nativescript 9.0.0-alpha.12 → 9.0.0-alpha.14

package/lib/common/mobile/android/android-application-manager.js

@@ -29,7 +29,7 @@ class AndroidApplicationManager extends application_manager_base_1.ApplicationMa
         this.$deviceLogProvider = $deviceLogProvider;
         this.$errors = $errors;
         this.PID_CHECK_INTERVAL = 100;
-        this.PID_CHECK_TIMEOUT = 10000;
+        this.PID_CHECK_TIMEOUT = 10000; // 10 secs
     }
     async getInstalledApplications() {
         const result = (await this.adb.executeShellCommand(["pm", "list", "packages"])) || "";
@@ -67,6 +67,7 @@ class AndroidApplicationManager extends application_manager_base_1.ApplicationMa
         }
     }
     uninstallApplication(appIdentifier) {
+        // Need to set the treatErrorsAsWarnings to true because when using `ns run` command if the application is not installed on the device it will throw error
         return this.adb.executeShellCommand(["pm", "uninstall", `${appIdentifier}`], { treatErrorsAsWarnings: true });
     }
     async startApplication(appData) {
@@ -75,9 +76,24 @@ class AndroidApplicationManager extends application_manager_base_1.ApplicationMa
                 `cat /dev/null > ${constants_1.LiveSyncPaths.ANDROID_TMP_DIR_NAME}/${appData.appId}-debugbreak`,
             ]);
         }
+        // If the app is debuggable, the Runtime will update the file when its ready for debugging
+        // and we will be able to take decisions and synchronize the debug experience based on the content
         await this.adb.executeShellCommand([
             `cat /dev/null > ${constants_1.LiveSyncPaths.ANDROID_TMP_DIR_NAME}/${appData.appId}-debugger-started`,
         ]);
+        /*
+        Example "pm dump <app_identifier> | grep -A 1 MAIN" output"
+            android.intent.action.MAIN:
+            3b2df03 org.nativescript.cliapp/com.tns.NativeScriptActivity filter 50dd82e
+            Action: "android.intent.action.MAIN"
+            Category: "android.intent.category.LAUNCHER"
+            --
+            intent={act=android.intent.action.MAIN cat=[android.intent.category.LAUNCHER] flg=0x10200000 cmp=org.nativescript.cliapp/com.tns.NativeScriptActivity}
+            realActivity=org.nativescript.cliapp/com.tns.NativeScriptActivity
+            --
+            Intent { act=android.intent.action.MAIN cat=[android.intent.category.LAUNCHER] flg=0x10200000 cmp=org.nativescript.cliapp/com.tns.NativeScriptActivity }
+            frontOfTask=true task=TaskRecord{fe592ac #449 A=org.nativescript.cliapp U=0 StackId=1 sz=1}
+        */
         const appIdentifier = appData.appId;
         const pmDumpOutput = await this.adb.executeShellCommand([
             "pm",
@@ -127,6 +143,8 @@ class AndroidApplicationManager extends application_manager_base_1.ApplicationMa
                     pid: processIdentifier,
                     appId: appIdentifier,
                     onAppRestarted: () => {
+                        // If the app restarts, we update the PID and
+                        // restart log helper.
                         this.onAppLaunch(appData);
                     },
                 });
@@ -205,3 +223,4 @@ __decorate([
 __decorate([
     (0, decorators_1.cache)()
 ], AndroidApplicationManager.prototype, "getFullyQualifiedActivityRegex", null);
+//# sourceMappingURL=android-application-manager.js.map

package/lib/common/mobile/android/android-debug-bridge-result-handler.js

@@ -330,3 +330,4 @@ AndroidDebugBridgeResultHandler.ANDROID_DEBUG_BRIDGE_ERRORS = [
     },
 ];
 yok_1.injector.register("androidDebugBridgeResultHandler", AndroidDebugBridgeResultHandler);
+//# sourceMappingURL=android-debug-bridge-result-handler.js.map

package/lib/common/mobile/android/android-debug-bridge.js

@@ -38,11 +38,15 @@ class AndroidDebugBridge {
                 return this.$childProcess.spawn(command.command, command.args);
             }
         }
+        // If adb -s <invalid device id> install <smth> is executed the childProcess won't get any response
+        // because the adb will be waiting for valid device and will not send close or exit event.
+        // For example `adb -s <invalid device id> install <smth>` throws error 'error: device \'030939f508e6c773\' not found\r\n' exitCode 4294967295
         const result = await this.$childProcess.spawnFromEvent(command.command, command.args, event, childProcessOptions, { throwError: false });
         const errors = this.$androidDebugBridgeResultHandler.checkForErrors(result);
         if (errors && errors.length > 0) {
             this.$androidDebugBridgeResultHandler.handleErrors(errors, treatErrorsAsWarnings);
         }
+        // Some adb commands returns array of strings instead of object with stdout and stderr. (adb start-server)
         return result.stdout === undefined || result.stdout === null
             ? result
             : result.stdout;
@@ -121,6 +125,7 @@ class AndroidDebugBridge {
     }
     async pushFile(localFilePath, deviceFilePath) {
         const fileDirectory = (0, helpers_1.fromWindowsRelativePathToUnix)(path.dirname(deviceFilePath));
+        // starting from API level 28, the push command is returning an error if the directory does not exist
         await this.executeShellCommand(["mkdir", "-p", fileDirectory]);
         await this.executeCommand(["push", localFilePath, deviceFilePath]);
         await this.executeShellCommand(["chmod", "0777", fileDirectory]);
@@ -140,3 +145,4 @@ __decorate([
     (0, decorators_1.invokeInit)()
 ], AndroidDebugBridge.prototype, "getDevices", null);
 yok_1.injector.register("adb", AndroidDebugBridge);
+//# sourceMappingURL=android-debug-bridge.js.map

package/lib/common/mobile/android/android-device-file-system.js

@@ -74,6 +74,8 @@ class AndroidDeviceFileSystem {
         return transferredFiles;
     }
     async transferDirectory(deviceAppData, localToDevicePaths, projectFilesPath) {
+        // starting from Android 9, adb push is throwing an exception when there are subfolders
+        // the check could be removed when we start supporting only runtime versions with sockets
         const minAndroidWithoutAdbPushDir = "9.0.0";
         const isAdbPushDirSupported = semver.lt(semver.coerce(deviceAppData.device.deviceInfo.version), minAndroidWithoutAdbPushDir);
         const deviceProjectDir = await deviceAppData.getDeviceProjectRootPath();
@@ -120,6 +122,7 @@ class AndroidDeviceFileSystem {
         const hostTmpDir = await this.$tempService.mkdirSync("application-");
         const commandsFileHostPath = path.join(hostTmpDir, "temp.commands.file");
         this.$fs.writeFile(commandsFileHostPath, fileContent);
+        // copy it to the device
         await this.transferFile(commandsFileHostPath, deviceFilePath);
         await this.adb.executeShellCommand(["chmod", "0777", deviceFilePath]);
     }
@@ -141,3 +144,4 @@ class AndroidDeviceFileSystem {
     }
 }
 exports.AndroidDeviceFileSystem = AndroidDeviceFileSystem;
+//# sourceMappingURL=android-device-file-system.js.map

package/lib/common/mobile/android/android-device-hash-service.js

@@ -51,6 +51,8 @@ class AndroidDeviceHashService {
         const action = async (localToDevicePathData) => {
             const localPath = localToDevicePathData.getLocalPath();
             if (this.$fs.getFsStats(localPath).isFile()) {
+                // TODO: Use relative to project path for key
+                // This will speed up livesync on the same device for the same project on different PCs.
                 initialShasums[localPath] = await this.$fs.getFileShasum(localPath);
             }
         };
@@ -106,3 +108,4 @@ __decorate([
 __decorate([
     (0, decorators_1.cache)()
 ], AndroidDeviceHashService.prototype, "getTempDir", null);
+//# sourceMappingURL=android-device-hash-service.js.map

package/lib/common/mobile/android/android-device.js

@@ -32,6 +32,8 @@ class AndroidDevice {
         this.fileSystem = this.$injector.resolve(fileSystemPath.AndroidDeviceFileSystem, { adb: this.adb });
         let details = await this.getDeviceDetails(["getprop"]);
         if (!details || !details.name) {
+            // In older CLI versions we are calling cat /system/build.prop to get details.
+            // Keep this logic for compatibility and possibly for devices for which getprop is not working
             details = await this.getDeviceDetails(["cat", "/system/build.prop"]);
         }
         this.$logger.trace(details);
@@ -88,6 +90,9 @@ class AndroidDevice {
         try {
             const details = await this.adb.executeShellCommand(shellCommandArgs);
             details.split(/\r?\n|\r/).forEach((value) => {
+                // sample line is "ro.build.version.release=4.4" in /system/build.prop
+                // sample line from getprop is:  [ro.build.version.release]: [6.0]
+                // NOTE: some props do not have value: [ro.build.version.base_os]: []
                 const match = /(?:\[?ro\.build\.version|ro\.product|ro\.build)\.(.+?)]?(?:\:|=)(?:\s*?\[)?(.*?)]?$/.exec(value);
                 if (match) {
                     parsedDetails[match[1]] = match[2];
@@ -101,6 +106,7 @@ class AndroidDevice {
         return parsedDetails;
     }
     getIsTablet(details) {
+        //version 3.x.x (also known as Honeycomb) is a tablet only version
         return (details &&
             (_.startsWith(details.release, "3.") ||
                 _.includes((details.characteristics || "").toLowerCase(), "tablet")));
@@ -114,6 +120,7 @@ class AndroidDevice {
     }
 }
 exports.AndroidDevice = AndroidDevice;
+// http://stackoverflow.com/questions/31178195/what-does-adb-device-status-mean
 AndroidDevice.ADB_DEVICE_STATUS_INFO = {
     device: {
         errorHelp: null,
@@ -139,3 +146,4 @@ AndroidDevice.ADB_DEVICE_STATUS_INFO = {
 __decorate([
     (0, decorators_1.cache)()
 ], AndroidDevice.prototype, "init", null);
+//# sourceMappingURL=android-device.js.map

package/lib/common/mobile/android/android-emulator-services.js

@@ -103,7 +103,7 @@ class AndroidEmulatorServices {
                     endTimeEpoch,
                 };
             }
-            await (0, helpers_1.sleep)(10000);
+            await (0, helpers_1.sleep)(10000); // the emulator definitely takes its time to wake up
             hasTimeLeft = (0, helpers_1.getCurrentEpochTime)() < endTimeEpoch;
         }
         if (!hasTimeLeft && !isInfiniteWait) {
@@ -180,3 +180,4 @@ class AndroidEmulatorServices {
 }
 exports.AndroidEmulatorServices = AndroidEmulatorServices;
 yok_1.injector.register("androidEmulatorServices", AndroidEmulatorServices);
+//# sourceMappingURL=android-emulator-services.js.map

package/lib/common/mobile/android/android-ini-file-parser.js

@@ -12,6 +12,8 @@ class AndroidIniFileParser {
         if (!this.$fs.exists(iniFilePath)) {
             return null;
         }
+        // avd files can have different encoding, defined on the first line.
+        // find which one it is (if any) and use it to correctly read the file contents
         const encoding = this.getAvdEncoding(iniFilePath);
         const contents = this.$fs.readText(iniFilePath, encoding).split("\n");
         return _.reduce(contents, (result, line) => {
@@ -44,6 +46,8 @@ class AndroidIniFileParser {
         }, Object.create(null));
     }
     getAvdEncoding(avdName) {
+        // avd files can have different encoding, defined on the first line.
+        // find which one it is (if any) and use it to correctly read the file contents
         let encoding = "utf8";
         let contents = this.$fs.readText(avdName, "ascii");
         if (contents.length > 0) {
@@ -57,18 +61,22 @@ class AndroidIniFileParser {
         }
         return encoding;
     }
+    // Android L is not written as a number in the .ini files, and we need to convert it
     readTargetNum(target) {
         const platform = target.replace("android-", "");
         let platformNumber = +platform;
         if (isNaN(platformNumber)) {
+            // this may be a google image
             const googlePlatform = target.split(":")[2];
             if (googlePlatform) {
                 platformNumber = +googlePlatform;
             }
             else if (platform === "L") {
+                // Android SDK 20 preview
                 platformNumber = 20;
             }
             else if (platform === "MNC") {
+                // Android M preview
                 platformNumber = 22;
             }
         }
@@ -77,3 +85,4 @@ class AndroidIniFileParser {
 }
 exports.AndroidIniFileParser = AndroidIniFileParser;
 yok_1.injector.register("androidIniFileParser", AndroidIniFileParser);
+//# sourceMappingURL=android-ini-file-parser.js.map

package/lib/common/mobile/android/android-log-filter.js

@@ -37,6 +37,10 @@ class AndroidLogFilter {
     }
 }
 exports.AndroidLogFilter = AndroidLogFilter;
+//sample line is "I/Web Console(    4438): Received Event: deviceready at file:///storage/emulated/0/Icenium/com.telerik.TestApp/js/index.js:48"
 AndroidLogFilter.LINE_REGEX = /.\/(.+?)\s*\(\s*\d+?\): (.*)/;
+// sample line is "11-23 12:39:07.310  1584  1597 I art     : Background sticky concurrent mark sweep GC freed 21966(1780KB) AllocSpace objects, 4(80KB) LOS objects, 77% free, 840KB/3MB, paused 4.018ms total 158.629ms"
+// or '12-28 10:45:08.020  3329  3329 W chromium: [WARNING:data_reduction_proxy_settings.cc(328)] SPDY proxy OFF at startup'
 AndroidLogFilter.API_LEVEL_23_LINE_REGEX = /.+?\s+?(?:[A-Z]\s+?)([A-Za-z \.]+?)\s*?\: (.*)/;
 yok_1.injector.register("androidLogFilter", AndroidLogFilter);
+//# sourceMappingURL=android-log-filter.js.map

package/lib/common/mobile/android/android-virtual-device-service.js

@@ -69,6 +69,9 @@ class AndroidVirtualDeviceService {
     get pathToEmulatorExecutable() {
         const emulatorExecutableName = "emulator";
         if (this.androidHome) {
+            // Check https://developer.android.com/studio/releases/sdk-tools.html (25.3.0)
+            // Since this version of SDK tools, the emulator is a separate package.
+            // However the emulator executable still exists in the "tools" dir.
             const pathToEmulatorFromAndroidStudio = path.join(this.androidHome, emulatorExecutableName, emulatorExecutableName);
             const realFilePath = this.$hostInfo.isWindows
                 ? `${pathToEmulatorFromAndroidStudio}.exe`
@@ -108,6 +111,17 @@ class AndroidVirtualDeviceService {
             client.on("data", (data) => {
                 output += data.toString();
                 const imageIdentifier = this.getImageIdentifierFromClientOutput(output);
+                // old output should look like:
+                // Android Console: type 'help' for a list of commands
+                // OK
+                // <Name of image>
+                // OK
+                // new output should look like:
+                // Android Console: type 'help' for a list of commands
+                // OK
+                // a\u001b[K\u001b[Dav\u001b[K\u001b[D\u001b[Davd\u001b...
+                // <Name of image>
+                // OK
                 if (imageIdentifier && !isResolved) {
                     this.mapEmulatorIdToImageIdentifier[emulatorId] = imageIdentifier;
                     this.clearNetConnection(client, timer);
@@ -159,6 +173,8 @@ class AndroidVirtualDeviceService {
         if (this.pathToAvdManagerExecutable &&
             this.$fs.exists(this.pathToAvdManagerExecutable)) {
             if (process.env.JAVA_HOME) {
+                // In case JAVA_HOME is set, but it points to incorrect directory (i.e. there's no java in $JAVA_HOME/bin/java), avdmanager will fail
+                // no matter if you have correct java in PATH.
                 canExecute = !!(await this.$sysInfo.getJavaVersionFromJavaHome());
             }
             else {
@@ -230,6 +246,13 @@ class AndroidVirtualDeviceService {
         const avdOutput = output.split(constants_1.AndroidVirtualDevice.AVAILABLE_AVDS_MESSAGE);
         const availableDevices = avdOutput && avdOutput[1] && avdOutput[1].trim();
         if (availableDevices) {
+            // In some cases `avdmanager list avds` command prints:
+            //	`The following Android Virtual Devices could not be loaded:
+            //	Name: Pixel_2_XL_API_28
+            //	Path: /Users/<username>/.android/avd/Pixel_2_XL_API_28.avd
+            //	Error: Google pixel_2_xl no longer exists as a device`
+            // These devices sometimes are valid so try to parse them.
+            // Also these devices are printed at the end of the output and are separated with 2 new lines from the valid devices output.
             const parts = availableDevices.split(/(?:\r?\n){2}/);
             const items = [parts[0], parts[1]].filter((item) => !!item);
             for (const item of items) {
@@ -246,6 +269,7 @@ class AndroidVirtualDeviceService {
     }
     getAvdManagerDeviceInfo(output) {
         const avdManagerDeviceInfo = Object.create(null);
+        // Split by `\n`, not EOL as the avdmanager and android executables print results with `\n` only even on Windows
         _.reduce(output.split("\n"), (result, row) => {
             const [key, value] = row.split(": ").map((part) => part.trim());
             switch (key) {
@@ -292,6 +316,7 @@ class AndroidVirtualDeviceService {
         };
     }
     getImageIdentifierFromClientOutput(output) {
+        // The lines should be trimmed after the split because the output has \r\n and when using split(EOL) on mac each line ends with \r.
         const lines = _.map(output.split(os_1.EOL), (line) => line.trim());
         const firstIndexOfOk = _.indexOf(lines, "OK");
         if (firstIndexOfOk < 0) {
@@ -340,3 +365,4 @@ __decorate([
     (0, decorators_1.cache)()
 ], AndroidVirtualDeviceService.prototype, "getConfigurationError", null);
 yok_1.injector.register("androidVirtualDeviceService", AndroidVirtualDeviceService);
+//# sourceMappingURL=android-virtual-device-service.js.map

package/lib/common/mobile/android/device-android-debug-bridge.js

@@ -30,3 +30,4 @@ class DeviceAndroidDebugBridge extends android_debug_bridge_1.AndroidDebugBridge
     }
 }
 exports.DeviceAndroidDebugBridge = DeviceAndroidDebugBridge;
+//# sourceMappingURL=device-android-debug-bridge.js.map

package/lib/common/mobile/android/genymotion/genymotion-service.js

@@ -42,6 +42,7 @@ class AndroidGenymotionService {
             .map(async (row) => {
             const match = row.match(/^(.+?)\s+device$/);
             if (match && match[1]) {
+                // possible genymotion emulator
                 const emulatorId = match[1];
                 const result = (await this.isGenymotionEmulator(emulatorId))
                     ? emulatorId
@@ -92,6 +93,7 @@ class AndroidGenymotionService {
         this.$emulatorHelper.setRunningAndroidEmulatorProperties(runningEmulatorId, runningEmulator);
         return runningEmulator;
     }
+    // https://wiki.appcelerator.org/display/guides2/Installing+Genymotion
     get playerSearchPaths() {
         return {
             darwin: [
@@ -133,13 +135,14 @@ class AndroidGenymotionService {
             vendor: constants_1.AndroidVirtualDevice.GENYMOTION_VENDOR_NAME,
             status: constants_1.NOT_RUNNING_EMULATOR_STATUS,
             errorHelp: [configurationError, error].filter((item) => !!item).join(os_1.EOL) || null,
-            isTablet: false,
+            isTablet: false, //TODO: Consider how to populate this correctly when the device is not running
             type: constants_1.DeviceTypes.Emulator,
             connectionTypes: [constants_2.DeviceConnectionType.Local],
             platform: this.$devicePlatformsConstants.Android,
         };
     }
     getSdkVersion(output) {
+        // Example -> Name: android_version, value: 6.0.0, timestamp: 1530090506102029000, flags:
         const androidApiLevelRow = output
             .split("\n")
             .filter((row) => !!row)
@@ -165,6 +168,7 @@ In case you have installed Genymotion in a different location, please add the pa
     }
     async getConfigurationError() {
         const result = await this.$childProcess.trySpawnFromCloseEvent(this.pathToEmulatorExecutable, [], {}, { throwError: false });
+        // When player is spawned, it always prints message on stderr.
         if (result &&
             result.stderr &&
             result.stderr.indexOf(constants_1.AndroidVirtualDevice.GENYMOTION_DEFAULT_STDERR_STRING) === -1) {
@@ -182,3 +186,4 @@ __decorate([
     (0, decorators_1.cache)()
 ], AndroidGenymotionService.prototype, "getConfigurationError", null);
 yok_1.injector.register("androidGenymotionService", AndroidGenymotionService);
+//# sourceMappingURL=genymotion-service.js.map

package/lib/common/mobile/android/genymotion/virtualbox-service.js

@@ -34,6 +34,7 @@ class VirtualBoxService {
                     .split(os_1.EOL)
                     .filter((row) => !!row)
                     .map((row) => {
+                    // Example row: "Google Nexus 4 - 5.0.0 - API 21 - 768x1280" {9d9beef2-cc60-4a54-bcc0-cc1dbf89811f}
                     const [rawName, rawId] = row.split('" ');
                     const id = rawId.substr(1, rawId.length - 2);
                     const name = rawName.substr(1, rawName.length - 1);
@@ -70,6 +71,15 @@ class VirtualBoxService {
         if (this.$hostInfo.isWindows) {
             let searchPath = null;
             try {
+                /* This can be used as interface!!!!
+                    arch:null
+                    hive:"HKLM"
+                    host:""
+                    key:"\Software\Oracle\VirtualBox"
+                    name:"InstallDir"
+                    type:"REG_SZ"
+                    value:"C:\Program Files\Oracle\VirtualBox\"
+                */
                 const result = await (0, helpers_1.getWinRegPropertyValue)("\\Software\\Oracle\\VirtualBox", "InstallDir");
                 searchPath = result && result.value ? result.value : null;
             }
@@ -102,3 +112,4 @@ __decorate([
     (0, decorators_1.cache)()
 ], VirtualBoxService.prototype, "getvBoxManagePath", null);
 yok_1.injector.register("virtualBoxService", VirtualBoxService);
+//# sourceMappingURL=virtualbox-service.js.map

package/lib/common/mobile/android/logcat-helper.js

@@ -40,6 +40,7 @@ class LogcatHelper {
                     }
                 }
                 catch (err) {
+                    // Ignore the error, the process is dead.
                 }
             });
             lineStream.on("data", (lineBuffer) => {
@@ -60,6 +61,7 @@ class LogcatHelper {
                     return;
                 const lines = (lineBuffer.toString() || "").split("\n");
                 for (let line of lines) {
+                    // 2024-06-26 16:43:22.286   630-659   ActivityManager system_server I  Start proc 8854:org.nativescript.uitestsapp/u0a190 for next-top-activity {org.nativescript.uitestsapp/com.tns.NativeScriptActivity}
                     const startProc = /Start proc (?<pid>[0-9]+):(?<appId>.+?)\//.exec(line);
                     if (startProc &&
                         ((_b = startProc.groups) === null || _b === void 0 ? void 0 : _b.appId) === options.appId &&
@@ -86,6 +88,9 @@ class LogcatHelper {
             lineStream.removeAllListeners();
         });
     }
+    /**
+     * Stops the logcat process for the specified device if keepSingleProcess is not passed on start
+     */
     stop(deviceIdentifier) {
         if (this.mapDevicesLoggingData[deviceIdentifier] &&
             !this.mapDevicesLoggingData[deviceIdentifier].keepSingleProcess) {
@@ -102,6 +107,9 @@ class LogcatHelper {
         (_e = loggingData.lineStream) === null || _e === void 0 ? void 0 : _e.removeAllListeners();
         delete this.mapDevicesLoggingData[deviceIdentifier];
     }
+    /**
+     * @deprecated - we likely don't need this anymore, and can simplify the code...
+     */
     async isLogcatPidSupported(deviceIdentifier) {
         const device = await this.$devicesService.getDevice(deviceIdentifier);
         const minAndroidWithLogcatPidSupport = "7.0.0";
@@ -111,6 +119,7 @@ class LogcatHelper {
     async getLogcatStream(deviceIdentifier, pid) {
         const isLogcatPidSupported = await this.isLogcatPidSupported(deviceIdentifier);
         const adb = this.$injector.resolve(device_android_debug_bridge_1.DeviceAndroidDebugBridge, { identifier: deviceIdentifier });
+        // -T 1 - shows only new logs after starting adb logcat
         const logcatCommand = ["logcat", "-T", "1"];
         const acceptedTags = [
             "chromium",
@@ -123,6 +132,7 @@ class LogcatHelper {
         if (pid && isLogcatPidSupported) {
             logcatCommand.push(`--pid=${pid}`);
             acceptedTags.forEach((tag) => {
+                // -s <tag> - shows only logs with the specified tag
                 logcatCommand.push("-s", tag);
             });
         }
@@ -133,6 +143,8 @@ class LogcatHelper {
     }
     async getAppStartTrackingLogcatStream(deviceIdentifier, appId) {
         const adb = this.$injector.resolve(device_android_debug_bridge_1.DeviceAndroidDebugBridge, { identifier: deviceIdentifier });
+        // -b system  - shows the system buffer/logs only
+        // -T 1 			- shows only new logs after starting adb logcat
         const logcatCommand = [
             `logcat`,
             `-b`,
@@ -153,3 +165,4 @@ class LogcatHelper {
 }
 exports.LogcatHelper = LogcatHelper;
 yok_1.injector.register("logcatHelper", LogcatHelper);
+//# sourceMappingURL=logcat-helper.js.map

package/lib/common/mobile/application-manager-base.js

@@ -36,6 +36,9 @@ class ApplicationManagerBase extends events_1.EventEmitter {
         if (!this.checkForApplicationUpdatesPromise) {
             this.checkForApplicationUpdatesPromise = new Promise(async (resolve, reject) => {
                 let isFulfilled = false;
+                // As this method is called on 500ms, but it's execution may last much longer
+                // use locking, so the next executions will not get into the body, while the first one is still working.
+                // In case we do not break the next executions, we'll report each app as newly installed several times.
                 try {
                     const currentlyInstalledAppIdentifiers = await this.getInstalledApplications();
                     const previouslyInstalledAppIdentifiers = this.lastInstalledAppIdentifiers || [];
@@ -80,6 +83,7 @@ class ApplicationManagerBase extends events_1.EventEmitter {
         _.each(notAvailableAppsForDebugging, (appInfo) => {
             this.emit("debuggableAppLost", appInfo);
             if (_.has(this.lastAvailableDebuggableAppViews, appInfo.appIdentifier)) {
+                // Prevent emitting debuggableViewLost when application cannot be debugged anymore.
                 delete this.lastAvailableDebuggableAppViews[appInfo.appIdentifier];
             }
         });
@@ -98,6 +102,7 @@ class ApplicationManagerBase extends events_1.EventEmitter {
             _.each(newAvailableViews, (debugWebViewInfo) => {
                 this.emit("debuggableViewFound", appIdentifier, debugWebViewInfo);
             });
+            // Determine which of the views had changed since last check and raise debuggableViewChanged event for them:
             const keptViews = _.differenceBy(currentlyAvailableViews, newAvailableViews, "id");
             _.each(keptViews, (view) => {
                 const previousTimeViewInfo = _.find(previouslyAvailableViews, (previousView) => previousView.id === view.id);
@@ -111,3 +116,4 @@ class ApplicationManagerBase extends events_1.EventEmitter {
     }
 }
 exports.ApplicationManagerBase = ApplicationManagerBase;
+//# sourceMappingURL=application-manager-base.js.map

package/lib/common/mobile/device-emitter.js

@@ -15,7 +15,10 @@ class DeviceEmitter extends events_1.EventEmitter {
         this.$devicesService.on(constants_1.DeviceDiscoveryEventNames.DEVICE_FOUND, (device) => {
             this.emit(constants_1.DeviceDiscoveryEventNames.DEVICE_FOUND, device.deviceInfo);
             this.attachApplicationChangedHandlers(device);
+            // await: Do not await as this will require to mark the lambda with async keyword, but there's no way to await the lambda itself.
+            /* tslint:disable:no-floating-promises */
             device.openDeviceLogStream();
+            /* tslint:enable:no-floating-promises */
         });
         this.$devicesService.on(constants_1.DeviceDiscoveryEventNames.DEVICE_LOST, (device) => {
             this.emit(constants_1.DeviceDiscoveryEventNames.DEVICE_LOST, device.deviceInfo);
@@ -59,3 +62,4 @@ class DeviceEmitter extends events_1.EventEmitter {
 }
 exports.DeviceEmitter = DeviceEmitter;
 yok_1.injector.register("deviceEmitter", DeviceEmitter);
+//# sourceMappingURL=device-emitter.js.map

package/lib/common/mobile/device-log-emitter.js

@@ -38,3 +38,4 @@ class DeviceLogEmitter extends device_log_provider_base_1.DeviceLogProviderBase
 }
 exports.DeviceLogEmitter = DeviceLogEmitter;
 yok_1.injector.register("deviceLogProvider", DeviceLogEmitter);
+//# sourceMappingURL=device-log-emitter.js.map

package/lib/common/mobile/device-log-provider-base.js

@@ -63,3 +63,4 @@ class DeviceLogProviderBase extends events_1.EventEmitter {
     }
 }
 exports.DeviceLogProviderBase = DeviceLogProviderBase;
+//# sourceMappingURL=device-log-provider-base.js.map

package/lib/common/mobile/device-log-provider.js

@@ -35,6 +35,7 @@ class DeviceLogProvider extends device_log_provider_base_1.DeviceLogProviderBase
         this.colorPoolIndex = 0;
     }
     logData(lineText, platform, deviceIdentifier) {
+        // console.log(lineText)
         const loggingOptions = this.getDeviceLogOptionsForDevice(deviceIdentifier);
         let data = this.$logFilter.filterData(platform, lineText, loggingOptions);
         data = this.$logSourceMapService.replaceWithOriginalFileLocations(platform, data, loggingOptions);
@@ -52,6 +53,7 @@ class DeviceLogProvider extends device_log_provider_base_1.DeviceLogProviderBase
             return this.deviceColorMap.get(deviceIdentifier);
         }
         const color = this.colorPool[this.colorPoolIndex];
+        // wrap around if we have no more colors in the pool
         this.colorPoolIndex =
             this.colorPoolIndex === this.colorPool.length - 1
                 ? 0
@@ -61,10 +63,13 @@ class DeviceLogProvider extends device_log_provider_base_1.DeviceLogProviderBase
     }
     logDataCore(data, deviceIdentifier) {
         var _a, _b, _c;
+        // todo: use config to set logger - --env.classicLogs is temporary!
         if ("classicLogs" in ((_a = this.$options.env) !== null && _a !== void 0 ? _a : {})) {
+            // legacy logging
             this.$logger.info(data, { [constants_2.LoggerConfigData.skipNewLine]: true });
             return;
         }
+        // todo: extract into an injectable printer/logger service
         let shouldPrepend = false;
         let splitIndexes = [];
         const lines = data
@@ -119,7 +124,25 @@ class DeviceLogProvider extends device_log_provider_base_1.DeviceLogProviderBase
     printLine(prefix, ...parts) {
         const fullLine = parts.join(" ");
         console.log(prefix, fullLine);
+        /**
+         * Note: Disabled
+         *
+         * This splits the output into lines that fit within the current
+         * terminal width, however this makes copying json objects that
+         * span across multiple lines difficult, as it introduces
+         * whitespace & line breaks
+         */
+        // const maxWidth = process.stdout.columns - 2;
+        // if (!maxWidth || maxWidth < 10 || fullLine.length < maxWidth) {
+        // 	console.log(prefix, fullLine);
+        // } else {
+        // 	for (let i = 0; i < fullLine.length; i += maxWidth) {
+        // 		const part = fullLine.substring(i, i + maxWidth);
+        // 		console.log(prefix, part);
+        // 	}
+        // }
     }
 }
 exports.DeviceLogProvider = DeviceLogProvider;
 yok_1.injector.register("deviceLogProvider", DeviceLogProvider);
+//# sourceMappingURL=device-log-provider.js.map

package/lib/common/mobile/device-platforms-constants.js

@@ -20,3 +20,4 @@ class DevicePlatformsConstants {
 }
 exports.DevicePlatformsConstants = DevicePlatformsConstants;
 yok_1.injector.register("devicePlatformsConstants", DevicePlatformsConstants);
+//# sourceMappingURL=device-platforms-constants.js.map

package/lib/common/mobile/emulator-helper.js

@@ -6,6 +6,7 @@ const _ = require("lodash");
 const yok_1 = require("../yok");
 class EmulatorHelper {
     constructor() {
+        // https://developer.android.com/guide/topics/manifest/uses-sdk-element
         this.mapAndroidApiLevelToVersion = {
             "android-36": "16.0.0",
             "android-35": "15.0.0",
@@ -80,7 +81,9 @@ class EmulatorHelper {
         emulator.identifier = emulatorId;
         emulator.status = constants_1.RUNNING_EMULATOR_STATUS;
         emulator.type = constants_1.DeviceTypes.Device;
+        //emulator.isTablet; // TODO: consider to do this here!!!
     }
 }
 exports.EmulatorHelper = EmulatorHelper;
 yok_1.injector.register("emulatorHelper", EmulatorHelper);
+//# sourceMappingURL=emulator-helper.js.map

package/lib/common/mobile/ios/device/ios-application-manager.js

@@ -115,9 +115,11 @@ class IOSApplicationManager extends application_manager_base_1.ApplicationManage
         await this.device.openDeviceLogStream();
     }
     getDebuggableApps() {
+        // Implement when we can find debuggable applications for iOS.
         return Promise.resolve([]);
     }
     getDebuggableAppViews(appIdentifiers) {
+        // Implement when we can find debuggable applications for iOS.
         return Promise.resolve(null);
     }
 }
@@ -128,3 +130,4 @@ __decorate([
 __decorate([
     (0, decorators_1.cache)()
 ], IOSApplicationManager.prototype, "startDeviceLog", null);
+//# sourceMappingURL=ios-application-manager.js.map

package/lib/common/mobile/ios/device/ios-device-file-system.js

@@ -104,3 +104,4 @@ class IOSDeviceFileSystem {
 }
 exports.IOSDeviceFileSystem = IOSDeviceFileSystem;
 IOSDeviceFileSystem.AFC_DELETE_FILE_NOT_FOUND_ERROR = 8;
+//# sourceMappingURL=ios-device-file-system.js.map

package/lib/common/mobile/ios/device/ios-device-operations.js

@@ -44,6 +44,7 @@ class IOSDeviceOperations extends events_1.EventEmitter {
             if (options && options.shouldReturnImmediateResult) {
                 return;
             }
+            // We need this because we need to make sure that we have devices.
             await new Promise((resolve, reject) => {
                 let iterationsCount = 0;
                 const maxIterationsCount = 3;
@@ -125,6 +126,8 @@ class IOSDeviceOperations extends events_1.EventEmitter {
         return this.getMultipleResults(() => this.deviceLib.stop(stopArray), errorHandler);
     }
     dispose(signal) {
+        // We need to check if we should dispose the device lib.
+        // For example we do not want to dispose it when we start printing the device logs.
         if (this.shouldDispose && this.deviceLib) {
             this.deviceLib.removeAllListeners();
             this.deviceLib.dispose(signal);
@@ -195,3 +198,4 @@ __decorate([
     (0, decorators_1.cache)()
 ], IOSDeviceOperations.prototype, "attacheDeviceLogDataHandler", null);
 yok_1.injector.register("iosDeviceOperations", IOSDeviceOperations);
+//# sourceMappingURL=ios-device-operations.js.map