nativescript 9.0.0-alpha.12 → 9.0.0-alpha.14

package/lib/services/bundler/bundler-compiler-service.js

@@ -10,14 +10,17 @@ exports.BundlerCompilerService = void 0;
 const path = require("path");
 const semver = require("semver");
 const _ = require("lodash");
+// TODO: can switch to file-system service
 const events_1 = require("events");
 const decorators_1 = require("../../common/decorators");
 const constants_1 = require("../../constants");
 const yok_1 = require("../../common/yok");
 const package_path_helper_1 = require("../../helpers/package-path-helper");
+/* for specific bundling debugging separate from logger */
 const debugLog = false;
 class BundlerCompilerService extends events_1.EventEmitter {
-    constructor($options, $errors, $childProcess, $fs, $hooksService, $hostInfo, $logger, $mobileHelper, $cleanupService, $packageManager, $packageInstallationManager, $projectConfigService) {
+    constructor($options, $errors, $childProcess, $fs, $hooksService, $hostInfo, $logger, $mobileHelper, $cleanupService, $packageManager, $packageInstallationManager, // private $sharedEventBus: ISharedEventBus
+    $projectConfigService) {
         super();
         this.$options = $options;
         this.$errors = $errors;
@@ -44,6 +47,7 @@ class BundlerCompilerService extends events_1.EventEmitter {
             prepareData.watch = true;
             try {
                 const childProcess = await this.startBundleProcess(platformData, projectData, prepareData);
+                // Handle Vite differently from webpack
                 const isVite = this.getBundler() === "vite";
                 childProcess.stdout.on("data", function (data) {
                     process.stdout.write(data);
@@ -51,8 +55,11 @@ class BundlerCompilerService extends events_1.EventEmitter {
                 childProcess.stderr.on("data", function (data) {
                     process.stderr.write(data);
                 });
+                // For both Vite and webpack, we wait for the first build to complete
+                // Don't resolve immediately for Vite - wait for first IPC message
                 childProcess.on("message", (message) => {
                     this.$logger.trace(`Message from ${projectData.bundler}`, message);
+                    // Handle Vite messages
                     if (isVite &&
                         message &&
                         message.emittedFiles) {
@@ -60,53 +67,30 @@ class BundlerCompilerService extends events_1.EventEmitter {
                         if (debugLog) {
                             console.log("Received Vite IPC message:", message);
                         }
-                        const distOutput = path.join(projectData.projectDir, "dist");
+                        // Copy Vite output files directly to platform destination
+                        const distOutput = path.join(projectData.projectDir, ".ns-vite-build");
                         const destDir = path.join(platformData.appDestinationDirectoryPath, this.$options.hostProjectModuleName);
                         if (debugLog) {
-                            console.log(`🔥 Copying from ${distOutput} to ${destDir}`);
+                            console.log(`Copying from ${distOutput} to ${destDir}.`);
                         }
-                        if (message.isHMR) {
+                        // Determine which files to copy based on build type and changes
+                        if (message.buildType === "incremental" &&
+                            message.emittedFiles &&
+                            message.emittedFiles.length > 0) {
+                            // Incremental builds: only copy files that are likely affected by the changes
+                            const filesToCopy = this.getIncrementalFilesToCopy(message.emittedFiles);
                             if (debugLog) {
-                                console.log("🔥 HMR update - copying only changed files for:", message.changedFiles);
-                            }
-                            let filesToCopy = message.emittedFiles;
-                            const hasHTMLChanges = message.changedFiles.some((f) => f.endsWith(".html"));
-                            if (hasHTMLChanges) {
-                                filesToCopy = message.emittedFiles.filter((f) => f.includes(".component") ||
-                                    f === "bundle.mjs" ||
-                                    f === "bundle.mjs.map");
-                                if (debugLog) {
-                                    console.log("🔥 HTML change detected - copying component files:", filesToCopy);
-                                }
-                            }
-                            this.copyViteBundleToNative(distOutput, destDir, filesToCopy);
-                        }
-                        else if (message.buildType === "incremental" &&
-                            message.changedFiles &&
-                            message.changedFiles.length > 0) {
-                            if (debugLog) {
-                                console.log("🔥 Incremental build - copying only relevant files for:", message.changedFiles);
-                            }
-                            const filesToCopy = this.getIncrementalFilesToCopy(message.emittedFiles, message.changedFiles);
-                            if (debugLog) {
-                                console.log("🔥 Incremental build - files to copy:", filesToCopy);
+                                console.log("Incremental build - files to copy:", filesToCopy);
                             }
                             this.copyViteBundleToNative(distOutput, destDir, filesToCopy);
                         }
-                        else if (message.buildType === "incremental" &&
-                            message.changedFiles &&
-                            message.changedFiles.length > 0) {
-                            console.log("🔥 Incremental build - copying only relevant files for:", message.changedFiles);
-                            const filesToCopy = this.getIncrementalFilesToCopy(message.emittedFiles, message.changedFiles);
-                            console.log("🔥 Incremental build - files to copy:", filesToCopy);
-                            this.copyViteBundleToNative(distOutput, destDir, filesToCopy);
-                        }
                         else {
                             if (debugLog) {
-                                console.log("🔥 Full build - copying all files");
+                                console.log("Full build - copying all files.");
                             }
                             this.copyViteBundleToNative(distOutput, destDir);
                         }
+                        // Resolve the promise on first build completion
                         if (isFirstBundlerWatchCompilation) {
                             isFirstBundlerWatchCompilation = false;
                             if (debugLog) {
@@ -114,6 +98,7 @@ class BundlerCompilerService extends events_1.EventEmitter {
                             }
                             resolve(childProcess);
                         }
+                        // Transform Vite message to match webpack format
                         const files = message.emittedFiles.map((file) => path.join(platformData.appDestinationDirectoryPath, this.$options.hostProjectModuleName, file));
                         const data = {
                             files,
@@ -125,34 +110,29 @@ class BundlerCompilerService extends events_1.EventEmitter {
                             platform: platformData.platformNameLowerCase,
                         };
                         this.$logger.info(`Vite build completed! Files copied to native platform.`);
-                        this.notifyHMRClients({
-                            type: message.isHMR ? "js-update" : "build-complete",
-                            timestamp: Date.now(),
-                            changedFiles: message.changedFiles || [],
-                            buildType: message.buildType || "incremental",
-                            isHMR: message.isHMR || false,
-                        });
-                        if (message.isHMR) {
-                            if (debugLog) {
-                                console.log("🔥 Skipping BUNDLER_COMPILATION_COMPLETE for HMR update - app will not restart");
-                            }
-                        }
-                        else {
-                            if (debugLog) {
-                                console.log("🔥 Emitting BUNDLER_COMPILATION_COMPLETE for full build");
-                            }
-                            this.emit(constants_1.BUNDLER_COMPILATION_COMPLETE, data);
+                        if (debugLog) {
+                            console.log("Emitting BUNDLER_COMPILATION_COMPLETE for full build.");
                         }
+                        this.emit(constants_1.BUNDLER_COMPILATION_COMPLETE, data);
                         return;
                     }
+                    // if we are on webpack5 - we handle HMR in a  slightly different way
                     if (typeof message === "object" &&
                         "version" in message &&
                         "type" in message) {
+                        // first compilation can be ignored because it will be synced regardless
+                        // handling it here would trigger 2 syncs
                         if (isFirstBundlerWatchCompilation) {
                             isFirstBundlerWatchCompilation = false;
                             resolve(childProcess);
                             return;
                         }
+                        // if ((message as IWebpackMessage).type === "hmr-status") {
+                        // 	// we pass message through our event-bus to be handled wherever needed
+                        // 	// in this case webpack-hmr-status-service listens for this event
+                        // 	this.$sharedEventBus.emit("webpack:hmr-status", message);
+                        // 	return;
+                        // }
                         return this.handleHMRMessage(message, platformData, projectData, prepareData);
                     }
                     if (message ===
@@ -168,6 +148,7 @@ class BundlerCompilerService extends events_1.EventEmitter {
                                 prepareData.hmr ? message.hash : "";
                             return;
                         }
+                        // Persist the previousHash value before calling `this.getUpdatedEmittedFiles` as it will modify the expectedHashes object with the current hash
                         const previousHash = this.expectedHashes[platformData.platformNameLowerCase];
                         let result;
                         if (prepareData.hmr) {
@@ -192,6 +173,7 @@ class BundlerCompilerService extends events_1.EventEmitter {
                             platform: platformData.platformNameLowerCase,
                         };
                         this.$logger.trace(`Generated data from ${projectData.bundler} message:`, data);
+                        // the hash of the compilation is the same as the previous one and there are only hot updates produced
                         if (data.hasOnlyHotUpdateFiles && previousHash === message.hash) {
                             return;
                         }
@@ -264,6 +246,9 @@ class BundlerCompilerService extends events_1.EventEmitter {
         }
     }
     async shouldUsePreserveSymlinksOption() {
+        // pnpm does not require symlink (https://github.com/nodejs/node-eps/issues/46#issuecomment-277373566)
+        // and it also does not work in some cases.
+        // Check https://github.com/NativeScript/nativescript-cli/issues/5259 for more information
         const currentPackageManager = await this.$packageManager.getPackageManagerName();
         const res = currentPackageManager !== constants_1.PackageManagers.pnpm;
         return res;
@@ -282,6 +267,7 @@ class BundlerCompilerService extends events_1.EventEmitter {
         const envData = this.buildEnvData(platformData.platformNameLowerCase, projectData, prepareData);
         const isVite = this.getBundler() === "vite";
         const cliArgs = await this.buildEnvCommandLineParams(envData, platformData, projectData, prepareData);
+        // Note: With Vite, we need `--` to prevent vite cli from erroring on unknown options.
         const envParams = isVite
             ? [
                 `--mode=${prepareData.release ? "production" : "development"}`,
@@ -300,7 +286,7 @@ class BundlerCompilerService extends events_1.EventEmitter {
         const args = [
             ...additionalNodeArgs,
             this.getBundlerExecutablePath(projectData),
-            isVite ? "build" : this.isModernBundler(projectData) ? `build` : null,
+            isVite || this.isModernBundler(projectData) ? "build" : null,
             `--config=${projectData.bundlerConfigPath}`,
             ...envParams,
         ].filter(Boolean);
@@ -349,16 +335,28 @@ class BundlerCompilerService extends events_1.EventEmitter {
         });
         envData.verbose = envData.verbose || this.$logger.isVerbose();
         envData.production = envData.production || prepareData.release;
+        // add the config file name to the env data so the webpack process can read the
+        // correct config file when resolving the CLI lib and the config service
+        // we are explicitly setting it to false to force using the defaults
         envData.config =
             (_b = (_a = process.env.NATIVESCRIPT_CONFIG_NAME) !== null && _a !== void 0 ? _a : this.$options.config) !== null && _b !== void 0 ? _b : "false";
+        // explicitly set the env variable
         process.env.NATIVESCRIPT_CONFIG_NAME = envData.config;
+        // The snapshot generation is wrongly located in the Webpack plugin.
+        // It should be moved in the Native Prepare of the CLI or a Gradle task in the Runtime.
+        // As a workaround, we skip the mksnapshot, xxd and android-ndk calls based on skipNativePrepare.
+        // In this way the plugin will prepare only the snapshot JS entry without any native prepare and
+        // we will able to execute cloud builds with snapshot without having any local snapshot or Docker setup.
+        // TODO: Remove this flag when we remove the native part from the plugin.
         envData.skipSnapshotTools =
             prepareData.nativePrepare && prepareData.nativePrepare.skipNativePrepare;
+        // only set sourceMap if not explicitly set through a flag
         if (typeof ((_c = prepareData === null || prepareData === void 0 ? void 0 : prepareData.env) === null || _c === void 0 ? void 0 : _c.sourceMap) === "undefined") {
             if (!prepareData.release) {
                 envData.sourceMap = true;
             }
         }
+        // convert string to boolean
         if (envData.sourceMap === "true" || envData.sourceMap === "false") {
             envData.sourceMap = envData.sourceMap === "true";
         }
@@ -379,6 +377,7 @@ class BundlerCompilerService extends events_1.EventEmitter {
             }
             else if (this.$hostInfo.isWindows) {
                 if (projectData.bundler === "webpack") {
+                    //TODO: check this use case for webpack5 WEBPACK_PLUGIN_NAME
                     const minWebpackPluginWithWinSnapshotsVersion = "1.3.0";
                     const installedWebpackPluginVersion = await this.$packageInstallationManager.getInstalledDependencyVersion(constants_1.WEBPACK_PLUGIN_NAME, projectData.projectDir);
                     const hasWebpackPluginWithWinSnapshotsSupport = !!installedWebpackPluginVersion
@@ -412,6 +411,15 @@ class BundlerCompilerService extends events_1.EventEmitter {
     }
     getUpdatedEmittedFiles(allEmittedFiles, chunkFiles, nextHash, platform) {
         const currentHash = this.getCurrentHotUpdateHash(allEmittedFiles);
+        // This logic is needed as there are already cases when webpack doesn't emit any files physically.
+        // We've set noEmitOnErrors in webpack.config.js based on noEmitOnError from tsconfig.json,
+        // so webpack doesn't emit any files when noEmitOnErrors: true is set in webpack.config.js and
+        // there is a compilation error in the source code. On the other side, hmr generates new hot-update files
+        // on every change and the hash of the next hmr update is written inside hot-update.json file.
+        // Although webpack doesn't emit any files, hmr hash is still generated. The hash is generated per compilation no matter
+        // if files will be emitted or not. This way, the first successful compilation after fixing the compilation error generates
+        // a hash that is not the same as the one expected in the latest emitted hot-update.json file.
+        // As a result, the hmr chain is broken and the changes are not applied.
         const isHashValid = nextHash
             ? this.expectedHashes[platform] === currentHash
             : true;
@@ -430,6 +438,7 @@ class BundlerCompilerService extends events_1.EventEmitter {
         let hotHash;
         const hotUpdateScripts = emittedFiles.filter((x) => x.endsWith(".hot-update.js"));
         if (hotUpdateScripts && hotUpdateScripts.length) {
+            // the hash is the same for each hot update in the current compilation
             const hotUpdateName = hotUpdateScripts[0];
             const matcher = /^(.+)\.(.+)\.hot-update/gm;
             const matches = matcher.exec(hotUpdateName);
@@ -447,6 +456,7 @@ class BundlerCompilerService extends events_1.EventEmitter {
         }
     }
     handleHMRMessage(message, platformData, projectData, prepareData) {
+        // handle new bundler hmr packets
         this.$logger.trace(`Received message from ${projectData.bundler} process:`, message);
         if (message.type !== "compilation") {
             return;
@@ -454,6 +464,7 @@ class BundlerCompilerService extends events_1.EventEmitter {
         this.$logger.trace(`${capitalizeFirstLetter(projectData.bundler)} build done!`);
         const files = message.data.emittedAssets.map((asset) => path.join(platformData.appDestinationDirectoryPath, this.$options.hostProjectModuleName, asset));
         const staleFiles = message.data.staleAssets.map((asset) => path.join(platformData.appDestinationDirectoryPath, this.$options.hostProjectModuleName, asset));
+        // extract last hash from emitted filenames
         const lastHash = (() => {
             const absoluteFileNameWithLastHash = files.find((fileName) => fileName.endsWith("hot-update.js"));
             if (!absoluteFileNameWithLastHash) {
@@ -466,6 +477,7 @@ class BundlerCompilerService extends events_1.EventEmitter {
             }
         })();
         if (!files.length) {
+            // ignore compilations if no new files are emitted
             return;
         }
         this.emit(constants_1.BUNDLER_COMPILATION_COMPLETE, {
@@ -529,38 +541,45 @@ class BundlerCompilerService extends events_1.EventEmitter {
         return this.$projectConfigService.getValue(`bundler`, "webpack");
     }
     copyViteBundleToNative(distOutput, destDir, specificFiles = null) {
+        // Clean and copy Vite output to native platform folder
         if (debugLog) {
-            console.log(`Copying Vite bundle from "${distOutput}" to "${destDir}"`);
+            console.log(`Copying Vite bundle from "${distOutput}" to "${destDir}".`);
         }
-        const fs = require("fs");
         try {
             if (specificFiles) {
+                // Selective mode: only copy specific files (incremental)
                 if (debugLog) {
-                    console.log("🔥 Selective copy - copying specific files:", specificFiles);
+                    console.log("Selective copy - copying specific files:", specificFiles);
                 }
-                fs.mkdirSync(destDir, { recursive: true });
+                // Ensure destination directory exists
+                this.$fs.createDirectory(destDir);
+                // Copy only the specified files
                 for (const file of specificFiles) {
                     const srcPath = path.join(distOutput, file);
                     const destPath = path.join(destDir, file);
-                    if (!fs.existsSync(srcPath))
+                    if (!this.$fs.exists(srcPath))
                         continue;
-                    fs.mkdirSync(path.dirname(destPath), { recursive: true });
-                    fs.copyFileSync(srcPath, destPath);
+                    // create parent dirs
+                    this.$fs.createDirectory(path.dirname(destPath));
+                    this.$fs.copyFile(srcPath, destPath);
                     if (debugLog) {
-                        console.log(`🔥 Copied ${file}`);
+                        console.log(`Copied ${file}`);
                     }
                 }
             }
             else {
+                // Full build mode: clean and copy everything
                 if (debugLog) {
-                    console.log("🔥 Full build: Copying all files");
+                    console.log("Full build: Copying all files.");
                 }
-                if (fs.existsSync(destDir)) {
-                    fs.rmSync(destDir, { recursive: true, force: true });
+                // Clean destination directory
+                if (this.$fs.exists(destDir)) {
+                    this.$fs.deleteDirectory(destDir);
                 }
-                fs.mkdirSync(destDir, { recursive: true });
-                if (fs.existsSync(distOutput)) {
-                    this.copyRecursiveSync(distOutput, destDir, fs);
+                this.$fs.createDirectory(destDir);
+                // Copy all files from dist to platform destination
+                if (this.$fs.exists(distOutput)) {
+                    this.copyRecursiveSync(distOutput, destDir);
                 }
                 else {
                     this.$logger.warn(`Vite output directory does not exist: ${distOutput}`);
@@ -571,62 +590,42 @@ class BundlerCompilerService extends events_1.EventEmitter {
             this.$logger.warn(`Failed to copy Vite bundle: ${error.message}`);
         }
     }
-    getIncrementalFilesToCopy(emittedFiles, changedFiles) {
+    getIncrementalFilesToCopy(emittedFiles) {
+        // For incremental builds, we need to determine which emitted files are likely affected
+        // by the source file changes
         const filesToCopy = [];
+        // default to ignoring vendor files as they are less likely to change during live reloads
         const bundleFiles = emittedFiles.filter((file) => !file.includes("vendor") &&
-            (file.includes("bundle") ||
-                file.includes("main") ||
-                file.includes("app") ||
-                file.endsWith(".mjs") ||
-                file.endsWith(".js")));
+            (file.endsWith(".mjs") ||
+                file.endsWith(".js") ||
+                file.endsWith(".map")));
         filesToCopy.push(...bundleFiles);
-        const sourceMapFiles = emittedFiles.filter((file) => !file.includes("vendor") && file.endsWith(".map"));
-        filesToCopy.push(...sourceMapFiles);
-        const hasAssetChanges = changedFiles.some((file) => file.includes("/assets/") ||
-            file.includes("/static/") ||
-            file.includes("/public/"));
-        if (hasAssetChanges) {
-            const assetFiles = emittedFiles.filter((file) => file.includes("assets/") ||
-                file.includes("static/") ||
-                file.includes("fonts/") ||
-                file.includes("images/"));
+        // Only copy assets if there are explicit asset-related changes
+        const assetFiles = emittedFiles.filter((file) => file.includes("assets/") ||
+            file.includes("static/") ||
+            file.includes("fonts/") ||
+            file.includes("images/"));
+        if (assetFiles.length > 0) {
             filesToCopy.push(...assetFiles);
         }
+        // Remove duplicates and return
         return [...new Set(filesToCopy)];
     }
-    notifyHMRClients(message) {
-        try {
-            const WebSocket = require("ws");
-            const ws = new WebSocket("ws://localhost:24678");
-            ws.on("open", () => {
-                if (debugLog) {
-                    console.log("🔥 Sending HMR notification to bridge:", message.type);
-                }
-                ws.send(JSON.stringify(message));
-                ws.close();
-            });
-            ws.on("error", () => {
-                if (debugLog) {
-                    console.log("🔥 HMR bridge not available (this is normal without HMR)");
-                }
-            });
-        }
-        catch (error) {
-            if (debugLog) {
-                console.log("🔥 WebSocket not available for HMR notifications");
-            }
-        }
-    }
-    copyRecursiveSync(src, dest, fs) {
-        for (const entry of fs.readdirSync(src, { withFileTypes: true })) {
-            const srcPath = path.join(src, entry.name);
-            const destPath = path.join(dest, entry.name);
-            if (entry.isDirectory()) {
-                fs.mkdirSync(destPath, { recursive: true });
-                this.copyRecursiveSync(srcPath, destPath, fs);
+    copyRecursiveSync(src, dest) {
+        // Ensure destination exists
+        this.$fs.createDirectory(dest);
+        const entries = this.$fs.readDirectory(src);
+        for (const name of entries) {
+            const srcPath = path.join(src, name);
+            const destPath = path.join(dest, name);
+            const lstats = this.$fs.getLsStats(srcPath);
+            if (lstats.isDirectory()) {
+                this.copyRecursiveSync(srcPath, destPath);
             }
-            else if (entry.isFile() || entry.isSymbolicLink()) {
-                fs.copyFileSync(srcPath, destPath);
+            else if (lstats.isFile() || lstats.isSymbolicLink()) {
+                // create parent directory (copyFile will also ensure it, but keep explicit)
+                this.$fs.createDirectory(path.dirname(destPath));
+                this.$fs.copyFile(srcPath, destPath);
             }
         }
     }
@@ -639,3 +638,4 @@ function capitalizeFirstLetter(val) {
     return String(val).charAt(0).toUpperCase() + String(val).slice(1);
 }
 yok_1.injector.register("bundlerCompilerService", BundlerCompilerService);
+//# sourceMappingURL=bundler-compiler-service.js.map

package/lib/services/bundler/bundler.js

@@ -1,2 +1,3 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
+//# sourceMappingURL=bundler.js.map

package/lib/services/cleanup-service.js

@@ -20,56 +20,56 @@ class CleanupService {
     async addCleanupCommand(commandInfo) {
         const cleanupProcess = await this.getCleanupProcess();
         cleanupProcess.send({
-            messageType: "AddCleanCommand",
+            messageType: "AddCleanCommand" /* CleanupProcessMessage.AddCleanCommand */,
             commandInfo,
         });
     }
     async removeCleanupCommand(commandInfo) {
         const cleanupProcess = await this.getCleanupProcess();
         cleanupProcess.send({
-            messageType: "RemoveCleanCommand",
+            messageType: "RemoveCleanCommand" /* CleanupProcessMessage.RemoveCleanCommand */,
             commandInfo,
         });
     }
     async addRequest(requestInfo) {
         const cleanupProcess = await this.getCleanupProcess();
         cleanupProcess.send({
-            messageType: "AddRequest",
+            messageType: "AddRequest" /* CleanupProcessMessage.AddRequest */,
             requestInfo,
         });
     }
     async removeRequest(requestInfo) {
         const cleanupProcess = await this.getCleanupProcess();
         cleanupProcess.send({
-            messageType: "RemoveRequest",
+            messageType: "RemoveRequest" /* CleanupProcessMessage.RemoveRequest */,
             requestInfo,
         });
     }
     async addCleanupDeleteAction(filePath) {
         const cleanupProcess = await this.getCleanupProcess();
         cleanupProcess.send({
-            messageType: "AddDeleteFileAction",
+            messageType: "AddDeleteFileAction" /* CleanupProcessMessage.AddDeleteFileAction */,
             filePath,
         });
     }
     async removeCleanupDeleteAction(filePath) {
         const cleanupProcess = await this.getCleanupProcess();
         cleanupProcess.send({
-            messageType: "RemoveDeleteFileAction",
+            messageType: "RemoveDeleteFileAction" /* CleanupProcessMessage.RemoveDeleteFileAction */,
             filePath,
         });
     }
     async addCleanupJS(jsCommand) {
         const cleanupProcess = await this.getCleanupProcess();
         cleanupProcess.send({
-            messageType: "AddJSFileToRequire",
+            messageType: "AddJSFileToRequire" /* CleanupProcessMessage.AddJSFileToRequire */,
             jsCommand,
         });
     }
     async removeCleanupJS(jsCommand) {
         const cleanupProcess = await this.getCleanupProcess();
         cleanupProcess.send({
-            messageType: "RemoveJSFileToRequire",
+            messageType: "RemoveJSFileToRequire" /* CleanupProcessMessage.RemoveJSFileToRequire */,
             jsCommand,
         });
     }
@@ -92,6 +92,8 @@ class CleanupService {
     setShouldDispose(shouldDispose) {
         this.shouldDispose = shouldDispose;
     }
+    // TODO: Consider extracting this method to a separate service
+    // as it has the same logic as the one used in analytics-service
     getCleanupProcess() {
         return new Promise((resolve, reject) => {
             const cleanupProcessArgs = this.getCleanupProcessArgs();
@@ -110,11 +112,12 @@ class CleanupService {
                 clearTimeout(timeoutId);
                 if (!isSettled) {
                     isSettled = true;
+                    // In case we throw error here, CLI will break its execution.
                     reject(err);
                 }
             });
             cleanupProcess.on("message", (data) => {
-                if (data === "ProcessReadyToReceive") {
+                if (data === "ProcessReadyToReceive" /* DetachedProcessMessages.ProcessReadyToReceive */) {
                     clearTimeout(timeoutId);
                     if (!isSettled) {
                         isSettled = true;
@@ -163,3 +166,4 @@ __decorate([
     (0, decorators_1.cache)()
 ], CleanupService.prototype, "getCleanupProcess", null);
 yok_1.injector.register("cleanupService", CleanupService);
+//# sourceMappingURL=cleanup-service.js.map

package/lib/services/cocoapods-platform-manager.js

@@ -82,6 +82,7 @@ class CocoaPodsPlatformManager {
         _.each(allPodfiles, (podfileContent) => {
             const platformMatch = platformRowRegExp.exec(podfileContent);
             const podfilePathMatch = podfilePathRegExp.exec(podfileContent) || [];
+            // platform without version -> select it with highest priority
             if (platformMatch && platformMatch[0] && !platformMatch[2]) {
                 selectedPlatformData = {
                     version: null,
@@ -90,6 +91,7 @@ class CocoaPodsPlatformManager {
                 };
                 return false;
             }
+            // platform with version
             if (platformMatch && platformMatch[0] && platformMatch[2]) {
                 if (!selectedPlatformData ||
                     semver.gt(semver.coerce(platformMatch[2]), semver.coerce(selectedPlatformData.version))) {
@@ -104,6 +106,12 @@ class CocoaPodsPlatformManager {
         return selectedPlatformData;
     }
     shouldReplacePlatformSection(projectData, oldPodfilePlatformData, currentPodfilePlatformData) {
+        // The selected platform should be replaced in the following cases:
+        // 1. When the pod file is from App_Resources and the selected platform is not from App_Resources
+        // 2. When the pod file is from App_Resources, the selected platform is also from App_Resources
+        // and the pod's version is greater than the selected one
+        // 3. When the pod file doesn't have platform's version -> `platform :ios`
+        // 4. When the pod file has a version greater than the selected platform's version
         const appResourcesPodfilePath = path.join(projectData.getAppResourcesDirectoryPath(), "iOS", constants_1.PODFILE_NAME);
         const isFromAppResources = oldPodfilePlatformData.path !== appResourcesPodfilePath &&
             currentPodfilePlatformData.path === appResourcesPodfilePath;
@@ -135,3 +143,4 @@ class CocoaPodsPlatformManager {
 }
 exports.CocoaPodsPlatformManager = CocoaPodsPlatformManager;
 yok_1.injector.register("cocoaPodsPlatformManager", CocoaPodsPlatformManager);
+//# sourceMappingURL=cocoapods-platform-manager.js.map