musubi-sdd 5.1.0 → 5.6.1

package/src/orchestration/patterns/group-chat.js

@@ -1,6 +1,6 @@
 /**
  * GroupChatPattern - Multi-skill collaborative discussion pattern
- * 
+ *
  * Enables multiple skills to collaborate on a task through
  * iterative discussion and consensus building.
  */
@@ -12,18 +12,18 @@ const { PatternType, ExecutionContext, ExecutionStatus } = require('../orchestra
  * Discussion mode
  */
 const DiscussionMode = {
-  ROUND_ROBIN: 'round-robin',   // Each skill speaks in turn
-  OPEN_FLOOR: 'open-floor',     // Skills speak based on relevance
-  MODERATED: 'moderated'        // Moderator skill controls discussion
+  ROUND_ROBIN: 'round-robin', // Each skill speaks in turn
+  OPEN_FLOOR: 'open-floor', // Skills speak based on relevance
+  MODERATED: 'moderated', // Moderator skill controls discussion
 };
 
 /**
  * Consensus type
  */
 const ConsensusType = {
-  UNANIMOUS: 'unanimous',       // All must agree
-  MAJORITY: 'majority',         // 50%+ must agree
-  FIRST_AGREEMENT: 'first'      // First agreement wins
+  UNANIMOUS: 'unanimous', // All must agree
+  MAJORITY: 'majority', // 50%+ must agree
+  FIRST_AGREEMENT: 'first', // First agreement wins
 };
 
 /**
@@ -37,15 +37,10 @@ class GroupChatPattern extends BasePattern {
       description: 'Enable multi-skill collaborative discussion and consensus',
       version: '1.0.0',
       tags: ['collaboration', 'discussion', 'consensus', 'multi-agent'],
-      useCases: [
-        'Design reviews',
-        'Code reviews',
-        'Decision making',
-        'Brainstorming'
-      ],
+      useCases: ['Design reviews', 'Code reviews', 'Decision making', 'Brainstorming'],
       complexity: 'high',
       supportsParallel: false,
-      requiresHuman: false
+      requiresHuman: false,
     });
 
     this.options = {
@@ -54,7 +49,7 @@ class GroupChatPattern extends BasePattern {
       maxRounds: options.maxRounds || 5,
       moderator: options.moderator || null,
       convergenceThreshold: options.convergenceThreshold || 0.8,
-      ...options
+      ...options,
     };
   }
 
@@ -99,7 +94,7 @@ class GroupChatPattern extends BasePattern {
 
     return {
       valid: errors.length === 0,
-      errors
+      errors,
     };
   }
 
@@ -125,7 +120,7 @@ class GroupChatPattern extends BasePattern {
       context,
       participants,
       topic,
-      mode: this.options.mode
+      mode: this.options.mode,
     });
 
     try {
@@ -135,7 +130,7 @@ class GroupChatPattern extends BasePattern {
         engine.emit('groupChatRoundStarted', {
           context,
           round,
-          maxRounds: this.options.maxRounds
+          maxRounds: this.options.maxRounds,
         });
 
         const roundResponses = await this._executeRound(
@@ -150,13 +145,13 @@ class GroupChatPattern extends BasePattern {
 
         transcript.push({
           round,
-          responses: roundResponses
+          responses: roundResponses,
         });
 
         // Check for consensus
         const consensusResult = this._checkConsensus(roundResponses);
         consensusReached = consensusResult.reached;
-        
+
         if (consensusReached) {
           finalDecision = consensusResult.decision;
         }
@@ -165,7 +160,7 @@ class GroupChatPattern extends BasePattern {
           context,
           round,
           responses: roundResponses,
-          consensusReached
+          consensusReached,
         });
       }
 
@@ -176,7 +171,7 @@ class GroupChatPattern extends BasePattern {
         transcript,
         consensusReached,
         finalDecision,
-        summary
+        summary,
       });
 
       return {
@@ -184,15 +179,14 @@ class GroupChatPattern extends BasePattern {
         rounds: round,
         consensusReached,
         finalDecision,
-        summary
+        summary,
       };
-
     } catch (error) {
       engine.emit('groupChatFailed', {
         context,
         transcript,
         round,
-        error
+        error,
       });
       throw error;
     }
@@ -202,13 +196,21 @@ class GroupChatPattern extends BasePattern {
    * Execute a single round of discussion
    * @private
    */
-  async _executeRound(participants, topic, transcript, initialContext, parentContext, engine, round) {
+  async _executeRound(
+    participants,
+    topic,
+    transcript,
+    initialContext,
+    parentContext,
+    engine,
+    round
+  ) {
     const responses = [];
     const discussionContext = {
       topic,
       round,
       previousRounds: transcript,
-      ...initialContext
+      ...initialContext,
     };
 
     for (const participant of participants) {
@@ -218,48 +220,43 @@ class GroupChatPattern extends BasePattern {
         input: {
           ...discussionContext,
           previousResponses: responses,
-          role: 'participant'
+          role: 'participant',
         },
         parentId: parentContext.id,
         metadata: {
           pattern: PatternType.GROUP_CHAT,
           round,
-          participant
-        }
+          participant,
+        },
       });
 
       parentContext.children.push(stepContext);
 
       try {
         stepContext.start();
-        
-        const response = await engine.executeSkill(
-          participant,
-          stepContext.input,
-          parentContext
-        );
+
+        const response = await engine.executeSkill(participant, stepContext.input, parentContext);
 
         stepContext.complete(response);
 
         responses.push({
           participant,
           response,
-          status: ExecutionStatus.COMPLETED
+          status: ExecutionStatus.COMPLETED,
         });
 
         engine.emit('groupChatResponse', {
           participant,
           round,
-          response
+          response,
         });
-
       } catch (error) {
         stepContext.fail(error);
-        
+
         responses.push({
           participant,
           error: error.message,
-          status: ExecutionStatus.FAILED
+          status: ExecutionStatus.FAILED,
         });
       }
     }
@@ -272,21 +269,21 @@ class GroupChatPattern extends BasePattern {
    * @private
    */
   _checkConsensus(responses) {
-    const validResponses = responses.filter(r => 
-      r.status === ExecutionStatus.COMPLETED
-    );
+    const validResponses = responses.filter(r => r.status === ExecutionStatus.COMPLETED);
 
     if (validResponses.length === 0) {
       return { reached: false, decision: null };
     }
 
     // Extract decisions from responses
-    const decisions = validResponses.map(r => {
-      if (r.response && typeof r.response === 'object') {
-        return r.response.decision || r.response.recommendation || r.response.answer;
-      }
-      return r.response;
-    }).filter(d => d !== undefined && d !== null);
+    const decisions = validResponses
+      .map(r => {
+        if (r.response && typeof r.response === 'object') {
+          return r.response.decision || r.response.recommendation || r.response.answer;
+        }
+        return r.response;
+      })
+      .filter(d => d !== undefined && d !== null);
 
     if (decisions.length === 0) {
       return { reached: false, decision: null };
@@ -295,9 +292,7 @@ class GroupChatPattern extends BasePattern {
     // Count votes for each decision
     const votes = {};
     for (const decision of decisions) {
-      const key = typeof decision === 'object' 
-        ? JSON.stringify(decision) 
-        : String(decision);
+      const key = typeof decision === 'object' ? JSON.stringify(decision) : String(decision);
       votes[key] = (votes[key] || 0) + 1;
     }
 
@@ -317,30 +312,30 @@ class GroupChatPattern extends BasePattern {
 
     // Check consensus based on type
     const total = validResponses.length;
-    
+
     switch (this.options.consensusType) {
       case ConsensusType.UNANIMOUS:
         return {
           reached: maxVotes === total,
-          decision: maxVotes === total ? winningDecision : null
+          decision: maxVotes === total ? winningDecision : null,
         };
-        
+
       case ConsensusType.MAJORITY:
         return {
           reached: maxVotes > total / 2,
-          decision: maxVotes > total / 2 ? winningDecision : null
+          decision: maxVotes > total / 2 ? winningDecision : null,
         };
-        
+
       case ConsensusType.FIRST_AGREEMENT:
         return {
           reached: maxVotes >= 2,
-          decision: maxVotes >= 2 ? winningDecision : null
+          decision: maxVotes >= 2 ? winningDecision : null,
         };
-        
+
       default:
         return {
           reached: maxVotes >= total * this.options.convergenceThreshold,
-          decision: winningDecision
+          decision: winningDecision,
         };
     }
   }
@@ -371,9 +366,8 @@ class GroupChatPattern extends BasePattern {
       successfulResponses,
       failedResponses,
       consensusReached,
-      successRate: totalResponses > 0 
-        ? (successfulResponses / totalResponses * 100).toFixed(1) + '%' 
-        : '0%'
+      successRate:
+        totalResponses > 0 ? ((successfulResponses / totalResponses) * 100).toFixed(1) + '%' : '0%',
     };
   }
 }
@@ -391,5 +385,5 @@ module.exports = {
   GroupChatPattern,
   DiscussionMode,
   ConsensusType,
-  createGroupChatPattern
+  createGroupChatPattern,
 };

package/src/orchestration/patterns/handoff.js

@@ -1,15 +1,15 @@
 /**
  * HandoffPattern - Agent delegation pattern
- * 
+ *
  * Enables conversation control transfer between agents.
  * Implements OpenAI Agents SDK-style handoff mechanism for MUSUBI.
- * 
+ *
  * @module orchestration/patterns/handoff
  * @version 1.0.0
  */
 
 const { BasePattern } = require('../pattern-registry');
-const { PatternType, ExecutionContext, ExecutionStatus } = require('../orchestration-engine');
+const { PatternType, ExecutionContext, _ExecutionStatus } = require('../orchestration-engine');
 
 /**
  * Extended PatternType with HANDOFF
@@ -17,17 +17,17 @@ const { PatternType, ExecutionContext, ExecutionStatus } = require('../orchestra
 const HandoffPatternType = {
   ...PatternType,
   HANDOFF: 'handoff',
-  TRIAGE: 'triage'
+  TRIAGE: 'triage',
 };
 
 /**
  * Handoff strategy options
  */
 const HandoffStrategy = {
-  FIRST_MATCH: 'first-match',     // Use first matching agent
-  BEST_MATCH: 'best-match',       // Use best scoring agent
-  ROUND_ROBIN: 'round-robin',     // Rotate through agents
-  WEIGHTED: 'weighted'            // Use weighted selection
+  FIRST_MATCH: 'first-match', // Use first matching agent
+  BEST_MATCH: 'best-match', // Use best scoring agent
+  ROUND_ROBIN: 'round-robin', // Rotate through agents
+  WEIGHTED: 'weighted', // Use weighted selection
 };
 
 /**
@@ -37,49 +37,51 @@ const HandoffFilters = {
   /**
    * Remove all tool calls from history
    */
-  removeAllTools: (history) => {
+  removeAllTools: history => {
     return history.filter(msg => msg.type !== 'tool_call' && msg.type !== 'tool_result');
   },
 
   /**
    * Remove tool results only (keep calls)
    */
-  removeToolResults: (history) => {
+  removeToolResults: history => {
     return history.filter(msg => msg.type !== 'tool_result');
   },
 
   /**
    * Keep only user messages
    */
-  userMessagesOnly: (history) => {
+  userMessagesOnly: history => {
     return history.filter(msg => msg.role === 'user');
   },
 
   /**
    * Keep last N messages
    */
-  lastN: (n) => (history) => {
+  lastN: n => history => {
     return history.slice(-n);
   },
 
   /**
    * Keep everything (no filter)
    */
-  keepAll: (history) => history,
+  keepAll: history => history,
 
   /**
    * Summarize history to single message
    */
-  summarize: (history) => {
+  summarize: history => {
     if (history.length === 0) return [];
-    const summary = history.map(msg => 
-      `[${msg.role || msg.type}]: ${msg.content?.substring(0, 100) || '...'}`
-    ).join('\n');
-    return [{
-      role: 'system',
-      content: `Previous conversation summary:\n${summary}`
-    }];
-  }
+    const summary = history
+      .map(msg => `[${msg.role || msg.type}]: ${msg.content?.substring(0, 100) || '...'}`)
+      .join('\n');
+    return [
+      {
+        role: 'system',
+        content: `Previous conversation summary:\n${summary}`,
+      },
+    ];
+  },
 };
 
 /**
@@ -102,7 +104,7 @@ class EscalationData {
       sourceAgent: this.sourceAgent,
       context: this.context,
       timestamp: this.timestamp.toISOString(),
-      metadata: this.metadata
+      metadata: this.metadata,
     };
   }
 }
@@ -112,13 +114,13 @@ class EscalationData {
  */
 class HandoffConfig {
   constructor(options = {}) {
-    this.agent = options.agent;                    // Target agent
+    this.agent = options.agent; // Target agent
     this.toolNameOverride = options.toolNameOverride || null;
     this.inputType = options.inputType || EscalationData;
     this.inputFilter = options.inputFilter || HandoffFilters.keepAll;
-    this.onHandoff = options.onHandoff || null;    // Callback when handoff occurs
-    this.condition = options.condition || null;    // Condition function
-    this.priority = options.priority || 0;         // Selection priority
+    this.onHandoff = options.onHandoff || null; // Callback when handoff occurs
+    this.condition = options.condition || null; // Condition function
+    this.priority = options.priority || 0; // Selection priority
   }
 }
 
@@ -151,12 +153,12 @@ class HandoffPattern extends BasePattern {
         'Escalation workflows',
         'Customer service routing',
         'Multi-expert consultation',
-        'Fallback handling'
+        'Fallback handling',
       ],
       complexity: 'medium',
       supportsParallel: false,
       supportsReplanning: true,
-      requiresHuman: false
+      requiresHuman: false,
     });
 
     this.options = {
@@ -167,7 +169,7 @@ class HandoffPattern extends BasePattern {
       inputFilter: options.inputFilter || HandoffFilters.keepAll,
       onHandoff: options.onHandoff || null,
       onHandoffComplete: options.onHandoffComplete || null,
-      ...options
+      ...options,
     };
 
     // Track handoff chain
@@ -199,7 +201,7 @@ class HandoffPattern extends BasePattern {
       for (let i = 0; i < input.targetAgents.length; i++) {
         const target = input.targetAgents[i];
         const agent = target.agent || target;
-        
+
         // Check if agent is a HandoffConfig or direct agent
         if (!agent) {
           errors.push(`Target agent ${i} is invalid`);
@@ -216,7 +218,7 @@ class HandoffPattern extends BasePattern {
 
     return {
       valid: errors.length === 0,
-      errors
+      errors,
     };
   }
 
@@ -238,7 +240,7 @@ class HandoffPattern extends BasePattern {
       message,
       history = [],
       escalationData = null,
-      sharedContext = {}
+      sharedContext = {},
     } = context.input;
 
     const startTime = Date.now();
@@ -248,7 +250,7 @@ class HandoffPattern extends BasePattern {
       context,
       sourceAgent: this._getAgentName(sourceAgent),
       targetAgents: targetAgents.map(t => this._getAgentName(t.agent || t)),
-      escalationData
+      escalationData,
     });
 
     try {
@@ -256,33 +258,32 @@ class HandoffPattern extends BasePattern {
       engine.emit('handoff:selecting', {
         context,
         strategy: this.options.strategy,
-        candidates: targetAgents.length
+        candidates: targetAgents.length,
       });
 
-      const selectedTarget = await this.selectTargetAgent(
-        context,
-        targetAgents,
-        engine
-      );
+      const selectedTarget = await this.selectTargetAgent(context, targetAgents, engine);
 
       if (!selectedTarget) {
         throw new Error('No suitable target agent found for handoff');
       }
 
-      const selectedConfig = selectedTarget instanceof HandoffConfig 
-        ? selectedTarget 
-        : new HandoffConfig({ agent: selectedTarget });
+      const selectedConfig =
+        selectedTarget instanceof HandoffConfig
+          ? selectedTarget
+          : new HandoffConfig({ agent: selectedTarget });
 
       // Step 2: Apply input filter to history
       const inputFilter = selectedConfig.inputFilter || this.options.inputFilter;
       const filteredHistory = inputFilter(history);
 
       // Step 3: Create escalation data if not provided
-      const escalation = escalationData || new EscalationData({
-        reason: context.input.reason || 'Agent handoff',
-        sourceAgent: this._getAgentName(sourceAgent),
-        context: sharedContext
-      });
+      const escalation =
+        escalationData ||
+        new EscalationData({
+          reason: context.input.reason || 'Agent handoff',
+          sourceAgent: this._getAgentName(sourceAgent),
+          context: sharedContext,
+        });
 
       // Step 4: Execute onHandoff callback if provided
       if (selectedConfig.onHandoff) {
@@ -297,7 +298,7 @@ class HandoffPattern extends BasePattern {
         from: this._getAgentName(sourceAgent),
         to: this._getAgentName(selectedConfig.agent),
         reason: escalation.reason,
-        timestamp: new Date()
+        timestamp: new Date(),
       });
 
       // Step 6: Perform handoff (execute target agent)
@@ -308,7 +309,7 @@ class HandoffPattern extends BasePattern {
           message,
           history: filteredHistory,
           escalation,
-          sharedContext
+          sharedContext,
         },
         context,
         engine
@@ -328,7 +329,7 @@ class HandoffPattern extends BasePattern {
         targetAgent: this._getAgentName(selectedConfig.agent),
         result,
         duration: endTime - startTime,
-        handoffChain: this.handoffChain
+        handoffChain: this.handoffChain,
       });
 
       return {
@@ -337,15 +338,14 @@ class HandoffPattern extends BasePattern {
         targetAgent: this._getAgentName(selectedConfig.agent),
         result,
         handoffChain: [...this.handoffChain],
-        duration: endTime - startTime
+        duration: endTime - startTime,
       };
-
     } catch (error) {
       engine.emit('handoff:failed', {
         context,
         sourceAgent: this._getAgentName(sourceAgent),
         error: error.message,
-        handoffChain: this.handoffChain
+        handoffChain: this.handoffChain,
       });
 
       throw error;
@@ -360,7 +360,7 @@ class HandoffPattern extends BasePattern {
    * @returns {Promise<HandoffConfig|Agent>} Selected agent
    */
   async selectTargetAgent(context, targetAgents, engine) {
-    const { message, history, sharedContext } = context.input;
+    const { _message, _history, _sharedContext } = context.input;
 
     switch (this.options.strategy) {
       case HandoffStrategy.FIRST_MATCH:
@@ -385,8 +385,9 @@ class HandoffPattern extends BasePattern {
    */
   async _selectFirstMatch(targetAgents, context) {
     for (const target of targetAgents) {
-      const config = target instanceof HandoffConfig ? target : new HandoffConfig({ agent: target });
-      
+      const config =
+        target instanceof HandoffConfig ? target : new HandoffConfig({ agent: target });
+
       if (config.condition) {
         const matches = await config.condition(context);
         if (matches) return config;
@@ -400,13 +401,14 @@ class HandoffPattern extends BasePattern {
   /**
    * Select best matching agent based on scoring
    */
-  async _selectBestMatch(targetAgents, context, engine) {
+  async _selectBestMatch(targetAgents, context, _engine) {
     let bestScore = -1;
     let bestTarget = null;
 
     for (const target of targetAgents) {
-      const config = target instanceof HandoffConfig ? target : new HandoffConfig({ agent: target });
-      
+      const config =
+        target instanceof HandoffConfig ? target : new HandoffConfig({ agent: target });
+
       let score = config.priority || 0;
 
       // If condition function exists, use it for scoring
@@ -473,7 +475,7 @@ class HandoffPattern extends BasePattern {
    */
   async performHandoff(source, target, handoffData, parentContext, engine) {
     const targetName = this._getAgentName(target);
-    
+
     // Create child context for target execution
     const childContext = new ExecutionContext({
       parentId: parentContext.id,
@@ -485,12 +487,12 @@ class HandoffPattern extends BasePattern {
         escalation: handoffData.escalation?.toJSON?.() || handoffData.escalation,
         sharedContext: handoffData.sharedContext,
         isHandoff: true,
-        sourceAgent: this._getAgentName(source)
+        sourceAgent: this._getAgentName(source),
       },
       metadata: {
         handoffChain: this.handoffChain,
-        handoffDepth: this.handoffChain.length
-      }
+        handoffDepth: this.handoffChain.length,
+      },
     });
 
     parentContext.children.push(childContext);
@@ -554,5 +556,5 @@ module.exports = {
   HandoffConfig,
   EscalationData,
   handoff,
-  createHandoffPattern
+  createHandoffPattern,
 };