musubi-sdd 5.1.0 → 5.6.1

package/src/validators/critic-system.js

@@ -1,8 +1,8 @@
 /**
  * MUSUBI Critic System
- * 
+ *
  * SDDステージの品質評価システム
- * 
+ *
  * @module src/validators/critic-system
  * @see REQ-P0-B005
  * @inspired-by OpenHands openhands/critic/
@@ -15,10 +15,10 @@ const path = require('path');
  * 評価グレード
  */
 const Grade = {
-  A: 'A',   // 0.8+
-  B: 'B',   // 0.5-0.79
-  C: 'C',   // 0.3-0.49
-  F: 'F',   // < 0.3
+  A: 'A', // 0.8+
+  B: 'B', // 0.5-0.79
+  C: 'C', // 0.3-0.49
+  F: 'F', // < 0.3
 };
 
 /**
@@ -97,13 +97,13 @@ class CriticResult {
     md += `- **Grade**: ${this.grade}\n`;
     md += `- **Status**: ${this.success ? '✅ Pass' : '❌ Fail'}\n\n`;
     md += `### Summary\n\n${this.message}\n\n`;
-    
+
     if (Object.keys(this.details).length > 0) {
       md += `### Details\n\n`;
       md += `| Criterion | Score | Status |\n`;
       md += `|-----------|-------|--------|\n`;
       for (const [key, value] of Object.entries(this.details)) {
-        const score = typeof value === 'number' ? value : (value.score || 0);
+        const score = typeof value === 'number' ? value : value.score || 0;
         const pct = Math.round(score * 100);
         const status = score >= 0.5 ? '✅' : '❌';
         md += `| ${key} | ${pct}% | ${status} |\n`;
@@ -131,7 +131,7 @@ class BaseCritic {
    * @param {Object} context - 評価コンテキスト
    * @returns {CriticResult}
    */
-  evaluate(context = {}) {
+  evaluate(_context = {}) {
     throw new Error('Must implement evaluate()');
   }
 
@@ -148,7 +148,7 @@ class BaseCritic {
     let weightedSum = 0;
 
     for (const [key, value] of entries) {
-      const score = typeof value === 'number' ? value : (value.score || 0);
+      const score = typeof value === 'number' ? value : value.score || 0;
       const weight = this.weights[key] || 1;
       weightedSum += score * weight;
       totalWeight += weight;
@@ -159,7 +159,7 @@ class BaseCritic {
 
   /**
    * ファイルが存在するかチェック
-   * @param {string} relativePath 
+   * @param {string} relativePath
    * @returns {boolean}
    */
   fileExists(relativePath) {
@@ -168,7 +168,7 @@ class BaseCritic {
 
   /**
    * ファイル内容を読み込み
-   * @param {string} relativePath 
+   * @param {string} relativePath
    * @returns {string|null}
    */
   readFile(relativePath) {
@@ -202,20 +202,17 @@ class RequirementsCritic extends BaseCritic {
     };
 
     const totalScore = this.calculateWeightedScore(scores);
-    
-    return new CriticResult(
-      totalScore,
-      this._generateMessage(totalScore, scores),
-      scores
-    );
+
+    return new CriticResult(totalScore, this._generateMessage(totalScore, scores), scores);
   }
 
   /**
    * EARS形式準拠チェック
    */
   checkEarsFormat(context) {
-    const content = context.content || this.readFile('docs/requirements/srs/srs-musubi-v3.0.0.ja.md') || '';
-    
+    const content =
+      context.content || this.readFile('docs/requirements/srs/srs-musubi-v3.0.0.ja.md') || '';
+
     // EARS キーワードパターン
     const earsPatterns = [
       /\b(When|If|While|Where)\b.*\b(shall|should|must)\b/gi,
@@ -225,7 +222,7 @@ class RequirementsCritic extends BaseCritic {
 
     const reqPattern = /REQ-[A-Z0-9]+-\d+/g;
     const requirements = content.match(reqPattern) || [];
-    
+
     if (requirements.length === 0) return 0;
 
     // EARS パターンの出現をカウント
@@ -243,8 +240,9 @@ class RequirementsCritic extends BaseCritic {
    * 完全性チェック
    */
   checkCompleteness(context) {
-    const content = context.content || this.readFile('docs/requirements/srs/srs-musubi-v3.0.0.ja.md') || '';
-    
+    const content =
+      context.content || this.readFile('docs/requirements/srs/srs-musubi-v3.0.0.ja.md') || '';
+
     const requiredSections = [
       /## 機能要件|## Functional Requirements/i,
       /## 非機能要件|## Non-Functional Requirements/i,
@@ -259,13 +257,14 @@ class RequirementsCritic extends BaseCritic {
    * テスト可能性チェック
    */
   checkTestability(context) {
-    const content = context.content || this.readFile('docs/requirements/srs/srs-musubi-v3.0.0.ja.md') || '';
-    
+    const content =
+      context.content || this.readFile('docs/requirements/srs/srs-musubi-v3.0.0.ja.md') || '';
+
     // 数値目標や測定可能な基準があるかチェック
     const measurablePatterns = [
-      /\d+%/g,                          // パーセンテージ
-      /\d+\s*(秒|ms|ミリ秒|seconds?)/gi,  // 時間
-      /\d+\s*(回|times?)/gi,            // 回数
+      /\d+%/g, // パーセンテージ
+      /\d+\s*(秒|ms|ミリ秒|seconds?)/gi, // 時間
+      /\d+\s*(回|times?)/gi, // 回数
       /less than|greater than|at least|最大|最小/gi,
     ];
 
@@ -284,14 +283,14 @@ class RequirementsCritic extends BaseCritic {
    */
   checkTraceability(context) {
     const content = context.content || '';
-    
+
     // 要件IDへの参照をチェック
     const reqPattern = /REQ-[A-Z0-9]+-\d+/g;
     const requirements = content.match(reqPattern) || [];
-    
+
     // 重複を除去してユニークな要件数をカウント
     const uniqueReqs = [...new Set(requirements)];
-    
+
     // 5つ以上のユニーク要件があれば良好
     return Math.min(1, uniqueReqs.length / 5);
   }
@@ -333,25 +332,21 @@ class DesignCritic extends BaseCritic {
     };
 
     const totalScore = this.calculateWeightedScore(scores);
-    
-    return new CriticResult(
-      totalScore,
-      this._generateMessage(totalScore, scores),
-      scores
-    );
+
+    return new CriticResult(totalScore, this._generateMessage(totalScore, scores), scores);
   }
 
   /**
    * C4モデル準拠チェック
    */
-  checkC4Format(context) {
+  checkC4Format(_context) {
     const designDir = path.join(this.projectRoot, 'docs/design');
     if (!fs.existsSync(designDir)) return 0;
 
     // C4レベルのキーワードをチェック
     const c4Keywords = ['Context', 'Container', 'Component', 'Code'];
     const files = fs.readdirSync(designDir).filter(f => f.endsWith('.md'));
-    
+
     let c4Score = 0;
     for (const file of files) {
       const content = fs.readFileSync(path.join(designDir, file), 'utf-8');
@@ -366,13 +361,11 @@ class DesignCritic extends BaseCritic {
   /**
    * ADR存在チェック
    */
-  checkAdrPresence(context) {
+  checkAdrPresence(_context) {
     const adrDir = path.join(this.projectRoot, 'docs/design/adr');
     if (!fs.existsSync(adrDir)) return 0;
 
-    const adrFiles = fs.readdirSync(adrDir).filter(f => 
-      f.startsWith('ADR-') && f.endsWith('.md')
-    );
+    const adrFiles = fs.readdirSync(adrDir).filter(f => f.startsWith('ADR-') && f.endsWith('.md'));
 
     // 3つ以上のADRがあれば満点
     return Math.min(1, adrFiles.length / 3);
@@ -381,7 +374,7 @@ class DesignCritic extends BaseCritic {
   /**
    * 要件カバレッジチェック
    */
-  checkRequirementCoverage(context) {
+  checkRequirementCoverage(_context) {
     const designDir = path.join(this.projectRoot, 'docs/design');
     if (!fs.existsSync(designDir)) return 0;
 
@@ -435,18 +428,14 @@ class ImplementationCritic extends BaseCritic {
     };
 
     const totalScore = this.calculateWeightedScore(scores);
-    
-    return new CriticResult(
-      totalScore,
-      this._generateMessage(totalScore, scores),
-      scores
-    );
+
+    return new CriticResult(totalScore, this._generateMessage(totalScore, scores), scores);
   }
 
   /**
    * テストカバレッジチェック
    */
-  checkTestCoverage(context) {
+  checkTestCoverage(_context) {
     // coverage/lcov-report/index.html があればパース
     const coveragePath = path.join(this.projectRoot, 'coverage/coverage-summary.json');
     if (fs.existsSync(coveragePath)) {
@@ -476,7 +465,7 @@ class ImplementationCritic extends BaseCritic {
   /**
    * コード品質チェック
    */
-  checkCodeQuality(context) {
+  checkCodeQuality(_context) {
     let score = 0;
 
     // ESLint設定の存在
@@ -511,7 +500,7 @@ class ImplementationCritic extends BaseCritic {
   /**
    * ドキュメントチェック
    */
-  checkDocumentation(context) {
+  checkDocumentation(_context) {
     let score = 0;
 
     // README.md
@@ -570,8 +559,8 @@ class CriticSystem {
 
   /**
    * 特定ステージを評価
-   * @param {string} stage 
-   * @param {Object} context 
+   * @param {string} stage
+   * @param {Object} context
    * @returns {CriticResult}
    */
   evaluate(stage, context = {}) {
@@ -584,7 +573,7 @@ class CriticSystem {
 
   /**
    * 全ステージを評価
-   * @param {Object} context 
+   * @param {Object} context
    * @returns {Object}
    */
   evaluateAll(context = {}) {
@@ -610,13 +599,13 @@ class CriticSystem {
 
   /**
    * レポートを生成
-   * @param {Object} results 
+   * @param {Object} results
    * @returns {string}
    */
   generateReport(results) {
     let md = `# MUSUBI Quality Report\n\n`;
     md += `Generated: ${new Date().toISOString()}\n\n`;
-    
+
     if (results.overall) {
       md += `## Overall Score\n\n`;
       md += `- **Score**: ${results.overall.percentage}%\n`;
@@ -634,7 +623,8 @@ class CriticSystem {
   }
 
   _generateOverallMessage(results) {
-    const avgScore = Object.values(results).reduce((sum, r) => sum + r.score, 0) / Object.keys(results).length;
+    const avgScore =
+      Object.values(results).reduce((sum, r) => sum + r.score, 0) / Object.keys(results).length;
     if (avgScore >= 0.8) {
       return 'プロジェクトは全体的に高品質です。';
     } else if (avgScore >= 0.5) {

package/src/validators/delta-format.js

@@ -1,7 +1,7 @@
 /**
  * Delta Format Validator
  * Validates delta specification format compliance
- * 
+ *
  * @module validators/delta-format
  */
 
@@ -15,21 +15,21 @@ const { DeltaType } = require('../managers/delta-spec');
 const ValidationRules = {
   // ID format: PREFIX-IDENTIFIER (e.g., DELTA-AUTH-001, CHG-UI-002)
   ID_PATTERN: /^[A-Z]+-[A-Z0-9]+-\d{3}$/,
-  
+
   // Delta marker in markdown: [TYPE] ID: Description
   MARKER_PATTERN: /^\[([A-Z]+)\]\s+([A-Z]+-[A-Z0-9]+-\d{3}):\s+(.+)$/,
-  
+
   // Requirement reference: REQ-xxx-nnn
   REQ_PATTERN: /REQ-[A-Z]+-\d{3}/g,
-  
+
   // Valid statuses
   VALID_STATUSES: ['proposed', 'approved', 'rejected', 'implemented', 'archived'],
-  
+
   // Maximum description length
   MAX_DESCRIPTION_LENGTH: 200,
-  
+
   // Required sections in delta markdown
-  REQUIRED_SECTIONS: ['Description']
+  REQUIRED_SECTIONS: ['Description'],
 };
 
 class DeltaFormatValidator {
@@ -61,7 +61,7 @@ class DeltaFormatValidator {
       valid: this.errors.length === 0,
       errors: this.errors,
       warnings: this.warnings,
-      delta
+      delta,
     };
   }
 
@@ -73,7 +73,7 @@ class DeltaFormatValidator {
     if (!id) {
       this.errors.push({
         rule: 'required-id',
-        message: 'Delta ID is required'
+        message: 'Delta ID is required',
       });
       return;
     }
@@ -82,7 +82,7 @@ class DeltaFormatValidator {
       this.errors.push({
         rule: 'id-format',
         message: `Invalid ID format: "${id}". Expected: PREFIX-IDENTIFIER-NNN (e.g., DELTA-AUTH-001)`,
-        value: id
+        value: id,
       });
     }
   }
@@ -95,7 +95,7 @@ class DeltaFormatValidator {
     if (!type) {
       this.errors.push({
         rule: 'required-type',
-        message: 'Delta type is required'
+        message: 'Delta type is required',
       });
       return;
     }
@@ -104,7 +104,7 @@ class DeltaFormatValidator {
       this.errors.push({
         rule: 'invalid-type',
         message: `Invalid delta type: "${type}". Must be one of: ${Object.values(DeltaType).join(', ')}`,
-        value: type
+        value: type,
       });
     }
   }
@@ -117,7 +117,7 @@ class DeltaFormatValidator {
     if (!target) {
       this.errors.push({
         rule: 'required-target',
-        message: 'Target is required'
+        message: 'Target is required',
       });
       return;
     }
@@ -127,7 +127,7 @@ class DeltaFormatValidator {
       this.warnings.push({
         rule: 'target-format',
         message: `Target "${target}" doesn't match requirement ID format (REQ-XXX-NNN) or path format`,
-        value: target
+        value: target,
       });
     }
   }
@@ -140,7 +140,7 @@ class DeltaFormatValidator {
     if (!description) {
       this.errors.push({
         rule: 'required-description',
-        message: 'Description is required'
+        message: 'Description is required',
       });
       return;
     }
@@ -149,21 +149,19 @@ class DeltaFormatValidator {
       this.warnings.push({
         rule: 'description-length',
         message: `Description exceeds ${ValidationRules.MAX_DESCRIPTION_LENGTH} characters`,
-        value: description.length
+        value: description.length,
       });
     }
 
     // Check for vague language
     const vagueTerms = ['should', 'might', 'could', 'maybe', 'possibly'];
-    const foundVague = vagueTerms.filter(term => 
-      description.toLowerCase().includes(term)
-    );
-    
+    const foundVague = vagueTerms.filter(term => description.toLowerCase().includes(term));
+
     if (foundVague.length > 0) {
       this.warnings.push({
         rule: 'vague-language',
         message: `Description contains vague terms: ${foundVague.join(', ')}. Use definitive language.`,
-        value: foundVague
+        value: foundVague,
       });
     }
   }
@@ -176,7 +174,7 @@ class DeltaFormatValidator {
     if (!status) {
       this.warnings.push({
         rule: 'missing-status',
-        message: 'Status not specified, defaulting to "proposed"'
+        message: 'Status not specified, defaulting to "proposed"',
       });
       return;
     }
@@ -185,7 +183,7 @@ class DeltaFormatValidator {
       this.errors.push({
         rule: 'invalid-status',
         message: `Invalid status: "${status}". Must be one of: ${ValidationRules.VALID_STATUSES.join(', ')}`,
-        value: status
+        value: status,
       });
     }
   }
@@ -202,13 +200,13 @@ class DeltaFormatValidator {
         if (before) {
           this.warnings.push({
             rule: 'added-has-before',
-            message: 'ADDED delta should not have a "before" state'
+            message: 'ADDED delta should not have a "before" state',
           });
         }
         if (!after && this.strict) {
           this.errors.push({
             rule: 'added-missing-after',
-            message: 'ADDED delta should specify the new state in "after"'
+            message: 'ADDED delta should specify the new state in "after"',
           });
         }
         break;
@@ -217,13 +215,13 @@ class DeltaFormatValidator {
         if (!before) {
           this.warnings.push({
             rule: 'modified-missing-before',
-            message: 'MODIFIED delta should have a "before" state for comparison'
+            message: 'MODIFIED delta should have a "before" state for comparison',
           });
         }
         if (!after) {
           this.warnings.push({
             rule: 'modified-missing-after',
-            message: 'MODIFIED delta should have an "after" state'
+            message: 'MODIFIED delta should have an "after" state',
           });
         }
         break;
@@ -232,13 +230,13 @@ class DeltaFormatValidator {
         if (!before && this.strict) {
           this.warnings.push({
             rule: 'removed-missing-before',
-            message: 'REMOVED delta should document the removed state in "before"'
+            message: 'REMOVED delta should document the removed state in "before"',
           });
         }
         if (after) {
           this.warnings.push({
             rule: 'removed-has-after',
-            message: 'REMOVED delta should not have an "after" state'
+            message: 'REMOVED delta should not have an "after" state',
           });
         }
         break;
@@ -247,13 +245,13 @@ class DeltaFormatValidator {
         if (!before) {
           this.errors.push({
             rule: 'renamed-missing-before',
-            message: 'RENAMED delta requires "before" state (original name)'
+            message: 'RENAMED delta requires "before" state (original name)',
           });
         }
         if (!after) {
           this.errors.push({
             rule: 'renamed-missing-after',
-            message: 'RENAMED delta requires "after" state (new name)'
+            message: 'RENAMED delta requires "after" state (new name)',
           });
         }
         break;
@@ -268,27 +266,33 @@ class DeltaFormatValidator {
     if (!impactedAreas || impactedAreas.length === 0) {
       this.warnings.push({
         rule: 'missing-impact',
-        message: 'Impacted areas should be specified for change tracking'
+        message: 'Impacted areas should be specified for change tracking',
       });
       return;
     }
 
     // Known impact categories
     const knownCategories = [
-      'api', 'database', 'ui', 'backend', 'frontend',
-      'security', 'performance', 'testing', 'documentation',
-      'infrastructure', 'configuration'
+      'api',
+      'database',
+      'ui',
+      'backend',
+      'frontend',
+      'security',
+      'performance',
+      'testing',
+      'documentation',
+      'infrastructure',
+      'configuration',
     ];
 
-    const unknown = impactedAreas.filter(area => 
-      !knownCategories.includes(area.toLowerCase())
-    );
+    const unknown = impactedAreas.filter(area => !knownCategories.includes(area.toLowerCase()));
 
     if (unknown.length > 0 && this.strict) {
       this.warnings.push({
         rule: 'unknown-impact-area',
         message: `Unknown impact areas: ${unknown.join(', ')}. Consider using: ${knownCategories.join(', ')}`,
-        value: unknown
+        value: unknown,
       });
     }
   }
@@ -303,7 +307,7 @@ class DeltaFormatValidator {
         this.errors.push({
           rule: 'invalid-created-timestamp',
           message: 'Invalid createdAt timestamp format',
-          value: delta.createdAt
+          value: delta.createdAt,
         });
       }
     }
@@ -313,14 +317,14 @@ class DeltaFormatValidator {
         this.errors.push({
           rule: 'invalid-updated-timestamp',
           message: 'Invalid updatedAt timestamp format',
-          value: delta.updatedAt
+          value: delta.updatedAt,
         });
       }
 
       if (delta.createdAt && new Date(delta.updatedAt) < new Date(delta.createdAt)) {
         this.warnings.push({
           rule: 'timestamp-order',
-          message: 'updatedAt is before createdAt'
+          message: 'updatedAt is before createdAt',
         });
       }
     }
@@ -342,12 +346,12 @@ class DeltaFormatValidator {
       const match = line.match(ValidationRules.MARKER_PATTERN);
       if (match) {
         const [, type, id, description] = match;
-        
+
         const delta = {
           type,
           id,
           description,
-          line: index + 1
+          line: index + 1,
         };
 
         // Validate each found delta marker
@@ -364,12 +368,12 @@ class DeltaFormatValidator {
     // Check for duplicate IDs
     const ids = deltas.map(d => d.id);
     const duplicates = ids.filter((id, index) => ids.indexOf(id) !== index);
-    
+
     if (duplicates.length > 0) {
       this.errors.push({
         rule: 'duplicate-id',
         message: `Duplicate delta IDs found: ${[...new Set(duplicates)].join(', ')}`,
-        value: duplicates
+        value: duplicates,
       });
     }
 
@@ -377,7 +381,7 @@ class DeltaFormatValidator {
       valid: this.errors.length === 0,
       errors: this.errors,
       warnings: this.warnings,
-      deltas
+      deltas,
     };
   }
 
@@ -391,7 +395,7 @@ class DeltaFormatValidator {
       return {
         valid: false,
         errors: [{ rule: 'file-not-found', message: `File not found: ${filePath}` }],
-        warnings: []
+        warnings: [],
       };
     }
 
@@ -406,7 +410,7 @@ class DeltaFormatValidator {
         return {
           valid: false,
           errors: [{ rule: 'invalid-json', message: `Invalid JSON: ${e.message}` }],
-          warnings: []
+          warnings: [],
         };
       }
     } else if (ext === '.md') {
@@ -415,7 +419,7 @@ class DeltaFormatValidator {
       return {
         valid: false,
         errors: [{ rule: 'unsupported-format', message: `Unsupported file format: ${ext}` }],
-        warnings: []
+        warnings: [],
       };
     }
   }
@@ -430,7 +434,7 @@ class DeltaFormatValidator {
       return {
         valid: true,
         results: [],
-        summary: { total: 0, valid: 0, invalid: 0 }
+        summary: { total: 0, valid: 0, invalid: 0 },
       };
     }
 
@@ -446,7 +450,7 @@ class DeltaFormatValidator {
           const result = this.validateFile(jsonPath);
           result.id = entry.name;
           results.push(result);
-          
+
           if (result.valid) {
             validCount++;
           } else {
@@ -462,13 +466,13 @@ class DeltaFormatValidator {
       summary: {
         total: results.length,
         valid: validCount,
-        invalid: invalidCount
-      }
+        invalid: invalidCount,
+      },
     };
   }
 }
 
 module.exports = {
   DeltaFormatValidator,
-  ValidationRules
+  ValidationRules,
 };