mulmoclaude 2.6.0 → 2.8.0

package/src/plugins/spreadsheet/cellHighlights.ts

@@ -1,78 +0,0 @@
-/**
- * DOM helpers for the mini-editor cell-highlight pass. Extracted from
- * the post-flush watch in `src/plugins/spreadsheet/View.vue`, which
- * had a cognitive complexity of 30 driven by four levels of nested
- * optional chaining + loops.
- *
- * These helpers are side-effectful by nature (they add/remove CSS
- * classes on DOM nodes) but each one is small enough that its
- * behaviour is obvious. Unit-testable with a minimal mock DOM; see
- * `test/plugins/spreadsheet/test_cellHighlights.ts`.
- */
-
-/** Minimal DOM surface the helpers need. Defined here so tests can
- *  pass plain objects without pulling in jsdom. */
-export interface HighlightableElement {
-  classList: { add: (cls: string) => void; remove: (cls: string) => void };
-}
-
-export interface HighlightableRow {
-  querySelectorAll: (selector: string) => ArrayLike<HighlightableElement>;
-}
-
-export interface HighlightableTable {
-  querySelectorAll: (selector: string) => ArrayLike<HighlightableRow>;
-}
-
-export interface HighlightableContainer {
-  // Overload: the spreadsheet root container is known to return a
-  // table when asked for the table id, so callers can keep the
-  // result strongly typed without casting.
-  querySelector: ((selector: "#spreadsheet-table") => HighlightableTable | null) & ((selector: string) => HighlightableElement | null);
-  querySelectorAll: (selector: string) => ArrayLike<HighlightableElement> & Iterable<HighlightableElement>;
-}
-
-export interface CellCoord {
-  row: number;
-  col: number;
-}
-
-const CELL_EDITING = "cell-editing";
-const CELL_REFERENCED = "cell-referenced";
-
-/** Remove both kinds of highlight classes from the container. */
-export function clearCellHighlights(container: HighlightableContainer | null | undefined): void {
-  if (!container) return;
-  container.querySelector(`.${CELL_EDITING}`)?.classList.remove(CELL_EDITING);
-  for (const cell of container.querySelectorAll(`.${CELL_REFERENCED}`)) {
-    cell.classList.remove(CELL_REFERENCED);
-  }
-}
-
-/** Add `className` to the <td> at (row, col) of the given table.
- *  No-op if the row or cell doesn't exist. */
-export function highlightCell(table: HighlightableTable | null | undefined, coord: CellCoord, className: string): void {
-  if (!table) return;
-  const rows = table.querySelectorAll("tr");
-  const row = rows[coord.row];
-  if (!row) return;
-  const cells = row.querySelectorAll("td");
-  const cell = cells[coord.col];
-  if (!cell) return;
-  cell.classList.add(className);
-}
-
-/** Apply the editing cell + referenced cells highlights. Looks up
- *  the #spreadsheet-table inside the container and no-ops if the
- *  table hasn't rendered yet. */
-export function applyCellHighlights(
-  container: HighlightableContainer | null | undefined,
-  editingCell: CellCoord | null,
-  references: readonly CellCoord[],
-): void {
-  if (!container) return;
-  const table = container.querySelector("#spreadsheet-table");
-  if (!table) return;
-  if (editingCell) highlightCell(table, editingCell, CELL_EDITING);
-  for (const ref of references) highlightCell(table, ref, CELL_REFERENCED);
-}

package/src/plugins/spreadsheet/engine/calculator.ts

@@ -1,427 +0,0 @@
-/**
- * Spreadsheet Calculator
- *
- * Core calculation engine with circular reference detection and cross-sheet support
- */
-
-import { formatCellForDisplay } from "./cellFormatting";
-import { evaluateFormula as evaluateFormulaFn } from "./evaluator";
-import { expandRangeOrCell, parseSingleCellRef } from "./formulaRefs";
-import { parseDate, getDefaultDateFormat } from "./date-parser";
-import type { SheetData, CellValue, CalculatedSheet, CalculationError, FormulaInfo, SpreadsheetCell, CalculateOptions } from "./types";
-import { isObj } from "../../../utils/types";
-import { isEmptyCell } from "./cellEmpty";
-import { errorMessage } from "../../../utils/errors";
-import { classifyThrownError, invalidRefError } from "./formulaError";
-import { isSpreadsheetErrorValue, spreadsheetError } from "./spreadsheet-errors";
-
-// The grid a reference should read from, plus the sheet-name-stripped ref and
-// whether it points at the sheet currently being calculated (which decides
-// whether recursive formula evaluation is allowed for the cell it lands on).
-type ResolvedSheetRef = { sheetData: (SpreadsheetCell | CellValue)[][]; ref: string; isCurrentSheet: boolean };
-
-// Where a cell sits in the grid CURRENTLY being calculated, carrying the row it
-// belongs to so a formula's result is written back without re-indexing. Only a
-// same-sheet cell has one: a cross-sheet read is resolved by that sheet's own
-// calculateSheet pass, so it has no position here to recurse from.
-type CellPosition = { cells: any[]; row: number; col: number };
-
-/**
- * Normalize malformed data structures
- * Some models generate flat arrays instead of 2D arrays - fix them
- *
- * @param data - Potentially malformed sheet data
- * @returns Normalized 2D array
- */
-export function normalizeData(data: any): SpreadsheetCell[][] {
-  // Handle null/undefined
-  if (!data) {
-    return [];
-  }
-
-  // If not an array, wrap in array
-  if (!Array.isArray(data)) {
-    return [];
-  }
-
-  // Empty array
-  if (data.length === 0) {
-    return [];
-  }
-
-  // If data is already a 2D array, return as-is
-  if (Array.isArray(data[0])) {
-    return data as SpreadsheetCell[][];
-  }
-
-  // If data is a flat array of cell objects, convert to 2D by pairing cells
-  // Pattern: [cell1, cell2, cell3, cell4] -> [[cell1, cell2], [cell3, cell4]]
-  // This handles the case where models output flat arrays instead of rows
-  if (isObj(data[0])) {
-    const rows: SpreadsheetCell[][] = [];
-    for (let i = 0; i < data.length; i += 2) {
-      const row = [data[i]];
-      if (i + 1 < data.length) {
-        row.push(data[i + 1]);
-      }
-      rows.push(row);
-    }
-    return rows;
-  }
-
-  // Unknown structure - return empty
-  console.warn("Unknown data structure in spreadsheet, returning empty:", data);
-  return [];
-}
-
-/**
- * Pre-process sheet data to parse date strings into serial numbers
- *
- * @param data - Raw sheet data
- * @returns Processed data with dates converted to serial numbers
- */
-function preprocessDates(data: SpreadsheetCell[][], preferDDMMYYYY: boolean): SpreadsheetCell[][] {
-  return data.map((row) =>
-    row.map((cell) => {
-      // Skip if not a cell object or if it has a formula
-      if (!isObj(cell) || !("v" in cell)) {
-        return cell;
-      }
-
-      const value = cell.v;
-
-      // Only parse strings that aren't formulas
-      if (typeof value === "string" && !value.startsWith("=")) {
-        const dateSerial = parseDate(value, preferDDMMYYYY);
-
-        if (dateSerial !== null) {
-          // It's a date! Convert to serial number
-          return {
-            v: dateSerial,
-            f: cell.f || getDefaultDateFormat(value, preferDDMMYYYY), // Use existing format or detect from input
-          };
-        }
-      }
-
-      // Not a date, return as-is
-      return cell;
-    }),
-  );
-}
-
-// `skipFormatting` is internal, not a public knob: a cross-sheet reference
-// computes its target sheet only to READ values, so the display-formatting pass
-// is skipped there — a date must stay a serial, not become "03/04/2025" that a
-// downstream parseFloat reads as 3 (issue #2332).
-type SheetCalculateOptions = CalculateOptions & { skipFormatting?: boolean };
-
-/**
- * Calculate formulas in a single sheet
- *
- * @param sheet - Sheet data to calculate
- * @param allSheets - All sheets for cross-sheet references
- * @returns Calculated sheet with formulas evaluated
- */
-export function calculateSheet(sheet: SheetData, allSheets?: SheetData[], options: SheetCalculateOptions = {}): CalculatedSheet {
-  const preferDDMMYYYY = options.preferDDMMYYYY ?? false;
-  const skipFormatting = options.skipFormatting ?? false;
-  // Normalize malformed data structures first
-  const normalizedData = normalizeData(sheet.data);
-
-  // Pre-process dates before calculation
-  const processedData = preprocessDates(normalizedData, preferDDMMYYYY);
-
-  // Also preprocess all sheets if provided
-  const processedAllSheets = allSheets?.map((s) => ({
-    ...s,
-    data: preprocessDates(normalizeData(s.data), preferDDMMYYYY),
-  }));
-
-  const data = processedData;
-  const sheetName = sheet.name;
-  // Cache stores either SpreadsheetCell[][] (before calculation) or CellValue[][] (after)
-  const sheetsCache = new Map<string, (SpreadsheetCell | CellValue)[][]>();
-  const errors: CalculationError[] = [];
-  const formulas: FormulaInfo[] = [];
-
-  // Create a copy of the data with calculated values
-  const calculated: any[][] = data.map((row) => [...row]);
-
-  // Add current sheet to cache to prevent infinite loops
-  sheetsCache.set(sheetName, calculated);
-
-  // Track cells being calculated to detect circular references
-  const calculating = new Set<string>();
-  // Cells whose result is already stored in `calculated`, of ANY type. A number
-  // check alone missed string/error results, so a cell referenced before the
-  // top loop reached it was re-evaluated (and, once formulas can throw, would
-  // re-emit its error). Membership here means "read the cached value, do not
-  // re-run".
-  const evaluated = new Set<string>();
-
-  // Evaluate one formula cell, guarding circular references, caching the result,
-  // and turning a thrown failure into a typed errors[] entry plus the Excel
-  // error value in the cell — never a swallowed bare string/number (#2359).
-  const resolveFormulaCell = (formulaText: string, { cells, row, col }: CellPosition): CellValue => {
-    const cellKey = `${row},${col}`;
-    if (calculating.has(cellKey)) {
-      errors.push({ cell: { row, col }, formula: formulaText, error: "Circular reference detected", type: "circular" });
-      return 0;
-    }
-    if (evaluated.has(cellKey)) return cells[col];
-    calculating.add(cellKey);
-    try {
-      const result = evaluateFormula(formulaText.substring(1)); // drop leading "="
-      cells[col] = result;
-      return result;
-    } catch (error) {
-      const { type, display } = classifyThrownError(error);
-      errors.push({ cell: { row, col }, formula: formulaText, error: errorMessage(error), type });
-      // The error VALUE, not its text: a cell that reads this one must see a
-      // real error, and the display pass renders it back to `#DIV/0!`.
-      const errorValue = spreadsheetError(display);
-      cells[col] = errorValue;
-      return errorValue;
-    } finally {
-      calculating.delete(cellKey);
-      evaluated.add(cellKey);
-    }
-  };
-
-  // Helper to extract raw value from cell with recursive formula evaluation
-  const getRawValue = (cell: any, position?: CellPosition): CellValue => {
-    // Handle null/undefined cells - treat as 0
-    if (cell === null || cell === undefined) return 0;
-
-    // An already-calculated cell can hold a formula error; it stays an error.
-    if (isSpreadsheetErrorValue(cell)) return cell;
-
-    if (typeof cell === "number") return cell;
-
-    // Handle string values (for legacy or calculated cells)
-    if (typeof cell === "string") {
-      // Handle empty strings as 0
-      if (cell.trim() === "") return 0;
-
-      // Handle percentage strings like "5%" or "0.4167%"
-      if (cell.includes("%")) {
-        const numericPart = cell.replace("%", "").trim();
-        const value = parseFloat(numericPart);
-        return isNaN(value) ? 0 : value / 100;
-      }
-      // Handle currency strings like "$1,000" or "$1,000.00"
-      if (cell.includes("$")) {
-        const numericPart = cell.replace(/[$,]/g, "").trim();
-        const value = parseFloat(numericPart);
-        return isNaN(value) ? 0 : value;
-      }
-      // Handle comma-separated numbers like "1,000"
-      if (cell.includes(",")) {
-        const numericPart = cell.replace(/,/g, "").trim();
-        const value = parseFloat(numericPart);
-        return isNaN(value) ? 0 : value;
-      }
-      // Handle regular numeric strings, but preserve non-numeric strings
-      const num = parseFloat(cell);
-      return isNaN(num) ? cell : num;
-    }
-
-    // Handle new cell format {v, f}
-    if (isObj(cell) && "v" in cell) {
-      const value = cell.v;
-      // If value is a string starting with "=", it's a formula
-      if (typeof value === "string" && value.startsWith("=")) {
-        // Only evaluatable when we know the cell's position (for recursion +
-        // circular tracking); otherwise treat as 0.
-        return position ? resolveFormulaCell(value, position) : 0;
-      }
-      // Try to parse as number, but preserve original type on failure
-      if (typeof value === "number") return value;
-      if (typeof value === "boolean") return value;
-      if (typeof value === "string") {
-        const num = parseFloat(value);
-        return isNaN(num) ? value : num;
-      }
-      return String(value);
-    }
-
-    // Try to parse cell as number, but preserve strings
-    const num = parseFloat(cell);
-    return isNaN(num) ? cell : num;
-  };
-
-  // Resolve a possibly cross-sheet reference to the grid it reads from, plus the
-  // sheet-name-stripped ref. A same-sheet ref returns the current `calculated`
-  // grid; a cross-sheet ref computes and caches its target sheet. null means the
-  // named sheet does not exist — the caller picks the terminal action (#REF! for
-  // a single cell, [] for a range). The two-stage cache seed (raw copy published
-  // BEFORE recursing, real result after) is the cross-sheet infinite-loop guard.
-  const resolveSheetData = (fullRef: string): ResolvedSheetRef | null => {
-    const sheetMatch = fullRef.match(/^(?:'([^']+)'|([^!]+))!(.+)$/);
-    if (!sheetMatch) return { sheetData: calculated, ref: fullRef, isCurrentSheet: true };
-
-    // Exactly one of the two name branches participates; the reference part
-    // always does. A shortfall would mean the pattern and this read disagree, so
-    // it lands on the caller's "sheet not found" path rather than a guess.
-    const [, quotedName, plainName, innerRef] = sheetMatch;
-    const targetSheetName = quotedName ?? plainName;
-    if (targetSheetName === undefined || innerRef === undefined) return null;
-
-    // Check cache first to prevent infinite loops
-    const cached = sheetsCache.get(targetSheetName);
-    if (cached) return { sheetData: cached, ref: innerRef, isCurrentSheet: false };
-
-    const targetSheet = processedAllSheets?.find((s) => s.name === targetSheetName);
-    if (!targetSheet || !targetSheet.data) return null;
-
-    // Seed the cache with a raw copy BEFORE recursing so a cyclic back-reference
-    // finds this sheet mid-flight, then overwrite it with the calculated result.
-    // Resolve cross-sheet values RAW (skip display formatting) so a date cell
-    // reads as its serial, not the presentation string "03/04/2025".
-    const targetCalculated = targetSheet.data.map((row) => [...row]);
-    sheetsCache.set(targetSheetName, targetCalculated);
-    const targetResult = calculateSheet(targetSheet, processedAllSheets, { preferDDMMYYYY, skipFormatting: true });
-    sheetsCache.set(targetSheetName, targetResult.data);
-    return { sheetData: targetResult.data, ref: innerRef, isCurrentSheet: false };
-  };
-
-  // Helper to get cell value by reference (e.g., "B2", "$B$2", or "'Sheet1'!B2")
-  const getCellValue = (ref: string): CellValue => {
-    const resolved = resolveSheetData(ref);
-    if (!resolved) throw invalidRefError(ref); // Sheet not found → #REF!
-    const { sheetData, ref: cellRef, isCurrentSheet } = resolved;
-
-    // `$` symbols and the A1 shape are parsed by the shared single-cell reader.
-    const coord = parseSingleCellRef(cellRef);
-    if (!coord) return 0;
-
-    const { row, col } = coord;
-    const gridRow = row >= 0 ? sheetData[row] : undefined;
-    if (!gridRow || col < 0 || col >= gridRow.length) return 0;
-
-    // Pass the position only if this is the current sheet (for recursive evaluation)
-    return getRawValue(gridRow[col], isCurrentSheet ? { cells: gridRow, row, col } : undefined);
-  };
-
-  const collectRangeValues = (range: string, options: { numericOnly: boolean }): CellValue[] => {
-    const resolved = resolveSheetData(range);
-    if (!resolved) return []; // Sheet not found → empty range
-    const { sheetData, ref: rangeRef, isCurrentSheet } = resolved;
-
-    const coords = expandRangeOrCell(rangeRef);
-    if (!coords) return [];
-
-    const values: CellValue[] = [];
-    for (const { row, col } of coords) {
-      const gridRow = row >= 0 ? sheetData[row] : undefined;
-      if (gridRow && col >= 0 && col < gridRow.length) {
-        const cell = gridRow[col];
-        // Pass the position only if current sheet (for recursive evaluation)
-        const rawValue = getRawValue(cell, isCurrentSheet ? { cells: gridRow, row, col } : undefined);
-
-        if (options.numericOnly) {
-          // A blank cell is not a value. Dropping it from the NUMERIC list keeps
-          // SUM unchanged (a blank read as 0) while stopping it from inflating
-          // AVERAGE's denominator and COUNT's tally (#2358). The raw list keeps
-          // every cell so SUMIF/AVERAGEIF's criteria and value ranges stay
-          // row-aligned; dropping there would shift indexes and aggregate the
-          // wrong rows (Codex review).
-          if (!isEmptyCell(cell) && !isNaN(rawValue as number)) {
-            values.push(rawValue);
-          }
-        } else {
-          values.push(rawValue);
-        }
-      }
-    }
-    return values;
-  };
-
-  // Helper to get numeric-only range values (legacy behavior)
-  const getRangeValues = (range: string): CellValue[] => collectRangeValues(range, { numericOnly: true });
-
-  // Helper to get raw range values including text
-  const getRangeValuesRaw = (range: string): CellValue[] => collectRangeValues(range, { numericOnly: false });
-
-  // Evaluate a formula with context
-  const evaluateFormula = (formula: string): CellValue => {
-    return evaluateFormulaFn(formula, {
-      getCellValue,
-      getRangeValues,
-      getRangeValuesRaw,
-      evaluateFormula,
-      preferDDMMYYYY,
-    });
-  };
-
-  // Compute one cell into its calculated row. A cell not in {v, f} format is
-  // left as-is (it is already a plain value).
-  const calculateCell = (originalCell: SpreadsheetCell, position: CellPosition): void => {
-    if (!isObj(originalCell) || !("v" in originalCell)) return;
-    const value = originalCell.v;
-
-    // A plain value is copied through, so range evaluation reads it.
-    if (typeof value !== "string" || !value.startsWith("=")) {
-      position.cells[position.col] = value;
-      return;
-    }
-
-    const info: FormulaInfo = {
-      cell: { row: position.row, col: position.col },
-      formula: value,
-      dependencies: [], // TODO: Extract dependencies from formula
-      result: 0, // Will be updated below
-    };
-    formulas.push(info);
-    // Route through the protected path so a thrown failure is classified into
-    // errors[] instead of escaping this walk, and a cell already resolved via
-    // another formula's recursion is read from cache (#2359).
-    info.result = resolveFormulaCell(value, position);
-    // Store result as-is (formatting will be applied at the end)
-    position.cells[position.col] = info.result;
-  };
-
-  // Walk every cell of the grid. `calculated` is built as a row-for-row copy of
-  // `data` and never resized, so a missing row cannot happen; skipping one keeps
-  // the walk total rather than asserting the invariant at each cell.
-  const forEachCell = (visit: (originalCell: SpreadsheetCell, position: CellPosition) => void): void => {
-    data.forEach((dataRow, row) => {
-      const cells = calculated[row];
-      if (!cells) return;
-      dataRow.forEach((originalCell, col) => visit(originalCell, { cells, row, col }));
-    });
-  };
-
-  // Process all cells and calculate formulas. A cell already evaluated through
-  // another formula's recursion keeps its number; formatting comes at the end.
-  forEachCell((originalCell, position) => {
-    const alreadyCalculated = typeof position.cells[position.col] === "number" && isObj(originalCell) && "f" in originalCell;
-    if (!alreadyCalculated) calculateCell(originalCell, position);
-  });
-
-  // Final display-formatting pass: turn raw serials into presentation strings.
-  // Skipped when this sheet is computed only to resolve a cross-sheet reference,
-  // so the referencing cell reads the underlying value, not a display string.
-  if (!skipFormatting) {
-    forEachCell((originalCell, { cells, col }) => {
-      cells[col] = formatCellForDisplay(originalCell, cells[col], preferDDMMYYYY);
-    });
-  }
-
-  return {
-    name: sheetName,
-    data: calculated,
-    formulas,
-    errors,
-  };
-}
-
-/**
- * Calculate all sheets in a workbook
- *
- * @param sheets - Array of sheets to calculate
- * @returns Array of calculated sheets
- */
-export function calculateWorkbook(sheets: SheetData[], options: CalculateOptions = {}): CalculatedSheet[] {
-  return sheets.map((sheet) => calculateSheet(sheet, sheets, options));
-}

package/src/plugins/spreadsheet/engine/cellBuilder.ts

@@ -1,89 +0,0 @@
-/**
- * Build a SpreadsheetCell from the raw input captured by the mini
- * editor (type + value / formula / format). Extracted from
- * `saveMiniEditor` in `src/plugins/spreadsheet/View.vue` where it
- * was inlined as ~30 lines of nested if/else that pushed the
- * surrounding function over the cognitive-complexity threshold.
- *
- * Pure — no refs, no DOM, no side effects. Given the same inputs
- * it always returns the same SpreadsheetCell. Tested in
- * `test/plugins/spreadsheet/engine/test_cellBuilder.ts`.
- */
-
-import type { SpreadsheetCell } from "./types.js";
-import { isCallableName } from "./registry.js";
-// Registers the functions, so isCallableName knows LOG10 before any sheet is calculated.
-import "./functions/index.js";
-
-/** Inputs to the cell builder. Mirrors the mini editor refs in the
- *  View but as plain values so unit tests don't need a Vue runtime. */
-export interface MiniEditorInput {
-  /** "string" → value is stored as-is as a string.
-   *  Anything else → the `formula` field is parsed (formula / number / raw string). */
-  type: string;
-  /** Used when type === "string". Coerced to string. */
-  value: unknown;
-  /** Used when type !== "string". Trimmed before classification. */
-  formula?: string;
-  /** Optional format code (e.g. "$#,##0.00"). */
-  format?: string;
-}
-
-// Anchored at the start of the input (after optional unary +/-) so we
-// only treat expressions that clearly begin with a function call as
-// formulas. Unanchored would match "abc FOO(" inside ordinary text.
-const FORMULA_FUNCTION_CALL = /^[-+]?\s*([A-Z][A-Z0-9]*)\s*\(/i;
-
-const startsWithFunctionCall = (input: string): boolean => {
-  const name = input.match(FORMULA_FUNCTION_CALL)?.[1];
-  return name !== undefined && isCallableName(name);
-};
-
-// `A1 + B2` style — cell reference next to an arithmetic operator.
-const FORMULA_CELL_OP = /[A-Z]+\d+\s*[+\-*/^]/;
-
-// `6/100`, `5 * 2` — arithmetic between two literal numbers.
-const FORMULA_NUMERIC_OP = /\d+\s*[+\-*/^]\s*\d+/;
-
-// Strict numeric literal. `parseFloat` accepts trailing junk
-// ("42abc" → 42) which silently corrupts user input; this anchor
-// ensures the ENTIRE trimmed string is a number.
-const STRICT_NUMBER = /^[-+]?(?:\d+\.?\d*|\.\d+)(?:[eE][-+]?\d+)?$/;
-
-/**
- * Best-effort formula detection. The rules are conservative enough
- * that plain text like "hello world" stays as text, but any input
- * with arithmetic operators or function calls is treated as a
- * formula and gets the "=" prefix the engine expects.
- */
-export function looksLikeFormula(input: string): boolean {
-  return startsWithFunctionCall(input) || FORMULA_CELL_OP.test(input) || FORMULA_NUMERIC_OP.test(input);
-}
-
-/**
- * Parse the raw (non-string-type) editor input into a cell value.
- * Priority: formula > number > raw string > empty string.
- */
-export function parseNonStringInput(raw: string): number | string {
-  const input = raw.trim();
-  if (input === "") return "";
-  if (looksLikeFormula(input)) return `=${input}`;
-  return STRICT_NUMBER.test(input) ? Number(input) : input;
-}
-
-/**
- * Build the full SpreadsheetCell from a mini editor input record.
- * String type short-circuits to `{ v: String(value) }`.
- * Everything else goes through parseNonStringInput for formula /
- * number / text classification, then optionally attaches `f`.
- */
-export function buildCellFromInput(input: MiniEditorInput): SpreadsheetCell {
-  if (input.type === "string") {
-    return { v: String(input.value) };
-  }
-  const cell: SpreadsheetCell = { v: parseNonStringInput(input.formula ?? "") };
-  if (input.format && input.format.length > 0) {
-    cell.f = input.format;
-  }
-  return cell;
-}

package/src/plugins/spreadsheet/engine/cellEmpty.ts

@@ -1,26 +0,0 @@
-/**
- * Telling a genuinely empty cell apart from one that holds the number 0.
- *
- * The calculator reads a blank cell as 0 for arithmetic (`=A1+1` on a blank A1
- * is 1, as in Excel). But an aggregate must not: `AVERAGE` divides by the count
- * of real values, and `COUNT` counts numbers — a blank that reads as 0 inflates
- * the denominator and the count. So range collection needs to skip the blanks,
- * which means distinguishing them from a stored 0, which this does.
- */
-
-import { isObj } from "../../../utils/types";
-
-/** True when a cell holds no value at all — absent, null, or an empty/whitespace
- *  string, in either the bare or the `{ v }` form. A cell containing the number
- *  0, `false`, or any non-empty text is NOT empty. */
-export function isEmptyCell(cell: unknown): boolean {
-  if (cell === null || cell === undefined) return true;
-  if (typeof cell === "string") return cell.trim() === "";
-  if (isObj(cell)) {
-    if (!("v" in cell)) return true;
-    const value = (cell as { v: unknown }).v;
-    if (value === null || value === undefined) return true;
-    return typeof value === "string" && value.trim() === "";
-  }
-  return false;
-}

package/src/plugins/spreadsheet/engine/cellFormatting.ts

@@ -1,59 +0,0 @@
-/**
- * Cell display formatting
- *
- * Turns a cell's raw calculated value into its display value (currency,
- * percentage, date, ...). Pure — no engine state — so cross-sheet reference
- * resolution can deliberately SKIP it and keep raw serial numbers, while the
- * final output pass applies it for presentation.
- */
-
-import { formatNumber } from "./formatter";
-import { isRecord } from "../../../utils/types";
-import { isSpreadsheetErrorValue } from "./spreadsheet-errors";
-import type { CellValue, SpreadsheetCell, StoredCellValue } from "./types";
-
-// Integer serials the engine is willing to auto-format as dates without an
-// explicit format code: ~Jul 1998 (36000) through ~Dec 2073 (63499). Narrow on
-// purpose so ordinary sums/averages are not mistaken for dates.
-const DATE_SERIAL_MIN = 36000;
-const DATE_SERIAL_MAX = 63499;
-
-const isSpreadsheetCell = (value: unknown): value is SpreadsheetCell => isRecord(value) && "v" in value;
-
-/** An integer within the date-serial window — a calculated number the engine
- *  should display as a date when the cell carries no explicit format. */
-export const isLikelyDateSerial = (value: CellValue): boolean =>
-  typeof value === "number" && Number.isInteger(value) && value >= DATE_SERIAL_MIN && value <= DATE_SERIAL_MAX;
-
-/**
- * Resolve the display value of one cell from its original definition and its
- * calculated value.
- *
- * - A formula error renders as its code, so the cell still reads `#NUM!`.
- * - Explicit format code wins (currency, percentage, date, ...).
- * - A formula that produced a date serial auto-formats as a date.
- * - Everything else (text, plain numbers, empty) passes through unchanged.
- *
- * The result is always a STORED value: this is the boundary where a computed
- * error becomes the text a cell shows and a workbook serializes.
- */
-export const formatCellForDisplay = (originalCell: unknown, calculatedValue: CellValue, preferDDMMYYYY: boolean): StoredCellValue => {
-  if (isSpreadsheetErrorValue(calculatedValue)) {
-    return calculatedValue.code;
-  }
-  if (!isSpreadsheetCell(originalCell) || typeof calculatedValue !== "number") {
-    return calculatedValue;
-  }
-
-  const explicitFormat = typeof originalCell.f === "string" ? originalCell.f : "";
-  if (explicitFormat) {
-    return formatNumber(calculatedValue, explicitFormat);
-  }
-
-  const isFormula = typeof originalCell.v === "string" && originalCell.v.startsWith("=");
-  if (isFormula && isLikelyDateSerial(calculatedValue)) {
-    return formatNumber(calculatedValue, preferDDMMYYYY ? "DD/MM/YYYY" : "MM/DD/YYYY");
-  }
-
-  return calculatedValue;
-};