mulmoclaude 2.6.0 → 2.8.0

package/server/index.ts

@@ -55,6 +55,7 @@ import "./plugins/markdown-builtin.js";
 // Side-effect: registers the built-in "html" dispatch handler so the
 // presentHtml View's useRuntime().dispatch({ kind }) resolves (phase 2).
 import "./plugins/html-builtin.js";
+import "./plugins/spreadsheet-builtin.js";
 // Side-effect: registers the built-in "shapescript" dispatch handler so the
 // presentShapeScript View's useRuntime().dispatch({ kind }) resolves — the
 // source editor's load / save against artifacts/shapes/.

package/server/plugins/confined-file-ops.ts

@@ -0,0 +1,56 @@
+// FileOps that refuse a path whose real location (symlinks followed) leaves the scope root.
+// `makeArtifactsFileOps` folds `..` lexically only, so a symlink inside the root still reaches out.
+
+import path from "node:path";
+import { mkdir, readFile, readdir, realpath, stat as fsStat, unlink as fsUnlink } from "node:fs/promises";
+import type { FileOps } from "gui-chat-protocol";
+import { writeFileAtomic } from "../utils/files/atomic.js";
+import { resolveWithinRoot, resolveWriteWithinRoot } from "../utils/files/safe.js";
+import { workspacePath } from "../workspace/paths.js";
+
+/** An escape reads as a missing file, so callers that treat ENOENT as "not there" stay closed. */
+const notInScope = (rel: string): Error & { code: string } => Object.assign(new Error(`not inside the scope: ${rel}`), { code: "ENOENT" });
+
+const realRoot = async (scopeRoot: string): Promise<string> => {
+  await mkdir(scopeRoot, { recursive: true });
+  return realpath(scopeRoot);
+};
+
+const existingPath = async (scopeRoot: string, rel: string): Promise<string | null> => resolveWithinRoot(await realRoot(scopeRoot), rel);
+
+const requireExisting = async (scopeRoot: string, rel: string): Promise<string> => {
+  const resolved = await existingPath(scopeRoot, rel);
+  if (resolved === null) throw notInScope(rel);
+  return resolved;
+};
+
+export function makeConfinedFileOps(scopeRoot: string): FileOps {
+  return {
+    read: async (rel) => readFile(await requireExisting(scopeRoot, rel), "utf-8"),
+    readBytes: async (rel) => {
+      const buf = await readFile(await requireExisting(scopeRoot, rel));
+      return new Uint8Array(buf.buffer, buf.byteOffset, buf.byteLength);
+    },
+    write: async (rel, content) => {
+      const target = await resolveWriteWithinRoot(await realRoot(scopeRoot), rel);
+      if (target === null) throw new Error(`refusing to write outside the scope: ${rel}`);
+      await writeFileAtomic(target, content);
+    },
+    readDir: async (rel) => {
+      const resolved = await existingPath(scopeRoot, rel);
+      return resolved === null ? [] : readdir(resolved);
+    },
+    stat: async (rel) => {
+      const { mtimeMs, size } = await fsStat(await requireExisting(scopeRoot, rel));
+      return { mtimeMs, size };
+    },
+    exists: async (rel) => (await existingPath(scopeRoot, rel)) !== null,
+    unlink: async (rel) => {
+      const resolved = await existingPath(scopeRoot, rel);
+      if (resolved !== null) await fsUnlink(resolved);
+    },
+  };
+}
+
+/** The workspace `artifacts/` dir, confined as above. */
+export const makeConfinedArtifactsFileOps = (): FileOps => makeConfinedFileOps(path.join(workspacePath, "artifacts"));

package/server/plugins/spreadsheet-builtin.ts

@@ -0,0 +1,26 @@
+// MulmoClaude's host wiring for the presentSpreadsheet View's dispatch channel.
+// The @gui-chat-plugin/spreadsheet View loads and saves its workbook through
+// `useRuntime().dispatch({ kind: "loadSpreadsheet" | "saveSpreadsheet", … })`;
+// this routes those calls to the package's `executeSpreadsheetDispatch` against
+// the workspace `artifacts/` (confined by realpath, so a symlink cannot lead out), then publishes a file-change event
+// after a save that wrote the file. Imported for side effect at boot (server/index.ts).
+
+import { executeSpreadsheetDispatch, isSpreadsheetDispatchArgs } from "@gui-chat-plugin/spreadsheet";
+import { makeConfinedArtifactsFileOps } from "./confined-file-ops.js";
+import { publishFileChange } from "../events/file-change.js";
+import { describeKind, registerBuiltinDispatch } from "./builtin-dispatch.js";
+import { wroteSpreadsheetFile } from "./spreadsheet-save-outcome.js";
+
+/** Matches `wrapWithScope("spreadsheet", …)` in `src/plugins/spreadsheet/index.ts`. */
+const SPREADSHEET_SCOPE = "spreadsheet";
+
+registerBuiltinDispatch(SPREADSHEET_SCOPE, async (args) => {
+  if (!isSpreadsheetDispatchArgs(args)) {
+    throw new Error(`spreadsheet plugin: unrecognised dispatch payload (kind=${describeKind(args)})`);
+  }
+  const result = await executeSpreadsheetDispatch(makeConfinedArtifactsFileOps(), args);
+  if (wroteSpreadsheetFile(args, result.data)) {
+    void publishFileChange(args.path);
+  }
+  return result;
+});

package/server/plugins/spreadsheet-save-outcome.ts

@@ -0,0 +1,7 @@
+// Whether a spreadsheet dispatch changed the file on disk, so the host should announce it.
+// A save refused for a conflict (the file moved on since the View's baseVersion) wrote nothing.
+
+import type { SpreadsheetDispatchArgs, SpreadsheetFileData } from "@gui-chat-plugin/spreadsheet";
+
+export const wroteSpreadsheetFile = (args: SpreadsheetDispatchArgs, data: SpreadsheetFileData | undefined): boolean =>
+  args.kind === "saveSpreadsheet" && data !== undefined && data.conflict !== true;

package/server/utils/files/store-resolvers.ts

@@ -1,5 +1,5 @@
 // Shared resolver factory for file-store modules (attachment-store,
-// image-store, spreadsheet-store). Each store used to define its own
+// image-store). Each store used to define its own
 // `safeResolve(relativePath)` wrapper of identical shape: ensure the
 // root dir exists, cache its realpath, strip the leading store
 // prefix, hand off to `resolveWithinRoot`. That left three name-cloned

package/src/lang/de.ts

@@ -1099,26 +1099,6 @@ const deMessages = {
   pluginSkill: {
     noDescription: "(keine Beschreibung)",
   },
-  pluginSpreadsheet: {
-    previewUntitled: "Tabelle",
-    previewSheets: "{count} Blatt | {count} Blätter",
-    untitled: "Tabelle",
-    excel: "Excel",
-    valuePlaceholder: "Wert",
-    valueOrFormulaPlaceholder: "Wert oder Formel (z. B. 100 oder SUM(B2:B11))",
-    formatPlaceholder: "Format (z. B. $#,##0.00)",
-    loading: "Tabelle wird geladen...",
-    noData: "Keine Tabellendaten verfügbar",
-    editData: "Tabellendaten bearbeiten",
-    applyChanges: "Änderungen übernehmen",
-    dataMustBeArray: "Daten müssen ein Array von Blättern sein",
-    loadFailed: "Laden der Tabelle fehlgeschlagen: {error}",
-    invalidJsonAlert: "Ungültiges JSON-Format: {error}",
-    unknownError: "Unbekannter Fehler",
-    update: "Aktualisieren",
-    stringType: "Zeichenkette",
-    formulaType: "Formel",
-  },
   app: {
     startConversation: "Gespräch beginnen",
     thinking: "Denkt nach…",

package/src/lang/en.ts

@@ -1109,26 +1109,6 @@ const enMessages = {
   pluginSkill: {
     noDescription: "(no description)",
   },
-  pluginSpreadsheet: {
-    previewUntitled: "Spreadsheet",
-    previewSheets: "{count} sheet | {count} sheets",
-    untitled: "Spreadsheet",
-    excel: "Excel",
-    valuePlaceholder: "Value",
-    valueOrFormulaPlaceholder: "Value or Formula (e.g., 100 or SUM(B2:B11))",
-    formatPlaceholder: "Format (e.g., $#,##0.00)",
-    loading: "Loading spreadsheet...",
-    noData: "No spreadsheet data available",
-    editData: "Edit Spreadsheet Data",
-    applyChanges: "Apply Changes",
-    dataMustBeArray: "Data must be an array of sheets",
-    loadFailed: "Failed to load spreadsheet: {error}",
-    invalidJsonAlert: "Invalid JSON format: {error}",
-    unknownError: "Unknown error",
-    update: "Update",
-    stringType: "String",
-    formulaType: "Formula",
-  },
   app: {
     startConversation: "Start a conversation",
     thinking: "Thinking…",

package/src/lang/es.ts

@@ -1097,26 +1097,6 @@ const esMessages = {
   pluginSkill: {
     noDescription: "(sin descripción)",
   },
-  pluginSpreadsheet: {
-    previewUntitled: "Hoja de cálculo",
-    previewSheets: "{count} hoja | {count} hojas",
-    untitled: "Hoja de cálculo",
-    excel: "Excel",
-    valuePlaceholder: "Valor",
-    valueOrFormulaPlaceholder: "Valor o Fórmula (ej. 100 o SUM(B2:B11))",
-    formatPlaceholder: "Formato (ej. $#,##0.00)",
-    loading: "Cargando la hoja de cálculo...",
-    noData: "No hay datos de hoja de cálculo disponibles",
-    editData: "Editar datos de la hoja de cálculo",
-    applyChanges: "Aplicar cambios",
-    dataMustBeArray: "Los datos deben ser una matriz de hojas",
-    loadFailed: "Error al cargar la hoja de cálculo: {error}",
-    invalidJsonAlert: "Formato JSON no válido: {error}",
-    unknownError: "Error desconocido",
-    update: "Actualizar",
-    stringType: "Texto",
-    formulaType: "Fórmula",
-  },
   app: {
     startConversation: "Inicia una conversación",
     thinking: "Pensando…",

package/src/lang/fr.ts

@@ -1089,26 +1089,6 @@ const frMessages = {
   pluginSkill: {
     noDescription: "(aucune description)",
   },
-  pluginSpreadsheet: {
-    previewUntitled: "Tableur",
-    previewSheets: "{count} feuille | {count} feuilles",
-    untitled: "Tableur",
-    excel: "Excel",
-    valuePlaceholder: "Valeur",
-    valueOrFormulaPlaceholder: "Valeur ou formule (ex. 100 ou SUM(B2:B11))",
-    formatPlaceholder: "Format (ex. $#,##0.00)",
-    loading: "Chargement du tableur...",
-    noData: "Aucune donnée de tableur disponible",
-    editData: "Modifier les données du tableur",
-    applyChanges: "Appliquer les modifications",
-    dataMustBeArray: "Les données doivent être un tableau de feuilles",
-    loadFailed: "Échec du chargement du tableur : {error}",
-    invalidJsonAlert: "Format JSON non valide : {error}",
-    unknownError: "Erreur inconnue",
-    update: "Mettre à jour",
-    stringType: "Texte",
-    formulaType: "Formule",
-  },
   app: {
     startConversation: "Démarrer une conversation",
     thinking: "Réflexion…",

package/src/lang/ja.ts

@@ -1083,26 +1083,6 @@ const jaMessages = {
   pluginSkill: {
     noDescription: "(説明なし)",
   },
-  pluginSpreadsheet: {
-    previewUntitled: "スプレッドシート",
-    previewSheets: "{count} シート",
-    untitled: "スプレッドシート",
-    excel: "Excel",
-    valuePlaceholder: "値",
-    valueOrFormulaPlaceholder: "値または数式（例: 100, SUM(B2:B11)）",
-    formatPlaceholder: "書式（例: $#,##0.00）",
-    loading: "スプレッドシート読み込み中...",
-    noData: "スプレッドシートのデータがありません",
-    editData: "スプレッドシートデータを編集",
-    applyChanges: "変更を適用",
-    dataMustBeArray: "データはシートの配列である必要があります",
-    loadFailed: "スプレッドシートの読み込みに失敗: {error}",
-    invalidJsonAlert: "不正な JSON 形式です: {error}",
-    unknownError: "不明なエラー",
-    update: "更新",
-    stringType: "文字列",
-    formulaType: "数式",
-  },
   app: {
     startConversation: "会話を開始してください",
     thinking: "考え中…",

package/src/lang/ko.ts

@@ -1081,26 +1081,6 @@ const koMessages = {
   pluginSkill: {
     noDescription: "(설명 없음)",
   },
-  pluginSpreadsheet: {
-    previewUntitled: "스프레드시트",
-    previewSheets: "{count}개 시트",
-    untitled: "스프레드시트",
-    excel: "Excel",
-    valuePlaceholder: "값",
-    valueOrFormulaPlaceholder: "값 또는 수식 (예: 100 또는 SUM(B2:B11))",
-    formatPlaceholder: "형식 (예: $#,##0.00)",
-    loading: "스프레드시트를 불러오는 중...",
-    noData: "사용 가능한 스프레드시트 데이터가 없습니다",
-    editData: "스프레드시트 데이터 편집",
-    applyChanges: "변경 사항 적용",
-    dataMustBeArray: "데이터는 시트 배열이어야 합니다",
-    loadFailed: "스프레드시트 불러오기 실패: {error}",
-    invalidJsonAlert: "잘못된 JSON 형식: {error}",
-    unknownError: "알 수 없는 오류",
-    update: "업데이트",
-    stringType: "문자열",
-    formulaType: "수식",
-  },
   app: {
     startConversation: "대화 시작",
     thinking: "생각 중…",

package/src/lang/pt-BR.ts

@@ -1085,26 +1085,6 @@ const ptBRMessages = {
   pluginSkill: {
     noDescription: "(sem descrição)",
   },
-  pluginSpreadsheet: {
-    previewUntitled: "Planilha",
-    previewSheets: "{count} aba | {count} abas",
-    untitled: "Planilha",
-    excel: "Excel",
-    valuePlaceholder: "Valor",
-    valueOrFormulaPlaceholder: "Valor ou Fórmula (ex.: 100 ou SUM(B2:B11))",
-    formatPlaceholder: "Formato (ex.: $#,##0.00)",
-    loading: "Carregando planilha...",
-    noData: "Nenhum dado de planilha disponível",
-    editData: "Editar dados da planilha",
-    applyChanges: "Aplicar alterações",
-    dataMustBeArray: "Os dados devem ser uma matriz de planilhas",
-    loadFailed: "Falha ao carregar a planilha: {error}",
-    invalidJsonAlert: "Formato JSON inválido: {error}",
-    unknownError: "Erro desconhecido",
-    update: "Atualizar",
-    stringType: "Texto",
-    formulaType: "Fórmula",
-  },
   app: {
     startConversation: "Iniciar uma conversa",
     thinking: "Pensando…",

package/src/lang/zh.ts

@@ -1065,26 +1065,6 @@ const zhMessages = {
   pluginSkill: {
     noDescription: "(无描述)",
   },
-  pluginSpreadsheet: {
-    previewUntitled: "电子表格",
-    previewSheets: "{count} 个工作表",
-    untitled: "电子表格",
-    excel: "Excel",
-    valuePlaceholder: "值",
-    valueOrFormulaPlaceholder: "值或公式(例如 100 或 SUM(B2:B11))",
-    formatPlaceholder: "格式(例如 $#,##0.00)",
-    loading: "正在加载电子表格...",
-    noData: "没有可用的电子表格数据",
-    editData: "编辑电子表格数据",
-    applyChanges: "应用更改",
-    dataMustBeArray: "数据必须是工作表数组",
-    loadFailed: "加载电子表格失败: {error}",
-    invalidJsonAlert: "无效的 JSON 格式: {error}",
-    unknownError: "未知错误",
-    update: "更新",
-    stringType: "字符串",
-    formulaType: "公式",
-  },
   app: {
     startConversation: "开始对话",
     thinking: "思考中…",

package/src/plugins/spreadsheet/definition.ts

@@ -1,137 +1,19 @@
+import { TOOL_DEFINITION as PACKAGE_TOOL_DEFINITION } from "@gui-chat-plugin/spreadsheet";
 import type { ToolDefinition } from "gui-chat-protocol";
 import { META } from "./meta";
 import type { ResolvedRoute } from "../meta-types";
-import { errorMessage } from "../../utils/errors";
 
+// presentSpreadsheet's schema, validation, engine and View live in
+// @gui-chat-plugin/spreadsheet (also consumed by MulmoTerminal). This built-in
+// keeps MulmoClaude's routing META and the prompt, which points the agent at
+// the workspace help file for cell formats and functions.
 export const TOOL_NAME = META.toolName;
-export type SpreadsheetEndpoints = { readonly [K in keyof typeof META.apiRoutes]: ResolvedRoute };
-
-/** Mirrors the engine's `StoredCellValue`. Declaring it narrower than what the
- *  engine stores and renders is what forced the View to cast its decoded
- *  sheets back to this type. */
-export type SpreadsheetCellValue = string | number | boolean;
-
-export interface SpreadsheetCell {
-  v: SpreadsheetCellValue;
-  f?: string;
-}
-
-/** A cell as a stored workbook actually holds it. The engine's `normalizeData`
- *  folds all four forms, and models and hand edits write all four, so a
- *  workbook read back off disk cannot promise `{ v }` for every cell. The tool
- *  SCHEMA is deliberately stricter — it says what a caller should emit, not
- *  what an existing file may contain. */
-export type StorableCell = SpreadsheetCell | { v?: null; f?: string } | SpreadsheetCellValue | null;
 
-export interface SpreadsheetSheet {
-  name: string;
-  data: StorableCell[][];
-}
-
-export interface SpreadsheetToolData {
-  sheets: SpreadsheetSheet[] | string;
-}
-
-export interface SpreadsheetArgs {
-  title: string;
-  sheets: SpreadsheetSheet[];
-}
+export type SpreadsheetEndpoints = { readonly [K in keyof typeof META.apiRoutes]: ResolvedRoute };
 
-const toolDefinition: ToolDefinition = {
-  type: "function",
-  name: TOOL_NAME,
-  description: "Display an Excel-like spreadsheet with formulas and calculations.",
+export const TOOL_DEFINITION: ToolDefinition = {
+  ...PACKAGE_TOOL_DEFINITION,
   prompt: `Use ${TOOL_NAME} when the user asks for a spreadsheet, table with calculations, or what-if analysis. Use formulas and cell references instead of pre-calculated values so the spreadsheet stays interactive. For cell format details and available functions, read \`config/helps/spreadsheet.md\` in the workspace.`,
-  parameters: {
-    type: "object",
-    properties: {
-      title: {
-        type: "string",
-        description: "Title for the spreadsheet",
-      },
-      sheets: {
-        type: "array",
-        description: "Sheets to render as spreadsheet tabs. Each sheet includes a name and 2D array of cells (rows x columns).",
-        items: {
-          type: "object",
-          properties: {
-            name: {
-              type: "string",
-              description: "Sheet name (e.g., 'Sales Q1', 'Summary')",
-            },
-            data: {
-              type: "array",
-              description:
-                'Rows of cells. Each cell is an object with \'v\' (value) and \'f\' (format). Use Excel-style A1 notation in formulas: columns are letters (A, B, C...), rows are 1-based numbers (1, 2, 3...). Values can be text, numbers, dates, or formulas. Examples: [{"v": "Product"}, {"v": 2024, "f": "#,##0"}, {"v": "01/15/2025", "f": "MM/DD/YYYY"}, {"v": "=B2*1.05", "f": "$#,##0.00"}]. Format codes: \'$#,##0.00\' (currency), \'#,##0\' (integer), \'0.00%\' (percent), \'0.00\' (decimal), \'MM/DD/YYYY\' (date), \'DD-MMM-YYYY\' (date), \'YYYY-MM-DD\' (ISO date).',
-              items: {
-                type: "array",
-                description: "Row of cells. Each cell is an object with value and format.",
-                items: {
-                  type: "object",
-                  description: "Cell object with value and optional format. If value is a string starting with '=', it's treated as a formula.",
-                  properties: {
-                    v: {
-                      oneOf: [{ type: "string" }, { type: "number" }, { type: "boolean" }],
-                      description:
-                        "Cell value. Can be text, number, boolean, date, or formula (string starting with '='). Examples: 'Revenue', 1500000, true, '01/15/2025', '=SUM(A1:A10)', '=B2-TODAY()'. Date strings like '01/15/2025' are automatically parsed to date serial numbers.",
-                    },
-                    f: {
-                      type: "string",
-                      description:
-                        "Optional format code for displaying the value. Common formats: '$#,##0.00' (currency), '#,##0' (integer), '0.00%' (percent), '0.00' (decimal), 'MM/DD/YYYY' (date), 'DD-MMM-YYYY' (date), 'YYYY-MM-DD' (ISO date)",
-                    },
-                  },
-                  required: ["v"],
-                },
-              },
-            },
-          },
-          required: ["name", "data"],
-        },
-      },
-    },
-    required: ["title", "sheets"],
-  },
 };
 
-export default toolDefinition;
-
-export const executeSpreadsheet = async (
-  args: SpreadsheetArgs,
-): Promise<{
-  message: string;
-  title: string;
-  data: SpreadsheetToolData;
-  instructions: string;
-}> => {
-  const { title } = args;
-  let { sheets } = args;
-
-  // Handle case where LLM accidentally stringifies the sheets array
-  if (typeof sheets === "string") {
-    try {
-      sheets = JSON.parse(sheets);
-    } catch (error) {
-      throw new Error(`Invalid sheets format: sheets must be an array, not a string. Parse error: ${errorMessage(error)}`);
-    }
-  }
-
-  // Validate that sheets are provided
-  if (!Array.isArray(sheets) || sheets.length === 0) {
-    throw new Error("At least one sheet is required. Sheets must be an array of sheet objects.");
-  }
-
-  // Validate each sheet has data
-  for (const sheet of sheets) {
-    if (!sheet.name || !sheet.data || sheet.data.length === 0) {
-      throw new Error(`Invalid sheet: ${sheet.name || "unnamed"}. Each sheet must have a name and data array.`);
-    }
-  }
-
-  return {
-    message: `Created spreadsheet: ${title}`,
-    title,
-    data: { sheets },
-    instructions: "Acknowledge that the spreadsheet has been created and is displayed to the user.",
-  };
-};
+export default TOOL_DEFINITION;

package/src/plugins/spreadsheet/index.ts

@@ -1,12 +1,15 @@
 import type { PluginRegistration, ToolPlugin } from "../../tools/types";
-import toolDefinition, { TOOL_NAME, type SpreadsheetEndpoints, type SpreadsheetToolData } from "./definition";
+import { View, Preview, type SpreadsheetToolData } from "@gui-chat-plugin/spreadsheet/vue";
+// Vite lib mode does not inject the package's stylesheet; the consumer imports it.
+import "@gui-chat-plugin/spreadsheet/style.css";
+import { TOOL_DEFINITION, TOOL_NAME, type SpreadsheetEndpoints } from "./definition";
 import { makeRouteExecute } from "../execute";
 import { wrapWithScope } from "../scope";
-import View from "./View.vue";
-import Preview from "./Preview.vue";
 
+// wrapWithScope provides the runtime the package View needs: dispatch for
+// loading and saving the workbook, and the host locale for its strings.
 const spreadsheetPlugin: ToolPlugin<SpreadsheetToolData> = {
-  toolDefinition,
+  toolDefinition: TOOL_DEFINITION,
 
   execute: makeRouteExecute<SpreadsheetEndpoints, SpreadsheetToolData>("spreadsheet", "create", TOOL_NAME),
 

package/src/plugins/spreadsheet/meta.ts

@@ -4,11 +4,9 @@ export const META = definePluginMeta({
   toolName: "presentSpreadsheet",
   apiNamespace: "spreadsheet",
   apiRoutes: {
-    /** POST /api/spreadsheet — create a new spreadsheet. */
+    /** POST /api/spreadsheet — create a new spreadsheet. Cell edits are
+     *  saved through the View's dispatch (server/plugins/spreadsheet-builtin.ts). */
     create: { method: "POST", path: "" },
-    /** PUT /api/spreadsheet/update — overwrite an existing
-     *  spreadsheet. Body carries the workspace-relative path. */
-    update: { method: "PUT", path: "/update" },
   },
   mcpDispatch: "create",
 });