mstro-app 0.4.43 → 0.4.45

package/server/services/websocket/quality-fix-agent.ts

@@ -1,216 +0,0 @@
-// Copyright (c) 2025-present Mstro, Inc. All rights reserved.
-// Licensed under the MIT License. See LICENSE file for details.
-
-/**
- * Quality Fix Agent — AI-powered issue fixing using Claude Code headless runner.
- *
- * Builds the fix prompt, runs the agent, re-scans, and persists updated results.
- */
-
-import { ResilientRunner } from '../../cli/headless/resilient-runner.js';
-import type { ToolUseEvent } from '../../cli/headless/types.js';
-import { loadSkillPrompt } from '../plan/agent-loader.js';
-import type { HandlerContext } from './handler-context.js';
-import type { QualityPersistence } from './quality-persistence.js';
-import { detectTools, runQualityScan } from './quality-service.js';
-import type { WSContext } from './types.js';
-
-// ── Types ─────────────────────────────────────────────────────
-
-export interface FindingForFix {
-  severity: string;
-  category: string;
-  file: string;
-  line: number | null;
-  title: string;
-  description: string;
-  suggestion?: string;
-}
-
-// ── Progress callback ─────────────────────────────────────────
-
-const TOOL_MESSAGES: Record<string, string> = {
-  Read: 'Reading files to understand issues...',
-  Edit: 'Applying fixes...',
-  Write: 'Writing fixes...',
-  Grep: 'Searching for related code...',
-  Bash: 'Running verification...',
-};
-
-export function createToolProgressCallback(ctx: HandlerContext, ws: WSContext, reportPath: string) {
-  const seenTools = new Set<string>();
-  return (event: ToolUseEvent) => {
-    try {
-      if (event.type === 'tool_start' && event.toolName && !seenTools.has(event.toolName)) {
-        seenTools.add(event.toolName);
-        const message = TOOL_MESSAGES[event.toolName];
-        if (message) {
-          ctx.send(ws, { type: 'qualityFixProgress', data: { path: reportPath, message } });
-        }
-      }
-      if (event.type === 'tool_complete' && event.toolName === 'Edit' && event.completeInput?.file_path) {
-        ctx.send(ws, {
-          type: 'qualityFixProgress',
-          data: { path: reportPath, message: `Fixed ${String(event.completeInput.file_path).split('/').slice(-2).join('/')}` },
-        });
-      }
-    } catch {
-      // WebSocket closed — progress lost but fix operation continues
-    }
-  };
-}
-
-function startFixHeartbeat(ctx: HandlerContext, ws: WSContext, reportPath: string, intervalMs = 30_000): () => void {
-  let elapsed = 0;
-  const timer = setInterval(() => {
-    elapsed += intervalMs;
-    const mins = Math.floor(elapsed / 60_000);
-    const secs = Math.floor((elapsed % 60_000) / 1000);
-    const timeStr = mins > 0 ? `${mins}m ${secs}s` : `${secs}s`;
-    try {
-      ctx.send(ws, { type: 'qualityFixProgress', data: { path: reportPath, message: `Fixing issues (${timeStr} elapsed, still working...)` } });
-    } catch {
-      // WebSocket closed — heartbeat lost but fix continues
-    }
-  }, intervalMs);
-  return () => clearInterval(timer);
-}
-
-// ── Prompt ────────────────────────────────────────────────────
-
-function buildFixPrompt(findings: FindingForFix[], section?: string): string {
-  const filtered = section ? findings.filter((f) => f.category === section) : findings;
-  const sorted = filtered.sort((a, b) => {
-    const order: Record<string, number> = { critical: 0, high: 1, medium: 2, low: 3 };
-    return (order[a.severity] ?? 4) - (order[b.severity] ?? 4);
-  });
-
-  const issueList = sorted.slice(0, 30).map((f, i) => {
-    const loc = f.line ? `${f.file}:${f.line}` : f.file;
-    const parts = [`${i + 1}. [${f.severity.toUpperCase()}] ${loc} — ${f.title}`];
-    if (f.description) parts.push(`   ${f.description}`);
-    if (f.suggestion) parts.push(`   Suggestion: ${f.suggestion}`);
-    return parts.join('\n');
-  }).join('\n\n');
-
-  const fromSkill = loadSkillPrompt('fix-quality', {
-    issueList,
-    issueCount: String(sorted.length),
-    showCount: String(Math.min(30, sorted.length)),
-  });
-  if (fromSkill) return fromSkill;
-
-  return `You are a code quality fix agent. Fix the following quality issues in the codebase.\n\n## Issues to Fix (${sorted.length} total, showing top ${Math.min(30, sorted.length)})\n\n${issueList}\n\nFix each issue by editing the relevant file. Work from most to least severe. Do NOT introduce new issues.`;
-}
-
-// ── Handler ───────────────────────────────────────────────────
-
-const activeFixes = new Set<string>();
-
-export async function handleFixIssues(
-  ctx: HandlerContext,
-  ws: WSContext,
-  reportPath: string,
-  dirPath: string,
-  workingDir: string,
-  section: string | undefined,
-  findings: FindingForFix[],
-  getPersistence: (dir: string) => QualityPersistence,
-): Promise<void> {
-  if (activeFixes.has(dirPath)) {
-    ctx.send(ws, {
-      type: 'qualityError',
-      data: { path: reportPath, error: 'A fix operation is already running for this directory.' },
-    });
-    return;
-  }
-
-  if (findings.length === 0) {
-    ctx.send(ws, {
-      type: 'qualityError',
-      data: { path: reportPath, error: 'No findings to fix.' },
-    });
-    return;
-  }
-
-  activeFixes.add(dirPath);
-  const stopHeartbeat = startFixHeartbeat(ctx, ws, reportPath);
-  try {
-    try {
-      ctx.send(ws, {
-        type: 'qualityFixProgress',
-        data: { path: reportPath, message: 'Starting Claude Code to fix issues...' },
-      });
-    } catch { /* WS closed */ }
-
-    const prompt = buildFixPrompt(findings, section);
-
-    const runner = new ResilientRunner({
-      workingDir: dirPath,
-      prompt,
-      policy: 'STANDARD',
-      stallWarningMs: 300_000,
-      stallKillMs: 1_200_000,
-      stallHardCapMs: 1_800_000,
-      toolUseCallback: createToolProgressCallback(ctx, ws, reportPath),
-      logLabel: 'code-review-fix',
-    });
-
-    await runner.run();
-
-    try {
-      ctx.send(ws, {
-        type: 'qualityFixProgress',
-        data: { path: reportPath, message: 'Fixes applied. Re-running quality checks...' },
-      });
-    } catch { /* WS closed */ }
-
-    // Re-run quality scan after fixing
-    const { tools: detectedTools } = await detectTools(dirPath);
-    const installedToolNames = detectedTools.filter((t) => t.installed).map((t) => t.name);
-
-    const results = await runQualityScan(dirPath, (progress) => {
-      try {
-        ctx.send(ws, {
-          type: 'qualityScanProgress',
-          data: { path: reportPath, progress },
-        });
-      } catch { /* WS closed */ }
-    }, installedToolNames);
-
-    // Persist before sending — results survive WebSocket drops
-    try {
-      const persistence = getPersistence(workingDir);
-      persistence.saveReport(reportPath, results);
-      persistence.appendHistory(results, reportPath);
-    } catch {
-      // Persistence failure should not break the fix flow
-    }
-
-    const resultData = { path: reportPath, results };
-    try {
-      ctx.send(ws, { type: 'qualityFixComplete', data: resultData });
-    } catch {
-      // WebSocket closed — save as pending for delivery on reconnect
-      const persistence = getPersistence(workingDir);
-      persistence.addPendingResult({
-        type: 'fixComplete',
-        path: reportPath,
-        data: resultData as unknown as Record<string, unknown>,
-        completedAt: new Date().toISOString(),
-      });
-    }
-  } catch (error) {
-    try {
-      ctx.send(ws, {
-        type: 'qualityError',
-        data: { path: reportPath, error: error instanceof Error ? error.message : String(error) },
-      });
-    } catch {
-      // WebSocket closed — error lost but operation tracked via activeOps
-    }
-  } finally {
-    stopHeartbeat();
-    activeFixes.delete(dirPath);
-  }
-}