mstro-app 0.4.43 → 0.4.45

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (49) hide show
  1. package/PRIVACY.md +1 -3
  2. package/dist/server/services/plan/executor.d.ts.map +1 -1
  3. package/dist/server/services/plan/executor.js +9 -5
  4. package/dist/server/services/plan/executor.js.map +1 -1
  5. package/dist/server/services/websocket/file-search-handlers.d.ts.map +1 -1
  6. package/dist/server/services/websocket/file-search-handlers.js +4 -0
  7. package/dist/server/services/websocket/file-search-handlers.js.map +1 -1
  8. package/dist/server/services/websocket/handler.js +1 -1
  9. package/dist/server/services/websocket/handler.js.map +1 -1
  10. package/dist/server/services/websocket/quality-complexity.d.ts +1 -1
  11. package/dist/server/services/websocket/quality-complexity.d.ts.map +1 -1
  12. package/dist/server/services/websocket/quality-complexity.js +88 -59
  13. package/dist/server/services/websocket/quality-complexity.js.map +1 -1
  14. package/dist/server/services/websocket/quality-handlers.d.ts.map +1 -1
  15. package/dist/server/services/websocket/quality-handlers.js +4 -21
  16. package/dist/server/services/websocket/quality-handlers.js.map +1 -1
  17. package/dist/server/services/websocket/quality-linting.d.ts.map +1 -1
  18. package/dist/server/services/websocket/quality-linting.js +71 -50
  19. package/dist/server/services/websocket/quality-linting.js.map +1 -1
  20. package/dist/server/services/websocket/quality-persistence.d.ts +1 -1
  21. package/dist/server/services/websocket/quality-persistence.d.ts.map +1 -1
  22. package/dist/server/services/websocket/quality-service.d.ts +0 -4
  23. package/dist/server/services/websocket/quality-service.d.ts.map +1 -1
  24. package/dist/server/services/websocket/quality-service.js +40 -34
  25. package/dist/server/services/websocket/quality-service.js.map +1 -1
  26. package/dist/server/services/websocket/quality-tools.d.ts +13 -0
  27. package/dist/server/services/websocket/quality-tools.d.ts.map +1 -1
  28. package/dist/server/services/websocket/quality-tools.js +32 -0
  29. package/dist/server/services/websocket/quality-tools.js.map +1 -1
  30. package/dist/server/services/websocket/types.d.ts +2 -2
  31. package/dist/server/services/websocket/types.d.ts.map +1 -1
  32. package/dist/server/services/websocket/types.js +2 -2
  33. package/dist/server/services/websocket/types.js.map +1 -1
  34. package/package.json +1 -1
  35. package/server/services/plan/executor.ts +9 -5
  36. package/server/services/websocket/file-search-handlers.ts +2 -0
  37. package/server/services/websocket/handler.ts +1 -1
  38. package/server/services/websocket/quality-complexity.ts +87 -51
  39. package/server/services/websocket/quality-handlers.ts +4 -18
  40. package/server/services/websocket/quality-linting.ts +74 -47
  41. package/server/services/websocket/quality-persistence.ts +1 -1
  42. package/server/services/websocket/quality-service.ts +44 -39
  43. package/server/services/websocket/quality-tools.ts +33 -0
  44. package/server/services/websocket/types.ts +2 -2
  45. package/dist/server/services/websocket/quality-fix-agent.d.ts +0 -16
  46. package/dist/server/services/websocket/quality-fix-agent.d.ts.map +0 -1
  47. package/dist/server/services/websocket/quality-fix-agent.js +0 -181
  48. package/dist/server/services/websocket/quality-fix-agent.js.map +0 -1
  49. package/server/services/websocket/quality-fix-agent.ts +0 -216
@@ -2,9 +2,12 @@
2
2
  // Licensed under the MIT License. See LICENSE file for details.
3
3
 
4
4
  import { relative } from 'node:path';
5
- import { runCommand, type SourceFile } from './quality-tools.js';
5
+ import { chunkFileList, filesByExt, runCommand, type SourceFile } from './quality-tools.js';
6
6
  import { biomeDiagToFinding, type Ecosystem, isBiomeComplexityDiagnostic, isEslintComplexityRule, type QualityFinding } from './quality-types.js';
7
7
 
8
+ const NODE_LINT_EXTS = ['.ts', '.tsx', '.js', '.jsx', '.mjs', '.cjs'];
9
+ const PY_LINT_EXTS = ['.py', '.pyi'];
10
+
8
11
  interface LintAccumulator {
9
12
  errors: number;
10
13
  warnings: number;
@@ -31,17 +34,22 @@ function parseBiomeDiagnostics(stdout: string, acc: LintAccumulator): void {
31
34
  }
32
35
  }
33
36
 
34
- async function lintWithBiome(dirPath: string, acc: LintAccumulator): Promise<void> {
35
- const result = await runCommand('npx', ['@biomejs/biome', 'lint', '--reporter=json', '.'], dirPath);
36
- if (result.exitCode > 1) return;
37
+ async function lintWithBiome(dirPath: string, acc: LintAccumulator, files: SourceFile[]): Promise<void> {
38
+ const targets = filesByExt(files, NODE_LINT_EXTS);
39
+ if (targets.length === 0) return;
37
40
 
38
- acc.ran = true;
39
- try {
40
- parseBiomeDiagnostics(result.stdout, acc);
41
- } catch {
42
- acc.errors += (result.stdout.match(/error/gi) || []).length;
43
- acc.warnings += (result.stdout.match(/warning/gi) || []).length;
44
- acc.ran = acc.errors > 0 || acc.warnings > 0 || result.exitCode === 0;
41
+ for (const chunk of chunkFileList(targets)) {
42
+ const result = await runCommand('npx', ['@biomejs/biome', 'lint', '--reporter=json', ...chunk], dirPath);
43
+ if (result.exitCode > 1) return;
44
+
45
+ acc.ran = true;
46
+ try {
47
+ parseBiomeDiagnostics(result.stdout, acc);
48
+ } catch {
49
+ acc.errors += (result.stdout.match(/error/gi) || []).length;
50
+ acc.warnings += (result.stdout.match(/warning/gi) || []).length;
51
+ acc.ran = acc.errors > 0 || acc.warnings > 0 || result.exitCode === 0;
52
+ }
45
53
  }
46
54
  }
47
55
 
@@ -64,58 +72,77 @@ function processEslintMessage(
64
72
  });
65
73
  }
66
74
 
67
- async function lintWithEslint(dirPath: string, acc: LintAccumulator): Promise<void> {
68
- const result = await runCommand('npx', ['eslint', '--format=json', '.'], dirPath);
69
- acc.ran = true;
70
- try {
71
- const parsed = JSON.parse(result.stdout);
72
- for (const file of parsed) {
73
- for (const msg of file.messages || []) {
74
- processEslintMessage(msg, file.filePath, dirPath, acc);
75
+ async function lintWithEslint(dirPath: string, acc: LintAccumulator, files: SourceFile[]): Promise<void> {
76
+ const targets = filesByExt(files, NODE_LINT_EXTS);
77
+ if (targets.length === 0) return;
78
+
79
+ for (const chunk of chunkFileList(targets)) {
80
+ const result = await runCommand('npx', ['eslint', '--format=json', ...chunk], dirPath);
81
+ acc.ran = true;
82
+ try {
83
+ const parsed = JSON.parse(result.stdout);
84
+ for (const file of parsed) {
85
+ for (const msg of file.messages || []) {
86
+ processEslintMessage(msg, file.filePath, dirPath, acc);
87
+ }
75
88
  }
89
+ } catch {
90
+ acc.errors += (result.stderr.match(/error/gi) || []).length;
91
+ acc.warnings += (result.stderr.match(/warning/gi) || []).length;
76
92
  }
77
- } catch {
78
- acc.errors += (result.stderr.match(/error/gi) || []).length;
79
- acc.warnings += (result.stderr.match(/warning/gi) || []).length;
80
93
  }
81
94
  }
82
95
 
83
- async function lintNode(dirPath: string, acc: LintAccumulator, installed: Set<string> | null): Promise<void> {
96
+ async function lintNode(
97
+ dirPath: string,
98
+ acc: LintAccumulator,
99
+ installed: Set<string> | null,
100
+ files: SourceFile[],
101
+ ): Promise<void> {
84
102
  // Use installed tools list to decide which linter to run, not config file presence.
85
103
  // This fixes monorepo scenarios where the config is in a subdirectory.
86
104
  const hasBiome = !installed || installed.has('biome');
87
105
  const hasEslint = !installed || installed.has('eslint');
88
106
 
89
107
  if (hasBiome) {
90
- await lintWithBiome(dirPath, acc);
108
+ await lintWithBiome(dirPath, acc, files);
91
109
  if (acc.ran) return;
92
110
  }
93
111
  if (hasEslint) {
94
- await lintWithEslint(dirPath, acc);
112
+ await lintWithEslint(dirPath, acc, files);
95
113
  }
96
114
  }
97
115
 
98
- async function lintPython(dirPath: string, acc: LintAccumulator): Promise<void> {
99
- const result = await runCommand('ruff', ['check', '--output-format=json', '.'], dirPath);
100
- if (result.exitCode !== 0 && !result.stdout.trim().startsWith('[')) return;
116
+ function processRuffItem(item: Record<string, unknown>, dirPath: string, acc: LintAccumulator): void {
117
+ const code = item.code as string | undefined;
118
+ const sev = code?.startsWith('E') ? 'high' : 'medium';
119
+ if (sev === 'high') acc.errors++;
120
+ else acc.warnings++;
121
+ const location = item.location as Record<string, unknown> | undefined;
122
+ acc.findings.push({
123
+ severity: sev,
124
+ category: 'lint',
125
+ file: item.filename ? relative(dirPath, item.filename as string) : '',
126
+ line: (location?.row as number) ?? null,
127
+ title: code || 'Lint issue',
128
+ description: (item.message as string) || '',
129
+ });
130
+ }
101
131
 
102
- acc.ran = true;
103
- try {
104
- const parsed = JSON.parse(result.stdout);
105
- for (const item of parsed) {
106
- const sev = item.code?.startsWith('E') ? 'high' : 'medium';
107
- if (sev === 'high') acc.errors++;
108
- else acc.warnings++;
109
- acc.findings.push({
110
- severity: sev,
111
- category: 'lint',
112
- file: item.filename ? relative(dirPath, item.filename) : '',
113
- line: item.location?.row ?? null,
114
- title: item.code || 'Lint issue',
115
- description: item.message || '',
116
- });
117
- }
118
- } catch { /* ignore */ }
132
+ async function lintPython(dirPath: string, acc: LintAccumulator, files: SourceFile[]): Promise<void> {
133
+ const targets = filesByExt(files, PY_LINT_EXTS);
134
+ if (targets.length === 0) return;
135
+
136
+ for (const chunk of chunkFileList(targets)) {
137
+ const result = await runCommand('ruff', ['check', '--output-format=json', ...chunk], dirPath);
138
+ if (result.exitCode !== 0 && !result.stdout.trim().startsWith('[')) continue;
139
+
140
+ acc.ran = true;
141
+ try {
142
+ const parsed = JSON.parse(result.stdout);
143
+ for (const item of parsed) processRuffItem(item, dirPath, acc);
144
+ } catch { /* ignore */ }
145
+ }
119
146
  }
120
147
 
121
148
  function processClippyMessage(msg: Record<string, unknown>, acc: LintAccumulator): void {
@@ -174,8 +201,8 @@ export async function analyzeLinting(
174
201
  const acc = newLintAccumulator();
175
202
  const installed = installedToolNames ? new Set(installedToolNames) : null;
176
203
 
177
- if (ecosystems.includes('node')) await lintNode(dirPath, acc, installed);
178
- if (ecosystems.includes('python')) await lintPython(dirPath, acc);
204
+ if (ecosystems.includes('node')) await lintNode(dirPath, acc, installed, files);
205
+ if (ecosystems.includes('python')) await lintPython(dirPath, acc, files);
179
206
  if (ecosystems.includes('rust')) await lintRust(dirPath, acc);
180
207
 
181
208
  if (!acc.ran) {
@@ -62,7 +62,7 @@ export interface ActiveOperation {
62
62
  }
63
63
 
64
64
  export interface PendingResult {
65
- type: 'scanResults' | 'codeReview' | 'fixComplete';
65
+ type: 'scanResults' | 'codeReview';
66
66
  path: string;
67
67
  data: Record<string, unknown>;
68
68
  completedAt: string;
@@ -4,9 +4,12 @@
4
4
  import { extname } from 'node:path';
5
5
  import { analyzeComplexity, analyzeFunctionLength } from './quality-complexity.js';
6
6
  import { analyzeLinting } from './quality-linting.js';
7
- import { collectSourceFiles, detectEcosystem, runCommand, type SourceFile } from './quality-tools.js';
7
+ import { chunkFileList, collectSourceFiles, detectEcosystem, filesByExt, runCommand, type SourceFile } from './quality-tools.js';
8
8
  import { type CategoryPenalty, type CategoryScore, type Ecosystem, FILE_LENGTH_THRESHOLD, hasInstalledToolInCategory, type QualityFinding, type QualityResults, type ScanProgress, type ScoreBreakdown, TOTAL_STEPS } from './quality-types.js';
9
9
 
10
+ const NODE_FMT_EXTS = ['.ts', '.tsx', '.js', '.jsx', '.mjs', '.cjs'];
11
+ const PY_FMT_EXTS = ['.py', '.pyi'];
12
+
10
13
  export { detectEcosystem, detectTools, installTools } from './quality-tools.js';
11
14
  // Re-export public API for backward compatibility
12
15
  export type { CategoryPenalty, CategoryScore, QualityFinding, QualityResults, QualityTool, ScanProgress, ScoreBreakdown } from './quality-types.js';
@@ -27,34 +30,51 @@ function newFmtAccumulator(): FmtAccumulator {
27
30
  }
28
31
 
29
32
  async function fmtNode(dirPath: string, files: SourceFile[], acc: FmtAccumulator): Promise<void> {
30
- const result = await runCommand('npx', ['prettier', '--check', '.'], dirPath);
31
- acc.ran = true;
32
- const unformatted = result.stdout.split('\n').filter((l) => l.trim() && !l.startsWith('Checking'));
33
- const nodeFiles = files.filter((f) => ['.ts', '.tsx', '.js', '.jsx', '.mjs', '.cjs'].includes(extname(f.path)));
34
- acc.totalFiles += nodeFiles.length;
35
- acc.passingFiles += Math.max(0, nodeFiles.length - unformatted.length);
36
- for (const filePath of unformatted) {
37
- if (!filePath.trim()) continue;
38
- const rel = filePath.startsWith('/') ? filePath.replace(`${dirPath}/`, '') : filePath;
33
+ const targets = filesByExt(files, NODE_FMT_EXTS);
34
+ if (targets.length === 0) return;
35
+
36
+ acc.totalFiles += targets.length;
37
+ const unformattedSet = new Set<string>();
38
+
39
+ for (const chunk of chunkFileList(targets)) {
40
+ const result = await runCommand('npx', ['prettier', '--check', ...chunk], dirPath);
41
+ acc.ran = true;
42
+ for (const line of result.stdout.split('\n')) {
43
+ if (!line.trim() || line.startsWith('Checking')) continue;
44
+ const rel = line.startsWith('/') ? line.replace(`${dirPath}/`, '') : line;
45
+ unformattedSet.add(rel.trim());
46
+ }
47
+ }
48
+
49
+ acc.passingFiles += Math.max(0, targets.length - unformattedSet.size);
50
+ for (const rel of unformattedSet) {
39
51
  acc.findings.push({ severity: 'low', category: 'format', file: rel, line: null, title: 'File not formatted', description: 'Does not match Prettier formatting rules.' });
40
52
  }
41
53
  }
42
54
 
43
55
  async function fmtPython(dirPath: string, files: SourceFile[], acc: FmtAccumulator): Promise<void> {
44
- const result = await runCommand('black', ['--check', '--quiet', '.'], dirPath);
45
- acc.ran = true;
46
- const pyFiles = files.filter((f) => ['.py', '.pyi'].includes(extname(f.path)));
47
- acc.totalFiles += pyFiles.length;
48
- if (result.exitCode === 0) {
49
- acc.passingFiles += pyFiles.length;
50
- return;
51
- }
52
- const reformatLines = result.stderr.split('\n').filter((l) => l.includes('would reformat'));
53
- acc.passingFiles += Math.max(0, pyFiles.length - reformatLines.length);
54
- for (const line of reformatLines) {
55
- const match = line.match(/would reformat (.+)/);
56
- if (match) acc.findings.push({ severity: 'low', category: 'format', file: match[1].trim(), line: null, title: 'File not formatted', description: 'Does not match Black formatting rules.' });
56
+ const targets = filesByExt(files, PY_FMT_EXTS);
57
+ if (targets.length === 0) return;
58
+
59
+ acc.totalFiles += targets.length;
60
+ let reformatCount = 0;
61
+ const findings: typeof acc.findings = [];
62
+
63
+ for (const chunk of chunkFileList(targets)) {
64
+ const result = await runCommand('black', ['--check', '--quiet', ...chunk], dirPath);
65
+ acc.ran = true;
66
+ if (result.exitCode === 0) continue;
67
+
68
+ const reformatLines = result.stderr.split('\n').filter((l) => l.includes('would reformat'));
69
+ reformatCount += reformatLines.length;
70
+ for (const line of reformatLines) {
71
+ const match = line.match(/would reformat (.+)/);
72
+ if (match) findings.push({ severity: 'low', category: 'format', file: match[1].trim(), line: null, title: 'File not formatted', description: 'Does not match Black formatting rules.' });
73
+ }
57
74
  }
75
+
76
+ acc.passingFiles += Math.max(0, targets.length - reformatCount);
77
+ acc.findings.push(...findings);
58
78
  }
59
79
 
60
80
  async function fmtRust(dirPath: string, files: SourceFile[], acc: FmtAccumulator): Promise<void> {
@@ -223,21 +243,6 @@ export function computeFormulaScore(
223
243
  };
224
244
  }
225
245
 
226
- /** @deprecated — use computeFormulaScore instead */
227
- export function computeAiReviewScore(
228
- findings: Array<{ severity: string }>,
229
- totalLines: number,
230
- ): number {
231
- if (findings.length === 0) return 100;
232
- const effectiveKloc = Math.max(totalLines / 1000, 1.0);
233
- const totalPenalty = findings.reduce(
234
- (sum, f) => sum + (SEVERITY_WEIGHT[f.severity] ?? 2.0),
235
- 0,
236
- );
237
- const penaltyDensity = totalPenalty / effectiveKloc;
238
- return Math.round(100 * Math.exp(-0.10 * penaltyDensity));
239
- }
240
-
241
246
  // ============================================================================
242
247
  // Main Scan
243
248
  // ============================================================================
@@ -278,7 +283,7 @@ export async function runQualityScan(
278
283
 
279
284
  // Step 4: Analyze complexity (using real tools: Biome, ESLint, radon)
280
285
  progress('Analyzing complexity', 4);
281
- const complexityResult = await analyzeComplexity(dirPath, ecosystems, installedToolNames);
286
+ const complexityResult = await analyzeComplexity(dirPath, ecosystems, files, installedToolNames);
282
287
 
283
288
  // Step 5: Check file lengths
284
289
  progress('Checking file lengths', 5);
@@ -239,6 +239,39 @@ export async function collectSourceFiles(dirPath: string, rootPath: string): Pro
239
239
  return files;
240
240
  }
241
241
 
242
+ // ============================================================================
243
+ // File List Helpers
244
+ // ============================================================================
245
+
246
+ /**
247
+ * Filter a SourceFile list by extension and return relative paths.
248
+ * Used to pass an explicit, git-ignored-filtered file list to external tools
249
+ * (prettier, biome, eslint, ...) so they don't walk ignored directories like
250
+ * web/dist or nested build outputs in monorepos.
251
+ */
252
+ export function filesByExt(files: SourceFile[], exts: string[]): string[] {
253
+ const set = new Set(exts.map((e) => e.toLowerCase()));
254
+ const out: string[] = [];
255
+ for (const f of files) {
256
+ if (set.has(extname(f.path).toLowerCase())) out.push(f.relativePath);
257
+ }
258
+ return out;
259
+ }
260
+
261
+ /**
262
+ * Split a file list into chunks so a single command invocation doesn't
263
+ * blow past ARG_MAX. macOS ARG_MAX is ~256KB; 400 paths at ~200 chars each
264
+ * leaves plenty of headroom.
265
+ */
266
+ export function chunkFileList(paths: string[], size = 400): string[][] {
267
+ if (paths.length === 0) return [];
268
+ const chunks: string[][] = [];
269
+ for (let i = 0; i < paths.length; i += size) {
270
+ chunks.push(paths.slice(i, i + size));
271
+ }
272
+ return chunks;
273
+ }
274
+
242
275
  // ============================================================================
243
276
  // Command Runner
244
277
  // ============================================================================
@@ -42,7 +42,7 @@ const SessionSyncMessages = ['getActiveTabs', 'createTab', 'reorderTabs', 'syncT
42
42
 
43
43
  const SettingsMessages = ['getSettings', 'updateSettings'] as const;
44
44
 
45
- const QualityMessages = ['qualityDetectTools', 'qualityScan', 'qualityInstallTools', 'qualityCodeReview', 'qualityFixIssues', 'qualityLoadState', 'qualitySaveDirectories'] as const;
45
+ const QualityMessages = ['qualityDetectTools', 'qualityScan', 'qualityInstallTools', 'qualityCodeReview', 'qualityLoadState', 'qualitySaveDirectories'] as const;
46
46
 
47
47
  const FileUploadMessages = ['fileUploadStart', 'fileUploadChunk', 'fileUploadComplete', 'fileUploadCancel'] as const;
48
48
 
@@ -105,7 +105,7 @@ const SessionSyncResponseMessages = ['activeTabs', 'tabCreated', 'tabRemoved', '
105
105
 
106
106
  const SettingsResponseMessages = ['settings', 'settingsUpdated'] as const;
107
107
 
108
- const QualityResponseMessages = ['qualityToolsDetected', 'qualityScanProgress', 'qualityScanResults', 'qualityInstallProgress', 'qualityInstallComplete', 'qualityCodeReview', 'qualityCodeReviewProgress', 'qualityPostSession', 'qualityFixProgress', 'qualityFixComplete', 'qualityError', 'qualityStateLoaded'] as const;
108
+ const QualityResponseMessages = ['qualityToolsDetected', 'qualityScanProgress', 'qualityScanResults', 'qualityInstallProgress', 'qualityInstallComplete', 'qualityCodeReview', 'qualityCodeReviewProgress', 'qualityPostSession', 'qualityError', 'qualityStateLoaded'] as const;
109
109
 
110
110
  const FileUploadResponseMessages = ['fileUploadAck', 'fileUploadReady', 'fileUploadError'] as const;
111
111
 
@@ -1,16 +0,0 @@
1
- import type { ToolUseEvent } from '../../cli/headless/types.js';
2
- import type { HandlerContext } from './handler-context.js';
3
- import type { QualityPersistence } from './quality-persistence.js';
4
- import type { WSContext } from './types.js';
5
- export interface FindingForFix {
6
- severity: string;
7
- category: string;
8
- file: string;
9
- line: number | null;
10
- title: string;
11
- description: string;
12
- suggestion?: string;
13
- }
14
- export declare function createToolProgressCallback(ctx: HandlerContext, ws: WSContext, reportPath: string): (event: ToolUseEvent) => void;
15
- export declare function handleFixIssues(ctx: HandlerContext, ws: WSContext, reportPath: string, dirPath: string, workingDir: string, section: string | undefined, findings: FindingForFix[], getPersistence: (dir: string) => QualityPersistence): Promise<void>;
16
- //# sourceMappingURL=quality-fix-agent.d.ts.map
@@ -1 +0,0 @@
1
- {"version":3,"file":"quality-fix-agent.d.ts","sourceRoot":"","sources":["../../../../server/services/websocket/quality-fix-agent.ts"],"names":[],"mappings":"AAUA,OAAO,KAAK,EAAE,YAAY,EAAE,MAAM,6BAA6B,CAAC;AAEhE,OAAO,KAAK,EAAE,cAAc,EAAE,MAAM,sBAAsB,CAAC;AAC3D,OAAO,KAAK,EAAE,kBAAkB,EAAE,MAAM,0BAA0B,CAAC;AAEnE,OAAO,KAAK,EAAE,SAAS,EAAE,MAAM,YAAY,CAAC;AAI5C,MAAM,WAAW,aAAa;IAC5B,QAAQ,EAAE,MAAM,CAAC;IACjB,QAAQ,EAAE,MAAM,CAAC;IACjB,IAAI,EAAE,MAAM,CAAC;IACb,IAAI,EAAE,MAAM,GAAG,IAAI,CAAC;IACpB,KAAK,EAAE,MAAM,CAAC;IACd,WAAW,EAAE,MAAM,CAAC;IACpB,UAAU,CAAC,EAAE,MAAM,CAAC;CACrB;AAYD,wBAAgB,0BAA0B,CAAC,GAAG,EAAE,cAAc,EAAE,EAAE,EAAE,SAAS,EAAE,UAAU,EAAE,MAAM,IAEvF,OAAO,YAAY,UAmB5B;AAiDD,wBAAsB,eAAe,CACnC,GAAG,EAAE,cAAc,EACnB,EAAE,EAAE,SAAS,EACb,UAAU,EAAE,MAAM,EAClB,OAAO,EAAE,MAAM,EACf,UAAU,EAAE,MAAM,EAClB,OAAO,EAAE,MAAM,GAAG,SAAS,EAC3B,QAAQ,EAAE,aAAa,EAAE,EACzB,cAAc,EAAE,CAAC,GAAG,EAAE,MAAM,KAAK,kBAAkB,GAClD,OAAO,CAAC,IAAI,CAAC,CAiGf"}
@@ -1,181 +0,0 @@
1
- // Copyright (c) 2025-present Mstro, Inc. All rights reserved.
2
- // Licensed under the MIT License. See LICENSE file for details.
3
- /**
4
- * Quality Fix Agent — AI-powered issue fixing using Claude Code headless runner.
5
- *
6
- * Builds the fix prompt, runs the agent, re-scans, and persists updated results.
7
- */
8
- import { ResilientRunner } from '../../cli/headless/resilient-runner.js';
9
- import { loadSkillPrompt } from '../plan/agent-loader.js';
10
- import { detectTools, runQualityScan } from './quality-service.js';
11
- // ── Progress callback ─────────────────────────────────────────
12
- const TOOL_MESSAGES = {
13
- Read: 'Reading files to understand issues...',
14
- Edit: 'Applying fixes...',
15
- Write: 'Writing fixes...',
16
- Grep: 'Searching for related code...',
17
- Bash: 'Running verification...',
18
- };
19
- export function createToolProgressCallback(ctx, ws, reportPath) {
20
- const seenTools = new Set();
21
- return (event) => {
22
- try {
23
- if (event.type === 'tool_start' && event.toolName && !seenTools.has(event.toolName)) {
24
- seenTools.add(event.toolName);
25
- const message = TOOL_MESSAGES[event.toolName];
26
- if (message) {
27
- ctx.send(ws, { type: 'qualityFixProgress', data: { path: reportPath, message } });
28
- }
29
- }
30
- if (event.type === 'tool_complete' && event.toolName === 'Edit' && event.completeInput?.file_path) {
31
- ctx.send(ws, {
32
- type: 'qualityFixProgress',
33
- data: { path: reportPath, message: `Fixed ${String(event.completeInput.file_path).split('/').slice(-2).join('/')}` },
34
- });
35
- }
36
- }
37
- catch {
38
- // WebSocket closed — progress lost but fix operation continues
39
- }
40
- };
41
- }
42
- function startFixHeartbeat(ctx, ws, reportPath, intervalMs = 30_000) {
43
- let elapsed = 0;
44
- const timer = setInterval(() => {
45
- elapsed += intervalMs;
46
- const mins = Math.floor(elapsed / 60_000);
47
- const secs = Math.floor((elapsed % 60_000) / 1000);
48
- const timeStr = mins > 0 ? `${mins}m ${secs}s` : `${secs}s`;
49
- try {
50
- ctx.send(ws, { type: 'qualityFixProgress', data: { path: reportPath, message: `Fixing issues (${timeStr} elapsed, still working...)` } });
51
- }
52
- catch {
53
- // WebSocket closed — heartbeat lost but fix continues
54
- }
55
- }, intervalMs);
56
- return () => clearInterval(timer);
57
- }
58
- // ── Prompt ────────────────────────────────────────────────────
59
- function buildFixPrompt(findings, section) {
60
- const filtered = section ? findings.filter((f) => f.category === section) : findings;
61
- const sorted = filtered.sort((a, b) => {
62
- const order = { critical: 0, high: 1, medium: 2, low: 3 };
63
- return (order[a.severity] ?? 4) - (order[b.severity] ?? 4);
64
- });
65
- const issueList = sorted.slice(0, 30).map((f, i) => {
66
- const loc = f.line ? `${f.file}:${f.line}` : f.file;
67
- const parts = [`${i + 1}. [${f.severity.toUpperCase()}] ${loc} — ${f.title}`];
68
- if (f.description)
69
- parts.push(` ${f.description}`);
70
- if (f.suggestion)
71
- parts.push(` Suggestion: ${f.suggestion}`);
72
- return parts.join('\n');
73
- }).join('\n\n');
74
- const fromSkill = loadSkillPrompt('fix-quality', {
75
- issueList,
76
- issueCount: String(sorted.length),
77
- showCount: String(Math.min(30, sorted.length)),
78
- });
79
- if (fromSkill)
80
- return fromSkill;
81
- return `You are a code quality fix agent. Fix the following quality issues in the codebase.\n\n## Issues to Fix (${sorted.length} total, showing top ${Math.min(30, sorted.length)})\n\n${issueList}\n\nFix each issue by editing the relevant file. Work from most to least severe. Do NOT introduce new issues.`;
82
- }
83
- // ── Handler ───────────────────────────────────────────────────
84
- const activeFixes = new Set();
85
- export async function handleFixIssues(ctx, ws, reportPath, dirPath, workingDir, section, findings, getPersistence) {
86
- if (activeFixes.has(dirPath)) {
87
- ctx.send(ws, {
88
- type: 'qualityError',
89
- data: { path: reportPath, error: 'A fix operation is already running for this directory.' },
90
- });
91
- return;
92
- }
93
- if (findings.length === 0) {
94
- ctx.send(ws, {
95
- type: 'qualityError',
96
- data: { path: reportPath, error: 'No findings to fix.' },
97
- });
98
- return;
99
- }
100
- activeFixes.add(dirPath);
101
- const stopHeartbeat = startFixHeartbeat(ctx, ws, reportPath);
102
- try {
103
- try {
104
- ctx.send(ws, {
105
- type: 'qualityFixProgress',
106
- data: { path: reportPath, message: 'Starting Claude Code to fix issues...' },
107
- });
108
- }
109
- catch { /* WS closed */ }
110
- const prompt = buildFixPrompt(findings, section);
111
- const runner = new ResilientRunner({
112
- workingDir: dirPath,
113
- prompt,
114
- policy: 'STANDARD',
115
- stallWarningMs: 300_000,
116
- stallKillMs: 1_200_000,
117
- stallHardCapMs: 1_800_000,
118
- toolUseCallback: createToolProgressCallback(ctx, ws, reportPath),
119
- logLabel: 'code-review-fix',
120
- });
121
- await runner.run();
122
- try {
123
- ctx.send(ws, {
124
- type: 'qualityFixProgress',
125
- data: { path: reportPath, message: 'Fixes applied. Re-running quality checks...' },
126
- });
127
- }
128
- catch { /* WS closed */ }
129
- // Re-run quality scan after fixing
130
- const { tools: detectedTools } = await detectTools(dirPath);
131
- const installedToolNames = detectedTools.filter((t) => t.installed).map((t) => t.name);
132
- const results = await runQualityScan(dirPath, (progress) => {
133
- try {
134
- ctx.send(ws, {
135
- type: 'qualityScanProgress',
136
- data: { path: reportPath, progress },
137
- });
138
- }
139
- catch { /* WS closed */ }
140
- }, installedToolNames);
141
- // Persist before sending — results survive WebSocket drops
142
- try {
143
- const persistence = getPersistence(workingDir);
144
- persistence.saveReport(reportPath, results);
145
- persistence.appendHistory(results, reportPath);
146
- }
147
- catch {
148
- // Persistence failure should not break the fix flow
149
- }
150
- const resultData = { path: reportPath, results };
151
- try {
152
- ctx.send(ws, { type: 'qualityFixComplete', data: resultData });
153
- }
154
- catch {
155
- // WebSocket closed — save as pending for delivery on reconnect
156
- const persistence = getPersistence(workingDir);
157
- persistence.addPendingResult({
158
- type: 'fixComplete',
159
- path: reportPath,
160
- data: resultData,
161
- completedAt: new Date().toISOString(),
162
- });
163
- }
164
- }
165
- catch (error) {
166
- try {
167
- ctx.send(ws, {
168
- type: 'qualityError',
169
- data: { path: reportPath, error: error instanceof Error ? error.message : String(error) },
170
- });
171
- }
172
- catch {
173
- // WebSocket closed — error lost but operation tracked via activeOps
174
- }
175
- }
176
- finally {
177
- stopHeartbeat();
178
- activeFixes.delete(dirPath);
179
- }
180
- }
181
- //# sourceMappingURL=quality-fix-agent.js.map
@@ -1 +0,0 @@
1
- {"version":3,"file":"quality-fix-agent.js","sourceRoot":"","sources":["../../../../server/services/websocket/quality-fix-agent.ts"],"names":[],"mappings":"AAAA,8DAA8D;AAC9D,gEAAgE;AAEhE;;;;GAIG;AAEH,OAAO,EAAE,eAAe,EAAE,MAAM,wCAAwC,CAAC;AAEzE,OAAO,EAAE,eAAe,EAAE,MAAM,yBAAyB,CAAC;AAG1D,OAAO,EAAE,WAAW,EAAE,cAAc,EAAE,MAAM,sBAAsB,CAAC;AAenE,iEAAiE;AAEjE,MAAM,aAAa,GAA2B;IAC5C,IAAI,EAAE,uCAAuC;IAC7C,IAAI,EAAE,mBAAmB;IACzB,KAAK,EAAE,kBAAkB;IACzB,IAAI,EAAE,+BAA+B;IACrC,IAAI,EAAE,yBAAyB;CAChC,CAAC;AAEF,MAAM,UAAU,0BAA0B,CAAC,GAAmB,EAAE,EAAa,EAAE,UAAkB;IAC/F,MAAM,SAAS,GAAG,IAAI,GAAG,EAAU,CAAC;IACpC,OAAO,CAAC,KAAmB,EAAE,EAAE;QAC7B,IAAI,CAAC;YACH,IAAI,KAAK,CAAC,IAAI,KAAK,YAAY,IAAI,KAAK,CAAC,QAAQ,IAAI,CAAC,SAAS,CAAC,GAAG,CAAC,KAAK,CAAC,QAAQ,CAAC,EAAE,CAAC;gBACpF,SAAS,CAAC,GAAG,CAAC,KAAK,CAAC,QAAQ,CAAC,CAAC;gBAC9B,MAAM,OAAO,GAAG,aAAa,CAAC,KAAK,CAAC,QAAQ,CAAC,CAAC;gBAC9C,IAAI,OAAO,EAAE,CAAC;oBACZ,GAAG,CAAC,IAAI,CAAC,EAAE,EAAE,EAAE,IAAI,EAAE,oBAAoB,EAAE,IAAI,EAAE,EAAE,IAAI,EAAE,UAAU,EAAE,OAAO,EAAE,EAAE,CAAC,CAAC;gBACpF,CAAC;YACH,CAAC;YACD,IAAI,KAAK,CAAC,IAAI,KAAK,eAAe,IAAI,KAAK,CAAC,QAAQ,KAAK,MAAM,IAAI,KAAK,CAAC,aAAa,EAAE,SAAS,EAAE,CAAC;gBAClG,GAAG,CAAC,IAAI,CAAC,EAAE,EAAE;oBACX,IAAI,EAAE,oBAAoB;oBAC1B,IAAI,EAAE,EAAE,IAAI,EAAE,UAAU,EAAE,OAAO,EAAE,SAAS,MAAM,CAAC,KAAK,CAAC,aAAa,CAAC,SAAS,CAAC,CAAC,KAAK,CAAC,GAAG,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,GAAG,CAAC,EAAE,EAAE;iBACrH,CAAC,CAAC;YACL,CAAC;QACH,CAAC;QAAC,MAAM,CAAC;YACP,+DAA+D;QACjE,CAAC;IACH,CAAC,CAAC;AACJ,CAAC;AAED,SAAS,iBAAiB,CAAC,GAAmB,EAAE,EAAa,EAAE,UAAkB,EAAE,UAAU,GAAG,MAAM;IACpG,IAAI,OAAO,GAAG,CAAC,CAAC;IAChB,MAAM,KAAK,GAAG,WAAW,CAAC,GAAG,EAAE;QAC7B,OAAO,IAAI,UAAU,CAAC;QACtB,MAAM,IAAI,GAAG,IAAI,CAAC,KAAK,CAAC,OAAO,GAAG,MAAM,CAAC,CAAC;QAC1C,MAAM,IAAI,GAAG,IAAI,CAAC,KAAK,CAAC,CAAC,OAAO,GAAG,MAAM,CAAC,GAAG,IAAI,CAAC,CAAC;QACnD,MAAM,OAAO,GAAG,IAAI,GAAG,CAAC,CAAC,CAAC,CAAC,GAAG,IAAI,KAAK,IAAI,GAAG,CAAC,CAAC,CAAC,GAAG,IAAI,GAAG,CAAC;QAC5D,IAAI,CAAC;YACH,GAAG,CAAC,IAAI,CAAC,EAAE,EAAE,EAAE,IAAI,EAAE,oBAAoB,EAAE,IAAI,EAAE,EAAE,IAAI,EAAE,UAAU,EAAE,OAAO,EAAE,kBAAkB,OAAO,6BAA6B,EAAE,EAAE,CAAC,CAAC;QAC5I,CAAC;QAAC,MAAM,CAAC;YACP,sDAAsD;QACxD,CAAC;IACH,CAAC,EAAE,UAAU,CAAC,CAAC;IACf,OAAO,GAAG,EAAE,CAAC,aAAa,CAAC,KAAK,CAAC,CAAC;AACpC,CAAC;AAED,iEAAiE;AAEjE,SAAS,cAAc,CAAC,QAAyB,EAAE,OAAgB;IACjE,MAAM,QAAQ,GAAG,OAAO,CAAC,CAAC,CAAC,QAAQ,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,QAAQ,KAAK,OAAO,CAAC,CAAC,CAAC,CAAC,QAAQ,CAAC;IACrF,MAAM,MAAM,GAAG,QAAQ,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC,EAAE,EAAE;QACpC,MAAM,KAAK,GAA2B,EAAE,QAAQ,EAAE,CAAC,EAAE,IAAI,EAAE,CAAC,EAAE,MAAM,EAAE,CAAC,EAAE,GAAG,EAAE,CAAC,EAAE,CAAC;QAClF,OAAO,CAAC,KAAK,CAAC,CAAC,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC,GAAG,CAAC,KAAK,CAAC,CAAC,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC,CAAC;IAC7D,CAAC,CAAC,CAAC;IAEH,MAAM,SAAS,GAAG,MAAM,CAAC,KAAK,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,CAAC,EAAE,EAAE;QACjD,MAAM,GAAG,GAAG,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,IAAI,IAAI,CAAC,CAAC,IAAI,EAAE,CAAC,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC;QACpD,MAAM,KAAK,GAAG,CAAC,GAAG,CAAC,GAAG,CAAC,MAAM,CAAC,CAAC,QAAQ,CAAC,WAAW,EAAE,KAAK,GAAG,MAAM,CAAC,CAAC,KAAK,EAAE,CAAC,CAAC;QAC9E,IAAI,CAAC,CAAC,WAAW;YAAE,KAAK,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC,WAAW,EAAE,CAAC,CAAC;QACrD,IAAI,CAAC,CAAC,UAAU;YAAE,KAAK,CAAC,IAAI,CAAC,kBAAkB,CAAC,CAAC,UAAU,EAAE,CAAC,CAAC;QAC/D,OAAO,KAAK,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;IAC1B,CAAC,CAAC,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC;IAEhB,MAAM,SAAS,GAAG,eAAe,CAAC,aAAa,EAAE;QAC/C,SAAS;QACT,UAAU,EAAE,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC;QACjC,SAAS,EAAE,MAAM,CAAC,IAAI,CAAC,GAAG,CAAC,EAAE,EAAE,MAAM,CAAC,MAAM,CAAC,CAAC;KAC/C,CAAC,CAAC;IACH,IAAI,SAAS;QAAE,OAAO,SAAS,CAAC;IAEhC,OAAO,4GAA4G,MAAM,CAAC,MAAM,uBAAuB,IAAI,CAAC,GAAG,CAAC,EAAE,EAAE,MAAM,CAAC,MAAM,CAAC,QAAQ,SAAS,+GAA+G,CAAC;AACrT,CAAC;AAED,iEAAiE;AAEjE,MAAM,WAAW,GAAG,IAAI,GAAG,EAAU,CAAC;AAEtC,MAAM,CAAC,KAAK,UAAU,eAAe,CACnC,GAAmB,EACnB,EAAa,EACb,UAAkB,EAClB,OAAe,EACf,UAAkB,EAClB,OAA2B,EAC3B,QAAyB,EACzB,cAAmD;IAEnD,IAAI,WAAW,CAAC,GAAG,CAAC,OAAO,CAAC,EAAE,CAAC;QAC7B,GAAG,CAAC,IAAI,CAAC,EAAE,EAAE;YACX,IAAI,EAAE,cAAc;YACpB,IAAI,EAAE,EAAE,IAAI,EAAE,UAAU,EAAE,KAAK,EAAE,wDAAwD,EAAE;SAC5F,CAAC,CAAC;QACH,OAAO;IACT,CAAC;IAED,IAAI,QAAQ,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;QAC1B,GAAG,CAAC,IAAI,CAAC,EAAE,EAAE;YACX,IAAI,EAAE,cAAc;YACpB,IAAI,EAAE,EAAE,IAAI,EAAE,UAAU,EAAE,KAAK,EAAE,qBAAqB,EAAE;SACzD,CAAC,CAAC;QACH,OAAO;IACT,CAAC;IAED,WAAW,CAAC,GAAG,CAAC,OAAO,CAAC,CAAC;IACzB,MAAM,aAAa,GAAG,iBAAiB,CAAC,GAAG,EAAE,EAAE,EAAE,UAAU,CAAC,CAAC;IAC7D,IAAI,CAAC;QACH,IAAI,CAAC;YACH,GAAG,CAAC,IAAI,CAAC,EAAE,EAAE;gBACX,IAAI,EAAE,oBAAoB;gBAC1B,IAAI,EAAE,EAAE,IAAI,EAAE,UAAU,EAAE,OAAO,EAAE,uCAAuC,EAAE;aAC7E,CAAC,CAAC;QACL,CAAC;QAAC,MAAM,CAAC,CAAC,eAAe,CAAC,CAAC;QAE3B,MAAM,MAAM,GAAG,cAAc,CAAC,QAAQ,EAAE,OAAO,CAAC,CAAC;QAEjD,MAAM,MAAM,GAAG,IAAI,eAAe,CAAC;YACjC,UAAU,EAAE,OAAO;YACnB,MAAM;YACN,MAAM,EAAE,UAAU;YAClB,cAAc,EAAE,OAAO;YACvB,WAAW,EAAE,SAAS;YACtB,cAAc,EAAE,SAAS;YACzB,eAAe,EAAE,0BAA0B,CAAC,GAAG,EAAE,EAAE,EAAE,UAAU,CAAC;YAChE,QAAQ,EAAE,iBAAiB;SAC5B,CAAC,CAAC;QAEH,MAAM,MAAM,CAAC,GAAG,EAAE,CAAC;QAEnB,IAAI,CAAC;YACH,GAAG,CAAC,IAAI,CAAC,EAAE,EAAE;gBACX,IAAI,EAAE,oBAAoB;gBAC1B,IAAI,EAAE,EAAE,IAAI,EAAE,UAAU,EAAE,OAAO,EAAE,6CAA6C,EAAE;aACnF,CAAC,CAAC;QACL,CAAC;QAAC,MAAM,CAAC,CAAC,eAAe,CAAC,CAAC;QAE3B,mCAAmC;QACnC,MAAM,EAAE,KAAK,EAAE,aAAa,EAAE,GAAG,MAAM,WAAW,CAAC,OAAO,CAAC,CAAC;QAC5D,MAAM,kBAAkB,GAAG,aAAa,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,SAAS,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC;QAEvF,MAAM,OAAO,GAAG,MAAM,cAAc,CAAC,OAAO,EAAE,CAAC,QAAQ,EAAE,EAAE;YACzD,IAAI,CAAC;gBACH,GAAG,CAAC,IAAI,CAAC,EAAE,EAAE;oBACX,IAAI,EAAE,qBAAqB;oBAC3B,IAAI,EAAE,EAAE,IAAI,EAAE,UAAU,EAAE,QAAQ,EAAE;iBACrC,CAAC,CAAC;YACL,CAAC;YAAC,MAAM,CAAC,CAAC,eAAe,CAAC,CAAC;QAC7B,CAAC,EAAE,kBAAkB,CAAC,CAAC;QAEvB,2DAA2D;QAC3D,IAAI,CAAC;YACH,MAAM,WAAW,GAAG,cAAc,CAAC,UAAU,CAAC,CAAC;YAC/C,WAAW,CAAC,UAAU,CAAC,UAAU,EAAE,OAAO,CAAC,CAAC;YAC5C,WAAW,CAAC,aAAa,CAAC,OAAO,EAAE,UAAU,CAAC,CAAC;QACjD,CAAC;QAAC,MAAM,CAAC;YACP,oDAAoD;QACtD,CAAC;QAED,MAAM,UAAU,GAAG,EAAE,IAAI,EAAE,UAAU,EAAE,OAAO,EAAE,CAAC;QACjD,IAAI,CAAC;YACH,GAAG,CAAC,IAAI,CAAC,EAAE,EAAE,EAAE,IAAI,EAAE,oBAAoB,EAAE,IAAI,EAAE,UAAU,EAAE,CAAC,CAAC;QACjE,CAAC;QAAC,MAAM,CAAC;YACP,+DAA+D;YAC/D,MAAM,WAAW,GAAG,cAAc,CAAC,UAAU,CAAC,CAAC;YAC/C,WAAW,CAAC,gBAAgB,CAAC;gBAC3B,IAAI,EAAE,aAAa;gBACnB,IAAI,EAAE,UAAU;gBAChB,IAAI,EAAE,UAAgD;gBACtD,WAAW,EAAE,IAAI,IAAI,EAAE,CAAC,WAAW,EAAE;aACtC,CAAC,CAAC;QACL,CAAC;IACH,CAAC;IAAC,OAAO,KAAK,EAAE,CAAC;QACf,IAAI,CAAC;YACH,GAAG,CAAC,IAAI,CAAC,EAAE,EAAE;gBACX,IAAI,EAAE,cAAc;gBACpB,IAAI,EAAE,EAAE,IAAI,EAAE,UAAU,EAAE,KAAK,EAAE,KAAK,YAAY,KAAK,CAAC,CAAC,CAAC,KAAK,CAAC,OAAO,CAAC,CAAC,CAAC,MAAM,CAAC,KAAK,CAAC,EAAE;aAC1F,CAAC,CAAC;QACL,CAAC;QAAC,MAAM,CAAC;YACP,oEAAoE;QACtE,CAAC;IACH,CAAC;YAAS,CAAC;QACT,aAAa,EAAE,CAAC;QAChB,WAAW,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC;IAC9B,CAAC;AACH,CAAC"}