moflo 4.8.10 → 4.8.12

package/bin/session-start-launcher.mjs

@@ -8,7 +8,7 @@
  */
 
 import { spawn } from 'child_process';
-import { existsSync, readFileSync, copyFileSync } from 'fs';
+import { existsSync, readFileSync, copyFileSync, unlinkSync, readdirSync } from 'fs';
 import { resolve, dirname } from 'path';
 import { fileURLToPath } from 'url';
 
@@ -75,54 +75,87 @@ try {
     try { cachedVersion = readFileSync(versionStampPath, 'utf-8').trim(); } catch {}
 
     if (installedVersion !== cachedVersion) {
+      const binDir = resolve(projectRoot, 'node_modules/moflo/bin');
+      const manifestPath = resolve(projectRoot, '.claude-flow', 'installed-files.json');
+
+      // ── Manifest-based auto-update ──────────────────────────────────────
+      //
+      // IMPORTANT: Every file moflo installs into the destination project
+      // MUST be recorded in `currentManifest` via syncFile() or a manual
+      // push. On upgrade, files in the OLD manifest but NOT in the new one
+      // are deleted — this is how we clean up files from prior versions
+      // without accidentally deleting user-created or runtime files.
+      //
+      // When adding/removing files from the sync lists below:
+      //  1. Use syncFile() for copied files (it records automatically)
+      //  2. Push to currentManifest manually for generated files
+      //  3. That's it — cleanup is automatic on the next upgrade
+      // ────────────────────────────────────────────────────────────────────
+
+      // Load the previous manifest so we can diff after syncing
+      let previousManifest = [];
+      try { previousManifest = JSON.parse(readFileSync(manifestPath, 'utf-8')); } catch { /* ok */ }
+
+      // Track every file we install this round
+      const currentManifest = [];
+
+      /** Copy src → dest if src exists, record in manifest. */
+      function syncFile(src, dest, manifestKey) {
+        if (existsSync(src)) {
+          try { copyFileSync(src, dest); currentManifest.push(manifestKey); } catch { /* non-fatal */ }
+        }
+      }
+
       // Version changed — sync scripts from bin/
       if (autoUpdateConfig.scripts) {
-        const binDir = resolve(projectRoot, 'node_modules/moflo/bin');
         const scriptsDir = resolve(projectRoot, '.claude/scripts');
         const scriptFiles = [
           'hooks.mjs', 'session-start-launcher.mjs', 'index-guidance.mjs',
           'build-embeddings.mjs', 'generate-code-map.mjs', 'semantic-search.mjs',
+          'index-tests.mjs',
         ];
         for (const file of scriptFiles) {
-          const src = resolve(binDir, file);
-          const dest = resolve(scriptsDir, file);
-          if (existsSync(src)) {
-            try { copyFileSync(src, dest); } catch { /* non-fatal */ }
-          }
+          syncFile(resolve(binDir, file), resolve(scriptsDir, file), `.claude/scripts/${file}`);
         }
       }
 
-      // Sync helpers from source .claude/helpers/
+      // Sync helpers from bin/ and source .claude/helpers/
       if (autoUpdateConfig.helpers) {
-        const sourceHelpersDir = resolve(projectRoot, 'node_modules/moflo/src/@claude-flow/cli/.claude/helpers');
         const helpersDir = resolve(projectRoot, '.claude/helpers');
-        const helperFiles = [
-          'auto-memory-hook.mjs', 'statusline.cjs', 'pre-commit', 'post-commit',
+        if (!existsSync(helpersDir)) mkdirSync(helpersDir, { recursive: true });
+
+        // Gate and hook helpers — shipped as static files in bin/
+        const binHelperFiles = [
+          'gate.cjs', 'gate-hook.mjs', 'prompt-hook.mjs', 'hook-handler.cjs',
         ];
-        for (const file of helperFiles) {
-          const src = resolve(sourceHelpersDir, file);
-          const dest = resolve(helpersDir, file);
-          if (existsSync(src)) {
-            try { copyFileSync(src, dest); } catch { /* non-fatal */ }
-          }
+        for (const file of binHelperFiles) {
+          syncFile(resolve(binDir, file), resolve(helpersDir, file), `.claude/helpers/${file}`);
         }
 
-        // Also sync generated helpers via upgrade CLI (hook-handler.cjs, gate.cjs, etc.)
-        // These are generated, not shipped, so we trigger an upgrade in the background
-        const localCli = resolve(projectRoot, 'node_modules/moflo/src/@claude-flow/cli/bin/cli.js');
-        if (existsSync(localCli)) {
-          try {
-            const proc = spawn('node', [localCli, 'init', '--upgrade', '--quiet'], {
-              cwd: projectRoot, stdio: 'ignore', detached: true, windowsHide: true,
-            });
-            proc.unref();
-          } catch { /* non-fatal */ }
+        // Other helpers from .claude/helpers/ and CLI .claude/helpers/
+        const helperSources = [
+          resolve(projectRoot, 'node_modules/moflo/.claude/helpers'),
+          resolve(projectRoot, 'node_modules/moflo/src/@claude-flow/cli/.claude/helpers'),
+        ];
+        const sourceHelperFiles = [
+          'auto-memory-hook.mjs', 'statusline.cjs', 'intelligence.cjs', 'pre-commit', 'post-commit',
+        ];
+        for (const file of sourceHelperFiles) {
+          const dest = resolve(helpersDir, file);
+          for (const srcDir of helperSources) {
+            const src = resolve(srcDir, file);
+            if (existsSync(src)) {
+              try { copyFileSync(src, dest); currentManifest.push(`.claude/helpers/${file}`); } catch { /* non-fatal */ }
+              break; // first source wins
+            }
+          }
         }
       }
 
       // Sync guidance bootstrap file (moflo-bootstrap.md)
-      // Ensures subagents can read guidance directly from disk
-      const bootstrapSrc = resolve(projectRoot, 'node_modules/moflo/.claude/guidance/agent-bootstrap.md');
+      const shippedBootstrap = resolve(projectRoot, 'node_modules/moflo/.claude/guidance/shipped/agent-bootstrap.md');
+      const legacyBootstrap = resolve(projectRoot, 'node_modules/moflo/.claude/guidance/agent-bootstrap.md');
+      const bootstrapSrc = existsSync(shippedBootstrap) ? shippedBootstrap : legacyBootstrap;
       const guidanceDir = resolve(projectRoot, '.claude/guidance');
       const bootstrapDest = resolve(guidanceDir, 'moflo-bootstrap.md');
       if (existsSync(bootstrapSrc)) {
@@ -131,13 +164,28 @@ try {
           const header = '<!-- AUTO-GENERATED by moflo session-start. Do not edit — changes will be overwritten. -->\n<!-- Source: node_modules/moflo/.claude/guidance/agent-bootstrap.md -->\n\n';
           const content = readFileSync(bootstrapSrc, 'utf-8');
           writeFileSync(bootstrapDest, header + content);
+          currentManifest.push('.claude/guidance/moflo-bootstrap.md');
         } catch { /* non-fatal */ }
       }
 
-      // Write version stamp
+      // ── Clean up files we installed previously but no longer ship ──
+      // Only remove files that are in the OLD manifest but NOT in the new one.
+      // This ensures we never delete user-created or runtime-generated files.
+      if (previousManifest.length > 0) {
+        const currentSet = new Set(currentManifest);
+        for (const rel of previousManifest) {
+          if (!currentSet.has(rel)) {
+            const abs = resolve(projectRoot, rel);
+            try { if (existsSync(abs)) unlinkSync(abs); } catch { /* non-fatal */ }
+          }
+        }
+      }
+
+      // Write updated manifest + version stamp
       try {
         const cfDir = resolve(projectRoot, '.claude-flow');
         if (!existsSync(cfDir)) mkdirSync(cfDir, { recursive: true });
+        writeFileSync(manifestPath, JSON.stringify(currentManifest, null, 2));
         writeFileSync(versionStampPath, installedVersion);
       } catch {}
     }
@@ -149,7 +197,9 @@ try {
 // ── 3b. Ensure guidance bootstrap file exists (even without version change) ──
 // Subagents need this file on disk for direct reads without memory search.
 try {
-  const bootstrapSrc = resolve(projectRoot, 'node_modules/moflo/.claude/guidance/agent-bootstrap.md');
+  const shippedBs = resolve(projectRoot, 'node_modules/moflo/.claude/guidance/shipped/agent-bootstrap.md');
+  const legacyBs = resolve(projectRoot, 'node_modules/moflo/.claude/guidance/agent-bootstrap.md');
+  const bootstrapSrc = existsSync(shippedBs) ? shippedBs : legacyBs;
   const guidanceDir = resolve(projectRoot, '.claude/guidance');
   const bootstrapDest = resolve(guidanceDir, 'moflo-bootstrap.md');
   if (existsSync(bootstrapSrc) && !existsSync(bootstrapDest)) {

package/bin/setup-project.mjs

@@ -29,67 +29,57 @@ const args = process.argv.slice(2);
 const updateOnly = args.includes('--update');
 const checkOnly = args.includes('--check');
 
-// Markers for idempotent CLAUDE.md updates
-const MARKER_START = '<!-- MOFLO:SUBAGENT-PROTOCOL:START -->';
-const MARKER_END = '<!-- MOFLO:SUBAGENT-PROTOCOL:END -->';
-
+// Markers for idempotent CLAUDE.md updates — keep in sync with claudemd-generator.ts
+const MARKER_START = '<!-- MOFLO:INJECTED:START -->';
+const MARKER_END = '<!-- MOFLO:INJECTED:END -->';
+// Legacy markers to detect and replace
+const LEGACY_STARTS = ['<!-- MOFLO:SUBAGENT-PROTOCOL:START -->', '<!-- MOFLO:START -->'];
+const LEGACY_ENDS = ['<!-- MOFLO:SUBAGENT-PROTOCOL:END -->', '<!-- MOFLO:END -->'];
+
+// Minimal injection — just enough for Claude to work with moflo.
+// All detailed docs live in .claude/guidance/shipped/moflo.md.
 const CLAUDE_MD_SECTION = `${MARKER_START}
-## FIRST ACTION ON EVERY PROMPT: Search Memory
+## MoFlo — AI Agent Orchestration
 
-Your first tool call for every new user prompt MUST be a memory search. Do this BEFORE Glob, Grep, Read, or any file exploration. No exceptions.
+This project uses [MoFlo](https://github.com/eric-cielo/moflo) for AI-assisted development workflows.
 
-WHY: Memory contains curated solutions, patterns, and architectural context from previous work. Without it, you will miss existing solutions, repeat mistakes that were already solved, and waste time re-discovering what is already known. Memory search is faster than file scanning.
+### FIRST ACTION ON EVERY PROMPT: Search Memory
 
-HOW: Use ToolSearch to load \`mcp__claude-flow__memory_search\`, then call it with a query describing your task. If MCP is unavailable, use:
-\`node bin/semantic-search.mjs "[task description]" --namespace guidance\`
+Your first tool call for every new user prompt MUST be a memory search. Do this BEFORE Glob, Grep, Read, or any file exploration.
 
-### Namespaces to search:
+\`\`\`
+mcp__moflo__memory_search — query: "<task description>", namespace: "guidance" or "patterns" or "code-map"
+\`\`\`
 
-| Namespace | When to search | What it returns |
-|-----------|---------------|-----------------|
-| \`guidance\` | Always — understanding patterns, rules, conventions | Guidance docs, coding rules, domain context |
-| \`patterns\` | Always — prior solutions and implementation patterns | Learned patterns from previous task execution |
-| \`code-map\` | Finding where code lives (files, types, services) | Type-to-file mappings, directory contents, project overviews |
+Search \`guidance\` and \`patterns\` namespaces on every prompt. Search \`code-map\` when navigating the codebase.
+When the user asks you to remember something: \`mcp__moflo__memory_store\` with namespace \`knowledge\`.
 
-**Always search both \`guidance\` and \`patterns\` namespaces.** The \`patterns\` namespace contains solutions to problems already solved — skipping it means repeating past mistakes.
+### Workflow Gates (enforced automatically)
 
-For **codebase navigation** (finding where a type/service/component lives), also search the \`code-map\` namespace.
+- **Memory-first**: Must search memory before Glob/Grep/Read
+- **TaskCreate-first**: Must call TaskCreate before spawning Agent tool
 
-## Memory System Access (MoFlo)
+### MCP Tools (preferred over CLI)
 
-### Primary: MCP Tools (preferred)
-\`\`\`
-mcp__claude-flow__memory_search   — query, namespace
-mcp__claude-flow__memory_store    — key, value, namespace
-mcp__claude-flow__memory_retrieve — key, namespace
-mcp__claude-flow__memory_list     — namespace, limit
-\`\`\`
-Load via ToolSearch first: \`+claude-flow memory\`
+| Tool | Purpose |
+|------|---------|
+| \`mcp__moflo__memory_search\` | Semantic search across indexed knowledge |
+| \`mcp__moflo__memory_store\` | Store patterns and decisions |
+| \`mcp__moflo__hooks_route\` | Route task to optimal agent type |
+| \`mcp__moflo__hooks_pre-task\` | Record task start |
+| \`mcp__moflo__hooks_post-task\` | Record task completion for learning |
+
+### CLI Fallback
 
-### Fallback: CLI Scripts
 \`\`\`bash
 npx flo-search "[query]" --namespace guidance   # Semantic search
-npx flo-embeddings                               # Rebuild embeddings
-npx flo-index                                    # Re-index guidance docs
-npx flo-codemap --force                          # Regenerate code-map
+npx flo doctor --fix                             # Health check
 \`\`\`
 
-### Where Content Goes
-
-| Content Type | Destination | How to Write |
-|-------------|-------------|--------------|
-| Debugging lessons (bug found, root cause, fix) | Memory DB — \`patterns\` namespace | \`mcp__claude-flow__memory_store\` |
-| Architectural decisions (chose X over Y, why) | Memory DB — \`decisions\` namespace | \`mcp__claude-flow__memory_store\` |
-| Learned patterns (task succeeded/failed, what worked) | Memory DB — \`patterns\` namespace | \`mcp__claude-flow__memory_store\` |
-| Coding rules (always/never do X in code) | \`.claude/guidance/\` files | Edit directly |
-| Process/workflow rules (CI, PR, gates) | \`CLAUDE.md\` | Edit directly |
+### Full Reference
 
-## Subagent Protocol (MoFlo)
-
-All subagents MUST read \`.claude/guidance/moflo-bootstrap.md\` before starting any work.
-It contains the memory-first protocol, discovery storage rules, and universal conventions.
-
-If \`.claude/guidance/agent-bootstrap.md\` also exists, read it next for project-specific rules.
+For CLI commands, hooks, agents, swarm config, memory commands, and moflo.yaml options, see:
+\`.claude/guidance/shipped/moflo.md\`
 ${MARKER_END}`;
 
 function log(msg) {
@@ -124,7 +114,10 @@ function findProjectRoot() {
 }
 
 function copyBootstrap(projectRoot) {
-  const source = join(mofloRoot, '.claude', 'guidance', 'agent-bootstrap.md');
+  const shippedSource = join(mofloRoot, '.claude', 'guidance', 'shipped', 'agent-bootstrap.md');
+  const source = existsSync(shippedSource)
+    ? shippedSource
+    : join(mofloRoot, '.claude', 'guidance', 'agent-bootstrap.md');
   const targetDir = join(projectRoot, '.claude', 'guidance');
   const target = join(targetDir, 'moflo-bootstrap.md');
 
@@ -177,28 +170,35 @@ function updateClaudeMd(projectRoot) {
 
   const content = readFileSync(claudeMdPath, 'utf-8');
 
-  // Check if markers already exist
-  if (content.includes(MARKER_START)) {
-    // Extract existing section and compare
-    const startIdx = content.indexOf(MARKER_START);
-    const endIdx = content.indexOf(MARKER_END);
+  // Check for current or legacy markers and replace
+  const allStarts = [MARKER_START, ...LEGACY_STARTS];
+  const allEnds = [MARKER_END, ...LEGACY_ENDS];
+
+  for (let i = 0; i < allStarts.length; i++) {
+    if (content.includes(allStarts[i])) {
+      const startIdx = content.indexOf(allStarts[i]);
+      const endIdx = content.indexOf(allEnds[i]);
+
+      if (endIdx > startIdx) {
+        // If current markers and content matches, we're up to date
+        if (i === 0) {
+          const existingSection = content.substring(startIdx, endIdx + allEnds[i].length);
+          if (existingSection === CLAUDE_MD_SECTION) {
+            log('✅ CLAUDE.md moflo section is current');
+            return true;
+          }
+        }
 
-    if (endIdx > startIdx) {
-      const existingSection = content.substring(startIdx, endIdx + MARKER_END.length);
-      if (existingSection === CLAUDE_MD_SECTION) {
-        log('✅ CLAUDE.md subagent section is current');
+        // Replace (current or legacy) with new section
+        if (!checkOnly) {
+          const updated = content.substring(0, startIdx) + CLAUDE_MD_SECTION + content.substring(endIdx + allEnds[i].length);
+          writeFileSync(claudeMdPath, updated, 'utf-8');
+          log(i === 0 ? '📝 Updated CLAUDE.md moflo section' : '📝 Replaced legacy CLAUDE.md section with minimal moflo injection');
+        } else {
+          log('⚠️  CLAUDE.md moflo section needs update');
+        }
         return true;
       }
-
-      // Update existing section
-      if (!checkOnly) {
-        const updated = content.substring(0, startIdx) + CLAUDE_MD_SECTION + content.substring(endIdx + MARKER_END.length);
-        writeFileSync(claudeMdPath, updated, 'utf-8');
-        log('📝 Updated CLAUDE.md subagent protocol section');
-      } else {
-        log('⚠️  CLAUDE.md subagent section needs update');
-      }
-      return true;
     }
   }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "moflo",
-  "version": "4.8.10",
+  "version": "4.8.12",
   "description": "MoFlo — AI agent orchestration for Claude Code. Forked from ruflo/claude-flow with patches applied to source, plus feature-level orchestration.",
   "main": "dist/index.js",
   "type": "module",
@@ -11,6 +11,7 @@
     "flo-search": "bin/semantic-search.mjs",
     "flo-embeddings": "bin/build-embeddings.mjs",
     "flo-index": "bin/index-guidance.mjs",
+    "flo-testmap": "bin/index-tests.mjs",
     "flo-learn": ".claude/helpers/learning-service.mjs",
     "moflo": "bin/cli.js",
     "claude-flow": "bin/cli.js"
@@ -40,6 +41,7 @@
     "src/@claude-flow/memory/package.json",
     ".claude-plugin/**",
     ".claude/**",
+    "!.claude/guidance/internal/**",
     "!.claude/**/*.db",
     "!.claude/**/*.map",
     "README.md",
@@ -83,7 +85,7 @@
     "@types/bcrypt": "^5.0.2",
     "@types/node": "^20.19.37",
     "eslint": "^8.0.0",
-    "moflo": "^4.8.9",
+    "moflo": "^4.8.11",
     "tsx": "^4.21.0",
     "typescript": "^5.9.3",
     "vitest": "^4.0.0"

package/src/@claude-flow/cli/README.md

@@ -433,7 +433,7 @@ MoFlo uses a SQLite database (via sql.js/WASM — no native deps) to store three
 
 When `flo init` runs, it appends a workflow section to your CLAUDE.md that teaches Claude:
 - Always search memory before Glob/Grep/Read (enforced by gates)
-- Use `mcp__claude-flow__memory_search` for knowledge retrieval
+- Use `mcp__moflo__memory_search` for knowledge retrieval
 - Use `/flo <issue>` (or `/fl`) for issue execution
 - Store learnings after task completion