mobx 7.0.5 → 7.0.6

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "mobx",
-    "version": "7.0.5",
+    "version": "7.0.6",
     "description": "Simple, scalable state management.",
     "source": "src/mobx.ts",
     "type": "commonjs",

package/src/core/reaction.ts

@@ -66,6 +66,7 @@ export class Reaction implements IDerivation, IReactionPublic {
     unboundDepsCount_ = 0
 
     private flags_ = 0b00000
+    private removeAbortListener_: Lambda | undefined = undefined
 
     constructor(
         public name_: string = __DEV__ ? "Reaction@" + getNextId() : "Reaction",
@@ -221,6 +222,8 @@ export class Reaction implements IDerivation, IReactionPublic {
     dispose() {
         if (!this.isDisposed) {
             this.isDisposed = true
+            // also covers self-disposal (`r.dispose()`, `when`), which bypasses the disposer
+            this.removeAbortListener_?.()
             if (!this.isRunning) {
                 // if disposed while running, clean up later. Maybe not optimal, but rare case
                 startBatch()
@@ -231,11 +234,11 @@ export class Reaction implements IDerivation, IReactionPublic {
     }
 
     getDisposer_(abortSignal?: GenericAbortSignal): IReactionDisposer {
-        const dispose = (() => {
-            this.dispose()
-            abortSignal?.removeEventListener?.("abort", dispose)
-        }) as IReactionDisposer
-        abortSignal?.addEventListener?.("abort", dispose)
+        const dispose = (() => this.dispose()) as IReactionDisposer
+        if (abortSignal?.addEventListener && !this.isDisposed) {
+            abortSignal.addEventListener("abort", dispose)
+            this.removeAbortListener_ = () => abortSignal.removeEventListener?.("abort", dispose)
+        }
         dispose[$mobx] = this
 
         if ("dispose" in Symbol && typeof Symbol.dispose === "symbol") {

package/src/types/observablearray.ts

@@ -95,8 +95,7 @@ const arrayTraps = {
         const adm: ObservableArrayAdministration = target[$mobx]
         if (name === "length") {
             adm.setArrayLength_(value)
-        }
-        if (typeof name === "symbol" || isNaN(name)) {
+        } else if (typeof name === "symbol" || isNaN(name)) {
             target[name] = value
         } else {
             // numeric string
@@ -151,7 +150,7 @@ export class ObservableArrayAdministration
     }
 
     setArrayLength_(newLength: number) {
-        if (typeof newLength !== "number" || isNaN(newLength) || newLength < 0) {
+        if (!Number.isInteger(newLength) || newLength < 0) {
             die(40, newLength)
         }
         let currentLength = this.values_.length

package/src/types/observableset.ts

@@ -127,7 +127,8 @@ export class ObservableSet<T = any> implements Set<T>, IInterceptable<ISetWillCh
         }
         if (!this.has(value)) {
             transaction(() => {
-                this.data_.add(this.enhancer_(value, undefined))
+                value = this.enhancer_(value, undefined) // report the stored value, like map and array
+                this.data_.add(value)
                 this.atom_.reportChanged()
             })
             const notifySpy = __DEV__ && isSpyEnabled()

package/src/types/observablevalue.ts

@@ -79,7 +79,7 @@ export class ObservableValue<T>
                 object: this,
                 observableKind: "value",
                 debugObjectName: this.name_,
-                newValue: "" + this.value_?.toString()
+                newValue: this.value_
             })
         }
     }