mobx 7.0.5 → 7.0.6

package/CHANGELOG.md

@@ -1,5 +1,17 @@
 # mobx
 
+## 7.0.6
+
+### Patch Changes
+
+-   [`4b1c8d3ea2b3de1a2ae852fd5631e33d28a82b15`](https://github.com/mobxjs/mobx/commit/4b1c8d3ea2b3de1a2ae852fd5631e33d28a82b15) [#4721](https://github.com/mobxjs/mobx/pull/4721) Thanks [@giaBaoJS](https://github.com/giaBaoJS)! - fix: assigning `length` on an observable array now respects `intercept`. A cancelled or modified splice used to be overridden by a direct write to the backing array, which truncated it without notifying observers and made the next mutation throw "Modification exception". A non-integer `length` now throws "Out of range" before touching the array.
+
+-   [`60be47cab0926d12f22449ec6c809fb5ec6601c4`](https://github.com/mobxjs/mobx/commit/60be47cab0926d12f22449ec6c809fb5ec6601c4) [#4716](https://github.com/mobxjs/mobx/pull/4716) Thanks [@AcEKaycgR](https://github.com/AcEKaycgR)! - fix: `observable.box(array)` no longer warns under `observableRequiresReaction` when a spy is active. The `create` spy event now reports `newValue` as the value itself rather than a string, matching the declared `IBoxDidChange` type. Previously the constructor stringified the value, and stringifying an observable array reads its `length`, which counted as an observable read outside a reactive context. Spy listeners that relied on `newValue` being a string for `create` events will now receive the raw value.
+
+-   [`3551aeb051ff922717b03c4fbc04a6b98f7f3b3e`](https://github.com/mobxjs/mobx/commit/3551aeb051ff922717b03c4fbc04a6b98f7f3b3e) [#4717](https://github.com/mobxjs/mobx/pull/4717) Thanks [@breken-ai](https://github.com/breken-ai)! - Remove the `signal` abort listener when a reaction disposes itself (`r.dispose()` or a resolved `when`), so long-lived `AbortSignal`s no longer accumulate listeners that keep disposed reactions in memory
+
+-   [`7e4e27dbfbf0b56770a11e9cba913e5d49c0c6f8`](https://github.com/mobxjs/mobx/commit/7e4e27dbfbf0b56770a11e9cba913e5d49c0c6f8) [#4718](https://github.com/mobxjs/mobx/pull/4718) Thanks [@breken-ai](https://github.com/breken-ai)! - `observe`/`spy` `add` events of an observable Set now report the value that was actually stored (e.g. the observable copy of a plain object), matching ObservableMap and observable arrays, so `set.has(change.newValue)` holds
+
 ## 7.0.5
 
 ### Patch Changes

package/dist/core/reaction.d.ts

@@ -35,6 +35,7 @@ export declare class Reaction implements IDerivation, IReactionPublic {
     runId_: number;
     unboundDepsCount_: number;
     private flags_;
+    private removeAbortListener_;
     constructor(name_: string | undefined, onInvalidate_: () => void, errorHandler_?: ((error: any, derivation: IDerivation) => void) | undefined, requiresObservable_?: any);
     get isDisposed(): boolean;
     set isDisposed(newValue: boolean);

package/dist/mobx.cjs.development.js

@@ -1195,14 +1195,13 @@ class ObservableValue extends Atom {
     this.equals_ = equals_;
     this.value_ = enhancer_(value, undefined, name_);
     if (notifySpy && isSpyEnabled()) {
-      var _this$value_;
       // only notify spy if this is a stand-alone observable
       spyReport({
         type: CREATE,
         object: this,
         observableKind: "value",
         debugObjectName: this.name_,
-        newValue: "" + ((_this$value_ = this.value_) == null ? void 0 : _this$value_.toString())
+        newValue: this.value_
       });
     }
   }
@@ -2165,6 +2164,7 @@ class Reaction {
     this.runId_ = 0;
     this.unboundDepsCount_ = 0;
     this.flags_ = 0b00000;
+    this.removeAbortListener_ = undefined;
     this.name_ = name_;
     this.onInvalidate_ = onInvalidate_;
     this.errorHandler_ = errorHandler_;
@@ -2301,7 +2301,10 @@ class Reaction {
   }
   dispose() {
     if (!this.isDisposed) {
+      var _this$removeAbortList;
       this.isDisposed = true;
+      // also covers self-disposal (`r.dispose()`, `when`), which bypasses the disposer
+      (_this$removeAbortList = this.removeAbortListener_) == null || _this$removeAbortList.call(this);
       if (!this.isRunning) {
         // if disposed while running, clean up later. Maybe not optimal, but rare case
         startBatch();
@@ -2311,11 +2314,11 @@ class Reaction {
     }
   }
   getDisposer_(abortSignal) {
-    const dispose = () => {
-      this.dispose();
-      abortSignal == null || abortSignal.removeEventListener == null || abortSignal.removeEventListener("abort", dispose);
-    };
-    abortSignal == null || abortSignal.addEventListener == null || abortSignal.addEventListener("abort", dispose);
+    const dispose = () => this.dispose();
+    if (abortSignal != null && abortSignal.addEventListener && !this.isDisposed) {
+      abortSignal.addEventListener("abort", dispose);
+      this.removeAbortListener_ = () => abortSignal.removeEventListener == null ? void 0 : abortSignal.removeEventListener("abort", dispose);
+    }
     dispose[$mobx] = this;
     if ("dispose" in Symbol && typeof Symbol.dispose === "symbol") {
       dispose[Symbol.dispose] = dispose;
@@ -3472,8 +3475,7 @@ const arrayTraps = {
     const adm = target[$mobx];
     if (name === "length") {
       adm.setArrayLength_(value);
-    }
-    if (typeof name === "symbol" || isNaN(name)) {
+    } else if (typeof name === "symbol" || isNaN(name)) {
       target[name] = value;
     } else {
       // numeric string
@@ -3518,7 +3520,7 @@ class ObservableArrayAdministration {
     return this.values_.length;
   }
   setArrayLength_(newLength) {
-    if (typeof newLength !== "number" || isNaN(newLength) || newLength < 0) {
+    if (!Number.isInteger(newLength) || newLength < 0) {
       die(40, newLength);
     }
     let currentLength = this.values_.length;
@@ -4300,7 +4302,8 @@ class ObservableSet {
     }
     if (!this.has(value)) {
       transaction(() => {
-        this.data_.add(this.enhancer_(value, undefined));
+        value = this.enhancer_(value, undefined); // report the stored value, like map and array
+        this.data_.add(value);
         this.atom_.reportChanged();
       });
       const notifySpy = isSpyEnabled();