mixdog 0.9.3 → 0.9.5

package/src/runtime/agent/orchestrator/session/store-summary-index.mjs

@@ -0,0 +1,189 @@
+/**
+ * Session summary index: the compact `session-summaries.json` sidecar that
+ * lists every session's lightweight metadata (preview, counts, lifecycle) so
+ * the status aggregator and session listers avoid parsing every full session
+ * file. Extracted from store.mjs verbatim; store.mjs re-exports these so
+ * importers stay unchanged.
+ */
+import { mkdirSync } from 'fs';
+import { join } from 'path';
+import { getPluginData } from '../config.mjs';
+import { updateJsonAtomicSync, writeJsonAtomicSync } from '../../../shared/atomic-file.mjs';
+
+export const SESSION_SUMMARY_INDEX_VERSION = 1;
+
+export function summaryIndexPath() {
+    const dir = getPluginData();
+    mkdirSync(dir, { recursive: true });
+    return join(dir, 'session-summaries.json');
+}
+
+function _messageText(content) {
+    if (typeof content === 'string') return content;
+    if (Array.isArray(content)) {
+        return content.map((part) => {
+            if (typeof part === 'string') return part;
+            if (part?.type === 'text') return part.text || '';
+            if (typeof part?.text === 'string') return part.text;
+            try { return JSON.stringify(part); } catch { return ''; }
+        }).filter(Boolean).join('\n');
+    }
+    if (content && typeof content === 'object') {
+        if (typeof content.text === 'string') return content.text;
+        try { return JSON.stringify(content); } catch { return ''; }
+    }
+    return '';
+}
+
+export function _cleanPreview(text, max = 240) {
+    const value = String(text || '').replace(/\s+/g, ' ').trim();
+    return value.length > max ? value.slice(0, max).replace(/\s+\S*$/, '').trim() : value;
+}
+
+function _isPreviewNoise(text) {
+    const value = String(text || '').trim();
+    if (!value) return true;
+    if (value.startsWith('<system-reminder>')) return true;
+    if (/^Reference files:/i.test(value)) return true;
+    return false;
+}
+
+function _sessionPreview(session) {
+    const messages = Array.isArray(session?.messages) ? session.messages : [];
+    let first = '';
+    for (const m of messages) {
+        if (m?.role !== 'user') continue;
+        const text = _cleanPreview(_messageText(m.content));
+        if (_isPreviewNoise(text)) continue;
+        if (!first) first = text;
+    }
+    for (let i = messages.length - 1; i >= 0; i -= 1) {
+        const m = messages[i];
+        if (m?.role !== 'user') continue;
+        const text = _cleanPreview(_messageText(m.content));
+        if (_isPreviewNoise(text)) continue;
+        return text || first;
+    }
+    return first;
+}
+
+function _sessionMessageCount(session) {
+    const messages = Array.isArray(session?.messages) ? session.messages : [];
+    let count = 0;
+    for (const m of messages) {
+        if (m && (m.role === 'user' || m.role === 'assistant')) count++;
+    }
+    return count;
+}
+
+function _positiveNumber(value, fallback = 0) {
+    const n = Number(value);
+    return Number.isFinite(n) && n > 0 ? n : fallback;
+}
+
+export function _sessionSummary(session) {
+    if (!session?.id) return null;
+    return {
+        id: String(session.id),
+        updatedAt: _positiveNumber(session.updatedAt, Date.now()),
+        createdAt: _positiveNumber(session.createdAt, 0),
+        lastHeartbeatAt: _positiveNumber(session.lastHeartbeatAt, 0),
+        closed: session.closed === true,
+        status: String(session.status || (session.closed === true ? 'closed' : 'idle')),
+        owner: session.owner || 'user',
+        agent: session.agent || null,
+        sourceType: session.sourceType || null,
+        sourceName: session.sourceName || null,
+        scopeKey: session.scopeKey || null,
+        ownerSessionId: session.ownerSessionId || null,
+        clientHostPid: _positiveNumber(session.clientHostPid, 0) || null,
+        cwd: session.cwd || '',
+        provider: session.provider || null,
+        model: session.model || null,
+        agentTag: session.agentTag || null,
+        task_id: session.task_id || session.taskId || null,
+        permission: session.permission || null,
+        toolPermission: session.toolPermission || null,
+        messageCount: _sessionMessageCount(session),
+        preview: _sessionPreview(session),
+        generation: typeof session.generation === 'number' ? session.generation : 0,
+        implicitBashSessionId: session.implicitBashSessionId || null,
+    };
+}
+
+function _normalizeSummaryRow(row) {
+    if (!row?.id || typeof row.id !== 'string' || !/^[A-Za-z0-9_-]+$/.test(row.id)) return null;
+    return {
+        id: row.id,
+        updatedAt: _positiveNumber(row.updatedAt, 0),
+        createdAt: _positiveNumber(row.createdAt, 0),
+        lastHeartbeatAt: _positiveNumber(row.lastHeartbeatAt, 0),
+        closed: row.closed === true,
+        status: String(row.status || (row.closed === true ? 'closed' : 'idle')),
+        owner: row.owner || 'user',
+        agent: row.agent || null,
+        sourceType: row.sourceType || null,
+        sourceName: row.sourceName || null,
+        scopeKey: row.scopeKey || null,
+        ownerSessionId: row.ownerSessionId || null,
+        clientHostPid: _positiveNumber(row.clientHostPid, 0) || null,
+        cwd: row.cwd || '',
+        provider: row.provider || null,
+        model: row.model || null,
+        agentTag: row.agentTag || null,
+        task_id: row.task_id || null,
+        permission: row.permission || null,
+        toolPermission: row.toolPermission || null,
+        messageCount: Math.max(0, Math.floor(Number(row.messageCount) || 0)),
+        preview: _cleanPreview(row.preview || ''),
+        generation: typeof row.generation === 'number' ? row.generation : 0,
+        implicitBashSessionId: row.implicitBashSessionId || null,
+    };
+}
+
+export function _normalizeSummaryIndex(raw) {
+    const rows = Array.isArray(raw?.rows) ? raw.rows.map(_normalizeSummaryRow).filter(Boolean) : [];
+    rows.sort((a, b) => (b.updatedAt || 0) - (a.updatedAt || 0));
+    return { version: SESSION_SUMMARY_INDEX_VERSION, updatedAt: _positiveNumber(raw?.updatedAt, 0), rows };
+}
+
+export function _writeSummaryIndex(rows) {
+    const cleanRows = (rows || []).map(_normalizeSummaryRow).filter(Boolean)
+        .sort((a, b) => (b.updatedAt || 0) - (a.updatedAt || 0));
+    writeJsonAtomicSync(summaryIndexPath(), {
+        version: SESSION_SUMMARY_INDEX_VERSION,
+        updatedAt: Date.now(),
+        rows: cleanRows,
+    }, { compact: true, lock: true });
+    return cleanRows;
+}
+
+export function _upsertSessionSummary(session) {
+    const row = _sessionSummary(session);
+    if (!row) return;
+    try {
+        updateJsonAtomicSync(summaryIndexPath(), (cur) => {
+            const index = _normalizeSummaryIndex(cur);
+            const rows = index.rows.filter((r) => r.id !== row.id);
+            const cleanRow = _normalizeSummaryRow(row);
+            if (!cleanRow) return undefined;
+            const existing = index.rows.find((r) => r.id === row.id) || null;
+            if (existing && JSON.stringify(existing) === JSON.stringify(cleanRow)) return undefined;
+            rows.push(cleanRow);
+            rows.sort((a, b) => (b.updatedAt || 0) - (a.updatedAt || 0));
+            return { version: SESSION_SUMMARY_INDEX_VERSION, updatedAt: Date.now(), rows };
+        }, { compact: true, lock: true });
+    } catch { /* summary index is best-effort */ }
+}
+
+export function _removeSessionSummary(id) {
+    if (!id) return;
+    try {
+        updateJsonAtomicSync(summaryIndexPath(), (cur) => {
+            const index = _normalizeSummaryIndex(cur);
+            const rows = index.rows.filter((r) => r.id !== id);
+            if (rows.length === index.rows.length) return undefined;
+            return { version: SESSION_SUMMARY_INDEX_VERSION, updatedAt: Date.now(), rows };
+        }, { compact: true, lock: true });
+    } catch { /* summary index is best-effort */ }
+}

package/src/runtime/agent/orchestrator/session/store.mjs

@@ -10,11 +10,29 @@ import { join } from 'path';
 import { Worker } from 'worker_threads';
 import { getPluginData } from '../config.mjs';
 import { isAgentOwner } from '../agent-owner.mjs';
-import { renameWithRetrySync, updateJsonAtomicSync, writeJsonAtomicSync } from '../../../shared/atomic-file.mjs';
+import { renameWithRetrySync } from '../../../shared/atomic-file.mjs';
 import { sanitizeContentForStoredHistory } from '../providers/media-normalization.mjs';
+import {
+    summaryIndexPath,
+    _sessionSummary,
+    _normalizeSummaryIndex,
+    _writeSummaryIndex,
+    _upsertSessionSummary,
+    _removeSessionSummary,
+} from './store-summary-index.mjs';
+// Facade re-export: summary-index API moved to store-summary-index.mjs; keep
+// prior importers of store.mjs unchanged.
+export {
+    SESSION_SUMMARY_INDEX_VERSION,
+    summaryIndexPath,
+    _sessionSummary,
+    _normalizeSummaryIndex,
+    _writeSummaryIndex,
+    _upsertSessionSummary,
+    _removeSessionSummary,
+} from './store-summary-index.mjs';
 
 const _lastSaveError = new Map(); // id -> { message, at }
-const SESSION_SUMMARY_INDEX_VERSION = 1;
 
 // The live in-memory session (and every model request)
 // retains attached image bytes across turns so multi-turn recognition works.
@@ -71,11 +89,6 @@ function sessionPath(id) {
     }
     return join(getStoreDir(), `${id}.json`);
 }
-function summaryIndexPath() {
-    const dir = getPluginData();
-    mkdirSync(dir, { recursive: true });
-    return join(dir, 'session-summaries.json');
-}
 /**
  * Ensure generation/closed defaults on every session object.
  * Older persisted sessions predate these fields; we normalise at load and save.
@@ -88,176 +101,6 @@ function _ensureLifecycleFields(session) {
     return session;
 }
 
-function _messageText(content) {
-    if (typeof content === 'string') return content;
-    if (Array.isArray(content)) {
-        return content.map((part) => {
-            if (typeof part === 'string') return part;
-            if (part?.type === 'text') return part.text || '';
-            if (typeof part?.text === 'string') return part.text;
-            try { return JSON.stringify(part); } catch { return ''; }
-        }).filter(Boolean).join('\n');
-    }
-    if (content && typeof content === 'object') {
-        if (typeof content.text === 'string') return content.text;
-        try { return JSON.stringify(content); } catch { return ''; }
-    }
-    return '';
-}
-
-function _cleanPreview(text, max = 240) {
-    const value = String(text || '').replace(/\s+/g, ' ').trim();
-    return value.length > max ? value.slice(0, max).replace(/\s+\S*$/, '').trim() : value;
-}
-
-function _isPreviewNoise(text) {
-    const value = String(text || '').trim();
-    if (!value) return true;
-    if (value.startsWith('<system-reminder>')) return true;
-    if (/^Reference files:/i.test(value)) return true;
-    return false;
-}
-
-function _sessionPreview(session) {
-    const messages = Array.isArray(session?.messages) ? session.messages : [];
-    let first = '';
-    for (const m of messages) {
-        if (m?.role !== 'user') continue;
-        const text = _cleanPreview(_messageText(m.content));
-        if (_isPreviewNoise(text)) continue;
-        if (!first) first = text;
-    }
-    for (let i = messages.length - 1; i >= 0; i -= 1) {
-        const m = messages[i];
-        if (m?.role !== 'user') continue;
-        const text = _cleanPreview(_messageText(m.content));
-        if (_isPreviewNoise(text)) continue;
-        return text || first;
-    }
-    return first;
-}
-
-function _sessionMessageCount(session) {
-    const messages = Array.isArray(session?.messages) ? session.messages : [];
-    let count = 0;
-    for (const m of messages) {
-        if (m && (m.role === 'user' || m.role === 'assistant')) count++;
-    }
-    return count;
-}
-
-function _positiveNumber(value, fallback = 0) {
-    const n = Number(value);
-    return Number.isFinite(n) && n > 0 ? n : fallback;
-}
-
-function _sessionSummary(session) {
-    if (!session?.id) return null;
-    return {
-        id: String(session.id),
-        updatedAt: _positiveNumber(session.updatedAt, Date.now()),
-        createdAt: _positiveNumber(session.createdAt, 0),
-        lastHeartbeatAt: _positiveNumber(session.lastHeartbeatAt, 0),
-        closed: session.closed === true,
-        status: String(session.status || (session.closed === true ? 'closed' : 'idle')),
-        owner: session.owner || 'user',
-        agent: session.agent || null,
-        sourceType: session.sourceType || null,
-        sourceName: session.sourceName || null,
-        scopeKey: session.scopeKey || null,
-        ownerSessionId: session.ownerSessionId || null,
-        clientHostPid: _positiveNumber(session.clientHostPid, 0) || null,
-        cwd: session.cwd || '',
-        provider: session.provider || null,
-        model: session.model || null,
-        agentTag: session.agentTag || null,
-        task_id: session.task_id || session.taskId || null,
-        permission: session.permission || null,
-        toolPermission: session.toolPermission || null,
-        messageCount: _sessionMessageCount(session),
-        preview: _sessionPreview(session),
-        generation: typeof session.generation === 'number' ? session.generation : 0,
-        implicitBashSessionId: session.implicitBashSessionId || null,
-    };
-}
-
-function _normalizeSummaryRow(row) {
-    if (!row?.id || typeof row.id !== 'string' || !/^[A-Za-z0-9_-]+$/.test(row.id)) return null;
-    return {
-        id: row.id,
-        updatedAt: _positiveNumber(row.updatedAt, 0),
-        createdAt: _positiveNumber(row.createdAt, 0),
-        lastHeartbeatAt: _positiveNumber(row.lastHeartbeatAt, 0),
-        closed: row.closed === true,
-        status: String(row.status || (row.closed === true ? 'closed' : 'idle')),
-        owner: row.owner || 'user',
-        agent: row.agent || null,
-        sourceType: row.sourceType || null,
-        sourceName: row.sourceName || null,
-        scopeKey: row.scopeKey || null,
-        ownerSessionId: row.ownerSessionId || null,
-        clientHostPid: _positiveNumber(row.clientHostPid, 0) || null,
-        cwd: row.cwd || '',
-        provider: row.provider || null,
-        model: row.model || null,
-        agentTag: row.agentTag || null,
-        task_id: row.task_id || null,
-        permission: row.permission || null,
-        toolPermission: row.toolPermission || null,
-        messageCount: Math.max(0, Math.floor(Number(row.messageCount) || 0)),
-        preview: _cleanPreview(row.preview || ''),
-        generation: typeof row.generation === 'number' ? row.generation : 0,
-        implicitBashSessionId: row.implicitBashSessionId || null,
-    };
-}
-
-function _normalizeSummaryIndex(raw) {
-    const rows = Array.isArray(raw?.rows) ? raw.rows.map(_normalizeSummaryRow).filter(Boolean) : [];
-    rows.sort((a, b) => (b.updatedAt || 0) - (a.updatedAt || 0));
-    return { version: SESSION_SUMMARY_INDEX_VERSION, updatedAt: _positiveNumber(raw?.updatedAt, 0), rows };
-}
-
-function _writeSummaryIndex(rows) {
-    const cleanRows = (rows || []).map(_normalizeSummaryRow).filter(Boolean)
-        .sort((a, b) => (b.updatedAt || 0) - (a.updatedAt || 0));
-    writeJsonAtomicSync(summaryIndexPath(), {
-        version: SESSION_SUMMARY_INDEX_VERSION,
-        updatedAt: Date.now(),
-        rows: cleanRows,
-    }, { compact: true, lock: true });
-    return cleanRows;
-}
-
-function _upsertSessionSummary(session) {
-    const row = _sessionSummary(session);
-    if (!row) return;
-    try {
-        updateJsonAtomicSync(summaryIndexPath(), (cur) => {
-            const index = _normalizeSummaryIndex(cur);
-            const rows = index.rows.filter((r) => r.id !== row.id);
-            const cleanRow = _normalizeSummaryRow(row);
-            if (!cleanRow) return undefined;
-            const existing = index.rows.find((r) => r.id === row.id) || null;
-            if (existing && JSON.stringify(existing) === JSON.stringify(cleanRow)) return undefined;
-            rows.push(cleanRow);
-            rows.sort((a, b) => (b.updatedAt || 0) - (a.updatedAt || 0));
-            return { version: SESSION_SUMMARY_INDEX_VERSION, updatedAt: Date.now(), rows };
-        }, { compact: true, lock: true });
-    } catch { /* summary index is best-effort */ }
-}
-
-function _removeSessionSummary(id) {
-    if (!id) return;
-    try {
-        updateJsonAtomicSync(summaryIndexPath(), (cur) => {
-            const index = _normalizeSummaryIndex(cur);
-            const rows = index.rows.filter((r) => r.id !== id);
-            if (rows.length === index.rows.length) return undefined;
-            return { version: SESSION_SUMMARY_INDEX_VERSION, updatedAt: Date.now(), rows };
-        }, { compact: true, lock: true });
-    } catch { /* summary index is best-effort */ }
-}
-
 /** Module-level map tracking in-flight saves per session ID to prevent concurrent write corruption. */
 const _savePending = new Map();
 
@@ -520,17 +363,34 @@ function _shouldDrop(id, opts) {
         // ran on every save). Fast-path a regex scan; only fall back to a full
         // parse if the lightweight scan is inconclusive.
         const closedMatch = /"closed"\s*:\s*(true|false)/.exec(raw);
-        if (closedMatch && closedMatch[1] === 'false') return false;
         if (closedMatch && closedMatch[1] === 'true') {
             const genMatch = /"generation"\s*:\s*(-?\d+)/.exec(raw);
             const diskGen = genMatch ? Number(genMatch[1]) : 0;
             return diskGen >= expected;
         }
+        if (closedMatch && closedMatch[1] === 'false') {
+            // Not closed — still check the generation-as-ownership-counter
+            // rule (see full-parse branch below) via the same fast regex
+            // scan, so bumpSessionGeneration()'s detach bump is honoured
+            // without paying for a full JSON.parse on every save.
+            const genMatch = /"generation"\s*:\s*(-?\d+)/.exec(raw);
+            const diskGen = genMatch ? Number(genMatch[1]) : 0;
+            return diskGen > expected;
+        }
         // No `closed` key found by scan — not a tombstone, so nothing to drop.
         if (!closedMatch && !/"closed"/.test(raw)) return false;
         const onDisk = JSON.parse(raw);
         const diskGen = typeof onDisk.generation === 'number' ? onDisk.generation : 0;
-        return onDisk.closed === true && diskGen >= expected;
+        if (onDisk.closed === true) return diskGen >= expected;
+        // Not closed, but `generation` also doubles as an ownership counter:
+        // normal in-place saves (updateSession/appendMessage/etc.) never bump
+        // it, only closeSession()-family calls do (markSessionClosed and its
+        // non-tombstoning sibling bumpSessionGeneration). So if disk
+        // generation is strictly greater than what this write expected,
+        // ownership moved on (session was detached-closed and possibly
+        // resumed) after our turn started — drop the stale write rather than
+        // let it clobber whatever happened after the handoff.
+        return diskGen > expected;
     } catch {
         return false;
     }
@@ -666,6 +526,41 @@ export function markSessionClosed(id, reason = 'manual') {
     return newGen;
 }
 
+/**
+ * Bump a session's generation WITHOUT planting a closed:true tombstone.
+ * Used by closeSession(id, reason, { tombstone: false }) — the runtime side
+ * (heartbeat, bash shells, controller, in-memory entry) is detached, but the
+ * session file itself stays valid/resumable. The generation bump alone is
+ * what protects it from a late save race: any saveSession() still in flight
+ * from the detached turn was issued with the OLD generation as its
+ * `expectedGeneration`, so once we bump the on-disk generation here, that
+ * late write's own _shouldDrop() check (generation-as-ownership-counter
+ * rule, see below) sees disk generation > expected and drops itself instead
+ * of clobbering whatever the resumed session writes next.
+ * Returns the new generation, or null if the session file doesn't exist.
+ */
+export function bumpSessionGeneration(id, reason = 'detach') {
+    _clearDebounce(id);
+    const existing = loadSession(id);
+    if (!existing) return null;
+    const newGen = (typeof existing.generation === 'number' ? existing.generation : 0) + 1;
+    const detached = { ...existing, generation: newGen, updatedAt: Date.now(), detachedReason: reason };
+    const target = sessionPath(id);
+    const tmp = target + '.' + randomBytes(6).toString('hex') + '.tmp';
+    try {
+        writeFileSync(tmp, JSON.stringify(_sessionForDisk(detached)), 'utf-8');
+        _renameWithRetrySync(tmp, target);
+    } catch {
+        try { unlinkSync(tmp); } catch { /* ignore */ }
+        return null;
+    }
+    _savePending.delete(id);
+    _clearLiveSession(id);
+    _deleteHeartbeat(id);
+    _upsertSessionSummary(detached);
+    return newGen;
+}
+
 export function loadSession(id) {
     const path = sessionPath(id);
     // Read-your-writes: if a save is pending (debouncing, scheduled, or queued

package/src/runtime/agent/orchestrator/stall-policy.mjs

@@ -206,9 +206,28 @@ export const PROVIDER_RETRY_JITTER_RATIO = (() => {
     return 0.2;
 })();
 
+// Public workflow agents are not in agents.json (that file only defines hidden
+// roles), so they historically always fell back to the 600s default. A wedged
+// anthropic SSE stream (HTTP 200 then zero deltas — observed 2026-07-03 on a
+// sonnet-5 worker, twice in a row) then holds the owner for the full 10 min.
+// Scoped workers/reviewers should be reaped faster; lead keeps the generous
+// default because interactive xhigh turns legitimately think for minutes.
+const WORKFLOW_AGENT_STALL_ABORT_S = {
+    'worker': 300,
+    'reviewer': 300,
+    'debugger': 420,
+    'heavy-worker': 420,
+    'maintainer': 300,
+    'explore': 240,
+    'web-researcher': 300,
+};
+
 export function resolveAgentStallThresholds(agent, env = process.env) {
     const cfg = agent ? getHiddenAgent(agent) : null;
-    const cfgAbort = cfg?.stallCap?.idleSeconds > 0 ? cfg.stallCap.idleSeconds : STALL_ABORT_S;
+    const roleAbort = WORKFLOW_AGENT_STALL_ABORT_S[String(agent || '')] || null;
+    const cfgAbort = cfg?.stallCap?.idleSeconds > 0
+        ? cfg.stallCap.idleSeconds
+        : (roleAbort || STALL_ABORT_S);
     const envOverride = envThresholdSeconds(env);
     const abort = envOverride != null ? envOverride : cfgAbort;
     // Mid-stream "slow" warning disabled — an agent stall now notifies ONLY at