mediasoup 3.27.0 → 3.28.0

package/worker/src/RTC/SCTP/public/AssociationMetrics.cpp

@@ -14,7 +14,7 @@ namespace RTC
 		{
 			MS_TRACE();
 
-			auto peerImplementationStringView = Types::SctpImplementationToString(this->peerImplementation);
+			auto peerImplementationStringView = Types::sctpImplementationToString(this->peerImplementation);
 
 			MS_DUMP_CLEAN(indentation, "<SCTP::AssociationMetrics>");
 			MS_DUMP_CLEAN(indentation, "  tx packets count: %" PRIu64, this->txPacketsCount);

package/worker/src/RTC/SCTP/rx/InterleavedReassemblyStreams.cpp

@@ -118,7 +118,7 @@ namespace RTC
 				this->nextMid.Increment();
 
 				// This might unblock assembling more messages.
-				return -TryToAssembleMessages();
+				return -static_cast<int32_t>(TryToAssembleMessages());
 			}
 
 			// Slow path.
@@ -159,7 +159,7 @@ namespace RTC
 				removedBytes += std::accumulate(
 				  it->second.begin(),
 				  it->second.end(),
-				  0,
+				  size_t{ 0 },
 				  [](size_t acc, const auto& i)
 				  {
 					  const auto& data = i.second.second;
@@ -295,7 +295,7 @@ namespace RTC
 			const size_t payloadLength = std::accumulate(
 			  tsnChunks.begin(),
 			  tsnChunks.end(),
-			  0,
+			  size_t{ 0 },
 			  [](size_t acc, const auto& i)
 			  {
 				  const auto& data = i.second.second;

package/worker/src/RTC/SCTP/rx/ReassemblyQueue.cpp

@@ -13,7 +13,8 @@ namespace RTC
 	{
 		ReassemblyQueue::ReassemblyQueue(size_t maxLengthBytes, bool useMessageInterleaving)
 		  : maxLengthBytes(maxLengthBytes),
-		    watermarkBytes(this->maxLengthBytes * ReassemblyQueue::HighWatermarkLimit),
+		    watermarkBytes(
+		      static_cast<size_t>(this->maxLengthBytes * ReassemblyQueue::HighWatermarkLimit)),
 		    reassemblyStreams(CreateReassemblyStreams(
 		      [this](std::span<const Types::UnwrappedTsn> tsns, Message message)
 		      {

package/worker/src/RTC/SCTP/rx/TraditionalReassemblyStreams.cpp

@@ -114,7 +114,7 @@ namespace RTC
 			const size_t payloadLength = std::accumulate(
 			  start,
 			  end,
-			  0,
+			  size_t{ 0 },
 			  [](size_t acc, const auto& i)
 			  {
 				  const auto& data = i.second;
@@ -200,13 +200,13 @@ namespace RTC
 			size_t removedBytes = std::accumulate(
 			  this->chunksBySsn.begin(),
 			  endIt,
-			  0,
+			  size_t{ 0 },
 			  [](size_t acc1, const auto& i1)
 			  {
 				  return acc1 + std::accumulate(
 				                  i1.second.begin(),
 				                  i1.second.end(),
-				                  0,
+				                  size_t{ 0 },
 				                  [](size_t acc2, const auto& i2)
 				                  {
 					                  const auto& data = i2.second;
@@ -349,7 +349,7 @@ namespace RTC
 			const size_t removedBytes = std::accumulate(
 			  this->chunks.begin(),
 			  endIt,
-			  0,
+			  size_t{ 0 },
 			  [](size_t acc, const auto& i)
 			  {
 				  const auto& data = i.second;

package/worker/src/RTC/SCTP/tx/RetransmissionTimeout.cpp

@@ -3,7 +3,7 @@
 
 #include "RTC/SCTP/tx/RetransmissionTimeout.hpp"
 #include "Logger.hpp"
-#include <cmath> // std::abs(), std::max(), std::round()
+#include <cmath> // std::abs(), std::round()
 
 namespace RTC
 {
@@ -33,8 +33,8 @@ namespace RTC
 		    maxRttUs(sctpOptions.maxRttMs * 1000),
 		    minRttVarianceUs(
 		      static_cast<int64_t>((sctpOptions.minRttVarianceMs * 1000) / HeuristicVarianceAdjustment)),
-		    srttUs(sctpOptions.initialRtoMs * 1000),
-		    rtoUs(sctpOptions.initialRtoMs * 1000),
+		    srttUs(static_cast<double>(sctpOptions.initialRtoMs * 1000)),
+		    rtoUs(static_cast<double>(sctpOptions.initialRtoMs * 1000)),
 		    firstMeasurement(true)
 		{
 			MS_TRACE();
@@ -76,7 +76,7 @@ namespace RTC
 			// https://datatracker.ietf.org/doc/html/rfc9260#section-6.3.1
 			if (this->firstMeasurement)
 			{
-				this->srttUs           = rttUs;
+				this->srttUs           = static_cast<double>(rttUs);
 				this->rttVarUs         = rttUs / 2.0;
 				this->firstMeasurement = false;
 			}

package/worker/src/RTC/SctpDictionaries/SctpStreamParameters.cpp

@@ -41,16 +41,18 @@ namespace RTC
 			this->maxRetransmits = maxRetransmits.value();
 		}
 
-		if (this->maxPacketLifeTime && this->maxRetransmits)
+		if (this->maxPacketLifeTime.has_value() && this->maxRetransmits.has_value())
 		{
 			MS_THROW_TYPE_ERROR("cannot provide both maxPacketLifeTime and maxRetransmits");
 		}
 
-		if (orderedGiven && this->ordered && (this->maxPacketLifeTime || this->maxRetransmits))
+		if (
+		  orderedGiven && this->ordered &&
+		  (this->maxPacketLifeTime.has_value() || this->maxRetransmits.has_value()))
 		{
 			MS_THROW_TYPE_ERROR("cannot be ordered with maxPacketLifeTime or maxRetransmits");
 		}
-		else if (!orderedGiven && (this->maxPacketLifeTime || this->maxRetransmits))
+		else if (!orderedGiven && (this->maxPacketLifeTime.has_value() || this->maxRetransmits.has_value()))
 		{
 			this->ordered = false;
 		}
@@ -62,12 +64,6 @@ namespace RTC
 		MS_TRACE();
 
 		return FBS::SctpParameters::CreateSctpStreamParameters(
-		  builder,
-		  this->streamId,
-		  this->ordered,
-		  this->maxPacketLifeTime ? flatbuffers::Optional<uint16_t>(this->maxPacketLifeTime)
-			                        : flatbuffers::nullopt,
-		  this->maxRetransmits ? flatbuffers::Optional<uint16_t>(this->maxRetransmits)
-			                     : flatbuffers::nullopt);
+		  builder, this->streamId, this->ordered, this->maxPacketLifeTime, this->maxRetransmits);
 	}
 } // namespace RTC

package/worker/src/RTC/SimulcastProducerStreamManager.cpp

@@ -219,11 +219,11 @@ namespace RTC
 			// packet lost.
 			if (lossPercentage < 2)
 			{
-				virtualBitrate = 1.08 * bitrate;
+				virtualBitrate = static_cast<int64_t>(1.08 * bitrate);
 			}
 			else if (lossPercentage > 10)
 			{
-				virtualBitrate = (1 - 0.5 * (lossPercentage / 100)) * bitrate;
+				virtualBitrate = static_cast<int64_t>((1 - 0.5 * (lossPercentage / 100)) * bitrate);
 			}
 			else
 			{

package/worker/src/RTC/SrtpSession.cpp

@@ -56,7 +56,7 @@ namespace RTC
 				return FBS::SrtpParameters::SrtpCryptoSuite::AES_CM_128_HMAC_SHA1_32;
 			}
 
-				NO_DEFAULT_GCC();
+				NO_DEFAULT();
 		}
 	}
 
@@ -86,7 +86,7 @@ namespace RTC
 				return SrtpSession::CryptoSuite::AES_CM_128_HMAC_SHA1_32;
 			}
 
-				NO_DEFAULT_GCC();
+				NO_DEFAULT();
 		}
 	}
 

package/worker/src/RTC/SvcProducerStreamManager.cpp

@@ -160,11 +160,11 @@ namespace RTC
 			// packet lost.
 			if (lossPercentage < 2)
 			{
-				virtualBitrate = 1.08 * bitrate;
+				virtualBitrate = static_cast<int64_t>(1.08 * bitrate);
 			}
 			else if (lossPercentage > 10)
 			{
-				virtualBitrate = (1 - 0.5 * (lossPercentage / 100)) * bitrate;
+				virtualBitrate = static_cast<int64_t>((1 - 0.5 * (lossPercentage / 100)) * bitrate);
 			}
 			else
 			{

package/worker/src/RTC/TcpConnection.cpp

@@ -168,7 +168,7 @@ namespace RTC
 		}
 	}
 
-	void TcpConnection::Send(const uint8_t* data, size_t len, ::TcpConnectionHandle::onSendCallback* cb)
+	void TcpConnection::Send(const uint8_t* data, size_t len, onSendCallback cb)
 	{
 		MS_TRACE();
 
@@ -177,6 +177,6 @@ namespace RTC
 		uint8_t frameLen[2];
 
 		Utils::Byte::Set2Bytes(frameLen, 0, len);
-		::TcpConnectionHandle::Write(frameLen, 2, data, len, cb);
+		::TcpConnectionHandle::Write(frameLen, 2, data, len, std::move(cb));
 	}
 } // namespace RTC