mandrel 2.0.0 → 2.2.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/.agents/README.md +59 -28
- package/.agents/agents/acceptance-critic.md +20 -9
- package/.agents/agents/story-worker.md +45 -48
- package/.agents/audit-checklists/performance.md +1 -1
- package/.agents/docs/SDLC.md +60 -46
- package/.agents/docs/agentrc-reference.json +8 -13
- package/.agents/docs/configuration.md +33 -57
- package/.agents/docs/execution-reference.md +39 -10
- package/.agents/docs/quality-gates.md +17 -19
- package/.agents/docs/workflows.md +6 -6
- package/.agents/instructions.md +64 -79
- package/.agents/rules/ci-remediation.md +3 -3
- package/.agents/rules/gherkin-standards.md +10 -0
- package/.agents/rules/git-conventions-reference.md +42 -51
- package/.agents/schemas/acceptance-eval-verdict.schema.json +2 -2
- package/.agents/schemas/agentrc.schema.json +35 -46
- package/.agents/schemas/audit-rules.json +59 -1
- package/.agents/schemas/audit-rules.schema.json +33 -1
- package/.agents/schemas/lifecycle/README.md +1 -2
- package/.agents/schemas/lifecycle/ledger-record.schema.json +1 -1
- package/.agents/schemas/lifecycle/merge.flip-failed.schema.json +33 -0
- package/.agents/schemas/lifecycle/merge.unlanded.schema.json +1 -0
- package/.agents/schemas/lifecycle/story.merged.schema.json +1 -1
- package/.agents/schemas/signal-event.schema.json +3 -3
- package/.agents/schemas/story-deliver-terminal.schema.json +152 -0
- package/.agents/schemas/validation-evidence.schema.json +1 -1
- package/.agents/scripts/acceptance-eval.js +24 -68
- package/.agents/scripts/agents-bootstrap-github.js +1 -1
- package/.agents/scripts/bootstrap.js +3 -3
- package/.agents/scripts/check-dead-exports.js +43 -104
- package/.agents/scripts/check-doc-links.js +2 -2
- package/.agents/scripts/check-lifecycle-lint.js +1 -1
- package/.agents/scripts/check-workflow-cli-lint.js +91 -0
- package/.agents/scripts/deliver-recover.js +122 -0
- package/.agents/scripts/drain-pending-cleanup.js +1 -1
- package/.agents/scripts/evidence-gate.js +20 -50
- package/.agents/scripts/generate-skills-index.js +17 -1
- package/.agents/scripts/generate-workflows-doc.js +4 -4
- package/.agents/scripts/lib/ITicketingProvider.js +1 -19
- package/.agents/scripts/lib/audit-suite/selector.js +323 -23
- package/.agents/scripts/lib/baselines/kinds/maintainability.js +0 -11
- package/.agents/scripts/lib/bootstrap/ci-workflow-template.js +28 -33
- package/.agents/scripts/lib/bootstrap/manifest.js +8 -11
- package/.agents/scripts/lib/bootstrap/project-bootstrap.js +30 -53
- package/.agents/scripts/lib/bootstrap/quality-bootstrap.js +0 -2
- package/.agents/scripts/lib/checks/core-bare-clean.js +4 -1
- package/.agents/scripts/lib/checks/index.js +1 -1
- package/.agents/scripts/lib/checks/loop-health.js +12 -11
- package/.agents/scripts/lib/checks/state.js +17 -248
- package/.agents/scripts/lib/checks/story-init-not-backgrounded.js +3 -3
- package/.agents/scripts/lib/checks/subagent-agent-tool-required.js +3 -4
- package/.agents/scripts/lib/checks/worktree-bootstrap-env.js +2 -2
- package/.agents/scripts/lib/checks/worktree-residue-biome.js +3 -3
- package/.agents/scripts/lib/cli-args.js +23 -2
- package/.agents/scripts/lib/close-validation/gates.js +13 -13
- package/.agents/scripts/lib/close-validation/projections/inputs.js +7 -7
- package/.agents/scripts/lib/close-validation/projections/maintainability.js +12 -12
- package/.agents/scripts/lib/close-validation/runner.js +13 -21
- package/.agents/scripts/lib/close-validation/telemetry.js +17 -8
- package/.agents/scripts/lib/config/acceptance-eval.js +2 -2
- package/.agents/scripts/lib/config/delivery-routing.js +7 -6
- package/.agents/scripts/lib/config/explain.js +10 -16
- package/.agents/scripts/lib/config/github.js +7 -5
- package/.agents/scripts/lib/config/limits.js +15 -25
- package/.agents/scripts/lib/config/quality.js +11 -14
- package/.agents/scripts/lib/config/runners.js +8 -21
- package/.agents/scripts/lib/config/temp-paths.js +18 -56
- package/.agents/scripts/lib/config-settings-schema-delivery.js +34 -16
- package/.agents/scripts/lib/config-settings-schema-quality.js +9 -2
- package/.agents/scripts/lib/config-settings-schema.js +48 -22
- package/.agents/scripts/lib/dead-exports-knip.js +105 -0
- package/.agents/scripts/lib/dead-exports-mode.js +51 -0
- package/.agents/scripts/lib/duplicate-search.js +38 -7
- package/.agents/scripts/lib/findings/promote-finding.js +23 -14
- package/.agents/scripts/lib/format-generated-json.js +97 -0
- package/.agents/scripts/lib/framework-version.js +19 -189
- package/.agents/scripts/lib/gh-exec.js +8 -0
- package/.agents/scripts/lib/git-branch-lifecycle.js +0 -158
- package/.agents/scripts/lib/git-utils.js +0 -14
- package/.agents/scripts/lib/json-utils.js +1 -2
- package/.agents/scripts/lib/label-constants.js +0 -15
- package/.agents/scripts/lib/label-taxonomy.js +1 -12
- package/.agents/scripts/lib/observability/active-story-env.js +42 -163
- package/.agents/scripts/lib/observability/runtime-friction.js +243 -0
- package/.agents/scripts/lib/observability/signal-validator.js +4 -4
- package/.agents/scripts/lib/observability/signals-writer.js +6 -82
- package/.agents/scripts/lib/observability/source-classifier.js +2 -2
- package/.agents/scripts/lib/observability/tool-trace-hook.js +2 -12
- package/.agents/scripts/lib/orchestration/acceptance-clusters.js +1 -1
- package/.agents/scripts/lib/orchestration/acceptance-eval-decision.js +2 -2
- package/.agents/scripts/lib/orchestration/ceremony-routing.js +43 -45
- package/.agents/scripts/lib/orchestration/change-set.js +103 -0
- package/.agents/scripts/lib/orchestration/code-review.js +70 -191
- package/.agents/scripts/lib/orchestration/consolidation-precondition.js +3 -3
- package/.agents/scripts/lib/orchestration/deliver-recover.js +328 -0
- package/.agents/scripts/lib/orchestration/detectors-phase.js +12 -6
- package/.agents/scripts/lib/orchestration/git-cleanup/phases/fast-forward.js +34 -0
- package/.agents/scripts/lib/orchestration/lease-guard-shared.js +3 -2
- package/.agents/scripts/lib/orchestration/lifecycle/emit-ledger-event.js +142 -0
- package/.agents/scripts/lib/orchestration/lifecycle/emit-loop-tick.js +9 -11
- package/.agents/scripts/lib/orchestration/lifecycle/emit-merge-flip-failed.js +86 -0
- package/.agents/scripts/lib/orchestration/lifecycle/emit-merge-unlanded.js +37 -103
- package/.agents/scripts/lib/orchestration/lifecycle/listeners/README.md +7 -3
- package/.agents/scripts/lib/orchestration/lifecycle/listeners/watcher.js +50 -85
- package/.agents/scripts/lib/orchestration/lifecycle/trace-logger.js +3 -14
- package/.agents/scripts/lib/orchestration/merge-block-class.js +76 -20
- package/.agents/scripts/lib/orchestration/merge-poll.js +104 -0
- package/.agents/scripts/lib/orchestration/plan-context.js +116 -33
- package/.agents/scripts/lib/orchestration/plan-critic-conditions.js +26 -36
- package/.agents/scripts/lib/orchestration/plan-critics-evaluate.js +31 -22
- package/.agents/scripts/lib/orchestration/plan-metrics.js +38 -6
- package/.agents/scripts/lib/orchestration/plan-persist/fan-out-gate.js +16 -6
- package/.agents/scripts/lib/orchestration/plan-persist/persist-helpers.js +173 -25
- package/.agents/scripts/lib/orchestration/plan-persist/plan-context-source.js +116 -0
- package/.agents/scripts/lib/orchestration/plan-persist/run-plan-persist.js +280 -100
- package/.agents/scripts/lib/orchestration/plan-persist/story-ops.js +472 -55
- package/.agents/scripts/lib/orchestration/plan-persist/summary.js +21 -16
- package/.agents/scripts/lib/orchestration/plan-persist/supersede-ops.js +509 -0
- package/.agents/scripts/lib/orchestration/plan-text-hygiene.js +230 -0
- package/.agents/scripts/lib/orchestration/planning/authoring-context.js +41 -40
- package/.agents/scripts/lib/orchestration/planning/decomposer-context.js +1 -2
- package/.agents/scripts/lib/orchestration/planning/spec-authoring-grounding.js +1 -1
- package/.agents/scripts/lib/orchestration/resolve-stories.js +344 -0
- package/.agents/scripts/lib/orchestration/retro-proposals.js +7 -7
- package/.agents/scripts/lib/orchestration/review-depth.js +105 -40
- package/.agents/scripts/lib/orchestration/review-providers/findings-renderer.js +3 -13
- package/.agents/scripts/lib/orchestration/review-providers/native.js +1 -154
- package/.agents/scripts/lib/orchestration/review-providers/review-depth.js +3 -2
- package/.agents/scripts/lib/orchestration/review-providers/security-review.js +1 -1
- package/.agents/scripts/lib/orchestration/review-providers/types.js +5 -4
- package/.agents/scripts/lib/orchestration/review-providers/ultrareview.js +1 -1
- package/.agents/scripts/lib/orchestration/run-epilogue.js +374 -16
- package/.agents/scripts/lib/orchestration/single-story-close/phases/auto-merge.js +24 -0
- package/.agents/scripts/lib/orchestration/single-story-close/phases/base-sync.js +11 -9
- package/.agents/scripts/lib/orchestration/single-story-close/phases/close-validation.js +4 -4
- package/.agents/scripts/lib/orchestration/single-story-close/phases/code-review.js +4 -13
- package/.agents/scripts/lib/orchestration/single-story-close/phases/confirm-merge.js +608 -152
- package/.agents/scripts/lib/orchestration/single-story-close/phases/options.js +72 -30
- package/.agents/scripts/lib/orchestration/single-story-close/phases/post-land.js +305 -0
- package/.agents/scripts/lib/orchestration/single-story-close/phases/pull-request.js +1 -1
- package/.agents/scripts/lib/orchestration/single-story-close/phases/review-block.js +12 -8
- package/.agents/scripts/lib/orchestration/single-story-close/phases/worktree-reap.js +37 -4
- package/.agents/scripts/lib/orchestration/single-story-close/phases/wrong-tree-guard.js +2 -2
- package/.agents/scripts/lib/orchestration/single-story-close/runner.js +264 -43
- package/.agents/scripts/lib/orchestration/single-story-lease-guard.js +1 -1
- package/.agents/scripts/lib/orchestration/story-close/format-autofix.js +10 -10
- package/.agents/scripts/lib/orchestration/story-close/phases/code-review.js +104 -279
- package/.agents/scripts/lib/orchestration/story-close/phases/local-lens-review.js +191 -0
- package/.agents/scripts/lib/orchestration/story-close/phases/review-core.js +120 -0
- package/.agents/scripts/lib/orchestration/story-deliver-terminal.js +360 -0
- package/.agents/scripts/lib/orchestration/story-follow-ups.js +75 -14
- package/.agents/scripts/lib/orchestration/story-init-remote.js +12 -8
- package/.agents/scripts/lib/orchestration/story-plan-state.js +14 -29
- package/.agents/scripts/lib/orchestration/task-body-validator.js +52 -7
- package/.agents/scripts/lib/orchestration/ticket-lease.js +27 -74
- package/.agents/scripts/lib/orchestration/ticket-validator-conflicts.js +119 -14
- package/.agents/scripts/lib/orchestration/ticket-validator-sizing.js +3 -4
- package/.agents/scripts/lib/orchestration/ticket-validator.js +121 -18
- package/.agents/scripts/lib/orchestration/ticketing/bulk.js +14 -47
- package/.agents/scripts/lib/orchestration/ticketing/reads.js +19 -32
- package/.agents/scripts/lib/orchestration/ticketing/transition.js +61 -1
- package/.agents/scripts/lib/orchestration/ticketing.js +0 -1
- package/.agents/scripts/lib/plan-phase-cleanup.js +12 -14
- package/.agents/scripts/lib/planning-corpus.js +12 -286
- package/.agents/scripts/lib/preflight-runner.js +2 -2
- package/.agents/scripts/lib/qa/qa-context-hydrator.js +5 -5
- package/.agents/scripts/lib/signals/index.js +4 -17
- package/.agents/scripts/lib/signals/read.js +35 -35
- package/.agents/scripts/lib/signals/schema.js +8 -11
- package/.agents/scripts/lib/signals/span-tree.js +7 -7
- package/.agents/scripts/lib/signals/write.js +0 -1
- package/.agents/scripts/lib/single-story/story-merged-notify.js +13 -2
- package/.agents/scripts/lib/skills/parse-skill.js +16 -3
- package/.agents/scripts/lib/story-adjacency.js +8 -7
- package/.agents/scripts/lib/story-body/story-body.js +81 -13
- package/.agents/scripts/lib/templates/decomposer-prompts.js +15 -16
- package/.agents/scripts/lib/test-env.js +14 -1
- package/.agents/scripts/lib/test-tiers.js +0 -3
- package/.agents/scripts/lib/ticket-body-sections.js +0 -14
- package/.agents/scripts/lib/validation-evidence.js +31 -59
- package/.agents/scripts/lib/wave-runner/live-probe.js +315 -0
- package/.agents/scripts/lib/wave-runner/ready-set.js +32 -6
- package/.agents/scripts/lib/worktree/lifecycle/pending-cleanup.js +1 -1
- package/.agents/scripts/lib/worktree/lifecycle/reap.js +68 -19
- package/.agents/scripts/lib/worktree/lifecycle-manager.js +1 -2
- package/.agents/scripts/plan-context.js +38 -7
- package/.agents/scripts/plan-critics.js +203 -0
- package/.agents/scripts/plan-persist.js +145 -35
- package/.agents/scripts/plan-run-epilogue.js +83 -38
- package/.agents/scripts/post-structured-comment.js +0 -38
- package/.agents/scripts/pr-watch-with-update.js +43 -22
- package/.agents/scripts/providers/github/compose.js +0 -1
- package/.agents/scripts/providers/github/errors.js +0 -19
- package/.agents/scripts/providers/github/issues.js +1 -11
- package/.agents/scripts/providers/github/mappers.js +5 -0
- package/.agents/scripts/providers/github/sub-issues.js +0 -47
- package/.agents/scripts/providers/github/tickets.js +33 -153
- package/.agents/scripts/providers/github.js +17 -6
- package/.agents/scripts/quality-preview.js +13 -6
- package/.agents/scripts/resolve-stories.js +236 -0
- package/.agents/scripts/run-coverage.js +4 -1
- package/.agents/scripts/run-lint.js +2 -2
- package/.agents/scripts/run-verify.js +31 -2
- package/.agents/scripts/signals-view.js +9 -10
- package/.agents/scripts/single-story-close.js +173 -18
- package/.agents/scripts/single-story-confirm-merge.js +288 -15
- package/.agents/scripts/single-story-init.js +6 -10
- package/.agents/scripts/stories-wave-tick.js +380 -53
- package/.agents/scripts/story-plan.js +3 -3
- package/.agents/scripts/update-ticket-state.js +8 -50
- package/.agents/skills/core/code-review-and-quality/SKILL.md +28 -450
- package/.agents/skills/core/code-review-and-quality/reference.md +458 -0
- package/.agents/skills/core/debugging-and-error-recovery/SKILL.md +22 -315
- package/.agents/skills/core/debugging-and-error-recovery/reference.md +323 -0
- package/.agents/skills/core/diagnose-friction/SKILL.md +14 -18
- package/.agents/skills/core/documentation-and-adrs/SKILL.md +25 -397
- package/.agents/skills/core/documentation-and-adrs/reference.md +403 -0
- package/.agents/skills/core/gates-and-baselines/SKILL.md +12 -12
- package/.agents/skills/core/idea-refinement/SKILL.md +3 -3
- package/.agents/skills/core/scope-triage/SKILL.md +3 -0
- package/.agents/skills/core/security-and-hardening/SKILL.md +22 -367
- package/.agents/skills/core/security-and-hardening/reference.md +375 -0
- package/.agents/skills/skills.index.json +2 -12
- package/.agents/skills/stack/qa/playwright-bdd/SKILL.md +2 -4
- package/.agents/skills/stack/qa/qa-explore-driving/SKILL.md +1 -1
- package/.agents/skills/stack/qa/qa-harness/SKILL.md +1 -3
- package/.agents/workflows/audit-architecture.md +3 -4
- package/.agents/workflows/audit-clean-code.md +4 -4
- package/.agents/workflows/audit-documentation.md +4 -5
- package/.agents/workflows/audit-lighthouse.md +8 -0
- package/.agents/workflows/audit-navigability.md +10 -0
- package/.agents/workflows/audit-performance.md +2 -3
- package/.agents/workflows/audit-quality.md +8 -9
- package/.agents/workflows/audit-security.md +1 -2
- package/.agents/workflows/audit-seo.md +10 -0
- package/.agents/workflows/audit-ux-ui.md +7 -0
- package/.agents/workflows/deliver.md +133 -45
- package/.agents/workflows/git-cleanup.md +2 -2
- package/.agents/workflows/git-deliver.md +1 -1
- package/.agents/workflows/helpers/acceptance-self-eval.md +34 -17
- package/.agents/workflows/helpers/code-quality-guardrails.md +15 -12
- package/.agents/workflows/helpers/code-review.md +14 -12
- package/.agents/workflows/helpers/deliver-story-reference.md +73 -32
- package/.agents/workflows/helpers/deliver-story.md +209 -118
- package/.agents/workflows/helpers/parallel-tooling.md +2 -2
- package/.agents/workflows/helpers/worktree-lifecycle.md +28 -32
- package/.agents/workflows/plan.md +239 -19
- package/.agents/workflows/qa-assist.md +6 -6
- package/.agents/workflows/qa-explore.md +3 -3
- package/.agents/workflows/qa-run.md +1 -5
- package/bin/mandrel.js +12 -1
- package/docs/CHANGELOG.md +62 -0
- package/lib/cli/registry.js +262 -19
- package/lib/cli/sync-agents.js +157 -0
- package/lib/cli/sync-commands.js +115 -6
- package/lib/cli/sync.js +168 -6
- package/lib/cli/update.js +105 -8
- package/lib/cli/version-helpers.js +131 -0
- package/lib/migrations/README.md +7 -5
- package/lib/migrations/index.js +17 -9
- package/lib/migrations/steps/2.1.0-retire-mi-drop-knobs.js +100 -0
- package/lib/migrations/steps/2.1.0-retire-verify-concurrency-cap.js +101 -0
- package/lib/migrations/steps/2.2.0-retire-epic-ac-tags.js +154 -0
- package/package.json +2 -2
- package/.agents/schemas/epic-perf-report.schema.json +0 -89
- package/.agents/schemas/lifecycle/acceptance.reconcile.failed.schema.json +0 -13
- package/.agents/schemas/lifecycle/acceptance.reconcile.ok.schema.json +0 -13
- package/.agents/schemas/lifecycle/acceptance.reconcile.skipped.schema.json +0 -13
- package/.agents/schemas/lifecycle/acceptance.reconcile.start.schema.json +0 -12
- package/.agents/schemas/lifecycle/acceptance.reconcile.waived.schema.json +0 -13
- package/.agents/schemas/lifecycle/epic.automerge.end.schema.json +0 -15
- package/.agents/schemas/lifecycle/epic.automerge.start.schema.json +0 -13
- package/.agents/schemas/lifecycle/epic.blocked.schema.json +0 -13
- package/.agents/schemas/lifecycle/epic.cleanup.end.schema.json +0 -12
- package/.agents/schemas/lifecycle/epic.cleanup.start.schema.json +0 -12
- package/.agents/schemas/lifecycle/epic.close.end.schema.json +0 -12
- package/.agents/schemas/lifecycle/epic.complete.schema.json +0 -13
- package/.agents/schemas/lifecycle/epic.finalize.end.schema.json +0 -13
- package/.agents/schemas/lifecycle/epic.finalize.start.schema.json +0 -12
- package/.agents/schemas/lifecycle/epic.merge.armed.schema.json +0 -13
- package/.agents/schemas/lifecycle/epic.merge.blocked.schema.json +0 -14
- package/.agents/schemas/lifecycle/epic.merge.confirmed.schema.json +0 -17
- package/.agents/schemas/lifecycle/epic.merge.ready.schema.json +0 -15
- package/.agents/schemas/lifecycle/epic.plan.end.schema.json +0 -18
- package/.agents/schemas/lifecycle/epic.plan.start.schema.json +0 -12
- package/.agents/schemas/lifecycle/epic.snapshot.end.schema.json +0 -16
- package/.agents/schemas/lifecycle/epic.snapshot.start.schema.json +0 -12
- package/.agents/schemas/lifecycle/epic.watch.end.schema.json +0 -29
- package/.agents/schemas/lifecycle/epic.watch.start.schema.json +0 -16
- package/.agents/schemas/lifecycle/story.heartbeat.schema.json +0 -20
- package/.agents/schemas/risk-verdict.schema.json +0 -53
- package/.agents/schemas/story-perf-summary.schema.json +0 -73
- package/.agents/scripts/analyze-execution.js +0 -444
- package/.agents/scripts/check-prepush-recovery.js +0 -90
- package/.agents/scripts/lib/git-merge-orchestrator.js +0 -261
- package/.agents/scripts/lib/observability/baseline-refresh-rate.js +0 -221
- package/.agents/scripts/lib/observability/hook-heartbeat.js +0 -187
- package/.agents/scripts/lib/observability/perf-aggregator.js +0 -813
- package/.agents/scripts/lib/observability/perf-report-readers.js +0 -328
- package/.agents/scripts/lib/observability/perf-report-render.js +0 -182
- package/.agents/scripts/lib/orchestration/audit-lens-routing.js +0 -128
- package/.agents/scripts/lib/orchestration/bookkeeping-outbox.js +0 -273
- package/.agents/scripts/lib/orchestration/error-journal.js +0 -139
- package/.agents/scripts/lib/orchestration/lifecycle/emit-story-heartbeat.js +0 -155
- package/.agents/scripts/lib/orchestration/lifecycle/ledger-diff.js +0 -140
- package/.agents/scripts/lib/orchestration/lifecycle/listeners/merge-watcher.js +0 -665
- package/.agents/scripts/lib/orchestration/plan-review-routing.js +0 -63
- package/.agents/scripts/lib/orchestration/planning/risk-verdict.js +0 -104
- package/.agents/scripts/lib/orchestration/planning-context-budget.js +0 -213
- package/.agents/scripts/lib/orchestration/planning-risk.js +0 -194
- package/.agents/scripts/lib/orchestration/post-merge/phases/branch-cleanup.js +0 -56
- package/.agents/scripts/lib/orchestration/post-merge/phases/dashboard-refresh.js +0 -21
- package/.agents/scripts/lib/orchestration/post-merge/phases/notification.js +0 -78
- package/.agents/scripts/lib/orchestration/post-merge/phases/temp-cleanup.js +0 -68
- package/.agents/scripts/lib/orchestration/post-merge/phases/ticket-closure.js +0 -118
- package/.agents/scripts/lib/orchestration/post-merge/phases/worktree-reap.js +0 -397
- package/.agents/scripts/lib/orchestration/preflight-cache.js +0 -187
- package/.agents/scripts/lib/orchestration/resolve-plan-run.js +0 -155
- package/.agents/scripts/lib/orchestration/retro-perf-heuristics.js +0 -275
- package/.agents/scripts/lib/orchestration/story-progress/story-run-progress-writer.js +0 -400
- package/.agents/scripts/lib/single-story/confirm-merge-follow-ups.js +0 -36
- package/.agents/scripts/resolve-plan-run.js +0 -117
- package/.agents/skills/core/analyze-execution/SKILL.md +0 -101
|
@@ -16,6 +16,7 @@ import fs from 'node:fs';
|
|
|
16
16
|
import os from 'node:os';
|
|
17
17
|
import path from 'node:path';
|
|
18
18
|
import { pathToFileURL } from 'node:url';
|
|
19
|
+
import { isCommandExcluded } from '../command-header.js';
|
|
19
20
|
import { detectPackageManager as detectPm } from '../detect-package-manager.js';
|
|
20
21
|
import { LEDGER_RELATIVE_PATH } from './install-ledger.js';
|
|
21
22
|
import { ensureIssueForms } from './issue-forms-template.js';
|
|
@@ -385,52 +386,17 @@ export async function validateAgentrc(ctx) {
|
|
|
385
386
|
return { ok: !!ok, errors: ok ? [] : (validate.errors ?? []) };
|
|
386
387
|
}
|
|
387
388
|
|
|
388
|
-
|
|
389
|
-
|
|
390
|
-
|
|
391
|
-
|
|
392
|
-
|
|
393
|
-
|
|
394
|
-
|
|
395
|
-
|
|
396
|
-
|
|
397
|
-
|
|
398
|
-
|
|
399
|
-
* @param {typeof fs} [ctx.fsImpl]
|
|
400
|
-
*/
|
|
401
|
-
export function ensureClaudeSettings(ctx) {
|
|
402
|
-
const { fsImpl = fs } = ctx;
|
|
403
|
-
const target = path.join(ctx.projectRoot, '.claude', 'settings.json');
|
|
404
|
-
const hook = { type: 'command', command: SYNC_COMMAND };
|
|
405
|
-
if (!fsImpl.existsSync(target)) {
|
|
406
|
-
fsImpl.mkdirSync(path.dirname(target), { recursive: true });
|
|
407
|
-
const fresh = {
|
|
408
|
-
hooks: {
|
|
409
|
-
UserPromptSubmit: [{ hooks: [hook] }],
|
|
410
|
-
},
|
|
411
|
-
};
|
|
412
|
-
writeJson(target, fresh, fsImpl);
|
|
413
|
-
return { action: 'created', path: target };
|
|
414
|
-
}
|
|
415
|
-
const settings = readJsonIfExists(target, fsImpl);
|
|
416
|
-
settings.hooks = settings.hooks ?? {};
|
|
417
|
-
settings.hooks.UserPromptSubmit = settings.hooks.UserPromptSubmit ?? [];
|
|
418
|
-
const hookAlready = settings.hooks.UserPromptSubmit.some((group) =>
|
|
419
|
-
(group?.hooks ?? []).some(
|
|
420
|
-
(h) =>
|
|
421
|
-
typeof h?.command === 'string' &&
|
|
422
|
-
h.command.includes('sync-claude-commands.js'),
|
|
423
|
-
),
|
|
424
|
-
);
|
|
425
|
-
let mutated = false;
|
|
426
|
-
if (!hookAlready) {
|
|
427
|
-
settings.hooks.UserPromptSubmit.push({ hooks: [hook] });
|
|
428
|
-
mutated = true;
|
|
429
|
-
}
|
|
430
|
-
if (!mutated) return { action: 'already-present', path: target };
|
|
431
|
-
writeJson(target, settings, fsImpl);
|
|
432
|
-
return { action: 'merged', path: target };
|
|
433
|
-
}
|
|
389
|
+
// Story #4527/#4530: the UserPromptSubmit sync-hook wiring
|
|
390
|
+
// (ensureClaudeSettings, formerly Step 3) was removed. It spawned
|
|
391
|
+
// `mandrel sync-commands` on every prompt to keep `.claude/commands/` in
|
|
392
|
+
// sync with `.agents/workflows/` — a rewrite racing the harness's own read
|
|
393
|
+
// of that same directory while expanding a slash command, and a directory
|
|
394
|
+
// that cannot change mid-session in the first place, so the hook reported
|
|
395
|
+
// `0 file(s) synced` on effectively every invocation. The real sync points
|
|
396
|
+
// already cover every case: `prepare` on install, `mandrel sync` /
|
|
397
|
+
// `mandrel update` on upgrade, and doctor's `commands-in-sync` check for
|
|
398
|
+
// hand-edits. `lib/cli/uninstall.js#revertClaudeSettings` still removes the
|
|
399
|
+
// hook from a consumer who already has it installed from a prior version.
|
|
434
400
|
|
|
435
401
|
/**
|
|
436
402
|
* Step 4 + Step 8 — Ensure `.gitignore` carries every {@link GITIGNORE_BLOCKS}
|
|
@@ -466,7 +432,7 @@ export function ensureGitignore(ctx) {
|
|
|
466
432
|
|
|
467
433
|
/**
|
|
468
434
|
* Materialize the generated GitHub Issue Forms
|
|
469
|
-
* (`.github/ISSUE_TEMPLATE/story.yml`
|
|
435
|
+
* (`.github/ISSUE_TEMPLATE/story.yml`) into the consumer
|
|
470
436
|
* project (Story #4227). Derived from the Story-body SSOT so a human-filed
|
|
471
437
|
* ticket round-trips through `story-body.parse()`. Idempotent and additive,
|
|
472
438
|
* mirroring `ensureGitignore`: byte-identical forms are `unchanged`,
|
|
@@ -547,6 +513,15 @@ export function runSyncCommands(ctx) {
|
|
|
547
513
|
* this; this is a belt-and-braces verification that the command projection
|
|
548
514
|
* covers every top-level workflow.
|
|
549
515
|
*
|
|
516
|
+
* A workflow whose frontmatter carries `command: false` is deliberately NOT
|
|
517
|
+
* projected to a command — `sync-claude-commands.js` skips it via the same
|
|
518
|
+
* `isCommandExcluded` predicate used here. Such a workflow must therefore be
|
|
519
|
+
* excluded from the expected-command set, or this check would demand a
|
|
520
|
+
* command the sync is contracted never to emit (e.g. the `audit-lighthouse` /
|
|
521
|
+
* `audit-security` lenses, which are run by the audit suite, not as slash
|
|
522
|
+
* commands). Keeping the two surfaces on one predicate is what stops them
|
|
523
|
+
* drifting.
|
|
524
|
+
*
|
|
550
525
|
* @param {object} ctx
|
|
551
526
|
* @param {typeof fs} [ctx.fsImpl]
|
|
552
527
|
*/
|
|
@@ -565,7 +540,14 @@ export function checkParity(ctx) {
|
|
|
565
540
|
.map((e) => e.name.replace(/\.md$/, ''))
|
|
566
541
|
.sort()
|
|
567
542
|
: [];
|
|
568
|
-
|
|
543
|
+
// Expected commands = projectable workflows only. A `command: false`
|
|
544
|
+
// workflow is contracted out of the command tree, so it is not "missing" a
|
|
545
|
+
// command — it declined one.
|
|
546
|
+
const projectable = (name) =>
|
|
547
|
+
!isCommandExcluded(
|
|
548
|
+
fsImpl.readFileSync(path.join(workflowsDir, `${name}.md`), 'utf8'),
|
|
549
|
+
);
|
|
550
|
+
const workflows = new Set(list(workflowsDir).filter(projectable));
|
|
569
551
|
const commands = new Set(list(commandsDir));
|
|
570
552
|
const missingCommand = [...workflows].filter((n) => !commands.has(n));
|
|
571
553
|
const orphanCommand = [...commands].filter((n) => !workflows.has(n));
|
|
@@ -744,11 +726,6 @@ export const BOOTSTRAP_PHASES = Object.freeze([
|
|
|
744
726
|
isFatal: true,
|
|
745
727
|
formatError: fatalValidation,
|
|
746
728
|
},
|
|
747
|
-
{
|
|
748
|
-
name: 'claudeSettings',
|
|
749
|
-
phaseGroup: PHASE_GROUPS.IDE_WIRING,
|
|
750
|
-
run: (ctx) => ensureClaudeSettings(ctx),
|
|
751
|
-
},
|
|
752
729
|
{
|
|
753
730
|
name: 'systemPromptWiring',
|
|
754
731
|
phaseGroup: PHASE_GROUPS.IDE_WIRING,
|
|
@@ -76,12 +76,10 @@ export const QUALITY_CONFIG_DEFAULTS = Object.freeze({
|
|
|
76
76
|
codingGuardrails: Object.freeze({
|
|
77
77
|
cyclomaticFlag: 8,
|
|
78
78
|
cyclomaticMustFix: 12,
|
|
79
|
-
miDropMustRefactor: 1.5,
|
|
80
79
|
requireSiblingTest: false,
|
|
81
80
|
}),
|
|
82
81
|
autoRefresh: Object.freeze({
|
|
83
82
|
enabled: true,
|
|
84
|
-
miDropCap: 1.5,
|
|
85
83
|
crapJumpCap: 5,
|
|
86
84
|
scope: 'diff',
|
|
87
85
|
}),
|
|
@@ -24,7 +24,10 @@
|
|
|
24
24
|
export default {
|
|
25
25
|
id: 'core-bare-clean',
|
|
26
26
|
severity: 'blocker',
|
|
27
|
-
|
|
27
|
+
// 'npm-test' keeps the test-wrapper preflight's refusal claim true: a
|
|
28
|
+
// poisoned shared config is caught before a suite (or N concurrent
|
|
29
|
+
// /deliver workers) inherits it, not only at close/retro time (#4580).
|
|
30
|
+
scope: ['story-close', 'retro', 'npm-test'],
|
|
28
31
|
autoCorrect: 'refuse-and-print',
|
|
29
32
|
detect(state) {
|
|
30
33
|
const coreBare = state?.git?.coreBare;
|
|
@@ -182,7 +182,7 @@ export async function getCheck(id, opts) {
|
|
|
182
182
|
*
|
|
183
183
|
* @param {object} opts
|
|
184
184
|
* @param {string} [opts.scope] Surface scope, e.g. 'story-close',
|
|
185
|
-
* '
|
|
185
|
+
* 'story-close', 'npm-test', 'retro', 'diagnose'. When omitted, every check runs.
|
|
186
186
|
* @param {boolean} [opts.autoFix=false] Invoke `fix()` for checks with
|
|
187
187
|
* `autoCorrect: 'auto'`. Forbidden when `scope === 'retro'`.
|
|
188
188
|
* @param {object} opts.state Probed state from `assembleState()`.
|
|
@@ -10,15 +10,15 @@
|
|
|
10
10
|
*
|
|
11
11
|
* 1. **Schema-invalid signal lines.** It tails the most recent
|
|
12
12
|
* {@link MAX_SAMPLE_LINES} lines of every `signals.ndjson` stream under
|
|
13
|
-
* the
|
|
13
|
+
* the run temp tree and validates each against the canonical
|
|
14
14
|
* `signal-event.schema.json` (via `validateSignal`, the same validator
|
|
15
15
|
* the writer uses — no hand-rolled drift).
|
|
16
|
-
* 2. **Persisted write-time rejects.** It reads the per-
|
|
17
|
-
* (`temp/
|
|
16
|
+
* 2. **Persisted write-time rejects.** It reads the per-run reject tally
|
|
17
|
+
* (`temp/run-<id>/signal-rejects.json`, written by Story #4413's
|
|
18
18
|
* signals-writer) so records that were dropped at write time — and thus
|
|
19
19
|
* never appear in the stream — are still counted.
|
|
20
20
|
* 3. **Un-actioned retro proposals.** It reads the retro mirror
|
|
21
|
-
* (`temp/
|
|
21
|
+
* (`temp/run-<id>/retro.md`, Story #4418) and flags any actionable
|
|
22
22
|
* "Proposed issues" item that carries neither a filed-issue reference
|
|
23
23
|
* (`Filed: [#N](url)`) nor lives under the explicit "One-off /
|
|
24
24
|
* discarded" record.
|
|
@@ -49,9 +49,10 @@ import { validateSignal } from '../observability/signal-validator.js';
|
|
|
49
49
|
export const MAX_SAMPLE_LINES = 200;
|
|
50
50
|
|
|
51
51
|
/**
|
|
52
|
-
* Locate the most-recently-touched `
|
|
53
|
-
* `<baseDir>/<tempRoot
|
|
54
|
-
*
|
|
52
|
+
* Locate the most-recently-touched `run-<id>` temp tree under
|
|
53
|
+
* `<baseDir>/<tempRoot>` (the layout `lib/config/temp-paths.js` creates).
|
|
54
|
+
* Returns `{ epicId, epicDir }` or `null` when no run temp tree exists (a
|
|
55
|
+
* fresh checkout, or a context with no run in flight).
|
|
55
56
|
*
|
|
56
57
|
* @param {string} baseDir The main checkout root.
|
|
57
58
|
* @param {{ tempRoot?: string, fsImpl?: { readdirSync: typeof readdirSync, statSync: typeof statSync } }} [opts]
|
|
@@ -72,7 +73,7 @@ export function resolveEpicTempTree(
|
|
|
72
73
|
}
|
|
73
74
|
let best = null;
|
|
74
75
|
for (const entry of entries) {
|
|
75
|
-
const match = /^
|
|
76
|
+
const match = /^run-(\d+)$/.exec(entry);
|
|
76
77
|
if (!match) continue;
|
|
77
78
|
const full = path.join(tempDir, entry);
|
|
78
79
|
let st;
|
|
@@ -168,7 +169,7 @@ export function sampleStreamInvalidCount(
|
|
|
168
169
|
}
|
|
169
170
|
|
|
170
171
|
/**
|
|
171
|
-
* Read the per-
|
|
172
|
+
* Read the per-run persisted reject count from `signal-rejects.json`.
|
|
172
173
|
* Returns 0 when the tally is absent or unreadable.
|
|
173
174
|
*
|
|
174
175
|
* @param {string} epicDir
|
|
@@ -316,10 +317,10 @@ export function detectLoopHealth(
|
|
|
316
317
|
id: 'loop-health',
|
|
317
318
|
severity: 'warning',
|
|
318
319
|
scope,
|
|
319
|
-
summary: `Loop-health (
|
|
320
|
+
summary: `Loop-health (run-${epicId}): ${summaryParts.join('; ')}.`,
|
|
320
321
|
detail: detailLines.join('\n'),
|
|
321
322
|
fixCommand:
|
|
322
|
-
'Inspect temp/
|
|
323
|
+
'Inspect temp/run-<id>/{signals.ndjson,signal-rejects.json,retro.md}; fix the signal producer or file/discard the surfaced proposals.',
|
|
323
324
|
autoCorrectable: false,
|
|
324
325
|
};
|
|
325
326
|
}
|
|
@@ -5,7 +5,7 @@
|
|
|
5
5
|
* that checks declared for the given scope actually need. The runner in
|
|
6
6
|
* `index.js` filters the registry by `scope` first, then asks this module
|
|
7
7
|
* for state; the per-scope projection keeps probe cost proportional to the
|
|
8
|
-
* call site (e.g. `story-close` does not pay for `
|
|
8
|
+
* call site (e.g. `story-close` does not pay for `diagnose` probes, and
|
|
9
9
|
* the `retro` consumer only probes inputs the retro-scoped checks need).
|
|
10
10
|
*
|
|
11
11
|
* Privacy contract:
|
|
@@ -32,7 +32,7 @@
|
|
|
32
32
|
*/
|
|
33
33
|
|
|
34
34
|
import { spawnSync } from 'node:child_process';
|
|
35
|
-
import { existsSync
|
|
35
|
+
import { existsSync } from 'node:fs';
|
|
36
36
|
import path from 'node:path';
|
|
37
37
|
|
|
38
38
|
/**
|
|
@@ -45,23 +45,18 @@ import path from 'node:path';
|
|
|
45
45
|
*
|
|
46
46
|
* @type {Record<string, readonly string[]>}
|
|
47
47
|
*/
|
|
48
|
-
//
|
|
49
|
-
//
|
|
50
|
-
// `epic-close` and `npm-test` aliases.
|
|
48
|
+
// Story-close probe surface: branch list + worktree set. Story #1289
|
|
49
|
+
// introduced the `npm-test` alias.
|
|
51
50
|
const STORY_CLOSE_KEYS = Object.freeze([
|
|
52
51
|
'git.headRef',
|
|
53
|
-
'git.epicBranches',
|
|
54
|
-
'git.epicBranchSync',
|
|
55
52
|
'git.localBranches',
|
|
56
53
|
'git.coreBare',
|
|
57
54
|
'fs.worktrees',
|
|
58
|
-
'fs.epicMergeLocks',
|
|
59
55
|
'env.GITHUB_TOKEN',
|
|
60
56
|
]);
|
|
61
57
|
|
|
62
|
-
const
|
|
58
|
+
const DIAGNOSE_KEYS = Object.freeze([
|
|
63
59
|
'git.headRef',
|
|
64
|
-
'git.epicBranches',
|
|
65
60
|
'git.coreBare',
|
|
66
61
|
'fs.worktrees',
|
|
67
62
|
'fs.dotEnv',
|
|
@@ -71,8 +66,6 @@ const EPIC_DELIVER_KEYS = Object.freeze([
|
|
|
71
66
|
|
|
72
67
|
const SCOPE_KEYS = Object.freeze({
|
|
73
68
|
'story-close': STORY_CLOSE_KEYS,
|
|
74
|
-
'epic-close': STORY_CLOSE_KEYS,
|
|
75
|
-
'epic-deliver': EPIC_DELIVER_KEYS,
|
|
76
69
|
'npm-test': Object.freeze([
|
|
77
70
|
'git.headRef',
|
|
78
71
|
'git.coreBare',
|
|
@@ -80,8 +73,11 @@ const SCOPE_KEYS = Object.freeze({
|
|
|
80
73
|
'fs.dotEnv',
|
|
81
74
|
'fs.dotMcp',
|
|
82
75
|
]),
|
|
83
|
-
|
|
84
|
-
|
|
76
|
+
// git.coreBare: core-bare-clean declares scope ['story-close', 'retro',
|
|
77
|
+
// 'npm-test']; without the probe key its detect() reads undefined and the
|
|
78
|
+
// retro leg is a silent no-op (#4580).
|
|
79
|
+
retro: Object.freeze(['git.headRef', 'git.coreBare', 'fs.worktrees']),
|
|
80
|
+
diagnose: DIAGNOSE_KEYS,
|
|
85
81
|
});
|
|
86
82
|
|
|
87
83
|
/**
|
|
@@ -138,78 +134,6 @@ function defaultEnvProbe(name) {
|
|
|
138
134
|
return process.env[name] ? 'set' : 'missing';
|
|
139
135
|
}
|
|
140
136
|
|
|
141
|
-
/**
|
|
142
|
-
* Default lock-file probe — reads an epic merge lock file at the given
|
|
143
|
-
* absolute path. Returns `{ exists, pid, acquiredAt, mtimeMs }` or
|
|
144
|
-
* `{ exists: false }`. PID + timestamp are NOT secrets — they are
|
|
145
|
-
* operational data the orphan-lock check uses to decide if a lock is
|
|
146
|
-
* stale. This probe is separate from the privacy-bounded `fs` probe so
|
|
147
|
-
* the README's "fs records existence only" contract for bootstrap files
|
|
148
|
-
* (.env, .mcp.json) remains intact.
|
|
149
|
-
*
|
|
150
|
-
* @param {string} absPath
|
|
151
|
-
* @returns {{ exists: boolean, pid?: number|null, acquiredAt?: number|null, mtimeMs?: number|null }}
|
|
152
|
-
*/
|
|
153
|
-
function defaultLockProbe(absPath) {
|
|
154
|
-
let st;
|
|
155
|
-
try {
|
|
156
|
-
st = statSync(absPath);
|
|
157
|
-
} catch {
|
|
158
|
-
return { exists: false };
|
|
159
|
-
}
|
|
160
|
-
let pid = null;
|
|
161
|
-
let acquiredAt = null;
|
|
162
|
-
try {
|
|
163
|
-
const raw = readFileSync(absPath, 'utf8');
|
|
164
|
-
const parsed = JSON.parse(raw);
|
|
165
|
-
pid = Number.isFinite(Number(parsed.pid)) ? Number(parsed.pid) : null;
|
|
166
|
-
acquiredAt = Number.isFinite(Number(parsed.acquiredAt))
|
|
167
|
-
? Number(parsed.acquiredAt)
|
|
168
|
-
: null;
|
|
169
|
-
} catch {
|
|
170
|
-
// Corrupted or unreadable — still report existence with null fields so
|
|
171
|
-
// the consumer can surface "lock file exists but is unparseable".
|
|
172
|
-
}
|
|
173
|
-
return { exists: true, pid, acquiredAt, mtimeMs: st.mtimeMs };
|
|
174
|
-
}
|
|
175
|
-
|
|
176
|
-
/**
|
|
177
|
-
* Predicate: is `pid` a shape we can hand to `process.kill(_, 0)`? Splits
|
|
178
|
-
* the input-validity check out of `defaultPidLivenessProbe` so the
|
|
179
|
-
* defensive guard cascade and the OS round-trip are independently
|
|
180
|
-
* testable. Exported so sibling tests can exercise every branch without
|
|
181
|
-
* monkey-patching `process.kill`.
|
|
182
|
-
*
|
|
183
|
-
* @param {*} pid
|
|
184
|
-
* @returns {boolean}
|
|
185
|
-
*/
|
|
186
|
-
export function validatePidProbeInputs(pid) {
|
|
187
|
-
if (pid === null || pid === undefined) return false;
|
|
188
|
-
if (typeof pid !== 'number') return false;
|
|
189
|
-
if (!Number.isFinite(pid)) return false;
|
|
190
|
-
if (pid <= 0) return false;
|
|
191
|
-
return true;
|
|
192
|
-
}
|
|
193
|
-
|
|
194
|
-
/**
|
|
195
|
-
* Default process-liveness probe — `process.kill(pid, 0)` checks existence
|
|
196
|
-
* without delivering a signal. Returns true for live, false for dead/missing.
|
|
197
|
-
* Separated from the lock probe so tests can independently spy on each.
|
|
198
|
-
*
|
|
199
|
-
* @param {number|null|undefined} pid
|
|
200
|
-
* @returns {boolean}
|
|
201
|
-
*/
|
|
202
|
-
function defaultPidLivenessProbe(pid) {
|
|
203
|
-
if (!validatePidProbeInputs(pid)) return false;
|
|
204
|
-
try {
|
|
205
|
-
process.kill(pid, 0);
|
|
206
|
-
return true;
|
|
207
|
-
} catch (err) {
|
|
208
|
-
// EPERM = exists but unsignalable — still alive.
|
|
209
|
-
return err && err.code === 'EPERM';
|
|
210
|
-
}
|
|
211
|
-
}
|
|
212
|
-
|
|
213
137
|
/**
|
|
214
138
|
* Probe the current HEAD ref (short / abbreviated form). Returns the branch
|
|
215
139
|
* name, or `null` when git cannot resolve HEAD (detached / non-repo).
|
|
@@ -240,20 +164,6 @@ function parseBranchList(result) {
|
|
|
240
164
|
: [];
|
|
241
165
|
}
|
|
242
166
|
|
|
243
|
-
/**
|
|
244
|
-
* Probe the epic branches (`refs/heads/epic/`), short-name form.
|
|
245
|
-
*
|
|
246
|
-
* @param {object} args
|
|
247
|
-
* @param {string} args.cwd
|
|
248
|
-
* @param {(cwd: string, ...args: string[]) => { ok: boolean, stdout: string }} args.git
|
|
249
|
-
* @returns {string[]}
|
|
250
|
-
*/
|
|
251
|
-
function probeEpicBranches({ cwd, git }) {
|
|
252
|
-
return parseBranchList(
|
|
253
|
-
git(cwd, 'for-each-ref', '--format=%(refname:short)', 'refs/heads/epic/'),
|
|
254
|
-
);
|
|
255
|
-
}
|
|
256
|
-
|
|
257
167
|
/**
|
|
258
168
|
* Probe all local branches (`refs/heads/`), short-name form. Used by checks
|
|
259
169
|
* that grep over the branch list for legacy naming patterns.
|
|
@@ -282,107 +192,24 @@ function probeCoreBare({ cwd, git }) {
|
|
|
282
192
|
return result.ok ? result.stdout : null;
|
|
283
193
|
}
|
|
284
194
|
|
|
285
|
-
/**
|
|
286
|
-
* Build a map of epic branch → { local, remote, ahead } sync state.
|
|
287
|
-
* Standalone (Story #3351): takes the already-assembled `epicBranches` as an
|
|
288
|
-
* explicit argument rather than reading sibling probe output, so it is
|
|
289
|
-
* independently testable and the ordering dependency on the epicBranches
|
|
290
|
-
* probe is explicit at the call site.
|
|
291
|
-
*
|
|
292
|
-
* Story #2463 (preflight batching): the prior implementation issued
|
|
293
|
-
* two `git rev-parse --verify` spawnSync calls per epic branch
|
|
294
|
-
* (one for `epic/<id>`, one for `origin/epic/<id>`), giving an
|
|
295
|
-
* O(branches × 2) probe cost. The collapsed implementation issues
|
|
296
|
-
* exactly one `git for-each-ref` invocation that emits
|
|
297
|
-
* `<refname> <objectname> <upstream:short> <upstream:objectname>`
|
|
298
|
-
* for every local branch, then filters to the epic branches the
|
|
299
|
-
* scope already declared. Probe cost drops to O(1) for the spawn
|
|
300
|
-
* surface while preserving the byte-identical return shape:
|
|
301
|
-
* { local: string|null, remote: string|null, ahead: boolean }.
|
|
302
|
-
*
|
|
303
|
-
* `ahead` stays true only when local AND remote SHAs both exist and
|
|
304
|
-
* differ — branches with no upstream config (no `%(upstream:objectname)`)
|
|
305
|
-
* report `remote: null, ahead: false`, matching the pre-batch behavior
|
|
306
|
-
* where `rev-parse --verify origin/<branch>` failed for unpushed refs.
|
|
307
|
-
*
|
|
308
|
-
* @param {object} args
|
|
309
|
-
* @param {string} args.cwd
|
|
310
|
-
* @param {(cwd: string, ...args: string[]) => { ok: boolean, stdout: string }} args.git
|
|
311
|
-
* @param {readonly string[]} args.epicBranches
|
|
312
|
-
* @returns {Record<string, { local: string|null, remote: string|null, ahead: boolean }>}
|
|
313
|
-
*/
|
|
314
|
-
function probeEpicBranchSync({ cwd, git, epicBranches }) {
|
|
315
|
-
const sync = {};
|
|
316
|
-
const branches = epicBranches ?? [];
|
|
317
|
-
const branchSet = new Set(branches);
|
|
318
|
-
const formatted = git(
|
|
319
|
-
cwd,
|
|
320
|
-
'for-each-ref',
|
|
321
|
-
'--format=%(refname:short) %(objectname) %(upstream:short) %(upstream:objectname)',
|
|
322
|
-
'refs/heads/',
|
|
323
|
-
);
|
|
324
|
-
const rows = new Map();
|
|
325
|
-
if (formatted.ok && formatted.stdout) {
|
|
326
|
-
for (const line of formatted.stdout.split('\n')) {
|
|
327
|
-
if (!line) continue;
|
|
328
|
-
// Split on whitespace; trailing fields may be empty strings.
|
|
329
|
-
// refname is mandatory (always present); objectname always populated
|
|
330
|
-
// for an existing ref; upstream fields may be missing.
|
|
331
|
-
const parts = line.split(' ');
|
|
332
|
-
const refname = parts[0];
|
|
333
|
-
if (!refname || !branchSet.has(refname)) continue;
|
|
334
|
-
const objectname = parts[1] || null;
|
|
335
|
-
const upstreamShort = parts[2] || null;
|
|
336
|
-
const upstreamObjectname = parts[3] || null;
|
|
337
|
-
rows.set(refname, {
|
|
338
|
-
local: objectname,
|
|
339
|
-
// Surface remote SHA only when an upstream is configured AND
|
|
340
|
-
// git resolved its objectname. An upstream short-name without
|
|
341
|
-
// an objectname (gone-upstream edge case) collapses to null.
|
|
342
|
-
remote: upstreamShort && upstreamObjectname ? upstreamObjectname : null,
|
|
343
|
-
});
|
|
344
|
-
}
|
|
345
|
-
}
|
|
346
|
-
for (const branch of branches) {
|
|
347
|
-
const row = rows.get(branch);
|
|
348
|
-
const localSha = row?.local ?? null;
|
|
349
|
-
const remoteSha = row?.remote ?? null;
|
|
350
|
-
sync[branch] = {
|
|
351
|
-
local: localSha,
|
|
352
|
-
remote: remoteSha,
|
|
353
|
-
ahead: Boolean(localSha && remoteSha && localSha !== remoteSha),
|
|
354
|
-
};
|
|
355
|
-
}
|
|
356
|
-
return sync;
|
|
357
|
-
}
|
|
358
|
-
|
|
359
195
|
/**
|
|
360
196
|
* Handler map keyed by git probe field name (the part after `git.`). Each
|
|
361
|
-
* handler receives `{ cwd, git
|
|
362
|
-
* exposes the already-assembled projection so dependent probes (e.g.
|
|
363
|
-
* `epicBranchSync`, which needs `epicBranches`) can read upstream results.
|
|
197
|
+
* handler receives `{ cwd, git }` and returns the field's value.
|
|
364
198
|
*
|
|
365
199
|
* Story #3351: replaces the prior if/else ladder so each probe is
|
|
366
|
-
* independently testable
|
|
367
|
-
* dependency is explicit (it reads `out.epicBranches` and the SCOPE_KEYS
|
|
368
|
-
* ordering guarantees that field is assembled first).
|
|
200
|
+
* independently testable.
|
|
369
201
|
*
|
|
370
|
-
* @type {Record<string, (ctx: { cwd: string, git: (cwd: string, ...args: string[]) => { ok: boolean, stdout: string }
|
|
202
|
+
* @type {Record<string, (ctx: { cwd: string, git: (cwd: string, ...args: string[]) => { ok: boolean, stdout: string } }) => unknown>}
|
|
371
203
|
*/
|
|
372
204
|
const GIT_PROBES = Object.freeze({
|
|
373
205
|
headRef: ({ cwd, git }) => probeHeadRef({ cwd, git }),
|
|
374
|
-
epicBranches: ({ cwd, git }) => probeEpicBranches({ cwd, git }),
|
|
375
206
|
localBranches: ({ cwd, git }) => probeLocalBranches({ cwd, git }),
|
|
376
207
|
coreBare: ({ cwd, git }) => probeCoreBare({ cwd, git }),
|
|
377
|
-
epicBranchSync: ({ cwd, git, out }) =>
|
|
378
|
-
probeEpicBranchSync({ cwd, git, epicBranches: out.epicBranches ?? [] }),
|
|
379
208
|
});
|
|
380
209
|
|
|
381
210
|
/**
|
|
382
211
|
* Build the git projection for a key list by iterating the `GIT_PROBES`
|
|
383
|
-
* handler map.
|
|
384
|
-
* on a sibling field (e.g. `epicBranchSync` → `epicBranches`) relies on the
|
|
385
|
-
* SCOPE_KEYS ordering placing its dependency first.
|
|
212
|
+
* handler map.
|
|
386
213
|
*
|
|
387
214
|
* @param {readonly string[]} keys
|
|
388
215
|
* @param {string} cwd
|
|
@@ -396,7 +223,7 @@ function probeGit(keys, cwd, git) {
|
|
|
396
223
|
const field = key.slice(4);
|
|
397
224
|
const handler = GIT_PROBES[field];
|
|
398
225
|
if (!handler) continue;
|
|
399
|
-
out[field] = handler({ cwd, git
|
|
226
|
+
out[field] = handler({ cwd, git });
|
|
400
227
|
}
|
|
401
228
|
return out;
|
|
402
229
|
}
|
|
@@ -407,12 +234,9 @@ function probeGit(keys, cwd, git) {
|
|
|
407
234
|
* @param {readonly string[]} keys
|
|
408
235
|
* @param {string} cwd
|
|
409
236
|
* @param {(absPath: string) => boolean} fs
|
|
410
|
-
* @param {{ epicBranches?: string[], gitCommonDir?: string }} ctx
|
|
411
|
-
* @param {(absPath: string) => object} lockProbe
|
|
412
|
-
* @param {(pid: number|null) => boolean} pidLivenessProbe
|
|
413
237
|
* @returns {Record<string, unknown>}
|
|
414
238
|
*/
|
|
415
|
-
function probeFs(keys, cwd, fs
|
|
239
|
+
function probeFs(keys, cwd, fs) {
|
|
416
240
|
const out = {};
|
|
417
241
|
for (const key of keys) {
|
|
418
242
|
if (!key.startsWith('fs.')) continue;
|
|
@@ -423,38 +247,6 @@ function probeFs(keys, cwd, fs, ctx, lockProbe, pidLivenessProbe) {
|
|
|
423
247
|
out.dotEnv = fs(path.join(cwd, '.env'));
|
|
424
248
|
} else if (field === 'dotMcp') {
|
|
425
249
|
out.dotMcp = fs(path.join(cwd, '.mcp.json'));
|
|
426
|
-
} else if (field === 'epicMergeLocks') {
|
|
427
|
-
// For each epic branch, probe the matching lock file in the git
|
|
428
|
-
// common dir. The lock path mirrors epic-merge-lock.js's
|
|
429
|
-
// `lockPathFor()`: `<gitCommonDir>/epic-<id>.merge.lock`.
|
|
430
|
-
const commonDir = ctx.gitCommonDir ?? path.join(cwd, '.git');
|
|
431
|
-
const locks = {};
|
|
432
|
-
const branches = ctx.epicBranches ?? [];
|
|
433
|
-
for (const branch of branches) {
|
|
434
|
-
const id = branch.replace(/^epic\//, '');
|
|
435
|
-
const lockPath = path.join(commonDir, `epic-${id}.merge.lock`);
|
|
436
|
-
const meta = lockProbe(lockPath);
|
|
437
|
-
if (!meta.exists) {
|
|
438
|
-
locks[id] = {
|
|
439
|
-
exists: false,
|
|
440
|
-
path: lockPath,
|
|
441
|
-
pid: null,
|
|
442
|
-
holderAlive: false,
|
|
443
|
-
acquiredAt: null,
|
|
444
|
-
mtimeMs: null,
|
|
445
|
-
};
|
|
446
|
-
continue;
|
|
447
|
-
}
|
|
448
|
-
locks[id] = {
|
|
449
|
-
exists: true,
|
|
450
|
-
path: lockPath,
|
|
451
|
-
pid: meta.pid ?? null,
|
|
452
|
-
acquiredAt: meta.acquiredAt ?? null,
|
|
453
|
-
mtimeMs: meta.mtimeMs ?? null,
|
|
454
|
-
holderAlive: pidLivenessProbe(meta.pid ?? null),
|
|
455
|
-
};
|
|
456
|
-
}
|
|
457
|
-
out.epicMergeLocks = locks;
|
|
458
250
|
}
|
|
459
251
|
}
|
|
460
252
|
return out;
|
|
@@ -506,31 +298,8 @@ export function assembleState({ scope, cwd = process.cwd(), probes } = {}) {
|
|
|
506
298
|
const gitProbe = probes?.git ?? defaultGitProbe;
|
|
507
299
|
const fsProbe = probes?.fs ?? defaultFsProbe;
|
|
508
300
|
const envProbe = probes?.env ?? defaultEnvProbe;
|
|
509
|
-
const lockProbe = probes?.lock ?? defaultLockProbe;
|
|
510
|
-
const pidLivenessProbe = probes?.pidLiveness ?? defaultPidLivenessProbe;
|
|
511
301
|
const gitProjection = probeGit(keys, cwd, gitProbe);
|
|
512
|
-
|
|
513
|
-
// probe so test injection still works. In a linked worktree this points
|
|
514
|
-
// at the parent repo's .git/, matching epic-merge-lock.js's lookup.
|
|
515
|
-
let gitCommonDir;
|
|
516
|
-
if (keys.includes('fs.epicMergeLocks')) {
|
|
517
|
-
const r = gitProbe(cwd, 'rev-parse', '--git-common-dir');
|
|
518
|
-
if (r.ok && r.stdout) {
|
|
519
|
-
gitCommonDir = path.isAbsolute(r.stdout)
|
|
520
|
-
? r.stdout
|
|
521
|
-
: path.resolve(cwd, r.stdout);
|
|
522
|
-
} else {
|
|
523
|
-
gitCommonDir = path.join(cwd, '.git');
|
|
524
|
-
}
|
|
525
|
-
}
|
|
526
|
-
const fsProjection = probeFs(
|
|
527
|
-
keys,
|
|
528
|
-
cwd,
|
|
529
|
-
fsProbe,
|
|
530
|
-
{ epicBranches: gitProjection.epicBranches, gitCommonDir },
|
|
531
|
-
lockProbe,
|
|
532
|
-
pidLivenessProbe,
|
|
533
|
-
);
|
|
302
|
+
const fsProjection = probeFs(keys, cwd, fsProbe);
|
|
534
303
|
// Story #1289: `cwd` is surfaced so fs-scanning checks target the
|
|
535
304
|
// worktree they were assembled for.
|
|
536
305
|
const state = Object.freeze({
|
|
@@ -9,7 +9,7 @@
|
|
|
9
9
|
* Monitor wait kills `single-story-init.js` mid-run, leaving a
|
|
10
10
|
* half-initialized worktree.
|
|
11
11
|
*
|
|
12
|
-
* Scope: '
|
|
12
|
+
* Scope: 'story-close', 'retro'. The check runs at every
|
|
13
13
|
* preflight surface that has the opportunity to invoke Story init —
|
|
14
14
|
* primarily `/deliver`'s init step — and surfaces as a retro audit
|
|
15
15
|
* signal if the failure mode resurfaces during a sprint.
|
|
@@ -146,7 +146,7 @@ const FIX_COMMAND = [
|
|
|
146
146
|
export default {
|
|
147
147
|
id: 'story-init-not-backgrounded',
|
|
148
148
|
severity: 'blocker',
|
|
149
|
-
scope: ['
|
|
149
|
+
scope: ['story-close', 'retro'],
|
|
150
150
|
autoCorrect: 'refuse-and-print',
|
|
151
151
|
|
|
152
152
|
detect(state) {
|
|
@@ -178,7 +178,7 @@ export default {
|
|
|
178
178
|
return {
|
|
179
179
|
id: 'story-init-not-backgrounded',
|
|
180
180
|
severity: 'blocker',
|
|
181
|
-
scope: state?.scope ?? '
|
|
181
|
+
scope: state?.scope ?? 'story-close',
|
|
182
182
|
summary: `${offences.length} orchestration call site(s) invoke single-story-init.js with Monitor backgrounding`,
|
|
183
183
|
detail,
|
|
184
184
|
fixCommand: FIX_COMMAND,
|
|
@@ -22,8 +22,7 @@
|
|
|
22
22
|
* catches an over-deep fan-out. The self-healing surface is preserved — it is
|
|
23
23
|
* re-scoped, not removed.
|
|
24
24
|
*
|
|
25
|
-
* Scope: '
|
|
26
|
-
* `epic-deliver` (the fan-out site) and as audit signal at retro.
|
|
25
|
+
* Scope: 'retro'. Surfaces as audit signal at retro.
|
|
27
26
|
*
|
|
28
27
|
* The check is `refuse-and-print` — auto-rewriting a workflow's declared
|
|
29
28
|
* depth or tool list would silently change runtime behavior in ways the
|
|
@@ -208,7 +207,7 @@ const FIX_COMMAND = [
|
|
|
208
207
|
export default {
|
|
209
208
|
id: 'subagent-agent-tool-required',
|
|
210
209
|
severity: 'blocker',
|
|
211
|
-
scope: ['
|
|
210
|
+
scope: ['retro'],
|
|
212
211
|
autoCorrect: 'refuse-and-print',
|
|
213
212
|
|
|
214
213
|
detect(state) {
|
|
@@ -249,7 +248,7 @@ export default {
|
|
|
249
248
|
return {
|
|
250
249
|
id: 'subagent-agent-tool-required',
|
|
251
250
|
severity: 'blocker',
|
|
252
|
-
scope: state?.scope ?? '
|
|
251
|
+
scope: state?.scope ?? 'retro',
|
|
253
252
|
summary: `${offences.length} sub-agent workflow(s) declare an Agent fan-out deeper than the supported nesting ceiling (${ceiling})`,
|
|
254
253
|
detail,
|
|
255
254
|
fixCommand: FIX_COMMAND,
|
|
@@ -8,7 +8,7 @@
|
|
|
8
8
|
* tests that read environment variables silently take a different code
|
|
9
9
|
* path.
|
|
10
10
|
*
|
|
11
|
-
* Surface:
|
|
11
|
+
* Surface: the `/diagnose` CLI. Surfaced as a
|
|
12
12
|
* warning rather than a blocker — the missing file may be a deliberate
|
|
13
13
|
* choice (e.g. a worktree that doesn't need MCP), but the operator should
|
|
14
14
|
* see the divergence from the main checkout.
|
|
@@ -28,7 +28,7 @@ const ID = 'worktree-bootstrap-env';
|
|
|
28
28
|
export default {
|
|
29
29
|
id: ID,
|
|
30
30
|
severity: 'warning',
|
|
31
|
-
scope: ['
|
|
31
|
+
scope: ['diagnose'],
|
|
32
32
|
autoCorrect: 'refuse-and-print',
|
|
33
33
|
detect(state) {
|
|
34
34
|
const status = state?.fs?.worktreeBootstrapStatus ?? {};
|