mandrel 2.0.0 → 2.2.0

package/.agents/scripts/lib/orchestration/review-providers/native.js

@@ -50,11 +50,6 @@ import {
 } from '../../maintainability-engine.js';
 import { PROJECT_ROOT } from '../../project-root.js';
 import { transpileIfNeeded } from '../../transpile.js';
-import {
-  hashCommandConfig,
-  recordPass,
-  shouldSkip,
-} from '../../validation-evidence.js';
 
 /** Worker entry that scores one file into a full maintainability report. */
 const MAINTAINABILITY_REPORT_WORKER_URL = new URL(
@@ -141,13 +136,6 @@ export function partitionFilesForLint(changedFiles) {
   return { code, md };
 }
 
-function resolveCurrentSha(cwd, gitSpawnFn = gitSpawn) {
-  const res = gitSpawnFn(cwd, 'rev-parse', 'HEAD');
-  if (res.status !== 0) return null;
-  const sha = (res.stdout || '').trim();
-  return sha.length > 0 ? sha : null;
-}
-
 /**
  * Read a changed file's content as it exists at `headRef` via
  * `git show <headRef>:<relPath>`, rather than reading the on-disk copy at
@@ -260,28 +248,6 @@ export function runScopedLint(changedFiles, cwd, runnerFn = spawnLintRunner) {
   return { ...summary, skipped: false, mode: 'changed-only' };
 }
 
-/**
- * Compute the canonical command-config hash for the scoped-lint runner. The
- * caller passes the partitioned biome + markdown lists so the hash captures
- * the exact set of files; any change to that set invalidates the prior
- * evidence and forces a re-lint.
- *
- * Exported for testing.
- */
-export function buildLintEvidenceConfig(changedFiles, cwd) {
-  const { code, md } = partitionFilesForLint(changedFiles);
-  const args = [];
-  if (code.length > 0) args.push('biome', 'lint', ...code);
-  if (md.length > 0) {
-    args.push('markdownlint', ...md, '--ignore', 'node_modules');
-  }
-  return hashCommandConfig({
-    cmd: 'epic-code-review/scoped-lint',
-    args,
-    cwd,
-  });
-}
-
 /**
  * Pure: classify a single file's maintainability report into a row + optional
  * Finding-shaped entries. `reportFn` is the thunk that produces the file's
@@ -548,87 +514,9 @@ function _emptyResults() {
   };
 }
 
-function tryEvidenceSkip({
-  storyId,
-  epicId,
-  useEvidence,
-  headSha,
-  evidenceCfg,
-  shouldSkipFn,
-  logger,
-}) {
-  if (!(useEvidence && storyId && epicId && headSha)) return null;
-  const verdict = shouldSkipFn(
-    {
-      storyId,
-      gateName: 'epic-code-review/lint',
-      currentSha: headSha,
-      configHash: evidenceCfg,
-    },
-    { cwd: PROJECT_ROOT, epicId },
-  );
-  if (!verdict.skip) return null;
-  logger?.info?.(
-    `[native-review] Scoped lint skipped (evidence match: SHA=${headSha.slice(
-      0,
-      7,
-    )}, recorded ${verdict.record?.timestamp ?? 'n/a'}).`,
-  );
-  return {
-    errors: 0,
-    warnings: 0,
-    parsed: false,
-    skipped: true,
-    mode: 'changed-only',
-    evidenceSkipped: true,
-  };
-}
-
-function maybeRecordLintEvidence({
-  storyId,
-  epicId,
-  useEvidence,
-  headSha,
-  evidenceCfg,
-  lintSummary,
-  recordPassFn,
-  logger,
-}) {
-  const eligible =
-    useEvidence &&
-    storyId &&
-    epicId &&
-    headSha &&
-    lintSummary.errors === 0 &&
-    !lintSummary.skipped;
-  if (!eligible) return;
-  try {
-    recordPassFn(
-      {
-        storyId,
-        gateName: 'epic-code-review/lint',
-        sha: headSha,
-        configHash: evidenceCfg,
-        exitCode: 0,
-      },
-      { cwd: PROJECT_ROOT, epicId },
-    );
-  } catch (err) {
-    logger?.warn?.(
-      `[native-review] Failed to record lint evidence: ${err?.message ?? err}`,
-    );
-  }
-}
-
 async function runLintPhase({
   scopeLint,
   changedFiles,
-  storyId,
-  epicId,
-  useEvidence,
-  gitSpawnFn,
-  shouldSkipFn,
-  recordPassFn,
   runScopedLintFn,
   logger,
 }) {
@@ -644,34 +532,10 @@ async function runLintPhase({
       mode: 'off',
     };
   }
-  const evidenceCfg = buildLintEvidenceConfig(changedFiles, PROJECT_ROOT);
-  const headSha = resolveCurrentSha(PROJECT_ROOT, gitSpawnFn);
-  const skipSummary = tryEvidenceSkip({
-    storyId,
-    epicId,
-    useEvidence,
-    headSha,
-    evidenceCfg,
-    shouldSkipFn,
-    logger,
-  });
-  if (skipSummary) return skipSummary;
-
   logger?.info?.(
     '[native-review] Linting changed files only (biome + markdownlint, scoped to diff)...',
   );
-  const lintSummary = runScopedLintFn(changedFiles, PROJECT_ROOT);
-  maybeRecordLintEvidence({
-    storyId,
-    epicId,
-    useEvidence,
-    headSha,
-    evidenceCfg,
-    lintSummary,
-    recordPassFn,
-    logger,
-  });
-  return lintSummary;
+  return runScopedLintFn(changedFiles, PROJECT_ROOT);
 }
 
 /**
@@ -686,12 +550,8 @@ async function runLintPhase({
  *   runScopedLintFn?: typeof runScopedLint,
  *   analyzeChangedFilesFn?: typeof analyzeChangedFiles,
  *   buildLintFindingsFn?: typeof buildLintFindings,
- *   shouldSkipFn?: typeof shouldSkip,
- *   recordPassFn?: typeof recordPass,
  *   logger?: { info?: Function, warn?: Function, error?: Function },
  *   scopeLint?: 'changed-only'|'off',
- *   storyId?: number|null,
- *   useEvidence?: boolean,
  * }} [deps]
  * @returns {ReviewProvider}
  */
@@ -701,12 +561,8 @@ export function createNativeProvider(deps = {}) {
     runScopedLintFn = runScopedLint,
     analyzeChangedFilesFn = analyzeChangedFiles,
     buildLintFindingsFn = buildLintFindings,
-    shouldSkipFn = shouldSkip,
-    recordPassFn = recordPass,
     logger,
     scopeLint = 'changed-only',
-    storyId = null,
-    useEvidence = true,
   } = deps;
 
   return {
@@ -761,18 +617,9 @@ export function createNativeProvider(deps = {}) {
         gitSpawnFn,
       });
 
-      // Epic-scope reviews flow through validation-evidence; story-scope
-      // reviews currently share the same gate name, keyed on the storyId.
-      const epicId = scope === 'epic' ? ticketId : null;
       const lintSummary = await runLintPhase({
         scopeLint,
         changedFiles,
-        storyId: storyId ?? (scope === 'story' ? ticketId : null),
-        epicId,
-        useEvidence,
-        gitSpawnFn,
-        shouldSkipFn,
-        recordPassFn,
         runScopedLintFn,
         logger,
       });

package/.agents/scripts/lib/orchestration/review-providers/review-depth.js

@@ -3,8 +3,9 @@
  * LLM-backed review providers.
  *
  * Story #3937 / #3938 — the depth lever (`light` / `standard` / `deep`,
- * resolved from judged risk AND diff width by `resolveDepth` in
- * `lib/orchestration/review-depth.js`) is threaded into every
+ * derived from the diff's observable width and sensitive-path hits by
+ * `lib/orchestration/review-depth.js`; #4542 retired the judged-risk
+ * input) is threaded into every
  * provider's `runReview` input. LLM-backed providers (codex, security-review,
  * ultrareview) must render that lever into the prompt/instructions they emit so
  * the model actually changes its thoroughness; the native (mechanical) provider

package/.agents/scripts/lib/orchestration/review-providers/security-review.js

@@ -185,7 +185,7 @@ export const SECURITY_REVIEW_INVOKE_PROMPT =
  * @returns {string}
  */
 export function buildSecurityReviewPrompt(input) {
-  const scopeLabel = input?.scope === 'epic' ? 'Epic' : 'Story';
+  const scopeLabel = 'Story';
   const baseRef = typeof input?.baseRef === 'string' ? input.baseRef : '?';
   const headRef = typeof input?.headRef === 'string' ? input.headRef : '?';
   const ticketId =

package/.agents/scripts/lib/orchestration/review-providers/types.js

@@ -26,7 +26,7 @@
  * @property {number=}  line         - 1-based line number, when attributable.
  * @property {string=}  category     - Free-form tag (e.g. 'security', 'docs', 'lint').
  *
- * @typedef {'story'|'epic'} ReviewScope
+ * @typedef {'story'} ReviewScope
  *
  * @typedef {'light'|'standard'|'deep'} ReviewDepth
  *
@@ -39,9 +39,10 @@
  *   lever (Story #3876/#3937/#3938). `light` → single-pass review focused on
  *   Pillar 1 (spec adherence) with Pillars 2–3 reduced to a quick scan;
  *   `standard` → all pillars at baseline depth; `deep` → all pillars plus a
- *   second adversarial pass over the diff. Resolved from the judged risk
- *   envelope AND the changed-file count of the diff by `resolveDepth`
- *   (`lib/orchestration/review-depth.js`) and threaded into `runReview`.
+ *   second adversarial pass over the diff. Derived from the diff's
+ *   changed-file count and sensitive-path hits
+ *   (`lib/orchestration/review-depth.js`; the judged-risk input was
+ *   retired in #4542) and threaded into `runReview`.
  *   LLM-backed
  *   providers MUST render this into the prompt/instructions they emit; the
  *   native provider documents why its mechanical sweep ignores it. Absent →

package/.agents/scripts/lib/orchestration/review-providers/ultrareview.js

@@ -55,7 +55,7 @@ export const ULTRAREVIEW_PROMPT_TEMPLATE =
  * @returns {string}
  */
 export function buildUltrareviewMessage(input) {
-  const scopeLabel = input?.scope === 'epic' ? 'Epic' : 'Story';
+  const scopeLabel = 'Story';
   const baseRef = typeof input?.baseRef === 'string' ? input.baseRef : '?';
   const headRef = typeof input?.headRef === 'string' ? input.headRef : '?';
   return ULTRAREVIEW_PROMPT_TEMPLATE.replace('{scopeLabel}', scopeLabel)