mandrel 1.94.0 → 2.1.0

package/.agents/scripts/lib/orchestration/review-providers/native.js

@@ -50,11 +50,6 @@ import {
 } from '../../maintainability-engine.js';
 import { PROJECT_ROOT } from '../../project-root.js';
 import { transpileIfNeeded } from '../../transpile.js';
-import {
-  hashCommandConfig,
-  recordPass,
-  shouldSkip,
-} from '../../validation-evidence.js';
 
 /** Worker entry that scores one file into a full maintainability report. */
 const MAINTAINABILITY_REPORT_WORKER_URL = new URL(
@@ -141,13 +136,6 @@ export function partitionFilesForLint(changedFiles) {
   return { code, md };
 }
 
-function resolveCurrentSha(cwd, gitSpawnFn = gitSpawn) {
-  const res = gitSpawnFn(cwd, 'rev-parse', 'HEAD');
-  if (res.status !== 0) return null;
-  const sha = (res.stdout || '').trim();
-  return sha.length > 0 ? sha : null;
-}
-
 /**
  * Read a changed file's content as it exists at `headRef` via
  * `git show <headRef>:<relPath>`, rather than reading the on-disk copy at
@@ -260,28 +248,6 @@ export function runScopedLint(changedFiles, cwd, runnerFn = spawnLintRunner) {
   return { ...summary, skipped: false, mode: 'changed-only' };
 }
 
-/**
- * Compute the canonical command-config hash for the scoped-lint runner. The
- * caller passes the partitioned biome + markdown lists so the hash captures
- * the exact set of files; any change to that set invalidates the prior
- * evidence and forces a re-lint.
- *
- * Exported for testing.
- */
-export function buildLintEvidenceConfig(changedFiles, cwd) {
-  const { code, md } = partitionFilesForLint(changedFiles);
-  const args = [];
-  if (code.length > 0) args.push('biome', 'lint', ...code);
-  if (md.length > 0) {
-    args.push('markdownlint', ...md, '--ignore', 'node_modules');
-  }
-  return hashCommandConfig({
-    cmd: 'epic-code-review/scoped-lint',
-    args,
-    cwd,
-  });
-}
-
 /**
  * Pure: classify a single file's maintainability report into a row + optional
  * Finding-shaped entries. `reportFn` is the thunk that produces the file's
@@ -548,87 +514,9 @@ function _emptyResults() {
   };
 }
 
-function tryEvidenceSkip({
-  storyId,
-  epicId,
-  useEvidence,
-  headSha,
-  evidenceCfg,
-  shouldSkipFn,
-  logger,
-}) {
-  if (!(useEvidence && storyId && epicId && headSha)) return null;
-  const verdict = shouldSkipFn(
-    {
-      storyId,
-      gateName: 'epic-code-review/lint',
-      currentSha: headSha,
-      configHash: evidenceCfg,
-    },
-    { cwd: PROJECT_ROOT, epicId },
-  );
-  if (!verdict.skip) return null;
-  logger?.info?.(
-    `[native-review] Scoped lint skipped (evidence match: SHA=${headSha.slice(
-      0,
-      7,
-    )}, recorded ${verdict.record?.timestamp ?? 'n/a'}).`,
-  );
-  return {
-    errors: 0,
-    warnings: 0,
-    parsed: false,
-    skipped: true,
-    mode: 'changed-only',
-    evidenceSkipped: true,
-  };
-}
-
-function maybeRecordLintEvidence({
-  storyId,
-  epicId,
-  useEvidence,
-  headSha,
-  evidenceCfg,
-  lintSummary,
-  recordPassFn,
-  logger,
-}) {
-  const eligible =
-    useEvidence &&
-    storyId &&
-    epicId &&
-    headSha &&
-    lintSummary.errors === 0 &&
-    !lintSummary.skipped;
-  if (!eligible) return;
-  try {
-    recordPassFn(
-      {
-        storyId,
-        gateName: 'epic-code-review/lint',
-        sha: headSha,
-        configHash: evidenceCfg,
-        exitCode: 0,
-      },
-      { cwd: PROJECT_ROOT, epicId },
-    );
-  } catch (err) {
-    logger?.warn?.(
-      `[native-review] Failed to record lint evidence: ${err?.message ?? err}`,
-    );
-  }
-}
-
 async function runLintPhase({
   scopeLint,
   changedFiles,
-  storyId,
-  epicId,
-  useEvidence,
-  gitSpawnFn,
-  shouldSkipFn,
-  recordPassFn,
   runScopedLintFn,
   logger,
 }) {
@@ -644,34 +532,10 @@ async function runLintPhase({
       mode: 'off',
     };
   }
-  const evidenceCfg = buildLintEvidenceConfig(changedFiles, PROJECT_ROOT);
-  const headSha = resolveCurrentSha(PROJECT_ROOT, gitSpawnFn);
-  const skipSummary = tryEvidenceSkip({
-    storyId,
-    epicId,
-    useEvidence,
-    headSha,
-    evidenceCfg,
-    shouldSkipFn,
-    logger,
-  });
-  if (skipSummary) return skipSummary;
-
   logger?.info?.(
     '[native-review] Linting changed files only (biome + markdownlint, scoped to diff)...',
   );
-  const lintSummary = runScopedLintFn(changedFiles, PROJECT_ROOT);
-  maybeRecordLintEvidence({
-    storyId,
-    epicId,
-    useEvidence,
-    headSha,
-    evidenceCfg,
-    lintSummary,
-    recordPassFn,
-    logger,
-  });
-  return lintSummary;
+  return runScopedLintFn(changedFiles, PROJECT_ROOT);
 }
 
 /**
@@ -686,12 +550,8 @@ async function runLintPhase({
  *   runScopedLintFn?: typeof runScopedLint,
  *   analyzeChangedFilesFn?: typeof analyzeChangedFiles,
  *   buildLintFindingsFn?: typeof buildLintFindings,
- *   shouldSkipFn?: typeof shouldSkip,
- *   recordPassFn?: typeof recordPass,
  *   logger?: { info?: Function, warn?: Function, error?: Function },
  *   scopeLint?: 'changed-only'|'off',
- *   storyId?: number|null,
- *   useEvidence?: boolean,
  * }} [deps]
  * @returns {ReviewProvider}
  */
@@ -701,12 +561,8 @@ export function createNativeProvider(deps = {}) {
     runScopedLintFn = runScopedLint,
     analyzeChangedFilesFn = analyzeChangedFiles,
     buildLintFindingsFn = buildLintFindings,
-    shouldSkipFn = shouldSkip,
-    recordPassFn = recordPass,
     logger,
     scopeLint = 'changed-only',
-    storyId = null,
-    useEvidence = true,
   } = deps;
 
   return {
@@ -761,18 +617,9 @@ export function createNativeProvider(deps = {}) {
         gitSpawnFn,
       });
 
-      // Epic-scope reviews flow through validation-evidence; story-scope
-      // reviews currently share the same gate name, keyed on the storyId.
-      const epicId = scope === 'epic' ? ticketId : null;
       const lintSummary = await runLintPhase({
         scopeLint,
         changedFiles,
-        storyId: storyId ?? (scope === 'story' ? ticketId : null),
-        epicId,
-        useEvidence,
-        gitSpawnFn,
-        shouldSkipFn,
-        recordPassFn,
         runScopedLintFn,
         logger,
       });

package/.agents/scripts/lib/orchestration/review-providers/review-depth.js

@@ -3,8 +3,9 @@
  * LLM-backed review providers.
  *
  * Story #3937 / #3938 — the depth lever (`light` / `standard` / `deep`,
- * resolved from judged risk AND diff width by `resolveDepth` in
- * `lib/orchestration/review-depth.js`) is threaded into every
+ * derived from the diff's observable width and sensitive-path hits by
+ * `lib/orchestration/review-depth.js`; #4542 retired the judged-risk
+ * input) is threaded into every
  * provider's `runReview` input. LLM-backed providers (codex, security-review,
  * ultrareview) must render that lever into the prompt/instructions they emit so
  * the model actually changes its thoroughness; the native (mechanical) provider

package/.agents/scripts/lib/orchestration/review-providers/review-provider-factory.js

@@ -1,34 +1,27 @@
 /**
  * review-providers/review-provider-factory.js — resolve
- * `codeReview.provider` / `codeReview.providers` to a concrete
- * `ReviewProvider` instance.
+ * `codeReview.providers` to a concrete `ReviewProvider` instance.
  *
  * Story #2825 (Epic #2815) — the factory is the only entry point.
  * `runCodeReview()` never references a specific adapter directly;
  * adding a backend is (1) implement the interface, (2) register here,
  * (3) extend the schema enum.
  *
- * Story #2871 — extends the factory for multi-provider chains:
- *   - Legacy single-string `codeReview.provider`: factory returns the
- *     single `ReviewProvider` adapter as before (back-compat for the
- *     shape and for every existing test).
- *   - New `codeReview.providers: ProviderEntry[]`: factory returns a
- *     `ChainProvider` that fans out `runReview` across every inline
- *     entry (merging `Finding[]` in declaration order) and exposes
- *     `getPromptMessages` so the orchestrator can render the
- *     trailing "Manual review suggestions" section without knowing
- *     about per-provider mechanics.
+ * Story #2871 — the factory always returns a `ChainProvider` that
+ * fans out `runReview` across every inline entry (merging `Finding[]`
+ * in declaration order) and exposes `getPromptMessages` so the
+ * orchestrator can render the trailing "Manual review suggestions"
+ * section without knowing about per-provider mechanics.
  *
  * Behaviour:
- *   - Unset / missing `codeReview.provider` defaults to `'native'`.
+ *   - Unset / empty `codeReview.providers` defaults to a single-entry
+ *     chain `[{ name: 'native' }]`.
  *   - Unknown provider name throws an Error with remediation text
  *     naming the supported values.
  *   - Adapters that throw at construction time (e.g. `codex` probing
  *     for an absent plugin command) bubble their error verbatim —
  *     EXCEPT when the chain entry carries `optional: true`, in which
  *     case the chain logs a warning and skips that entry.
- *   - When both `provider` (legacy single) and `providers` (chain) are
- *     present, `providers` wins; `provider` is ignored with a warning.
  *
  * @typedef {import('./types.js').ReviewProvider}        ReviewProvider
  * @typedef {import('./types.js').ManualPromptProvider}  ManualPromptProvider
@@ -70,8 +63,8 @@ const PROMPT_PROVIDERS = Object.freeze({
 });
 
 /**
- * The provider name used when `codeReview.provider` is unset or the
- * `codeReview` block is absent entirely.
+ * The inline provider name used when `codeReview.providers` is unset,
+ * empty, or the `codeReview` block is absent entirely.
  */
 export const DEFAULT_PROVIDER_NAME = 'native';
 
@@ -127,13 +120,10 @@ export function isScopeApplicable(declaredScopes, currentScope) {
  * config block. Pass the `codeReview` sub-object (not the full
  * config) so callers can compose with their own config readers.
  *
- * Story #2871 — when `codeReviewConfig.providers` is a non-empty
- * array, returns a `ChainProvider` (fans out across entries);
- * otherwise returns the single legacy adapter selected by
- * `codeReviewConfig.provider`.
+ * Always returns a `ChainProvider`. When `codeReviewConfig.providers`
+ * is unset or empty, the chain defaults to `[{ name: 'native' }]`.
  *
  * @param {{
- *   provider?: string,
  *   providers?: Array<object>,
  *   providerConfig?: object,
  * }|null|undefined} codeReviewConfig
@@ -152,44 +142,19 @@ export function createReviewProvider(codeReviewConfig, opts = {}) {
   const promptRegistry = opts.promptRegistry ?? PROMPT_PROVIDERS;
   const logger = opts.logger;
 
-  // Chain shape wins when present.
-  if (
+  const entries =
     codeReviewConfig &&
     Array.isArray(codeReviewConfig.providers) &&
     codeReviewConfig.providers.length > 0
-  ) {
-    if (typeof codeReviewConfig.provider === 'string') {
-      logger?.warn?.(
-        '[ReviewProviderFactory] Both `provider` and `providers` are set; ' +
-          '`providers` wins. Remove the legacy `provider` field to silence ' +
-          'this warning.',
-      );
-    }
-    const chain = buildProviderChain(codeReviewConfig.providers, {
-      inlineRegistry,
-      promptRegistry,
-      logger,
-    });
-    return createChainProvider(chain, { logger });
-  }
+      ? codeReviewConfig.providers
+      : [{ name: DEFAULT_PROVIDER_NAME }];
 
-  // Legacy single-string shape.
-  const name =
-    codeReviewConfig && typeof codeReviewConfig.provider === 'string'
-      ? codeReviewConfig.provider
-      : DEFAULT_PROVIDER_NAME;
-
-  const ctor = inlineRegistry[name];
-  if (!ctor) {
-    const supported = Object.keys(inlineRegistry).sort().join(', ');
-    throw new Error(
-      `[ReviewProviderFactory] Unknown codeReview.provider "${name}". ` +
-        `Supported values: ${supported}. ` +
-        'Set codeReview.provider in .agentrc.json to one of the supported ' +
-        'values, or remove the field to use the default ("native").',
-    );
-  }
-  return ctor();
+  const chain = buildProviderChain(entries, {
+    inlineRegistry,
+    promptRegistry,
+    logger,
+  });
+  return createChainProvider(chain, { logger });
 }
 
 /**

package/.agents/scripts/lib/orchestration/review-providers/security-review.js

@@ -185,7 +185,7 @@ export const SECURITY_REVIEW_INVOKE_PROMPT =
  * @returns {string}
  */
 export function buildSecurityReviewPrompt(input) {
-  const scopeLabel = input?.scope === 'epic' ? 'Epic' : 'Story';
+  const scopeLabel = 'Story';
   const baseRef = typeof input?.baseRef === 'string' ? input.baseRef : '?';
   const headRef = typeof input?.headRef === 'string' ? input.headRef : '?';
   const ticketId =

package/.agents/scripts/lib/orchestration/review-providers/types.js

@@ -26,7 +26,7 @@
  * @property {number=}  line         - 1-based line number, when attributable.
  * @property {string=}  category     - Free-form tag (e.g. 'security', 'docs', 'lint').
  *
- * @typedef {'story'|'epic'} ReviewScope
+ * @typedef {'story'} ReviewScope
  *
  * @typedef {'light'|'standard'|'deep'} ReviewDepth
  *
@@ -39,9 +39,10 @@
  *   lever (Story #3876/#3937/#3938). `light` → single-pass review focused on
  *   Pillar 1 (spec adherence) with Pillars 2–3 reduced to a quick scan;
  *   `standard` → all pillars at baseline depth; `deep` → all pillars plus a
- *   second adversarial pass over the diff. Resolved from the judged risk
- *   envelope AND the changed-file count of the diff by `resolveDepth`
- *   (`lib/orchestration/review-depth.js`) and threaded into `runReview`.
+ *   second adversarial pass over the diff. Derived from the diff's
+ *   changed-file count and sensitive-path hits
+ *   (`lib/orchestration/review-depth.js`; the judged-risk input was
+ *   retired in #4542) and threaded into `runReview`.
  *   LLM-backed
  *   providers MUST render this into the prompt/instructions they emit; the
  *   native provider documents why its mechanical sweep ignores it. Absent →

package/.agents/scripts/lib/orchestration/review-providers/ultrareview.js

@@ -55,7 +55,7 @@ export const ULTRAREVIEW_PROMPT_TEMPLATE =
  * @returns {string}
  */
 export function buildUltrareviewMessage(input) {
-  const scopeLabel = input?.scope === 'epic' ? 'Epic' : 'Story';
+  const scopeLabel = 'Story';
   const baseRef = typeof input?.baseRef === 'string' ? input.baseRef : '?';
   const headRef = typeof input?.headRef === 'string' ? input.headRef : '?';
   return ULTRAREVIEW_PROMPT_TEMPLATE.replace('{scopeLabel}', scopeLabel)