mandrel 1.94.0 → 2.1.0

package/.agents/scripts/lib/config/paths.js

@@ -32,7 +32,6 @@ export const PATHS_DEFAULTS = Object.freeze({
  *   auditOutputDir: string,
  *   scriptsRoot: string,
  *   workflowsRoot: string,
- *   personasRoot: string,
  *   schemasRoot: string,
  *   skillsRoot: string,
  *   templatesRoot: string,
@@ -53,7 +52,6 @@ export function resolvePaths(userPaths) {
     auditOutputDir: `${tempRoot}/audits`,
     scriptsRoot: `${agentRoot}/scripts`,
     workflowsRoot: `${agentRoot}/workflows`,
-    personasRoot: `${agentRoot}/personas`,
     schemasRoot: `${agentRoot}/schemas`,
     skillsRoot: `${agentRoot}/skills`,
     templatesRoot: `${agentRoot}/templates`,

package/.agents/scripts/lib/config/quality.js

@@ -57,7 +57,7 @@ const DEFAULT_COVERAGE_FLOORS = Object.freeze({
   '*': Object.freeze({ lines: 90, branches: 85, functions: 90 }),
 });
 const DEFAULT_CRAP_FLOORS = Object.freeze({
-  '*': Object.freeze({ crap: 20 }),
+  '*': Object.freeze({ max: 30, p95: 20, methodsAbove20: 50 }),
 });
 /**
  * Story #2193 — maintainability rollups expose the `min` / `p50` / `p95`
@@ -366,14 +366,19 @@ function resolveCoverageGate(userBlock) {
 }
 
 /**
- * Framework defaults for `delivery.quality.codingGuardrails`. The legacy
- * field name `miDropRefactor` was renamed to `miDropMustRefactor` in
- * Story 1 to avoid semantic collision with `autoRefresh.miDropCap`.
+ * Framework defaults for `delivery.quality.codingGuardrails`.
+ *
+ * `miDropMustRefactor` was retired in Story #4531: schema-validated,
+ * defaulted, and resolved, but never consumed — the gate it named
+ * (`quality-preview.js`'s `computeExitCode`) short-circuits on `miExit`
+ * (derived from the already-consumed `gates.maintainability.tolerance`)
+ * before this value is ever read. `maintainability.tolerance` is the one
+ * documented MI-drop control now; see `lib/migrations/index.js` for the
+ * consumer-config migration that strips a leftover key on upgrade.
  */
 export const CODING_GUARDRAILS_DEFAULTS = Object.freeze({
   cyclomaticFlag: 8,
   cyclomaticMustFix: 12,
-  miDropMustRefactor: 1.5,
   requireSiblingTest: false,
 });
 
@@ -393,8 +398,6 @@ export function resolveCodingGuardrails(userBlock) {
     cyclomaticFlag: userBlock.cyclomaticFlag ?? defaults.cyclomaticFlag,
     cyclomaticMustFix:
       userBlock.cyclomaticMustFix ?? defaults.cyclomaticMustFix,
-    miDropMustRefactor:
-      userBlock.miDropMustRefactor ?? defaults.miDropMustRefactor,
     requireSiblingTest:
       typeof userBlock.requireSiblingTest === 'boolean'
         ? userBlock.requireSiblingTest
@@ -402,9 +405,10 @@ export function resolveCodingGuardrails(userBlock) {
   };
 }
 
+// autoRefresh.miDropCap was retired alongside codingGuardrails.
+// miDropMustRefactor in Story #4531 — same unconsumed-knob shape, same fix.
 const AUTO_REFRESH_DEFAULTS = Object.freeze({
   enabled: true,
-  miDropCap: 1.5,
   crapJumpCap: 5,
   scope: 'diff',
 });
@@ -416,7 +420,6 @@ function resolveAutoRefresh(userBlock) {
   if (userBlock == null || typeof userBlock !== 'object') {
     return {
       enabled: defaults.enabled,
-      miDropCap: defaults.miDropCap,
       crapJumpCap: defaults.crapJumpCap,
       scope: defaults.scope,
     };
@@ -429,12 +432,6 @@ function resolveAutoRefresh(userBlock) {
       typeof userBlock.enabled === 'boolean'
         ? userBlock.enabled
         : defaults.enabled,
-    miDropCap:
-      typeof userBlock.miDropCap === 'number' &&
-      Number.isFinite(userBlock.miDropCap) &&
-      userBlock.miDropCap >= 0
-        ? userBlock.miDropCap
-        : defaults.miDropCap,
     crapJumpCap:
       typeof userBlock.crapJumpCap === 'number' &&
       Number.isFinite(userBlock.crapJumpCap) &&

package/.agents/scripts/lib/config/runners.js

@@ -1,18 +1,13 @@
 /**
  * Runner accessor (Epic #1720 Story #1739 — top-level reshape).
  *
- * Post-reshape, only `delivery.deliverRunner`, `delivery.epicAudit`, and
- * `delivery.codeReview` are configurable; everything else lives in
- * framework-internal constants exported alongside (`DEFAULT_STORY_MERGE_RETRY`,
- * `DEFAULT_DECOMPOSER`).
+ * Post-reshape, only `delivery.deliverRunner` and `delivery.codeReview` are
+ * configurable via this accessor; everything else lives in framework-internal
+ * constants exported alongside (`DEFAULT_DECOMPOSER`).
+ * `delivery.epicAudit` was removed on v2 (Story-only delivery — no
+ * epic-audit runner; remediation policy lives on `delivery.codeReview`).
  */
 
-/** Hardcoded story-merge retry policy (was `orchestration.runners.storyMergeRetry`). */
-export const DEFAULT_STORY_MERGE_RETRY = Object.freeze({
-  maxAttempts: 3,
-  backoffMs: Object.freeze([250, 500, 1000]),
-});
-
 /** Hardcoded decomposer concurrency cap (was `orchestration.runners.decomposer.concurrencyCap`). */
 export const DEFAULT_DECOMPOSER = Object.freeze({
   concurrencyCap: 3,
@@ -23,51 +18,28 @@ export const DEFAULT_DECOMPOSER = Object.freeze({
  * `delivery.deliverRunner.*` in `.agentrc.json`.
  *
  * **Throughput tradeoff — `concurrencyCap`.**
- * The default of 3 is intentionally conservative: it keeps host-quota
- * consumption low for Epics with small waves and avoids saturating the
- * GitHub API with concurrent label writes. For wide-wave Epics where the
- * host has adequate parallel-agent quota, operators should raise
- * `delivery.deliverRunner.concurrencyCap` — wall-clock time falls
- * proportionally to the extra concurrency. The safe default is a tuning
- * knob, not a performance ceiling. See `helpers/deliver-epic.md` § Phase 2b and
- * `agentrc-reference.json` `delivery.deliverRunner.concurrencyCap` for details.
+ * The default of 3 is intentionally moderate: it keeps host-quota
+ * consumption predictable for multi-Story plan-runs and avoids saturating
+ * the GitHub API with concurrent label writes, while still allowing a
+ * small ready-set fan-out. Operators who want strictly sequential delivery
+ * should set `delivery.deliverRunner.concurrencyCap: 1`. Raising the cap
+ * reduces wall-clock time where dependencies allow. See `deliver.md` and
+ * `agentrc-reference.json` `delivery.deliverRunner.concurrencyCap`.
  *
- * **`verifyConcurrencyCap`** (Epic #3019 Tech Spec §1.4 / Story #3024) is a
- * separate knob that bounds the `verifyWaveResults` loop independently of
- * Story-dispatch concurrency, so operators can tune ticket-verify parallelism
- * without raising the wave fan-out. Default 4.
+ * Story #4545 removed the sibling `verifyConcurrencyCap`: the
+ * `verifyWaveResults` loop it claimed to bound never existed in the tree, and
+ * its only reader was the retired execution-analysis CLI, which echoed the
+ * number into a report rather than bounding anything.
  */
 const DEFAULT_DELIVER_RUNNER = Object.freeze({
   concurrencyCap: 3,
-  progressReportIntervalSec: 120,
-  verifyConcurrencyCap: 4,
 });
 
 /**
- * Default auto-fix loop ceilings for /deliver Phase 4 (epic-audit)
- * and Phase 5 (code-review). Operators override via
- * `delivery.epicAudit.*` and `delivery.codeReview.*` in `.agentrc.json`
- * (Story #2611, Epic #2586).
- *
- * `autoFixSeverity` is **tier-aware** (Story #4412, Epic #4405). The
- * Epic-close audit tier (`DEFAULT_EPIC_AUDIT`) defaults to `'high'` —
- * remediating only 🔴 Critical + 🟠 High findings on-branch while 🟡 Medium
- * and 🟢 Suggestion findings graduate to follow-up issues. This is the
- * three-tier model's slim outermost tier: 🟡 Medium code-quality concerns are
- * already routed into on-branch remediation shift-left (the write-time
- * checklist threading of Story #4410 and the Story-scope local-lens pass of
- * Story #4409), so the Epic-close tier stops paying to re-remediate them where
- * a fix is most expensive. The code-review tier (`DEFAULT_CODE_REVIEW`) keeps
- * the `'medium'` default introduced by Story #4399. Both are hard cutovers per
- * `rules/git-conventions.md` — no back-compat flag; an operator opts back into
- * the wider routing by setting `delivery.epicAudit.autoFixSeverity: 'medium'`.
+ * Default auto-fix loop ceilings for /deliver code-review. Operators
+ * override via `delivery.codeReview.*` in `.agentrc.json` (Story #2611,
+ * Epic #2586; `autoFixSeverity` default `'medium'` per Story #4399).
  */
-export const DEFAULT_EPIC_AUDIT = Object.freeze({
-  maxFixAttempts: 3,
-  maxFixScopeFiles: 5,
-  autoFixSeverity: 'high',
-});
-
 export const DEFAULT_CODE_REVIEW = Object.freeze({
   maxFixAttempts: 3,
   maxFixScopeFiles: 5,
@@ -79,36 +51,19 @@ export const DEFAULT_CODE_REVIEW = Object.freeze({
  *
  * @param {object | null | undefined} config
  * @returns {{
- *   deliverRunner: { concurrencyCap: number, progressReportIntervalSec: number, verifyConcurrencyCap: number },
- *   epicAudit: { maxFixAttempts: number, maxFixScopeFiles: number, autoFixSeverity: 'high'|'medium' },
+ *   deliverRunner: { concurrencyCap: number },
  *   codeReview: { maxFixAttempts: number, maxFixScopeFiles: number, autoFixSeverity: 'high'|'medium' },
- *   storyMergeRetry: { maxAttempts: number, backoffMs: readonly number[] },
  *   decomposer: { concurrencyCap: number },
  * }}
  */
 export function getRunners(config) {
   const deliverRunnerUser = config?.delivery?.deliverRunner ?? {};
-  const epicAuditUser = config?.delivery?.epicAudit ?? {};
   const codeReviewUser = config?.delivery?.codeReview ?? {};
   return {
     deliverRunner: {
       concurrencyCap:
         deliverRunnerUser.concurrencyCap ??
         DEFAULT_DELIVER_RUNNER.concurrencyCap,
-      progressReportIntervalSec:
-        deliverRunnerUser.progressReportIntervalSec ??
-        DEFAULT_DELIVER_RUNNER.progressReportIntervalSec,
-      verifyConcurrencyCap:
-        deliverRunnerUser.verifyConcurrencyCap ??
-        DEFAULT_DELIVER_RUNNER.verifyConcurrencyCap,
-    },
-    epicAudit: {
-      maxFixAttempts:
-        epicAuditUser.maxFixAttempts ?? DEFAULT_EPIC_AUDIT.maxFixAttempts,
-      maxFixScopeFiles:
-        epicAuditUser.maxFixScopeFiles ?? DEFAULT_EPIC_AUDIT.maxFixScopeFiles,
-      autoFixSeverity:
-        epicAuditUser.autoFixSeverity ?? DEFAULT_EPIC_AUDIT.autoFixSeverity,
     },
     codeReview: {
       maxFixAttempts:
@@ -118,7 +73,6 @@ export function getRunners(config) {
       autoFixSeverity:
         codeReviewUser.autoFixSeverity ?? DEFAULT_CODE_REVIEW.autoFixSeverity,
     },
-    storyMergeRetry: DEFAULT_STORY_MERGE_RETRY,
     decomposer: DEFAULT_DECOMPOSER,
   };
 }

package/.agents/scripts/lib/config/temp-paths.js

@@ -1,27 +1,25 @@
 /**
- * `temp/epic-<id>/` path-resolution helper (Epic #1030 Story #1039).
+ * `temp/run-<id>/` path-resolution helper (Epic #1030 Story #1039).
  *
  * Single source of truth for every artifact path that lives under
  * `project.paths.tempRoot`. Every script that previously hand-rolled
- * a flat `temp/<artifact>-epic-<id>.<ext>` path migrates to call one of
+ * a flat `temp/<artifact>-run-<id>.<ext>` path migrates to call one of
  * these helpers. The Tech Spec (#1032) names this module as the cutover
  * grep target — `temp/.*-epic-` should be empty across `.agents/scripts`
  * once the migration Stories land.
  *
  * Layout:
- *   temp/epic-<eid>/
+ *   temp/run-<eid>/
  *     ├─ techspec.md
  *     ├─ manifest.md          (dispatch manifest)
  *     ├─ retro.md             (mirror of GitHub retro at Epic close)
- *     ├─ perf-report.md       (analyzer output, Epic-level)
  *     ├─ lifecycle.ndjson     (lifecycle bus ledger)
- *     ├─ checkpoints/...      (epic-runner state store)
- *     ├─ <name>               (epicArtifactPath escape hatch)
+ *     ├─ checkpoints/...      (pre-v2 epic-runner state store; retained layout)
+ *     ├─ <name>               (runArtifactPath escape hatch)
  *     └─ stories/
  *        └─ story-<sid>/
  *           ├─ manifest.md       (story dispatch manifest)
  *           ├─ signals.ndjson    (append-only signals writer)
- *           ├─ perf-summary.md
  *           └─ <name>            (storyArtifactPath escape hatch)
  *
  * Standalone Stories (no parent Epic) follow the same shape under
@@ -42,11 +40,12 @@
  * resolve a *relative* `tempRoot` against the **main checkout root** (the
  * parent of `git rev-parse --git-common-dir`) rather than `process.cwd()`.
  * Without this, a story child that `cd`s into `.worktrees/story-<id>/` before
- * calling `story-phase.js` would append `story.heartbeat` records to
- * `<worktree>/temp/epic-N/lifecycle.ndjson`, while the `/deliver` host
+ * emitting a lifecycle record would append it to
+ * `<worktree>/temp/run-N/lifecycle.ndjson`, while the `/deliver` host
  * (running from the main checkout) reads the main-checkout copy — so the
- * idle-watchdog never sees heartbeats and the Epic-lease guard silently
- * reclaims live foreign claims (the audit-#3513 bug class). Anchoring the
+ * host never sees the child's records (the audit-#3513 bug class; its
+ * original `story.heartbeat` instance is gone with that emitter, but the
+ * divergence applies to every ledger writer). Anchoring the
  * ledger to the git common dir makes the worktree child writer and the
  * main-checkout host reader converge on a single file regardless of cwd. An
  * absolute `tempRoot` is honoured verbatim; only relative roots are anchored.
@@ -155,11 +154,9 @@ export function tempRootFrom(config) {
     : 'temp';
 }
 
-const epicId = (id) => {
+const runId = (id) => {
   if (!Number.isInteger(id) || id <= 0) {
-    throw new Error(
-      `[temp-paths] epicId must be a positive integer; got ${id}`,
-    );
+    throw new Error(`[temp-paths] runId must be a positive integer; got ${id}`);
   }
   return id;
 };
@@ -206,18 +203,18 @@ const artifactName = (name) => {
 };
 
 /**
- * `temp/epic-<eid>/` — every Epic-scoped artifact lives under here.
+ * `temp/run-<id>/` — every run-scoped artifact lives under here.
  *
- * @param {number} eid
+ * @param {number} rid
  * @param {object} [config]
  * @returns {string}
  */
-export function epicTempDir(eid, config) {
-  return path.join(anchorTempRoot(tempRootFrom(config)), `epic-${epicId(eid)}`);
+export function runTempDir(rid, config) {
+  return path.join(anchorTempRoot(tempRootFrom(config)), `run-${runId(rid)}`);
 }
 
 /**
- * `temp/epic-<eid>/stories/story-<sid>/` — every Story-scoped artifact
+ * `temp/run-<eid>/stories/story-<sid>/` — every Story-scoped artifact
  * lives under here.
  *
  * Story #2874: accepts `eid === null` for standalone Stories (no
@@ -241,12 +238,12 @@ export function storyTempDir(eid, sid, config) {
   const parent =
     checkedEid === null
       ? path.join(anchorTempRoot(tempRootFrom(config)), 'standalone')
-      : epicTempDir(checkedEid, config);
+      : runTempDir(checkedEid, config);
   return path.join(parent, 'stories', `story-${storyId(sid)}`);
 }
 
 /**
- * `temp/epic-<eid>/stories/story-<sid>/signals.ndjson` — append-only
+ * `temp/run-<eid>/stories/story-<sid>/signals.ndjson` — append-only
  * signal stream consumed by the analyzer (Epic #1030 AC1).
  *
  * @param {number} eid
@@ -259,18 +256,18 @@ export function signalsFile(eid, sid, config) {
 }
 
 /**
- * `temp/epic-<eid>/stories/story-<sid>/lifecycle.ndjson` — the story-scope
+ * `temp/run-<eid>/stories/story-<sid>/lifecycle.ndjson` — the story-scope
  * ledger destination for lifecycle events emitted directly by a Story
  * (rather than routed through the Epic-scoped bus ledger). Story #4426
  * (Epic #4425) introduces the first consumer: a standalone
  * `single-story-close` run (no parent Epic) emitting `merge.unlanded`
- * needs an on-disk home even though there is no `epic-<id>/` directory to
+ * needs an on-disk home even though there is no `run-<id>/` directory to
  * anchor the event to.
  *
- * Mirrors `epicLedgerPath` exactly, one level down: `eid === null` routes
+ * Mirrors `runLedgerPath` exactly, one level down: `eid === null` routes
  * through `storyTempDir`'s standalone branch to
  * `<tempRoot>/standalone/stories/story-<sid>/lifecycle.ndjson`; a real
- * `eid` routes to `<tempRoot>/epic-<eid>/stories/story-<sid>/lifecycle.ndjson`,
+ * `eid` routes to `<tempRoot>/run-<eid>/stories/story-<sid>/lifecycle.ndjson`,
  * so an Epic-attached Story's story-scope ledger sits alongside its
  * `signals.ndjson` sibling.
  *
@@ -293,14 +290,13 @@ export const storyLedgerPath = (eid, sid, config) =>
  * @param {object} [config]
  * @returns {string}
  */
-export function epicArtifactPath(eid, name, config) {
-  return path.join(epicTempDir(eid, config), artifactName(name));
+export function runArtifactPath(eid, name, config) {
+  return path.join(runTempDir(eid, config), artifactName(name));
 }
 
 /**
  * Escape hatch for a Story-level artifact whose name isn't part of the
- * canonical layout (signals.ndjson + perf-summary.md + manifest.md ship
- * named helpers).
+ * canonical layout (signals.ndjson + manifest.md ship named helpers).
  *
  * @param {number} eid
  * @param {number} sid
@@ -308,39 +304,12 @@ export function epicArtifactPath(eid, name, config) {
  * @param {object} [config]
  * @returns {string}
  */
-export function storyArtifactPath(eid, sid, name, config) {
+function storyArtifactPath(eid, sid, name, config) {
   return path.join(storyTempDir(eid, sid, config), artifactName(name));
 }
 
-// --- Canonical Epic-level filenames (Tech Spec #1032 §tempRoot) ---
-
-export const epicTechSpecPath = (eid, config) =>
-  epicArtifactPath(eid, 'techspec.md', config);
-export const epicManifestPath = (eid, config) =>
-  epicArtifactPath(eid, 'manifest.md', config);
-export const epicRetroMirrorPath = (eid, config) =>
-  epicArtifactPath(eid, 'retro.md', config);
-export const epicPerfReportPath = (eid, config) =>
-  epicArtifactPath(eid, 'perf-report.md', config);
-
-/**
- * `temp/epic-<eid>/epic-perf-report.json` — canonical JSON snapshot of
- * the `epic-perf-report` payload persisted at /deliver close
- * (Epic #3019 / Story #3029 / Task #3040). When present alongside the
- * `epic-perf-report` structured comment, the report is discoverable
- * from the file system without round-tripping the ticketing provider,
- * and the `epic-handoff` structured close comment links it by relative
- * path.
- *
- * @param {number} eid
- * @param {object} [config]
- * @returns {string}
- */
-export const epicPerfReportJsonPath = (eid, config) =>
-  epicArtifactPath(eid, 'epic-perf-report.json', config);
-
 /**
- * `temp/epic-<eid>/lifecycle.ndjson` — append-only lifecycle bus ledger
+ * `temp/run-<eid>/lifecycle.ndjson` — append-only lifecycle bus ledger
  * (Story #2510). The LedgerWriter persists every emitted/completed/failed
  * record here; the TraceLogger renders the companion markdown from it.
  *
@@ -352,12 +321,10 @@ export const epicPerfReportJsonPath = (eid, config) =>
  * @param {object} [config]
  * @returns {string}
  */
-export const epicLedgerPath = (eid, config) =>
-  epicArtifactPath(eid, 'lifecycle.ndjson', config);
+export const runLedgerPath = (eid, config) =>
+  runArtifactPath(eid, 'lifecycle.ndjson', config);
 
 // --- Canonical Story-level filenames ---
 
 export const storyManifestPath = (eid, sid, config) =>
   storyArtifactPath(eid, sid, 'manifest.md', config);
-export const storyPerfSummaryPath = (eid, sid, config) =>
-  storyArtifactPath(eid, sid, 'perf-summary.md', config);

package/.agents/scripts/lib/config/worktree-isolation.js

@@ -33,7 +33,6 @@ export const WORKTREE_ISOLATION_DEFAULTS = Object.freeze({
   primeFromPath: null,
   allowSymlinkOnWindows: false,
   reapOnSuccess: true,
-  reapOnCancel: true,
   // Gitignored workspace files copied into each new worktree. Includes the
   // operator's local-override files (`.agentrc.local.json`,
   // `.agents/instructions.local.md`) so a worktree-isolated agent honors the
@@ -84,10 +83,6 @@ export function getWorktreeIsolation(config) {
       typeof wi.reapOnSuccess === 'boolean'
         ? wi.reapOnSuccess
         : WORKTREE_ISOLATION_DEFAULTS.reapOnSuccess,
-    reapOnCancel:
-      typeof wi.reapOnCancel === 'boolean'
-        ? wi.reapOnCancel
-        : WORKTREE_ISOLATION_DEFAULTS.reapOnCancel,
     bootstrapFiles: Array.isArray(wi.bootstrapFiles)
       ? wi.bootstrapFiles
       : [...WORKTREE_ISOLATION_DEFAULTS.bootstrapFiles],

package/.agents/scripts/lib/config-resolver.js

@@ -27,7 +27,6 @@ import path from 'node:path';
 import { getCiDelivery } from './config/ci.js';
 import { getCommands } from './config/commands.js';
 import { getGitHub } from './config/github.js';
-import { getLifecycle } from './config/lifecycle.js';
 import { resolvePaths } from './config/paths.js';
 import { validateOrchestrationConfig } from './config/validate-orchestration.js';
 import { getWorktreeIsolation } from './config/worktree-isolation.js';
@@ -43,10 +42,8 @@ export { NOTIFICATIONS_DEFAULTS } from './config/github.js';
 export {
   getLimits,
   LIMITS_DEFAULTS,
-  resolvePreflightCeilings,
 } from './config/limits.js';
 export { getPaths } from './config/paths.js';
-export { getPreflight, PREFLIGHT_DEFAULTS } from './config/preflight.js';
 export {
   CODING_GUARDRAILS_DEFAULTS,
   getQuality,
@@ -107,10 +104,8 @@ function applyDeliveryDefaults(rawDelivery) {
   delivery.worktreeIsolation = getWorktreeIsolation({
     worktreeIsolation: delivery.worktreeIsolation,
   });
-  delivery.lifecycle = getLifecycle({ lifecycle: delivery.lifecycle });
-  // Story #2899 (Epic #2880) — `delivery.ci` always carries
-  // `skipForStoryPushes: true` by default so Story-branch commit
-  // tooling applies the `[skip ci]` trailer without operator opt-in.
+  // `delivery.ci` always carries autoMerge (and passes watch through) so
+  // CI-aware delivery knobs resolve without operator opt-in.
   delivery.ci = getCiDelivery({ ci: delivery.ci });
   return delivery;
 }