mandrel 1.94.0 → 2.0.0

package/.agents/scripts/lib/config/limits.js

@@ -6,24 +6,18 @@
  * `planning.*` and `delivery.*`:
  *
  *   - `planning.context.{maxBytes, summaryMode}` (planning-context budget)
- *   - `delivery.maxTokenBudget` (task-prompt hydration cap)
  *   - `delivery.execution.timeoutMs` (per-process execution timeout)
  *   - `delivery.lease.ttlMs` (assignee-as-lease staleness window — Story #3480)
- *   - `delivery.signals.{hotspot, rework, retry}` (performance-signal
- *     detector thresholds — `churn` and `idle` dropped)
+ *   - `delivery.signals.{rework, retry}` (performance-signal detector
+ *     thresholds — `hotspot` retired with Epic #4406; `churn`/`idle` dropped)
  *
- * `maxTickets` (the decomposer reviewability budget) is a **framework
- * constant** — Story #4163 collapsed the never-overridden
- * `planning.maxTickets` operator knob to `LIMITS_DEFAULTS.maxTickets` and
- * removed it from the AJV schema, the published mirror, and the explain
- * map. The persist-time over-budget gate (ADR-20260610) still reads the
- * constant via `getLimits(config).maxTickets`; `resolveLimits` no longer
- * reads `planning.maxTickets`, so setting it in a config is inert.
+ * Framework constants (not operator-tunable via `.agentrc.json`):
+ *   - `maxTickets` — decomposer reviewability budget (Story #4163)
  *
- * Dropped entirely: `maxInstructionSteps`, `friction.*` (the LLM
- * self-pacing thresholds rewritten as qualitative prose in
- * `.agents/instructions.md`), `executionMaxBuffer` (now a framework-internal
- * constant in the spawn caller modules), `signals.{churn, idle}`.
+ * Dropped entirely: `maxInstructionSteps`, `friction.*`, `executionMaxBuffer`,
+ * `signals.{churn, idle}`, `delivery.preflight`, `delivery.maxTokenBudget`
+ * (planning no longer sizes against a token-budget envelope; session-mass
+ * ceilings are absolute in `DEFAULT_MODEL_CAPACITY`).
  *
  * The historic combined accessor `getLimits(config)` is preserved as a
  * compatibility surface: it returns a wrapper carrying the surviving
@@ -31,14 +25,12 @@
  * working. New call sites should prefer the specific accessors below.
  */
 
-import { getPreflight } from './preflight.js';
-
 /**
- * Framework defaults for the performance-signal detector thresholds. The two
- * dropped detectors (`churn`, `idle`) are omitted entirely.
+ * Framework defaults for the performance-signal detector thresholds.
+ * `hotspot` was retired with its detector (Epic #4406); `churn` and `idle`
+ * were dropped earlier.
  */
 export const SIGNALS_DEFAULTS = Object.freeze({
-  hotspot: Object.freeze({ p95Multiplier: 1.25 }),
   rework: Object.freeze({ editsPerFile: 5 }),
   retry: Object.freeze({ repeatCount: 3 }),
 });
@@ -53,17 +45,10 @@ export const SIGNALS_DEFAULTS = Object.freeze({
 export const LEASE_TTL_MS_DEFAULT = 900000;
 
 /**
- * Framework defaults for the surviving limits surface. `executionTimeoutMs`
- * bumps from 5 min to 10 min per the Story 1 decisions log.
- *
- * `maxTokenBudget` is a **single global value** (Story #3875 — raised once
- * from 200000 to 300000 so capability-sized Stories are not clipped by
- * hydration elision). There is intentionally no per-profile or
- * per-complexity budget branch anywhere in the resolver.
+ * Framework defaults for the surviving limits surface.
  */
 export const LIMITS_DEFAULTS = Object.freeze({
   maxTickets: 80,
-  maxTokenBudget: 300000,
   executionTimeoutMs: 600000,
   leaseTtlMs: LEASE_TTL_MS_DEFAULT,
   planningContext: Object.freeze({
@@ -79,7 +64,7 @@ export const LIMITS_DEFAULTS = Object.freeze({
  * operator can override a single threshold without re-listing the others.
  *
  * @param {object|undefined} userSignals
- * @returns {{ hotspot: {p95Multiplier: number}, rework: {editsPerFile: number}, retry: {repeatCount: number} }}
+ * @returns {{ rework: {editsPerFile: number}, retry: {repeatCount: number} }}
  */
 function mergeSignals(userSignals) {
   const user =
@@ -97,16 +82,14 @@ function mergeSignals(userSignals) {
 
 /**
  * Resolve the surviving limits surface against a `.agentrc.json` shape
- * (post-reshape). Accepts the resolved-config wrapper or a partial bag —
- * `maxTickets` is the framework constant `LIMITS_DEFAULTS.maxTickets`
- * (no longer operator-configurable; Story #4163), pulls `planningContext`
- * from `planning.*`, pulls `maxTokenBudget` and `executionTimeoutMs` from
- * `delivery.*`, pulls signals from `delivery.signals.*`.
+ * (post-reshape). `maxTickets` is a framework constant (never read from
+ * config); pulls `planningContext` from `planning.*`, pulls
+ * `executionTimeoutMs` from `delivery.*`, pulls signals from
+ * `delivery.signals.*`.
  *
  * @param {object|undefined} config
  * @returns {{
  *   maxTickets: number,
- *   maxTokenBudget: number,
  *   executionTimeoutMs: number,
  *   leaseTtlMs: number,
  *   planningContext: { maxBytes: number, summaryMode: string },
@@ -133,11 +116,7 @@ export function resolveLimits(config) {
   const lease =
     delivery.lease && typeof delivery.lease === 'object' ? delivery.lease : {};
   return {
-    // `maxTickets` is a framework constant (Story #4163) — never read from
-    // `planning.maxTickets`. The persist-time over-budget gate still reads
-    // this value via getLimits().maxTickets.
     maxTickets: LIMITS_DEFAULTS.maxTickets,
-    maxTokenBudget: delivery.maxTokenBudget ?? LIMITS_DEFAULTS.maxTokenBudget,
     executionTimeoutMs:
       execution.timeoutMs ?? LIMITS_DEFAULTS.executionTimeoutMs,
     leaseTtlMs: lease.ttlMs ?? LIMITS_DEFAULTS.leaseTtlMs,
@@ -173,26 +152,6 @@ export function getSignals(config) {
   return getLimits(config).signals;
 }
 
-/**
- * Resolve the configured `delivery.preflight.max*` ceilings as a plain
- * object holding **only** the keys the operator actually configured
- * (Story #3875 — plan-time/delivery-time reconciliation). Unconfigured
- * ceilings (`null` floors, meaning "no cap") are omitted entirely so the
- * decomposition context can thread a compact, non-null envelope to the
- * planner. An Epic on a zero-config project yields `{}` — never `null`.
- *
- * @param {object | null | undefined} config
- * @returns {Record<string, number>}
- */
-export function resolvePreflightCeilings(config) {
-  const resolved = getPreflight(config);
-  const ceilings = {};
-  for (const [key, value] of Object.entries(resolved)) {
-    if (value !== null) ceilings[key] = value;
-  }
-  return ceilings;
-}
-
 /**
  * Resolve the assignee-as-lease TTL in milliseconds (Story #3480). Standalone
  * accessor so the `ticket-lease` module can import it without dragging the

package/.agents/scripts/lib/config/paths.js

@@ -32,7 +32,6 @@ export const PATHS_DEFAULTS = Object.freeze({
  *   auditOutputDir: string,
  *   scriptsRoot: string,
  *   workflowsRoot: string,
- *   personasRoot: string,
  *   schemasRoot: string,
  *   skillsRoot: string,
  *   templatesRoot: string,
@@ -53,7 +52,6 @@ export function resolvePaths(userPaths) {
     auditOutputDir: `${tempRoot}/audits`,
     scriptsRoot: `${agentRoot}/scripts`,
     workflowsRoot: `${agentRoot}/workflows`,
-    personasRoot: `${agentRoot}/personas`,
     schemasRoot: `${agentRoot}/schemas`,
     skillsRoot: `${agentRoot}/skills`,
     templatesRoot: `${agentRoot}/templates`,

package/.agents/scripts/lib/config/quality.js

@@ -57,7 +57,7 @@ const DEFAULT_COVERAGE_FLOORS = Object.freeze({
   '*': Object.freeze({ lines: 90, branches: 85, functions: 90 }),
 });
 const DEFAULT_CRAP_FLOORS = Object.freeze({
-  '*': Object.freeze({ crap: 20 }),
+  '*': Object.freeze({ max: 30, p95: 20, methodsAbove20: 50 }),
 });
 /**
  * Story #2193 — maintainability rollups expose the `min` / `p50` / `p95`

package/.agents/scripts/lib/config/runners.js

@@ -1,10 +1,12 @@
 /**
  * Runner accessor (Epic #1720 Story #1739 — top-level reshape).
  *
- * Post-reshape, only `delivery.deliverRunner`, `delivery.epicAudit`, and
- * `delivery.codeReview` are configurable; everything else lives in
- * framework-internal constants exported alongside (`DEFAULT_STORY_MERGE_RETRY`,
- * `DEFAULT_DECOMPOSER`).
+ * Post-reshape, only `delivery.deliverRunner` and `delivery.codeReview` are
+ * configurable via this accessor; everything else lives in framework-internal
+ * constants exported alongside (`DEFAULT_STORY_MERGE_RETRY`,
+ * `DEFAULT_DECOMPOSER`). `delivery.epicAudit` was removed on v2 (Story-only
+ * delivery — no epic-audit runner; remediation policy lives on
+ * `delivery.codeReview`).
  */
 
 /** Hardcoded story-merge retry policy (was `orchestration.runners.storyMergeRetry`). */
@@ -23,14 +25,13 @@ export const DEFAULT_DECOMPOSER = Object.freeze({
  * `delivery.deliverRunner.*` in `.agentrc.json`.
  *
  * **Throughput tradeoff — `concurrencyCap`.**
- * The default of 3 is intentionally conservative: it keeps host-quota
- * consumption low for Epics with small waves and avoids saturating the
- * GitHub API with concurrent label writes. For wide-wave Epics where the
- * host has adequate parallel-agent quota, operators should raise
- * `delivery.deliverRunner.concurrencyCap` — wall-clock time falls
- * proportionally to the extra concurrency. The safe default is a tuning
- * knob, not a performance ceiling. See `helpers/deliver-epic.md` § Phase 2b and
- * `agentrc-reference.json` `delivery.deliverRunner.concurrencyCap` for details.
+ * The default of 3 is intentionally moderate: it keeps host-quota
+ * consumption predictable for multi-Story plan-runs and avoids saturating
+ * the GitHub API with concurrent label writes, while still allowing a
+ * small ready-set fan-out. Operators who want strictly sequential delivery
+ * should set `delivery.deliverRunner.concurrencyCap: 1`. Raising the cap
+ * reduces wall-clock time where dependencies allow. See `deliver.md` and
+ * `agentrc-reference.json` `delivery.deliverRunner.concurrencyCap`.
  *
  * **`verifyConcurrencyCap`** (Epic #3019 Tech Spec §1.4 / Story #3024) is a
  * separate knob that bounds the `verifyWaveResults` loop independently of
@@ -39,35 +40,14 @@ export const DEFAULT_DECOMPOSER = Object.freeze({
  */
 const DEFAULT_DELIVER_RUNNER = Object.freeze({
   concurrencyCap: 3,
-  progressReportIntervalSec: 120,
   verifyConcurrencyCap: 4,
 });
 
 /**
- * Default auto-fix loop ceilings for /deliver Phase 4 (epic-audit)
- * and Phase 5 (code-review). Operators override via
- * `delivery.epicAudit.*` and `delivery.codeReview.*` in `.agentrc.json`
- * (Story #2611, Epic #2586).
- *
- * `autoFixSeverity` is **tier-aware** (Story #4412, Epic #4405). The
- * Epic-close audit tier (`DEFAULT_EPIC_AUDIT`) defaults to `'high'` —
- * remediating only 🔴 Critical + 🟠 High findings on-branch while 🟡 Medium
- * and 🟢 Suggestion findings graduate to follow-up issues. This is the
- * three-tier model's slim outermost tier: 🟡 Medium code-quality concerns are
- * already routed into on-branch remediation shift-left (the write-time
- * checklist threading of Story #4410 and the Story-scope local-lens pass of
- * Story #4409), so the Epic-close tier stops paying to re-remediate them where
- * a fix is most expensive. The code-review tier (`DEFAULT_CODE_REVIEW`) keeps
- * the `'medium'` default introduced by Story #4399. Both are hard cutovers per
- * `rules/git-conventions.md` — no back-compat flag; an operator opts back into
- * the wider routing by setting `delivery.epicAudit.autoFixSeverity: 'medium'`.
+ * Default auto-fix loop ceilings for /deliver code-review. Operators
+ * override via `delivery.codeReview.*` in `.agentrc.json` (Story #2611,
+ * Epic #2586; `autoFixSeverity` default `'medium'` per Story #4399).
  */
-export const DEFAULT_EPIC_AUDIT = Object.freeze({
-  maxFixAttempts: 3,
-  maxFixScopeFiles: 5,
-  autoFixSeverity: 'high',
-});
-
 export const DEFAULT_CODE_REVIEW = Object.freeze({
   maxFixAttempts: 3,
   maxFixScopeFiles: 5,
@@ -79,8 +59,7 @@ export const DEFAULT_CODE_REVIEW = Object.freeze({
  *
  * @param {object | null | undefined} config
  * @returns {{
- *   deliverRunner: { concurrencyCap: number, progressReportIntervalSec: number, verifyConcurrencyCap: number },
- *   epicAudit: { maxFixAttempts: number, maxFixScopeFiles: number, autoFixSeverity: 'high'|'medium' },
+ *   deliverRunner: { concurrencyCap: number, verifyConcurrencyCap: number },
  *   codeReview: { maxFixAttempts: number, maxFixScopeFiles: number, autoFixSeverity: 'high'|'medium' },
  *   storyMergeRetry: { maxAttempts: number, backoffMs: readonly number[] },
  *   decomposer: { concurrencyCap: number },
@@ -88,28 +67,16 @@ export const DEFAULT_CODE_REVIEW = Object.freeze({
  */
 export function getRunners(config) {
   const deliverRunnerUser = config?.delivery?.deliverRunner ?? {};
-  const epicAuditUser = config?.delivery?.epicAudit ?? {};
   const codeReviewUser = config?.delivery?.codeReview ?? {};
   return {
     deliverRunner: {
       concurrencyCap:
         deliverRunnerUser.concurrencyCap ??
         DEFAULT_DELIVER_RUNNER.concurrencyCap,
-      progressReportIntervalSec:
-        deliverRunnerUser.progressReportIntervalSec ??
-        DEFAULT_DELIVER_RUNNER.progressReportIntervalSec,
       verifyConcurrencyCap:
         deliverRunnerUser.verifyConcurrencyCap ??
         DEFAULT_DELIVER_RUNNER.verifyConcurrencyCap,
     },
-    epicAudit: {
-      maxFixAttempts:
-        epicAuditUser.maxFixAttempts ?? DEFAULT_EPIC_AUDIT.maxFixAttempts,
-      maxFixScopeFiles:
-        epicAuditUser.maxFixScopeFiles ?? DEFAULT_EPIC_AUDIT.maxFixScopeFiles,
-      autoFixSeverity:
-        epicAuditUser.autoFixSeverity ?? DEFAULT_EPIC_AUDIT.autoFixSeverity,
-    },
     codeReview: {
       maxFixAttempts:
         codeReviewUser.maxFixAttempts ?? DEFAULT_CODE_REVIEW.maxFixAttempts,

package/.agents/scripts/lib/config/temp-paths.js

@@ -1,21 +1,21 @@
 /**
- * `temp/epic-<id>/` path-resolution helper (Epic #1030 Story #1039).
+ * `temp/run-<id>/` path-resolution helper (Epic #1030 Story #1039).
  *
  * Single source of truth for every artifact path that lives under
  * `project.paths.tempRoot`. Every script that previously hand-rolled
- * a flat `temp/<artifact>-epic-<id>.<ext>` path migrates to call one of
+ * a flat `temp/<artifact>-run-<id>.<ext>` path migrates to call one of
  * these helpers. The Tech Spec (#1032) names this module as the cutover
  * grep target — `temp/.*-epic-` should be empty across `.agents/scripts`
  * once the migration Stories land.
  *
  * Layout:
- *   temp/epic-<eid>/
+ *   temp/run-<eid>/
  *     ├─ techspec.md
  *     ├─ manifest.md          (dispatch manifest)
  *     ├─ retro.md             (mirror of GitHub retro at Epic close)
  *     ├─ perf-report.md       (analyzer output, Epic-level)
  *     ├─ lifecycle.ndjson     (lifecycle bus ledger)
- *     ├─ checkpoints/...      (epic-runner state store)
+ *     ├─ checkpoints/...      (pre-v2 epic-runner state store; retained layout)
  *     ├─ <name>               (epicArtifactPath escape hatch)
  *     └─ stories/
  *        └─ story-<sid>/
@@ -43,7 +43,7 @@
  * parent of `git rev-parse --git-common-dir`) rather than `process.cwd()`.
  * Without this, a story child that `cd`s into `.worktrees/story-<id>/` before
  * calling `story-phase.js` would append `story.heartbeat` records to
- * `<worktree>/temp/epic-N/lifecycle.ndjson`, while the `/deliver` host
+ * `<worktree>/temp/run-N/lifecycle.ndjson`, while the `/deliver` host
  * (running from the main checkout) reads the main-checkout copy — so the
  * idle-watchdog never sees heartbeats and the Epic-lease guard silently
  * reclaims live foreign claims (the audit-#3513 bug class). Anchoring the
@@ -206,18 +206,23 @@ const artifactName = (name) => {
 };
 
 /**
- * `temp/epic-<eid>/` — every Epic-scoped artifact lives under here.
+ * `temp/run-<eid>/` — every Epic-scoped artifact lives under here.
  *
  * @param {number} eid
  * @param {object} [config]
  * @returns {string}
  */
+export function runTempDir(rid, config) {
+  return path.join(anchorTempRoot(tempRootFrom(config)), `run-${epicId(rid)}`);
+}
+
+/** @deprecated Use {@link runTempDir}. */
 export function epicTempDir(eid, config) {
-  return path.join(anchorTempRoot(tempRootFrom(config)), `epic-${epicId(eid)}`);
+  return runTempDir(eid, config);
 }
 
 /**
- * `temp/epic-<eid>/stories/story-<sid>/` — every Story-scoped artifact
+ * `temp/run-<eid>/stories/story-<sid>/` — every Story-scoped artifact
  * lives under here.
  *
  * Story #2874: accepts `eid === null` for standalone Stories (no
@@ -246,7 +251,7 @@ export function storyTempDir(eid, sid, config) {
 }
 
 /**
- * `temp/epic-<eid>/stories/story-<sid>/signals.ndjson` — append-only
+ * `temp/run-<eid>/stories/story-<sid>/signals.ndjson` — append-only
  * signal stream consumed by the analyzer (Epic #1030 AC1).
  *
  * @param {number} eid
@@ -259,18 +264,18 @@ export function signalsFile(eid, sid, config) {
 }
 
 /**
- * `temp/epic-<eid>/stories/story-<sid>/lifecycle.ndjson` — the story-scope
+ * `temp/run-<eid>/stories/story-<sid>/lifecycle.ndjson` — the story-scope
  * ledger destination for lifecycle events emitted directly by a Story
  * (rather than routed through the Epic-scoped bus ledger). Story #4426
  * (Epic #4425) introduces the first consumer: a standalone
  * `single-story-close` run (no parent Epic) emitting `merge.unlanded`
- * needs an on-disk home even though there is no `epic-<id>/` directory to
+ * needs an on-disk home even though there is no `run-<id>/` directory to
  * anchor the event to.
  *
  * Mirrors `epicLedgerPath` exactly, one level down: `eid === null` routes
  * through `storyTempDir`'s standalone branch to
  * `<tempRoot>/standalone/stories/story-<sid>/lifecycle.ndjson`; a real
- * `eid` routes to `<tempRoot>/epic-<eid>/stories/story-<sid>/lifecycle.ndjson`,
+ * `eid` routes to `<tempRoot>/run-<eid>/stories/story-<sid>/lifecycle.ndjson`,
  * so an Epic-attached Story's story-scope ledger sits alongside its
  * `signals.ndjson` sibling.
  *
@@ -324,7 +329,7 @@ export const epicPerfReportPath = (eid, config) =>
   epicArtifactPath(eid, 'perf-report.md', config);
 
 /**
- * `temp/epic-<eid>/epic-perf-report.json` — canonical JSON snapshot of
+ * `temp/run-<eid>/epic-perf-report.json` — canonical JSON snapshot of
  * the `epic-perf-report` payload persisted at /deliver close
  * (Epic #3019 / Story #3029 / Task #3040). When present alongside the
  * `epic-perf-report` structured comment, the report is discoverable
@@ -340,7 +345,7 @@ export const epicPerfReportJsonPath = (eid, config) =>
   epicArtifactPath(eid, 'epic-perf-report.json', config);
 
 /**
- * `temp/epic-<eid>/lifecycle.ndjson` — append-only lifecycle bus ledger
+ * `temp/run-<eid>/lifecycle.ndjson` — append-only lifecycle bus ledger
  * (Story #2510). The LedgerWriter persists every emitted/completed/failed
  * record here; the TraceLogger renders the companion markdown from it.
  *

package/.agents/scripts/lib/config/worktree-isolation.js

@@ -33,7 +33,6 @@ export const WORKTREE_ISOLATION_DEFAULTS = Object.freeze({
   primeFromPath: null,
   allowSymlinkOnWindows: false,
   reapOnSuccess: true,
-  reapOnCancel: true,
   // Gitignored workspace files copied into each new worktree. Includes the
   // operator's local-override files (`.agentrc.local.json`,
   // `.agents/instructions.local.md`) so a worktree-isolated agent honors the
@@ -84,10 +83,6 @@ export function getWorktreeIsolation(config) {
       typeof wi.reapOnSuccess === 'boolean'
         ? wi.reapOnSuccess
         : WORKTREE_ISOLATION_DEFAULTS.reapOnSuccess,
-    reapOnCancel:
-      typeof wi.reapOnCancel === 'boolean'
-        ? wi.reapOnCancel
-        : WORKTREE_ISOLATION_DEFAULTS.reapOnCancel,
     bootstrapFiles: Array.isArray(wi.bootstrapFiles)
       ? wi.bootstrapFiles
       : [...WORKTREE_ISOLATION_DEFAULTS.bootstrapFiles],

package/.agents/scripts/lib/config-resolver.js

@@ -27,7 +27,6 @@ import path from 'node:path';
 import { getCiDelivery } from './config/ci.js';
 import { getCommands } from './config/commands.js';
 import { getGitHub } from './config/github.js';
-import { getLifecycle } from './config/lifecycle.js';
 import { resolvePaths } from './config/paths.js';
 import { validateOrchestrationConfig } from './config/validate-orchestration.js';
 import { getWorktreeIsolation } from './config/worktree-isolation.js';
@@ -43,10 +42,8 @@ export { NOTIFICATIONS_DEFAULTS } from './config/github.js';
 export {
   getLimits,
   LIMITS_DEFAULTS,
-  resolvePreflightCeilings,
 } from './config/limits.js';
 export { getPaths } from './config/paths.js';
-export { getPreflight, PREFLIGHT_DEFAULTS } from './config/preflight.js';
 export {
   CODING_GUARDRAILS_DEFAULTS,
   getQuality,
@@ -107,10 +104,8 @@ function applyDeliveryDefaults(rawDelivery) {
   delivery.worktreeIsolation = getWorktreeIsolation({
     worktreeIsolation: delivery.worktreeIsolation,
   });
-  delivery.lifecycle = getLifecycle({ lifecycle: delivery.lifecycle });
-  // Story #2899 (Epic #2880) — `delivery.ci` always carries
-  // `skipForStoryPushes: true` by default so Story-branch commit
-  // tooling applies the `[skip ci]` trailer without operator opt-in.
+  // `delivery.ci` always carries autoMerge (and passes watch through) so
+  // CI-aware delivery knobs resolve without operator opt-in.
   delivery.ci = getCiDelivery({ ci: delivery.ci });
   return delivery;
 }