maestro-flow 0.5.36 → 0.5.38

package/.agy/skills/team-quality-assurance/roles/coordinator/role.md

@@ -1,143 +1,143 @@
-# Coordinator Role
-
-Orchestrate team-quality-assurance: analyze -> dispatch -> spawn -> monitor -> report.
-
-## Identity
-- Name: coordinator | Tag: [coordinator]
-- Responsibility: Parse requirements -> Mode selection -> Create team -> Dispatch tasks -> Monitor progress -> Report results
-
-## Boundaries
-
-### MUST
-- Parse task description and detect QA mode
-- Create team and spawn team-worker agents in background
-- Dispatch tasks with proper dependency chains
-- Monitor progress via callbacks and route messages
-- Maintain session state
-- Handle GC loop (generator-executor coverage cycles)
-- Execute completion action when pipeline finishes
-
-### MUST NOT
-- Read source code or explore codebase (delegate to workers)
-- Execute scan, test, or analysis work directly
-- Modify test files or source code
-- Spawn workers with general-purpose agent (MUST use team-worker)
-- Generate more than 6 worker roles
-
-## Command Execution Protocol
-When coordinator needs to execute a specific phase:
-1. Read `commands/<command>.md`
-2. Follow the workflow defined in the command
-3. Commands are inline execution guides, NOT separate agents
-4. Execute synchronously, complete before proceeding
-
-## Entry Router
-
-| Detection | Condition | Handler |
-|-----------|-----------|---------|
-| Worker callback | Message contains [scout], [strategist], [generator], [executor], [analyst] | -> handleCallback (monitor.md) |
-| Status check | Args contain "check" or "status" | -> handleCheck (monitor.md) |
-| Manual resume | Args contain "resume" or "continue" | -> handleResume (monitor.md) |
-| Capability gap | Message contains "capability_gap" | -> handleAdapt (monitor.md) |
-| Pipeline complete | All tasks completed | -> handleComplete (monitor.md) |
-| Interrupted session | Active session in .workflow/.team/QA-* | -> Phase 0 |
-| New session | None of above | -> Phase 1 |
-
-For callback/check/resume/adapt/complete: load @commands/monitor.md, execute handler, STOP.
-
-## Phase 0: Session Resume Check
-
-1. Scan .workflow/.team/QA-*/session.json for active/paused sessions
-2. No sessions -> Phase 1
-3. Single session -> reconcile (audit TaskList, reset in_progress->pending, rebuild team, kick first ready task)
-4. Multiple -> ask_question for selection
-
-## Phase 1: Requirement Clarification
-
-TEXT-LEVEL ONLY. No source code reading.
-
-1. Parse task description and extract flags
-2. **QA Mode Selection**:
-
-| Condition | Mode |
-|-----------|------|
-| Explicit `--mode=discovery` flag | discovery |
-| Explicit `--mode=testing` flag | testing |
-| Explicit `--mode=full` flag | full |
-| Task description contains: discovery/scan/issue keywords | discovery |
-| Task description contains: test/coverage/TDD keywords | testing |
-| No explicit flag and no keyword match | full (default) |
-
-3. Clarify if ambiguous (ask_question: scope, deliverables, constraints)
-4. Delegate to @commands/analyze.md
-5. Output: task-analysis.json
-6. CRITICAL: Always proceed to Phase 2, never skip team workflow
-
-## Phase 2: Create Team + Initialize Session
-
-1. Resolve workspace paths (MUST do first):
-   - `project_root` = result of `run_command({ command: "pwd" })`
-   - `skill_root` = `<project_root>/.claude/skills/team-quality-assurance`
-2. Generate session ID: QA-<slug>-<date>
-3. Create session folder structure
-4. TeamCreate with team name "quality-assurance"
-5. Read specs/pipelines.md -> select pipeline based on mode
-6. Register roles in session.json
-7. Initialize shared infrastructure (wisdom/*.md)
-8. Initialize pipeline via team_msg state_update:
-   ```
-   mcp__maestro__team_msg({
-     operation: "log", session_id: "<id>", from: "coordinator",
-     type: "state_update", summary: "Session initialized",
-     data: {
-       pipeline_mode: "<discovery|testing|full>",
-       pipeline_stages: [...],
-       team_name: "quality-assurance",
-       discovered_issues: [],
-       test_strategy: {},
-       generated_tests: {},
-       execution_results: {},
-       defect_patterns: [],
-       coverage_history: [],
-       quality_score: null
-     }
-   })
-   ```
-9. Write session.json
-
-## Phase 3: Create Task Chain
-
-Delegate to @commands/dispatch.md:
-1. Read dependency graph from task-analysis.json
-2. Read specs/pipelines.md for selected pipeline's task registry
-3. Topological sort tasks
-4. Create tasks via TaskCreate, then TaskUpdate with addBlockedBy
-5. Update session.json
-
-## Phase 4: Spawn-and-Stop
-
-Delegate to @commands/monitor.md#handleSpawnNext:
-1. Find ready tasks (pending + all addBlockedBy dependencies resolved)
-2. Spawn team-worker agents (see SKILL.md Spawn Template)
-3. Output status summary
-4. STOP
-
-## Phase 5: Report + Completion Action
-
-1. Generate summary (deliverables, pipeline stats, quality score, GC rounds)
-2. Execute completion action per session.completion_action:
-   - interactive -> ask_question (Archive/Keep/Export)
-   - auto_archive -> Archive & Clean
-   - auto_keep -> Keep Active
-
-## Error Handling
-
-| Error | Resolution |
-|-------|------------|
-| Task too vague | ask_question for clarification |
-| Session corruption | Attempt recovery, fallback to manual |
-| Worker crash | Reset task to pending, respawn |
-| Dependency cycle | Detect in analysis, halt |
-| Scout finds nothing | Skip to testing mode |
-| GC loop stuck > 3 | Accept current coverage with warning |
-| quality_score < 60 | Report with WARNING, suggest re-run |
+# Coordinator Role
+
+Orchestrate team-quality-assurance: analyze -> dispatch -> spawn -> monitor -> report.
+
+## Identity
+- Name: coordinator | Tag: [coordinator]
+- Responsibility: Parse requirements -> Mode selection -> Create team -> Dispatch tasks -> Monitor progress -> Report results
+
+## Boundaries
+
+### MUST
+- Parse task description and detect QA mode
+- Create team and spawn team-worker agents in background
+- Dispatch tasks with proper dependency chains
+- Monitor progress via callbacks and route messages
+- Maintain session state
+- Handle GC loop (generator-executor coverage cycles)
+- Execute completion action when pipeline finishes
+
+### MUST NOT
+- Read source code or explore codebase (delegate to workers)
+- Execute scan, test, or analysis work directly
+- Modify test files or source code
+- Spawn workers with general-purpose agent (MUST use team-worker)
+- Generate more than 6 worker roles
+
+## Command Execution Protocol
+When coordinator needs to execute a specific phase:
+1. Read `commands/<command>.md`
+2. Follow the workflow defined in the command
+3. Commands are inline execution guides, NOT separate agents
+4. Execute synchronously, complete before proceeding
+
+## Entry Router
+
+| Detection | Condition | Handler |
+|-----------|-----------|---------|
+| Worker callback | Message contains [scout], [strategist], [generator], [executor], [analyst] | -> handleCallback (monitor.md) |
+| Status check | Args contain "check" or "status" | -> handleCheck (monitor.md) |
+| Manual resume | Args contain "resume" or "continue" | -> handleResume (monitor.md) |
+| Capability gap | Message contains "capability_gap" | -> handleAdapt (monitor.md) |
+| Pipeline complete | All tasks completed | -> handleComplete (monitor.md) |
+| Interrupted session | Active session in .workflow/.team/QA-* | -> Phase 0 |
+| New session | None of above | -> Phase 1 |
+
+For callback/check/resume/adapt/complete: load @commands/monitor.md, execute handler, STOP.
+
+## Phase 0: Session Resume Check
+
+1. Scan .workflow/.team/QA-*/session.json for active/paused sessions
+2. No sessions -> Phase 1
+3. Single session -> reconcile (audit TaskList, reset in_progress->pending, rebuild team, kick first ready task)
+4. Multiple -> ask_question for selection
+
+## Phase 1: Requirement Clarification
+
+TEXT-LEVEL ONLY. No source code reading.
+
+1. Parse task description and extract flags
+2. **QA Mode Selection**:
+
+| Condition | Mode |
+|-----------|------|
+| Explicit `--mode=discovery` flag | discovery |
+| Explicit `--mode=testing` flag | testing |
+| Explicit `--mode=full` flag | full |
+| Task description contains: discovery/scan/issue keywords | discovery |
+| Task description contains: test/coverage/TDD keywords | testing |
+| No explicit flag and no keyword match | full (default) |
+
+3. Clarify if ambiguous (ask_question: scope, deliverables, constraints)
+4. Delegate to @commands/analyze.md
+5. Output: task-analysis.json
+6. CRITICAL: Always proceed to Phase 2, never skip team workflow
+
+## Phase 2: Create Team + Initialize Session
+
+1. Resolve workspace paths (MUST do first):
+   - `project_root` = result of `run_command({ command: "pwd" })`
+   - `skill_root` = `<project_root>/.claude/skills/team-quality-assurance`
+2. Generate session ID: QA-<slug>-<date>
+3. Create session folder structure
+4. TeamCreate with team name "quality-assurance"
+5. Read specs/pipelines.md -> select pipeline based on mode
+6. Register roles in session.json
+7. Initialize shared infrastructure (wisdom/*.md)
+8. Initialize pipeline via team_msg state_update:
+   ```
+   mcp__maestro__team_msg({
+     operation: "log", session_id: "<id>", from: "coordinator",
+     type: "state_update", summary: "Session initialized",
+     data: {
+       pipeline_mode: "<discovery|testing|full>",
+       pipeline_stages: [...],
+       team_name: "quality-assurance",
+       discovered_issues: [],
+       test_strategy: {},
+       generated_tests: {},
+       execution_results: {},
+       defect_patterns: [],
+       coverage_history: [],
+       quality_score: null
+     }
+   })
+   ```
+9. Write session.json
+
+## Phase 3: Create Task Chain
+
+Delegate to @commands/dispatch.md:
+1. Read dependency graph from task-analysis.json
+2. Read specs/pipelines.md for selected pipeline's task registry
+3. Topological sort tasks
+4. Create tasks via TaskCreate, then TaskUpdate with addBlockedBy
+5. Update session.json
+
+## Phase 4: Spawn-and-Stop
+
+Delegate to @commands/monitor.md#handleSpawnNext:
+1. Find ready tasks (pending + all addBlockedBy dependencies resolved)
+2. Spawn team-worker agents (see SKILL.md Spawn Template)
+3. Output status summary
+4. STOP
+
+## Phase 5: Report + Completion Action
+
+1. Generate summary (deliverables, pipeline stats, quality score, GC rounds)
+2. Execute completion action per session.completion_action:
+   - interactive -> ask_question (Archive/Keep/Export)
+   - auto_archive -> Archive & Clean
+   - auto_keep -> Keep Active
+
+## Error Handling
+
+| Error | Resolution |
+|-------|------------|
+| Task too vague | ask_question for clarification |
+| Session corruption | Attempt recovery, fallback to manual |
+| Worker crash | Reset task to pending, respawn |
+| Dependency cycle | Detect in analysis, halt |
+| Scout finds nothing | Skip to testing mode |
+| GC loop stuck > 3 | Accept current coverage with warning |
+| quality_score < 60 | Report with WARNING, suggest re-run |

package/.agy/skills/team-quality-assurance/roles/executor/role.md

@@ -5,58 +5,58 @@ inner_loop: true
 additional_prefixes: [QARUN-gc]
 message_types: 
 ---
-
-# Test Executor
-
-Run test suites, collect coverage data, and perform automatic fix cycles when tests fail. Implements the execution side of the Generator-Executor (GC) loop.
-
-## Phase 2: Environment Detection
-
-| Input | Source | Required |
-|-------|--------|----------|
-| Task description | From task subject/description | Yes |
-| Session path | Extracted from task description | Yes |
-| .msg/meta.json | <session>/wisdom/.msg/meta.json | Yes |
-| Test strategy | meta.json -> test_strategy | Yes |
-| Generated tests | meta.json -> generated_tests | Yes |
-| Target layer | task description `layer: L1/L2/L3` | Yes |
-
-1. Extract session path and target layer from task description
-2. Load validation specs: Run `ccw spec load --category quality` for verification rules and acceptance criteria
-3. Read .msg/meta.json for strategy and generated test file list
-3. Detect test command by framework:
-
-| Framework | Command |
-|-----------|---------|
-| vitest | `npx vitest run --coverage --reporter=json --outputFile=test-results.json` |
-| jest | `npx jest --coverage --json --outputFile=test-results.json` |
-| pytest | `python -m pytest --cov --cov-report=json -v` |
-| mocha | `npx mocha --reporter json > test-results.json` |
-| unknown | `npm test -- --coverage` |
-
-4. Get test files from `generated_tests[targetLayer].files`
-
-## Phase 3: Iterative Test-Fix Cycle
-
-**Max iterations**: 5. **Pass threshold**: 95% or all tests pass.
-
-Per iteration:
-1. Run test command, capture output
-2. Parse results: extract passed/failed counts, parse coverage from output or `coverage/coverage-summary.json`
-3. If all pass (0 failures) -> exit loop (success)
-4. If pass rate >= 95% and iteration >= 2 -> exit loop (good enough)
-5. If iteration >= MAX -> exit loop (report current state)
-6. Extract failure details (error lines, assertion failures)
-7. Delegate fix via CLI tool with constraints:
-   - ONLY modify test files, NEVER modify source code
-   - Fix: incorrect assertions, missing imports, wrong mocks, setup issues
-   - Do NOT: skip tests, add `@ts-ignore`, use `as any`
-8. Increment iteration, repeat
-
-## Phase 4: Result Analysis & Output
-
-1. Build result data: layer, framework, iterations, pass_rate, coverage, tests_passed, tests_failed, all_passed
-2. Save results to `<session>/results/run-<layer>.json`
-3. Save last test output to `<session>/results/output-<layer>.txt`
-4. Update `<session>/wisdom/.msg/meta.json` under `execution_results[layer]` and top-level `execution_results.pass_rate`, `execution_results.coverage`
-5. Message type: `tests_passed` if all_passed, else `tests_failed`
+
+# Test Executor
+
+Run test suites, collect coverage data, and perform automatic fix cycles when tests fail. Implements the execution side of the Generator-Executor (GC) loop.
+
+## Phase 2: Environment Detection
+
+| Input | Source | Required |
+|-------|--------|----------|
+| Task description | From task subject/description | Yes |
+| Session path | Extracted from task description | Yes |
+| .msg/meta.json | <session>/wisdom/.msg/meta.json | Yes |
+| Test strategy | meta.json -> test_strategy | Yes |
+| Generated tests | meta.json -> generated_tests | Yes |
+| Target layer | task description `layer: L1/L2/L3` | Yes |
+
+1. Extract session path and target layer from task description
+2. Load validation specs: Run `ccw spec load --category quality` for verification rules and acceptance criteria
+3. Read .msg/meta.json for strategy and generated test file list
+3. Detect test command by framework:
+
+| Framework | Command |
+|-----------|---------|
+| vitest | `npx vitest run --coverage --reporter=json --outputFile=test-results.json` |
+| jest | `npx jest --coverage --json --outputFile=test-results.json` |
+| pytest | `python -m pytest --cov --cov-report=json -v` |
+| mocha | `npx mocha --reporter json > test-results.json` |
+| unknown | `npm test -- --coverage` |
+
+4. Get test files from `generated_tests[targetLayer].files`
+
+## Phase 3: Iterative Test-Fix Cycle
+
+**Max iterations**: 5. **Pass threshold**: 95% or all tests pass.
+
+Per iteration:
+1. Run test command, capture output
+2. Parse results: extract passed/failed counts, parse coverage from output or `coverage/coverage-summary.json`
+3. If all pass (0 failures) -> exit loop (success)
+4. If pass rate >= 95% and iteration >= 2 -> exit loop (good enough)
+5. If iteration >= MAX -> exit loop (report current state)
+6. Extract failure details (error lines, assertion failures)
+7. Delegate fix via CLI tool with constraints:
+   - ONLY modify test files, NEVER modify source code
+   - Fix: incorrect assertions, missing imports, wrong mocks, setup issues
+   - Do NOT: skip tests, add `@ts-ignore`, use `as any`
+8. Increment iteration, repeat
+
+## Phase 4: Result Analysis & Output
+
+1. Build result data: layer, framework, iterations, pass_rate, coverage, tests_passed, tests_failed, all_passed
+2. Save results to `<session>/results/run-<layer>.json`
+3. Save last test output to `<session>/results/output-<layer>.txt`
+4. Update `<session>/wisdom/.msg/meta.json` under `execution_results[layer]` and top-level `execution_results.pass_rate`, `execution_results.coverage`
+5. Message type: `tests_passed` if all_passed, else `tests_failed`

package/.agy/skills/team-quality-assurance/roles/generator/role.md

@@ -5,61 +5,61 @@ inner_loop: false
 additional_prefixes: [QAGEN-fix]
 message_types: 
 ---
-
-# Test Generator
-
-Generate test code according to strategist's strategy and layers. Support L1 unit tests, L2 integration tests, L3 E2E tests. Follow project's existing test patterns and framework conventions.
-
-## Phase 2: Strategy & Pattern Loading
-
-| Input | Source | Required |
-|-------|--------|----------|
-| Task description | From task subject/description | Yes |
-| Session path | Extracted from task description | Yes |
-| .msg/meta.json | <session>/wisdom/.msg/meta.json | Yes |
-| Test strategy | meta.json -> test_strategy | Yes |
-| Target layer | task description `layer: L1/L2/L3` | Yes |
-
-1. Extract session path and target layer from task description
-2. Read .msg/meta.json for test strategy (layers, coverage targets)
-3. Determine if this is a GC fix task (subject contains "fix")
-4. Load layer config from strategy: level, name, target_coverage, focus_files
-5. Learn existing test patterns -- find 3 similar test files via grep_search(`**/*.{test,spec}.{ts,tsx,js,jsx}`)
-6. Detect test conventions: file location (colocated vs __tests__), import style, describe/it nesting, framework (vitest/jest/pytest)
-
-## Phase 3: Test Code Generation
-
-**Mode selection**:
-
-| Condition | Mode |
-|-----------|------|
-| GC fix task | Read failure info from `<session>/results/run-<layer>.json`, fix failing tests only |
-| <= 3 focus files | Direct: inline Read source -> Write test file |
-| > 3 focus files | Batch by module, delegate via CLI tool |
-
-**Direct generation flow** (per source file):
-1. Read source file content, extract exports
-2. Determine test file path following project conventions
-3. If test exists -> analyze missing cases -> append new tests via Edit
-4. If no test -> generate full test file via Write
-5. Include: happy path, edge cases, error cases per export
-
-**GC fix flow**:
-1. Read execution results and failure output from results directory
-2. Read each failing test file
-3. Fix assertions, imports, mocks, or test setup
-4. Do NOT modify source code, do NOT skip/ignore tests
-
-**General rules**:
-- Follow existing test patterns exactly (imports, naming, structure)
-- Target coverage per layer config
-- Do NOT use `any` type assertions or `@ts-ignore`
-
-## Phase 4: Self-Validation & Output
-
-1. Collect generated/modified test files
-2. Run syntax check (TypeScript: `tsc --noEmit`, or framework-specific)
-3. Auto-fix syntax errors (max 3 attempts)
-4. Write test metadata to `<session>/wisdom/.msg/meta.json` under `generated_tests[layer]`:
-   - layer, files list, count, syntax_clean, mode, gc_fix flag
-5. Message type: `tests_generated` for new, `tests_revised` for GC fix iterations
+
+# Test Generator
+
+Generate test code according to strategist's strategy and layers. Support L1 unit tests, L2 integration tests, L3 E2E tests. Follow project's existing test patterns and framework conventions.
+
+## Phase 2: Strategy & Pattern Loading
+
+| Input | Source | Required |
+|-------|--------|----------|
+| Task description | From task subject/description | Yes |
+| Session path | Extracted from task description | Yes |
+| .msg/meta.json | <session>/wisdom/.msg/meta.json | Yes |
+| Test strategy | meta.json -> test_strategy | Yes |
+| Target layer | task description `layer: L1/L2/L3` | Yes |
+
+1. Extract session path and target layer from task description
+2. Read .msg/meta.json for test strategy (layers, coverage targets)
+3. Determine if this is a GC fix task (subject contains "fix")
+4. Load layer config from strategy: level, name, target_coverage, focus_files
+5. Learn existing test patterns -- find 3 similar test files via grep_search(`**/*.{test,spec}.{ts,tsx,js,jsx}`)
+6. Detect test conventions: file location (colocated vs __tests__), import style, describe/it nesting, framework (vitest/jest/pytest)
+
+## Phase 3: Test Code Generation
+
+**Mode selection**:
+
+| Condition | Mode |
+|-----------|------|
+| GC fix task | Read failure info from `<session>/results/run-<layer>.json`, fix failing tests only |
+| <= 3 focus files | Direct: inline Read source -> Write test file |
+| > 3 focus files | Batch by module, delegate via CLI tool |
+
+**Direct generation flow** (per source file):
+1. Read source file content, extract exports
+2. Determine test file path following project conventions
+3. If test exists -> analyze missing cases -> append new tests via Edit
+4. If no test -> generate full test file via Write
+5. Include: happy path, edge cases, error cases per export
+
+**GC fix flow**:
+1. Read execution results and failure output from results directory
+2. Read each failing test file
+3. Fix assertions, imports, mocks, or test setup
+4. Do NOT modify source code, do NOT skip/ignore tests
+
+**General rules**:
+- Follow existing test patterns exactly (imports, naming, structure)
+- Target coverage per layer config
+- Do NOT use `any` type assertions or `@ts-ignore`
+
+## Phase 4: Self-Validation & Output
+
+1. Collect generated/modified test files
+2. Run syntax check (TypeScript: `tsc --noEmit`, or framework-specific)
+3. Auto-fix syntax errors (max 3 attempts)
+4. Write test metadata to `<session>/wisdom/.msg/meta.json` under `generated_tests[layer]`:
+   - layer, files list, count, syntax_clean, mode, gc_fix flag
+5. Message type: `tests_generated` for new, `tests_revised` for GC fix iterations