ma-agents 3.6.2 → 3.9.0

package/test/extension-module-restructure.test.js

@@ -1,407 +0,0 @@
-#!/usr/bin/env node
-/**
- * Tests for extension module restructure (Story 15-2)
- *
- * Verifies:
- *   - module.yaml has all required fields for BMAD 6.2.0 conventions
- *   - skills/ directory exists with correct subdirectories
- *   - module-help.csv has entries for all skills
- *   - Old agents/ and workflows/ directories still exist (preserved for 15.3-15.6)
- */
-'use strict';
-
-const assert = require('assert');
-const path = require('path');
-const fs = require('fs');
-
-const PROJECT_ROOT = path.join(__dirname, '..');
-const EXTENSION_DIR = path.join(PROJECT_ROOT, 'lib', 'bmad-extension');
-
-let passed = 0;
-let failed = 0;
-const errors = [];
-
-function test(name, fn) {
-  try {
-    fn();
-    console.log(`  \u2713 ${name}`);
-    passed++;
-  } catch (err) {
-    console.error(`  \u2717 ${name}: ${err.message}`);
-    failed++;
-    errors.push({ name, error: err.message });
-  }
-}
-
-// ─── Helper: parse simple YAML (key: value pairs) ──────────────────────────
-function parseSimpleYaml(content) {
-  const result = {};
-  for (const line of content.split('\n')) {
-    const trimmed = line.trim();
-    if (!trimmed || trimmed.startsWith('#')) continue;
-    const colonIdx = trimmed.indexOf(':');
-    if (colonIdx === -1) continue;
-    const key = trimmed.slice(0, colonIdx).trim();
-    let val = trimmed.slice(colonIdx + 1).trim();
-    // Strip surrounding quotes
-    if ((val.startsWith('"') && val.endsWith('"')) || (val.startsWith("'") && val.endsWith("'"))) {
-      val = val.slice(1, -1);
-    }
-    result[key] = val;
-  }
-  return result;
-}
-
-// ─── Helper: parse CSV ──────────────────────────────────────────────────────
-function parseCsv(content) {
-  const lines = content.trim().split('\n').filter(l => l.trim());
-  if (lines.length === 0) return { headers: [], rows: [] };
-  const headers = lines[0].split(',').map(h => h.trim());
-  const rows = lines.slice(1).map(line => {
-    // Handle quoted fields with commas
-    const fields = [];
-    let current = '';
-    let inQuotes = false;
-    for (const ch of line) {
-      if (ch === '"') {
-        inQuotes = !inQuotes;
-      } else if (ch === ',' && !inQuotes) {
-        fields.push(current.trim());
-        current = '';
-      } else {
-        current += ch;
-      }
-    }
-    fields.push(current.trim());
-    return fields;
-  });
-  return { headers, rows };
-}
-
-// ═══════════════════════════════════════════════════════════════════════════════
-//  Task 1: module.yaml validation
-// ═══════════════════════════════════════════════════════════════════════════════
-console.log('\n--- Task 1: module.yaml ---');
-
-const moduleYamlPath = path.join(EXTENSION_DIR, 'module.yaml');
-
-test('module.yaml file exists', () => {
-  assert.ok(fs.existsSync(moduleYamlPath), 'module.yaml must exist');
-});
-
-let moduleYaml = {};
-test('module.yaml is parseable', () => {
-  const content = fs.readFileSync(moduleYamlPath, 'utf8');
-  moduleYaml = parseSimpleYaml(content);
-  assert.ok(Object.keys(moduleYaml).length > 0, 'module.yaml must have fields');
-});
-
-test('module.yaml has code: ma-skills', () => {
-  assert.strictEqual(moduleYaml.code, 'ma-skills', 'code field must be ma-skills');
-});
-
-test('module.yaml has name field', () => {
-  assert.ok(moduleYaml.name, 'name field must be present');
-  assert.strictEqual(moduleYaml.name, 'MA-Agents Skills & Agents');
-});
-
-test('module.yaml has description field', () => {
-  assert.ok(moduleYaml.description, 'description field must be present');
-  assert.strictEqual(
-    moduleYaml.description,
-    'Enterprise methodology enforcement, specialized agents, and operational workflows'
-  );
-});
-
-test('module.yaml has extends-module: bmm', () => {
-  assert.strictEqual(moduleYaml['extends-module'], 'bmm', 'extends-module must be bmm');
-});
-
-test('module.yaml has default_selected: false', () => {
-  assert.strictEqual(moduleYaml['default_selected'], 'false', 'default_selected must be false');
-});
-
-// ═══════════════════════════════════════════════════════════════════════════════
-//  Task 2: skills/ directory structure
-// ═══════════════════════════════════════════════════════════════════════════════
-console.log('\n--- Task 2: skills/ directory ---');
-
-const skillsDir = path.join(EXTENSION_DIR, 'skills');
-
-test('skills/ directory exists', () => {
-  assert.ok(fs.existsSync(skillsDir), 'skills/ directory must exist');
-  assert.ok(fs.statSync(skillsDir).isDirectory(), 'skills/ must be a directory');
-});
-
-// Expected skill directories based on ACTUAL file inventory
-const expectedAgentSkills = [
-  'bmad-ma-agent-sre',
-  'bmad-ma-agent-devops',
-  'bmad-ma-agent-cyber',
-  'bmad-ma-agent-ml',
-  'bmad-ma-agent-sqa',
-  // Note: bmad-ma-agent-mil498 retired — MIL-STD-498 workflows absorbed into Gad (bmad-ma-agent-sqa)
-];
-
-const expectedSqaSkills = [
-  'sqa-audit',
-  'sqa-ieee12207',
-  'sqa-requirements-quality',
-];
-
-const expectedMil498Skills = [
-  'mil498-sss', 'mil498-ssdd', 'mil498-ocd', 'mil498-sdp',
-  'mil498-srs', 'mil498-sdd', 'mil498-std', 'mil498-requirement-quality',
-];
-
-const expectedSreSkills = [
-  'sre-check-deployment-status', 'sre-check-secrets', 'sre-check-system-status',
-  'sre-day-2-ops', 'sre-deployment-strategies', 'sre-fix-deployments',
-  'sre-gitops-status',
-];
-
-const expectedDevopsSkills = [
-  'devops-configure-infrastructure', 'devops-disconnected-deployment',
-  'devops-docker-compose-setup', 'devops-manage-helm', 'devops-sign-docker-image',
-];
-
-const expectedCyberSkills = [
-  'cyber-generate-certs', 'cyber-immunity-estimation', 'cyber-security-audit',
-  'cyber-vault-secrets', 'cyber-verify-docker-users', 'cyber-verify-image-signature',
-  'cyber-vulnerability-scan',
-];
-
-const expectedExtensionSkills = [
-  'create-bug-story', 'bmad-dev-story', 'add-sprint', 'modify-sprint',
-  'add-to-sprint', 'project-context-expansion', 'sprint-status-view',
-  'cleanup-done', 'generate-backlog', 'prioritize-backlog', 'remove-from-sprint',
-  'bmad-sprint-planning', 'bmad-sprint-status', 'close-sprint',
-];
-
-const expectedMlSkills = [
-  'ml-ideation', 'ml-eda', 'ml-architecture', 'ml-detailed-design',
-  'ml-techspec', 'ml-infra', 'ml-experiment', 'ml-analysis',
-  'ml-hparam', 'ml-revision', 'ml-advise', 'ml-retrospective',
-];
-
-const allExpectedSkills = [
-  ...expectedAgentSkills,
-  ...expectedMil498Skills,
-  ...expectedSreSkills,
-  ...expectedDevopsSkills,
-  ...expectedCyberSkills,
-  ...expectedExtensionSkills,
-  ...expectedMlSkills,
-  ...expectedSqaSkills,
-];
-
-test('skills/ has exactly 61 subdirectories', () => {
-  const entries = fs.readdirSync(skillsDir).filter(e =>
-    fs.statSync(path.join(skillsDir, e)).isDirectory()
-  );
-  assert.strictEqual(entries.length, 61, `Expected 61 skill dirs, found ${entries.length}`);
-});
-
-test('all 5 agent skill directories exist', () => {
-  for (const skill of expectedAgentSkills) {
-    const p = path.join(skillsDir, skill);
-    assert.ok(fs.existsSync(p), `Missing agent skill dir: ${skill}`);
-  }
-});
-
-test('all 8 MIL-498 skill directories exist', () => {
-  for (const skill of expectedMil498Skills) {
-    const p = path.join(skillsDir, skill);
-    assert.ok(fs.existsSync(p), `Missing MIL-498 skill dir: ${skill}`);
-  }
-});
-
-test('all 7 SRE skill directories exist', () => {
-  for (const skill of expectedSreSkills) {
-    const p = path.join(skillsDir, skill);
-    assert.ok(fs.existsSync(p), `Missing SRE skill dir: ${skill}`);
-  }
-});
-
-test('all 5 DevOps skill directories exist', () => {
-  for (const skill of expectedDevopsSkills) {
-    const p = path.join(skillsDir, skill);
-    assert.ok(fs.existsSync(p), `Missing DevOps skill dir: ${skill}`);
-  }
-});
-
-test('all 7 Cyber skill directories exist', () => {
-  for (const skill of expectedCyberSkills) {
-    const p = path.join(skillsDir, skill);
-    assert.ok(fs.existsSync(p), `Missing Cyber skill dir: ${skill}`);
-  }
-});
-
-test('all 12 ML skill directories exist', () => {
-  for (const skill of expectedMlSkills) {
-    const p = path.join(skillsDir, skill);
-    assert.ok(fs.existsSync(p), `Missing ML skill dir: ${skill}`);
-  }
-});
-
-test('all 14 extension workflow skill directories exist', () => {
-  for (const skill of expectedExtensionSkills) {
-    const p = path.join(skillsDir, skill);
-    assert.ok(fs.existsSync(p), `Missing extension skill dir: ${skill}`);
-  }
-});
-
-test('all 3 SQA skill directories exist', () => {
-  for (const skill of expectedSqaSkills) {
-    const p = path.join(skillsDir, skill);
-    assert.ok(fs.existsSync(p), `Missing SQA skill dir: ${skill}`);
-  }
-});
-
-test('every skill directory contains a .gitkeep file', () => {
-  for (const skill of allExpectedSkills) {
-    const gk = path.join(skillsDir, skill, '.gitkeep');
-    assert.ok(fs.existsSync(gk), `Missing .gitkeep in ${skill}`);
-  }
-});
-
-// ═══════════════════════════════════════════════════════════════════════════════
-//  Task 3: module-help.csv validation
-// ═══════════════════════════════════════════════════════════════════════════════
-console.log('\n--- Task 3: module-help.csv ---');
-
-const csvPath = path.join(EXTENSION_DIR, 'module-help.csv');
-
-test('module-help.csv exists', () => {
-  assert.ok(fs.existsSync(csvPath), 'module-help.csv must exist');
-});
-
-let csvData = { headers: [], rows: [] };
-test('module-help.csv is parseable', () => {
-  const content = fs.readFileSync(csvPath, 'utf8');
-  csvData = parseCsv(content);
-  assert.ok(csvData.headers.length > 0, 'CSV must have headers');
-  assert.ok(csvData.rows.length > 0, 'CSV must have data rows');
-});
-
-test('module-help.csv has correct header columns', () => {
-  const expected = ['module', 'phase', 'name', 'code'];
-  for (const col of expected) {
-    assert.ok(csvData.headers.includes(col), `Missing header column: ${col}`);
-  }
-});
-
-test('module-help.csv has 61 skill entries (excluding header)', () => {
-  assert.strictEqual(csvData.rows.length, 61, `Expected 61 rows, found ${csvData.rows.length}`);
-});
-
-test('all CSV entries use module code ma-skills', () => {
-  const moduleIdx = csvData.headers.indexOf('module');
-  for (const row of csvData.rows) {
-    assert.strictEqual(row[moduleIdx], 'ma-skills', `Row has wrong module: ${row[moduleIdx]}`);
-  }
-});
-
-test('CSV has entries for all 6 agent skills', () => {
-  const codeIdx = csvData.headers.indexOf('code');
-  const codes = csvData.rows.map(r => r[codeIdx]);
-  for (const skill of expectedAgentSkills) {
-    assert.ok(codes.includes(skill), `Missing CSV entry for agent skill: ${skill}`);
-  }
-});
-
-test('CSV has entries for all 3 SQA skills', () => {
-  const codeIdx = csvData.headers.indexOf('code');
-  const codes = csvData.rows.map(r => r[codeIdx]);
-  for (const skill of expectedSqaSkills) {
-    assert.ok(codes.includes(skill), `Missing CSV entry for SQA skill: ${skill}`);
-  }
-});
-
-test('CSV has entries for all 8 MIL-498 skills', () => {
-  const codeIdx = csvData.headers.indexOf('code');
-  const codes = csvData.rows.map(r => r[codeIdx]);
-  for (const skill of expectedMil498Skills) {
-    assert.ok(codes.includes(skill), `Missing CSV entry for MIL-498 skill: ${skill}`);
-  }
-});
-
-test('CSV has entries for all 7 SRE skills', () => {
-  const codeIdx = csvData.headers.indexOf('code');
-  const codes = csvData.rows.map(r => r[codeIdx]);
-  for (const skill of expectedSreSkills) {
-    assert.ok(codes.includes(skill), `Missing CSV entry for SRE skill: ${skill}`);
-  }
-});
-
-test('CSV has entries for all 5 DevOps skills', () => {
-  const codeIdx = csvData.headers.indexOf('code');
-  const codes = csvData.rows.map(r => r[codeIdx]);
-  for (const skill of expectedDevopsSkills) {
-    assert.ok(codes.includes(skill), `Missing CSV entry for DevOps skill: ${skill}`);
-  }
-});
-
-test('CSV has entries for all 7 Cyber skills', () => {
-  const codeIdx = csvData.headers.indexOf('code');
-  const codes = csvData.rows.map(r => r[codeIdx]);
-  for (const skill of expectedCyberSkills) {
-    assert.ok(codes.includes(skill), `Missing CSV entry for Cyber skill: ${skill}`);
-  }
-});
-
-test('CSV has entries for all 14 extension workflow skills', () => {
-  const codeIdx = csvData.headers.indexOf('code');
-  const codes = csvData.rows.map(r => r[codeIdx]);
-  for (const skill of expectedExtensionSkills) {
-    assert.ok(codes.includes(skill), `Missing CSV entry for extension skill: ${skill}`);
-  }
-});
-
-test('CSV has entries for all 12 ML skills', () => {
-  const codeIdx = csvData.headers.indexOf('code');
-  const codes = csvData.rows.map(r => r[codeIdx]);
-  for (const skill of expectedMlSkills) {
-    assert.ok(codes.includes(skill), `Missing CSV entry for ML skill: ${skill}`);
-  }
-});
-
-// ═══════════════════════════════════════════════════════════════════════════════
-//  Task 4: Directory state after Story 15.6 migration
-// ═══════════════════════════════════════════════════════════════════════════════
-console.log('\n--- Task 4: Directory state after Story 15.6 ---');
-
-test('agents/ directory is empty or absent (Story 15.6 moved files to bmad-customize/)', () => {
-  const agentsDir = path.join(EXTENSION_DIR, 'agents');
-  if (fs.existsSync(agentsDir)) {
-    const files = fs.readdirSync(agentsDir).filter(f => f.endsWith('.customize.yaml'));
-    assert.strictEqual(files.length, 0, `agents/ must have 0 .customize.yaml files after 15.6, found ${files.length}`);
-  }
-  // If directory doesn't exist, that's also correct
-});
-
-test('workflows/ directory still exists', () => {
-  const workflowsDir = path.join(EXTENSION_DIR, 'workflows');
-  assert.ok(fs.existsSync(workflowsDir), 'workflows/ directory must be preserved');
-  assert.ok(fs.statSync(workflowsDir).isDirectory(), 'workflows/ must be a directory');
-});
-
-test('workflows/ directory contains workflow subdirs', () => {
-  const workflowsDir = path.join(EXTENSION_DIR, 'workflows');
-  const dirs = fs.readdirSync(workflowsDir).filter(e =>
-    fs.statSync(path.join(workflowsDir, e)).isDirectory()
-  );
-  assert.ok(dirs.length >= 6, `Expected at least 6 workflow dirs, found ${dirs.length}`);
-});
-
-// ═══════════════════════════════════════════════════════════════════════════════
-//  Summary
-// ═══════════════════════════════════════════════════════════════════════════════
-console.log(`\n--- Results: ${passed} passed, ${failed} failed ---`);
-if (errors.length > 0) {
-  console.error('\nFailures:');
-  for (const { name, error } of errors) {
-    console.error(`  ${name}: ${error}`);
-  }
-}
-process.exit(failed > 0 ? 1 : 0);

package/test/fixtures/README.md

@@ -1,74 +0,0 @@
-# Test Fixtures — Epic 21 End-to-End Installer Harness
-
-This directory holds the fixtures used by the Epic 21 Story 21.9 end-to-end installer test. They give the harness a stable, byte-for-byte reference point for what `npx ma-agents install` produces for each profile.
-
-## Layout
-
-- `empty-project/` — canonical seed project (README + minimal package.json). Copied to a scratch tmpdir by the harness before each install run. **Do not edit casually.** Changes here affect generated output and must be paired with baseline regeneration.
-- `standard-profile-baseline/` — expected byte-for-byte output of `npx ma-agents install --yes` (standard profile) run against `empty-project/`. Populated by Story 21.9 via the regeneration procedure below.
-- `onprem-profile-baseline/` — same, but with `"profile": "on-prem"` persisted in `.ma-agents.json` before install. Populated by Story 21.9.
-
-## When to regenerate
-
-Regenerate the baselines **only** when the installer or a template has intentionally changed. Examples:
-- Story 21.2 landing changes the universal instruction block content → regenerate both baselines.
-- Story 21.6 landing adds on-prem content → regenerate `onprem-profile-baseline/`.
-- Story 21.3 landing adds `.roomodes` → both baselines.
-- Story 21.11 landing does NOT require baseline changes (uninstall is a separate test).
-
-**A regression is when the baselines diverge from installer output unintentionally.** Never regenerate to "make the test pass" — diagnose the diff first.
-
-## Regeneration procedure
-
-From a clean repo checkout:
-
-```bash
-# 1. Copy the seed to a scratch tmpdir
-rm -rf /tmp/ma-agents-fixture-regen
-mkdir -p /tmp/ma-agents-fixture-regen
-cp -R test/fixtures/empty-project/* /tmp/ma-agents-fixture-regen/
-
-# 2. Standard profile install
-cd /tmp/ma-agents-fixture-regen
-node <repo>/bin/cli.js install --yes
-# (no --profile flag exists per P3-3 Alternatives Considered; standard is the --yes default)
-
-# 3. Copy generated output back to the repo
-rm -rf <repo>/test/fixtures/standard-profile-baseline/*
-cp -R /tmp/ma-agents-fixture-regen/* <repo>/test/fixtures/standard-profile-baseline/
-
-# 4. Clean + reseed for on-prem
-rm -rf /tmp/ma-agents-fixture-regen
-mkdir -p /tmp/ma-agents-fixture-regen
-cp -R <repo>/test/fixtures/empty-project/* /tmp/ma-agents-fixture-regen/
-# Pre-seed .ma-agents.json with profile=on-prem so --yes honors it (no CLI flag)
-echo '{"manifestVersion":"1.2.0","profile":"on-prem","skills":{}}' > /tmp/ma-agents-fixture-regen/.ma-agents.json
-
-# 5. On-prem install
-cd /tmp/ma-agents-fixture-regen
-node <repo>/bin/cli.js install --yes
-
-# 6. Copy back
-rm -rf <repo>/test/fixtures/onprem-profile-baseline/*
-cp -R /tmp/ma-agents-fixture-regen/* <repo>/test/fixtures/onprem-profile-baseline/
-
-# 7. Review the diff
-cd <repo>
-git diff --stat test/fixtures/
-git add test/fixtures/
-# Commit only after human review — never blindly regenerate
-```
-
-## What's excluded from baselines
-
-The harness must ignore these when diffing (they're volatile or environment-specific):
-- Timestamps in log files (if any are written — none expected today)
-- The `backup-<ISO-timestamp>` files produced by Story 21.2 AC #8 upgrade-safety and Story 21.10/21.11 backup steps (not generated on clean install, but listed here for completeness)
-- The `roomodesOverwriteLog` field's `date` values in `.ma-agents.json` (Story 21.3 AC #10 — the field is deterministic in shape but `date` will differ across runs; normalize to a fixed placeholder before diff)
-- The `profileHistory` field's `date` values (Story 21.10 AC #11 — same treatment)
-
-The harness implementation (Story 21.9 Task 5.2) is responsible for this normalization. This scaffolding PR does not implement it.
-
-## Relationship to Story 21.9
-
-See `_bmad-output/implementation-artifacts/21-9-tests-validation.md` ACs #5 and #6 (added 2026-04-14 in corrective-plan step 3). This scaffolding closes the "nothing concrete to build against" gap flagged in adversarial-review Finding #18.

package/test/fixtures/empty-project/README.md

@@ -1,5 +0,0 @@
-# Empty Project Seed (Test Fixture)
-
-This is the canonical empty-project fixture used by the Epic 21 Story 21.9 end-to-end installer test harness. It contains the minimum files an `npx ma-agents install` run expects at a project root: a `README.md` and a `package.json`. Nothing in this seed should affect what the installer generates.
-
-**Do not edit this seed casually.** Any change to its contents will change the byte-for-byte output of the installer and break the baseline fixtures in sibling directories. If the seed genuinely needs to change, follow the regeneration procedure in `test/fixtures/README.md`.

package/test/fixtures/empty-project/package.json

@@ -1,5 +0,0 @@
-{
-  "name": "empty-project-fixture",
-  "version": "0.0.0",
-  "private": true
-}

package/test/fixtures/onprem-profile-baseline/.gitkeep

@@ -1,2 +0,0 @@
-# Populated by Story 21.9 via the regeneration procedure in test/fixtures/README.md.
-# Empty until Story 21.9 implementation lands — the harness treats this as "fixtures not yet captured" and skips byte-for-byte diffing.

package/test/fixtures/standard-profile-baseline/.gitkeep

@@ -1,2 +0,0 @@
-# Populated by Story 21.9 via the regeneration procedure in test/fixtures/README.md.
-# Empty until Story 21.9 implementation lands — the harness treats this as "fixtures not yet captured" and skips byte-for-byte diffing.