ma-agents 3.6.2 → 3.9.0

package/test/create-agent.test.js

@@ -1,232 +0,0 @@
-#!/usr/bin/env node
-/**
- * Tests for create-agent command implementation
- * Story 3.5: Specialized Agent Development Tooling
- *
- * Task 6.1: create-agent bmm-test-role runs and creates scaffold file
- * Task 6.2: Duplicate agent rejected with error
- * Task 6.3: Auto-prefix bmm- if missing
- * Task 6.4: Generated YAML is valid structure
- */
-'use strict';
-
-const assert = require('assert');
-const { spawnSync } = require('child_process');
-const path = require('path');
-const fs = require('fs');
-const os = require('os');
-
-const CLI_PATH = path.join(__dirname, '..', 'bin', 'cli.js');
-const PROJECT_ROOT = path.join(__dirname, '..');
-const AGENTS_DIR = path.join(PROJECT_ROOT, 'lib', 'bmad-extension', 'agents');
-
-let passed = 0;
-let failed = 0;
-const errors = [];
-
-function test(name, fn) {
-  try {
-    fn();
-    console.log(`  ✓ ${name}`);
-    passed++;
-  } catch (err) {
-    console.error(`  ✗ ${name}: ${err.message}`);
-    failed++; errors.push({ name, error: err.message });
-  }
-}
-
-// ─── Module imports ──────────────────────────────────────────────────────────
-let validateAgentName, createBmadAgent;
-try {
-  ({ validateAgentName, createBmadAgent } = require('../lib/skill-authoring'));
-} catch (e) {
-  console.error('\n  FATAL: Cannot load skill-authoring module');
-  console.error(' ', e.message);
-  process.exit(1);
-}
-
-// ─── Unit tests: validateAgentName() ─────────────────────────────────────────
-console.log('\n validateAgentName unit tests\n');
-
-test('validates bmm-prefixed kebab-case name', () => {
-  const result = validateAgentName('bmm-test-role');
-  assert.strictEqual(result.valid, true);
-  assert.strictEqual(result.name, 'bmm-test-role');
-  assert.strictEqual(result.normalized, false);
-});
-
-test('auto-prefixes bmm- if missing', () => {
-  const result = validateAgentName('test-role');
-  assert.strictEqual(result.valid, true);
-  assert.strictEqual(result.name, 'bmm-test-role');
-  assert.strictEqual(result.normalized, true);
-});
-
-test('rejects empty name', () => {
-  const result = validateAgentName('');
-  assert.strictEqual(result.valid, false);
-  assert.ok(result.error.length > 0);
-});
-
-test('rejects uppercase in name', () => {
-  const result = validateAgentName('bmm-TEST-role');
-  assert.strictEqual(result.valid, false);
-});
-
-test('rejects name ending with hyphen', () => {
-  const result = validateAgentName('bmm-test-');
-  assert.strictEqual(result.valid, false);
-});
-
-test('rejects existing builtin agent name', () => {
-  const result = validateAgentName('bmm-pm');
-  assert.strictEqual(result.valid, false);
-  assert.ok(result.error.includes('already exists') || result.hint);
-});
-
-test('rejects existing custom agent name', () => {
-  const result = validateAgentName('bmm-sre');
-  assert.strictEqual(result.valid, false);
-});
-
-// ─── Unit tests: createBmadAgent() ───────────────────────────────────────────
-console.log('\n createBmadAgent unit tests\n');
-
-test('createBmadAgent: creates .customize.yaml in agentsDir', () => {
-  const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'ma-create-agent-'));
-  try {
-    const result = createBmadAgent('bmm-test-role', tmpDir);
-    assert.strictEqual(result.success, true, `Expected success: ${result.error}`);
-    const filePath = path.join(tmpDir, 'bmm-test-role.customize.yaml');
-    assert.ok(fs.existsSync(filePath), 'Expected file to be created');
-  } finally {
-    fs.rmSync(tmpDir, { recursive: true, force: true });
-  }
-});
-
-test('createBmadAgent: generated file includes persona section', () => {
-  const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'ma-create-agent-'));
-  try {
-    createBmadAgent('bmm-test-role', tmpDir);
-    const content = fs.readFileSync(path.join(tmpDir, 'bmm-test-role.customize.yaml'), 'utf8');
-    assert.ok(content.includes('persona:'), 'Expected persona section');
-    assert.ok(content.includes('role:'), 'Expected role field');
-  } finally {
-    fs.rmSync(tmpDir, { recursive: true, force: true });
-  }
-});
-
-test('createBmadAgent: generated file includes menu section', () => {
-  const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'ma-create-agent-'));
-  try {
-    createBmadAgent('bmm-test-role', tmpDir);
-    const content = fs.readFileSync(path.join(tmpDir, 'bmm-test-role.customize.yaml'), 'utf8');
-    assert.ok(content.includes('menu:'), 'Expected menu section');
-  } finally {
-    fs.rmSync(tmpDir, { recursive: true, force: true });
-  }
-});
-
-test('createBmadAgent: generated file includes mandatory critical_actions 1-3', () => {
-  const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'ma-create-agent-'));
-  try {
-    createBmadAgent('bmm-test-role', tmpDir);
-    const content = fs.readFileSync(path.join(tmpDir, 'bmm-test-role.customize.yaml'), 'utf8');
-    assert.ok(content.includes('critical_actions:'), 'Expected critical_actions section');
-    assert.ok(content.includes('MANIFEST'), 'Expected MANIFEST reference');
-    assert.ok(content.includes('always_load'), 'Expected always_load reference');
-    assert.ok(content.includes('Follow all skill directives'), 'Expected action 3');
-  } finally {
-    fs.rmSync(tmpDir, { recursive: true, force: true });
-  }
-});
-
-test('createBmadAgent: returns error for duplicate file', () => {
-  const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'ma-create-agent-'));
-  try {
-    createBmadAgent('bmm-test-role', tmpDir);
-    const result = createBmadAgent('bmm-test-role', tmpDir);
-    assert.strictEqual(result.success, false);
-    assert.ok(result.error.length > 0, 'Expected error message');
-    assert.ok(result.hint.length > 0, 'Expected hint message');
-  } finally {
-    fs.rmSync(tmpDir, { recursive: true, force: true });
-  }
-});
-
-test('createBmadAgent: error and hint are label-free data', () => {
-  const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'ma-create-agent-'));
-  try {
-    createBmadAgent('bmm-test-role', tmpDir);
-    const result = createBmadAgent('bmm-test-role', tmpDir);
-    assert.ok(!result.error.startsWith('Error:'), 'error field must not include "Error:" prefix');
-    assert.ok(!result.hint.startsWith('Hint:'), 'hint field must not include "Hint:" prefix');
-  } finally {
-    fs.rmSync(tmpDir, { recursive: true, force: true });
-  }
-});
-
-// ─── CLI integration tests ────────────────────────────────────────────────────
-console.log('\n create-agent CLI integration tests\n');
-
-test('create-agent: no agent name exits 1', () => {
-  const result = spawnSync('node', [CLI_PATH, 'create-agent'], {
-    encoding: 'utf8', cwd: PROJECT_ROOT
-  });
-  assert.strictEqual(result.status, 1, 'Expected exit 1 for missing agent name');
-});
-
-test('create-agent: existing builtin agent exits 1 with error', () => {
-  const result = spawnSync('node', [CLI_PATH, 'create-agent', 'bmm-pm'], {
-    encoding: 'utf8', cwd: PROJECT_ROOT
-  });
-  assert.strictEqual(result.status, 1, 'Expected exit 1 for existing agent');
-  const output = result.stdout + result.stderr;
-  assert.ok(output.includes('Error') || output.includes('already exists'), 'Expected error message');
-});
-
-test('create-agent: invalid name (uppercase) exits 1', () => {
-  const result = spawnSync('node', [CLI_PATH, 'create-agent', 'bmm-TEST-role'], {
-    encoding: 'utf8', cwd: PROJECT_ROOT
-  });
-  assert.strictEqual(result.status, 1, 'Expected exit 1 for invalid name');
-});
-
-test('create-agent: --yes flag generates file with exit 0', () => {
-  // Use a unique test name to avoid conflicts
-  const testAgentName = `bmm-test-role-${Date.now()}`;
-  const result = spawnSync('node', [CLI_PATH, 'create-agent', testAgentName, '--yes'], {
-    encoding: 'utf8', cwd: PROJECT_ROOT, input: ''
-  });
-  assert.ok(result.status === 0 || result.status === null, `Expected exit 0, got: ${result.status}. stderr: ${result.stderr}`);
-  assert.ok(
-    result.stdout.includes('created') || result.stdout.includes('generated'),
-    `Expected success message: ${result.stdout}`
-  );
-  // Cleanup
-  const filePath = path.join(AGENTS_DIR, `${testAgentName}.customize.yaml`);
-  if (fs.existsSync(filePath)) fs.rmSync(filePath);
-});
-
-test('create-agent: auto-prefix bmm- and succeed', () => {
-  const testAgentName = `test-prefix-${Date.now()}`;
-  const normalizedName = `bmm-${testAgentName}`;
-  const result = spawnSync('node', [CLI_PATH, 'create-agent', testAgentName, '--yes'], {
-    encoding: 'utf8', cwd: PROJECT_ROOT, input: ''
-  });
-  assert.ok(result.status === 0 || result.status === null, `Expected exit 0, got: ${result.status}. stderr: ${result.stderr}`);
-  assert.ok(
-    result.stdout.includes('normalized') || result.stdout.includes(normalizedName) || result.stdout.includes('created'),
-    `Expected normalization or creation message: ${result.stdout}`
-  );
-  // Cleanup
-  const filePath = path.join(AGENTS_DIR, `${normalizedName}.customize.yaml`);
-  if (fs.existsSync(filePath)) fs.rmSync(filePath);
-});
-
-// ─── Results ──────────────────────────────────────────────────────────────────
-console.log(`\n  ${passed} passed, ${failed} failed\n`);
-if (failed > 0) {
-  errors.forEach(e => console.error(`  ✗ ${e.name}: ${e.error}`));
-  process.exit(1);
-}

package/test/cross-repo-validation.test.js

@@ -1,201 +0,0 @@
-#!/usr/bin/env node
-/**
- * Tests for Story 16.4: Validate Cross-Repo Path Resolution
- * Verifies config-driven path resolution and backward compatibility
- */
-'use strict';
-
-const assert = require('assert');
-const path = require('path');
-const fs = require('fs');
-const os = require('os');
-
-let passed = 0;
-let failed = 0;
-const errors = [];
-
-function test(name, fn) {
-  try {
-    fn();
-    console.log(`  \u2713 ${name}`);
-    passed++;
-  } catch (err) {
-    console.error(`  \u2717 ${name}: ${err.message}`);
-    failed++;
-    errors.push({ name, error: err.message });
-  }
-}
-
-let writeRepoLayoutConfig, writeConfigField;
-try {
-  ({ writeRepoLayoutConfig, writeConfigField } = require('../bin/cli.js'));
-} catch (e) {
-  console.error('\n  FATAL: Cannot load exports from cli.js');
-  console.error(' ', e.message);
-  process.exit(1);
-}
-
-// ─── Task 1: Audit verification ─────────────────────────────────────────────
-console.log('\nTask 1 — Workflow audit: no hardcoded _bmad-output/ paths');
-
-test('no workflow files contain hardcoded _bmad-output/', () => {
-  const bmadDir = path.join(__dirname, '..', '_bmad', 'bmm');
-  if (!fs.existsSync(bmadDir)) {
-    console.log('    SKIP: _bmad/bmm not found (BMAD not installed)');
-    return;
-  }
-
-  function scanDir(dir) {
-    const entries = fs.readdirSync(dir, { withFileTypes: true });
-    const results = [];
-    for (const entry of entries) {
-      const full = path.join(dir, entry.name);
-      if (entry.isDirectory()) {
-        results.push(...scanDir(full));
-      } else if ((entry.name.endsWith('.md') || entry.name.endsWith('.yaml')) && entry.name !== 'config.yaml') {
-        // Exclude config.yaml — it stores resolved path values, not hardcoded references
-        const content = fs.readFileSync(full, 'utf-8');
-        // Look for literal _bmad-output/ that isn't in a comment or template variable context
-        const lines = content.split('\n');
-        for (let i = 0; i < lines.length; i++) {
-          const line = lines[i];
-          if (line.includes('_bmad-output/') && !line.includes('{') && !line.includes('#')) {
-            results.push({ file: full, line: i + 1, content: line.trim() });
-          }
-        }
-      }
-    }
-    return results;
-  }
-
-  const hardcoded = scanDir(bmadDir);
-  assert.strictEqual(hardcoded.length, 0,
-    `Found ${hardcoded.length} hardcoded _bmad-output/ references:\n` +
-    hardcoded.map(h => `  ${h.file}:${h.line}: ${h.content}`).join('\n'));
-});
-
-// ─── Task 2: Config-driven path resolution ──────────────────────────────────
-console.log('\nTask 2 — Config writes planning_artifacts and implementation_artifacts');
-
-test('single-repo: writes default artifact paths', () => {
-  const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'ma-test-'));
-  const origCwd = process.cwd();
-  try {
-    process.chdir(tmpDir);
-    const configDir = path.join(tmpDir, '_bmad', 'bmm');
-    fs.mkdirSync(configDir, { recursive: true });
-    fs.writeFileSync(path.join(configDir, 'config.yaml'), '# config\n{}');
-    writeRepoLayoutConfig({
-      knowledgebase: { mode: 'same', path: '.' },
-      sprintManagement: { mode: 'same', path: '.' }
-    });
-    const content = fs.readFileSync(path.join(configDir, 'config.yaml'), 'utf-8');
-    assert.ok(content.includes('planning_artifacts: "_bmad-output/planning-artifacts"'),
-      `Expected default planning_artifacts. Got:\n${content}`);
-    assert.ok(content.includes('implementation_artifacts: "_bmad-output/implementation-artifacts"'),
-      `Expected default implementation_artifacts. Got:\n${content}`);
-  } finally {
-    process.chdir(origCwd);
-    fs.rmSync(tmpDir, { recursive: true, force: true });
-  }
-});
-
-test('multi-repo: writes external artifact paths', () => {
-  const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'ma-test-'));
-  const origCwd = process.cwd();
-  try {
-    process.chdir(tmpDir);
-    const configDir = path.join(tmpDir, '_bmad', 'bmm');
-    fs.mkdirSync(configDir, { recursive: true });
-    fs.writeFileSync(path.join(configDir, 'config.yaml'), '# config\n{}');
-    writeRepoLayoutConfig({
-      knowledgebase: { mode: 'local', path: 'd:\\Code\\kb-repo' },
-      sprintManagement: { mode: 'local', path: 'd:\\Code\\sprint-repo' }
-    });
-    const content = fs.readFileSync(path.join(configDir, 'config.yaml'), 'utf-8');
-    assert.ok(content.includes('planning_artifacts: "d:/Code/kb-repo/_bmad-output/planning-artifacts"'),
-      `Expected external planning_artifacts. Got:\n${content}`);
-    assert.ok(content.includes('implementation_artifacts: "d:/Code/sprint-repo/_bmad-output/implementation-artifacts"'),
-      `Expected external implementation_artifacts. Got:\n${content}`);
-  } finally {
-    process.chdir(origCwd);
-    fs.rmSync(tmpDir, { recursive: true, force: true });
-  }
-});
-
-test('mixed mode: kb external, sprint same', () => {
-  const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'ma-test-'));
-  const origCwd = process.cwd();
-  try {
-    process.chdir(tmpDir);
-    const configDir = path.join(tmpDir, '_bmad', 'bmm');
-    fs.mkdirSync(configDir, { recursive: true });
-    fs.writeFileSync(path.join(configDir, 'config.yaml'), '# config\n{}');
-    writeRepoLayoutConfig({
-      knowledgebase: { mode: 'local', path: '/ext/kb' },
-      sprintManagement: { mode: 'same', path: '.' }
-    });
-    const content = fs.readFileSync(path.join(configDir, 'config.yaml'), 'utf-8');
-    assert.ok(content.includes('planning_artifacts: "/ext/kb/_bmad-output/planning-artifacts"'),
-      `Got:\n${content}`);
-    assert.ok(content.includes('implementation_artifacts: "_bmad-output/implementation-artifacts"'),
-      `Got:\n${content}`);
-  } finally {
-    process.chdir(origCwd);
-    fs.rmSync(tmpDir, { recursive: true, force: true });
-  }
-});
-
-// ─── Task 3: Single-repo backward compatibility ─────────────────────────────
-console.log('\nTask 3 — Single-repo backward compatibility');
-
-test('single-repo config matches pre-Epic-16 defaults', () => {
-  const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'ma-test-'));
-  const origCwd = process.cwd();
-  try {
-    process.chdir(tmpDir);
-    const configDir = path.join(tmpDir, '_bmad', 'bmm');
-    fs.mkdirSync(configDir, { recursive: true });
-    fs.writeFileSync(path.join(configDir, 'config.yaml'), '{}');
-    writeRepoLayoutConfig({
-      knowledgebase: { mode: 'same', path: '.' },
-      sprintManagement: { mode: 'same', path: '.' }
-    });
-    const content = fs.readFileSync(path.join(configDir, 'config.yaml'), 'utf-8');
-    // These are the default relative paths that workflows used before Epic 16
-    assert.ok(content.includes('planning_artifacts: "_bmad-output/planning-artifacts"'));
-    assert.ok(content.includes('implementation_artifacts: "_bmad-output/implementation-artifacts"'));
-    assert.ok(content.includes('knowledgebase_path: "."'));
-    assert.ok(content.includes('sprint_management_path: "."'));
-  } finally {
-    process.chdir(origCwd);
-    fs.rmSync(tmpDir, { recursive: true, force: true });
-  }
-});
-
-// ─── Task 4: Source-of-truth precedence ─────────────────────────────────────
-console.log('\nTask 4 — Source-of-truth precedence documented');
-
-test('validation report exists', () => {
-  const reportPath = path.join(__dirname, '..', '_bmad-output', 'implementation-artifacts', '16-4-validation-report.md');
-  assert.ok(fs.existsSync(reportPath), 'Validation report should exist');
-  const content = fs.readFileSync(reportPath, 'utf-8');
-  assert.ok(content.includes('Source-of-Truth Precedence'), 'Should document precedence');
-  assert.ok(content.includes('PRIMARY'), 'Should identify primary source');
-  assert.ok(content.includes('config.yaml'), 'Should mention config.yaml as primary');
-});
-
-test('path accessibility: fs.accessSync pattern available', () => {
-  // Verify fs.accessSync works for testing path accessibility
-  assert.ok(typeof fs.accessSync === 'function', 'fs.accessSync should be available');
-  // Test with known accessible path
-  assert.doesNotThrow(() => fs.accessSync(__dirname, fs.constants.R_OK));
-});
-
-// ─── Summary ────────────────────────────────────────────────────────────────
-console.log(`\n${passed} passed, ${failed} failed`);
-if (errors.length > 0) {
-  console.log('\nFailed tests:');
-  errors.forEach(e => console.log(`  - ${e.name}: ${e.error}`));
-}
-if (failed > 0) process.exit(1);