ma-agents 2.19.2 → 2.20.1

package/lib/bmad-cache/tea/test/test-knowledge-base.js

@@ -0,0 +1,208 @@
+/**
+ * Knowledge Base Validation Tests - TEA Module
+ *
+ * Tests tea-index.csv parsing, fragment existence, tag selection,
+ * and cross-fragment link references.
+ *
+ * Usage: node test/test-knowledge-base.js
+ */
+
+const fs = require('node:fs');
+const path = require('node:path');
+const { parse } = require('csv-parse/sync');
+
+// ANSI colors
+const colors = {
+  reset: '\u001B[0m',
+  green: '\u001B[32m',
+  red: '\u001B[31m',
+  yellow: '\u001B[33m',
+  cyan: '\u001B[36m',
+  dim: '\u001B[2m',
+};
+
+let passed = 0;
+let failed = 0;
+let warned = 0;
+
+function assert(condition, testName, errorMessage = '') {
+  if (condition) {
+    console.log(`${colors.green}✓${colors.reset} ${testName}`);
+    passed++;
+  } else {
+    console.log(`${colors.red}✗${colors.reset} ${testName}`);
+    if (errorMessage) {
+      console.log(`  ${colors.dim}${errorMessage}${colors.reset}`);
+    }
+    failed++;
+  }
+}
+
+function warn(message) {
+  console.log(`${colors.yellow}•${colors.reset} ${message}`);
+  warned++;
+}
+
+function parseTags(tagString) {
+  if (!tagString) return [];
+  return tagString
+    .split(',')
+    .map((tag) => tag.trim())
+    .filter(Boolean);
+}
+
+function isExternalLink(href) {
+  return href.startsWith('http://') || href.startsWith('https://');
+}
+
+function resolveFragmentLink(baseDir, href) {
+  if (href.startsWith('knowledge/')) {
+    return path.join(baseDir, href);
+  }
+  if (href.startsWith('./') || href.startsWith('../')) {
+    return path.join(baseDir, href);
+  }
+  // If only a filename is provided, assume knowledge dir
+  if (href.endsWith('.md') && !href.includes('/')) {
+    return path.join(baseDir, 'knowledge', href);
+  }
+  return null;
+}
+
+function runTests() {
+  console.log(`${colors.cyan}========================================`);
+  console.log('TEA Knowledge Base Tests');
+  console.log(`========================================${colors.reset}\n`);
+
+  const projectRoot = path.join(__dirname, '..');
+  const kbRoot = path.join(projectRoot, 'src', 'testarch');
+  const indexPath = path.join(kbRoot, 'tea-index.csv');
+
+  // ============================================================
+  // Test 1: Parse CSV and validate structure
+  // ============================================================
+  console.log(`${colors.yellow}Test Suite 1: CSV Structure${colors.reset}\n`);
+
+  let records = [];
+  try {
+    const csv = fs.readFileSync(indexPath, 'utf8');
+    records = parse(csv, { columns: true, skip_empty_lines: true });
+
+    assert(records.length === 42, 'tea-index.csv has 42 fragment records', `Found ${records.length}`);
+
+    const requiredFields = ['id', 'name', 'description', 'tags', 'tier', 'fragment_file'];
+    const missingFields = requiredFields.filter((field) => !Object.prototype.hasOwnProperty.call(records[0] || {}, field));
+    assert(missingFields.length === 0, 'tea-index.csv has required columns', missingFields.join(', '));
+
+    // Validate tier values
+    const validTiers = new Set(['core', 'extended', 'specialized']);
+    const invalidTiers = records.filter((r) => !validTiers.has(r.tier));
+    assert(
+      invalidTiers.length === 0,
+      'All fragments have valid tier values (core/extended/specialized)',
+      invalidTiers.map((r) => `${r.id}: "${r.tier}"`).join(', '),
+    );
+  } catch (error) {
+    assert(false, 'tea-index.csv parsed successfully', error.message);
+  }
+
+  console.log('');
+
+  // ============================================================
+  // Test 2: Fragment file existence
+  // ============================================================
+  console.log(`${colors.yellow}Test Suite 2: Fragment Existence${colors.reset}\n`);
+
+  if (records.length > 0) {
+    let missingCount = 0;
+    for (const record of records) {
+      const fragmentPath = path.join(kbRoot, record.fragment_file);
+      const exists = fs.existsSync(fragmentPath);
+      if (!exists) missingCount++;
+      assert(exists, `fragment exists: ${record.fragment_file}`);
+    }
+    assert(missingCount === 0, 'all fragments exist');
+  } else {
+    assert(false, 'fragment records loaded', 'No records found in tea-index.csv');
+  }
+
+  console.log('');
+
+  // ============================================================
+  // Test 3: Tag selection logic
+  // ============================================================
+  console.log(`${colors.yellow}Test Suite 3: Tag Selection${colors.reset}\n`);
+
+  if (records.length > 0) {
+    const firstTag = parseTags(records[0].tags)[0];
+    const selected = records.filter((record) => parseTags(record.tags).includes(firstTag));
+    assert(Boolean(firstTag), 'first record has at least one tag');
+    assert(selected.length > 0, `tag filter returns results for '${firstTag}'`);
+
+    const none = records.filter((record) => parseTags(record.tags).includes('__no_such_tag__'));
+    assert(none.length === 0, 'unknown tag returns no results');
+  } else {
+    assert(false, 'tag selection tested', 'No records to test');
+  }
+
+  console.log('');
+
+  // ============================================================
+  // Test 4: Cross-fragment references
+  // ============================================================
+  console.log(`${colors.yellow}Test Suite 4: Cross-Fragment Links${colors.reset}\n`);
+
+  const knowledgeDir = path.join(kbRoot, 'knowledge');
+  const mdFiles = fs.readdirSync(knowledgeDir).filter((name) => name.endsWith('.md'));
+
+  let linkCount = 0;
+  let brokenLinks = 0;
+
+  for (const fileName of mdFiles) {
+    const filePath = path.join(knowledgeDir, fileName);
+    const content = fs.readFileSync(filePath, 'utf8');
+
+    const linkMatches = content.matchAll(/\]\(([^)]+)\)/g);
+    for (const match of linkMatches) {
+      const href = match[1].trim();
+      if (!href.endsWith('.md') || isExternalLink(href)) continue;
+
+      const resolved = resolveFragmentLink(kbRoot, href);
+      if (!resolved) continue;
+
+      linkCount++;
+      const exists = fs.existsSync(resolved);
+      if (!exists) brokenLinks++;
+      assert(exists, `link resolves: ${fileName} -> ${href}`);
+    }
+  }
+
+  if (linkCount === 0) {
+    warn('no cross-fragment links detected (informational)');
+  } else {
+    assert(linkCount > 0, 'cross-fragment links detected (at least one)');
+  }
+  assert(brokenLinks === 0, 'no broken cross-fragment links');
+
+  console.log('');
+
+  // ============================================================
+  // Summary
+  // ============================================================
+  console.log(`${colors.cyan}========================================`);
+  console.log('Test Results:');
+  console.log(`  Passed: ${colors.green}${passed}${colors.reset}`);
+  console.log(`  Warnings: ${colors.yellow}${warned}${colors.reset}`);
+  console.log(`  Failed: ${colors.red}${failed}${colors.reset}`);
+  console.log(`========================================${colors.reset}\n`);
+
+  if (failed === 0) {
+    console.log(`${colors.green}✨ Knowledge base tests passed!${colors.reset}\n`);
+    process.exit(0);
+  } else {
+    console.log(`${colors.red}❌ Knowledge base tests failed${colors.reset}\n`);
+    process.exit(1);
+  }
+}
+
+runTests();

package/lib/bmad-cache/tea/test/unit-test-schema.js

@@ -0,0 +1,133 @@
+/**
+ * Unit Tests for Agent Schema Edge Cases
+ *
+ * Tests internal functions to achieve 100% branch coverage
+ */
+
+const { validateAgentFile } = require('./schema/agent.js');
+
+console.log('Running edge case unit tests...\n');
+
+let passed = 0;
+let failed = 0;
+
+// Test 1: Path with malformed module structure (no slash after module name)
+// This tests line 213: slashIndex === -1
+console.log('Test 1: Malformed module path (no slash after module name)');
+try {
+  const result = validateAgentFile('src/modules/bmm', {
+    agent: {
+      metadata: {
+        id: 'test',
+        name: 'Test',
+        title: 'Test',
+        icon: '🧪',
+      },
+      persona: {
+        role: 'Test',
+        identity: 'Test',
+        communication_style: 'Test',
+        principles: ['Test'],
+      },
+      menu: [{ trigger: 'help', description: 'Help', action: 'help' }],
+    },
+  });
+
+  if (result.success) {
+    console.log('✗ Should have failed - missing module field');
+    failed++;
+  } else {
+    console.log('✓ Correctly handled malformed path (treated as core agent)');
+    passed++;
+  }
+} catch (error) {
+  console.log('✗ Unexpected error:', error.message);
+  failed++;
+}
+console.log('');
+
+// Test 2: Module option with empty string
+// This tests line 222: trimmed.length > 0
+console.log('Test 2: Module agent with empty string in module field');
+try {
+  const result = validateAgentFile('src/modules/bmm/agents/test.agent.yaml', {
+    agent: {
+      metadata: {
+        id: 'test',
+        name: 'Test',
+        title: 'Test',
+        icon: '🧪',
+        module: '   ', // Empty after trimming
+      },
+      persona: {
+        role: 'Test',
+        identity: 'Test',
+        communication_style: 'Test',
+        principles: ['Test'],
+      },
+      menu: [{ trigger: 'help', description: 'Help', action: 'help' }],
+    },
+  });
+
+  if (result.success) {
+    console.log('✗ Should have failed - empty module string');
+    failed++;
+  } else {
+    console.log('✓ Correctly rejected empty module string');
+    passed++;
+  }
+} catch (error) {
+  console.log('✗ Unexpected error:', error.message);
+  failed++;
+}
+console.log('');
+
+// Test 3: Core agent path (src/core/agents/...) - tests the !filePath.startsWith(marker) branch
+console.log('Test 3: Core agent path returns null for module');
+try {
+  const result = validateAgentFile('src/core/agents/test.agent.yaml', {
+    agent: {
+      metadata: {
+        id: 'test',
+        name: 'Test',
+        title: 'Test',
+        icon: '🧪',
+        // No module field - correct for core agent
+      },
+      persona: {
+        role: 'Test',
+        identity: 'Test',
+        communication_style: 'Test',
+        principles: ['Test'],
+      },
+      menu: [{ trigger: 'help', description: 'Help', action: 'help' }],
+    },
+  });
+
+  if (result.success) {
+    console.log('✓ Core agent validated correctly (no module required)');
+    passed++;
+  } else {
+    console.log('✗ Core agent should pass without module field');
+    failed++;
+  }
+} catch (error) {
+  console.log('✗ Unexpected error:', error.message);
+  failed++;
+}
+console.log('');
+
+// Summary
+console.log('═══════════════════════════════════════');
+console.log('Edge Case Unit Test Results:');
+console.log(`  Passed: ${passed}`);
+console.log(`  Failed: ${failed}`);
+console.log('═══════════════════════════════════════\n');
+
+if (failed === 0) {
+  console.log('✨ All edge case tests passed!\n');
+  process.exit(0);
+} else {
+  console.log('❌ Some edge case tests failed\n');
+  process.exit(1);
+}

package/lib/bmad-cache/tea/test/validate-agent-schema.js

@@ -0,0 +1,110 @@
+/**
+ * Agent Schema Validator CLI
+ *
+ * Scans all *.agent.yaml files in src/{core,modules/*}/agents/
+ * and validates them against the Zod schema.
+ *
+ * Usage: node tools/validate-agent-schema.js [project_root]
+ * Exit codes: 0 = success, 1 = validation failures
+ *
+ * Optional argument:
+ *   project_root - Directory to scan (defaults to BMAD repo root)
+ */
+
+const { glob } = require('glob');
+const yaml = require('yaml');
+const fs = require('node:fs');
+const path = require('node:path');
+const { validateAgentFile } = require('./schema/agent.js');
+
+/**
+ * Main validation routine
+ * @param {string} [customProjectRoot] - Optional project root to scan (for testing)
+ */
+async function main(customProjectRoot) {
+  console.log('🔍 Scanning for agent files...\n');
+
+  // Determine project root: use custom path if provided, otherwise default to repo root
+  const project_root = customProjectRoot || path.join(__dirname, '..');
+
+  // Find all agent files
+  const agentFiles = await glob('src/**/*.agent.yaml', {
+    cwd: project_root,
+    absolute: true,
+  });
+
+  if (agentFiles.length === 0) {
+    console.log('❌ No agent files found. This likely indicates a configuration error.');
+    console.log('   Expected to find *.agent.yaml files in src/{core,modules/*}/agents/');
+    process.exit(1);
+  }
+
+  console.log(`Found ${agentFiles.length} agent file(s)\n`);
+
+  const errors = [];
+
+  // Validate each file
+  for (const filePath of agentFiles) {
+    const relativePath = path.relative(process.cwd(), filePath);
+
+    try {
+      const fileContent = fs.readFileSync(filePath, 'utf8');
+      const agentData = yaml.parse(fileContent);
+
+      // Convert absolute path to relative src/ path for module detection
+      const srcRelativePath = relativePath.startsWith('src/') ? relativePath : path.relative(project_root, filePath).replaceAll('\\', '/');
+
+      const result = validateAgentFile(srcRelativePath, agentData);
+
+      if (result.success) {
+        console.log(`✅ ${relativePath}`);
+      } else {
+        errors.push({
+          file: relativePath,
+          issues: result.error.issues,
+        });
+      }
+    } catch (error) {
+      errors.push({
+        file: relativePath,
+        issues: [
+          {
+            code: 'parse_error',
+            message: `Failed to parse YAML: ${error.message}`,
+            path: [],
+          },
+        ],
+      });
+    }
+  }
+
+  // Report errors
+  if (errors.length > 0) {
+    console.log('\n❌ Validation failed for the following files:\n');
+
+    for (const { file, issues } of errors) {
+      console.log(`\n📄 ${file}`);
+      for (const issue of issues) {
+        const pathString = issue.path.length > 0 ? issue.path.join('.') : '(root)';
+        console.log(`   Path: ${pathString}`);
+        console.log(`   Error: ${issue.message}`);
+        if (issue.code) {
+          console.log(`   Code: ${issue.code}`);
+        }
+      }
+    }
+
+    console.log(`\n\n💥 ${errors.length} file(s) failed validation`);
+    process.exit(1);
+  }
+
+  console.log(`\n✨ All ${agentFiles.length} agent file(s) passed validation!\n`);
+  process.exit(0);
+}
+
+// Run with optional command-line argument for project root
+const customProjectRoot = process.argv[2];
+main(customProjectRoot).catch((error) => {
+  console.error('Fatal error:', error);
+  process.exit(1);
+});