ma-agents 2.19.2 → 2.20.0

package/lib/bmad-cache/tea/test/test-agent-schema.js

@@ -0,0 +1,387 @@
+/**
+ * Agent Schema Validation Test Runner
+ *
+ * Runs all test fixtures and verifies expected outcomes.
+ * Reports pass/fail for each test and overall coverage statistics.
+ *
+ * Usage: node test/test-agent-schema.js
+ * Exit codes: 0 = all tests pass, 1 = test failures
+ */
+
+const fs = require('node:fs');
+const path = require('node:path');
+const yaml = require('yaml');
+const { validateAgentFile } = require('./schema/agent.js');
+const { glob } = require('glob');
+
+// ANSI color codes
+const colors = {
+  reset: '\u001B[0m',
+  green: '\u001B[32m',
+  red: '\u001B[31m',
+  yellow: '\u001B[33m',
+  blue: '\u001B[34m',
+  cyan: '\u001B[36m',
+  dim: '\u001B[2m',
+};
+
+/**
+ * Parse test metadata from YAML comments
+ * @param {string} filePath
+ * @returns {{shouldPass: boolean, errorExpectation?: object, pathContext?: string}}
+ */
+function parseTestMetadata(filePath) {
+  const content = fs.readFileSync(filePath, 'utf8');
+  const lines = content.split('\n');
+
+  let shouldPass = true;
+  let pathContext = null;
+  const errorExpectation = {};
+
+  for (const line of lines) {
+    if (line.includes('Expected: PASS')) {
+      shouldPass = true;
+    } else if (line.includes('Expected: FAIL')) {
+      shouldPass = false;
+    }
+
+    // Parse error metadata
+    const codeMatch = line.match(/^# Error code: (.+)$/);
+    if (codeMatch) {
+      errorExpectation.code = codeMatch[1].trim();
+    }
+
+    const pathMatch = line.match(/^# Error path: (.+)$/);
+    if (pathMatch) {
+      errorExpectation.path = pathMatch[1].trim();
+    }
+
+    const messageMatch = line.match(/^# Error message: (.+)$/);
+    if (messageMatch) {
+      errorExpectation.message = messageMatch[1].trim();
+    }
+
+    const minimumMatch = line.match(/^# Error minimum: (\d+)$/);
+    if (minimumMatch) {
+      errorExpectation.minimum = parseInt(minimumMatch[1], 10);
+    }
+
+    const expectedMatch = line.match(/^# Error expected: (.+)$/);
+    if (expectedMatch) {
+      errorExpectation.expected = expectedMatch[1].trim();
+    }
+
+    const receivedMatch = line.match(/^# Error received: (.+)$/);
+    if (receivedMatch) {
+      errorExpectation.received = receivedMatch[1].trim();
+    }
+
+    const keysMatch = line.match(/^# Error keys: \[(.+)\]$/);
+    if (keysMatch) {
+      errorExpectation.keys = keysMatch[1].split(',').map((k) => k.trim().replaceAll(/['"]/g, ''));
+    }
+
+    const contextMatch = line.match(/^# Path context: (.+)$/);
+    if (contextMatch) {
+      pathContext = contextMatch[1].trim();
+    }
+  }
+
+  return {
+    shouldPass,
+    errorExpectation: Object.keys(errorExpectation).length > 0 ? errorExpectation : null,
+    pathContext,
+  };
+}
+
+/**
+ * Convert dot-notation path string to array (handles array indices)
+ * e.g., "agent.menu[0].trigger" => ["agent", "menu", 0, "trigger"]
+ */
+function parsePathString(pathString) {
+  return pathString
+    .replaceAll(/\[(\d+)\]/g, '.$1') // Convert [0] to .0
+    .split('.')
+    .map((part) => {
+      const num = parseInt(part, 10);
+      return isNaN(num) ? part : num;
+    });
+}
+
+/**
+ * Validate error against expectations
+ * @param {object} error - Zod error issue
+ * @param {object} expectation - Expected error structure
+ * @returns {{valid: boolean, reason?: string}}
+ */
+function validateError(error, expectation) {
+  // Check error code
+  if (expectation.code && error.code !== expectation.code) {
+    return { valid: false, reason: `Expected code "${expectation.code}", got "${error.code}"` };
+  }
+
+  // Check error path
+  if (expectation.path) {
+    const expectedPath = parsePathString(expectation.path);
+    const actualPath = error.path;
+
+    if (JSON.stringify(expectedPath) !== JSON.stringify(actualPath)) {
+      return {
+        valid: false,
+        reason: `Expected path ${JSON.stringify(expectedPath)}, got ${JSON.stringify(actualPath)}`,
+      };
+    }
+  }
+
+  // For custom errors, strictly check message
+  if (expectation.code === 'custom' && expectation.message && error.message !== expectation.message) {
+    return {
+      valid: false,
+      reason: `Expected message "${expectation.message}", got "${error.message}"`,
+    };
+  }
+
+  // For Zod errors, check type-specific fields
+  if (expectation.minimum !== undefined && error.minimum !== expectation.minimum) {
+    return { valid: false, reason: `Expected minimum ${expectation.minimum}, got ${error.minimum}` };
+  }
+
+  if (expectation.expected && error.expected !== expectation.expected) {
+    return { valid: false, reason: `Expected type "${expectation.expected}", got "${error.expected}"` };
+  }
+
+  if (expectation.received && error.received !== expectation.received) {
+    return { valid: false, reason: `Expected received "${expectation.received}", got "${error.received}"` };
+  }
+
+  if (expectation.keys) {
+    const expectedKeys = expectation.keys.sort();
+    const actualKeys = (error.keys || []).sort();
+    if (JSON.stringify(expectedKeys) !== JSON.stringify(actualKeys)) {
+      return {
+        valid: false,
+        reason: `Expected keys ${JSON.stringify(expectedKeys)}, got ${JSON.stringify(actualKeys)}`,
+      };
+    }
+  }
+
+  return { valid: true };
+}
+
+/**
+ * Run a single test case
+ * @param {string} filePath
+ * @returns {{passed: boolean, message: string}}
+ */
+function runTest(filePath) {
+  const metadata = parseTestMetadata(filePath);
+  const { shouldPass, errorExpectation, pathContext } = metadata;
+
+  try {
+    const fileContent = fs.readFileSync(filePath, 'utf8');
+    let agentData;
+
+    try {
+      agentData = yaml.parse(fileContent);
+    } catch (parseError) {
+      // YAML parse error
+      if (shouldPass) {
+        return {
+          passed: false,
+          message: `Expected PASS but got YAML parse error: ${parseError.message}`,
+        };
+      }
+      return {
+        passed: true,
+        message: 'Got expected YAML parse error',
+      };
+    }
+
+    // Determine validation path
+    // If pathContext is specified in comments, use it; otherwise derive from fixture location
+    let validationPath = pathContext;
+    if (!validationPath) {
+      // Map fixture location to simulated src/ path
+      const relativePath = path.relative(path.join(__dirname, 'fixtures/agent-schema'), filePath);
+      const parts = relativePath.split(path.sep);
+
+      if (parts.includes('metadata') && parts[0] === 'valid') {
+        // Valid metadata tests: check if filename suggests module or core
+        const filename = path.basename(filePath);
+        if (filename.includes('module')) {
+          validationPath = 'src/modules/bmm/agents/test.agent.yaml';
+        } else {
+          validationPath = 'src/core/agents/test.agent.yaml';
+        }
+      } else if (parts.includes('metadata') && parts[0] === 'invalid') {
+        // Invalid metadata tests: derive from filename
+        const filename = path.basename(filePath);
+        if (filename.includes('module') || filename.includes('wrong-module')) {
+          validationPath = 'src/modules/bmm/agents/test.agent.yaml';
+        } else if (filename.includes('core')) {
+          validationPath = 'src/core/agents/test.agent.yaml';
+        } else {
+          validationPath = 'src/core/agents/test.agent.yaml';
+        }
+      } else {
+        // Default to core agent path
+        validationPath = 'src/core/agents/test.agent.yaml';
+      }
+    }
+
+    const result = validateAgentFile(validationPath, agentData);
+
+    if (result.success && shouldPass) {
+      return {
+        passed: true,
+        message: 'Validation passed as expected',
+      };
+    }
+
+    if (!result.success && !shouldPass) {
+      const actualError = result.error.issues[0];
+
+      // If we have error expectations, validate strictly
+      if (errorExpectation) {
+        const validation = validateError(actualError, errorExpectation);
+
+        if (!validation.valid) {
+          return {
+            passed: false,
+            message: `Error validation failed: ${validation.reason}`,
+          };
+        }
+
+        return {
+          passed: true,
+          message: `Got expected error (${errorExpectation.code}): ${actualError.message}`,
+        };
+      }
+
+      // No specific expectations - just check that it failed
+      return {
+        passed: true,
+        message: `Got expected validation error: ${actualError?.message}`,
+      };
+    }
+
+    if (result.success && !shouldPass) {
+      return {
+        passed: false,
+        message: 'Expected validation to FAIL but it PASSED',
+      };
+    }
+
+    if (!result.success && shouldPass) {
+      return {
+        passed: false,
+        message: `Expected validation to PASS but it FAILED: ${result.error.issues[0]?.message}`,
+      };
+    }
+
+    return {
+      passed: false,
+      message: 'Unexpected test state',
+    };
+  } catch (error) {
+    return {
+      passed: false,
+      message: `Test execution error: ${error.message}`,
+    };
+  }
+}
+
+/**
+ * Main test runner
+ */
+async function main() {
+  console.log(`${colors.cyan}╔═══════════════════════════════════════════════════════════╗${colors.reset}`);
+  console.log(`${colors.cyan}║  Agent Schema Validation Test Suite                      ║${colors.reset}`);
+  console.log(`${colors.cyan}╚═══════════════════════════════════════════════════════════╝${colors.reset}\n`);
+
+  // Find all test fixtures
+  const testFiles = await glob('test/fixtures/agent-schema/**/*.agent.yaml', {
+    cwd: path.join(__dirname, '..'),
+    absolute: true,
+  });
+
+  if (testFiles.length === 0) {
+    console.log(`${colors.yellow}⚠️  No test fixtures found${colors.reset}`);
+    process.exit(0);
+  }
+
+  console.log(`Found ${colors.cyan}${testFiles.length}${colors.reset} test fixture(s)\n`);
+
+  // Group tests by category
+  const categories = {};
+  for (const testFile of testFiles) {
+    const relativePath = path.relative(path.join(__dirname, 'fixtures/agent-schema'), testFile);
+    const parts = relativePath.split(path.sep);
+    const validInvalid = parts[0]; // 'valid' or 'invalid'
+    const category = parts[1]; // 'top-level', 'metadata', etc.
+
+    const categoryKey = `${validInvalid}/${category}`;
+    if (!categories[categoryKey]) {
+      categories[categoryKey] = [];
+    }
+    categories[categoryKey].push(testFile);
+  }
+
+  // Run tests by category
+  let totalTests = 0;
+  let passedTests = 0;
+  const failures = [];
+
+  for (const [categoryKey, files] of Object.entries(categories).sort()) {
+    const [validInvalid, category] = categoryKey.split('/');
+    const categoryLabel = category.replaceAll('-', ' ').toUpperCase();
+    const validLabel = validInvalid === 'valid' ? '✅' : '❌';
+
+    console.log(`${colors.blue}${validLabel} ${categoryLabel} (${validInvalid})${colors.reset}`);
+
+    for (const testFile of files) {
+      totalTests++;
+      const testName = path.basename(testFile, '.agent.yaml');
+      const result = runTest(testFile);
+
+      if (result.passed) {
+        passedTests++;
+        console.log(`  ${colors.green}✓${colors.reset} ${testName} ${colors.dim}${result.message}${colors.reset}`);
+      } else {
+        console.log(`  ${colors.red}✗${colors.reset} ${testName} ${colors.red}${result.message}${colors.reset}`);
+        failures.push({
+          file: path.relative(process.cwd(), testFile),
+          message: result.message,
+        });
+      }
+    }
+    console.log('');
+  }
+
+  // Summary
+  console.log(`${colors.cyan}═══════════════════════════════════════════════════════════${colors.reset}`);
+  console.log(`${colors.cyan}Test Results:${colors.reset}`);
+  console.log(`  Total:  ${totalTests}`);
+  console.log(`  Passed: ${colors.green}${passedTests}${colors.reset}`);
+  console.log(`  Failed: ${passedTests === totalTests ? colors.green : colors.red}${totalTests - passedTests}${colors.reset}`);
+  console.log(`${colors.cyan}═══════════════════════════════════════════════════════════${colors.reset}\n`);
+
+  // Report failures
+  if (failures.length > 0) {
+    console.log(`${colors.red}❌ FAILED TESTS:${colors.reset}\n`);
+    for (const failure of failures) {
+      console.log(`${colors.red}✗${colors.reset} ${failure.file}`);
+      console.log(`  ${failure.message}\n`);
+    }
+    process.exit(1);
+  }
+
+  console.log(`${colors.green}✨ All tests passed!${colors.reset}\n`);
+  process.exit(0);
+}
+
+// Run
+main().catch((error) => {
+  console.error(`${colors.red}Fatal error:${colors.reset}`, error);
+  process.exit(1);
+});

package/lib/bmad-cache/tea/test/test-installation-components.js

@@ -0,0 +1,214 @@
+/**
+ * Installation Component Tests - TEA Module
+ *
+ * Tests TEA module installation components in isolation:
+ * - Agent YAML structure validation
+ * - Module.yaml validation
+ * - Path references validation
+ *
+ * These are deterministic unit tests that don't require full installation.
+ * Usage: node test/test-installation-components.js
+ */
+
+const path = require('node:path');
+const fs = require('node:fs/promises');
+const yaml = require('js-yaml');
+
+async function pathExists(filePath) {
+  try {
+    await fs.access(filePath);
+    return true;
+  } catch {
+    return false;
+  }
+}
+
+// ANSI colors
+const colors = {
+  reset: '\u001B[0m',
+  green: '\u001B[32m',
+  red: '\u001B[31m',
+  yellow: '\u001B[33m',
+  cyan: '\u001B[36m',
+  dim: '\u001B[2m',
+};
+
+let passed = 0;
+let failed = 0;
+
+/**
+ * Test helper: Assert condition
+ */
+function assert(condition, testName, errorMessage = '') {
+  if (condition) {
+    console.log(`${colors.green}✓${colors.reset} ${testName}`);
+    passed++;
+  } else {
+    console.log(`${colors.red}✗${colors.reset} ${testName}`);
+    if (errorMessage) {
+      console.log(`  ${colors.dim}${errorMessage}${colors.reset}`);
+    }
+    failed++;
+  }
+}
+
+/**
+ * Test Suite
+ */
+async function runTests() {
+  console.log(`${colors.cyan}========================================`);
+  console.log('TEA Installation Component Tests');
+  console.log(`========================================${colors.reset}\n`);
+
+  const projectRoot = path.join(__dirname, '..');
+
+  // ============================================================
+  // Test 1: Module.yaml Structure
+  // ============================================================
+  console.log(`${colors.yellow}Test Suite 1: Module Configuration${colors.reset}\n`);
+
+  try {
+    const moduleYamlPath = path.join(projectRoot, 'src/module.yaml');
+    const moduleYaml = yaml.load(await fs.readFile(moduleYamlPath, 'utf8'));
+
+    assert(moduleYaml.code === 'tea', 'module.yaml has correct code: tea');
+    assert(moduleYaml.name === 'Test Architect', 'module.yaml has correct name');
+    assert(typeof moduleYaml.description === 'string' && moduleYaml.description.length > 0, 'module.yaml has description');
+    assert(typeof moduleYaml.default_selected === 'boolean', 'module.yaml has boolean default_selected');
+  } catch (error) {
+    assert(false, 'module.yaml loads and validates', error.message);
+  }
+
+  console.log('');
+
+  // ============================================================
+  // Test 2: TEA Agent YAML Structure
+  // ============================================================
+  console.log(`${colors.yellow}Test Suite 2: TEA Agent Structure${colors.reset}\n`);
+
+  try {
+    const teaAgentPath = path.join(projectRoot, 'src/agents/tea.agent.yaml');
+
+    if (await pathExists(teaAgentPath)) {
+      const teaAgent = yaml.load(await fs.readFile(teaAgentPath, 'utf8'));
+
+      assert(teaAgent.agent !== undefined, 'tea.agent.yaml has agent root key');
+      assert(teaAgent.agent.metadata !== undefined, 'TEA agent has metadata section');
+      assert(teaAgent.agent.metadata.module === 'tea', 'TEA agent metadata has module: tea');
+      assert(teaAgent.agent.metadata.id.includes('_bmad/tea/'), 'TEA agent id references _bmad/tea/ path');
+      assert(teaAgent.agent.persona !== undefined, 'TEA agent has persona section');
+      assert(teaAgent.agent.critical_actions !== undefined, 'TEA agent has critical_actions');
+      assert(teaAgent.agent.menu !== undefined, 'TEA agent has menu');
+      assert(Array.isArray(teaAgent.agent.menu) && teaAgent.agent.menu.length === 9, 'TEA agent menu has 9 workflows');
+
+      // Verify no BMM references
+      const yamlContent = await fs.readFile(teaAgentPath, 'utf8');
+      assert(!yamlContent.includes('_bmad/bmm/'), 'TEA agent has no _bmad/bmm/ references');
+      assert(!yamlContent.includes('module: bmm'), 'TEA agent has no module: bmm references');
+    } else {
+      assert(false, 'TEA agent YAML exists', 'src/agents/tea.agent.yaml not found - run Phase 2 first');
+    }
+  } catch (error) {
+    assert(false, 'TEA agent structure validates', error.message);
+  }
+
+  console.log('');
+
+  // ============================================================
+  // Test 3: Knowledge Base Structure
+  // ============================================================
+  console.log(`${colors.yellow}Test Suite 3: Knowledge Base${colors.reset}\n`);
+
+  try {
+    const teaIndexPath = path.join(projectRoot, 'src/testarch/tea-index.csv');
+
+    if (await pathExists(teaIndexPath)) {
+      const csvContent = await fs.readFile(teaIndexPath, 'utf8');
+      const lines = csvContent.trim().split('\n');
+
+      assert(lines.length === 43, 'tea-index.csv has 43 lines (header + 42 fragments)', `Found ${lines.length} lines`);
+      assert(lines[0].includes('id,name,description,tags,tier,fragment_file'), 'tea-index.csv has correct header format');
+
+      // Verify no BMM references in CSV
+      assert(!csvContent.includes('bmm'), 'tea-index.csv has no BMM references');
+    } else {
+      console.log(`  ${colors.dim}Skipping - tea-index.csv not found (run Phase 2 first)${colors.reset}`);
+    }
+  } catch (error) {
+    assert(false, 'Knowledge base structure validates', error.message);
+  }
+
+  console.log('');
+
+  // ============================================================
+  // Test 4: Workflow Structure
+  // ============================================================
+  console.log(`${colors.yellow}Test Suite 4: Workflow Structure${colors.reset}\n`);
+
+  const teachMeWorkflowPath = path.join(projectRoot, 'src/workflows/testarch/bmad-teach-me-testing/workflow.md');
+  try {
+    if (await pathExists(teachMeWorkflowPath)) {
+      const teachMeContent = await fs.readFile(teachMeWorkflowPath, 'utf8');
+      assert(teachMeContent.length > 0, 'bmad-teach-me-testing/workflow.md exists');
+      assert(!teachMeContent.includes('_bmad/bmm/'), 'bmad-teach-me-testing has no _bmad/bmm/ references');
+    } else {
+      assert(false, 'bmad-teach-me-testing workflow exists', 'src/workflows/testarch/bmad-teach-me-testing/workflow.md not found');
+    }
+  } catch (error) {
+    assert(false, 'teach-me-testing workflow validates', error.message);
+  }
+
+  const workflowDirs = {
+    'bmad-testarch-framework': 'framework',
+    'bmad-testarch-ci': 'ci',
+    'bmad-testarch-test-design': 'test-design',
+    'bmad-testarch-atdd': 'atdd',
+    'bmad-testarch-automate': 'automate',
+    'bmad-testarch-test-review': 'test-review',
+    'bmad-testarch-nfr': 'nfr-assess',
+    'bmad-testarch-trace': 'trace',
+  };
+
+  for (const [dirName, displayName] of Object.entries(workflowDirs)) {
+    const workflowYamlPath = path.join(projectRoot, `src/workflows/testarch/${dirName}/workflow.yaml`);
+
+    if (await pathExists(workflowYamlPath)) {
+      try {
+        const workflowYaml = yaml.load(await fs.readFile(workflowYamlPath, 'utf8'));
+        assert(workflowYaml !== undefined, `${dirName}/workflow.yaml is valid YAML`);
+
+        // Verify no BMM references
+        const yamlContent = await fs.readFile(workflowYamlPath, 'utf8');
+        assert(!yamlContent.includes('_bmad/bmm/'), `${dirName} has no _bmad/bmm/ references`);
+      } catch (error) {
+        assert(false, `${dirName}/workflow.yaml validates`, error.message);
+      }
+    }
+  }
+
+  console.log('');
+
+  // ============================================================
+  // Summary
+  // ============================================================
+  console.log(`${colors.cyan}========================================`);
+  console.log('Test Results:');
+  console.log(`  Passed: ${colors.green}${passed}${colors.reset}`);
+  console.log(`  Failed: ${colors.red}${failed}${colors.reset}`);
+  console.log(`========================================${colors.reset}\n`);
+
+  if (failed === 0) {
+    console.log(`${colors.green}✨ All installation component tests passed!${colors.reset}\n`);
+    process.exit(0);
+  } else {
+    console.log(`${colors.red}❌ Some installation component tests failed${colors.reset}\n`);
+    process.exit(1);
+  }
+}
+
+// Run tests
+runTests().catch((error) => {
+  console.error(`${colors.red}Test runner failed:${colors.reset}`, error.message);
+  console.error(error.stack);
+  process.exit(1);
+});