lsd-pi 1.0.0 → 1.1.1

package/src/resources/extensions/gsd/tests/test-utils.ts

@@ -1,165 +0,0 @@
-/**
- * Shared test utilities for GSD extension tests.
- *
- * Provides cross-platform helpers for creating temporary git repos,
- * safe cleanup, file creation, and shell-free git operations.
- *
- * Usage:
- *   import { git, makeTempRepo, cleanup, createFile } from "./test-utils.ts";
- */
-
-import { execFileSync } from "node:child_process";
-import {
-  existsSync,
-  mkdirSync,
-  mkdtempSync,
-  readFileSync,
-  rmSync,
-  statSync,
-  writeFileSync,
-} from "node:fs";
-import { dirname, join } from "node:path";
-import { tmpdir } from "node:os";
-
-/**
- * Shell-free git helper — uses execFileSync to bypass shell entirely.
- * No quoting issues, no Windows cmd.exe incompatibilities.
- *
- * @param cwd - Working directory for git command
- * @param args - Git arguments (e.g., "add", "-A")
- * @returns trimmed stdout
- */
-export function git(cwd: string, ...args: string[]): string {
-  return execFileSync("git", args, {
-    cwd,
-    encoding: "utf-8",
-    stdio: "pipe",
-  }).trim();
-}
-
-/**
- * Create a temporary git repository with an initial commit.
- * Configures user.email, user.name, and core.autocrlf=false for
- * consistent behavior across platforms.
- *
- * @param prefix - Optional prefix for the temp directory name
- * @returns absolute path to the temp repo
- */
-export function makeTempRepo(prefix: string = "gsd-test-"): string {
-  const dir = mkdtempSync(join(tmpdir(), prefix));
-  git(dir, "init");
-  git(dir, "config", "user.email", "test@test.com");
-  git(dir, "config", "user.name", "Test");
-  git(dir, "config", "core.autocrlf", "false");
-  writeFileSync(join(dir, "README.md"), "# init\n");
-  git(dir, "add", "-A");
-  git(dir, "commit", "-m", "init");
-  git(dir, "branch", "-M", "main");
-  return dir;
-}
-
-/**
- * Create a temporary directory (not a git repo).
- *
- * @param prefix - Optional prefix for the temp directory name
- * @returns absolute path to the temp directory
- */
-export function makeTempDir(prefix: string = "gsd-test-"): string {
-  return mkdtempSync(join(tmpdir(), prefix));
-}
-
-/**
- * Safely clean up a temporary directory.
- * Non-fatal — Windows may hold file descriptors briefly.
- */
-export function cleanup(dir: string): void {
-  try {
-    rmSync(dir, { recursive: true, force: true });
-  } catch {
-    // ignore — Windows may hold file descriptors briefly after test
-  }
-}
-
-/**
- * Create a file with intermediate directories.
- *
- * @param base - Base directory
- * @param relativePath - Relative path within base (e.g., "src/index.ts")
- * @param content - File content (defaults to empty string)
- * @returns absolute path to the created file
- */
-export function createFile(base: string, relativePath: string, content: string = ""): string {
-  const fullPath = join(base, relativePath);
-  mkdirSync(dirname(fullPath), { recursive: true });
-  writeFileSync(fullPath, content, "utf-8");
-  return fullPath;
-}
-
-/**
- * Safely read a file, returning null if it doesn't exist or is a directory.
- * Prevents EISDIR errors.
- */
-export function safeReadFile(filePath: string): string | null {
-  try {
-    if (!existsSync(filePath)) return null;
-    if (!statSync(filePath).isFile()) return null;
-    return readFileSync(filePath, "utf-8");
-  } catch {
-    return null;
-  }
-}
-
-/**
- * Create a minimal GSD milestone structure in a temp directory.
- *
- * @param base - Base directory (should have .gsd/ or be a temp repo)
- * @param mid - Milestone ID (e.g., "M001")
- * @param options - What to create
- */
-export function writeMilestoneFixture(
-  base: string,
-  mid: string,
-  options: {
-    roadmap?: string;
-    context?: string;
-    summary?: string;
-    validation?: string;
-    slices?: Array<{
-      id: string;
-      plan?: string;
-      summary?: string;
-      uat?: string;
-    }>;
-  } = {},
-): void {
-  const milestoneDir = join(base, ".gsd", "milestones", mid);
-  mkdirSync(milestoneDir, { recursive: true });
-
-  if (options.roadmap) {
-    writeFileSync(join(milestoneDir, `${mid}-ROADMAP.md`), options.roadmap);
-  }
-  if (options.context) {
-    writeFileSync(join(milestoneDir, `${mid}-CONTEXT.md`), options.context);
-  }
-  if (options.summary) {
-    writeFileSync(join(milestoneDir, `${mid}-SUMMARY.md`), options.summary);
-  }
-  if (options.validation) {
-    writeFileSync(join(milestoneDir, `${mid}-VALIDATION.md`), options.validation);
-  }
-  if (options.slices) {
-    for (const slice of options.slices) {
-      const sliceDir = join(milestoneDir, "slices", slice.id);
-      mkdirSync(sliceDir, { recursive: true });
-      if (slice.plan) {
-        writeFileSync(join(sliceDir, `${slice.id}-PLAN.md`), slice.plan);
-      }
-      if (slice.summary) {
-        writeFileSync(join(sliceDir, `${slice.id}-SUMMARY.md`), slice.summary);
-      }
-      if (slice.uat) {
-        writeFileSync(join(sliceDir, `${slice.id}-UAT.md`), slice.uat);
-      }
-    }
-  }
-}

package/src/resources/extensions/gsd/tests/token-cost-display.test.ts

@@ -1,118 +0,0 @@
-/**
- * Tests for the show_token_cost preference (#1515).
- *
- * Covers:
- *   - Preference recognition and validation
- *   - Cost formatting accuracy (inline re-implementation for test isolation)
- *   - Disabled-by-default behavior
- *   - Preference parsing from markdown frontmatter
- */
-
-import test from "node:test";
-import assert from "node:assert/strict";
-import {
-  validatePreferences,
-  parsePreferencesMarkdown,
-} from "../preferences.ts";
-import { KNOWN_PREFERENCE_KEYS } from "../preferences-types.ts";
-
-// Re-implement formatPromptCost here for test isolation (avoids pi-coding-agent build dep).
-// The canonical implementation lives in footer.ts.
-function formatPromptCost(cost: number): string {
-  if (cost < 0.001) return `$${cost.toFixed(4)}`;
-  if (cost < 0.01) return `$${cost.toFixed(3)}`;
-  if (cost < 1) return `$${cost.toFixed(3)}`;
-  return `$${cost.toFixed(2)}`;
-}
-
-// ── Preference recognition ──────────────────────────────────────────────────
-
-test("show_token_cost is a known preference key", () => {
-  assert.ok(KNOWN_PREFERENCE_KEYS.has("show_token_cost"));
-});
-
-test("show_token_cost: true validates without errors", () => {
-  const { errors, preferences } = validatePreferences({ show_token_cost: true });
-  assert.equal(errors.length, 0);
-  assert.equal(preferences.show_token_cost, true);
-});
-
-test("show_token_cost: false validates without errors", () => {
-  const { errors, preferences } = validatePreferences({ show_token_cost: false });
-  assert.equal(errors.length, 0);
-  assert.equal(preferences.show_token_cost, false);
-});
-
-test("show_token_cost: non-boolean produces validation error", () => {
-  const { errors } = validatePreferences({ show_token_cost: "yes" as any });
-  assert.ok(errors.length > 0);
-  assert.ok(errors[0].includes("show_token_cost"));
-  assert.ok(errors[0].includes("boolean"));
-});
-
-test("show_token_cost does not produce unknown-key warning", () => {
-  const { warnings } = validatePreferences({ show_token_cost: true });
-  const unknownWarnings = warnings.filter(w => w.includes("show_token_cost"));
-  assert.equal(unknownWarnings.length, 0);
-});
-
-// ── Disabled by default ─────────────────────────────────────────────────────
-
-test("show_token_cost defaults to undefined (disabled) when not set", () => {
-  const { preferences } = validatePreferences({});
-  assert.equal(preferences.show_token_cost, undefined);
-});
-
-test("empty PREFERENCES.md does not enable show_token_cost", () => {
-  const prefs = parsePreferencesMarkdown("---\nversion: 1\n---\n");
-  assert.ok(prefs);
-  assert.equal(prefs.show_token_cost, undefined);
-});
-
-test("PREFERENCES.md with show_token_cost: true enables the preference", () => {
-  const prefs = parsePreferencesMarkdown("---\nshow_token_cost: true\n---\n");
-  assert.ok(prefs);
-  assert.equal(prefs.show_token_cost, true);
-});
-
-// ── Cost formatting ─────────────────────────────────────────────────────────
-
-test("formatPromptCost formats sub-cent amounts with 4 decimals", () => {
-  assert.equal(formatPromptCost(0.0003), "$0.0003");
-  assert.equal(formatPromptCost(0.0009), "$0.0009");
-});
-
-test("formatPromptCost formats cent-range amounts with 3 decimals", () => {
-  assert.equal(formatPromptCost(0.003), "$0.003");
-  assert.equal(formatPromptCost(0.012), "$0.012");
-  assert.equal(formatPromptCost(0.1), "$0.100");
-});
-
-test("formatPromptCost formats dollar-range amounts with 2 decimals", () => {
-  assert.equal(formatPromptCost(1.5), "$1.50");
-  assert.equal(formatPromptCost(12.345), "$12.35");
-});
-
-test("formatPromptCost handles zero", () => {
-  assert.equal(formatPromptCost(0), "$0.0000");
-});
-
-// ── Cost calculation correctness ────────────────────────────────────────────
-
-test("cost calculation formula matches Model cost structure", () => {
-  // Simulates: usage.input * model.cost.input / 1_000_000 + usage.output * model.cost.output / 1_000_000
-  // Model.cost fields are $/million tokens
-  const modelCost = { input: 15, output: 75, cacheRead: 1.5, cacheWrite: 18.75 }; // claude-opus-4 pricing
-  const usage = { input: 2000, output: 500, cacheRead: 10000, cacheWrite: 1000 };
-
-  const cost =
-    (usage.input * modelCost.input / 1_000_000) +
-    (usage.output * modelCost.output / 1_000_000) +
-    (usage.cacheRead * modelCost.cacheRead / 1_000_000) +
-    (usage.cacheWrite * modelCost.cacheWrite / 1_000_000);
-
-  // 2000*15/1M + 500*75/1M + 10000*1.5/1M + 1000*18.75/1M
-  // = 0.03 + 0.0375 + 0.015 + 0.01875 = 0.10125
-  assert.ok(Math.abs(cost - 0.10125) < 0.0001, `Expected ~$0.10125 but got $${cost}`);
-  assert.equal(formatPromptCost(cost), "$0.101");
-});

package/src/resources/extensions/gsd/tests/token-counter.test.ts

@@ -1,129 +0,0 @@
-/**
- * Unit tests for token-counter.ts — provider-aware token estimation.
- */
-
-import { describe, it } from "node:test";
-import assert from "node:assert/strict";
-
-import {
-  type TokenProvider,
-  estimateTokensForProvider,
-  getCharsPerToken,
-  countTokensSync,
-  countTokens,
-} from "../token-counter.js";
-
-// ─── getCharsPerToken ─────────────────────────────────────────────────────────
-
-describe("token-counter: getCharsPerToken", () => {
-  it("returns 3.5 for anthropic", () => {
-    assert.equal(getCharsPerToken("anthropic"), 3.5);
-  });
-
-  it("returns 4.0 for openai", () => {
-    assert.equal(getCharsPerToken("openai"), 4.0);
-  });
-
-  it("returns 4.0 for google", () => {
-    assert.equal(getCharsPerToken("google"), 4.0);
-  });
-
-  it("returns 3.8 for mistral", () => {
-    assert.equal(getCharsPerToken("mistral"), 3.8);
-  });
-
-  it("returns 3.5 for bedrock", () => {
-    assert.equal(getCharsPerToken("bedrock"), 3.5);
-  });
-
-  it("returns 4.0 for unknown", () => {
-    assert.equal(getCharsPerToken("unknown"), 4.0);
-  });
-});
-
-// ─── estimateTokensForProvider ────────────────────────────────────────────────
-
-describe("token-counter: estimateTokensForProvider", () => {
-  const sampleText = "A".repeat(1000);
-
-  it("estimates tokens for anthropic using 3.5 chars/token ratio", () => {
-    const tokens = estimateTokensForProvider(sampleText, "anthropic");
-    assert.equal(tokens, Math.ceil(1000 / 3.5));
-  });
-
-  it("estimates tokens for openai using 4.0 chars/token ratio", () => {
-    const tokens = estimateTokensForProvider(sampleText, "openai");
-    assert.equal(tokens, Math.ceil(1000 / 4.0));
-  });
-
-  it("estimates tokens for google using 4.0 chars/token ratio", () => {
-    const tokens = estimateTokensForProvider(sampleText, "google");
-    assert.equal(tokens, Math.ceil(1000 / 4.0));
-  });
-
-  it("estimates tokens for mistral using 3.8 chars/token ratio", () => {
-    const tokens = estimateTokensForProvider(sampleText, "mistral");
-    assert.equal(tokens, Math.ceil(1000 / 3.8));
-  });
-
-  it("estimates tokens for bedrock using 3.5 chars/token ratio", () => {
-    const tokens = estimateTokensForProvider(sampleText, "bedrock");
-    assert.equal(tokens, Math.ceil(1000 / 3.5));
-  });
-
-  it("estimates tokens for unknown using 4.0 chars/token ratio", () => {
-    const tokens = estimateTokensForProvider(sampleText, "unknown");
-    assert.equal(tokens, Math.ceil(1000 / 4.0));
-  });
-
-  it("anthropic estimates are ~14% higher than openai for same text", () => {
-    const anthropicTokens = estimateTokensForProvider(sampleText, "anthropic");
-    const openaiTokens = estimateTokensForProvider(sampleText, "openai");
-
-    // anthropic: 1000/3.5 ≈ 286, openai: 1000/4.0 = 250
-    // ratio: 286/250 ≈ 1.143 (~14% higher)
-    const ratio = anthropicTokens / openaiTokens;
-    assert.ok(ratio > 1.10, `expected anthropic to be >10% higher, ratio was ${ratio}`);
-    assert.ok(ratio < 1.20, `expected anthropic to be <20% higher, ratio was ${ratio}`);
-  });
-
-  it("handles empty string", () => {
-    const tokens = estimateTokensForProvider("", "openai");
-    assert.equal(tokens, 0);
-  });
-
-  it("handles single character", () => {
-    const tokens = estimateTokensForProvider("X", "openai");
-    assert.equal(tokens, 1); // ceil(1/4) = 1
-  });
-});
-
-// ─── backward compatibility ──────────────────────────────────────────────────
-
-describe("token-counter: backward compatibility", () => {
-  it("countTokensSync returns heuristic estimate when tiktoken is not loaded", () => {
-    // Without tiktoken loaded, countTokensSync falls back to ceil(len/4)
-    const text = "A".repeat(100);
-    const result = countTokensSync(text);
-    // Either tiktoken is loaded (exact count) or heuristic (ceil(100/4) = 25)
-    assert.ok(result > 0, "should return a positive count");
-    assert.ok(typeof result === "number", "should return a number");
-  });
-
-  it("countTokens returns a positive count", async () => {
-    const text = "Hello, this is a test string for token counting.";
-    const result = await countTokens(text);
-    assert.ok(result > 0, "should return a positive count");
-    assert.ok(typeof result === "number", "should return a number");
-  });
-
-  it("countTokensSync handles empty string", () => {
-    const result = countTokensSync("");
-    assert.equal(result, 0);
-  });
-
-  it("countTokens handles empty string", async () => {
-    const result = await countTokens("");
-    assert.equal(result, 0);
-  });
-});

package/src/resources/extensions/gsd/tests/token-profile.test.ts

@@ -1,268 +0,0 @@
-/**
- * Token Profile — unit tests for M004/S01.
- *
- * Tests profile resolution, preference merging, phase skip defaults,
- * subagent model routing, default-to-balanced behavior, and dispatch
- * table guard clauses (source-level structural verification).
- *
- * Uses source-level checks (readFileSync + string matching) to avoid
- * @gsd/pi-coding-agent import resolution issues in dev environments.
- */
-
-import test from "node:test";
-import assert from "node:assert/strict";
-import { readFileSync } from "node:fs";
-import { join, dirname } from "node:path";
-import { fileURLToPath } from "node:url";
-
-const __dirname = dirname(fileURLToPath(import.meta.url));
-
-// ─── Source files for structural checks ───────────────────────────────────
-// After decomposition, code lives across multiple modules. Concatenate them
-// so structural string-matching works regardless of which file holds the code.
-
-const dispatchSrc = readFileSync(join(__dirname, "..", "auto-dispatch.ts"), "utf-8");
-const preferencesSrc = [
-  readFileSync(join(__dirname, "..", "preferences.ts"), "utf-8"),
-  readFileSync(join(__dirname, "..", "preferences-types.ts"), "utf-8"),
-  readFileSync(join(__dirname, "..", "preferences-models.ts"), "utf-8"),
-  readFileSync(join(__dirname, "..", "preferences-validation.ts"), "utf-8"),
-].join("\n");
-const typesSrc = readFileSync(join(__dirname, "..", "types.ts"), "utf-8");
-
-// ═══════════════════════════════════════════════════════════════════════════
-// Type Definitions
-// ═══════════════════════════════════════════════════════════════════════════
-
-test("types: TokenProfile type exported with budget/balanced/quality", () => {
-  assert.ok(typesSrc.includes("export type TokenProfile"), "TokenProfile should be exported");
-  assert.match(typesSrc, /["']budget["']/, "should include budget");
-  assert.match(typesSrc, /["']balanced["']/, "should include balanced");
-  assert.match(typesSrc, /["']quality["']/, "should include quality");
-});
-
-test("types: InlineLevel type exported with full/standard/minimal", () => {
-  assert.ok(typesSrc.includes("export type InlineLevel"), "InlineLevel should be exported");
-  assert.match(typesSrc, /["']full["']/, "should include full");
-  assert.match(typesSrc, /["']standard["']/, "should include standard");
-  assert.match(typesSrc, /["']minimal["']/, "should include minimal");
-});
-
-test("types: PhaseSkipPreferences interface exported", () => {
-  assert.ok(typesSrc.includes("export interface PhaseSkipPreferences"), "PhaseSkipPreferences should be exported");
-  assert.ok(typesSrc.includes("skip_research"), "should include skip_research");
-  assert.ok(typesSrc.includes("skip_reassess"), "should include skip_reassess");
-  assert.ok(typesSrc.includes("skip_slice_research"), "should include skip_slice_research");
-  assert.ok(typesSrc.includes("reassess_after_slice"), "should include reassess_after_slice");
-});
-
-// ═══════════════════════════════════════════════════════════════════════════
-// GSDPreferences Interface
-// ═══════════════════════════════════════════════════════════════════════════
-
-test("preferences: GSDPreferences includes token_profile field", () => {
-  assert.ok(
-    preferencesSrc.includes("token_profile?: TokenProfile"),
-    "GSDPreferences should have token_profile field",
-  );
-});
-
-test("preferences: GSDPreferences includes phases field", () => {
-  assert.ok(
-    preferencesSrc.includes("phases?: PhaseSkipPreferences"),
-    "GSDPreferences should have phases field",
-  );
-});
-
-test("preferences: GSDModelConfig includes subagent field", () => {
-  // Check both v1 and v2 configs
-  const v1Match = preferencesSrc.match(/interface GSDModelConfig\s*\{[^}]*subagent/);
-  assert.ok(v1Match, "GSDModelConfig should have subagent field");
-  const v2Match = preferencesSrc.match(/interface GSDModelConfigV2\s*\{[^}]*subagent/);
-  assert.ok(v2Match, "GSDModelConfigV2 should have subagent field");
-});
-
-test("preferences: KNOWN_PREFERENCE_KEYS includes token_profile and phases", () => {
-  assert.ok(preferencesSrc.includes('"token_profile"'), "KNOWN_PREFERENCE_KEYS should include token_profile");
-  assert.ok(preferencesSrc.includes('"phases"'), "KNOWN_PREFERENCE_KEYS should include phases");
-});
-
-// ═══════════════════════════════════════════════════════════════════════════
-// Profile Resolution
-// ═══════════════════════════════════════════════════════════════════════════
-
-test("profile: resolveProfileDefaults exists and handles all 3 tiers", () => {
-  assert.ok(
-    preferencesSrc.includes("export function resolveProfileDefaults"),
-    "resolveProfileDefaults should be exported",
-  );
-  assert.ok(
-    preferencesSrc.includes('case "budget"') &&
-    preferencesSrc.includes('case "balanced"') &&
-    preferencesSrc.includes('case "quality"'),
-    "resolveProfileDefaults should handle all 3 tiers",
-  );
-});
-
-test("profile: budget profile sets phase skips to true", () => {
-  // Extract the budget case block
-  const budgetIdx = preferencesSrc.indexOf('case "budget":');
-  const balancedIdx = preferencesSrc.indexOf('case "balanced":');
-  const budgetBlock = preferencesSrc.slice(budgetIdx, balancedIdx);
-  assert.ok(budgetBlock.includes("skip_research: true"), "budget should skip research");
-  assert.ok(budgetBlock.includes("skip_reassess: true"), "budget should skip reassess");
-  assert.ok(budgetBlock.includes("skip_slice_research: true"), "budget should skip slice research");
-});
-
-test("profile: balanced profile skips research, reassess, and slice research (ADR-003)", () => {
-  const balancedIdx = preferencesSrc.indexOf('case "balanced":');
-  const qualityIdx = preferencesSrc.indexOf('case "quality":');
-  const balancedBlock = preferencesSrc.slice(balancedIdx, qualityIdx);
-  assert.ok(balancedBlock.includes("skip_slice_research: true"), "balanced should skip slice research");
-  assert.ok(balancedBlock.includes("skip_research: true"), "balanced should skip milestone research");
-  assert.ok(balancedBlock.includes("skip_reassess: true"), "balanced should skip reassess");
-});
-
-test("profile: quality profile skips research, slice research, and reassess (ADR-003)", () => {
-  const qualityIdx = preferencesSrc.indexOf('case "quality":');
-  const qualityBlock = preferencesSrc.slice(qualityIdx, qualityIdx + 300);
-  assert.ok(qualityBlock.includes("skip_research: true"), "quality should skip research");
-  assert.ok(qualityBlock.includes("skip_slice_research: true"), "quality should skip slice research");
-  assert.ok(qualityBlock.includes("skip_reassess: true"), "quality should skip reassess");
-});
-
-// ═══════════════════════════════════════════════════════════════════════════
-// Default Behavior (D046)
-// ═══════════════════════════════════════════════════════════════════════════
-
-test("profile: resolveEffectiveProfile defaults to balanced (D046)", () => {
-  assert.ok(
-    preferencesSrc.includes("export function resolveEffectiveProfile"),
-    "resolveEffectiveProfile should be exported",
-  );
-  assert.ok(
-    preferencesSrc.includes('return "balanced"'),
-    "resolveEffectiveProfile should default to balanced",
-  );
-});
-
-// ═══════════════════════════════════════════════════════════════════════════
-// Inline Level Mapping
-// ═══════════════════════════════════════════════════════════════════════════
-
-test("profile: resolveInlineLevel maps profile to inline level", () => {
-  assert.ok(
-    preferencesSrc.includes("export function resolveInlineLevel"),
-    "resolveInlineLevel should be exported",
-  );
-  assert.ok(preferencesSrc.includes('case "budget": return "minimal"'), "budget → minimal");
-  assert.ok(preferencesSrc.includes('case "balanced": return "standard"'), "balanced → standard");
-  assert.ok(preferencesSrc.includes('case "quality": return "full"'), "quality → full");
-});
-
-// ═══════════════════════════════════════════════════════════════════════════
-// Validation
-// ═══════════════════════════════════════════════════════════════════════════
-
-test("validate: validatePreferences handles token_profile", () => {
-  assert.ok(
-    preferencesSrc.includes("preferences.token_profile") &&
-    preferencesSrc.includes("budget, balanced, quality"),
-    "validatePreferences should validate token_profile enum values",
-  );
-});
-
-test("validate: validatePreferences handles phases object", () => {
-  assert.ok(
-    preferencesSrc.includes("preferences.phases") &&
-    preferencesSrc.includes("skip_research") &&
-    preferencesSrc.includes("skip_reassess") &&
-    preferencesSrc.includes("skip_slice_research"),
-    "validatePreferences should validate phases fields",
-  );
-});
-
-test("validate: phases warns on unknown keys", () => {
-  assert.ok(
-    preferencesSrc.includes("knownPhaseKeys") &&
-    preferencesSrc.includes("unknown phases key"),
-    "validatePreferences should warn on unknown phase keys",
-  );
-});
-
-// ═══════════════════════════════════════════════════════════════════════════
-// Merge
-// ═══════════════════════════════════════════════════════════════════════════
-
-test("merge: mergePreferences handles token_profile with nullish coalescing", () => {
-  assert.ok(
-    preferencesSrc.includes("token_profile: override.token_profile ?? base.token_profile"),
-    "mergePreferences should use nullish coalescing for token_profile",
-  );
-});
-
-test("merge: mergePreferences handles phases with spread", () => {
-  assert.ok(
-    preferencesSrc.includes("...(base.phases") && preferencesSrc.includes("...(override.phases"),
-    "mergePreferences should spread phases objects",
-  );
-});
-
-// ═══════════════════════════════════════════════════════════════════════════
-// Subagent Model Routing
-// ═══════════════════════════════════════════════════════════════════════════
-
-test("subagent: budget profile sets subagent model", () => {
-  const budgetIdx = preferencesSrc.indexOf('case "budget":');
-  const balancedIdx = preferencesSrc.indexOf('case "balanced":');
-  const budgetBlock = preferencesSrc.slice(budgetIdx, balancedIdx);
-  assert.ok(budgetBlock.includes("subagent:"), "budget profile should set subagent model");
-});
-
-test("subagent: resolveModelWithFallbacksForUnit handles subagent unit types", () => {
-  assert.ok(
-    preferencesSrc.includes('"subagent"') && preferencesSrc.includes('startsWith("subagent/")'),
-    "resolveModelWithFallbacksForUnit should handle subagent and subagent/* unit types",
-  );
-});
-
-// ═══════════════════════════════════════════════════════════════════════════
-// Dispatch Table — Phase Skip Guards
-// ═══════════════════════════════════════════════════════════════════════════
-
-test("dispatch: research-milestone rule has skip_research guard", () => {
-  // Find the research-milestone rule and check it has the guard
-  const ruleIdx = dispatchSrc.indexOf("research-milestone");
-  assert.ok(ruleIdx > -1, "should have research-milestone rule");
-  // The guard should appear near this rule
-  assert.ok(
-    dispatchSrc.includes("skip_research") && dispatchSrc.includes("research-milestone"),
-    "research-milestone dispatch rule should check phases.skip_research",
-  );
-});
-
-test("dispatch: research-slice rule has skip guards", () => {
-  const ruleIdx = dispatchSrc.indexOf("research-slice");
-  assert.ok(ruleIdx > -1, "should have research-slice rule");
-  const afterRule = dispatchSrc.slice(ruleIdx);
-  assert.ok(
-    afterRule.includes("skip_research") || afterRule.includes("skip_slice_research"),
-    "research-slice rule should check skip_research or skip_slice_research",
-  );
-});
-
-test("dispatch: reassess-roadmap rule has reassess_after_slice opt-in guard (ADR-003)", () => {
-  assert.ok(
-    dispatchSrc.includes("reassess_after_slice") && dispatchSrc.includes("reassess-roadmap"),
-    "reassess-roadmap dispatch rule should check phases.reassess_after_slice",
-  );
-});
-
-test("dispatch: phase skip guards return null (not stop)", () => {
-  // Verify skip guards use return null pattern
-  const researchGuard = dispatchSrc.match(/skip_research\).*?return null/s);
-  assert.ok(researchGuard, "skip_research guard should return null (fall-through)");
-
-  const reassessGuard = dispatchSrc.match(/reassess_after_slice\).*?return null/s);
-  assert.ok(reassessGuard, "reassess_after_slice guard should return null (fall-through)");
-});