lsd-pi 1.0.0 → 1.1.1

package/src/resources/extensions/gsd/tests/auto-milestone-target.test.ts

@@ -1,61 +0,0 @@
-import { describe, it } from "node:test";
-import assert from "node:assert/strict";
-
-import { parseMilestoneTarget } from "../commands/handlers/auto.js";
-
-describe("parseMilestoneTarget", () => {
-  it("extracts a simple milestone ID", () => {
-    const result = parseMilestoneTarget("auto M016");
-    assert.equal(result.milestoneId, "M016");
-    assert.equal(result.rest, "auto");
-  });
-
-  it("extracts a milestone ID with unique suffix", () => {
-    const result = parseMilestoneTarget("auto M001-a3b4c5 --verbose");
-    assert.equal(result.milestoneId, "M001-a3b4c5");
-    assert.equal(result.rest, "auto --verbose");
-  });
-
-  it("returns null when no milestone ID is present", () => {
-    const result = parseMilestoneTarget("auto --verbose");
-    assert.equal(result.milestoneId, null);
-    assert.equal(result.rest, "auto --verbose");
-  });
-
-  it("extracts milestone ID with flags in any order", () => {
-    const result = parseMilestoneTarget("auto --verbose M003 --debug");
-    assert.equal(result.milestoneId, "M003");
-    assert.equal(result.rest, "auto --verbose --debug");
-  });
-
-  it("returns null for plain 'auto'", () => {
-    const result = parseMilestoneTarget("auto");
-    assert.equal(result.milestoneId, null);
-    assert.equal(result.rest, "auto");
-  });
-
-  it("extracts from 'next' command", () => {
-    const result = parseMilestoneTarget("next M012");
-    assert.equal(result.milestoneId, "M012");
-    assert.equal(result.rest, "next");
-  });
-
-  it("handles milestone ID at the start of input", () => {
-    const result = parseMilestoneTarget("M007");
-    assert.equal(result.milestoneId, "M007");
-    assert.equal(result.rest, "");
-  });
-
-  it("picks the first milestone ID when multiple appear", () => {
-    // Edge case: user accidentally types two. First one wins.
-    const result = parseMilestoneTarget("auto M001 M002");
-    assert.equal(result.milestoneId, "M001");
-    // M002 remains in rest since only the first match is removed
-    assert.ok(result.rest.includes("M002"));
-  });
-
-  it("does not match bare numbers without M prefix", () => {
-    const result = parseMilestoneTarget("auto 016");
-    assert.equal(result.milestoneId, null);
-  });
-});

package/src/resources/extensions/gsd/tests/auto-mode-interactive-guard.test.ts

@@ -1,71 +0,0 @@
-/**
- * Test: auto-mode prompts must prohibit ask_user_questions / secure_env_collect
- *
- * Bug #2936: When the LLM calls ask_user_questions during auto-mode units
- * (plan-slice, execute-task, complete-slice), the interactive tool queues a
- * user response which causes the subsequent gsd_plan_slice / gsd_complete_task
- * call to fail with "Skipped due to queued user message." The canonical GSD
- * tool call is never recorded, verifyExpectedArtifact finds no artifact, and
- * the dispatch loop re-dispatches the same unit 2-4x.
- *
- * Fix: Each auto-mode prompt must contain an "Autonomous execution" guard
- * that explicitly prohibits ask_user_questions and secure_env_collect.
- */
-
-import test from "node:test";
-import assert from "node:assert/strict";
-import { readFileSync } from "node:fs";
-import { join, dirname } from "node:path";
-import { fileURLToPath } from "node:url";
-
-const __dirname = dirname(fileURLToPath(import.meta.url));
-const promptsDir = join(__dirname, "..", "prompts");
-
-function loadPromptRaw(name: string): string {
-  return readFileSync(join(promptsDir, `${name}.md`), "utf-8");
-}
-
-const AUTO_MODE_PROMPTS = ["plan-slice", "execute-task", "complete-slice"];
-
-for (const promptName of AUTO_MODE_PROMPTS) {
-  test(`${promptName} prompt prohibits ask_user_questions in auto-mode`, () => {
-    const content = loadPromptRaw(promptName);
-
-    assert.ok(
-      content.includes("ask_user_questions"),
-      `${promptName}.md must mention ask_user_questions (to prohibit it)`,
-    );
-
-    assert.ok(
-      content.includes("secure_env_collect"),
-      `${promptName}.md must mention secure_env_collect (to prohibit it)`,
-    );
-
-    // The guard must clearly state this is autonomous / auto-mode
-    assert.ok(
-      content.toLowerCase().includes("auto-mode") || content.toLowerCase().includes("autonomous"),
-      `${promptName}.md must reference auto-mode or autonomous execution`,
-    );
-
-    // The guard must indicate no human is available
-    assert.ok(
-      content.includes("no human") || content.includes("no user"),
-      `${promptName}.md must state that no human/user is available to answer`,
-    );
-  });
-}
-
-test("auto-mode prompts contain autonomous guard before final tool call reminder", () => {
-  for (const promptName of AUTO_MODE_PROMPTS) {
-    const content = loadPromptRaw(promptName);
-
-    // The guard should appear before the final "MUST call" line
-    const guardIndex = content.indexOf("ask_user_questions");
-    const mustCallIndex = content.lastIndexOf("MUST call");
-
-    assert.ok(
-      guardIndex !== -1 && mustCallIndex !== -1 && guardIndex < mustCallIndex,
-      `${promptName}.md: autonomous guard (ask_user_questions prohibition) must appear before the final MUST call reminder`,
-    );
-  }
-});

package/src/resources/extensions/gsd/tests/auto-model-selection.test.ts

@@ -1,209 +0,0 @@
-import test from "node:test";
-import assert from "node:assert/strict";
-import { mkdtempSync, mkdirSync, rmSync, writeFileSync } from "node:fs";
-import { join } from "node:path";
-import { tmpdir } from "node:os";
-
-import { resolvePreferredModelConfig, resolveModelId } from "../auto-model-selection.js";
-
-function makeTempDir(prefix: string): string {
-  return mkdtempSync(join(tmpdir(), prefix));
-}
-
-test("resolvePreferredModelConfig synthesizes heavy routing ceiling when models section is absent", () => {
-  const originalCwd = process.cwd();
-  const originalGsdHome = process.env.LSD_HOME;
-  const tempProject = makeTempDir("gsd-routing-project-");
-  const tempGsdHome = makeTempDir("gsd-routing-home-");
-
-  try {
-    mkdirSync(join(tempProject, ".gsd"), { recursive: true });
-    writeFileSync(
-      join(tempProject, ".gsd", "PREFERENCES.md"),
-      [
-        "---",
-        "dynamic_routing:",
-        "  enabled: true",
-        "  tier_models:",
-        "    light: claude-haiku-4-5",
-        "    standard: claude-sonnet-4-6",
-        "    heavy: claude-opus-4-6",
-        "---",
-      ].join("\n"),
-      "utf-8",
-    );
-    process.env.LSD_HOME = tempGsdHome;
-    process.chdir(tempProject);
-
-    const config = resolvePreferredModelConfig("plan-slice", {
-      provider: "anthropic",
-      id: "claude-sonnet-4-6",
-    });
-
-    assert.deepEqual(config, {
-      primary: "claude-opus-4-6",
-      fallbacks: [],
-    });
-  } finally {
-    process.chdir(originalCwd);
-    if (originalGsdHome === undefined) delete process.env.LSD_HOME;
-    else process.env.LSD_HOME = originalGsdHome;
-    rmSync(tempProject, { recursive: true, force: true });
-    rmSync(tempGsdHome, { recursive: true, force: true });
-  }
-});
-
-test("resolvePreferredModelConfig falls back to auto start model when heavy tier is absent", () => {
-  const originalCwd = process.cwd();
-  const originalGsdHome = process.env.LSD_HOME;
-  const tempProject = makeTempDir("gsd-routing-project-");
-  const tempGsdHome = makeTempDir("gsd-routing-home-");
-
-  try {
-    mkdirSync(join(tempProject, ".gsd"), { recursive: true });
-    writeFileSync(
-      join(tempProject, ".gsd", "PREFERENCES.md"),
-      [
-        "---",
-        "dynamic_routing:",
-        "  enabled: true",
-        "  tier_models:",
-        "    light: claude-haiku-4-5",
-        "    standard: claude-sonnet-4-6",
-        "---",
-      ].join("\n"),
-      "utf-8",
-    );
-    process.env.LSD_HOME = tempGsdHome;
-    process.chdir(tempProject);
-
-    const config = resolvePreferredModelConfig("execute-task", {
-      provider: "openai",
-      id: "gpt-5.4",
-    });
-
-    assert.deepEqual(config, {
-      primary: "openai/gpt-5.4",
-      fallbacks: [],
-    });
-  } finally {
-    process.chdir(originalCwd);
-    if (originalGsdHome === undefined) delete process.env.LSD_HOME;
-    else process.env.LSD_HOME = originalGsdHome;
-    rmSync(tempProject, { recursive: true, force: true });
-    rmSync(tempGsdHome, { recursive: true, force: true });
-  }
-});
-
-test("resolvePreferredModelConfig keeps explicit phase models as the ceiling", () => {
-  const originalCwd = process.cwd();
-  const originalGsdHome = process.env.LSD_HOME;
-  const tempProject = makeTempDir("gsd-routing-project-");
-  const tempGsdHome = makeTempDir("gsd-routing-home-");
-
-  try {
-    mkdirSync(join(tempProject, ".gsd"), { recursive: true });
-    writeFileSync(
-      join(tempProject, ".gsd", "PREFERENCES.md"),
-      [
-        "---",
-        "models:",
-        "  planning: claude-sonnet-4-6",
-        "dynamic_routing:",
-        "  enabled: true",
-        "  tier_models:",
-        "    heavy: claude-opus-4-6",
-        "---",
-      ].join("\n"),
-      "utf-8",
-    );
-    process.env.LSD_HOME = tempGsdHome;
-    process.chdir(tempProject);
-
-    const config = resolvePreferredModelConfig("plan-slice", {
-      provider: "anthropic",
-      id: "claude-opus-4-6",
-    });
-
-    assert.deepEqual(config, {
-      primary: "claude-sonnet-4-6",
-      fallbacks: [],
-    });
-  } finally {
-    process.chdir(originalCwd);
-    if (originalGsdHome === undefined) delete process.env.LSD_HOME;
-    else process.env.LSD_HOME = originalGsdHome;
-    rmSync(tempProject, { recursive: true, force: true });
-    rmSync(tempGsdHome, { recursive: true, force: true });
-  }
-});
-
-// ─── resolveModelId tests ─────────────────────────────────────────────────
-
-test("resolveModelId: bare ID resolves to anthropic over claude-code when session is claude-code (#2905)", () => {
-  const availableModels = [
-    { id: "claude-sonnet-4-6", provider: "anthropic" },
-    { id: "claude-sonnet-4-6", provider: "claude-code" },
-  ];
-
-  // Bug: when currentProvider is "claude-code", bare ID "claude-sonnet-4-6"
-  // resolves to claude-code/claude-sonnet-4-6 instead of anthropic/claude-sonnet-4-6
-  const result = resolveModelId("claude-sonnet-4-6", availableModels, "claude-code");
-  assert.ok(result, "should resolve a model");
-  assert.equal(result.provider, "anthropic", "bare ID must resolve to anthropic, not claude-code");
-});
-
-test("resolveModelId: bare ID still prefers current provider when it is a first-class API provider", () => {
-  const availableModels = [
-    { id: "claude-sonnet-4-6", provider: "anthropic" },
-    { id: "claude-sonnet-4-6", provider: "bedrock" },
-  ];
-
-  const result = resolveModelId("claude-sonnet-4-6", availableModels, "bedrock");
-  assert.ok(result, "should resolve a model");
-  assert.equal(result.provider, "bedrock", "bare ID should prefer current provider when it is a real API provider");
-});
-
-test("resolveModelId: explicit provider/model format still resolves to claude-code when specified", () => {
-  const availableModels = [
-    { id: "claude-sonnet-4-6", provider: "anthropic" },
-    { id: "claude-sonnet-4-6", provider: "claude-code" },
-  ];
-
-  const result = resolveModelId("claude-code/claude-sonnet-4-6", availableModels, "anthropic");
-  assert.ok(result, "should resolve a model");
-  assert.equal(result.provider, "claude-code", "explicit provider prefix must be respected");
-});
-
-test("resolveModelId: bare ID with only one provider works normally", () => {
-  const availableModels = [
-    { id: "claude-sonnet-4-6", provider: "anthropic" },
-  ];
-
-  const result = resolveModelId("claude-sonnet-4-6", availableModels, "anthropic");
-  assert.ok(result, "should resolve a model");
-  assert.equal(result.provider, "anthropic");
-});
-
-test("resolveModelId: bare ID with claude-code as only provider still resolves", () => {
-  const availableModels = [
-    { id: "claude-sonnet-4-6", provider: "claude-code" },
-  ];
-
-  // If claude-code is the ONLY provider for this model, it should still resolve
-  const result = resolveModelId("claude-sonnet-4-6", availableModels, "claude-code");
-  assert.ok(result, "should resolve even when only available via claude-code");
-  assert.equal(result.provider, "claude-code");
-});
-
-test("resolveModelId: anthropic wins over claude-code regardless of list order", () => {
-  const availableModels = [
-    { id: "claude-sonnet-4-6", provider: "claude-code" },
-    { id: "claude-sonnet-4-6", provider: "anthropic" },
-  ];
-
-  // Even when claude-code appears first in the list, anthropic should win
-  const result = resolveModelId("claude-sonnet-4-6", availableModels, "claude-code");
-  assert.ok(result, "should resolve a model");
-  assert.equal(result.provider, "anthropic", "anthropic must win over claude-code regardless of list order");
-});

package/src/resources/extensions/gsd/tests/auto-paused-session-validation.test.ts

@@ -1,129 +0,0 @@
-/**
- * auto-paused-session-validation.test.ts — Validates milestone existence
- * before restoring from paused-session.json (#1664).
- *
- * Two layers:
- * 1. Source-code regression: ensures auto.ts validates the milestone before
- *    trusting paused-session.json (guards against accidental removal).
- * 2. Filesystem unit: confirms resolveMilestonePath / resolveMilestoneFile
- *    correctly detect missing and completed milestones.
- */
-
-import test from "node:test";
-import assert from "node:assert/strict";
-import { mkdirSync, writeFileSync, rmSync, readFileSync } from "node:fs";
-import { join } from "node:path";
-import { tmpdir } from "node:os";
-import { randomUUID } from "node:crypto";
-import { fileURLToPath } from "node:url";
-import { dirname } from "node:path";
-
-import { resolveMilestonePath, resolveMilestoneFile } from "../paths.ts";
-
-const __dirname = dirname(fileURLToPath(import.meta.url));
-const AUTO_TS_PATH = join(__dirname, "..", "auto.ts");
-
-// ─── Source-code regression guard ───────────────────────────────────────────
-
-test("auto.ts validates milestone before restoring paused session (#1664)", () => {
-  const source = readFileSync(AUTO_TS_PATH, "utf-8");
-
-  // The resume block must call resolveMilestonePath to verify the milestone dir exists
-  assert.ok(
-    source.includes('resolveMilestonePath(base, meta.milestoneId)'),
-    "auto.ts must call resolveMilestonePath to verify paused milestone exists",
-  );
-
-  // The resume block must check for a SUMMARY file to detect completed milestones
-  assert.ok(
-    source.includes('resolveMilestoneFile(base, meta.milestoneId, "SUMMARY")'),
-    "auto.ts must check for SUMMARY file to detect completed milestones",
-  );
-});
-
-// ─── Filesystem validation unit tests ───────────────────────────────────────
-
-function makeTmpBase(): string {
-  return join(tmpdir(), `gsd-paused-test-${randomUUID()}`);
-}
-
-function cleanup(base: string): void {
-  try { rmSync(base, { recursive: true, force: true }); } catch { /* */ }
-}
-
-test("resolveMilestonePath returns null for missing milestone", (t) => {
-  const base = makeTmpBase();
-  mkdirSync(join(base, ".gsd", "milestones"), { recursive: true });
-  t.after(() => cleanup(base));
-
-  const result = resolveMilestonePath(base, "M999");
-  assert.equal(result, null, "should return null for non-existent milestone");
-});
-
-test("resolveMilestonePath returns path for existing milestone", (t) => {
-  const base = makeTmpBase();
-  mkdirSync(join(base, ".gsd", "milestones", "M001"), { recursive: true });
-  t.after(() => cleanup(base));
-
-  const result = resolveMilestonePath(base, "M001");
-  assert.ok(result, "should return a path for existing milestone");
-  assert.ok(result.includes("M001"), "path should contain the milestone ID");
-});
-
-test("resolveMilestoneFile returns null when no SUMMARY exists", (t) => {
-  const base = makeTmpBase();
-  mkdirSync(join(base, ".gsd", "milestones", "M001"), { recursive: true });
-  t.after(() => cleanup(base));
-
-  const result = resolveMilestoneFile(base, "M001", "SUMMARY");
-  assert.equal(result, null, "should return null when no SUMMARY file");
-});
-
-test("resolveMilestoneFile returns path when SUMMARY exists (completed)", (t) => {
-  const base = makeTmpBase();
-  const mDir = join(base, ".gsd", "milestones", "M001");
-  mkdirSync(mDir, { recursive: true });
-  writeFileSync(join(mDir, "M001-SUMMARY.md"), "# Summary\nDone.");
-  t.after(() => cleanup(base));
-
-  const result = resolveMilestoneFile(base, "M001", "SUMMARY");
-  assert.ok(result, "should return a path when SUMMARY exists");
-  assert.ok(result.includes("SUMMARY"), "path should reference SUMMARY");
-});
-
-// ─── Combined validation logic (mirrors auto.ts resume guard) ───────────────
-
-test("stale milestone: missing dir means paused session should be discarded", (t) => {
-  const base = makeTmpBase();
-  mkdirSync(join(base, ".gsd", "milestones"), { recursive: true });
-  t.after(() => cleanup(base));
-
-  const mDir = resolveMilestonePath(base, "M999");
-  const summaryFile = resolveMilestoneFile(base, "M999", "SUMMARY");
-  const isStale = !mDir || !!summaryFile;
-  assert.ok(isStale, "milestone that doesn't exist should be detected as stale");
-});
-
-test("stale milestone: completed (has SUMMARY) means paused session should be discarded", (t) => {
-  const base = makeTmpBase();
-  const mDir = join(base, ".gsd", "milestones", "M001");
-  mkdirSync(mDir, { recursive: true });
-  writeFileSync(join(mDir, "M001-SUMMARY.md"), "# Summary\nDone.");
-  t.after(() => cleanup(base));
-
-  const dir = resolveMilestonePath(base, "M001");
-  const summaryFile = resolveMilestoneFile(base, "M001", "SUMMARY");
-  const isStale = !dir || !!summaryFile;
-  assert.ok(isStale, "milestone with SUMMARY should be detected as stale");
-});
-
-test("valid milestone: exists and has no SUMMARY means paused session is valid", (t) => {
-  const base = makeTmpBase();
-  mkdirSync(join(base, ".gsd", "milestones", "M001"), { recursive: true });
-  t.after(() => cleanup(base));
-
-  const dir = resolveMilestonePath(base, "M001");
-  const summaryFile = resolveMilestoneFile(base, "M001", "SUMMARY");
-  const isStale = !dir || !!summaryFile;
-  assert.ok(!isStale, "active milestone should not be detected as stale");
-});

package/src/resources/extensions/gsd/tests/auto-pr-bugs.test.ts

@@ -1,88 +0,0 @@
-/**
- * auto-pr-bugs.test.ts — Regression tests for #2302.
- *
- * Three interacting bugs prevented auto_pr from ever creating a PR:
- * 1. auto_pr was gated on `pushed` (which requires auto_push)
- * 2. Milestone branch was not pushed to remote before PR creation
- * 3. createDraftPR in git-service.ts lacked --head/--base parameters
- */
-
-import test from "node:test";
-import assert from "node:assert/strict";
-import { readFileSync } from "node:fs";
-import { join } from "node:path";
-
-// ─── Bug 1: auto_pr should not depend on auto_push / pushed flag ────────────
-
-const autoWorktreeSrcPath = join(import.meta.dirname, "..", "auto-worktree.ts");
-const autoWorktreeSrc = readFileSync(autoWorktreeSrcPath, "utf-8");
-
-test("#2302 bug 1: auto_pr condition should not require pushed flag", () => {
-  // Find the auto_pr block in mergeMilestoneToMain
-  const autoPrIdx = autoWorktreeSrc.indexOf("auto_pr");
-  assert.ok(autoPrIdx !== -1, "auto_pr reference exists in auto-worktree.ts");
-
-  // Get context around the auto_pr check
-  const lineStart = autoWorktreeSrc.lastIndexOf("\n", autoPrIdx) + 1;
-  const lineEnd = autoWorktreeSrc.indexOf("\n", autoPrIdx);
-  const autoPrLine = autoWorktreeSrc.slice(lineStart, lineEnd);
-
-  // The condition should NOT include `&& pushed`
-  assert.ok(
-    !autoPrLine.includes("&& pushed"),
-    "auto_pr condition should not be gated on pushed flag (auto_push dependency)",
-  );
-});
-
-// ─── Bug 2: phases.ts should not duplicate PR creation ──────────────────────
-
-const phasesSrcPath = join(import.meta.dirname, "..", "auto", "phases.ts");
-const phasesSrc = readFileSync(phasesSrcPath, "utf-8");
-
-test("#2302 bug 2: phases.ts should not call createDraftPR (handled by mergeMilestoneToMain)", () => {
-  // After fix, phases.ts should not import or call createDraftPR because
-  // PR creation is handled inside mergeMilestoneToMain in auto-worktree.ts
-  const createDraftPRCalls = phasesSrc.match(/createDraftPR\(/g) || [];
-
-  assert.equal(
-    createDraftPRCalls.length,
-    0,
-    "phases.ts should not call createDraftPR — it's handled by mergeMilestoneToMain",
-  );
-});
-
-// ─── Bug 3: createDraftPR should accept head and base branch parameters ─────
-
-const gitServiceSrcPath = join(import.meta.dirname, "..", "git-service.ts");
-const gitServiceSrc = readFileSync(gitServiceSrcPath, "utf-8");
-
-test("#2302 bug 3: createDraftPR should accept head and base branch parameters", () => {
-  // Find the createDraftPR function signature
-  const fnIdx = gitServiceSrc.indexOf("function createDraftPR");
-  assert.ok(fnIdx !== -1, "createDraftPR function exists");
-
-  // Get the function signature (up to the closing paren)
-  const sigEnd = gitServiceSrc.indexOf(")", fnIdx);
-  const signature = gitServiceSrc.slice(fnIdx, sigEnd);
-
-  // Should have head and base parameters
-  assert.ok(
-    signature.includes("head") || signature.includes("branch"),
-    "createDraftPR should accept a head/branch parameter",
-  );
-});
-
-test("#2302 bug 3: createDraftPR should pass --head and --base to gh pr create", () => {
-  const fnIdx = gitServiceSrc.indexOf("function createDraftPR");
-  const fnEnd = gitServiceSrc.indexOf("\n}", fnIdx);
-  const fnBody = gitServiceSrc.slice(fnIdx, fnEnd);
-
-  assert.ok(
-    fnBody.includes("--head"),
-    "createDraftPR should pass --head to gh pr create",
-  );
-  assert.ok(
-    fnBody.includes("--base"),
-    "createDraftPR should pass --base to gh pr create",
-  );
-});