lighthouse 9.5.0-dev.20221018 → 9.5.0-dev.20221020

package/core/audits/resource-summary.js

@@ -49,9 +49,9 @@ class ResourceSummary extends Audit {
 
     /** @type {LH.Audit.Details.Table['headings']} */
     const headings = [
-      {key: 'label', itemType: 'text', text: str_(i18n.UIStrings.columnResourceType)},
-      {key: 'requestCount', itemType: 'numeric', text: str_(i18n.UIStrings.columnRequests)},
-      {key: 'transferSize', itemType: 'bytes', text: str_(i18n.UIStrings.columnTransferSize)},
+      {key: 'label', valueType: 'text', label: str_(i18n.UIStrings.columnResourceType)},
+      {key: 'requestCount', valueType: 'numeric', label: str_(i18n.UIStrings.columnRequests)},
+      {key: 'transferSize', valueType: 'bytes', label: str_(i18n.UIStrings.columnTransferSize)},
     ];
 
 

package/core/audits/seo/crawlable-anchors.js

@@ -71,8 +71,8 @@ class CrawlableAnchors extends Audit {
     /** @type {LH.Audit.Details.Table['headings']} */
     const headings = [{
       key: 'node',
-      itemType: 'node',
-      text: str_(UIStrings.columnFailingLink),
+      valueType: 'node',
+      label: str_(UIStrings.columnFailingLink),
     }];
 
     /** @type {LH.Audit.Details.Table['items']} */

package/core/audits/seo/font-size.js

@@ -284,10 +284,10 @@ class FontSize extends Audit {
 
     /** @type {LH.Audit.Details.Table['headings']} */
     const headings = [
-      {key: 'source', itemType: 'source-location', text: str_(i18n.UIStrings.columnSource)},
-      {key: 'selector', itemType: 'code', text: str_(UIStrings.columnSelector)},
-      {key: 'coverage', itemType: 'text', text: str_(UIStrings.columnPercentPageText)},
-      {key: 'fontSize', itemType: 'text', text: str_(UIStrings.columnFontSize)},
+      {key: 'source', valueType: 'source-location', label: str_(i18n.UIStrings.columnSource)},
+      {key: 'selector', valueType: 'code', label: str_(UIStrings.columnSelector)},
+      {key: 'coverage', valueType: 'text', label: str_(UIStrings.columnPercentPageText)},
+      {key: 'fontSize', valueType: 'text', label: str_(UIStrings.columnFontSize)},
     ];
 
     const tableData = failingRules.sort((a, b) => b.textLength - a.textLength)

package/core/audits/seo/hreflang.js

@@ -127,12 +127,12 @@ class Hreflang extends Audit {
     /** @type {LH.Audit.Details.Table['headings']} */
     const headings = [{
       key: 'source',
-      itemType: 'code',
+      valueType: 'code',
       subItemsHeading: {
         key: 'reason',
-        itemType: 'text',
+        valueType: 'text',
       },
-      text: '',
+      label: '',
     }];
 
     const details = Audit.makeTableDetails(headings, invalidHreflangs);

package/core/audits/seo/is-crawlable.js

@@ -138,7 +138,7 @@ class IsCrawlable extends Audit {
 
         /** @type {LH.Audit.Details.Table['headings']} */
         const headings = [
-          {key: 'source', itemType: 'code', text: 'Blocking Directive Source'},
+          {key: 'source', valueType: 'code', label: 'Blocking Directive Source'},
         ];
         const details = Audit.makeTableDetails(headings, blockingDirectives);
 

package/core/audits/seo/link-text.js

@@ -137,8 +137,8 @@ class LinkText extends Audit {
 
     /** @type {LH.Audit.Details.Table['headings']} */
     const headings = [
-      {key: 'href', itemType: 'url', text: 'Link destination'},
-      {key: 'text', itemType: 'text', text: 'Link Text'},
+      {key: 'href', valueType: 'url', label: 'Link destination'},
+      {key: 'text', valueType: 'text', label: 'Link Text'},
     ];
 
     const details = Audit.makeTableDetails(headings, failingLinks, {});

package/core/audits/seo/plugins.js

@@ -134,7 +134,7 @@ class Plugins extends Audit {
 
     /** @type {LH.Audit.Details.Table['headings']} */
     const headings = [
-      {key: 'source', itemType: 'code', text: 'Element source'},
+      {key: 'source', valueType: 'code', label: 'Element source'},
     ];
 
     const details = Audit.makeTableDetails(headings, plugins);

package/core/audits/seo/robots-txt.js

@@ -230,9 +230,9 @@ class RobotsTxt extends Audit {
 
     /** @type {LH.Audit.Details.Table['headings']} */
     const headings = [
-      {key: 'index', itemType: 'text', text: 'Line #'},
-      {key: 'line', itemType: 'code', text: 'Content'},
-      {key: 'message', itemType: 'code', text: 'Error'},
+      {key: 'index', valueType: 'text', label: 'Line #'},
+      {key: 'line', valueType: 'code', label: 'Content'},
+      {key: 'message', valueType: 'code', label: 'Error'},
     ];
 
     const details = Audit.makeTableDetails(headings, validationErrors, {});

package/core/audits/seo/tap-targets.js

@@ -286,9 +286,9 @@ class TapTargets extends Audit {
 
     /** @type {LH.Audit.Details.Table['headings']} */
     const headings = [
-      {key: 'tapTarget', itemType: 'node', text: str_(UIStrings.tapTargetHeader)},
-      {key: 'size', itemType: 'text', text: str_(i18n.UIStrings.columnSize)},
-      {key: 'overlappingTarget', itemType: 'node', text: str_(UIStrings.overlappingTargetHeader)},
+      {key: 'tapTarget', valueType: 'node', label: str_(UIStrings.tapTargetHeader)},
+      {key: 'size', valueType: 'text', label: str_(i18n.UIStrings.columnSize)},
+      {key: 'overlappingTarget', valueType: 'node', label: str_(UIStrings.overlappingTargetHeader)},
     ];
 
     const details = Audit.makeTableDetails(headings, tableItems);

package/core/audits/themed-omnibox.js

@@ -4,8 +4,6 @@
  * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
  */
 
-import cssParsers from 'cssstyle/lib/parsers.js';
-
 import MultiCheckAudit from './multi-check-audit.js';
 import {ManifestValues} from '../computed/manifest-values.js';
 import * as i18n from '../lib/i18n/i18n.js';
@@ -28,8 +26,10 @@ const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
  *
  * Requirements:
  *   * manifest is not empty
- *   * manifest has a valid theme_color
- *   * HTML has a valid theme-color meta
+ *   * manifest has a theme_color
+ *   * HTML has a theme-color meta
+ *
+ * Color validity is explicitly not checked.
  */
 
 class ThemedOmnibox extends MultiCheckAudit {
@@ -47,14 +47,6 @@ class ThemedOmnibox extends MultiCheckAudit {
     };
   }
 
-  /**
-   * @param {string} color
-   * @return {boolean}
-   */
-  static isValidColor(color) {
-    return cssParsers.valueType(color) === cssParsers.TYPES.COLOR;
-  }
-
   /**
    * @param {LH.Artifacts.MetaElement|undefined} themeColorMeta
    * @param {Array<string>} failures
@@ -63,8 +55,8 @@ class ThemedOmnibox extends MultiCheckAudit {
     if (!themeColorMeta) {
       // TODO(#7238): i18n
       failures.push('No `<meta name="theme-color">` tag found');
-    } else if (!ThemedOmnibox.isValidColor(themeColorMeta.content || '')) {
-      failures.push('The theme-color meta tag did not contain a valid CSS color');
+    } else if (!themeColorMeta.content) {
+      failures.push('The theme-color meta tag did not contain a content value');
     }
   }
 

package/core/audits/third-party-facades.js

@@ -201,9 +201,9 @@ class ThirdPartyFacades extends Audit {
     /** @type {LH.Audit.Details.Table['headings']} */
     const headings = [
       /* eslint-disable max-len */
-      {key: 'product', itemType: 'text', subItemsHeading: {key: 'url', itemType: 'url'}, text: str_(UIStrings.columnProduct)},
-      {key: 'transferSize', itemType: 'bytes', subItemsHeading: {key: 'transferSize'}, granularity: 1, text: str_(i18n.UIStrings.columnTransferSize)},
-      {key: 'blockingTime', itemType: 'ms', subItemsHeading: {key: 'blockingTime'}, granularity: 1, text: str_(i18n.UIStrings.columnBlockingTime)},
+      {key: 'product', valueType: 'text', subItemsHeading: {key: 'url', valueType: 'url'}, label: str_(UIStrings.columnProduct)},
+      {key: 'transferSize', valueType: 'bytes', subItemsHeading: {key: 'transferSize'}, granularity: 1, label: str_(i18n.UIStrings.columnTransferSize)},
+      {key: 'blockingTime', valueType: 'ms', subItemsHeading: {key: 'blockingTime'}, granularity: 1, label: str_(i18n.UIStrings.columnBlockingTime)},
       /* eslint-enable max-len */
     ];
 

package/core/audits/third-party-summary.js

@@ -232,9 +232,9 @@ class ThirdPartySummary extends Audit {
     /** @type {LH.Audit.Details.Table['headings']} */
     const headings = [
       /* eslint-disable max-len */
-      {key: 'entity', itemType: 'link', text: str_(UIStrings.columnThirdParty), subItemsHeading: {key: 'url', itemType: 'url'}},
-      {key: 'transferSize', granularity: 1, itemType: 'bytes', text: str_(i18n.UIStrings.columnTransferSize), subItemsHeading: {key: 'transferSize'}},
-      {key: 'blockingTime', granularity: 1, itemType: 'ms', text: str_(i18n.UIStrings.columnBlockingTime), subItemsHeading: {key: 'blockingTime'}},
+      {key: 'entity', valueType: 'link', label: str_(UIStrings.columnThirdParty), subItemsHeading: {key: 'url', valueType: 'url'}},
+      {key: 'transferSize', granularity: 1, valueType: 'bytes', label: str_(i18n.UIStrings.columnTransferSize), subItemsHeading: {key: 'transferSize'}},
+      {key: 'blockingTime', granularity: 1, valueType: 'ms', label: str_(i18n.UIStrings.columnBlockingTime), subItemsHeading: {key: 'blockingTime'}},
       /* eslint-enable max-len */
     ];
 

package/core/audits/timing-budget.js

@@ -154,13 +154,13 @@ class TimingBudget extends Audit {
 
     /** @type {LH.Audit.Details.Table['headings']} */
     const headers = [
-      {key: 'label', itemType: 'text', text: str_(UIStrings.columnTimingMetric)},
+      {key: 'label', valueType: 'text', label: str_(UIStrings.columnTimingMetric)},
       /**
        * Note: SpeedIndex, unlike other timing metrics, is not measured in milliseconds.
        * The renderer applies the correct units to the 'measurement' and 'overBudget' columns for SpeedIndex.
        */
-      {key: 'measurement', itemType: 'ms', text: str_(UIStrings.columnMeasurement)},
-      {key: 'overBudget', itemType: 'ms', text: str_(i18n.UIStrings.columnOverBudget)},
+      {key: 'measurement', valueType: 'ms', label: str_(UIStrings.columnMeasurement)},
+      {key: 'overBudget', valueType: 'ms', label: str_(i18n.UIStrings.columnOverBudget)},
     ];
 
     return {

package/core/audits/unsized-images.js

@@ -146,8 +146,8 @@ class UnsizedImages extends Audit {
 
     /** @type {LH.Audit.Details.Table['headings']} */
     const headings = [
-      {key: 'node', itemType: 'node', text: ''},
-      {key: 'url', itemType: 'url', text: str_(i18n.UIStrings.columnURL)},
+      {key: 'node', valueType: 'node', label: ''},
+      {key: 'url', valueType: 'url', label: str_(i18n.UIStrings.columnURL)},
     ];
 
     return {

package/core/audits/user-timings.js

@@ -89,12 +89,12 @@ class UserTimings extends Audit {
 
       /** @type {LH.Audit.Details.Table['headings']} */
       const headings = [
-        {key: 'name', itemType: 'text', text: str_(i18n.UIStrings.columnName)},
-        {key: 'timingType', itemType: 'text', text: str_(UIStrings.columnType)},
-        {key: 'startTime', itemType: 'ms', granularity: 0.01,
-          text: str_(i18n.UIStrings.columnStartTime)},
-        {key: 'duration', itemType: 'ms', granularity: 0.01,
-          text: str_(i18n.UIStrings.columnDuration)},
+        {key: 'name', valueType: 'text', label: str_(i18n.UIStrings.columnName)},
+        {key: 'timingType', valueType: 'text', label: str_(UIStrings.columnType)},
+        {key: 'startTime', valueType: 'ms', granularity: 0.01,
+          label: str_(i18n.UIStrings.columnStartTime)},
+        {key: 'duration', valueType: 'ms', granularity: 0.01,
+          label: str_(i18n.UIStrings.columnDuration)},
       ];
 
       const details = Audit.makeTableDetails(headings, tableRows);

package/core/audits/valid-source-maps.js

@@ -119,11 +119,11 @@ class ValidSourceMaps extends Audit {
       /* eslint-disable max-len */
       {
         key: 'scriptUrl',
-        itemType: 'url',
+        valueType: 'url',
         subItemsHeading: {key: 'error'},
-        text: str_(i18n.UIStrings.columnURL),
+        label: str_(i18n.UIStrings.columnURL),
       },
-      {key: 'sourceMapUrl', itemType: 'url', text: str_(UIStrings.columnMapURL)},
+      {key: 'sourceMapUrl', valueType: 'url', label: str_(UIStrings.columnMapURL)},
       /* eslint-enable max-len */
     ];
 

package/core/audits/work-during-interaction.js

@@ -184,11 +184,11 @@ class WorkDuringInteraction extends Audit {
     /** @type {LH.Audit.Details.Table['headings']} */
     const headings = [
       /* eslint-disable max-len */
-      {key: 'phase', itemType: 'text', subItemsHeading: {key: 'url', itemType: 'url'}, text: 'Phase'},
-      {key: 'total', itemType: 'ms', subItemsHeading: {key: 'total', granularity: 1, itemType: 'ms'}, granularity: 1, text: 'Total time'},
-      {key: null, itemType: 'ms', subItemsHeading: {key: 'scripting', granularity: 1, itemType: 'ms'}, text: 'Script evaluation'},
-      {key: null, itemType: 'ms', subItemsHeading: {key: 'layout', granularity: 1, itemType: 'ms'}, text: taskGroups.styleLayout.label},
-      {key: null, itemType: 'ms', subItemsHeading: {key: 'render', granularity: 1, itemType: 'ms'}, text: taskGroups.paintCompositeRender.label},
+      {key: 'phase', valueType: 'text', subItemsHeading: {key: 'url', valueType: 'url'}, label: 'Phase'},
+      {key: 'total', valueType: 'ms', subItemsHeading: {key: 'total', granularity: 1, valueType: 'ms'}, granularity: 1, label: 'Total time'},
+      {key: null, valueType: 'ms', subItemsHeading: {key: 'scripting', granularity: 1, valueType: 'ms'}, label: 'Script evaluation'},
+      {key: null, valueType: 'ms', subItemsHeading: {key: 'layout', granularity: 1, valueType: 'ms'}, label: taskGroups.styleLayout.label},
+      {key: null, valueType: 'ms', subItemsHeading: {key: 'render', granularity: 1, valueType: 'ms'}, label: taskGroups.paintCompositeRender.label},
       /* eslint-enable max-len */
     ];
 
@@ -208,7 +208,7 @@ class WorkDuringInteraction extends Audit {
 
     /** @type {LH.Audit.Details.Table['headings']} */
     const headings = [
-      {key: 'node', itemType: 'node', text: str_(UIStrings.eventTarget)},
+      {key: 'node', valueType: 'node', label: str_(UIStrings.eventTarget)},
     ];
     const elementItems = [{node: Audit.makeNodeItem(responsivenessElement.node)}];
 

package/core/gather/navigation-runner.js

@@ -300,11 +300,12 @@ async function _cleanup({requestedUrl, driver, config}) {
 }
 
 /**
+ * @param {LH.Puppeteer.Page|undefined} page
  * @param {LH.NavigationRequestor|undefined} requestor
- * @param {{page?: LH.Puppeteer.Page, config?: LH.Config.Json, flags?: LH.Flags}} options
+ * @param {{config?: LH.Config.Json, flags?: LH.Flags}} [options]
  * @return {Promise<LH.Gatherer.FRGatherResult>}
  */
-async function navigationGather(requestor, options) {
+async function navigationGather(page, requestor, options = {}) {
   const {flags = {}} = options;
   log.setLevel(flags.logLevel || 'error');
 
@@ -316,7 +317,6 @@ async function navigationGather(requestor, options) {
   const runnerOptions = {config, computedCache};
   const artifacts = await Runner.gather(
     async () => {
-      let {page} = options;
       const normalizedRequestor = isCallback ? requestor : UrlUtils.normalizeUrl(requestor);
 
       // For navigation mode, we shouldn't connect to a browser in audit mode,

package/core/gather/snapshot-runner.js

@@ -13,11 +13,12 @@ import {initializeConfig} from '../config/config.js';
 import {getBaseArtifacts, finalizeArtifacts} from './base-artifacts.js';
 
 /**
- * @param {{page: LH.Puppeteer.Page, config?: LH.Config.Json, flags?: LH.Flags}} options
+ * @param {LH.Puppeteer.Page} page
+ * @param {{config?: LH.Config.Json, flags?: LH.Flags}} [options]
  * @return {Promise<LH.Gatherer.FRGatherResult>}
  */
-async function snapshotGather(options) {
-  const {page, flags = {}} = options;
+async function snapshotGather(page, options = {}) {
+  const {flags = {}} = options;
   log.setLevel(flags.logLevel || 'error');
 
   const {config} = await initializeConfig('snapshot', options.config, flags);

package/core/gather/timespan-runner.js

@@ -14,11 +14,12 @@ import {initializeConfig} from '../config/config.js';
 import {getBaseArtifacts, finalizeArtifacts} from './base-artifacts.js';
 
 /**
- * @param {{page: LH.Puppeteer.Page, config?: LH.Config.Json, flags?: LH.Flags}} options
+ * @param {LH.Puppeteer.Page} page
+ * @param {{config?: LH.Config.Json, flags?: LH.Flags}} [options]
  * @return {Promise<{endTimespanGather(): Promise<LH.Gatherer.FRGatherResult>}>}
  */
-async function startTimespanGather(options) {
-  const {page, flags = {}} = options;
+async function startTimespanGather(page, options = {}) {
+  const {flags = {}} = options;
   log.setLevel(flags.logLevel || 'error');
 
   const {config} = await initializeConfig('timespan', options.config, flags);

package/core/index.js

@@ -40,7 +40,7 @@ import {initializeConfig} from './config/config.js';
  * @return {Promise<LH.RunnerResult|undefined>}
  */
 async function lighthouse(url, flags = {}, configJSON, page) {
-  return fraggleRock.navigation(url, {page, config: configJSON, flags});
+  return fraggleRock.navigation(page, url, {config: configJSON, flags});
 }
 
 /**

package/core/legacy/config/config.js

@@ -128,29 +128,6 @@ function assertValidGatherer(gathererInstance, gathererName) {
   }
 }
 
-
-/**
- * Validate the LH.Flags
- * @param {LH.Flags} flags
- */
-function assertValidFlags(flags) {
-  // COMPAT: compatibility layer for devtools as it uses the old way and we need tests to pass
-  // TODO(paulirish): remove this from LH once emulation refactor has rolled into DevTools
-  // @ts-expect-error Deprecated flag
-  if (flags.channel === 'devtools' && flags.internalDisableDeviceScreenEmulation) {
-    // @ts-expect-error Deprecated flag
-    flags.formFactor = flags.emulatedFormFactor;
-    // @ts-expect-error Deprecated flag
-    flags.emulatedFormFactor = flags.internalDisableDeviceScreenEmulation = undefined;
-  }
-
-
-  // @ts-expect-error Checking for removed flags
-  if (flags.emulatedFormFactor || flags.internalDisableDeviceScreenEmulation) {
-    throw new Error('Invalid emulation flag. Emulation configuration changed in LH 7.0. See https://github.com/GoogleChrome/lighthouse/blob/main/docs/emulation.md');
-  }
-}
-
 /**
  * @implements {LH.Config.Config}
  */
@@ -193,9 +170,6 @@ class Config {
     // Validate and merge in plugins (if any).
     configJSON = await mergePlugins(configJSON, configDir, flags);
 
-    if (flags) {
-      assertValidFlags(flags);
-    }
     const settings = resolveSettings(configJSON.settings || {}, flags);
 
     // Augment passes with necessary defaults and require gatherers.