lighthouse 9.5.0-dev.20221018 → 9.5.0-dev.20221020

package/core/api.js

@@ -13,36 +13,40 @@ import {Runner} from './runner.js';
 
 /**
  * @param {LH.Puppeteer.Page} page
- * @param {ConstructorParameters<LH.UserFlow>[1]} [options]
+ * @param {LH.UserFlow.Options} [options]
  */
 async function startFlow(page, options) {
   return new UserFlow(page, options);
 }
 
 /**
- * @param  {Parameters<navigationGather>} params
+ * @param {LH.Puppeteer.Page|undefined} page
+ * @param {LH.NavigationRequestor|undefined} requestor
+ * @param {{config?: LH.Config.Json, flags?: LH.Flags}} [options]
  * @return {Promise<LH.RunnerResult|undefined>}
  */
-async function navigation(...params) {
-  const gatherResult = await navigationGather(...params);
+async function navigation(page, requestor, options) {
+  const gatherResult = await navigationGather(page, requestor, options);
   return Runner.audit(gatherResult.artifacts, gatherResult.runnerOptions);
 }
 
 /**
- * @param  {Parameters<snapshotGather>} params
+ * @param {LH.Puppeteer.Page} page
+ * @param {{config?: LH.Config.Json, flags?: LH.Flags}} [options]
  * @return {Promise<LH.RunnerResult|undefined>}
  */
-async function snapshot(...params) {
-  const gatherResult = await snapshotGather(...params);
+async function snapshot(page, options) {
+  const gatherResult = await snapshotGather(page, options);
   return Runner.audit(gatherResult.artifacts, gatherResult.runnerOptions);
 }
 
 /**
- * @param  {Parameters<startTimespanGather>} params
+ * @param {LH.Puppeteer.Page} page
+ * @param {{config?: LH.Config.Json, flags?: LH.Flags}} [options]
  * @return {Promise<{endTimespan: () => Promise<LH.RunnerResult|undefined>}>}
  */
-async function startTimespan(...params) {
-  const {endTimespanGather} = await startTimespanGather(...params);
+async function startTimespan(page, options) {
+  const {endTimespanGather} = await startTimespanGather(page, options);
   const endTimespan = async () => {
     const gatherResult = await endTimespanGather();
     return Runner.audit(gatherResult.artifacts, gatherResult.runnerOptions);

package/core/audits/accessibility/axe-audit.js

@@ -88,7 +88,7 @@ class AxeAudit extends Audit {
     /** @type {LH.Audit.Details.Table['headings']} */
     const headings = [
       /* eslint-disable max-len */
-      {key: 'node', itemType: 'node', subItemsHeading: {key: 'relatedNode', itemType: 'node'}, text: str_(UIStrings.failingElementsHeader)},
+      {key: 'node', valueType: 'node', subItemsHeading: {key: 'relatedNode', valueType: 'node'}, label: str_(UIStrings.failingElementsHeader)},
       /* eslint-enable max-len */
     ];
 

package/core/audits/accessibility/bypass.js

@@ -36,6 +36,7 @@ class Bypass extends AxeAudit {
       title: str_(UIStrings.title),
       failureTitle: str_(UIStrings.failureTitle),
       description: str_(UIStrings.description),
+      scoreDisplayMode: AxeAudit.SCORING_MODES.INFORMATIVE,
       requiredArtifacts: ['Accessibility'],
     };
   }

package/core/audits/accessibility/th-has-data-cells.js

@@ -38,6 +38,7 @@ class THHasDataCells extends AxeAudit {
       title: str_(UIStrings.title),
       failureTitle: str_(UIStrings.failureTitle),
       description: str_(UIStrings.description),
+      scoreDisplayMode: AxeAudit.SCORING_MODES.INFORMATIVE,
       requiredArtifacts: ['Accessibility'],
     };
   }

package/core/audits/accessibility/video-caption.js

@@ -36,6 +36,7 @@ class VideoCaption extends AxeAudit {
       title: str_(UIStrings.title),
       failureTitle: str_(UIStrings.failureTitle),
       description: str_(UIStrings.description),
+      scoreDisplayMode: AxeAudit.SCORING_MODES.INFORMATIVE,
       requiredArtifacts: ['Accessibility'],
     };
   }

package/core/audits/autocomplete.js

@@ -266,9 +266,9 @@ class AutocompleteAudit extends Audit {
 
     /** @type {LH.Audit.Details.Table['headings']} */
     const headings = [
-      {key: 'node', itemType: 'node', text: str_(i18n.UIStrings.columnFailingElem)},
-      {key: 'current', itemType: 'text', text: str_(UIStrings.columnCurrent)},
-      {key: 'suggestion', itemType: 'text', text: str_(UIStrings.columnSuggestions)},
+      {key: 'node', valueType: 'node', label: str_(i18n.UIStrings.columnFailingElem)},
+      {key: 'current', valueType: 'text', label: str_(UIStrings.columnCurrent)},
+      {key: 'suggestion', valueType: 'text', label: str_(UIStrings.columnSuggestions)},
     ];
     const details = Audit.makeTableDetails(headings, failingFormsData);
     let displayValue;

package/core/audits/bootup-time.js

@@ -121,11 +121,11 @@ class BootupTime extends Audit {
 
     /** @type {LH.Audit.Details.Table['headings']} */
     const headings = [
-      {key: 'url', itemType: 'url', text: str_(i18n.UIStrings.columnURL)},
-      {key: 'total', granularity: 1, itemType: 'ms', text: str_(UIStrings.columnTotal)},
-      {key: 'scripting', granularity: 1, itemType: 'ms', text: str_(UIStrings.columnScriptEval)},
-      {key: 'scriptParseCompile', granularity: 1, itemType: 'ms',
-        text: str_(UIStrings.columnScriptParse)},
+      {key: 'url', valueType: 'url', label: str_(i18n.UIStrings.columnURL)},
+      {key: 'total', granularity: 1, valueType: 'ms', label: str_(UIStrings.columnTotal)},
+      {key: 'scripting', granularity: 1, valueType: 'ms', label: str_(UIStrings.columnScriptEval)},
+      {key: 'scriptParseCompile', granularity: 1, valueType: 'ms',
+        label: str_(UIStrings.columnScriptParse)},
     ];
 
     const details = BootupTime.makeTableDetails(headings, results, summary);

package/core/audits/byte-efficiency/duplicated-javascript.js

@@ -225,7 +225,7 @@ class DuplicatedJavascript extends ByteEfficiencyAudit {
       });
     }
 
-    /** @type {LH.Audit.Details.OpportunityColumnHeading[]} */
+    /** @type {LH.Audit.Details.TableColumnHeading[]} */
     const headings = [
       /* eslint-disable max-len */
       {key: 'source', valueType: 'code', subItemsHeading: {key: 'url', valueType: 'url'}, label: str_(i18n.UIStrings.columnSource)},

package/core/audits/byte-efficiency/legacy-javascript.js

@@ -455,7 +455,7 @@ class LegacyJavascript extends ByteEfficiencyAudit {
       }
     }
 
-    /** @type {LH.Audit.Details.OpportunityColumnHeading[]} */
+    /** @type {LH.Audit.Details.TableColumnHeading[]} */
     const headings = [
       /* eslint-disable max-len */
       {key: 'url', valueType: 'url', subItemsHeading: {key: 'location', valueType: 'source-location'}, label: str_(i18n.UIStrings.columnURL)},

package/core/audits/byte-efficiency/total-byte-weight.js

@@ -89,8 +89,8 @@ class TotalByteWeight extends Audit {
 
     /** @type {LH.Audit.Details.Table['headings']} */
     const headings = [
-      {key: 'url', itemType: 'url', text: str_(i18n.UIStrings.columnURL)},
-      {key: 'totalBytes', itemType: 'bytes', text: str_(i18n.UIStrings.columnTransferSize)},
+      {key: 'url', valueType: 'url', label: str_(i18n.UIStrings.columnURL)},
+      {key: 'totalBytes', valueType: 'bytes', label: str_(i18n.UIStrings.columnTransferSize)},
     ];
 
     const tableDetails = Audit.makeTableDetails(headings, results);

package/core/audits/byte-efficiency/uses-long-cache-ttl.js

@@ -272,11 +272,11 @@ class CacheHeaders extends Audit {
 
       /** @type {LH.Audit.Details.Table['headings']} */
       const headings = [
-        {key: 'url', itemType: 'url', text: str_(i18n.UIStrings.columnURL)},
+        {key: 'url', valueType: 'url', label: str_(i18n.UIStrings.columnURL)},
         // TODO(i18n): pre-compute localized duration
-        {key: 'cacheLifetimeMs', itemType: 'ms', text: str_(i18n.UIStrings.columnCacheTTL),
+        {key: 'cacheLifetimeMs', valueType: 'ms', label: str_(i18n.UIStrings.columnCacheTTL),
           displayUnit: 'duration'},
-        {key: 'totalBytes', itemType: 'bytes', text: str_(i18n.UIStrings.columnTransferSize),
+        {key: 'totalBytes', valueType: 'bytes', label: str_(i18n.UIStrings.columnTransferSize),
           displayUnit: 'kb', granularity: 1},
       ];
 

package/core/audits/byte-efficiency/uses-responsive-images-snapshot.js

@@ -80,10 +80,10 @@ class UsesResponsiveImagesSnapshot extends Audit {
     /** @type {LH.Audit.Details.Table['headings']} */
     const headings = [
       /* eslint-disable max-len */
-      {key: 'node', itemType: 'node', text: ''},
-      {key: 'url', itemType: 'url', text: str_(i18n.UIStrings.columnURL)},
-      {key: 'displayedDimensions', itemType: 'text', text: str_(UIStrings.columnDisplayedDimensions)},
-      {key: 'actualDimensions', itemType: 'text', text: str_(UIStrings.columnActualDimensions)},
+      {key: 'node', valueType: 'node', label: ''},
+      {key: 'url', valueType: 'url', label: str_(i18n.UIStrings.columnURL)},
+      {key: 'displayedDimensions', valueType: 'text', label: str_(UIStrings.columnDisplayedDimensions)},
+      {key: 'actualDimensions', valueType: 'text', label: str_(UIStrings.columnActualDimensions)},
       /* eslint-enable max-len */
     ];
 

package/core/audits/csp-xss.js

@@ -163,9 +163,9 @@ class CspXss extends Audit {
     /** @type {LH.Audit.Details.Table['headings']} */
     const headings = [
       /* eslint-disable max-len */
-      {key: 'description', itemType: 'text', subItemsHeading: {key: 'description'}, text: str_(i18n.UIStrings.columnDescription)},
-      {key: 'directive', itemType: 'code', subItemsHeading: {key: 'directive'}, text: str_(UIStrings.columnDirective)},
-      {key: 'severity', itemType: 'text', subItemsHeading: {key: 'severity'}, text: str_(UIStrings.columnSeverity)},
+      {key: 'description', valueType: 'text', subItemsHeading: {key: 'description'}, label: str_(i18n.UIStrings.columnDescription)},
+      {key: 'directive', valueType: 'code', subItemsHeading: {key: 'directive'}, label: str_(UIStrings.columnDirective)},
+      {key: 'severity', valueType: 'text', subItemsHeading: {key: 'severity'}, label: str_(UIStrings.columnSeverity)},
       /* eslint-enable max-len */
     ];
     const details = Audit.makeTableDetails(headings, results);

package/core/audits/deprecations.js

@@ -92,8 +92,8 @@ class Deprecations extends Audit {
 
     /** @type {LH.Audit.Details.Table['headings']} */
     const headings = [
-      {key: 'value', itemType: 'text', text: str_(UIStrings.columnDeprecate)},
-      {key: 'source', itemType: 'source-location', text: str_(i18n.UIStrings.columnSource)},
+      {key: 'value', valueType: 'text', label: str_(UIStrings.columnDeprecate)},
+      {key: 'source', valueType: 'source-location', label: str_(i18n.UIStrings.columnSource)},
     ];
     const details = Audit.makeTableDetails(headings, deprecations);
 

package/core/audits/dobetterweb/dom-size.js

@@ -85,9 +85,9 @@ class DOMSize extends Audit {
 
     /** @type {LH.Audit.Details.Table['headings']} */
     const headings = [
-      {key: 'statistic', itemType: 'text', text: str_(UIStrings.columnStatistic)},
-      {key: 'node', itemType: 'node', text: str_(i18n.UIStrings.columnElement)},
-      {key: 'value', itemType: 'numeric', text: str_(UIStrings.columnValue)},
+      {key: 'statistic', valueType: 'text', label: str_(UIStrings.columnStatistic)},
+      {key: 'node', valueType: 'node', label: str_(i18n.UIStrings.columnElement)},
+      {key: 'value', valueType: 'numeric', label: str_(UIStrings.columnValue)},
     ];
 
     /** @type {LH.Audit.Details.Table['items']} */

package/core/audits/dobetterweb/geolocation-on-start.js

@@ -52,7 +52,7 @@ class GeolocationOnStart extends ViolationAudit {
 
     /** @type {LH.Audit.Details.Table['headings']} */
     const headings = [
-      {key: 'source', itemType: 'source-location', text: str_(i18n.UIStrings.columnSource)},
+      {key: 'source', valueType: 'source-location', label: str_(i18n.UIStrings.columnSource)},
     ];
     // TODO(bckenny): there should actually be a ts error here. results[0].stackTrace
     // should violate the results type. Shouldn't be removed from details items regardless.

package/core/audits/dobetterweb/inspector-issues.js

@@ -152,7 +152,7 @@ class IssuesPanelEntries extends Audit {
     /** @type {LH.Audit.Details.Table['headings']} */
     const headings = [
       /* eslint-disable max-len */
-      {key: 'issueType', itemType: 'text', subItemsHeading: {key: 'url', itemType: 'url'}, text: str_(UIStrings.columnIssueType)},
+      {key: 'issueType', valueType: 'text', subItemsHeading: {key: 'url', valueType: 'url'}, label: str_(UIStrings.columnIssueType)},
       /* eslint-enable max-len */
     ];
 

package/core/audits/dobetterweb/js-libraries.js

@@ -54,8 +54,8 @@ class JsLibrariesAudit extends Audit {
 
     /** @type {LH.Audit.Details.Table['headings']} */
     const headings = [
-      {key: 'name', itemType: 'text', text: str_(i18n.UIStrings.columnName)},
-      {key: 'version', itemType: 'text', text: str_(UIStrings.columnVersion)},
+      {key: 'name', valueType: 'text', label: str_(i18n.UIStrings.columnName)},
+      {key: 'version', valueType: 'text', label: str_(UIStrings.columnVersion)},
     ];
     const details = Audit.makeTableDetails(headings, libDetails, {});
 

package/core/audits/dobetterweb/no-document-write.js

@@ -68,7 +68,7 @@ class NoDocWriteAudit extends ViolationAudit {
 
     /** @type {LH.Audit.Details.Table['headings']} */
     const headings = [
-      {key: 'source', itemType: 'source-location', text: str_(i18n.UIStrings.columnSource)},
+      {key: 'source', valueType: 'source-location', label: str_(i18n.UIStrings.columnSource)},
     ];
     // TODO(bckenny): see TODO in geolocation-on-start
     const details = ViolationAudit.makeTableDetails(headings, results);

package/core/audits/dobetterweb/notification-on-start.js

@@ -52,7 +52,7 @@ class NotificationOnStart extends ViolationAudit {
 
     /** @type {LH.Audit.Details.Table['headings']} */
     const headings = [
-      {key: 'source', itemType: 'source-location', text: str_(i18n.UIStrings.columnSource)},
+      {key: 'source', valueType: 'source-location', label: str_(i18n.UIStrings.columnSource)},
     ];
     // TODO(bckenny): see TODO in geolocation-on-start
     const details = ViolationAudit.makeTableDetails(headings, results);

package/core/audits/dobetterweb/password-inputs-can-be-pasted-into.js

@@ -51,7 +51,7 @@ class PasswordInputsCanBePastedIntoAudit extends Audit {
 
     /** @type {LH.Audit.Details.Table['headings']} */
     const headings = [
-      {key: 'node', itemType: 'node', text: str_(i18n.UIStrings.columnFailingElem)},
+      {key: 'node', valueType: 'node', label: str_(i18n.UIStrings.columnFailingElem)},
     ];
 
     return {

package/core/audits/dobetterweb/uses-http2.js

@@ -214,8 +214,8 @@ class UsesHTTP2Audit extends Audit {
     if (artifacts.GatherContext.gatherMode === 'timespan') {
       /** @type {LH.Audit.Details.Table['headings']} */
       const headings = [
-        {key: 'url', itemType: 'url', text: str_(i18n.UIStrings.columnURL)},
-        {key: 'protocol', itemType: 'text', text: str_(UIStrings.columnProtocol)},
+        {key: 'url', valueType: 'url', label: str_(i18n.UIStrings.columnURL)},
+        {key: 'protocol', valueType: 'text', label: str_(UIStrings.columnProtocol)},
       ];
 
       const details = Audit.makeTableDetails(headings, resources);

package/core/audits/dobetterweb/uses-passive-event-listeners.js

@@ -51,7 +51,7 @@ class PassiveEventsAudit extends ViolationAudit {
 
     /** @type {LH.Audit.Details.Table['headings']} */
     const headings = [
-      {key: 'source', itemType: 'source-location', text: str_(i18n.UIStrings.columnSource)},
+      {key: 'source', valueType: 'source-location', label: str_(i18n.UIStrings.columnSource)},
     ];
     // TODO(bckenny): see TODO in geolocation-on-start
     const details = ViolationAudit.makeTableDetails(headings, results);

package/core/audits/errors-in-console.js

@@ -100,8 +100,10 @@ class ErrorLogs extends Audit {
 
     /** @type {LH.Audit.Details.Table['headings']} */
     const headings = [
-      {key: 'sourceLocation', itemType: 'source-location', text: str_(i18n.UIStrings.columnSource)},
-      {key: 'description', itemType: 'code', text: str_(i18n.UIStrings.columnDescription)},
+      /* eslint-disable max-len */
+      {key: 'sourceLocation', valueType: 'source-location', label: str_(i18n.UIStrings.columnSource)},
+      {key: 'description', valueType: 'code', label: str_(i18n.UIStrings.columnDescription)},
+      /* eslint-enable max-len */
     ];
 
     const details = Audit.makeTableDetails(headings, tableRows);

package/core/audits/font-display.js

@@ -175,8 +175,8 @@ class FontDisplay extends Audit {
 
     /** @type {LH.Audit.Details.Table['headings']} */
     const headings = [
-      {key: 'url', itemType: 'url', text: str_(i18n.UIStrings.columnURL)},
-      {key: 'wastedMs', itemType: 'ms', text: str_(i18n.UIStrings.columnWastedMs)},
+      {key: 'url', valueType: 'url', label: str_(i18n.UIStrings.columnURL)},
+      {key: 'wastedMs', valueType: 'ms', label: str_(i18n.UIStrings.columnWastedMs)},
     ];
 
     const details = Audit.makeTableDetails(headings, results);

package/core/audits/image-aspect-ratio.js

@@ -105,10 +105,10 @@ class ImageAspectRatio extends Audit {
 
     /** @type {LH.Audit.Details.Table['headings']} */
     const headings = [
-      {key: 'node', itemType: 'node', text: ''},
-      {key: 'url', itemType: 'url', text: str_(i18n.UIStrings.columnURL)},
-      {key: 'displayedAspectRatio', itemType: 'text', text: str_(UIStrings.columnDisplayed)},
-      {key: 'actualAspectRatio', itemType: 'text', text: str_(UIStrings.columnActual)},
+      {key: 'node', valueType: 'node', label: ''},
+      {key: 'url', valueType: 'url', label: str_(i18n.UIStrings.columnURL)},
+      {key: 'displayedAspectRatio', valueType: 'text', label: str_(UIStrings.columnDisplayed)},
+      {key: 'actualAspectRatio', valueType: 'text', label: str_(UIStrings.columnActual)},
     ];
 
     return {

package/core/audits/image-size-responsive.js

@@ -264,11 +264,11 @@ class ImageSizeResponsive extends Audit {
 
     /** @type {LH.Audit.Details.Table['headings']} */
     const headings = [
-      {key: 'node', itemType: 'node', text: ''},
-      {key: 'url', itemType: 'url', text: str_(i18n.UIStrings.columnURL)},
-      {key: 'displayedSize', itemType: 'text', text: str_(UIStrings.columnDisplayed)},
-      {key: 'actualSize', itemType: 'text', text: str_(UIStrings.columnActual)},
-      {key: 'expectedSize', itemType: 'text', text: str_(UIStrings.columnExpected)},
+      {key: 'node', valueType: 'node', label: ''},
+      {key: 'url', valueType: 'url', label: str_(i18n.UIStrings.columnURL)},
+      {key: 'displayedSize', valueType: 'text', label: str_(UIStrings.columnDisplayed)},
+      {key: 'actualSize', valueType: 'text', label: str_(UIStrings.columnActual)},
+      {key: 'expectedSize', valueType: 'text', label: str_(UIStrings.columnExpected)},
     ];
 
     const finalResults = sortResultsBySizeDelta(deduplicateResultsByUrl(results));

package/core/audits/installable-manifest.js

@@ -216,7 +216,7 @@ class InstallableManifest extends Audit {
 
     /** @type {LH.Audit.Details.Table['headings']} */
     const headings = [
-      {key: 'reason', itemType: 'text', text: str_(UIStrings.columnValue)},
+      {key: 'reason', valueType: 'text', label: str_(UIStrings.columnValue)},
     ];
 
     // Errors for report table.

package/core/audits/is-on-https.js

@@ -82,8 +82,8 @@ class HTTPS extends Audit {
 
       /** @type {LH.Audit.Details.Table['headings']} */
       const headings = [
-        {key: 'url', itemType: 'url', text: str_(UIStrings.columnInsecureURL)},
-        {key: 'resolution', itemType: 'text', text: str_(UIStrings.columnResolution)},
+        {key: 'url', valueType: 'url', label: str_(UIStrings.columnInsecureURL)},
+        {key: 'resolution', valueType: 'text', label: str_(UIStrings.columnResolution)},
       ];
 
       for (const details of artifacts.InspectorIssues.mixedContentIssue) {

package/core/audits/largest-contentful-paint-element.js

@@ -48,7 +48,7 @@ class LargestContentfulPaintElement extends Audit {
 
     /** @type {LH.Audit.Details.Table['headings']} */
     const headings = [
-      {key: 'node', itemType: 'node', text: str_(i18n.UIStrings.columnElement)},
+      {key: 'node', valueType: 'node', label: str_(i18n.UIStrings.columnElement)},
     ];
 
     const details = Audit.makeTableDetails(headings, lcpElementDetails);

package/core/audits/layout-shift-elements.js

@@ -49,9 +49,9 @@ class LayoutShiftElements extends Audit {
 
     /** @type {LH.Audit.Details.Table['headings']} */
     const headings = [
-      {key: 'node', itemType: 'node', text: str_(i18n.UIStrings.columnElement)},
-      {key: 'score', itemType: 'numeric',
-        granularity: 0.001, text: str_(UIStrings.columnContribution)},
+      {key: 'node', valueType: 'node', label: str_(i18n.UIStrings.columnElement)},
+      {key: 'score', valueType: 'numeric',
+        granularity: 0.001, label: str_(UIStrings.columnContribution)},
     ];
 
     const details = Audit.makeTableDetails(headings, clsElementData);

package/core/audits/lcp-lazy-loaded.js

@@ -64,7 +64,7 @@ class LargestContentfulPaintLazyLoaded extends Audit {
 
     /** @type {LH.Audit.Details.Table['headings']} */
     const headings = [
-      {key: 'node', itemType: 'node', text: str_(i18n.UIStrings.columnElement)},
+      {key: 'node', valueType: 'node', label: str_(i18n.UIStrings.columnElement)},
     ];
 
     const details = Audit.makeTableDetails(headings, [

package/core/audits/long-tasks.js

@@ -98,9 +98,9 @@ class LongTasks extends Audit {
     /** @type {LH.Audit.Details.Table['headings']} */
     const headings = [
       /* eslint-disable max-len */
-      {key: 'url', itemType: 'url', text: str_(i18n.UIStrings.columnURL)},
-      {key: 'startTime', itemType: 'ms', granularity: 1, text: str_(i18n.UIStrings.columnStartTime)},
-      {key: 'duration', itemType: 'ms', granularity: 1, text: str_(i18n.UIStrings.columnDuration)},
+      {key: 'url', valueType: 'url', label: str_(i18n.UIStrings.columnURL)},
+      {key: 'startTime', valueType: 'ms', granularity: 1, label: str_(i18n.UIStrings.columnStartTime)},
+      {key: 'duration', valueType: 'ms', granularity: 1, label: str_(i18n.UIStrings.columnDuration)},
       /* eslint-enable max-len */
     ];
 

package/core/audits/main-thread-tasks.js

@@ -42,8 +42,8 @@ class MainThreadTasks extends Audit {
 
     /** @type {LH.Audit.Details.Table['headings']} */
     const headings = [
-      {key: 'startTime', itemType: 'ms', granularity: 1, text: 'Start Time'},
-      {key: 'duration', itemType: 'ms', granularity: 1, text: 'End Time'},
+      {key: 'startTime', valueType: 'ms', granularity: 1, label: 'Start Time'},
+      {key: 'duration', valueType: 'ms', granularity: 1, label: 'End Time'},
     ];
 
     const tableDetails = Audit.makeTableDetails(headings, results);

package/core/audits/mainthread-work-breakdown.js

@@ -107,8 +107,10 @@ class MainThreadWorkBreakdown extends Audit {
 
     /** @type {LH.Audit.Details.Table['headings']} */
     const headings = [
-      {key: 'groupLabel', itemType: 'text', text: str_(UIStrings.columnCategory)},
-      {key: 'duration', itemType: 'ms', granularity: 1, text: str_(i18n.UIStrings.columnTimeSpent)},
+      /* eslint-disable max-len */
+      {key: 'groupLabel', valueType: 'text', label: str_(UIStrings.columnCategory)},
+      {key: 'duration', valueType: 'ms', granularity: 1, label: str_(i18n.UIStrings.columnTimeSpent)},
+      /* eslint-enable max-len */
     ];
 
     results.sort((a, b) => categoryTotals[b.group] - categoryTotals[a.group]);

package/core/audits/network-requests.js

@@ -85,27 +85,27 @@ class NetworkRequests extends Audit {
     // NOTE(i18n): this audit is only for debug info in the LHR and does not appear in the report.
     /** @type {LH.Audit.Details.Table['headings']} */
     const headings = [
-      {key: 'url', itemType: 'url', text: 'URL'},
-      {key: 'protocol', itemType: 'text', text: 'Protocol'},
-      {key: 'startTime', itemType: 'ms', granularity: 1, text: 'Start Time'},
-      {key: 'endTime', itemType: 'ms', granularity: 1, text: 'End Time'},
+      {key: 'url', valueType: 'url', label: 'URL'},
+      {key: 'protocol', valueType: 'text', label: 'Protocol'},
+      {key: 'startTime', valueType: 'ms', granularity: 1, label: 'Start Time'},
+      {key: 'endTime', valueType: 'ms', granularity: 1, label: 'End Time'},
       {
         key: 'transferSize',
-        itemType: 'bytes',
+        valueType: 'bytes',
         displayUnit: 'kb',
         granularity: 1,
-        text: 'Transfer Size',
+        label: 'Transfer Size',
       },
       {
         key: 'resourceSize',
-        itemType: 'bytes',
+        valueType: 'bytes',
         displayUnit: 'kb',
         granularity: 1,
-        text: 'Resource Size',
+        label: 'Resource Size',
       },
-      {key: 'statusCode', itemType: 'text', text: 'Status Code'},
-      {key: 'mimeType', itemType: 'text', text: 'MIME Type'},
-      {key: 'resourceType', itemType: 'text', text: 'Resource Type'},
+      {key: 'statusCode', valueType: 'text', label: 'Status Code'},
+      {key: 'mimeType', valueType: 'text', label: 'MIME Type'},
+      {key: 'resourceType', valueType: 'text', label: 'Resource Type'},
     ];
 
     const tableDetails = Audit.makeTableDetails(headings, results);

package/core/audits/network-rtt.js

@@ -69,8 +69,8 @@ class NetworkRTT extends Audit {
 
     /** @type {LH.Audit.Details.Table['headings']} */
     const headings = [
-      {key: 'origin', itemType: 'text', text: str_(i18n.UIStrings.columnURL)},
-      {key: 'rtt', itemType: 'ms', granularity: 1, text: str_(i18n.UIStrings.columnTimeSpent)},
+      {key: 'origin', valueType: 'text', label: str_(i18n.UIStrings.columnURL)},
+      {key: 'rtt', valueType: 'ms', granularity: 1, label: str_(i18n.UIStrings.columnTimeSpent)},
     ];
 
     const tableDetails = Audit.makeTableDetails(headings, results);

package/core/audits/network-server-latency.js

@@ -67,9 +67,9 @@ class NetworkServerLatency extends Audit {
 
     /** @type {LH.Audit.Details.Table['headings']} */
     const headings = [
-      {key: 'origin', itemType: 'text', text: str_(i18n.UIStrings.columnURL)},
-      {key: 'serverResponseTime', itemType: 'ms', granularity: 1,
-        text: str_(i18n.UIStrings.columnTimeSpent)},
+      {key: 'origin', valueType: 'text', label: str_(i18n.UIStrings.columnURL)},
+      {key: 'serverResponseTime', valueType: 'ms', granularity: 1,
+        label: str_(i18n.UIStrings.columnTimeSpent)},
     ];
 
     const tableDetails = Audit.makeTableDetails(headings, results);

package/core/audits/no-unload-listeners.js

@@ -50,7 +50,7 @@ class NoUnloadListeners extends Audit {
 
     /** @type {LH.Audit.Details.Table['headings']} */
     const headings = [
-      {key: 'source', itemType: 'source-location', text: str_(i18n.UIStrings.columnSource)},
+      {key: 'source', valueType: 'source-location', label: str_(i18n.UIStrings.columnSource)},
     ];
 
     /** @type {Array<{source: LH.Audit.Details.ItemValue}>} */

package/core/audits/non-composited-animations.js

@@ -173,14 +173,14 @@ class NonCompositedAnimations extends Audit {
     /** @type {LH.Audit.Details.Table['headings']} */
     const headings = [
       /* eslint-disable max-len */
-      {key: 'node', itemType: 'node', subItemsHeading: {key: 'failureReason', itemType: 'text'}, text: str_(i18n.UIStrings.columnElement)},
+      {key: 'node', valueType: 'node', subItemsHeading: {key: 'failureReason', valueType: 'text'}, label: str_(i18n.UIStrings.columnElement)},
       /* eslint-enable max-len */
     ];
 
     if (shouldAddAnimationNameColumn) {
       headings.push(
         /* eslint-disable max-len */
-        {key: null, itemType: 'text', subItemsHeading: {key: 'animation', itemType: 'text'}, text: str_(i18n.UIStrings.columnName)}
+        {key: null, valueType: 'text', subItemsHeading: {key: 'animation', valueType: 'text'}, label: str_(i18n.UIStrings.columnName)}
         /* eslint-enable max-len */
       );
     }

package/core/audits/performance-budget.js

@@ -135,11 +135,11 @@ class ResourceBudget extends Audit {
 
     /** @type {LH.Audit.Details.Table['headings']} */
     const headers = [
-      {key: 'label', itemType: 'text', text: str_(i18n.UIStrings.columnResourceType)},
-      {key: 'requestCount', itemType: 'numeric', text: str_(i18n.UIStrings.columnRequests)},
-      {key: 'transferSize', itemType: 'bytes', text: str_(i18n.UIStrings.columnTransferSize)},
-      {key: 'countOverBudget', itemType: 'text', text: ''},
-      {key: 'sizeOverBudget', itemType: 'bytes', text: str_(i18n.UIStrings.columnOverBudget)},
+      {key: 'label', valueType: 'text', label: str_(i18n.UIStrings.columnResourceType)},
+      {key: 'requestCount', valueType: 'numeric', label: str_(i18n.UIStrings.columnRequests)},
+      {key: 'transferSize', valueType: 'bytes', label: str_(i18n.UIStrings.columnTransferSize)},
+      {key: 'countOverBudget', valueType: 'text', label: ''},
+      {key: 'sizeOverBudget', valueType: 'bytes', label: str_(i18n.UIStrings.columnOverBudget)},
     ];
 
     return {

package/core/audits/preload-fonts.js

@@ -82,7 +82,7 @@ class PreloadFontsAudit extends Audit {
 
     /** @type {LH.Audit.Details.Table['headings']} */
     const headings = [
-      {key: 'url', itemType: 'url', text: str_(i18n.UIStrings.columnURL)},
+      {key: 'url', valueType: 'url', label: str_(i18n.UIStrings.columnURL)},
     ];
 
     return {