lighthouse 10.2.0-dev.20230612 → 10.3.0-dev.20230613

package/core/lib/cdt/generated/SourceMap.d.ts

@@ -1,10 +1,10 @@
-export = TextSourceMap;
-declare class TextSourceMap {
+export = SourceMap;
+declare class SourceMap {
     /**
      * Implements Source Map V3 model. See https://github.com/google/closure-compiler/wiki/Source-Maps
      * for format description.
      */
-    constructor(compiledURL: any, sourceMappingURL: any, payload: any, initiator: any);
+    constructor(compiledURL: any, sourceMappingURL: any, payload: any);
     compiledURL(): any;
     url(): any;
     sourceURLs(): any[];
@@ -36,22 +36,21 @@ declare class TextSourceMap {
     findReverseEntries(sourceURL: any, lineNumber: any, columnNumber: any): any;
     findReverseRanges(sourceURL: any, lineNumber: any, columnNumber: any): any[];
     /** @return {Array<{lineNumber: number, columnNumber: number, sourceURL?: string, sourceLineNumber: number, sourceColumnNumber: number, name?: string, lastColumnNumber?: number}>} */
-    mappings(): Array<{
+    mappings(): {
         lineNumber: number;
         columnNumber: number;
-        sourceURL?: string;
+        sourceURL?: string | undefined;
         sourceLineNumber: number;
         sourceColumnNumber: number;
-        name?: string;
-        lastColumnNumber?: number;
-    }>;
+        name?: string | undefined;
+        lastColumnNumber?: number | undefined;
+    }[];
     reversedMappings(sourceURL: any): any;
     eachSection(callback: any): void;
     parseSources(sourceMap: any): void;
     parseMap(map: any, lineNumber: any, columnNumber: any): void;
     isSeparator(char: any): boolean;
     decodeVLQ(stringCharIterator: any): number;
-    reverseMapTextRange(url: any, textRange: any): any;
     mapsOrigin(): boolean;
     hasIgnoreListHint(sourceURL: any): any;
     /**
@@ -63,30 +62,18 @@ declare class TextSourceMap {
     findRanges(predicate: any, options: any): any[];
     #private;
 }
-declare namespace TextSourceMap {
-    export { __esModule, SourceMapV3, Section, Offset, SourceMapEntry, TextSourceMap };
+declare namespace SourceMap {
+    export { parseSourceMap, __esModule, SourceMapEntry, SourceMap };
 }
+/**
+ * Parses the {@link content} as JSON, ignoring BOM markers in the beginning, and
+ * also handling the CORB bypass prefix correctly.
+ *
+ * @param content the string representation of a sourcemap.
+ * @returns the {@link SourceMapV3} representation of the {@link content}.
+ */
+declare function parseSourceMap(content: any): any;
 declare const __esModule: boolean;
-declare class SourceMapV3 {
-    version: any;
-    file: any;
-    sources: any;
-    sections: any;
-    mappings: any;
-    sourceRoot: any;
-    names: any;
-    sourcesContent: any;
-    x_google_ignoreList: any;
-}
-declare class Section {
-    map: any;
-    offset: any;
-    url: any;
-}
-declare class Offset {
-    line: any;
-    column: any;
-}
 declare class SourceMapEntry {
     static compare(entry1: any, entry2: any): number;
     constructor(lineNumber: any, columnNumber: any, sourceURL: any, sourceLineNumber: any, sourceColumnNumber: any, name: any);

package/core/lib/cdt/generated/SourceMap.js

@@ -8,7 +8,7 @@ const Platform = require('../Platform.js');
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.TextSourceMap = exports.SourceMapEntry = exports.Offset = exports.Section = exports.SourceMapV3 = void 0;
+exports.SourceMap = exports.SourceMapEntry = exports.parseSourceMap = void 0;
 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
@@ -41,42 +41,24 @@ exports.TextSourceMap = exports.SourceMapEntry = exports.Offset = exports.Sectio
 ;
 ;
 ;
-;
-;
-;
-;
-;
-;
-class SourceMapV3 {
-    version;
-    file;
-    sources;
-    sections;
-    mappings;
-    sourceRoot;
-    names;
-    sourcesContent;
-    // eslint-disable-next-line @typescript-eslint/naming-convention
-    x_google_ignoreList;
-    constructor() {
+/**
+ * Parses the {@link content} as JSON, ignoring BOM markers in the beginning, and
+ * also handling the CORB bypass prefix correctly.
+ *
+ * @param content the string representation of a sourcemap.
+ * @returns the {@link SourceMapV3} representation of the {@link content}.
+ */
+function parseSourceMap(content) {
+    if (content.startsWith(')]}')) {
+        content = content.substring(content.indexOf('\n'));
     }
-}
-exports.SourceMapV3 = SourceMapV3;
-class Section {
-    map;
-    offset;
-    url;
-    constructor() {
+    if (content.charCodeAt(0) === 0xFEFF) {
+        // Strip BOM at the beginning before parsing the JSON.
+        content = content.slice(1);
     }
+    return JSON.parse(content);
 }
-exports.Section = Section;
-class Offset {
-    line;
-    column;
-    constructor() {
-    }
-}
-exports.Offset = Offset;
+exports.parseSourceMap = parseSourceMap;
 class SourceMapEntry {
     lineNumber;
     columnNumber;
@@ -106,8 +88,7 @@ for (let i = 0; i < base64Digits.length; ++i) {
     base64Map.set(base64Digits.charAt(i), i);
 }
 const sourceMapToSourceList = new WeakMap();
-class TextSourceMap {
-    #initiator;
+class SourceMap {
     #json;
     #compiledURLInternal;
     #sourceMappingURL;
@@ -118,17 +99,15 @@ class TextSourceMap {
      * Implements Source Map V3 model. See https://github.com/google/closure-compiler/wiki/Source-Maps
      * for format description.
      */
-    constructor(compiledURL, sourceMappingURL, payload, initiator) {
-        this.#initiator = initiator;
+    constructor(compiledURL, sourceMappingURL, payload) {
         this.#json = payload;
         this.#compiledURLInternal = compiledURL;
         this.#sourceMappingURL = sourceMappingURL;
         this.#baseURL = (sourceMappingURL.startsWith('data:') ? compiledURL : sourceMappingURL);
         this.#mappingsInternal = null;
         this.#sourceInfos = new Map();
-        if (this.#json.sections) {
-            const sectionWithURL = Boolean(this.#json.sections.find(section => Boolean(section.url)));
-            if (sectionWithURL) {
+        if ('sections' in this.#json) {
+            if (this.#json.sections.find(section => 'url' in section)) {
                 console.warn(`SourceMap "${sourceMappingURL}" contains unsupported "URL" field in one of its sections.`);
             }
         }
@@ -266,6 +245,8 @@ class TextSourceMap {
         if (this.#mappingsInternal === null) {
             this.#mappingsInternal = [];
             this.eachSection(this.parseMap.bind(this));
+            // As per spec, mappings are not necessarily sorted.
+            this.mappings().sort(SourceMapEntry.compare);
             this.#computeReverseMappings(this.#mappingsInternal);
             this.#json = null;
         }
@@ -303,42 +284,43 @@ class TextSourceMap {
         if (!this.#json) {
             return;
         }
-        if (!this.#json.sections) {
-            callback(this.#json, 0, 0);
-            return;
+        if ('sections' in this.#json) {
+            for (const section of this.#json.sections) {
+                if ('map' in section) {
+                    callback(section.map, section.offset.line, section.offset.column);
+                }
+            }
         }
-        for (const section of this.#json.sections) {
-            callback(section.map, section.offset.line, section.offset.column);
+        else {
+            callback(this.#json, 0, 0);
         }
     }
     parseSources(sourceMap) {
         const sourcesList = [];
-        const sourceRoot = sourceMap.sourceRoot || Platform.DevToolsPath.EmptyUrlString;
+        const sourceRoot = sourceMap.sourceRoot ?? '';
         const ignoreList = new Set(sourceMap.x_google_ignoreList);
         for (let i = 0; i < sourceMap.sources.length; ++i) {
             let href = sourceMap.sources[i];
             // The source map v3 proposal says to prepend the sourceRoot to the source URL
             // and if the resulting URL is not absolute, then resolve the source URL against
-            // the source map URL. Appending the sourceRoot (if one exists) is not likely to
+            // the source map URL. Prepending the sourceRoot (if one exists) is not likely to
             // be meaningful or useful if the source URL is already absolute though. In this
             // case, use the source URL as is without prepending the sourceRoot.
             if (Common.ParsedURL.ParsedURL.isRelativeURL(href)) {
                 if (sourceRoot && !sourceRoot.endsWith('/') && href && !href.startsWith('/')) {
-                    href = Common.ParsedURL.ParsedURL.concatenate(sourceRoot, '/', href);
+                    href = sourceRoot.concat('/', href);
                 }
                 else {
-                    href = Common.ParsedURL.ParsedURL.concatenate(sourceRoot, href);
+                    href = sourceRoot.concat(href);
                 }
             }
-            let url = '' || href;
+            const url = '' || href;
             const source = sourceMap.sourcesContent && sourceMap.sourcesContent[i];
-            if (url === this.#compiledURLInternal && source) {
-            }
             sourcesList.push(url);
             if (!this.#sourceInfos.has(url)) {
                 const content = source ?? null;
                 const ignoreListHint = ignoreList.has(i);
-                this.#sourceInfos.set(url, new TextSourceMap.SourceInfo(content, ignoreListHint));
+                this.#sourceInfos.set(url, { content, ignoreListHint, reverseMappings: null });
             }
         }
         sourceMapToSourceList.set(sourceMap, sourcesList);
@@ -355,8 +337,8 @@ class TextSourceMap {
         // only reach this point when we are certain
         // we have the list available.
         const sources = sourceMapToSourceList.get(map);
-        const names = map.names || [];
-        const stringCharIterator = new TextSourceMap.StringCharIterator(map.mappings);
+        const names = map.names ?? [];
+        const stringCharIterator = new SourceMap.StringCharIterator(map.mappings);
         let sourceURL = sources && sources[sourceIndex];
         while (true) {
             if (stringCharIterator.peek() === ',') {
@@ -393,8 +375,6 @@ class TextSourceMap {
             nameIndex += this.decodeVLQ(stringCharIterator);
             this.mappings().push(new SourceMapEntry(lineNumber, columnNumber, sourceURL, sourceLineNumber, sourceColumnNumber, names[nameIndex]));
         }
-        // As per spec, mappings are not necessarily sorted.
-        this.mappings().sort(SourceMapEntry.compare);
     }
     isSeparator(char) {
         return char === ',' || char === ';';
@@ -403,38 +383,17 @@ class TextSourceMap {
         // Read unsigned value.
         let result = 0;
         let shift = 0;
-        let digit = TextSourceMap._VLQ_CONTINUATION_MASK;
-        while (digit & TextSourceMap._VLQ_CONTINUATION_MASK) {
+        let digit = SourceMap._VLQ_CONTINUATION_MASK;
+        while (digit & SourceMap._VLQ_CONTINUATION_MASK) {
             digit = base64Map.get(stringCharIterator.next()) || 0;
-            result += (digit & TextSourceMap._VLQ_BASE_MASK) << shift;
-            shift += TextSourceMap._VLQ_BASE_SHIFT;
+            result += (digit & SourceMap._VLQ_BASE_MASK) << shift;
+            shift += SourceMap._VLQ_BASE_SHIFT;
         }
         // Fix the sign.
         const negative = result & 1;
         result >>= 1;
         return negative ? -result : result;
     }
-    reverseMapTextRange(url, textRange) {
-        function comparator(position, mappingIndex) {
-            if (position.lineNumber !== mappings[mappingIndex].sourceLineNumber) {
-                return position.lineNumber - mappings[mappingIndex].sourceLineNumber;
-            }
-            return position.columnNumber - mappings[mappingIndex].sourceColumnNumber;
-        }
-        const reverseMappings = this.reversedMappings(url);
-        const mappings = this.mappings();
-        if (!reverseMappings.length) {
-            return null;
-        }
-        const startIndex = Platform.ArrayUtilities.lowerBound(reverseMappings, { lineNumber: textRange.startLine, columnNumber: textRange.startColumn }, comparator);
-        const endIndex = Platform.ArrayUtilities.upperBound(reverseMappings, { lineNumber: textRange.endLine, columnNumber: textRange.endColumn }, comparator);
-        if (endIndex >= reverseMappings.length) {
-            return null;
-        }
-        const startMapping = mappings[reverseMappings[startIndex]];
-        const endMapping = mappings[reverseMappings[endIndex]];
-        return new TextUtils.TextRange.TextRange(startMapping.lineNumber, startMapping.columnNumber, endMapping.lineNumber, endMapping.columnNumber);
-    }
     mapsOrigin() {
         const mappings = this.mappings();
         if (mappings.length > 0) {
@@ -482,17 +441,17 @@ class TextSourceMap {
         return ranges;
     }
 }
-exports.TextSourceMap = TextSourceMap;
-(function (TextSourceMap) {
+exports.SourceMap = SourceMap;
+(function (SourceMap) {
     // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration
     // eslint-disable-next-line @typescript-eslint/naming-convention
-    TextSourceMap._VLQ_BASE_SHIFT = 5;
+    SourceMap._VLQ_BASE_SHIFT = 5;
     // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration
     // eslint-disable-next-line @typescript-eslint/naming-convention
-    TextSourceMap._VLQ_BASE_MASK = (1 << 5) - 1;
+    SourceMap._VLQ_BASE_MASK = (1 << 5) - 1;
     // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration
     // eslint-disable-next-line @typescript-eslint/naming-convention
-    TextSourceMap._VLQ_CONTINUATION_MASK = 1 << 5;
+    SourceMap._VLQ_CONTINUATION_MASK = 1 << 5;
     class StringCharIterator {
         string;
         position;
@@ -510,18 +469,9 @@ exports.TextSourceMap = TextSourceMap;
             return this.position < this.string.length;
         }
     }
-    TextSourceMap.StringCharIterator = StringCharIterator;
-    class SourceInfo {
-        content;
-        ignoreListHint;
-        reverseMappings = null;
-        constructor(content, ignoreListHint) {
-            this.content = content;
-            this.ignoreListHint = ignoreListHint;
-        }
-    }
-    TextSourceMap.SourceInfo = SourceInfo;
-})(TextSourceMap = exports.TextSourceMap || (exports.TextSourceMap = {}));
+    SourceMap.StringCharIterator = StringCharIterator;
+})(SourceMap = exports.SourceMap || (exports.SourceMap = {}));
 
 
-module.exports = TextSourceMap;
+module.exports = SourceMap;
+SourceMap.parseSourceMap = parseSourceMap;

package/core/lib/dependency-graph/simulator/network-analyzer.js

@@ -139,6 +139,15 @@ class NetworkAnalyzer {
     return NetworkAnalyzer._estimateValueByOrigin(records, ({timing, connectionReused, record}) => {
       if (connectionReused) return;
 
+      // In LR, network records are missing connection timing, but we've smuggled it in via headers.
+      if (global.isLightrider && record.lrStatistics) {
+        if (record.protocol.startsWith('h3')) {
+          return record.lrStatistics.TCPMs;
+        } else {
+          return [record.lrStatistics.TCPMs / 2, record.lrStatistics.TCPMs / 2];
+        }
+      }
+
       const {connectStart, sslStart, sslEnd, connectEnd} = timing;
       if (connectEnd >= 0 && connectStart >= 0 && record.protocol.startsWith('h3')) {
         // These values are equal to sslStart and sslEnd for h3.
@@ -247,6 +256,10 @@ class NetworkAnalyzer {
    */
   static _estimateResponseTimeByOrigin(records, rttByOrigin) {
     return NetworkAnalyzer._estimateValueByOrigin(records, ({record, timing}) => {
+      // Lightrider does not have timings for sendEnd, but we do have this timing which should be
+      // close to the response time.
+      if (global.isLightrider && record.lrStatistics) return record.lrStatistics.requestMs;
+
       if (!Number.isFinite(timing.receiveHeadersEnd) || timing.receiveHeadersEnd < 0) return;
       if (!Number.isFinite(timing.sendEnd) || timing.sendEnd < 0) return;
 

package/core/lib/deprecation-description.d.ts

@@ -0,0 +1,17 @@
+/**
+ * @param {LH.Crdp.Audits.DeprecationIssueDetails} issueDetails
+ */
+export function getIssueDetailDescription(issueDetails: LH.Crdp.Audits.DeprecationIssueDetails): {
+    substitutions: Map<string, import("../index.js").IcuMessage | undefined>;
+    links: {
+        link: string;
+        linkTitle: import("../index.js").IcuMessage;
+    }[];
+    message: import("../index.js").IcuMessage | undefined;
+};
+export namespace UIStrings {
+    const feature: string;
+    const milestone: string;
+    const title: string;
+}
+//# sourceMappingURL=deprecation-description.d.ts.map

package/core/lib/deprecation-description.js

@@ -0,0 +1,71 @@
+/**
+ * @license Copyright 2023 The Lighthouse Authors. All Rights Reserved.
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
+ * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
+ */
+
+import * as i18n from '../lib/i18n/i18n.js';
+import {DEPRECATIONS_METADATA, UIStrings as DeprecationUIStrings} from './deprecations-strings.js';
+
+const UIStrings = {
+  // Store strings used across messages in this block.
+  /**
+   * @description This links to the chrome feature status page when one exists.
+   */
+  feature: 'Check the feature status page for more details.',
+  /**
+   * @description This links to the chromium dash schedule when a milestone is set.
+   * @example {100} milestone
+   */
+  milestone: 'This change will go into effect with milestone {milestone}.',
+  /**
+   * @description Title of issue raised when a deprecated feature is used
+   */
+  title: 'Deprecated Feature Used',
+};
+
+const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
+const deprecationsStr_ = i18n.createIcuMessageFn(import.meta.url, DeprecationUIStrings);
+
+/**
+ * @param {LH.Crdp.Audits.DeprecationIssueDetails} issueDetails
+ */
+function getIssueDetailDescription(issueDetails) {
+  let message;
+  const type = /** @type {keyof DEPRECATIONS_METADATA} */ (issueDetails.type);
+  const maybeEnglishMessage = DeprecationUIStrings[type];
+  if (maybeEnglishMessage) {
+    message = deprecationsStr_(maybeEnglishMessage);
+  }
+
+  const links = [];
+  /** @type {{chromeStatusFeature?: number, milestone?: number}|undefined} */
+  const deprecationMeta = DEPRECATIONS_METADATA[type];
+  const feature = deprecationMeta?.chromeStatusFeature ?? 0;
+  if (feature !== 0) {
+    links.push({
+      link: `https://chromestatus.com/feature/${feature}`,
+      linkTitle: str_(UIStrings.feature),
+    });
+  }
+  const milestone = deprecationMeta?.milestone ?? 0;
+  if (milestone !== 0) {
+    links.push({
+      link: 'https://chromiumdash.appspot.com/schedule',
+      linkTitle: str_(UIStrings.milestone, {milestone}),
+    });
+  }
+  return ({
+    substitutions: new Map([
+      ['PLACEHOLDER_title', str_(UIStrings.title)],
+      ['PLACEHOLDER_message', message],
+    ]),
+    links,
+    message,
+  });
+}
+
+export {
+  getIssueDetailDescription,
+  UIStrings,
+};