lighthouse 10.2.0-dev.20230612 → 10.3.0-dev.20230613

package/core/audits/deprecations.js

@@ -11,7 +11,7 @@
 import {Audit} from './audit.js';
 import {JSBundles} from '../computed/js-bundles.js';
 import * as i18n from '../lib/i18n/i18n.js';
-import {getIssueDetailDescription} from '../lib/deprecations-strings.js';
+import {getIssueDetailDescription} from '../lib/deprecation-description.js';
 
 /* eslint-disable max-len */
 const UIStrings = {

package/core/audits/server-response-time.d.ts

@@ -2,8 +2,9 @@ export default ServerResponseTime;
 declare class ServerResponseTime extends Audit {
     /**
      * @param {LH.Artifacts.NetworkRequest} record
+     * @return {number|null}
      */
-    static calculateResponseTime(record: LH.Artifacts.NetworkRequest): number;
+    static calculateResponseTime(record: LH.Artifacts.NetworkRequest): number | null;
     /**
      * @param {LH.Artifacts} artifacts
      * @param {LH.Audit.Context} context

package/core/audits/server-response-time.js

@@ -43,10 +43,15 @@ class ServerResponseTime extends Audit {
 
   /**
    * @param {LH.Artifacts.NetworkRequest} record
+   * @return {number|null}
    */
   static calculateResponseTime(record) {
-    const timing = record.timing;
-    return timing ? timing.receiveHeadersStart - timing.sendEnd : 0;
+    // Lightrider does not have timings for sendEnd, but we do have this timing which should be
+    // close to the response time.
+    if (global.isLightrider && record.lrStatistics) return record.lrStatistics.requestMs;
+
+    if (!record.timing) return null;
+    return record.timing.receiveHeadersStart - record.timing.sendEnd;
   }
 
   /**
@@ -61,6 +66,10 @@ class ServerResponseTime extends Audit {
     const mainResource = await MainResource.request({devtoolsLog, URL: artifacts.URL}, context);
 
     const responseTime = ServerResponseTime.calculateResponseTime(mainResource);
+    if (responseTime === null) {
+      throw new Error('no timing found for main resource');
+    }
+
     const passed = responseTime < TOO_SLOW_THRESHOLD_MS;
     const displayValue = str_(UIStrings.displayValue, {timeInMs: responseTime});
 

package/core/audits/uses-rel-preconnect.js

@@ -72,7 +72,7 @@ class UsesRelPreconnectAudit extends Audit {
    * @return {boolean}
    */
   static hasValidTiming(record) {
-    return !!record.timing && record.timing.connectEnd > 0 && record.timing.connectStart > 0;
+    return !!record.timing && record.timing.connectEnd >= 0 && record.timing.connectStart >= 0;
   }
 
   /**
@@ -81,11 +81,27 @@ class UsesRelPreconnectAudit extends Audit {
    * @return {boolean}
    */
   static hasAlreadyConnectedToOrigin(record) {
-    return (
-      !!record.timing &&
+    if (!record.timing) return false;
+
+    // When these values are given as -1, that means the page has
+    // a connection for this origin and paid these costs already.
+    if (
+      record.timing.dnsStart === -1 && record.timing.dnsEnd === -1 &&
+      record.timing.connectStart === -1 && record.timing.connectEnd === -1
+    ) {
+      return true;
+    }
+
+    // Less understood: if the connection setup took no time at all, consider
+    // it the same as the above. It is unclear if this is correct, or is even possible.
+    if (
       record.timing.dnsEnd - record.timing.dnsStart === 0 &&
       record.timing.connectEnd - record.timing.connectStart === 0
-    );
+    ) {
+      return true;
+    }
+
+    return false;
   }
 
   /**

package/core/lib/bf-cache-strings.d.ts

@@ -117,5 +117,8 @@ export namespace UIStrings {
     const errorDocument: string;
     const fencedFramesEmbedder: string;
     const keepaliveRequest: string;
+    const authorizationHeader: string;
+    const indexedDBEvent: string;
+    const cookieDisabled: string;
 }
 //# sourceMappingURL=bf-cache-strings.d.ts.map