legend-doctor 0.1.0

package/dist/src/rules/observable-tracking/reactive-inputs.js

@@ -0,0 +1,231 @@
+import { outermostTransparentParent, provenObservablePath, } from "../observable-reads/observable-paths.js";
+import ts from "typescript";
+import { unwrapTransparentExpression } from "../../core/analysis-ast.js";
+import { visit } from "../../core/ast.js";
+const COMPONENT_SLOTS = new Map([
+    ["For", new Set(["each"])],
+    ["Show", new Set(["if", "ifReady"])],
+    ["Switch", new Set(["value"])],
+]);
+const CHILD_COMPONENTS = new Set(["Computed", "Memo"]);
+const REACTIONS = new Set([
+    "observe",
+    "useObserve",
+    "useObserveEffect",
+    "useWhen",
+    "useWhenReady",
+    "when",
+    "whenReady",
+]);
+const reactiveComponentsBySource = new WeakMap();
+/**
+ * A `get()` or `peek()` snapshot handed to a Legend input that expects an observable or
+ * selector: `Show if`, `Switch value`, `For each`, a `Memo`/`Computed` child, a `$`-prefixed
+ * reactive prop, or the first argument of `observe`/`when` and their hooks. Legend can only
+ * track what it receives, so the snapshot freezes the input at the parent's render.
+ */
+export function eagerReactiveInput(call, scan) {
+    const read = snapshotRead(call);
+    const observable = read && provenObservablePath(read.receiver, scan.observableBindings);
+    if (!read || !observable) {
+        return null;
+    }
+    const outer = outermostTransparentParent(call);
+    const slot = reactiveSlotFor(outer, scan);
+    return slot ? { call, observable, ...slot } : null;
+}
+function snapshotRead(call) {
+    if (call.arguments.length > 0 ||
+        (call.typeArguments?.length ?? 0) > 0 ||
+        call.questionDotToken ||
+        !ts.isPropertyAccessExpression(call.expression) ||
+        call.expression.questionDotToken) {
+        return null;
+    }
+    const method = call.expression.name.text;
+    if (method !== "get" && method !== "peek") {
+        return null;
+    }
+    return { method, receiver: unwrapTransparentExpression(call.expression.expression) };
+}
+function reactiveSlotFor(outer, scan) {
+    const { parent } = outer;
+    if (ts.isJsxExpression(parent)) {
+        const container = parent.parent;
+        if (ts.isJsxAttribute(container)) {
+            return attributeSlot(container, scan);
+        }
+        return ts.isJsxElement(container) ? childSlot(container.openingElement, scan.imports) : null;
+    }
+    if (ts.isCallExpression(parent) && parent.arguments[0] === outer) {
+        return reactionSlot(parent, scan.imports);
+    }
+    return null;
+}
+function attributeSlot(attribute, scan) {
+    const tag = attribute.parent.parent;
+    if (!ts.isJsxOpeningElement(tag) && !ts.isJsxSelfClosingElement(tag)) {
+        return null;
+    }
+    const name = attribute.name.getText();
+    const component = legendReactComponentOf(tag, scan.imports);
+    if (component) {
+        return COMPONENT_SLOTS.get(component)?.has(name)
+            ? componentAttributeSlot(component, name)
+            : null;
+    }
+    if (!name.startsWith("$") || !isReactiveHostTag(tag, scan)) {
+        return null;
+    }
+    return {
+        consequence: "the reactive prop tracks an observable or selector on its own, while the snapshot only updates when the parent re-renders",
+        slot: `\`<${tag.tagName.getText()} ${name}>\``,
+    };
+}
+function componentAttributeSlot(component, name) {
+    const slot = `\`<${component} ${name}>\``;
+    if (component === "For") {
+        return {
+            consequence: "`For` calls `get()` on the collection it receives to track membership, so the raw array breaks that contract",
+            slot,
+        };
+    }
+    return {
+        consequence: `\`${component}\` tracks the observable itself, while the snapshot only updates when the parent re-renders`,
+        slot,
+    };
+}
+function childSlot(tag, imports) {
+    const component = legendReactComponentOf(tag, imports);
+    if (!component || !CHILD_COMPONENTS.has(component)) {
+        return null;
+    }
+    return {
+        consequence: `\`${component}\` re-renders from its own observable, not from its parent, so the snapshot never updates`,
+        slot: `\`<${component}>\``,
+    };
+}
+function reactionSlot(call, imports) {
+    const reaction = legendReactionOf(call, imports);
+    if (!reaction) {
+        return null;
+    }
+    const slot = `\`${reaction}\``;
+    if (reaction === "when" ||
+        reaction === "whenReady" ||
+        reaction === "useWhen" ||
+        reaction === "useWhenReady") {
+        return {
+            consequence: `\`${reaction}\` resolves the snapshot once instead of waiting for the observable to change`,
+            slot,
+        };
+    }
+    return {
+        consequence: `\`${reaction}\` runs once against the snapshot instead of re-running when the observable changes`,
+        slot,
+    };
+}
+function legendReactComponentOf(tag, imports) {
+    const { tagName } = tag;
+    if (ts.isIdentifier(tagName)) {
+        return imports.legendReactComponents.get(tagName.text) ?? null;
+    }
+    if (ts.isPropertyAccessExpression(tagName) &&
+        ts.isIdentifier(tagName.expression) &&
+        imports.legendReactNamespaces.has(tagName.expression.text)) {
+        return canonicalComponent(tagName.name.text);
+    }
+    return null;
+}
+function canonicalComponent(name) {
+    return name === "Computed" ||
+        name === "For" ||
+        name === "Memo" ||
+        name === "Show" ||
+        name === "Switch"
+        ? name
+        : null;
+}
+function legendReactionOf(call, imports) {
+    const callee = unwrapTransparentExpression(call.expression);
+    if (ts.isIdentifier(callee)) {
+        return imports.legendReactions.get(callee.text) ?? null;
+    }
+    if (!ts.isPropertyAccessExpression(callee) ||
+        !ts.isIdentifier(callee.expression) ||
+        !REACTIONS.has(callee.name.text)) {
+        return null;
+    }
+    const namespace = callee.expression.text;
+    const hook = callee.name.text.startsWith("use");
+    const namespaces = hook ? imports.legendReactNamespaces : imports.legendNamespaces;
+    return namespaces.has(namespace) ? canonicalReaction(callee.name.text) : null;
+}
+function canonicalReaction(name) {
+    return name === "observe" ||
+        name === "useObserve" ||
+        name === "useObserveEffect" ||
+        name === "useWhen" ||
+        name === "useWhenReady" ||
+        name === "when" ||
+        name === "whenReady"
+        ? name
+        : null;
+}
+function isReactiveHostTag(tag, scan) {
+    const { tagName } = tag;
+    if (ts.isIdentifier(tagName)) {
+        return (scan.imports.reactiveHosts.has(tagName.text) || reactiveComponentNames(scan).has(tagName.text));
+    }
+    return (ts.isPropertyAccessExpression(tagName) &&
+        ts.isIdentifier(tagName.expression) &&
+        scan.imports.reactiveHosts.has(tagName.expression.text));
+}
+function reactiveComponentNames(scan) {
+    const cached = reactiveComponentsBySource.get(scan.sourceFile);
+    if (cached) {
+        return cached;
+    }
+    const names = new Set();
+    visit(scan.sourceFile, (node) => {
+        if (!ts.isVariableDeclaration(node) || !ts.isIdentifier(node.name) || !node.initializer) {
+            return;
+        }
+        const initializer = unwrapTransparentExpression(node.initializer);
+        if (ts.isCallExpression(initializer) && isReactiveFactoryCall(initializer, scan.imports)) {
+            names.add(node.name.text);
+        }
+    });
+    reactiveComponentsBySource.set(scan.sourceFile, names);
+    return names;
+}
+function isReactiveFactoryCall(call, imports) {
+    const callee = unwrapTransparentExpression(call.expression);
+    if (ts.isIdentifier(callee)) {
+        return imports.reactiveFactories.has(callee.text) || imports.legendObservers.has(callee.text);
+    }
+    return (ts.isPropertyAccessExpression(callee) &&
+        ts.isIdentifier(callee.expression) &&
+        imports.legendReactNamespaces.has(callee.expression.text) &&
+        (callee.name.text === "reactive" || callee.name.text === "reactiveObserver"));
+}
+export function eagerReactiveInputFinding(input, scan) {
+    const { call, consequence, observable, slot } = input;
+    const { line, character } = scan.sourceFile.getLineAndCharacterOfPosition(call.getStart(scan.sourceFile));
+    const read = call.getText(scan.sourceFile);
+    const path = observable.getText(scan.sourceFile);
+    return {
+        action: "pass-observable-to-reactive-input",
+        confidence: "certain",
+        disposition: "change",
+        evidence: [
+            `${path} is a proven Legend observable path`,
+            `${slot} accepts an observable or selector and tracks it in its own context`,
+            "the snapshot is evaluated once in the parent's render and never tracked",
+        ],
+        location: { column: character + 1, file: scan.fileName, line: line + 1 },
+        message: `Replace \`${read}\` with \`${path}\` in ${slot}; ${consequence}.`,
+        practice: "reactivity",
+    };
+}
+//# sourceMappingURL=reactive-inputs.js.map

package/dist/src/rules/observable-tracking/reactive-inputs.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"reactive-inputs.js","sourceRoot":"","sources":["../../../../src/rules/observable-tracking/reactive-inputs.ts"],"names":[],"mappings":"AACA,OAAO,EACL,0BAA0B,EAC1B,oBAAoB,GACrB,MAAM,yCAAyC,CAAC;AAGjD,OAAO,EAAE,MAAM,YAAY,CAAC;AAC5B,OAAO,EAAE,2BAA2B,EAAE,MAAM,4BAA4B,CAAC;AACzE,OAAO,EAAE,KAAK,EAAE,MAAM,mBAAmB,CAAC;AAqB1C,MAAM,eAAe,GAA2D,IAAI,GAAG,CAAC;IACtF,CAAC,KAAK,EAAE,IAAI,GAAG,CAAC,CAAC,MAAM,CAAC,CAAC,CAAC;IAC1B,CAAC,MAAM,EAAE,IAAI,GAAG,CAAC,CAAC,IAAI,EAAE,SAAS,CAAC,CAAC,CAAC;IACpC,CAAC,QAAQ,EAAE,IAAI,GAAG,CAAC,CAAC,OAAO,CAAC,CAAC,CAAC;CAC/B,CAAC,CAAC;AAEH,MAAM,gBAAgB,GAAsC,IAAI,GAAG,CAAC,CAAC,UAAU,EAAE,MAAM,CAAC,CAAC,CAAC;AAE1F,MAAM,SAAS,GAAwB,IAAI,GAAG,CAAC;IAC7C,SAAS;IACT,YAAY;IACZ,kBAAkB;IAClB,SAAS;IACT,cAAc;IACd,MAAM;IACN,WAAW;CACZ,CAAC,CAAC;AAEH,MAAM,0BAA0B,GAAG,IAAI,OAAO,EAAsC,CAAC;AAErF;;;;;GAKG;AACH,MAAM,UAAU,kBAAkB,CAChC,IAAuB,EACvB,IAAkB;IAElB,MAAM,IAAI,GAAG,YAAY,CAAC,IAAI,CAAC,CAAC;IAChC,MAAM,UAAU,GAAG,IAAI,IAAI,oBAAoB,CAAC,IAAI,CAAC,QAAQ,EAAE,IAAI,CAAC,kBAAkB,CAAC,CAAC;IACxF,IAAI,CAAC,IAAI,IAAI,CAAC,UAAU,EAAE,CAAC;QACzB,OAAO,IAAI,CAAC;IACd,CAAC;IACD,MAAM,KAAK,GAAG,0BAA0B,CAAC,IAAI,CAAC,CAAC;IAC/C,MAAM,IAAI,GAAG,eAAe,CAAC,KAAK,EAAE,IAAI,CAAC,CAAC;IAC1C,OAAO,IAAI,CAAC,CAAC,CAAC,EAAE,IAAI,EAAE,UAAU,EAAE,GAAG,IAAI,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC;AACrD,CAAC;AAED,SAAS,YAAY,CAAC,IAAuB;IAC3C,IACE,IAAI,CAAC,SAAS,CAAC,MAAM,GAAG,CAAC;QACzB,CAAC,IAAI,CAAC,aAAa,EAAE,MAAM,IAAI,CAAC,CAAC,GAAG,CAAC;QACrC,IAAI,CAAC,gBAAgB;QACrB,CAAC,EAAE,CAAC,0BAA0B,CAAC,IAAI,CAAC,UAAU,CAAC;QAC/C,IAAI,CAAC,UAAU,CAAC,gBAAgB,EAChC,CAAC;QACD,OAAO,IAAI,CAAC;IACd,CAAC;IACD,MAAM,MAAM,GAAG,IAAI,CAAC,UAAU,CAAC,IAAI,CAAC,IAAI,CAAC;IACzC,IAAI,MAAM,KAAK,KAAK,IAAI,MAAM,KAAK,MAAM,EAAE,CAAC;QAC1C,OAAO,IAAI,CAAC;IACd,CAAC;IACD,OAAO,EAAE,MAAM,EAAE,QAAQ,EAAE,2BAA2B,CAAC,IAAI,CAAC,UAAU,CAAC,UAAU,CAAC,EAAE,CAAC;AACvF,CAAC;AAED,SAAS,eAAe,CAAC,KAAoB,EAAE,IAAkB;IAC/D,MAAM,EAAE,MAAM,EAAE,GAAG,KAAK,CAAC;IACzB,IAAI,EAAE,CAAC,eAAe,CAAC,MAAM,CAAC,EAAE,CAAC;QAC/B,MAAM,SAAS,GAAG,MAAM,CAAC,MAAM,CAAC;QAChC,IAAI,EAAE,CAAC,cAAc,CAAC,SAAS,CAAC,EAAE,CAAC;YACjC,OAAO,aAAa,CAAC,SAAS,EAAE,IAAI,CAAC,CAAC;QACxC,CAAC;QACD,OAAO,EAAE,CAAC,YAAY,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC,SAAS,CAAC,cAAc,EAAE,IAAI,CAAC,OAAO,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC;IAC/F,CAAC;IACD,IAAI,EAAE,CAAC,gBAAgB,CAAC,MAAM,CAAC,IAAI,MAAM,CAAC,SAAS,CAAC,CAAC,CAAC,KAAK,KAAK,EAAE,CAAC;QACjE,OAAO,YAAY,CAAC,MAAM,EAAE,IAAI,CAAC,OAAO,CAAC,CAAC;IAC5C,CAAC;IACD,OAAO,IAAI,CAAC;AACd,CAAC;AAED,SAAS,aAAa,CAAC,SAA0B,EAAE,IAAkB;IACnE,MAAM,GAAG,GAAG,SAAS,CAAC,MAAM,CAAC,MAAM,CAAC;IACpC,IAAI,CAAC,EAAE,CAAC,mBAAmB,CAAC,GAAG,CAAC,IAAI,CAAC,EAAE,CAAC,uBAAuB,CAAC,GAAG,CAAC,EAAE,CAAC;QACrE,OAAO,IAAI,CAAC;IACd,CAAC;IACD,MAAM,IAAI,GAAG,SAAS,CAAC,IAAI,CAAC,OAAO,EAAE,CAAC;IACtC,MAAM,SAAS,GAAG,sBAAsB,CAAC,GAAG,EAAE,IAAI,CAAC,OAAO,CAAC,CAAC;IAC5D,IAAI,SAAS,EAAE,CAAC;QACd,OAAO,eAAe,CAAC,GAAG,CAAC,SAAS,CAAC,EAAE,GAAG,CAAC,IAAI,CAAC;YAC9C,CAAC,CAAC,sBAAsB,CAAC,SAAS,EAAE,IAAI,CAAC;YACzC,CAAC,CAAC,IAAI,CAAC;IACX,CAAC;IACD,IAAI,CAAC,IAAI,CAAC,UAAU,CAAC,GAAG,CAAC,IAAI,CAAC,iBAAiB,CAAC,GAAG,EAAE,IAAI,CAAC,EAAE,CAAC;QAC3D,OAAO,IAAI,CAAC;IACd,CAAC;IACD,OAAO;QACL,WAAW,EACT,2HAA2H;QAC7H,IAAI,EAAE,MAAM,GAAG,CAAC,OAAO,CAAC,OAAO,EAAE,IAAI,IAAI,KAAK;KAC/C,CAAC;AACJ,CAAC;AAED,SAAS,sBAAsB,CAAC,SAA+B,EAAE,IAAY;IAC3E,MAAM,IAAI,GAAG,MAAM,SAAS,IAAI,IAAI,KAAK,CAAC;IAC1C,IAAI,SAAS,KAAK,KAAK,EAAE,CAAC;QACxB,OAAO;YACL,WAAW,EACT,8GAA8G;YAChH,IAAI;SACL,CAAC;IACJ,CAAC;IACD,OAAO;QACL,WAAW,EAAE,KAAK,SAAS,6FAA6F;QACxH,IAAI;KACL,CAAC;AACJ,CAAC;AAED,SAAS,SAAS,CAAC,GAAyB,EAAE,OAAoB;IAChE,MAAM,SAAS,GAAG,sBAAsB,CAAC,GAAG,EAAE,OAAO,CAAC,CAAC;IACvD,IAAI,CAAC,SAAS,IAAI,CAAC,gBAAgB,CAAC,GAAG,CAAC,SAAS,CAAC,EAAE,CAAC;QACnD,OAAO,IAAI,CAAC;IACd,CAAC;IACD,OAAO;QACL,WAAW,EAAE,KAAK,SAAS,2FAA2F;QACtH,IAAI,EAAE,MAAM,SAAS,KAAK;KAC3B,CAAC;AACJ,CAAC;AAED,SAAS,YAAY,CAAC,IAAuB,EAAE,OAAoB;IACjE,MAAM,QAAQ,GAAG,gBAAgB,CAAC,IAAI,EAAE,OAAO,CAAC,CAAC;IACjD,IAAI,CAAC,QAAQ,EAAE,CAAC;QACd,OAAO,IAAI,CAAC;IACd,CAAC;IACD,MAAM,IAAI,GAAG,KAAK,QAAQ,IAAI,CAAC;IAC/B,IACE,QAAQ,KAAK,MAAM;QACnB,QAAQ,KAAK,WAAW;QACxB,QAAQ,KAAK,SAAS;QACtB,QAAQ,KAAK,cAAc,EAC3B,CAAC;QACD,OAAO;YACL,WAAW,EAAE,KAAK,QAAQ,+EAA+E;YACzG,IAAI;SACL,CAAC;IACJ,CAAC;IACD,OAAO;QACL,WAAW,EAAE,KAAK,QAAQ,qFAAqF;QAC/G,IAAI;KACL,CAAC;AACJ,CAAC;AAED,SAAS,sBAAsB,CAAC,GAAW,EAAE,OAAoB;IAC/D,MAAM,EAAE,OAAO,EAAE,GAAG,GAAG,CAAC;IACxB,IAAI,EAAE,CAAC,YAAY,CAAC,OAAO,CAAC,EAAE,CAAC;QAC7B,OAAO,OAAO,CAAC,qBAAqB,CAAC,GAAG,CAAC,OAAO,CAAC,IAAI,CAAC,IAAI,IAAI,CAAC;IACjE,CAAC;IACD,IACE,EAAE,CAAC,0BAA0B,CAAC,OAAO,CAAC;QACtC,EAAE,CAAC,YAAY,CAAC,OAAO,CAAC,UAAU,CAAC;QACnC,OAAO,CAAC,qBAAqB,CAAC,GAAG,CAAC,OAAO,CAAC,UAAU,CAAC,IAAI,CAAC,EAC1D,CAAC;QACD,OAAO,kBAAkB,CAAC,OAAO,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;IAC/C,CAAC;IACD,OAAO,IAAI,CAAC;AACd,CAAC;AAED,SAAS,kBAAkB,CAAC,IAAY;IACtC,OAAO,IAAI,KAAK,UAAU;QACxB,IAAI,KAAK,KAAK;QACd,IAAI,KAAK,MAAM;QACf,IAAI,KAAK,MAAM;QACf,IAAI,KAAK,QAAQ;QACjB,CAAC,CAAC,IAAI;QACN,CAAC,CAAC,IAAI,CAAC;AACX,CAAC;AAED,SAAS,gBAAgB,CAAC,IAAuB,EAAE,OAAoB;IACrE,MAAM,MAAM,GAAG,2BAA2B,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC;IAC5D,IAAI,EAAE,CAAC,YAAY,CAAC,MAAM,CAAC,EAAE,CAAC;QAC5B,OAAO,OAAO,CAAC,eAAe,CAAC,GAAG,CAAC,MAAM,CAAC,IAAI,CAAC,IAAI,IAAI,CAAC;IAC1D,CAAC;IACD,IACE,CAAC,EAAE,CAAC,0BAA0B,CAAC,MAAM,CAAC;QACtC,CAAC,EAAE,CAAC,YAAY,CAAC,MAAM,CAAC,UAAU,CAAC;QACnC,CAAC,SAAS,CAAC,GAAG,CAAC,MAAM,CAAC,IAAI,CAAC,IAAI,CAAC,EAChC,CAAC;QACD,OAAO,IAAI,CAAC;IACd,CAAC;IACD,MAAM,SAAS,GAAG,MAAM,CAAC,UAAU,CAAC,IAAI,CAAC;IACzC,MAAM,IAAI,GAAG,MAAM,CAAC,IAAI,CAAC,IAAI,CAAC,UAAU,CAAC,KAAK,CAAC,CAAC;IAChD,MAAM,UAAU,GAAG,IAAI,CAAC,CAAC,CAAC,OAAO,CAAC,qBAAqB,CAAC,CAAC,CAAC,OAAO,CAAC,gBAAgB,CAAC;IACnF,OAAO,UAAU,CAAC,GAAG,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC,iBAAiB,CAAC,MAAM,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC;AAChF,CAAC;AAED,SAAS,iBAAiB,CAAC,IAAY;IACrC,OAAO,IAAI,KAAK,SAAS;QACvB,IAAI,KAAK,YAAY;QACrB,IAAI,KAAK,kBAAkB;QAC3B,IAAI,KAAK,SAAS;QAClB,IAAI,KAAK,cAAc;QACvB,IAAI,KAAK,MAAM;QACf,IAAI,KAAK,WAAW;QACpB,CAAC,CAAC,IAAI;QACN,CAAC,CAAC,IAAI,CAAC;AACX,CAAC;AAED,SAAS,iBAAiB,CAAC,GAAW,EAAE,IAAkB;IACxD,MAAM,EAAE,OAAO,EAAE,GAAG,GAAG,CAAC;IACxB,IAAI,EAAE,CAAC,YAAY,CAAC,OAAO,CAAC,EAAE,CAAC;QAC7B,OAAO,CACL,IAAI,CAAC,OAAO,CAAC,aAAa,CAAC,GAAG,CAAC,OAAO,CAAC,IAAI,CAAC,IAAI,sBAAsB,CAAC,IAAI,CAAC,CAAC,GAAG,CAAC,OAAO,CAAC,IAAI,CAAC,CAC/F,CAAC;IACJ,CAAC;IACD,OAAO,CACL,EAAE,CAAC,0BAA0B,CAAC,OAAO,CAAC;QACtC,EAAE,CAAC,YAAY,CAAC,OAAO,CAAC,UAAU,CAAC;QACnC,IAAI,CAAC,OAAO,CAAC,aAAa,CAAC,GAAG,CAAC,OAAO,CAAC,UAAU,CAAC,IAAI,CAAC,CACxD,CAAC;AACJ,CAAC;AAED,SAAS,sBAAsB,CAAC,IAAkB;IAChD,MAAM,MAAM,GAAG,0BAA0B,CAAC,GAAG,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC;IAC/D,IAAI,MAAM,EAAE,CAAC;QACX,OAAO,MAAM,CAAC;IAChB,CAAC;IACD,MAAM,KAAK,GAAG,IAAI,GAAG,EAAU,CAAC;IAChC,KAAK,CAAC,IAAI,CAAC,UAAU,EAAE,CAAC,IAAI,EAAE,EAAE;QAC9B,IAAI,CAAC,EAAE,CAAC,qBAAqB,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC,WAAW,EAAE,CAAC;YACxF,OAAO;QACT,CAAC;QACD,MAAM,WAAW,GAAG,2BAA2B,CAAC,IAAI,CAAC,WAAW,CAAC,CAAC;QAClE,IAAI,EAAE,CAAC,gBAAgB,CAAC,WAAW,CAAC,IAAI,qBAAqB,CAAC,WAAW,EAAE,IAAI,CAAC,OAAO,CAAC,EAAE,CAAC;YACzF,KAAK,CAAC,GAAG,CAAC,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAC5B,CAAC;IACH,CAAC,CAAC,CAAC;IACH,0BAA0B,CAAC,GAAG,CAAC,IAAI,CAAC,UAAU,EAAE,KAAK,CAAC,CAAC;IACvD,OAAO,KAAK,CAAC;AACf,CAAC;AAED,SAAS,qBAAqB,CAAC,IAAuB,EAAE,OAAoB;IAC1E,MAAM,MAAM,GAAG,2BAA2B,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC;IAC5D,IAAI,EAAE,CAAC,YAAY,CAAC,MAAM,CAAC,EAAE,CAAC;QAC5B,OAAO,OAAO,CAAC,iBAAiB,CAAC,GAAG,CAAC,MAAM,CAAC,IAAI,CAAC,IAAI,OAAO,CAAC,eAAe,CAAC,GAAG,CAAC,MAAM,CAAC,IAAI,CAAC,CAAC;IAChG,CAAC;IACD,OAAO,CACL,EAAE,CAAC,0BAA0B,CAAC,MAAM,CAAC;QACrC,EAAE,CAAC,YAAY,CAAC,MAAM,CAAC,UAAU,CAAC;QAClC,OAAO,CAAC,qBAAqB,CAAC,GAAG,CAAC,MAAM,CAAC,UAAU,CAAC,IAAI,CAAC;QACzD,CAAC,MAAM,CAAC,IAAI,CAAC,IAAI,KAAK,UAAU,IAAI,MAAM,CAAC,IAAI,CAAC,IAAI,KAAK,kBAAkB,CAAC,CAC7E,CAAC;AACJ,CAAC;AAED,MAAM,UAAU,yBAAyB,CACvC,KAAyB,EACzB,IAAkB;IAElB,MAAM,EAAE,IAAI,EAAE,WAAW,EAAE,UAAU,EAAE,IAAI,EAAE,GAAG,KAAK,CAAC;IACtD,MAAM,EAAE,IAAI,EAAE,SAAS,EAAE,GAAG,IAAI,CAAC,UAAU,CAAC,6BAA6B,CACvE,IAAI,CAAC,QAAQ,CAAC,IAAI,CAAC,UAAU,CAAC,CAC/B,CAAC;IACF,MAAM,IAAI,GAAG,IAAI,CAAC,OAAO,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC;IAC3C,MAAM,IAAI,GAAG,UAAU,CAAC,OAAO,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC;IACjD,OAAO;QACL,MAAM,EAAE,mCAAmC;QAC3C,UAAU,EAAE,SAAS;QACrB,WAAW,EAAE,QAAQ;QACrB,QAAQ,EAAE;YACR,GAAG,IAAI,qCAAqC;YAC5C,GAAG,IAAI,qEAAqE;YAC5E,yEAAyE;SAC1E;QACD,QAAQ,EAAE,EAAE,MAAM,EAAE,SAAS,GAAG,CAAC,EAAE,IAAI,EAAE,IAAI,CAAC,QAAQ,EAAE,IAAI,EAAE,IAAI,GAAG,CAAC,EAAE;QACxE,OAAO,EAAE,aAAa,IAAI,aAAa,IAAI,SAAS,IAAI,KAAK,WAAW,GAAG;QAC3E,QAAQ,EAAE,YAAY;KACvB,CAAC;AACJ,CAAC"}

package/dist/src/rules/observable-tracking/render-owners.d.ts

@@ -0,0 +1,20 @@
+import type { HookImports } from "../../core/imports.js";
+import ts from "typescript";
+export type RenderFunction = ts.ArrowFunction | ts.FunctionDeclaration | ts.FunctionExpression;
+export interface RenderOwner {
+    /** Synchronous iteration callbacks between the node and the render function's own body. */
+    readonly hops: number;
+    readonly kind: "component" | "hook";
+    readonly name: string;
+    readonly owner: RenderFunction;
+    /** `observer` or `reactiveObserver` wraps the component, so `get()` calls in its render track. */
+    readonly tracked: boolean;
+}
+/**
+ * Resolves the component or custom hook whose render executes `node`. A node inside a nested
+ * function counts only when that function is the callback of a synchronous array iteration
+ * method whose call is itself render-executed; every other nested function (handlers, effects,
+ * selectors, reactive children) has its own execution context and returns null.
+ */
+export declare function renderOwnerOf(node: ts.Node, imports: HookImports): RenderOwner | null;
+//# sourceMappingURL=render-owners.d.ts.map

package/dist/src/rules/observable-tracking/render-owners.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"render-owners.d.ts","sourceRoot":"","sources":["../../../../src/rules/observable-tracking/render-owners.ts"],"names":[],"mappings":"AACA,OAAO,KAAK,EAAE,WAAW,EAAE,MAAM,uBAAuB,CAAC;AAGzD,OAAO,EAAE,MAAM,YAAY,CAAC;AAG5B,MAAM,MAAM,cAAc,GAAG,EAAE,CAAC,aAAa,GAAG,EAAE,CAAC,mBAAmB,GAAG,EAAE,CAAC,kBAAkB,CAAC;AAE/F,MAAM,WAAW,WAAW;IAC1B,2FAA2F;IAC3F,QAAQ,CAAC,IAAI,EAAE,MAAM,CAAC;IACtB,QAAQ,CAAC,IAAI,EAAE,WAAW,GAAG,MAAM,CAAC;IACpC,QAAQ,CAAC,IAAI,EAAE,MAAM,CAAC;IACtB,QAAQ,CAAC,KAAK,EAAE,cAAc,CAAC;IAC/B,kGAAkG;IAClG,QAAQ,CAAC,OAAO,EAAE,OAAO,CAAC;CAC3B;AA4BD;;;;;GAKG;AACH,wBAAgB,aAAa,CAAC,IAAI,EAAE,EAAE,CAAC,IAAI,EAAE,OAAO,EAAE,WAAW,GAAG,WAAW,GAAG,IAAI,CAErF"}

package/dist/src/rules/observable-tracking/render-owners.js

@@ -0,0 +1,152 @@
+import { findAncestor, isRuntimeFunctionLike, visit } from "../../core/ast.js";
+import { jsxElementCount } from "../state-proofs/jsx-subtrees.js";
+import ts from "typescript";
+import { unwrapTransparentExpression } from "../../core/analysis-ast.js";
+const SYNC_ITERATION_METHODS = new Set([
+    "every",
+    "filter",
+    "find",
+    "findIndex",
+    "findLast",
+    "findLastIndex",
+    "flatMap",
+    "forEach",
+    "map",
+    "reduce",
+    "reduceRight",
+    "some",
+    "sort",
+    "toSorted",
+]);
+const OBSERVER_FACTORIES = new Set(["observer", "reactiveObserver"]);
+const observedFunctionsBySource = new WeakMap();
+/**
+ * Resolves the component or custom hook whose render executes `node`. A node inside a nested
+ * function counts only when that function is the callback of a synchronous array iteration
+ * method whose call is itself render-executed; every other nested function (handlers, effects,
+ * selectors, reactive children) has its own execution context and returns null.
+ */
+export function renderOwnerOf(node, imports) {
+    return resolveRenderOwner(node, imports, 0);
+}
+function resolveRenderOwner(node, imports, hops) {
+    const enclosing = findAncestor(node, isRuntimeFunctionLike);
+    if (!enclosing) {
+        return null;
+    }
+    const owner = classifyRenderFunction(enclosing, imports);
+    if (owner) {
+        return { ...owner, hops };
+    }
+    const iteration = renderIterationCall(enclosing);
+    return iteration ? resolveRenderOwner(iteration, imports, hops + 1) : null;
+}
+function renderIterationCall(callback) {
+    if (!ts.isArrowFunction(callback) && !ts.isFunctionExpression(callback)) {
+        return null;
+    }
+    let current = callback;
+    while (ts.isParenthesizedExpression(current.parent)) {
+        current = current.parent;
+    }
+    const call = current.parent;
+    if (!ts.isCallExpression(call) || call.arguments[0] !== current) {
+        return null;
+    }
+    const callee = unwrapTransparentExpression(call.expression);
+    return ts.isPropertyAccessExpression(callee) && SYNC_ITERATION_METHODS.has(callee.name.text)
+        ? call
+        : null;
+}
+function classifyRenderFunction(candidate, imports) {
+    if (!ts.isArrowFunction(candidate) &&
+        !ts.isFunctionDeclaration(candidate) &&
+        !ts.isFunctionExpression(candidate)) {
+        return null;
+    }
+    const name = renderFunctionName(candidate);
+    if (name === null) {
+        return null;
+    }
+    if (/^use[A-Z0-9]/u.test(name)) {
+        return { kind: "hook", name, owner: candidate, tracked: false };
+    }
+    return /^[A-Z]/u.test(name) && jsxElementCount(candidate) > 0
+        ? componentOwner(candidate, name, imports)
+        : null;
+}
+function componentOwner(candidate, name, imports) {
+    const observed = observedFunctions(candidate.getSourceFile(), imports);
+    return {
+        kind: "component",
+        name,
+        owner: candidate,
+        tracked: observed.nodes.has(candidate) || observed.names.has(name),
+    };
+}
+function renderFunctionName(candidate) {
+    if (candidate.name && ts.isIdentifier(candidate.name)) {
+        return candidate.name.text;
+    }
+    if (ts.isFunctionDeclaration(candidate)) {
+        return null;
+    }
+    return declaredName(candidate);
+}
+/** The variable an expression is assigned to, looking through parentheses and wrapper calls. */
+function declaredName(expression) {
+    const { parent } = expression;
+    if (ts.isParenthesizedExpression(parent) ||
+        (ts.isCallExpression(parent) && parent.arguments.includes(expression))) {
+        return declaredName(parent);
+    }
+    return ts.isVariableDeclaration(parent) && ts.isIdentifier(parent.name) ? parent.name.text : null;
+}
+function observedFunctions(sourceFile, imports) {
+    const cached = observedFunctionsBySource.get(sourceFile);
+    if (cached) {
+        return cached;
+    }
+    const names = new Set();
+    const nodes = new Set();
+    visit(sourceFile, (node) => {
+        if (!ts.isCallExpression(node) || !isObserverFactoryCall(node, imports)) {
+            return;
+        }
+        const wrapped = innermostWrappedArgument(node);
+        if (!wrapped) {
+            return;
+        }
+        if (ts.isIdentifier(wrapped)) {
+            names.add(wrapped.text);
+        }
+        else if (isRuntimeFunctionLike(wrapped)) {
+            nodes.add(wrapped);
+        }
+    });
+    const observed = { names, nodes };
+    observedFunctionsBySource.set(sourceFile, observed);
+    return observed;
+}
+function isObserverFactoryCall(call, imports) {
+    const callee = unwrapTransparentExpression(call.expression);
+    if (ts.isIdentifier(callee)) {
+        return imports.legendObservers.has(callee.text);
+    }
+    return (ts.isPropertyAccessExpression(callee) &&
+        ts.isIdentifier(callee.expression) &&
+        imports.legendReactNamespaces.has(callee.expression.text) &&
+        OBSERVER_FACTORIES.has(callee.name.text));
+}
+function innermostWrappedArgument(call) {
+    let [current] = call.arguments;
+    while (current) {
+        const value = unwrapTransparentExpression(current);
+        if (!ts.isCallExpression(value)) {
+            return value;
+        }
+        [current] = value.arguments;
+    }
+    return null;
+}
+//# sourceMappingURL=render-owners.js.map

package/dist/src/rules/observable-tracking/render-owners.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"render-owners.js","sourceRoot":"","sources":["../../../../src/rules/observable-tracking/render-owners.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,YAAY,EAAE,qBAAqB,EAAE,KAAK,EAAE,MAAM,mBAAmB,CAAC;AAG/E,OAAO,EAAE,eAAe,EAAE,MAAM,iCAAiC,CAAC;AAClE,OAAO,EAAE,MAAM,YAAY,CAAC;AAC5B,OAAO,EAAE,2BAA2B,EAAE,MAAM,4BAA4B,CAAC;AAmBzE,MAAM,sBAAsB,GAAG,IAAI,GAAG,CAAC;IACrC,OAAO;IACP,QAAQ;IACR,MAAM;IACN,WAAW;IACX,UAAU;IACV,eAAe;IACf,SAAS;IACT,SAAS;IACT,KAAK;IACL,QAAQ;IACR,aAAa;IACb,MAAM;IACN,MAAM;IACN,UAAU;CACX,CAAC,CAAC;AAEH,MAAM,kBAAkB,GAAG,IAAI,GAAG,CAAC,CAAC,UAAU,EAAE,kBAAkB,CAAC,CAAC,CAAC;AAErE,MAAM,yBAAyB,GAAG,IAAI,OAAO,EAAoC,CAAC;AAElF;;;;;GAKG;AACH,MAAM,UAAU,aAAa,CAAC,IAAa,EAAE,OAAoB;IAC/D,OAAO,kBAAkB,CAAC,IAAI,EAAE,OAAO,EAAE,CAAC,CAAC,CAAC;AAC9C,CAAC;AAED,SAAS,kBAAkB,CAAC,IAAa,EAAE,OAAoB,EAAE,IAAY;IAC3E,MAAM,SAAS,GAAG,YAAY,CAAC,IAAI,EAAE,qBAAqB,CAAC,CAAC;IAC5D,IAAI,CAAC,SAAS,EAAE,CAAC;QACf,OAAO,IAAI,CAAC;IACd,CAAC;IACD,MAAM,KAAK,GAAG,sBAAsB,CAAC,SAAS,EAAE,OAAO,CAAC,CAAC;IACzD,IAAI,KAAK,EAAE,CAAC;QACV,OAAO,EAAE,GAAG,KAAK,EAAE,IAAI,EAAE,CAAC;IAC5B,CAAC;IACD,MAAM,SAAS,GAAG,mBAAmB,CAAC,SAAS,CAAC,CAAC;IACjD,OAAO,SAAS,CAAC,CAAC,CAAC,kBAAkB,CAAC,SAAS,EAAE,OAAO,EAAE,IAAI,GAAG,CAAC,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC;AAC7E,CAAC;AAED,SAAS,mBAAmB,CAAC,QAA6B;IACxD,IAAI,CAAC,EAAE,CAAC,eAAe,CAAC,QAAQ,CAAC,IAAI,CAAC,EAAE,CAAC,oBAAoB,CAAC,QAAQ,CAAC,EAAE,CAAC;QACxE,OAAO,IAAI,CAAC;IACd,CAAC;IACD,IAAI,OAAO,GAAY,QAAQ,CAAC;IAChC,OAAO,EAAE,CAAC,yBAAyB,CAAC,OAAO,CAAC,MAAM,CAAC,EAAE,CAAC;QACpD,OAAO,GAAG,OAAO,CAAC,MAAM,CAAC;IAC3B,CAAC;IACD,MAAM,IAAI,GAAG,OAAO,CAAC,MAAM,CAAC;IAC5B,IAAI,CAAC,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC,IAAI,IAAI,CAAC,SAAS,CAAC,CAAC,CAAC,KAAK,OAAO,EAAE,CAAC;QAChE,OAAO,IAAI,CAAC;IACd,CAAC;IACD,MAAM,MAAM,GAAG,2BAA2B,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC;IAC5D,OAAO,EAAE,CAAC,0BAA0B,CAAC,MAAM,CAAC,IAAI,sBAAsB,CAAC,GAAG,CAAC,MAAM,CAAC,IAAI,CAAC,IAAI,CAAC;QAC1F,CAAC,CAAC,IAAI;QACN,CAAC,CAAC,IAAI,CAAC;AACX,CAAC;AAED,SAAS,sBAAsB,CAC7B,SAA8B,EAC9B,OAAoB;IAEpB,IACE,CAAC,EAAE,CAAC,eAAe,CAAC,SAAS,CAAC;QAC9B,CAAC,EAAE,CAAC,qBAAqB,CAAC,SAAS,CAAC;QACpC,CAAC,EAAE,CAAC,oBAAoB,CAAC,SAAS,CAAC,EACnC,CAAC;QACD,OAAO,IAAI,CAAC;IACd,CAAC;IACD,MAAM,IAAI,GAAG,kBAAkB,CAAC,SAAS,CAAC,CAAC;IAC3C,IAAI,IAAI,KAAK,IAAI,EAAE,CAAC;QAClB,OAAO,IAAI,CAAC;IACd,CAAC;IACD,IAAI,eAAe,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE,CAAC;QAC/B,OAAO,EAAE,IAAI,EAAE,MAAM,EAAE,IAAI,EAAE,KAAK,EAAE,SAAS,EAAE,OAAO,EAAE,KAAK,EAAE,CAAC;IAClE,CAAC;IACD,OAAO,SAAS,CAAC,IAAI,CAAC,IAAI,CAAC,IAAI,eAAe,CAAC,SAAS,CAAC,GAAG,CAAC;QAC3D,CAAC,CAAC,cAAc,CAAC,SAAS,EAAE,IAAI,EAAE,OAAO,CAAC;QAC1C,CAAC,CAAC,IAAI,CAAC;AACX,CAAC;AAED,SAAS,cAAc,CACrB,SAAyB,EACzB,IAAY,EACZ,OAAoB;IAEpB,MAAM,QAAQ,GAAG,iBAAiB,CAAC,SAAS,CAAC,aAAa,EAAE,EAAE,OAAO,CAAC,CAAC;IACvE,OAAO;QACL,IAAI,EAAE,WAAW;QACjB,IAAI;QACJ,KAAK,EAAE,SAAS;QAChB,OAAO,EAAE,QAAQ,CAAC,KAAK,CAAC,GAAG,CAAC,SAAS,CAAC,IAAI,QAAQ,CAAC,KAAK,CAAC,GAAG,CAAC,IAAI,CAAC;KACnE,CAAC;AACJ,CAAC;AAED,SAAS,kBAAkB,CAAC,SAAyB;IACnD,IAAI,SAAS,CAAC,IAAI,IAAI,EAAE,CAAC,YAAY,CAAC,SAAS,CAAC,IAAI,CAAC,EAAE,CAAC;QACtD,OAAO,SAAS,CAAC,IAAI,CAAC,IAAI,CAAC;IAC7B,CAAC;IACD,IAAI,EAAE,CAAC,qBAAqB,CAAC,SAAS,CAAC,EAAE,CAAC;QACxC,OAAO,IAAI,CAAC;IACd,CAAC;IACD,OAAO,YAAY,CAAC,SAAS,CAAC,CAAC;AACjC,CAAC;AAED,gGAAgG;AAChG,SAAS,YAAY,CAAC,UAAyB;IAC7C,MAAM,EAAE,MAAM,EAAE,GAAG,UAAU,CAAC;IAC9B,IACE,EAAE,CAAC,yBAAyB,CAAC,MAAM,CAAC;QACpC,CAAC,EAAE,CAAC,gBAAgB,CAAC,MAAM,CAAC,IAAI,MAAM,CAAC,SAAS,CAAC,QAAQ,CAAC,UAAU,CAAC,CAAC,EACtE,CAAC;QACD,OAAO,YAAY,CAAC,MAAM,CAAC,CAAC;IAC9B,CAAC;IACD,OAAO,EAAE,CAAC,qBAAqB,CAAC,MAAM,CAAC,IAAI,EAAE,CAAC,YAAY,CAAC,MAAM,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,MAAM,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC,IAAI,CAAC;AACpG,CAAC;AAED,SAAS,iBAAiB,CAAC,UAAyB,EAAE,OAAoB;IACxE,MAAM,MAAM,GAAG,yBAAyB,CAAC,GAAG,CAAC,UAAU,CAAC,CAAC;IACzD,IAAI,MAAM,EAAE,CAAC;QACX,OAAO,MAAM,CAAC;IAChB,CAAC;IACD,MAAM,KAAK,GAAG,IAAI,GAAG,EAAU,CAAC;IAChC,MAAM,KAAK,GAAG,IAAI,GAAG,EAAW,CAAC;IACjC,KAAK,CAAC,UAAU,EAAE,CAAC,IAAI,EAAE,EAAE;QACzB,IAAI,CAAC,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC,IAAI,CAAC,qBAAqB,CAAC,IAAI,EAAE,OAAO,CAAC,EAAE,CAAC;YACxE,OAAO;QACT,CAAC;QACD,MAAM,OAAO,GAAG,wBAAwB,CAAC,IAAI,CAAC,CAAC;QAC/C,IAAI,CAAC,OAAO,EAAE,CAAC;YACb,OAAO;QACT,CAAC;QACD,IAAI,EAAE,CAAC,YAAY,CAAC,OAAO,CAAC,EAAE,CAAC;YAC7B,KAAK,CAAC,GAAG,CAAC,OAAO,CAAC,IAAI,CAAC,CAAC;QAC1B,CAAC;aAAM,IAAI,qBAAqB,CAAC,OAAO,CAAC,EAAE,CAAC;YAC1C,KAAK,CAAC,GAAG,CAAC,OAAO,CAAC,CAAC;QACrB,CAAC;IACH,CAAC,CAAC,CAAC;IACH,MAAM,QAAQ,GAAG,EAAE,KAAK,EAAE,KAAK,EAAE,CAAC;IAClC,yBAAyB,CAAC,GAAG,CAAC,UAAU,EAAE,QAAQ,CAAC,CAAC;IACpD,OAAO,QAAQ,CAAC;AAClB,CAAC;AAED,SAAS,qBAAqB,CAAC,IAAuB,EAAE,OAAoB;IAC1E,MAAM,MAAM,GAAG,2BAA2B,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC;IAC5D,IAAI,EAAE,CAAC,YAAY,CAAC,MAAM,CAAC,EAAE,CAAC;QAC5B,OAAO,OAAO,CAAC,eAAe,CAAC,GAAG,CAAC,MAAM,CAAC,IAAI,CAAC,CAAC;IAClD,CAAC;IACD,OAAO,CACL,EAAE,CAAC,0BAA0B,CAAC,MAAM,CAAC;QACrC,EAAE,CAAC,YAAY,CAAC,MAAM,CAAC,UAAU,CAAC;QAClC,OAAO,CAAC,qBAAqB,CAAC,GAAG,CAAC,MAAM,CAAC,UAAU,CAAC,IAAI,CAAC;QACzD,kBAAkB,CAAC,GAAG,CAAC,MAAM,CAAC,IAAI,CAAC,IAAI,CAAC,CACzC,CAAC;AACJ,CAAC;AAED,SAAS,wBAAwB,CAAC,IAAuB;IACvD,IAAI,CAAC,OAAO,CAAC,GAAG,IAAI,CAAC,SAAS,CAAC;IAC/B,OAAO,OAAO,EAAE,CAAC;QACf,MAAM,KAAK,GAAkB,2BAA2B,CAAC,OAAO,CAAC,CAAC;QAClE,IAAI,CAAC,EAAE,CAAC,gBAAgB,CAAC,KAAK,CAAC,EAAE,CAAC;YAChC,OAAO,KAAK,CAAC;QACf,CAAC;QACD,CAAC,OAAO,CAAC,GAAG,KAAK,CAAC,SAAS,CAAC;IAC9B,CAAC;IACD,OAAO,IAAI,CAAC;AACd,CAAC"}

package/dist/src/rules/observable-tracking/render-reads.d.ts

@@ -0,0 +1,12 @@
+import type { LegendPracticeFinding } from "../../core/types.js";
+import type { TrackingScan } from "./model.js";
+import ts from "typescript";
+/**
+ * A `get()` on a proven observable path that executes during a component's or custom hook's
+ * render without any tracking context. Nothing subscribes, so the value is read once per render
+ * and the owner never re-renders when it changes. Reads that another rule owns (eager reactive
+ * inputs, `useValue` arguments), reads handed to hooks as snapshots, `key` attributes, observer
+ * components, and paths already covered by a `useValue` in the same owner are left alone.
+ */
+export declare function renderReadFinding(call: ts.CallExpression, scan: TrackingScan): LegendPracticeFinding | null;
+//# sourceMappingURL=render-reads.d.ts.map

package/dist/src/rules/observable-tracking/render-reads.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"render-reads.d.ts","sourceRoot":"","sources":["../../../../src/rules/observable-tracking/render-reads.ts"],"names":[],"mappings":"AAYA,OAAO,KAAK,EAAE,qBAAqB,EAAE,MAAM,qBAAqB,CAAC;AAEjE,OAAO,KAAK,EAAE,YAAY,EAAE,MAAM,YAAY,CAAC;AAI/C,OAAO,EAAE,MAAM,YAAY,CAAC;AAS5B;;;;;;GAMG;AACH,wBAAgB,iBAAiB,CAC/B,IAAI,EAAE,EAAE,CAAC,cAAc,EACvB,IAAI,EAAE,YAAY,GACjB,qBAAqB,GAAG,IAAI,CAG9B"}

package/dist/src/rules/observable-tracking/render-reads.js

@@ -0,0 +1,99 @@
+import { bindingDeclarationCount, hookCallName, staticPropertyPath, } from "../../core/analysis-ast.js";
+import { directGetReceiver, isTrackingHookCall, outermostTransparentParent, provenObservablePath, } from "../observable-reads/observable-paths.js";
+import { eagerReactiveInput } from "./reactive-inputs.js";
+import { hasCoveringSubscription } from "./subscription-coverage.js";
+import { renderOwnerOf } from "./render-owners.js";
+import ts from "typescript";
+/**
+ * A `get()` on a proven observable path that executes during a component's or custom hook's
+ * render without any tracking context. Nothing subscribes, so the value is read once per render
+ * and the owner never re-renders when it changes. Reads that another rule owns (eager reactive
+ * inputs, `useValue` arguments), reads handed to hooks as snapshots, `key` attributes, observer
+ * components, and paths already covered by a `useValue` in the same owner are left alone.
+ */
+export function renderReadFinding(call, scan) {
+    const read = untrackedRenderRead(call, scan);
+    return read ? renderReadPractice(read, scan) : null;
+}
+function untrackedRenderRead(call, scan) {
+    const receiver = directGetReceiver(call);
+    const observable = receiver && provenObservablePath(receiver, scan.observableBindings);
+    const path = observable && staticPropertyPath(observable);
+    if (!observable ||
+        !path ||
+        eagerReactiveInput(call, scan) ||
+        isSnapshotPosition(call, scan.imports)) {
+        return null;
+    }
+    const owner = renderOwnerOf(call, scan.imports);
+    if (!owner || owner.tracked || hasCoveringSubscription(owner.owner, path, scan)) {
+        return null;
+    }
+    return { call, observable, owner, path };
+}
+/**
+ * Hook arguments are evaluated once per render on purpose (`useState(x$.get())` seeds state),
+ * tracking hooks own their own input rule, and `key` reads are intentionally non-reactive.
+ */
+function isSnapshotPosition(call, imports) {
+    const outer = outermostTransparentParent(call);
+    const { parent } = outer;
+    if (ts.isCallExpression(parent) && parent.arguments.includes(outer)) {
+        const hook = hookCallName(parent);
+        return (isTrackingHookCall(parent, imports) ||
+            (hook !== null && (/^use[A-Z0-9$]/u.test(hook) || isAliasedReactHook(hook, imports))));
+    }
+    return (ts.isJsxExpression(parent) &&
+        ts.isJsxAttribute(parent.parent) &&
+        parent.parent.name.getText() === "key");
+}
+function isAliasedReactHook(name, imports) {
+    return (imports.useState.has(name) ||
+        imports.useRef.has(name) ||
+        imports.useMemo.has(name) ||
+        imports.useCallback.has(name) ||
+        imports.useObservable.has(name));
+}
+function isDirectRenderInitializer(read) {
+    const declaration = outermostTransparentParent(read.call).parent;
+    if (read.owner.hops > 0 ||
+        !ts.isVariableDeclaration(declaration) ||
+        !ts.isIdentifier(declaration.name) ||
+        !ts.isVariableDeclarationList(declaration.parent) ||
+        !ts.isVariableStatement(declaration.parent.parent)) {
+        return false;
+    }
+    return declaration.parent.parent.parent === read.owner.owner.body;
+}
+function suggestedBindingName(read) {
+    const last = read.path.at(-1) ?? "value";
+    const base = last.replace(/\$+$/u, "") || "value";
+    const name = base.charAt(0).toLowerCase() + base.slice(1);
+    return bindingDeclarationCount(read.owner.owner, name) === 0 ? name : `${name}Value`;
+}
+function renderReadPractice(read, scan) {
+    const { call, observable, owner } = read;
+    const { line, character } = scan.sourceFile.getLineAndCharacterOfPosition(call.getStart(scan.sourceFile));
+    const path = observable.getText(scan.sourceFile);
+    const subject = owner.kind === "component" ? `\`${owner.name}\`` : `components calling \`${owner.name}\``;
+    const consequence = `the read runs in \`${owner.name}\` outside a tracking context (useValue, observer, or a reactive component), so ${subject} never re-render${owner.kind === "component" ? "s" : ""} when \`${path}\` changes`;
+    const instruction = isDirectRenderInitializer(read)
+        ? `Replace \`${path}.get()\` with \`useValue(${path})\``
+        : `Subscribe with \`const ${suggestedBindingName(read)} = useValue(${path})\` at the top of \`${owner.name}\` and read \`${suggestedBindingName(read)}\` here`;
+    return {
+        action: "use-value-for-render-read",
+        confidence: "certain",
+        disposition: "change",
+        evidence: [
+            `${path}.get() reads a proven Legend observable path`,
+            owner.hops === 0
+                ? `the call executes directly in the render body of ${owner.kind} \`${owner.name}\``
+                : `the call executes in a synchronous iteration callback of ${owner.kind} \`${owner.name}\`'s render`,
+            `no useValue in \`${owner.name}\` subscribes to \`${path}\` or a parent path, and the component is not wrapped in observer`,
+        ],
+        location: { column: character + 1, file: scan.fileName, line: line + 1 },
+        message: `${instruction}; ${consequence}.`,
+        practice: "reactivity",
+    };
+}
+//# sourceMappingURL=render-reads.js.map

package/dist/src/rules/observable-tracking/render-reads.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"render-reads.js","sourceRoot":"","sources":["../../../../src/rules/observable-tracking/render-reads.ts"],"names":[],"mappings":"AAAA,OAAO,EACL,uBAAuB,EACvB,YAAY,EACZ,kBAAkB,GACnB,MAAM,4BAA4B,CAAC;AACpC,OAAO,EACL,iBAAiB,EACjB,kBAAkB,EAClB,0BAA0B,EAC1B,oBAAoB,GACrB,MAAM,yCAAyC,CAAC;AAKjD,OAAO,EAAE,kBAAkB,EAAE,MAAM,sBAAsB,CAAC;AAC1D,OAAO,EAAE,uBAAuB,EAAE,MAAM,4BAA4B,CAAC;AACrE,OAAO,EAAE,aAAa,EAAE,MAAM,oBAAoB,CAAC;AACnD,OAAO,EAAE,MAAM,YAAY,CAAC;AAS5B;;;;;;GAMG;AACH,MAAM,UAAU,iBAAiB,CAC/B,IAAuB,EACvB,IAAkB;IAElB,MAAM,IAAI,GAAG,mBAAmB,CAAC,IAAI,EAAE,IAAI,CAAC,CAAC;IAC7C,OAAO,IAAI,CAAC,CAAC,CAAC,kBAAkB,CAAC,IAAI,EAAE,IAAI,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC;AACtD,CAAC;AAED,SAAS,mBAAmB,CAAC,IAAuB,EAAE,IAAkB;IACtE,MAAM,QAAQ,GAAG,iBAAiB,CAAC,IAAI,CAAC,CAAC;IACzC,MAAM,UAAU,GAAG,QAAQ,IAAI,oBAAoB,CAAC,QAAQ,EAAE,IAAI,CAAC,kBAAkB,CAAC,CAAC;IACvF,MAAM,IAAI,GAAG,UAAU,IAAI,kBAAkB,CAAC,UAAU,CAAC,CAAC;IAC1D,IACE,CAAC,UAAU;QACX,CAAC,IAAI;QACL,kBAAkB,CAAC,IAAI,EAAE,IAAI,CAAC;QAC9B,kBAAkB,CAAC,IAAI,EAAE,IAAI,CAAC,OAAO,CAAC,EACtC,CAAC;QACD,OAAO,IAAI,CAAC;IACd,CAAC;IACD,MAAM,KAAK,GAAG,aAAa,CAAC,IAAI,EAAE,IAAI,CAAC,OAAO,CAAC,CAAC;IAChD,IAAI,CAAC,KAAK,IAAI,KAAK,CAAC,OAAO,IAAI,uBAAuB,CAAC,KAAK,CAAC,KAAK,EAAE,IAAI,EAAE,IAAI,CAAC,EAAE,CAAC;QAChF,OAAO,IAAI,CAAC;IACd,CAAC;IACD,OAAO,EAAE,IAAI,EAAE,UAAU,EAAE,KAAK,EAAE,IAAI,EAAE,CAAC;AAC3C,CAAC;AAED;;;GAGG;AACH,SAAS,kBAAkB,CAAC,IAAuB,EAAE,OAAoB;IACvE,MAAM,KAAK,GAAG,0BAA0B,CAAC,IAAI,CAAC,CAAC;IAC/C,MAAM,EAAE,MAAM,EAAE,GAAG,KAAK,CAAC;IACzB,IAAI,EAAE,CAAC,gBAAgB,CAAC,MAAM,CAAC,IAAI,MAAM,CAAC,SAAS,CAAC,QAAQ,CAAC,KAAK,CAAC,EAAE,CAAC;QACpE,MAAM,IAAI,GAAG,YAAY,CAAC,MAAM,CAAC,CAAC;QAClC,OAAO,CACL,kBAAkB,CAAC,MAAM,EAAE,OAAO,CAAC;YACnC,CAAC,IAAI,KAAK,IAAI,IAAI,CAAC,gBAAgB,CAAC,IAAI,CAAC,IAAI,CAAC,IAAI,kBAAkB,CAAC,IAAI,EAAE,OAAO,CAAC,CAAC,CAAC,CACtF,CAAC;IACJ,CAAC;IACD,OAAO,CACL,EAAE,CAAC,eAAe,CAAC,MAAM,CAAC;QAC1B,EAAE,CAAC,cAAc,CAAC,MAAM,CAAC,MAAM,CAAC;QAChC,MAAM,CAAC,MAAM,CAAC,IAAI,CAAC,OAAO,EAAE,KAAK,KAAK,CACvC,CAAC;AACJ,CAAC;AAED,SAAS,kBAAkB,CAAC,IAAY,EAAE,OAAoB;IAC5D,OAAO,CACL,OAAO,CAAC,QAAQ,CAAC,GAAG,CAAC,IAAI,CAAC;QAC1B,OAAO,CAAC,MAAM,CAAC,GAAG,CAAC,IAAI,CAAC;QACxB,OAAO,CAAC,OAAO,CAAC,GAAG,CAAC,IAAI,CAAC;QACzB,OAAO,CAAC,WAAW,CAAC,GAAG,CAAC,IAAI,CAAC;QAC7B,OAAO,CAAC,aAAa,CAAC,GAAG,CAAC,IAAI,CAAC,CAChC,CAAC;AACJ,CAAC;AAED,SAAS,yBAAyB,CAAC,IAAgB;IACjD,MAAM,WAAW,GAAG,0BAA0B,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,MAAM,CAAC;IACjE,IACE,IAAI,CAAC,KAAK,CAAC,IAAI,GAAG,CAAC;QACnB,CAAC,EAAE,CAAC,qBAAqB,CAAC,WAAW,CAAC;QACtC,CAAC,EAAE,CAAC,YAAY,CAAC,WAAW,CAAC,IAAI,CAAC;QAClC,CAAC,EAAE,CAAC,yBAAyB,CAAC,WAAW,CAAC,MAAM,CAAC;QACjD,CAAC,EAAE,CAAC,mBAAmB,CAAC,WAAW,CAAC,MAAM,CAAC,MAAM,CAAC,EAClD,CAAC;QACD,OAAO,KAAK,CAAC;IACf,CAAC;IACD,OAAO,WAAW,CAAC,MAAM,CAAC,MAAM,CAAC,MAAM,KAAK,IAAI,CAAC,KAAK,CAAC,KAAK,CAAC,IAAI,CAAC;AACpE,CAAC;AAED,SAAS,oBAAoB,CAAC,IAAgB;IAC5C,MAAM,IAAI,GAAG,IAAI,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC,IAAI,OAAO,CAAC;IACzC,MAAM,IAAI,GAAG,IAAI,CAAC,OAAO,CAAC,OAAO,EAAE,EAAE,CAAC,IAAI,OAAO,CAAC;IAClD,MAAM,IAAI,GAAG,IAAI,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,WAAW,EAAE,GAAG,IAAI,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC;IAC1D,OAAO,uBAAuB,CAAC,IAAI,CAAC,KAAK,CAAC,KAAK,EAAE,IAAI,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,GAAG,IAAI,OAAO,CAAC;AACvF,CAAC;AAED,SAAS,kBAAkB,CAAC,IAAgB,EAAE,IAAkB;IAC9D,MAAM,EAAE,IAAI,EAAE,UAAU,EAAE,KAAK,EAAE,GAAG,IAAI,CAAC;IACzC,MAAM,EAAE,IAAI,EAAE,SAAS,EAAE,GAAG,IAAI,CAAC,UAAU,CAAC,6BAA6B,CACvE,IAAI,CAAC,QAAQ,CAAC,IAAI,CAAC,UAAU,CAAC,CAC/B,CAAC;IACF,MAAM,IAAI,GAAG,UAAU,CAAC,OAAO,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC;IACjD,MAAM,OAAO,GACX,KAAK,CAAC,IAAI,KAAK,WAAW,CAAC,CAAC,CAAC,KAAK,KAAK,CAAC,IAAI,IAAI,CAAC,CAAC,CAAC,wBAAwB,KAAK,CAAC,IAAI,IAAI,CAAC;IAC5F,MAAM,WAAW,GAAG,sBAAsB,KAAK,CAAC,IAAI,mFAAmF,OAAO,mBAAmB,KAAK,CAAC,IAAI,KAAK,WAAW,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,WAAW,IAAI,YAAY,CAAC;IAClO,MAAM,WAAW,GAAG,yBAAyB,CAAC,IAAI,CAAC;QACjD,CAAC,CAAC,aAAa,IAAI,4BAA4B,IAAI,KAAK;QACxD,CAAC,CAAC,0BAA0B,oBAAoB,CAAC,IAAI,CAAC,eAAe,IAAI,uBAAuB,KAAK,CAAC,IAAI,iBAAiB,oBAAoB,CAAC,IAAI,CAAC,SAAS,CAAC;IACjK,OAAO;QACL,MAAM,EAAE,2BAA2B;QACnC,UAAU,EAAE,SAAS;QACrB,WAAW,EAAE,QAAQ;QACrB,QAAQ,EAAE;YACR,GAAG,IAAI,8CAA8C;YACrD,KAAK,CAAC,IAAI,KAAK,CAAC;gBACd,CAAC,CAAC,oDAAoD,KAAK,CAAC,IAAI,MAAM,KAAK,CAAC,IAAI,IAAI;gBACpF,CAAC,CAAC,4DAA4D,KAAK,CAAC,IAAI,MAAM,KAAK,CAAC,IAAI,aAAa;YACvG,oBAAoB,KAAK,CAAC,IAAI,sBAAsB,IAAI,mEAAmE;SAC5H;QACD,QAAQ,EAAE,EAAE,MAAM,EAAE,SAAS,GAAG,CAAC,EAAE,IAAI,EAAE,IAAI,CAAC,QAAQ,EAAE,IAAI,EAAE,IAAI,GAAG,CAAC,EAAE;QACxE,OAAO,EAAE,GAAG,WAAW,KAAK,WAAW,GAAG;QAC1C,QAAQ,EAAE,YAAY;KACvB,CAAC;AACJ,CAAC"}

package/dist/src/rules/observable-tracking/subscription-coverage.d.ts

@@ -0,0 +1,11 @@
+import type { RenderFunction } from "./render-owners.js";
+import type { TrackingScan } from "./model.js";
+type ObservablePath = readonly string[];
+/**
+ * True when a `useValue` (or legacy selector hook) call in the owner's own render already
+ * subscribes to `path` or to one of its ancestors, so an untracked read of `path` still
+ * re-renders with every change it could observe.
+ */
+export declare function hasCoveringSubscription(owner: RenderFunction, path: ObservablePath, scan: TrackingScan): boolean;
+export {};
+//# sourceMappingURL=subscription-coverage.d.ts.map

package/dist/src/rules/observable-tracking/subscription-coverage.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"subscription-coverage.d.ts","sourceRoot":"","sources":["../../../../src/rules/observable-tracking/subscription-coverage.ts"],"names":[],"mappings":"AAOA,OAAO,KAAK,EAAE,cAAc,EAAE,MAAM,oBAAoB,CAAC;AACzD,OAAO,KAAK,EAAE,YAAY,EAAE,MAAM,YAAY,CAAC;AAG/C,KAAK,cAAc,GAAG,SAAS,MAAM,EAAE,CAAC;AAOxC;;;;GAIG;AACH,wBAAgB,uBAAuB,CACrC,KAAK,EAAE,cAAc,EACrB,IAAI,EAAE,cAAc,EACpB,IAAI,EAAE,YAAY,GACjB,OAAO,CAOT"}