legend-doctor 0.1.0

package/dist/src/rules/observable-ownership/nested-observable-arguments.js

@@ -0,0 +1,35 @@
+import { callLocation } from "./model.js";
+import { provenObservablePath } from "../observable-reads/observable-paths.js";
+export function nestedObservableArgumentFinding(call, factory, scan) {
+    if (call.arguments.length !== 1) {
+        return null;
+    }
+    const path = provenObservablePath(call.arguments[0], scan.observableBindings);
+    if (!path) {
+        return null;
+    }
+    const { sourceFile } = scan;
+    const callee = call.expression.getText(sourceFile);
+    const pathText = path.getText(sourceFile);
+    return {
+        action: "reuse-observable-reference",
+        confidence: "certain",
+        disposition: "change",
+        evidence: [
+            `${pathText} is a proven Legend observable path`,
+            `${callee}() returns an observable argument unchanged instead of wrapping it, so the call adds no ownership, stability, or context`,
+            ...unmountEvidence(factory, pathText),
+        ],
+        location: callLocation(call, scan),
+        message: `Replace \`${callee}(${pathText})\` with \`${pathText}\`; Legend returns the same observable, and one observable belongs inside another only as an intentional link whose reads and writes forward to the source.`,
+        practice: "ownership",
+    };
+}
+function unmountEvidence(factory, pathText) {
+    return factory === "useObservable"
+        ? [
+            `useObservable deactivates the node it returns when the component unmounts, and that node is the shared ${pathText}`,
+        ]
+        : [];
+}
+//# sourceMappingURL=nested-observable-arguments.js.map

package/dist/src/rules/observable-ownership/nested-observable-arguments.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"nested-observable-arguments.js","sourceRoot":"","sources":["../../../../src/rules/observable-ownership/nested-observable-arguments.ts"],"names":[],"mappings":"AAEA,OAAO,EAAE,YAAY,EAAE,MAAM,YAAY,CAAC;AAC1C,OAAO,EAAE,oBAAoB,EAAE,MAAM,yCAAyC,CAAC;AAG/E,MAAM,UAAU,+BAA+B,CAC7C,IAAuB,EACvB,OAAsB,EACtB,IAA6B;IAE7B,IAAI,IAAI,CAAC,SAAS,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;QAChC,OAAO,IAAI,CAAC;IACd,CAAC;IACD,MAAM,IAAI,GAAG,oBAAoB,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC,CAAE,EAAE,IAAI,CAAC,kBAAkB,CAAC,CAAC;IAC/E,IAAI,CAAC,IAAI,EAAE,CAAC;QACV,OAAO,IAAI,CAAC;IACd,CAAC;IACD,MAAM,EAAE,UAAU,EAAE,GAAG,IAAI,CAAC;IAC5B,MAAM,MAAM,GAAG,IAAI,CAAC,UAAU,CAAC,OAAO,CAAC,UAAU,CAAC,CAAC;IACnD,MAAM,QAAQ,GAAG,IAAI,CAAC,OAAO,CAAC,UAAU,CAAC,CAAC;IAC1C,OAAO;QACL,MAAM,EAAE,4BAA4B;QACpC,UAAU,EAAE,SAAS;QACrB,WAAW,EAAE,QAAQ;QACrB,QAAQ,EAAE;YACR,GAAG,QAAQ,qCAAqC;YAChD,GAAG,MAAM,0HAA0H;YACnI,GAAG,eAAe,CAAC,OAAO,EAAE,QAAQ,CAAC;SACtC;QACD,QAAQ,EAAE,YAAY,CAAC,IAAI,EAAE,IAAI,CAAC;QAClC,OAAO,EAAE,aAAa,MAAM,IAAI,QAAQ,cAAc,QAAQ,6JAA6J;QAC3N,QAAQ,EAAE,WAAW;KACtB,CAAC;AACJ,CAAC;AAED,SAAS,eAAe,CAAC,OAAsB,EAAE,QAAgB;IAC/D,OAAO,OAAO,KAAK,eAAe;QAChC,CAAC,CAAC;YACE,0GAA0G,QAAQ,EAAE;SACrH;QACH,CAAC,CAAC,EAAE,CAAC;AACT,CAAC"}

package/dist/src/rules/observable-ownership/observable-ownership.d.ts

@@ -0,0 +1,5 @@
+import type { ObservableOwnershipScan } from "./model.js";
+import type { LegendPracticeFinding } from "../../core/types.js";
+export type { ObservableOwnershipScan } from "./model.js";
+export declare function findObservableOwnershipPractices(scan: ObservableOwnershipScan): LegendPracticeFinding[];
+//# sourceMappingURL=observable-ownership.d.ts.map

package/dist/src/rules/observable-ownership/observable-ownership.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"observable-ownership.d.ts","sourceRoot":"","sources":["../../../../src/rules/observable-ownership/observable-ownership.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAiB,uBAAuB,EAAE,MAAM,YAAY,CAAC;AAIzE,OAAO,KAAK,EAAE,qBAAqB,EAAE,MAAM,qBAAqB,CAAC;AAKjE,YAAY,EAAE,uBAAuB,EAAE,MAAM,YAAY,CAAC;AAO1D,wBAAgB,gCAAgC,CAC9C,IAAI,EAAE,uBAAuB,GAC5B,qBAAqB,EAAE,CAkBzB"}

package/dist/src/rules/observable-ownership/observable-ownership.js

@@ -0,0 +1,55 @@
+import { bindingDeclarationCount, rootIdentifier } from "../../core/analysis-ast.js";
+import { findAncestor, isRuntimeFunctionLike, visit } from "../../core/ast.js";
+import { nestedObservableArgumentFinding } from "./nested-observable-arguments.js";
+import ts from "typescript";
+import { writtenComputedInitializerFinding } from "./written-computed-initializers.js";
+const NAMESPACE_FACTORIES = new Map([
+    ["observable", "observable"],
+    ["useObservable", "useObservable"],
+]);
+export function findObservableOwnershipPractices(scan) {
+    const findings = [];
+    visit(scan.sourceFile, (node) => {
+        if (!ts.isCallExpression(node)) {
+            return;
+        }
+        const factory = legendFactoryCallKind(node, scan.imports);
+        if (!factory) {
+            return;
+        }
+        const finding = nestedObservableArgumentFinding(node, factory, scan) ??
+            (factory === "useObservable" ? writtenComputedInitializerFinding(node, scan) : null);
+        if (finding) {
+            findings.push(finding);
+        }
+    });
+    return findings;
+}
+function legendFactoryCallKind(call, imports) {
+    const factory = importedFactoryKind(call.expression, imports);
+    if (!factory) {
+        return null;
+    }
+    const root = rootIdentifier(call.expression);
+    const owner = findAncestor(call, isRuntimeFunctionLike);
+    const shadowed = root !== null && owner !== null && bindingDeclarationCount(owner, root.text) > 0;
+    return shadowed ? null : factory;
+}
+function importedFactoryKind(callee, imports) {
+    if (ts.isIdentifier(callee)) {
+        return localFactoryKind(callee.text, imports);
+    }
+    if (!ts.isPropertyAccessExpression(callee) || !ts.isIdentifier(callee.expression)) {
+        return null;
+    }
+    const factory = NAMESPACE_FACTORIES.get(callee.name.text) ?? null;
+    const namespaces = factory === "observable" ? imports.legendNamespaces : imports.legendReactNamespaces;
+    return factory && namespaces.has(callee.expression.text) ? factory : null;
+}
+function localFactoryKind(name, imports) {
+    if (imports.observable.has(name)) {
+        return "observable";
+    }
+    return imports.useObservable.has(name) ? "useObservable" : null;
+}
+//# sourceMappingURL=observable-ownership.js.map

package/dist/src/rules/observable-ownership/observable-ownership.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"observable-ownership.js","sourceRoot":"","sources":["../../../../src/rules/observable-ownership/observable-ownership.ts"],"names":[],"mappings":"AACA,OAAO,EAAE,uBAAuB,EAAE,cAAc,EAAE,MAAM,4BAA4B,CAAC;AACrF,OAAO,EAAE,YAAY,EAAE,qBAAqB,EAAE,KAAK,EAAE,MAAM,mBAAmB,CAAC;AAG/E,OAAO,EAAE,+BAA+B,EAAE,MAAM,kCAAkC,CAAC;AACnF,OAAO,EAAE,MAAM,YAAY,CAAC;AAC5B,OAAO,EAAE,iCAAiC,EAAE,MAAM,oCAAoC,CAAC;AAIvF,MAAM,mBAAmB,GAAG,IAAI,GAAG,CAAwB;IACzD,CAAC,YAAY,EAAE,YAAY,CAAC;IAC5B,CAAC,eAAe,EAAE,eAAe,CAAC;CACnC,CAAC,CAAC;AAEH,MAAM,UAAU,gCAAgC,CAC9C,IAA6B;IAE7B,MAAM,QAAQ,GAA4B,EAAE,CAAC;IAC7C,KAAK,CAAC,IAAI,CAAC,UAAU,EAAE,CAAC,IAAI,EAAE,EAAE;QAC9B,IAAI,CAAC,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC,EAAE,CAAC;YAC/B,OAAO;QACT,CAAC;QACD,MAAM,OAAO,GAAG,qBAAqB,CAAC,IAAI,EAAE,IAAI,CAAC,OAAO,CAAC,CAAC;QAC1D,IAAI,CAAC,OAAO,EAAE,CAAC;YACb,OAAO;QACT,CAAC;QACD,MAAM,OAAO,GACX,+BAA+B,CAAC,IAAI,EAAE,OAAO,EAAE,IAAI,CAAC;YACpD,CAAC,OAAO,KAAK,eAAe,CAAC,CAAC,CAAC,iCAAiC,CAAC,IAAI,EAAE,IAAI,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC;QACvF,IAAI,OAAO,EAAE,CAAC;YACZ,QAAQ,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC;QACzB,CAAC;IACH,CAAC,CAAC,CAAC;IACH,OAAO,QAAQ,CAAC;AAClB,CAAC;AAED,SAAS,qBAAqB,CAC5B,IAAuB,EACvB,OAAoB;IAEpB,MAAM,OAAO,GAAG,mBAAmB,CAAC,IAAI,CAAC,UAAU,EAAE,OAAO,CAAC,CAAC;IAC9D,IAAI,CAAC,OAAO,EAAE,CAAC;QACb,OAAO,IAAI,CAAC;IACd,CAAC;IACD,MAAM,IAAI,GAAG,cAAc,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC;IAC7C,MAAM,KAAK,GAAG,YAAY,CAAC,IAAI,EAAE,qBAAqB,CAAC,CAAC;IACxD,MAAM,QAAQ,GAAG,IAAI,KAAK,IAAI,IAAI,KAAK,KAAK,IAAI,IAAI,uBAAuB,CAAC,KAAK,EAAE,IAAI,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC;IAClG,OAAO,QAAQ,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,OAAO,CAAC;AACnC,CAAC;AAED,SAAS,mBAAmB,CAAC,MAAqB,EAAE,OAAoB;IACtE,IAAI,EAAE,CAAC,YAAY,CAAC,MAAM,CAAC,EAAE,CAAC;QAC5B,OAAO,gBAAgB,CAAC,MAAM,CAAC,IAAI,EAAE,OAAO,CAAC,CAAC;IAChD,CAAC;IACD,IAAI,CAAC,EAAE,CAAC,0BAA0B,CAAC,MAAM,CAAC,IAAI,CAAC,EAAE,CAAC,YAAY,CAAC,MAAM,CAAC,UAAU,CAAC,EAAE,CAAC;QAClF,OAAO,IAAI,CAAC;IACd,CAAC;IACD,MAAM,OAAO,GAAG,mBAAmB,CAAC,GAAG,CAAC,MAAM,CAAC,IAAI,CAAC,IAAI,CAAC,IAAI,IAAI,CAAC;IAClE,MAAM,UAAU,GACd,OAAO,KAAK,YAAY,CAAC,CAAC,CAAC,OAAO,CAAC,gBAAgB,CAAC,CAAC,CAAC,OAAO,CAAC,qBAAqB,CAAC;IACtF,OAAO,OAAO,IAAI,UAAU,CAAC,GAAG,CAAC,MAAM,CAAC,UAAU,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,CAAC,IAAI,CAAC;AAC5E,CAAC;AAED,SAAS,gBAAgB,CAAC,IAAY,EAAE,OAAoB;IAC1D,IAAI,OAAO,CAAC,UAAU,CAAC,GAAG,CAAC,IAAI,CAAC,EAAE,CAAC;QACjC,OAAO,YAAY,CAAC;IACtB,CAAC;IACD,OAAO,OAAO,CAAC,aAAa,CAAC,GAAG,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,eAAe,CAAC,CAAC,CAAC,IAAI,CAAC;AAClE,CAAC"}

package/dist/src/rules/observable-ownership/written-computed-initializers.d.ts

@@ -0,0 +1,5 @@
+import type { LegendPracticeFinding } from "../../core/types.js";
+import type { ObservableOwnershipScan } from "./model.js";
+import ts from "typescript";
+export declare function writtenComputedInitializerFinding(call: ts.CallExpression, scan: ObservableOwnershipScan): LegendPracticeFinding | null;
+//# sourceMappingURL=written-computed-initializers.d.ts.map

package/dist/src/rules/observable-ownership/written-computed-initializers.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"written-computed-initializers.d.ts","sourceRoot":"","sources":["../../../../src/rules/observable-ownership/written-computed-initializers.ts"],"names":[],"mappings":"AAaA,OAAO,KAAK,EAAE,qBAAqB,EAAE,MAAM,qBAAqB,CAAC;AACjE,OAAO,KAAK,EAAE,uBAAuB,EAAE,MAAM,YAAY,CAAC;AAG1D,OAAO,EAAE,MAAM,YAAY,CAAC;AAuB5B,wBAAgB,iCAAiC,CAC/C,IAAI,EAAE,EAAE,CAAC,cAAc,EACvB,IAAI,EAAE,uBAAuB,GAC5B,qBAAqB,GAAG,IAAI,CAoB9B"}

package/dist/src/rules/observable-ownership/written-computed-initializers.js

@@ -0,0 +1,159 @@
+import { RESERVED_OBSERVABLE_MEMBERS, directObservableReadPath, outermostTransparentParent, } from "../observable-reads/observable-paths.js";
+import { bindingDeclarationCount, unwrapTransparentExpression } from "../../core/analysis-ast.js";
+import { findAncestor, isRuntimeFunctionLike, visit, visitSkippingNestedRuntimeFunctions, } from "../../core/ast.js";
+import { callLocation } from "./model.js";
+import ts from "typescript";
+const OBSERVABLE_WRITE_MEMBERS = new Set(["assign", "delete", "push", "set", "splice", "toggle"]);
+const LINK_FACTORIES = new Set(["linked", "synced"]);
+export function writtenComputedInitializerFinding(call, scan) {
+    const computed = writtenComputed(call, scan);
+    if (!computed) {
+        return null;
+    }
+    const { sourceFile } = scan;
+    const paths = [...new Set(computed.reads.map((read) => read.path.getText(sourceFile)))];
+    const writeLines = describeLines(computed.writes, sourceFile);
+    return {
+        action: "snapshot-computed-initializer",
+        confidence: "certain",
+        disposition: "change",
+        evidence: [
+            `${paths.join(", ")} is read with a tracked get() inside the useObservable initializer function, so the hook creates a computed observable`,
+            `${computed.binding.text} is written at ${writeLines}; a computed observable replaces a written value on its next recomputation`,
+        ],
+        location: callLocation(call, scan),
+        message: `${replacementInstruction(call, computed, scan)}; the function initializer creates a computed observable that recomputes from ${paths.join(" and ")} and replaces the writes at ${writeLines}. If the value is meant to stay derived, delete those writes instead.`,
+        practice: "ownership",
+    };
+}
+function replacementInstruction(call, computed, scan) {
+    const { sourceFile } = scan;
+    const callee = call.expression.getText(sourceFile);
+    const { body } = computed.initializer;
+    if (ts.isBlock(body)) {
+        return `Replace the function initializer of \`${callee}\` with a plain initial value whose observable reads use \`.peek()\``;
+    }
+    const snapshot = withPeekReads(body, computed.reads, sourceFile);
+    const current = call.arguments[0].getText(sourceFile);
+    return `Replace \`${callee}(${current})\` with \`${callee}(${snapshot})\``;
+}
+function withPeekReads(body, reads, sourceFile) {
+    const { text } = sourceFile;
+    const names = reads
+        .flatMap((read) => ts.isPropertyAccessExpression(read.call.expression) ? [read.call.expression.name] : [])
+        .toSorted((left, right) => left.getStart(sourceFile) - right.getStart(sourceFile));
+    let result = "";
+    let cursor = body.getStart(sourceFile);
+    for (const name of names) {
+        result += `${text.slice(cursor, name.getStart(sourceFile))}peek`;
+        cursor = name.getEnd();
+    }
+    return result + text.slice(cursor, body.getEnd());
+}
+function writtenComputed(call, scan) {
+    const declaration = computedDeclaration(call);
+    if (!declaration) {
+        return null;
+    }
+    const { binding, initializer, owner } = declaration;
+    const reads = trackedObservableReads(initializer.body, scan.observableBindings);
+    if (reads.length === 0 || containsLinkFactoryCall(initializer.body, scan.imports)) {
+        return null;
+    }
+    const writes = observableWritesRootedAt(owner, binding.text);
+    return writes.length > 0 ? { ...declaration, reads, writes } : null;
+}
+function computedDeclaration(call) {
+    if (call.arguments.length !== 1) {
+        return null;
+    }
+    const initializer = unwrapTransparentExpression(call.arguments[0]);
+    const binding = declaredBinding(call);
+    const owner = findAncestor(call, isRuntimeFunctionLike);
+    if (!isPlainComputeFunction(initializer) ||
+        !binding ||
+        !owner ||
+        bindingDeclarationCount(owner, binding.text) !== 1) {
+        return null;
+    }
+    return { binding, initializer, owner };
+}
+function isPlainComputeFunction(expression) {
+    if (!ts.isArrowFunction(expression) && !ts.isFunctionExpression(expression)) {
+        return false;
+    }
+    const isAsync = expression.modifiers?.some((modifier) => modifier.kind === ts.SyntaxKind.AsyncKeyword);
+    return expression.parameters.length === 0 && !isAsync && !expression.asteriskToken;
+}
+function trackedObservableReads(body, observableBindings) {
+    const reads = [];
+    visitSkippingNestedRuntimeFunctions(body, (node) => {
+        if (!ts.isCallExpression(node)) {
+            return;
+        }
+        const path = directObservableReadPath(node, observableBindings);
+        if (path) {
+            reads.push({ call: node, path });
+        }
+    });
+    return reads;
+}
+function containsLinkFactoryCall(body, imports) {
+    let found = false;
+    visit(body, (node) => {
+        if (ts.isCallExpression(node) && isLinkFactoryCallee(node.expression, imports)) {
+            found = true;
+        }
+    });
+    return found;
+}
+function isLinkFactoryCallee(callee, imports) {
+    if (ts.isIdentifier(callee)) {
+        return imports.linked.has(callee.text) || imports.synced.has(callee.text);
+    }
+    return (ts.isPropertyAccessExpression(callee) &&
+        ts.isIdentifier(callee.expression) &&
+        imports.legendNamespaces.has(callee.expression.text) &&
+        LINK_FACTORIES.has(callee.name.text));
+}
+function declaredBinding(call) {
+    const declaration = outermostTransparentParent(call).parent;
+    return ts.isVariableDeclaration(declaration) && ts.isIdentifier(declaration.name)
+        ? declaration.name
+        : null;
+}
+function observableWritesRootedAt(owner, name) {
+    const writes = [];
+    visit(owner.body, (node) => {
+        if (ts.isCallExpression(node) && writesObservableRootedAt(node, name)) {
+            writes.push(node);
+        }
+    });
+    return writes;
+}
+function writesObservableRootedAt(call, name) {
+    const callee = call.expression;
+    if (!ts.isPropertyAccessExpression(callee) || !OBSERVABLE_WRITE_MEMBERS.has(callee.name.text)) {
+        return false;
+    }
+    let current = unwrapTransparentExpression(callee.expression);
+    while (ts.isPropertyAccessExpression(current) || ts.isElementAccessExpression(current)) {
+        if (ts.isPropertyAccessExpression(current) &&
+            RESERVED_OBSERVABLE_MEMBERS.has(current.name.text)) {
+            return false;
+        }
+        current = unwrapTransparentExpression(current.expression);
+    }
+    return ts.isIdentifier(current) && current.text === name;
+}
+function describeLines(writes, sourceFile) {
+    const lines = [
+        ...new Set(writes.map((write) => sourceFile.getLineAndCharacterOfPosition(write.getStart(sourceFile)).line + 1)),
+    ];
+    if (lines.length === 1) {
+        return `line ${lines[0]}`;
+    }
+    const head = lines.slice(0, -1).join(", ");
+    return `lines ${head} and ${lines.at(-1)}`;
+}
+//# sourceMappingURL=written-computed-initializers.js.map

package/dist/src/rules/observable-ownership/written-computed-initializers.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"written-computed-initializers.js","sourceRoot":"","sources":["../../../../src/rules/observable-ownership/written-computed-initializers.ts"],"names":[],"mappings":"AAAA,OAAO,EACL,2BAA2B,EAC3B,wBAAwB,EACxB,0BAA0B,GAC3B,MAAM,yCAAyC,CAAC;AACjD,OAAO,EAAE,uBAAuB,EAAE,2BAA2B,EAAE,MAAM,4BAA4B,CAAC;AAClG,OAAO,EACL,YAAY,EACZ,qBAAqB,EACrB,KAAK,EACL,mCAAmC,GACpC,MAAM,mBAAmB,CAAC;AAK3B,OAAO,EAAE,YAAY,EAAE,MAAM,YAAY,CAAC;AAC1C,OAAO,EAAE,MAAM,YAAY,CAAC;AAoB5B,MAAM,wBAAwB,GAAG,IAAI,GAAG,CAAC,CAAC,QAAQ,EAAE,QAAQ,EAAE,MAAM,EAAE,KAAK,EAAE,QAAQ,EAAE,QAAQ,CAAC,CAAC,CAAC;AAClG,MAAM,cAAc,GAAG,IAAI,GAAG,CAAC,CAAC,QAAQ,EAAE,QAAQ,CAAC,CAAC,CAAC;AAErD,MAAM,UAAU,iCAAiC,CAC/C,IAAuB,EACvB,IAA6B;IAE7B,MAAM,QAAQ,GAAG,eAAe,CAAC,IAAI,EAAE,IAAI,CAAC,CAAC;IAC7C,IAAI,CAAC,QAAQ,EAAE,CAAC;QACd,OAAO,IAAI,CAAC;IACd,CAAC;IACD,MAAM,EAAE,UAAU,EAAE,GAAG,IAAI,CAAC;IAC5B,MAAM,KAAK,GAAG,CAAC,GAAG,IAAI,GAAG,CAAC,QAAQ,CAAC,KAAK,CAAC,GAAG,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,IAAI,CAAC,IAAI,CAAC,OAAO,CAAC,UAAU,CAAC,CAAC,CAAC,CAAC,CAAC;IACxF,MAAM,UAAU,GAAG,aAAa,CAAC,QAAQ,CAAC,MAAM,EAAE,UAAU,CAAC,CAAC;IAC9D,OAAO;QACL,MAAM,EAAE,+BAA+B;QACvC,UAAU,EAAE,SAAS;QACrB,WAAW,EAAE,QAAQ;QACrB,QAAQ,EAAE;YACR,GAAG,KAAK,CAAC,IAAI,CAAC,IAAI,CAAC,wHAAwH;YAC3I,GAAG,QAAQ,CAAC,OAAO,CAAC,IAAI,kBAAkB,UAAU,4EAA4E;SACjI;QACD,QAAQ,EAAE,YAAY,CAAC,IAAI,EAAE,IAAI,CAAC;QAClC,OAAO,EAAE,GAAG,sBAAsB,CAAC,IAAI,EAAE,QAAQ,EAAE,IAAI,CAAC,iFAAiF,KAAK,CAAC,IAAI,CAAC,OAAO,CAAC,+BAA+B,UAAU,uEAAuE;QAC5Q,QAAQ,EAAE,WAAW;KACtB,CAAC;AACJ,CAAC;AAED,SAAS,sBAAsB,CAC7B,IAAuB,EACvB,QAAyB,EACzB,IAA6B;IAE7B,MAAM,EAAE,UAAU,EAAE,GAAG,IAAI,CAAC;IAC5B,MAAM,MAAM,GAAG,IAAI,CAAC,UAAU,CAAC,OAAO,CAAC,UAAU,CAAC,CAAC;IACnD,MAAM,EAAE,IAAI,EAAE,GAAG,QAAQ,CAAC,WAAW,CAAC;IACtC,IAAI,EAAE,CAAC,OAAO,CAAC,IAAI,CAAC,EAAE,CAAC;QACrB,OAAO,yCAAyC,MAAM,sEAAsE,CAAC;IAC/H,CAAC;IACD,MAAM,QAAQ,GAAG,aAAa,CAAC,IAAI,EAAE,QAAQ,CAAC,KAAK,EAAE,UAAU,CAAC,CAAC;IACjE,MAAM,OAAO,GAAG,IAAI,CAAC,SAAS,CAAC,CAAC,CAAE,CAAC,OAAO,CAAC,UAAU,CAAC,CAAC;IACvD,OAAO,aAAa,MAAM,IAAI,OAAO,cAAc,MAAM,IAAI,QAAQ,KAAK,CAAC;AAC7E,CAAC;AAED,SAAS,aAAa,CACpB,IAAmB,EACnB,KAA6B,EAC7B,UAAyB;IAEzB,MAAM,EAAE,IAAI,EAAE,GAAG,UAAU,CAAC;IAC5B,MAAM,KAAK,GAAG,KAAK;SAChB,OAAO,CAAC,CAAC,IAAI,EAAE,EAAE,CAChB,EAAE,CAAC,0BAA0B,CAAC,IAAI,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,UAAU,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,EAAE,CACvF;SACA,QAAQ,CAAC,CAAC,IAAI,EAAE,KAAK,EAAE,EAAE,CAAC,IAAI,CAAC,QAAQ,CAAC,UAAU,CAAC,GAAG,KAAK,CAAC,QAAQ,CAAC,UAAU,CAAC,CAAC,CAAC;IACrF,IAAI,MAAM,GAAG,EAAE,CAAC;IAChB,IAAI,MAAM,GAAG,IAAI,CAAC,QAAQ,CAAC,UAAU,CAAC,CAAC;IACvC,KAAK,MAAM,IAAI,IAAI,KAAK,EAAE,CAAC;QACzB,MAAM,IAAI,GAAG,IAAI,CAAC,KAAK,CAAC,MAAM,EAAE,IAAI,CAAC,QAAQ,CAAC,UAAU,CAAC,CAAC,MAAM,CAAC;QACjE,MAAM,GAAG,IAAI,CAAC,MAAM,EAAE,CAAC;IACzB,CAAC;IACD,OAAO,MAAM,GAAG,IAAI,CAAC,KAAK,CAAC,MAAM,EAAE,IAAI,CAAC,MAAM,EAAE,CAAC,CAAC;AACpD,CAAC;AAED,SAAS,eAAe,CACtB,IAAuB,EACvB,IAA6B;IAE7B,MAAM,WAAW,GAAG,mBAAmB,CAAC,IAAI,CAAC,CAAC;IAC9C,IAAI,CAAC,WAAW,EAAE,CAAC;QACjB,OAAO,IAAI,CAAC;IACd,CAAC;IACD,MAAM,EAAE,OAAO,EAAE,WAAW,EAAE,KAAK,EAAE,GAAG,WAAW,CAAC;IACpD,MAAM,KAAK,GAAG,sBAAsB,CAAC,WAAW,CAAC,IAAI,EAAE,IAAI,CAAC,kBAAkB,CAAC,CAAC;IAChF,IAAI,KAAK,CAAC,MAAM,KAAK,CAAC,IAAI,uBAAuB,CAAC,WAAW,CAAC,IAAI,EAAE,IAAI,CAAC,OAAO,CAAC,EAAE,CAAC;QAClF,OAAO,IAAI,CAAC;IACd,CAAC;IACD,MAAM,MAAM,GAAG,wBAAwB,CAAC,KAAK,EAAE,OAAO,CAAC,IAAI,CAAC,CAAC;IAC7D,OAAO,MAAM,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC,CAAC,EAAE,GAAG,WAAW,EAAE,KAAK,EAAE,MAAM,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC;AACtE,CAAC;AAED,SAAS,mBAAmB,CAAC,IAAuB;IAClD,IAAI,IAAI,CAAC,SAAS,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;QAChC,OAAO,IAAI,CAAC;IACd,CAAC;IACD,MAAM,WAAW,GAAG,2BAA2B,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC,CAAE,CAAC,CAAC;IACpE,MAAM,OAAO,GAAG,eAAe,CAAC,IAAI,CAAC,CAAC;IACtC,MAAM,KAAK,GAAG,YAAY,CAAC,IAAI,EAAE,qBAAqB,CAAC,CAAC;IACxD,IACE,CAAC,sBAAsB,CAAC,WAAW,CAAC;QACpC,CAAC,OAAO;QACR,CAAC,KAAK;QACN,uBAAuB,CAAC,KAAK,EAAE,OAAO,CAAC,IAAI,CAAC,KAAK,CAAC,EAClD,CAAC;QACD,OAAO,IAAI,CAAC;IACd,CAAC;IACD,OAAO,EAAE,OAAO,EAAE,WAAW,EAAE,KAAK,EAAE,CAAC;AACzC,CAAC;AAED,SAAS,sBAAsB,CAAC,UAAyB;IACvD,IAAI,CAAC,EAAE,CAAC,eAAe,CAAC,UAAU,CAAC,IAAI,CAAC,EAAE,CAAC,oBAAoB,CAAC,UAAU,CAAC,EAAE,CAAC;QAC5E,OAAO,KAAK,CAAC;IACf,CAAC;IACD,MAAM,OAAO,GAAG,UAAU,CAAC,SAAS,EAAE,IAAI,CACxC,CAAC,QAAQ,EAAE,EAAE,CAAC,QAAQ,CAAC,IAAI,KAAK,EAAE,CAAC,UAAU,CAAC,YAAY,CAC3D,CAAC;IACF,OAAO,UAAU,CAAC,UAAU,CAAC,MAAM,KAAK,CAAC,IAAI,CAAC,OAAO,IAAI,CAAC,UAAU,CAAC,aAAa,CAAC;AACrF,CAAC;AAED,SAAS,sBAAsB,CAC7B,IAAoB,EACpB,kBAAuC;IAEvC,MAAM,KAAK,GAAkB,EAAE,CAAC;IAChC,mCAAmC,CAAC,IAAI,EAAE,CAAC,IAAI,EAAE,EAAE;QACjD,IAAI,CAAC,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC,EAAE,CAAC;YAC/B,OAAO;QACT,CAAC;QACD,MAAM,IAAI,GAAG,wBAAwB,CAAC,IAAI,EAAE,kBAAkB,CAAC,CAAC;QAChE,IAAI,IAAI,EAAE,CAAC;YACT,KAAK,CAAC,IAAI,CAAC,EAAE,IAAI,EAAE,IAAI,EAAE,IAAI,EAAE,CAAC,CAAC;QACnC,CAAC;IACH,CAAC,CAAC,CAAC;IACH,OAAO,KAAK,CAAC;AACf,CAAC;AAED,SAAS,uBAAuB,CAAC,IAAoB,EAAE,OAAoB;IACzE,IAAI,KAAK,GAAG,KAAK,CAAC;IAClB,KAAK,CAAC,IAAI,EAAE,CAAC,IAAI,EAAE,EAAE;QACnB,IAAI,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC,IAAI,mBAAmB,CAAC,IAAI,CAAC,UAAU,EAAE,OAAO,CAAC,EAAE,CAAC;YAC/E,KAAK,GAAG,IAAI,CAAC;QACf,CAAC;IACH,CAAC,CAAC,CAAC;IACH,OAAO,KAAK,CAAC;AACf,CAAC;AAED,SAAS,mBAAmB,CAAC,MAAqB,EAAE,OAAoB;IACtE,IAAI,EAAE,CAAC,YAAY,CAAC,MAAM,CAAC,EAAE,CAAC;QAC5B,OAAO,OAAO,CAAC,MAAM,CAAC,GAAG,CAAC,MAAM,CAAC,IAAI,CAAC,IAAI,OAAO,CAAC,MAAM,CAAC,GAAG,CAAC,MAAM,CAAC,IAAI,CAAC,CAAC;IAC5E,CAAC;IACD,OAAO,CACL,EAAE,CAAC,0BAA0B,CAAC,MAAM,CAAC;QACrC,EAAE,CAAC,YAAY,CAAC,MAAM,CAAC,UAAU,CAAC;QAClC,OAAO,CAAC,gBAAgB,CAAC,GAAG,CAAC,MAAM,CAAC,UAAU,CAAC,IAAI,CAAC;QACpD,cAAc,CAAC,GAAG,CAAC,MAAM,CAAC,IAAI,CAAC,IAAI,CAAC,CACrC,CAAC;AACJ,CAAC;AAED,SAAS,eAAe,CAAC,IAAuB;IAC9C,MAAM,WAAW,GAAG,0BAA0B,CAAC,IAAI,CAAC,CAAC,MAAM,CAAC;IAC5D,OAAO,EAAE,CAAC,qBAAqB,CAAC,WAAW,CAAC,IAAI,EAAE,CAAC,YAAY,CAAC,WAAW,CAAC,IAAI,CAAC;QAC/E,CAAC,CAAC,WAAW,CAAC,IAAI;QAClB,CAAC,CAAC,IAAI,CAAC;AACX,CAAC;AAED,SAAS,wBAAwB,CAAC,KAA0B,EAAE,IAAY;IACxE,MAAM,MAAM,GAAwB,EAAE,CAAC;IACvC,KAAK,CAAC,KAAK,CAAC,IAAI,EAAE,CAAC,IAAI,EAAE,EAAE;QACzB,IAAI,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC,IAAI,wBAAwB,CAAC,IAAI,EAAE,IAAI,CAAC,EAAE,CAAC;YACtE,MAAM,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QACpB,CAAC;IACH,CAAC,CAAC,CAAC;IACH,OAAO,MAAM,CAAC;AAChB,CAAC;AAED,SAAS,wBAAwB,CAAC,IAAuB,EAAE,IAAY;IACrE,MAAM,MAAM,GAAG,IAAI,CAAC,UAAU,CAAC;IAC/B,IAAI,CAAC,EAAE,CAAC,0BAA0B,CAAC,MAAM,CAAC,IAAI,CAAC,wBAAwB,CAAC,GAAG,CAAC,MAAM,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE,CAAC;QAC9F,OAAO,KAAK,CAAC;IACf,CAAC;IACD,IAAI,OAAO,GAAG,2BAA2B,CAAC,MAAM,CAAC,UAAU,CAAC,CAAC;IAC7D,OAAO,EAAE,CAAC,0BAA0B,CAAC,OAAO,CAAC,IAAI,EAAE,CAAC,yBAAyB,CAAC,OAAO,CAAC,EAAE,CAAC;QACvF,IACE,EAAE,CAAC,0BAA0B,CAAC,OAAO,CAAC;YACtC,2BAA2B,CAAC,GAAG,CAAC,OAAO,CAAC,IAAI,CAAC,IAAI,CAAC,EAClD,CAAC;YACD,OAAO,KAAK,CAAC;QACf,CAAC;QACD,OAAO,GAAG,2BAA2B,CAAC,OAAO,CAAC,UAAU,CAAC,CAAC;IAC5D,CAAC;IACD,OAAO,EAAE,CAAC,YAAY,CAAC,OAAO,CAAC,IAAI,OAAO,CAAC,IAAI,KAAK,IAAI,CAAC;AAC3D,CAAC;AAED,SAAS,aAAa,CAAC,MAAoC,EAAE,UAAyB;IACpF,MAAM,KAAK,GAAG;QACZ,GAAG,IAAI,GAAG,CACR,MAAM,CAAC,GAAG,CACR,CAAC,KAAK,EAAE,EAAE,CAAC,UAAU,CAAC,6BAA6B,CAAC,KAAK,CAAC,QAAQ,CAAC,UAAU,CAAC,CAAC,CAAC,IAAI,GAAG,CAAC,CACzF,CACF;KACF,CAAC;IACF,IAAI,KAAK,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;QACvB,OAAO,QAAQ,KAAK,CAAC,CAAC,CAAC,EAAE,CAAC;IAC5B,CAAC;IACD,MAAM,IAAI,GAAG,KAAK,CAAC,KAAK,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;IAC3C,OAAO,SAAS,IAAI,QAAQ,KAAK,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC,EAAE,CAAC;AAC7C,CAAC"}

package/dist/src/rules/observable-reads/conditional-jsx-slots.d.ts

@@ -0,0 +1,6 @@
+import type { HookImports } from "../../core/imports.js";
+import type { RuntimeFunctionLike } from "../../core/ast.js";
+import ts from "typescript";
+export declare function stableConditionalJsxSlot(references: readonly ts.Identifier[], owner: RuntimeFunctionLike, imports: HookImports): ts.Expression | null;
+export declare function isInsideOwnerReturn(node: ts.Node, owner: RuntimeFunctionLike): boolean;
+//# sourceMappingURL=conditional-jsx-slots.d.ts.map

package/dist/src/rules/observable-reads/conditional-jsx-slots.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"conditional-jsx-slots.d.ts","sourceRoot":"","sources":["../../../../src/rules/observable-reads/conditional-jsx-slots.ts"],"names":[],"mappings":"AAOA,OAAO,KAAK,EAAE,WAAW,EAAE,MAAM,uBAAuB,CAAC;AACzD,OAAO,KAAK,EAAE,mBAAmB,EAAE,MAAM,mBAAmB,CAAC;AAK7D,OAAO,EAAE,MAAM,YAAY,CAAC;AAkB5B,wBAAgB,wBAAwB,CACtC,UAAU,EAAE,SAAS,EAAE,CAAC,UAAU,EAAE,EACpC,KAAK,EAAE,mBAAmB,EAC1B,OAAO,EAAE,WAAW,GACnB,EAAE,CAAC,UAAU,GAAG,IAAI,CAwBtB;AAoKD,wBAAgB,mBAAmB,CAAC,IAAI,EAAE,EAAE,CAAC,IAAI,EAAE,KAAK,EAAE,mBAAmB,GAAG,OAAO,CAkBtF"}

package/dist/src/rules/observable-reads/conditional-jsx-slots.js

@@ -0,0 +1,164 @@
+import { bindingDeclarationCount, isAssignmentOperator, isNonValueIdentifier, unwrapTransparentExpression, } from "../../core/analysis-ast.js";
+import { visit, visitSkippingNestedRuntimeFunctions } from "../../core/ast.js";
+import { bindingContainsName } from "../state-proofs/binding-lookup.js";
+import { hasUnstableSubtreeLifetime } from "../state-proofs/jsx-subtrees.js";
+import { isImportedHookCall } from "../../core/imports.js";
+import { isUseValueCall } from "./observable-paths.js";
+import ts from "typescript";
+function containsKeyedJsxElement(expression) {
+    let keyed = false;
+    visit(expression, (node) => {
+        if (!keyed &&
+            (ts.isJsxElement(node) || ts.isJsxSelfClosingElement(node)) &&
+            (ts.isJsxElement(node) ? node.openingElement : node).attributes.properties.some((property) => ts.isJsxAttribute(property) && property.name.getText() === "key")) {
+            keyed = true;
+        }
+    });
+    return keyed;
+}
+export function stableConditionalJsxSlot(references, owner, imports) {
+    const slots = references.map((reference) => enclosingConditionalJsxExpression(reference, owner));
+    const [slot] = slots;
+    if (!slot || slots.some((candidate) => candidate !== slot) || !slot.expression) {
+        return null;
+    }
+    const expression = unwrapTransparentExpression(slot.expression);
+    const container = ts.isJsxElement(slot.parent) || ts.isJsxFragment(slot.parent) ? slot.parent : null;
+    if (!container ||
+        !isConditionalRenderExpression(expression) ||
+        !hasRenderOwnedConditionalInputs(expression, {
+            imports,
+            observableValue: references[0].text,
+            owner,
+            resolving: new Set(),
+        }) ||
+        !isInsideOwnerReturn(slot, owner) ||
+        hasUnstableSubtreeLifetime(container, owner)) {
+        return null;
+    }
+    return containsKeyedJsxElement(expression) ? null : expression;
+}
+function enclosingConditionalJsxExpression(node, boundary) {
+    for (let current = node.parent; current && current !== boundary; current = current.parent) {
+        if (ts.isJsxExpression(current) &&
+            current.expression &&
+            isConditionalRenderExpression(unwrapTransparentExpression(current.expression)) &&
+            (ts.isJsxElement(current.parent) || ts.isJsxFragment(current.parent))) {
+            return current;
+        }
+    }
+    return null;
+}
+function isConditionalRenderExpression(expression) {
+    return (ts.isConditionalExpression(expression) ||
+        (ts.isBinaryExpression(expression) &&
+            [
+                ts.SyntaxKind.AmpersandAmpersandToken,
+                ts.SyntaxKind.BarBarToken,
+                ts.SyntaxKind.QuestionQuestionToken,
+            ].includes(expression.operatorToken.kind)));
+}
+function hasRenderOwnedConditionalInputs(expression, ownership) {
+    let safe = true;
+    const walk = (node) => {
+        if (!safe ||
+            ts.isJsxElement(node) ||
+            ts.isJsxFragment(node) ||
+            ts.isJsxSelfClosingElement(node)) {
+            return;
+        }
+        if (ts.isAwaitExpression(node) ||
+            ts.isYieldExpression(node) ||
+            ts.isNewExpression(node) ||
+            ts.isCallExpression(node) ||
+            ts.isDeleteExpression(node) ||
+            ts.isPostfixUnaryExpression(node) ||
+            (ts.isPrefixUnaryExpression(node) &&
+                (node.operator === ts.SyntaxKind.PlusPlusToken ||
+                    node.operator === ts.SyntaxKind.MinusMinusToken)) ||
+            (ts.isBinaryExpression(node) && isAssignmentOperator(node.operatorToken.kind))) {
+            safe = false;
+            return;
+        }
+        if (ts.isIdentifier(node) &&
+            !isNonValueIdentifier(node) &&
+            !conditionalIdentifierIsRenderOwned(node.text, ownership)) {
+            safe = false;
+            return;
+        }
+        node.forEachChild(walk);
+    };
+    walk(expression);
+    return safe;
+}
+function soleLocalInitializedDeclaration(body, name) {
+    const declarations = [];
+    visitSkippingNestedRuntimeFunctions(body, (node) => {
+        if (ts.isVariableDeclaration(node) && bindingContainsName(node.name, name)) {
+            declarations.push(node);
+        }
+    });
+    const declaration = declarations.length === 1 ? declarations[0] : null;
+    if (!declaration?.initializer || !ts.isVariableDeclarationList(declaration.parent)) {
+        return null;
+    }
+    return { declaration, initializer: unwrapTransparentExpression(declaration.initializer) };
+}
+function conditionalIdentifierIsRenderOwned(name, ownership) {
+    if (name === ownership.observableValue || name === "undefined") {
+        return true;
+    }
+    if (ownership.owner.parameters.some((parameter) => bindingContainsName(parameter.name, name)) &&
+        bindingDeclarationCount(ownership.owner, name) === 1) {
+        return true;
+    }
+    if (!ownership.owner.body || ownership.resolving.has(name)) {
+        return false;
+    }
+    const local = soleLocalInitializedDeclaration(ownership.owner.body, name);
+    return local !== null && localBindingIsRenderOwned(local, name, ownership);
+}
+function localBindingIsRenderOwned(local, name, ownership) {
+    const { declaration, initializer } = local;
+    if (ts.isArrayBindingPattern(declaration.name) &&
+        declaration.name.elements[0] &&
+        !ts.isOmittedExpression(declaration.name.elements[0]) &&
+        bindingContainsName(declaration.name.elements[0].name, name) &&
+        ts.isCallExpression(initializer) &&
+        isImportedHookCall({
+            call: initializer,
+            localNames: ownership.imports.useState,
+            namespaceNames: ownership.imports.reactNamespaces,
+            canonicalName: "useState",
+        })) {
+        return true;
+    }
+    if (ts.isIdentifier(declaration.name) &&
+        ts.isCallExpression(initializer) &&
+        isUseValueCall(initializer, ownership.imports)) {
+        return true;
+    }
+    if (!ts.isIdentifier(declaration.name) || (declaration.parent.flags & ts.NodeFlags.Const) === 0) {
+        return false;
+    }
+    return hasRenderOwnedConditionalInputs(initializer, {
+        ...ownership,
+        resolving: new Set([...ownership.resolving, name]),
+    });
+}
+export function isInsideOwnerReturn(node, owner) {
+    const { body } = owner;
+    if (!body) {
+        return false;
+    }
+    if (!ts.isBlock(body)) {
+        return node.pos >= body.pos && node.end <= body.end;
+    }
+    for (let current = node.parent; current && current !== owner; current = current.parent) {
+        if (ts.isReturnStatement(current)) {
+            return true;
+        }
+    }
+    return false;
+}
+//# sourceMappingURL=conditional-jsx-slots.js.map

package/dist/src/rules/observable-reads/conditional-jsx-slots.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"conditional-jsx-slots.js","sourceRoot":"","sources":["../../../../src/rules/observable-reads/conditional-jsx-slots.ts"],"names":[],"mappings":"AAAA,OAAO,EACL,uBAAuB,EACvB,oBAAoB,EACpB,oBAAoB,EACpB,2BAA2B,GAC5B,MAAM,4BAA4B,CAAC;AACpC,OAAO,EAAE,KAAK,EAAE,mCAAmC,EAAE,MAAM,mBAAmB,CAAC;AAG/E,OAAO,EAAE,mBAAmB,EAAE,MAAM,mCAAmC,CAAC;AACxE,OAAO,EAAE,0BAA0B,EAAE,MAAM,iCAAiC,CAAC;AAC7E,OAAO,EAAE,kBAAkB,EAAE,MAAM,uBAAuB,CAAC;AAC3D,OAAO,EAAE,cAAc,EAAE,MAAM,uBAAuB,CAAC;AACvD,OAAO,EAAE,MAAM,YAAY,CAAC;AAE5B,SAAS,uBAAuB,CAAC,UAAyB;IACxD,IAAI,KAAK,GAAG,KAAK,CAAC;IAClB,KAAK,CAAC,UAAU,EAAE,CAAC,IAAI,EAAE,EAAE;QACzB,IACE,CAAC,KAAK;YACN,CAAC,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC,IAAI,EAAE,CAAC,uBAAuB,CAAC,IAAI,CAAC,CAAC;YAC3D,CAAC,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,cAAc,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,UAAU,CAAC,UAAU,CAAC,IAAI,CAC7E,CAAC,QAAQ,EAAE,EAAE,CAAC,EAAE,CAAC,cAAc,CAAC,QAAQ,CAAC,IAAI,QAAQ,CAAC,IAAI,CAAC,OAAO,EAAE,KAAK,KAAK,CAC/E,EACD,CAAC;YACD,KAAK,GAAG,IAAI,CAAC;QACf,CAAC;IACH,CAAC,CAAC,CAAC;IACH,OAAO,KAAK,CAAC;AACf,CAAC;AAED,MAAM,UAAU,wBAAwB,CACtC,UAAoC,EACpC,KAA0B,EAC1B,OAAoB;IAEpB,MAAM,KAAK,GAAG,UAAU,CAAC,GAAG,CAAC,CAAC,SAAS,EAAE,EAAE,CAAC,iCAAiC,CAAC,SAAS,EAAE,KAAK,CAAC,CAAC,CAAC;IACjG,MAAM,CAAC,IAAI,CAAC,GAAG,KAAK,CAAC;IACrB,IAAI,CAAC,IAAI,IAAI,KAAK,CAAC,IAAI,CAAC,CAAC,SAAS,EAAE,EAAE,CAAC,SAAS,KAAK,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC,UAAU,EAAE,CAAC;QAC/E,OAAO,IAAI,CAAC;IACd,CAAC;IACD,MAAM,UAAU,GAAG,2BAA2B,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC;IAChE,MAAM,SAAS,GACb,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC,MAAM,CAAC,IAAI,EAAE,CAAC,aAAa,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC,CAAC,IAAI,CAAC;IACrF,IACE,CAAC,SAAS;QACV,CAAC,6BAA6B,CAAC,UAAU,CAAC;QAC1C,CAAC,+BAA+B,CAAC,UAAU,EAAE;YAC3C,OAAO;YACP,eAAe,EAAE,UAAU,CAAC,CAAC,CAAE,CAAC,IAAI;YACpC,KAAK;YACL,SAAS,EAAE,IAAI,GAAG,EAAE;SACrB,CAAC;QACF,CAAC,mBAAmB,CAAC,IAAI,EAAE,KAAK,CAAC;QACjC,0BAA0B,CAAC,SAAS,EAAE,KAAK,CAAC,EAC5C,CAAC;QACD,OAAO,IAAI,CAAC;IACd,CAAC;IACD,OAAO,uBAAuB,CAAC,UAAU,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,UAAU,CAAC;AACjE,CAAC;AAED,SAAS,iCAAiC,CACxC,IAAa,EACb,QAAiB;IAEjB,KACE,IAAI,OAAO,GAAwB,IAAI,CAAC,MAAM,EAC9C,OAAO,IAAI,OAAO,KAAK,QAAQ,EAC/B,OAAO,GAAG,OAAO,CAAC,MAAM,EACxB,CAAC;QACD,IACE,EAAE,CAAC,eAAe,CAAC,OAAO,CAAC;YAC3B,OAAO,CAAC,UAAU;YAClB,6BAA6B,CAAC,2BAA2B,CAAC,OAAO,CAAC,UAAU,CAAC,CAAC;YAC9E,CAAC,EAAE,CAAC,YAAY,CAAC,OAAO,CAAC,MAAM,CAAC,IAAI,EAAE,CAAC,aAAa,CAAC,OAAO,CAAC,MAAM,CAAC,CAAC,EACrE,CAAC;YACD,OAAO,OAAO,CAAC;QACjB,CAAC;IACH,CAAC;IACD,OAAO,IAAI,CAAC;AACd,CAAC;AAED,SAAS,6BAA6B,CAAC,UAAyB;IAC9D,OAAO,CACL,EAAE,CAAC,uBAAuB,CAAC,UAAU,CAAC;QACtC,CAAC,EAAE,CAAC,kBAAkB,CAAC,UAAU,CAAC;YAChC;gBACE,EAAE,CAAC,UAAU,CAAC,uBAAuB;gBACrC,EAAE,CAAC,UAAU,CAAC,WAAW;gBACzB,EAAE,CAAC,UAAU,CAAC,qBAAqB;aACpC,CAAC,QAAQ,CAAC,UAAU,CAAC,aAAa,CAAC,IAAI,CAAC,CAAC,CAC7C,CAAC;AACJ,CAAC;AASD,SAAS,+BAA+B,CACtC,UAAyB,EACzB,SAA+B;IAE/B,IAAI,IAAI,GAAG,IAAI,CAAC;IAChB,MAAM,IAAI,GAAG,CAAC,IAAa,EAAQ,EAAE;QACnC,IACE,CAAC,IAAI;YACL,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC;YACrB,EAAE,CAAC,aAAa,CAAC,IAAI,CAAC;YACtB,EAAE,CAAC,uBAAuB,CAAC,IAAI,CAAC,EAChC,CAAC;YACD,OAAO;QACT,CAAC;QACD,IACE,EAAE,CAAC,iBAAiB,CAAC,IAAI,CAAC;YAC1B,EAAE,CAAC,iBAAiB,CAAC,IAAI,CAAC;YAC1B,EAAE,CAAC,eAAe,CAAC,IAAI,CAAC;YACxB,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC;YACzB,EAAE,CAAC,kBAAkB,CAAC,IAAI,CAAC;YAC3B,EAAE,CAAC,wBAAwB,CAAC,IAAI,CAAC;YACjC,CAAC,EAAE,CAAC,uBAAuB,CAAC,IAAI,CAAC;gBAC/B,CAAC,IAAI,CAAC,QAAQ,KAAK,EAAE,CAAC,UAAU,CAAC,aAAa;oBAC5C,IAAI,CAAC,QAAQ,KAAK,EAAE,CAAC,UAAU,CAAC,eAAe,CAAC,CAAC;YACrD,CAAC,EAAE,CAAC,kBAAkB,CAAC,IAAI,CAAC,IAAI,oBAAoB,CAAC,IAAI,CAAC,aAAa,CAAC,IAAI,CAAC,CAAC,EAC9E,CAAC;YACD,IAAI,GAAG,KAAK,CAAC;YACb,OAAO;QACT,CAAC;QACD,IACE,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC;YACrB,CAAC,oBAAoB,CAAC,IAAI,CAAC;YAC3B,CAAC,kCAAkC,CAAC,IAAI,CAAC,IAAI,EAAE,SAAS,CAAC,EACzD,CAAC;YACD,IAAI,GAAG,KAAK,CAAC;YACb,OAAO;QACT,CAAC;QACD,IAAI,CAAC,YAAY,CAAC,IAAI,CAAC,CAAC;IAC1B,CAAC,CAAC;IACF,IAAI,CAAC,UAAU,CAAC,CAAC;IACjB,OAAO,IAAI,CAAC;AACd,CAAC;AAOD,SAAS,+BAA+B,CACtC,IAAa,EACb,IAAY;IAEZ,MAAM,YAAY,GAA6B,EAAE,CAAC;IAClD,mCAAmC,CAAC,IAAI,EAAE,CAAC,IAAI,EAAE,EAAE;QACjD,IAAI,EAAE,CAAC,qBAAqB,CAAC,IAAI,CAAC,IAAI,mBAAmB,CAAC,IAAI,CAAC,IAAI,EAAE,IAAI,CAAC,EAAE,CAAC;YAC3E,YAAY,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAC1B,CAAC;IACH,CAAC,CAAC,CAAC;IACH,MAAM,WAAW,GAAG,YAAY,CAAC,MAAM,KAAK,CAAC,CAAC,CAAC,CAAC,YAAY,CAAC,CAAC,CAAE,CAAC,CAAC,CAAC,IAAI,CAAC;IACxE,IAAI,CAAC,WAAW,EAAE,WAAW,IAAI,CAAC,EAAE,CAAC,yBAAyB,CAAC,WAAW,CAAC,MAAM,CAAC,EAAE,CAAC;QACnF,OAAO,IAAI,CAAC;IACd,CAAC;IACD,OAAO,EAAE,WAAW,EAAE,WAAW,EAAE,2BAA2B,CAAC,WAAW,CAAC,WAAW,CAAC,EAAE,CAAC;AAC5F,CAAC;AAED,SAAS,kCAAkC,CACzC,IAAY,EACZ,SAA+B;IAE/B,IAAI,IAAI,KAAK,SAAS,CAAC,eAAe,IAAI,IAAI,KAAK,WAAW,EAAE,CAAC;QAC/D,OAAO,IAAI,CAAC;IACd,CAAC;IACD,IACE,SAAS,CAAC,KAAK,CAAC,UAAU,CAAC,IAAI,CAAC,CAAC,SAAS,EAAE,EAAE,CAAC,mBAAmB,CAAC,SAAS,CAAC,IAAI,EAAE,IAAI,CAAC,CAAC;QACzF,uBAAuB,CAAC,SAAS,CAAC,KAAK,EAAE,IAAI,CAAC,KAAK,CAAC,EACpD,CAAC;QACD,OAAO,IAAI,CAAC;IACd,CAAC;IACD,IAAI,CAAC,SAAS,CAAC,KAAK,CAAC,IAAI,IAAI,SAAS,CAAC,SAAS,CAAC,GAAG,CAAC,IAAI,CAAC,EAAE,CAAC;QAC3D,OAAO,KAAK,CAAC;IACf,CAAC;IACD,MAAM,KAAK,GAAG,+BAA+B,CAAC,SAAS,CAAC,KAAK,CAAC,IAAI,EAAE,IAAI,CAAC,CAAC;IAC1E,OAAO,KAAK,KAAK,IAAI,IAAI,yBAAyB,CAAC,KAAK,EAAE,IAAI,EAAE,SAAS,CAAC,CAAC;AAC7E,CAAC;AAED,SAAS,yBAAyB,CAChC,KAA4B,EAC5B,IAAY,EACZ,SAA+B;IAE/B,MAAM,EAAE,WAAW,EAAE,WAAW,EAAE,GAAG,KAAK,CAAC;IAC3C,IACE,EAAE,CAAC,qBAAqB,CAAC,WAAW,CAAC,IAAI,CAAC;QAC1C,WAAW,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC,CAAC;QAC5B,CAAC,EAAE,CAAC,mBAAmB,CAAC,WAAW,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC;QACrD,mBAAmB,CAAC,WAAW,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,IAAI,EAAE,IAAI,CAAC;QAC5D,EAAE,CAAC,gBAAgB,CAAC,WAAW,CAAC;QAChC,kBAAkB,CAAC;YACjB,IAAI,EAAE,WAAW;YACjB,UAAU,EAAE,SAAS,CAAC,OAAO,CAAC,QAAQ;YACtC,cAAc,EAAE,SAAS,CAAC,OAAO,CAAC,eAAe;YACjD,aAAa,EAAE,UAAU;SAC1B,CAAC,EACF,CAAC;QACD,OAAO,IAAI,CAAC;IACd,CAAC;IACD,IACE,EAAE,CAAC,YAAY,CAAC,WAAW,CAAC,IAAI,CAAC;QACjC,EAAE,CAAC,gBAAgB,CAAC,WAAW,CAAC;QAChC,cAAc,CAAC,WAAW,EAAE,SAAS,CAAC,OAAO,CAAC,EAC9C,CAAC;QACD,OAAO,IAAI,CAAC;IACd,CAAC;IACD,IAAI,CAAC,EAAE,CAAC,YAAY,CAAC,WAAW,CAAC,IAAI,CAAC,IAAI,CAAC,WAAW,CAAC,MAAM,CAAC,KAAK,GAAG,EAAE,CAAC,SAAS,CAAC,KAAK,CAAC,KAAK,CAAC,EAAE,CAAC;QAChG,OAAO,KAAK,CAAC;IACf,CAAC;IACD,OAAO,+BAA+B,CAAC,WAAW,EAAE;QAClD,GAAG,SAAS;QACZ,SAAS,EAAE,IAAI,GAAG,CAAC,CAAC,GAAG,SAAS,CAAC,SAAS,EAAE,IAAI,CAAC,CAAC;KACnD,CAAC,CAAC;AACL,CAAC;AAED,MAAM,UAAU,mBAAmB,CAAC,IAAa,EAAE,KAA0B;IAC3E,MAAM,EAAE,IAAI,EAAE,GAAG,KAAK,CAAC;IACvB,IAAI,CAAC,IAAI,EAAE,CAAC;QACV,OAAO,KAAK,CAAC;IACf,CAAC;IACD,IAAI,CAAC,EAAE,CAAC,OAAO,CAAC,IAAI,CAAC,EAAE,CAAC;QACtB,OAAO,IAAI,CAAC,GAAG,IAAI,IAAI,CAAC,GAAG,IAAI,IAAI,CAAC,GAAG,IAAI,IAAI,CAAC,GAAG,CAAC;IACtD,CAAC;IACD,KACE,IAAI,OAAO,GAAwB,IAAI,CAAC,MAAM,EAC9C,OAAO,IAAI,OAAO,KAAK,KAAK,EAC5B,OAAO,GAAG,OAAO,CAAC,MAAM,EACxB,CAAC;QACD,IAAI,EAAE,CAAC,iBAAiB,CAAC,OAAO,CAAC,EAAE,CAAC;YAClC,OAAO,IAAI,CAAC;QACd,CAAC;IACH,CAAC;IACD,OAAO,KAAK,CAAC;AACf,CAAC"}

package/dist/src/rules/observable-reads/fresh-selector-results.d.ts

@@ -0,0 +1,11 @@
+import type { LegendPracticeFinding } from "../../core/types.js";
+import type { ObservableReadScan } from "./model.js";
+import ts from "typescript";
+/**
+ * `const { a, b } = useValue(() => ({ a: a$.get(), b: total }))` builds a new object on every
+ * tracked change, so every destructured consumer sees a fresh identity. When each destructured
+ * member is a direct observable read or an evaluation-inert expression, one `useValue` per
+ * read subscribes to exactly the same paths and returns values that compare by content.
+ */
+export declare function splitUseValueResultFinding(call: ts.CallExpression, scan: ObservableReadScan): LegendPracticeFinding | null;
+//# sourceMappingURL=fresh-selector-results.d.ts.map

package/dist/src/rules/observable-reads/fresh-selector-results.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"fresh-selector-results.d.ts","sourceRoot":"","sources":["../../../../src/rules/observable-reads/fresh-selector-results.ts"],"names":[],"mappings":"AAUA,OAAO,KAAK,EAAE,qBAAqB,EAAE,MAAM,qBAAqB,CAAC;AACjE,OAAO,KAAK,EAAE,kBAAkB,EAAE,MAAM,YAAY,CAAC;AACrD,OAAO,EAAE,MAAM,YAAY,CAAC;AAiB5B;;;;;GAKG;AACH,wBAAgB,0BAA0B,CACxC,IAAI,EAAE,EAAE,CAAC,cAAc,EACvB,IAAI,EAAE,kBAAkB,GACvB,qBAAqB,GAAG,IAAI,CAG9B"}