lazycodex-ai 5.1.44 → 5.1.46

package/packages/shared-skills/skills/ulw-research/scripts/fact-derive.test.ts

@@ -0,0 +1,375 @@
+import { describe, expect, onTestFinished, test } from "bun:test"
+import { mkdtempSync, rmSync } from "node:fs"
+import { tmpdir } from "node:os"
+import { join } from "node:path"
+
+import { derive, recompute } from "./fact-derive.mjs"
+import { addRow, emptyLedger, readLedger, writeLedger } from "./fact-ledger.mjs"
+
+const HASH = "a".repeat(64)
+const EOK_WON = "\uC5B5\uC6D0"
+
+type Row = Record<string, unknown>
+type Ledger = { schemaVersion: number; rows: Row[]; events: unknown[] }
+
+function measured(factId: string, value: string, unit: string, extra: Row = {}): Row {
+	return {
+		fact_id: factId,
+		kind: "measured",
+		value,
+		unit,
+		raw: `${value} ${unit}`,
+		quote: `The figure is ${value} ${unit}.`,
+		source_id: "S1",
+		locator: { artifact: "sources/S1/text.txt", char_start: 0, char_end: 20 },
+		snapshot_sha256: HASH,
+		extracted_by: "fact add --find",
+		observed_at: "2026-10-23T08:00:00Z",
+		label: factId.toLowerCase(),
+		...extra,
+	}
+}
+
+function ledgerOf(rows: Row[]): Ledger {
+	const ledger = emptyLedger() as Ledger
+	for (const row of rows) addRow(ledger, row)
+	return ledger
+}
+
+function fixture(): Ledger {
+	return ledgerOf([
+		measured("F5", "100", EOK_WON, { population: "all" }),
+		measured("F6", "200", EOK_WON, { population: "all" }),
+		measured("F7", "200", EOK_WON, { population: "subset" }),
+		measured("F8", "15", "%"),
+		measured("F9", "20", "%"),
+		measured("F12", "320", "m"),
+		measured("F19", "100", "case", { valid_at: "2025-Q3", entity: "acme" }),
+		measured("F20", "112", "case", { valid_at: "2026-Q3", entity: "acme" }),
+		measured("F30", "3.2", "m"),
+	])
+}
+
+function rowOf(result: { row?: Row; error?: string; detail?: string }): Row {
+	if (!result.row) throw new Error(`expected a row, got ${result.error}: ${result.detail}`)
+	return result.row
+}
+
+describe("derive: checked operations", () => {
+	test("sum of compatible rows stores the exact sum and appends a derived row", () => {
+		const ledger = fixture()
+		const row = rowOf(derive(ledger, { op: "sum", operands: ["F5", "F6"], unit: EOK_WON }))
+		// unit-rules.md: derived rows store the canonical unit text, so the input alias is stored as its table token.
+		expect(row).toMatchObject({ fact_id: "F31", kind: "derived", operation: "sum", value: "300", unit: "KRW-e8", exact: { num: "300", den: "1" } })
+		expect(row.operands).toEqual(["F5", "F6"])
+		expect(row.derived_from).toEqual(["F5", "F6"])
+		expect(ledger.rows.at(-1)).toBe(row)
+	})
+
+	test("sum across declared populations is incompatible and writes nothing", () => {
+		const ledger = fixture()
+		const result = derive(ledger, { op: "sum", operands: ["F5", "F7"], unit: EOK_WON })
+		expect(result.error).toBe("incompatible_operands")
+		expect(result.detail).toContain("population")
+		expect(ledger.rows).toHaveLength(9)
+	})
+
+	test("percent operands: plain sum refused, pp diff and disjoint sum allowed", () => {
+		const ledger = fixture()
+		expect(derive(ledger, { op: "sum", operands: ["F8", "F9"], unit: "%" }).error).toBe("incompatible_operands")
+		expect(derive(ledger, { op: "diff", operands: ["F9", "F8"], unit: "%" }).error).toBe("incompatible_operands")
+		// unit-rules.md: `pp` is an input alias; the stored unit is canonical `%p`.
+		expect(rowOf(derive(ledger, { op: "diff", operands: ["F9", "F8"], unit: "pp" }))).toMatchObject({ value: "5", unit: "%p" })
+		expect(derive(ledger, { op: "sum", operands: ["F8", "F9"], unit: "%", disjoint: true }).error).toBe("incompatible_operands")
+		// unit-rules.md: a % sum also needs one shared reference (denominator), persisted in context.
+		expect(derive(ledger, { op: "sum", operands: ["F8", "F9"], unit: "%", disjoint: true, rationale: "x" }).error).toBe("incompatible_operands")
+		const disjoint = rowOf(derive(ledger, { op: "sum", operands: ["F8", "F9"], unit: "%", disjoint: true, reference: "all", rationale: "x" }))
+		expect(disjoint).toMatchObject({ value: "35", unit: "%", rationale: "x", context: { disjoint: true, reference: "all" } })
+	})
+
+	test("growth needs two periods of the same entity", () => {
+		const ledger = fixture()
+		const row = rowOf(derive(ledger, { op: "growth", from: "F19", to: "F20", unit: "%" }))
+		expect(row).toMatchObject({ value: "12", unit: "%", exact: { num: "12", den: "1" }, operands: ["F19", "F20"] })
+		addRow(ledger, measured("F21", "105", "case", { valid_at: "2025-Q3", entity: "acme" }))
+		const same = derive(ledger, { op: "growth", from: "F19", to: "F21", unit: "%" })
+		expect(same.error).toBe("incompatible_operands")
+		expect(same.detail).toContain("valid_at")
+	})
+
+	test("an unknown or missing operand is refused", () => {
+		const ledger = fixture()
+		expect(derive(ledger, { op: "sum", operands: ["F5", "F99"], unit: EOK_WON }).error).toBeDefined()
+		expect(ledger.rows).toHaveLength(9)
+	})
+})
+
+describe("derive: rendered precision", () => {
+	const precision = () =>
+		ledgerOf([measured("F1", "1000", "m"), measured("F2", "3", "m"), measured("F3", "9", "m"), measured("F4", "1.5", "m"), measured("F5", "20.25", "%"), measured("F6", "15.5", "%"), measured("F7", "19.0", "m")])
+
+	test("a difference keeps the fewest decimal places: 1000 m - 3 m is 997 m", () => {
+		const row = rowOf(derive(precision(), { op: "diff", operands: ["F1", "F2"], unit: "m" }))
+		expect(row).toMatchObject({ value: "997", render: "997 m", exact: { num: "997", den: "1" } })
+	})
+
+	test("a difference keeps the fewest decimal places: 9 m - 1.5 m is 8 m, 19.0 m - 1.5 m is 17.5 m", () => {
+		const ledger = precision()
+		expect(rowOf(derive(ledger, { op: "diff", operands: ["F3", "F4"], unit: "m" }))).toMatchObject({ value: "8", render: "8 m", exact: { num: "15", den: "2" } })
+		expect(rowOf(derive(ledger, { op: "diff", operands: ["F7", "F4"], unit: "m" }))).toMatchObject({ value: "17.5", render: "17.5 m", exact: { num: "35", den: "2" } })
+	})
+
+	test("pp with mixed decimal places rounds to the fewest: 20.25 % - 15.5 % is 4.8 pp", () => {
+		const ledger = precision()
+		const row = rowOf(derive(ledger, { op: "diff", operands: ["F5", "F6"], unit: "pp" }))
+		// unit-rules.md: the canonical delta unit is `%p`; precision is unchanged.
+		expect(row).toMatchObject({ value: "4.8", unit: "%p", render: "4.8 %p", exact: { num: "19", den: "4" } })
+		expect(recompute(ledger, row).ok).toBe(true)
+	})
+})
+
+describe("derive: convert", () => {
+	test("320 m to mm keeps the original beside the converted value", () => {
+		const ledger = fixture()
+		const row = rowOf(derive(ledger, { op: "convert", operands: ["F12"], to: "mm" }))
+		expect(row).toMatchObject({ kind: "converted", operation: "convert", value: "320000", unit: "mm", factor: "1000", render: "320,000 mm (320 m)" })
+		expect(row.exact).toEqual({ num: "320000", den: "1" })
+		expect(row.derived_from).toEqual(["F12"])
+	})
+
+	test("3.2 m to cm renders 320 cm at the original precision", () => {
+		const ledger = fixture()
+		const row = rowOf(derive(ledger, { op: "convert", operands: ["F30"], to: "cm" }))
+		expect(row.value).toBe("320")
+		expect(String(row.render).startsWith("320 cm")).toBe(true)
+		expect(String(row.render)).not.toContain("320.0")
+	})
+
+	test("currency conversion is refused with a hint to expr", () => {
+		const ledger = fixture()
+		const result = derive(ledger, { op: "convert", operands: ["F5"], to: "USD" })
+		expect(result.error).toBe("incompatible_operands")
+		expect(result.hint).toContain("expr")
+		expect(ledger.rows).toHaveLength(9)
+	})
+})
+
+describe("derive: expr and exact chaining", () => {
+	// unit-rules.md: expr units are inferred with no rationale escape, and an omitted unit is an error, not null.
+	test("expr needs a declared unit that follows from its operands", () => {
+		const ledger = fixture()
+		expect(derive(ledger, { op: "expr", formula: "F12 / F30", rationale: "span over sample length" }).error).toBeDefined()
+		expect(derive(ledger, { op: "expr", formula: "F12 / F30", unit: "m" }).error).toBeDefined()
+		const result = derive(ledger, { op: "expr", formula: "F12 / F30", unit: null })
+		expect(result.compatibility).toBe("unchecked")
+		expect(rowOf(result)).toMatchObject({ value: "100", formula: "F12 / F30", operands: ["F12", "F30"] })
+	})
+
+	test("expr refuses unsupported tokens and absent ids", () => {
+		const ledger = fixture()
+		for (const formula of ["F12 ** 2", "Math.max(F12)", "F12 / F404", "F12 / 0", "(F12"]) {
+			expect(derive(ledger, { op: "expr", formula, unit: null }).error).toBeDefined()
+		}
+		expect(ledger.rows).toHaveLength(9)
+	})
+
+	test("ratio of 1.00 / 3.00 stores 1/3 and chains exactly through expr", () => {
+		const ledger = ledgerOf([measured("F5", "1.00", EOK_WON, { population: "all" }), measured("F6", "3.00", EOK_WON, { population: "all" })])
+		// unit-rules.md: the result unit is always declared; a same-unit ratio is dimensionless (null).
+		const ratio = rowOf(derive(ledger, { op: "ratio", num: "F5", den: "F6", unit: null }))
+		expect(ratio.exact).toEqual({ num: "1", den: "3" })
+		expect(ratio.value).toBe("0.333")
+		const chained = rowOf(derive(ledger, { op: "expr", formula: `${ratio.fact_id} * 3`, unit: null }))
+		expect(chained.exact).toEqual({ num: "1", den: "1" })
+		expect(chained.value).toBe("1")
+
+		const dir = mkdtempSync(join(tmpdir(), "ulw-derive-"))
+		onTestFinished(() => rmSync(dir, { recursive: true, force: true }))
+		writeLedger(dir, ledger)
+		const back = readLedger(dir) as Ledger
+		expect(back.rows.find((row) => row.fact_id === ratio.fact_id)?.exact).toEqual({ num: "1", den: "3" })
+		expect(recompute(back, back.rows.find((row) => row.fact_id === chained.fact_id) as Row).ok).toBe(true)
+	})
+})
+
+describe("recompute", () => {
+	test("an untouched row recomputes; an edited value or exact does not", () => {
+		const ledger = fixture()
+		const row = rowOf(derive(ledger, { op: "convert", operands: ["F12"], to: "mm" }))
+		expect(recompute(ledger, row)).toMatchObject({ ok: true, expected: { value: "320000", exact: { num: "320000", den: "1" } } })
+		expect(recompute(ledger, { ...row, value: "319999" }).ok).toBe(false)
+		expect(recompute(ledger, { ...row, exact: { num: "319999", den: "1" } }).ok).toBe(false)
+		const sum = rowOf(derive(ledger, { op: "sum", operands: ["F5", "F6"], unit: EOK_WON }))
+		expect(recompute(ledger, sum).ok).toBe(true)
+		expect(recompute(ledger, { ...sum, exact: { num: "301", den: "1" } }).ok).toBe(false)
+	})
+
+	const meters = () => ledgerOf([measured("F1", "1", "m"), measured("F2", "3", "m"), measured("F3", "5", "m")])
+
+	test("a unit relabel with a matching render is refused: 1 m + 3 m relabeled 4 km", () => {
+		const ledger = meters()
+		const sum = rowOf(derive(ledger, { op: "sum", operands: ["F1", "F2"], unit: "m" }))
+		expect(recompute(ledger, sum).ok).toBe(true)
+		const relabeled = recompute(ledger, { ...sum, unit: "km", raw: "4 km", render: "4 km" })
+		expect(relabeled.ok).toBe(false)
+		expect(relabeled.detail).toContain("unit")
+		const expr = rowOf(derive(ledger, { op: "expr", formula: "F1 + F2", unit: "m" }))
+		expect(recompute(ledger, expr).ok).toBe(true)
+		expect(recompute(ledger, { ...expr, unit: "km", raw: "4 km", render: "4 km" }).ok).toBe(false)
+	})
+
+	test("a row with null operands is not ok and does not throw", () => {
+		const ledger = meters()
+		const sum = rowOf(derive(ledger, { op: "sum", operands: ["F1", "F2"], unit: "m" }))
+		const result = recompute(ledger, { ...sum, operands: null })
+		expect(result.ok).toBe(false)
+		expect(result.detail).toContain("operands")
+	})
+
+	test("an expr row whose operands no longer match its formula ids is not ok and does not throw", () => {
+		const ledger = meters()
+		const expr = rowOf(derive(ledger, { op: "expr", formula: "F1 + F2", unit: "m" }))
+		const result = recompute(ledger, { ...expr, operands: ["F1", "F3"] })
+		expect(result.ok).toBe(false)
+		expect(result.detail).toContain("F2")
+	})
+})
+
+describe("unit rules: the design review's counterexamples", () => {
+	const book = () =>
+		ledgerOf([
+			measured("F1", "20", "%"),
+			measured("F2", "10", "%"),
+			measured("F3", "5", "pp"),
+			measured("F4", "25", "C", { valid_at: "2025", entity: "x" }),
+			measured("F5", "30", "C", { valid_at: "2026", entity: "x" }),
+			measured("F6", "200", "person"),
+			measured("F7", "100", "person"),
+			measured("F8", "100", "USD"),
+			measured("F9", "20", "USD/person"),
+			measured("F10", "0", "m"),
+		])
+
+	test("a sum of % operands without one shared reference is refused", () => {
+		const ledger = book()
+		const base = { op: "sum", operands: ["F1", "F2"], unit: "%", disjoint: true, rationale: "disjoint shares" }
+		expect(derive(ledger, base).error).toBe("incompatible_operands")
+		expect(derive(ledger, { ...base, reference: { F1: "voters", F2: "residents" } }).error).toBe("incompatible_operands")
+		expect(rowOf(derive(ledger, { ...base, reference: { F1: "voters", F2: "voters" } }))).toMatchObject({ value: "30", unit: "%" })
+	})
+
+	test("20% - 5pp is 15%", () => {
+		const row = rowOf(derive(book(), { op: "diff", operands: ["F1", "F3"], unit: "%" }))
+		expect(row).toMatchObject({ value: "15", unit: "%", render: "15%" })
+	})
+
+	test("growth on a Celsius scale is refused", () => {
+		const result = derive(book(), { op: "growth", from: "F4", to: "F5", unit: "%" })
+		expect(result.error).toBe("incompatible_operands")
+		expect(result.detail).toContain("affine")
+	})
+
+	test("temperatures are not summed or differenced as absolute values; ratio refuses them; convert C to F is allowed", () => {
+		const ledger = book()
+		const refused = [
+			{ op: "sum", operands: ["F4", "F5"], unit: "C" },
+			{ op: "diff", operands: ["F5", "F4"], unit: "C" },
+			{ op: "expr", formula: "F4 + F5", unit: "C" },
+			{ op: "expr", formula: "F5 - F4", unit: "C" },
+			{ op: "ratio", num: "F5", den: "F4", unit: null },
+		]
+		for (const spec of refused) {
+			const result = derive(ledger, spec)
+			expect({ spec, error: result.error, detail: result.detail }).toEqual({ spec, error: "incompatible_operands", detail: expect.stringContaining("affine") })
+		}
+		const converted = rowOf(derive(ledger, { op: "convert", operands: ["F4"], to: "F" }))
+		expect(converted).toMatchObject({ value: "77", unit: "F" })
+		expect(recompute(ledger, converted).ok).toBe(true)
+	})
+
+	test("a convert row relabeled to an alias in both unit and context.target is detected", () => {
+		const ledger = book()
+		const row = rowOf(derive(ledger, { op: "convert", operands: ["F10"], to: "km" }))
+		const relabeled = recompute(ledger, { ...row, unit: "kilometre", raw: "0 kilometre (0 m)", render: "0 kilometre (0 m)", context: { target: "kilometre" } })
+		expect(relabeled.ok).toBe(false)
+		expect(relabeled.detail).toContain('context.target "kilometre" is not canonical')
+	})
+
+	test("a share of 200 out of 100 is refused", () => {
+		expect(derive(book(), { op: "share", part: "F6", whole: "F7", unit: "%" }).error).toBe("incompatible_operands")
+	})
+
+	test("100 USD / (20 USD/person) is 5 person", () => {
+		const ledger = book()
+		const row = rowOf(derive(ledger, { op: "ratio", num: "F8", den: "F9", unit: "person" }))
+		expect(row).toMatchObject({ value: "5", unit: "person", exact: { num: "5", den: "1" } })
+		expect(recompute(ledger, row).ok).toBe(true)
+	})
+
+	test("convert 0 m to km relabeled cm is detected though the value is unchanged", () => {
+		const ledger = book()
+		const row = rowOf(derive(ledger, { op: "convert", operands: ["F10"], to: "km" }))
+		expect(recompute(ledger, row).ok).toBe(true)
+		const relabeled = recompute(ledger, { ...row, unit: "cm", raw: "0 cm (0 m)", render: "0 cm (0 m)" })
+		expect(relabeled.ok).toBe(false)
+		expect(relabeled.detail).toContain("km")
+	})
+
+	test("expr % + %p is %, in either order; a ratio over unequal % and %p is refused", () => {
+		const ledger = book()
+		for (const formula of ["F1 + F3", "F3 + F1"]) {
+			const row = rowOf(derive(ledger, { op: "expr", formula, unit: "%" }))
+			expect(row).toMatchObject({ value: "25", unit: "%" })
+			expect(recompute(ledger, row).ok).toBe(true)
+		}
+		const ratio = derive(ledger, { op: "ratio", num: "F1", den: "F3", unit: null })
+		expect(ratio.error).toBe("incompatible_operands")
+		expect(ratio.detail).toContain("needs equal units")
+	})
+
+	test("a stored context on an operation that has none is malformed", () => {
+		const ledger = book()
+		const diff = rowOf(derive(ledger, { op: "diff", operands: ["F1", "F2"], unit: "%p" }))
+		const expr = rowOf(derive(ledger, { op: "expr", formula: "F1 - F2", unit: "%p" }))
+		for (const [row, context] of [[diff, "x"], [expr, { target: "km" }]] as const) {
+			const result = recompute(ledger, { ...row, context })
+			expect(result.ok).toBe(false)
+			expect(result.detail).toContain("rows carry no context")
+		}
+	})
+
+	test("expr 20% - 10% is %p, never %", () => {
+		const ledger = book()
+		expect(derive(ledger, { op: "expr", formula: "F1 - F2", unit: "%" }).error).toBe("incompatible_operands")
+		const row = rowOf(derive(ledger, { op: "expr", formula: "F1 - F2", unit: "%p" }))
+		expect(row).toMatchObject({ value: "10", unit: "%p" })
+		expect(recompute(ledger, row).ok).toBe(true)
+	})
+})
+
+describe("render precision of expr results (invariant 5)", () => {
+	const book = () => ledgerOf([measured("F1", "20.25", "%"), measured("F2", "15.5", "%"), measured("F3", "1000", "m"), measured("F4", "3", "m"), measured("F5", "12.34", "m")])
+
+	test("an expr difference giving %p renders by decimal places, as diff does", () => {
+		const ledger = book()
+		const viaDiff = rowOf(derive(ledger, { op: "diff", operands: ["F1", "F2"], unit: "%p" }))
+		const viaExpr = rowOf(derive(ledger, { op: "expr", formula: "F1 - F2", unit: "%p" }))
+		expect(viaDiff).toMatchObject({ value: "4.8", render: "4.8 %p" })
+		expect(viaExpr).toMatchObject({ value: "4.8", render: "4.8 %p" })
+		expect(recompute(ledger, viaExpr).ok).toBe(true)
+	})
+
+	test("an expr with a - root renders 1000 m - 3 m as 997 m", () => {
+		const ledger = book()
+		const row = rowOf(derive(ledger, { op: "expr", formula: "F3 - F4", unit: "m" }))
+		expect(row).toMatchObject({ value: "997", render: "997 m", exact: { num: "997", den: "1" } })
+		expect(recompute(ledger, row).ok).toBe(true)
+	})
+
+	test("an expr with a * root keeps significant figures", () => {
+		const ledger = book()
+		const row = rowOf(derive(ledger, { op: "expr", formula: "F5 * 1.5", unit: "m" }))
+		expect(row).toMatchObject({ value: "19", render: "19 m" })
+		expect(recompute(ledger, row).ok).toBe(true)
+	})
+})

package/packages/shared-skills/skills/ulw-research/scripts/fact-expr.mjs

@@ -0,0 +1,108 @@
+// fact-expr.mjs - the expression language of `fact derive --op expr` (references/unit-rules.md, expr row).
+// Leaves are fact ids and decimal literals; nodes are + - * / and pct(x), the explicit dimensionless-to-% node.
+// evaluate() is exact rational arithmetic. Under * and / a child whose inferred unit is % or %p enters as its
+// fraction (20% as 0.2): that unit comes from the registry's inference over the operand rows, never from the row's
+// own declared unit.
+
+import { add, div, fromDecimal, mul, sub } from "./rational.mjs"
+import { isPercentish, refuse } from "./unit-algebra.mjs"
+
+const TOKEN = /\s*(?:(F\d+)|(\d+(?:\.\d+)?)|(pct)\b|([-+*/()]))/y
+const HUNDRED = fromDecimal("100")
+
+function tokenize(formula) {
+	const text = String(formula ?? "")
+	const tokens = []
+	TOKEN.lastIndex = 0
+	while (/\S/.test(text.slice(TOKEN.lastIndex))) {
+		const at = TOKEN.lastIndex
+		const match = TOKEN.exec(text)
+		if (!match) refuse(`unsupported expression text at ${at}: "${text.slice(at).trim().slice(0, 16)}"`)
+		tokens.push(match[1] ? { id: match[1] } : match[2] ? { literal: match[2] } : match[3] ? { fn: "pct" } : { op: match[4] })
+	}
+	if (tokens.length === 0) refuse("expr needs an expression")
+	return tokens
+}
+
+/** Shunting-yard parser: parentheses and AST depth do not consume the JS call stack. */
+export function parseExpr(formula) {
+	if (typeof formula !== "string") refuse("expr needs an expression")
+	const tokens = tokenize(formula)
+	const values = []
+	const ops = []
+	const precedence = (op) => op === "*" || op === "/" ? 2 : 1
+	const reduce = () => {
+		const op = ops.pop()
+		if (op === "pct") values.push({ fn: op, arg: values.pop() })
+		else { const right = values.pop(); values.push({ op, left: values.pop(), right }) }
+	}
+	let need = true
+	for (let i = 0; i < tokens.length; i++) {
+		const token = tokens[i]
+		if (need) {
+			if (token.id || token.literal) { values.push(token); need = false }
+			else if (token.fn) {
+				if (tokens[i + 1]?.op !== "(") refuse("pct needs a parenthesized argument")
+				ops.push("pct")
+			} else if (token.op === "(") ops.push("(")
+			else refuse(`unexpected "${token.op}" in the expression`)
+		} else if (token.op === ")") {
+			while (ops.length && ops.at(-1) !== "(") reduce()
+			if (ops.pop() !== "(") refuse("unexpected closing parenthesis")
+			if (ops.at(-1) === "pct") reduce()
+		} else if (["+", "-", "*", "/"].includes(token.op)) {
+			while (ops.length && ops.at(-1) !== "(" && precedence(ops.at(-1)) >= precedence(token.op)) reduce()
+			ops.push(token.op)
+			need = true
+		} else refuse("unexpected text after the expression")
+	}
+	if (need) refuse("the expression ends early")
+	if (ops.includes("(")) refuse("the expression is missing a closing parenthesis")
+	while (ops.length) reduce()
+	return values[0]
+}
+
+const childrenOf = (node) => (node.op ? [node.left, node.right] : node.fn ? [node.arg] : [])
+
+export function leaves(node, found = { ids: [], literals: [] }) {
+	const ids = new Set(found.ids)
+	const stack = [node]
+	while (stack.length) {
+		const current = stack.pop()
+		if (current.id) ids.add(current.id)
+		if (current.literal) found.literals.push(current.literal)
+		stack.push(...childrenOf(current).reverse())
+	}
+	found.ids = [...ids]
+	return found
+}
+
+export function postorder(node) {
+	const stack = [node]
+	const order = []
+	while (stack.length) { const current = stack.pop(); order.push(current); stack.push(...childrenOf(current)) }
+	return order.reverse()
+}
+
+/** Exact value of the tree; `units` maps each node to its inferred canonical unit (inferExpr in unit-rules.mjs). */
+export function evaluate(node, values, units) {
+	const results = new Map()
+	for (const current of postorder(node)) {
+		let value
+		if (current.id) value = values.get(current.id)
+		else if (current.literal) value = fromDecimal(current.literal)
+		else if (current.fn === "pct") value = mul(results.get(current.arg), HUNDRED)
+		else {
+			const operand = (child) => {
+				const v = results.get(child)
+				return (current.op === "*" || current.op === "/") && isPercentish(units.get(child)) ? div(v, HUNDRED) : v
+			}
+			const left = operand(current.left)
+			const right = operand(current.right)
+			if (current.op === "/" && right.num === 0n) refuse("the expression divides by zero", undefined, "divides_by_zero", "a nonzero denominator")
+			value = { "+": add, "-": sub, "*": mul, "/": div }[current.op](left, right)
+		}
+		results.set(current, value)
+	}
+	return results.get(node)
+}