lastlight 0.1.15 → 0.2.1

package/dist/state/workflow-run-store.js

@@ -0,0 +1,363 @@
+/**
+ * Aggregate root for a workflow run's lifecycle. Owns the `workflow_runs`
+ * table (including the `phase_history` JSON column) and the named, atomic
+ * transitions a run moves through: create → pause-for-approval →
+ * resume/finish, plus gate resolution and the socratic reply append.
+ *
+ * Carved out of the old `StateDb` god-class (issue #97). The deepening: every
+ * multi-step mutation that previously lived as an un-guarded read-modify-write
+ * chain in `index.ts` / `admin/routes.ts` / `phase-executor.ts` is now a
+ * single named operation wrapped in ONE `better-sqlite3` transaction — a throw
+ * partway through rolls the whole thing back, so a run can never be left
+ * marked `running` with its gate unresolved (the hazard the issue calls out).
+ *
+ * Constructed with an injected {@link ApprovalStore}: an approval has no life
+ * independent of its run, so the cross-table ops call the approval store's
+ * single-table writes from inside this store's transaction. Both stores MUST
+ * be built from the same `Database` — better-sqlite3 transactions are
+ * per-connection.
+ *
+ * The long-running re-dispatch (`dispatchWorkflow`, which spawns a Docker
+ * sandbox for minutes) is deliberately NOT part of any transaction here —
+ * better-sqlite3 transactions are synchronous. The atomic boundary is the DB
+ * mutations only; the caller dispatches after the transaction commits.
+ */
+export class WorkflowRunStore {
+    db;
+    approvals;
+    constructor(db, deps) {
+        this.db = db;
+        this.approvals = deps.approvals;
+    }
+    // ── Plain single-mutation operations ───────────────────────────
+    /** Create a new workflow run record */
+    createRun(run) {
+        const now = new Date().toISOString();
+        this.db.prepare(`
+      INSERT INTO workflow_runs (id, workflow_name, trigger_id, repo, issue_number, current_phase, phase_history, status, context, scratch, started_at, updated_at)
+      VALUES (?, ?, ?, ?, ?, ?, '[]', ?, ?, ?, ?, ?)
+    `).run(run.id, run.workflowName, run.triggerId, run.repo ?? null, run.issueNumber ?? null, run.currentPhase, run.status, run.context ? JSON.stringify(run.context) : null, run.scratch ? JSON.stringify(run.scratch) : null, run.startedAt, now);
+    }
+    /**
+     * Top-level merge of `patch` into the workflow run's scratch state.
+     * Loop iterations can append to `scratch.socratic.qa` without clobbering
+     * other keys.
+     *
+     * Throws if `patch` is not JSON-serializable (e.g. it contains a BigInt) —
+     * which is exactly how the atomic ops prove their rollback: a poison patch
+     * makes `JSON.stringify` throw mid-transaction.
+     */
+    mergeScratch(id, patch) {
+        const now = new Date().toISOString();
+        const row = this.db
+            .prepare(`SELECT scratch FROM workflow_runs WHERE id = ?`)
+            .get(id);
+        if (!row)
+            return;
+        const current = row.scratch ? JSON.parse(row.scratch) : {};
+        const merged = { ...current, ...patch };
+        // Stringify BEFORE the UPDATE so a non-serializable patch throws without
+        // having mutated the row — keeps the op all-or-nothing even outside a txn.
+        const serialized = JSON.stringify(merged);
+        this.db
+            .prepare(`UPDATE workflow_runs SET scratch = ?, updated_at = ? WHERE id = ?`)
+            .run(serialized, now, id);
+    }
+    /**
+     * Update the current phase and append to phase history. This is the single
+     * seam through which all phase-history writes flow (issue #97 defers the
+     * full `phase_history`/`executions` reconciliation to a follow-up, but
+     * routes every write through here so that future change touches one method
+     * instead of ~10 call sites).
+     */
+    appendPhase(id, phase, entry) {
+        const now = new Date().toISOString();
+        const row = this.db.prepare(`SELECT phase_history FROM workflow_runs WHERE id = ?`).get(id);
+        if (!row)
+            return;
+        const history = JSON.parse(row.phase_history);
+        history.push(entry);
+        this.db.prepare(`
+      UPDATE workflow_runs SET current_phase = ?, phase_history = ?, updated_at = ? WHERE id = ?
+    `).run(phase, JSON.stringify(history), now, id);
+    }
+    /** Get a single workflow run by ID */
+    getRun(id) {
+        const row = this.db.prepare(`SELECT * FROM workflow_runs WHERE id = ?`).get(id);
+        return row ? this.deserialize(row) : null;
+    }
+    /** Find the most recent active (running or paused) workflow run for a trigger */
+    getByTrigger(triggerId) {
+        const row = this.db.prepare(`
+      SELECT * FROM workflow_runs
+      WHERE trigger_id = ? AND status IN ('running', 'paused')
+      ORDER BY started_at DESC
+      LIMIT 1
+    `).get(triggerId);
+        return row ? this.deserialize(row) : null;
+    }
+    /** List all active (running or paused) workflow runs */
+    listActive() {
+        const rows = this.db.prepare(`
+      SELECT * FROM workflow_runs WHERE status IN ('running', 'paused') ORDER BY started_at DESC
+    `).all();
+        return rows.map((r) => this.deserialize(r));
+    }
+    /** List recent workflow runs, ordered by start time descending */
+    listRecent(limit = 20) {
+        const rows = this.db.prepare(`
+      SELECT * FROM workflow_runs ORDER BY started_at DESC LIMIT ?
+    `).all(limit);
+        return rows.map((r) => this.deserialize(r));
+    }
+    /**
+     * List workflow runs with pagination + filters. Returns the page slice
+     * AND the post-filter total so the dashboard knows how many remain.
+     *
+     * - sinceIso filters `started_at >= sinceIso` (used for the header date range).
+     * - workflowName filters by exact `workflow_name`.
+     * - statuses filters to one of the workflow statuses (`running`, `paused`,
+     *   `succeeded`, `failed`, `cancelled`). Used for the dashboard's "live"
+     *   filter, which maps to ['running','paused'].
+     */
+    list(opts = {}) {
+        const limit = opts.limit ?? 20;
+        const offset = opts.offset ?? 0;
+        const where = [];
+        const params = [];
+        if (opts.sinceIso) {
+            where.push("started_at >= ?");
+            params.push(opts.sinceIso);
+        }
+        if (opts.workflowName) {
+            where.push("workflow_name = ?");
+            params.push(opts.workflowName);
+        }
+        if (opts.statuses && opts.statuses.length > 0) {
+            where.push(`status IN (${opts.statuses.map(() => "?").join(",")})`);
+            params.push(...opts.statuses);
+        }
+        const whereClause = where.length > 0 ? `WHERE ${where.join(" AND ")}` : "";
+        const total = this.db
+            .prepare(`SELECT COUNT(*) as c FROM workflow_runs ${whereClause}`)
+            .get(...params).c;
+        // Explicit column list — the heavy JSON blobs (`context`, `scratch`)
+        // can each be many MB on long-running build runs and
+        // the dashboard list view doesn't read them. Returning them turned a
+        // 20-row page into a 14MB payload. The single-row endpoint
+        // (`getRun`) still uses `SELECT *` so the detail panel keeps
+        // the full row when the user picks one.
+        const rows = this.db
+            .prepare(`SELECT
+           id, workflow_name, trigger_id, repo, issue_number,
+           current_phase, phase_history, status,
+           restart_count, started_at, updated_at, finished_at
+         FROM workflow_runs
+         ${whereClause}
+         ORDER BY started_at DESC
+         LIMIT ? OFFSET ?`)
+            .all(...params, limit, offset);
+        return {
+            runs: rows.map((r) => this.deserialize(r)),
+            total,
+        };
+    }
+    /** Distinct workflow_name values, sorted alphabetically. */
+    distinctNames() {
+        const rows = this.db
+            .prepare(`SELECT DISTINCT workflow_name FROM workflow_runs ORDER BY workflow_name ASC`)
+            .all();
+        return rows.map((r) => r.workflow_name);
+    }
+    /**
+     * Mark a workflow run as finished. Plain status flip when called with just
+     * `{ error }`; when a `terminalMarker` is supplied (the runner's
+     * `on_success.set_phase`), the phase-history append and the status flip
+     * happen in ONE transaction so the dashboard never sees the terminal phase
+     * without the finished status, or vice versa.
+     */
+    finishRun(id, status, opts = {}) {
+        const apply = () => {
+            if (opts.terminalMarker) {
+                this.appendPhase(id, opts.terminalMarker.phase, {
+                    phase: opts.terminalMarker.phase,
+                    timestamp: new Date().toISOString(),
+                    success: true,
+                    summary: opts.terminalMarker.summary,
+                });
+            }
+            this.flipFinished(id, status, opts.error);
+        };
+        if (opts.terminalMarker) {
+            this.db.transaction(apply)();
+        }
+        else {
+            apply();
+        }
+    }
+    flipFinished(id, status, error) {
+        const now = new Date().toISOString();
+        this.db.prepare(`
+      UPDATE workflow_runs SET status = ?, finished_at = ?, updated_at = ?, context = CASE
+        WHEN ? IS NOT NULL THEN json_patch(COALESCE(context, '{}'), json_object('error', ?))
+        ELSE context
+      END WHERE id = ?
+    `).run(status, now, now, error ?? null, error ?? null, id);
+    }
+    /** Cancel a workflow run */
+    cancelRun(id) {
+        const now = new Date().toISOString();
+        this.db.prepare(`
+      UPDATE workflow_runs SET status = 'cancelled', updated_at = ?, finished_at = ? WHERE id = ?
+    `).run(now, now, id);
+    }
+    /** Pause a workflow run (waiting for approval) */
+    setPaused(id) {
+        const now = new Date().toISOString();
+        this.db.prepare(`
+      UPDATE workflow_runs SET status = 'paused', updated_at = ? WHERE id = ?
+    `).run(now, id);
+    }
+    /** Resume a paused workflow run (set back to running) */
+    setRunning(id) {
+        const now = new Date().toISOString();
+        this.db.prepare(`
+      UPDATE workflow_runs SET status = 'running', updated_at = ? WHERE id = ?
+    `).run(now, id);
+    }
+    /**
+     * Increment the restart counter and return the new value. Used by
+     * `resumeOrphanedWorkflows` to enforce a retry budget so a run that
+     * crashes the host (agent OOM, etc.) eventually self-terminates instead
+     * of being re-dispatched on every boot.
+     */
+    incrementRestartCount(id) {
+        const now = new Date().toISOString();
+        this.db.prepare(`
+      UPDATE workflow_runs
+      SET restart_count = COALESCE(restart_count, 0) + 1, updated_at = ?
+      WHERE id = ?
+    `).run(now, id);
+        const row = this.db.prepare(`SELECT restart_count FROM workflow_runs WHERE id = ?`)
+            .get(id);
+        return row?.restart_count ?? 0;
+    }
+    deserialize(row) {
+        return {
+            id: row.id,
+            workflowName: row.workflow_name,
+            triggerId: row.trigger_id,
+            repo: row.repo,
+            issueNumber: row.issue_number,
+            currentPhase: row.current_phase,
+            phaseHistory: JSON.parse(row.phase_history),
+            status: row.status,
+            context: row.context ? JSON.parse(row.context) : undefined,
+            scratch: row.scratch ? JSON.parse(row.scratch) : undefined,
+            restartCount: typeof row.restart_count === "number" ? row.restart_count : 0,
+            startedAt: row.started_at,
+            updatedAt: row.updated_at,
+            finishedAt: row.finished_at,
+        };
+    }
+    // ── Named atomic lifecycle operations ──────────────────────────
+    //
+    // Each wraps ONE better-sqlite3 transaction. The long-running re-dispatch
+    // (`dispatchWorkflow`) stays OUT of these — the caller dispatches after the
+    // transaction commits.
+    /**
+     * Resolve a socratic reply gate and resume the run, atomically: the reply
+     * gate flips `pending → approved` (recording the reply text), the caller's
+     * scratch patch merges in, and the run goes back to `running` — all in one
+     * transaction. A throw anywhere rolls the whole thing back, so the run can
+     * never be left `running` with its gate unresolved or its reply lost (the
+     * hazard issue #97 calls out).
+     *
+     * The reply-gate resolve is guarded by `kind = 'reply' AND status = 'pending'`
+     * (see {@link ApprovalStore.resolveReplyGate}); if it changes zero rows —
+     * because a racing reply already resolved the gate — this throws and the
+     * transaction aborts, which is the double-reply concurrency guard.
+     *
+     * The caller (`index.ts`) computes the explore-domain `scratch.socratic.qa`
+     * patch and passes it in; the generic store stays ignorant of that shape.
+     */
+    /**
+     * Pause a run for an approval gate, atomically: create the pending approval,
+     * optionally merge a scratch patch (loops persist their iteration state
+     * here), append the `waiting_approval` phase marker, and flip the run to
+     * `paused` — all in one transaction. Covers the standard post-phase gate,
+     * the reviewer-loop gate, and the interactive generic-loop gate.
+     *
+     * The marker is appended BEFORE the approval insert so that an insert
+     * failure provably rolls back the phase-history write (the injected
+     * ApprovalStore participates in the same transaction); ordering is invisible
+     * outside the transaction.
+     */
+    pauseForApproval(runId, approval, marker, scratchPatch) {
+        this.db.transaction(() => {
+            this.appendPhase(runId, marker.phase, {
+                phase: marker.phase,
+                timestamp: new Date().toISOString(),
+                success: true,
+                summary: marker.summary,
+            });
+            if (scratchPatch)
+                this.mergeScratch(runId, scratchPatch);
+            this.approvals.create(approval);
+            this.setPaused(runId);
+        })();
+    }
+    /**
+     * Approve a gate and resume its run, atomically. Reads the approval to find
+     * its run, records the `approved` response, and flips the run back to
+     * `running` in one transaction; returns the run so the caller can dispatch.
+     * Used by the GitHub/Slack path (`index.ts`), which validates the dispatch
+     * target BEFORE calling this so the flip to `running` is always followed by a
+     * dispatch. The dashboard path does NOT use this — it can't prove a dispatch
+     * will follow before responding, so it records the approval and lets
+     * `resumeWorkflow` flip the run only as part of an actual dispatch.
+     */
+    resolveGateAndResume(approvalId, responder) {
+        return this.db.transaction(() => {
+            const approval = this.approvals.getById(approvalId);
+            if (!approval)
+                throw new Error(`approval ${approvalId} not found`);
+            const changed = this.approvals.respond(approvalId, "approved", responder);
+            if (changed !== 1) {
+                throw new Error(`approval ${approvalId} is not pending (already resolved?)`);
+            }
+            this.setRunning(approval.workflowRunId);
+            return this.getRun(approval.workflowRunId);
+        })();
+    }
+    /**
+     * Reject a gate and fail its run, atomically: record the `rejected` response
+     * (with reason) and flip the run to `failed` in one transaction. Returns the
+     * run (or null if the approval's run was already gone).
+     */
+    resolveGateAndFail(approvalId, responder, reason) {
+        return this.db.transaction(() => {
+            const approval = this.approvals.getById(approvalId);
+            if (!approval)
+                throw new Error(`approval ${approvalId} not found`);
+            const changed = this.approvals.respond(approvalId, "rejected", responder, reason);
+            if (changed !== 1) {
+                throw new Error(`approval ${approvalId} is not pending (already resolved?)`);
+            }
+            this.flipFinished(approval.workflowRunId, "failed", `Rejected: ${reason || "no reason given"}`);
+            return this.getRun(approval.workflowRunId);
+        })();
+    }
+    resolveReplyGateAndResume(runId, approvalId, replyText, responder, scratchPatch) {
+        return this.db.transaction(() => {
+            const changed = this.approvals.resolveReplyGate(approvalId, replyText, responder);
+            if (changed !== 1) {
+                throw new Error(`reply gate ${approvalId} is not pending (already resolved?)`);
+            }
+            this.mergeScratch(runId, scratchPatch);
+            this.setRunning(runId);
+            return this.getRun(runId);
+        })();
+    }
+}
+//# sourceMappingURL=workflow-run-store.js.map

package/dist/state/workflow-run-store.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"workflow-run-store.js","sourceRoot":"","sources":["../../src/state/workflow-run-store.ts"],"names":[],"mappings":"AA6CA;;;;;;;;;;;;;;;;;;;;;;;GAuBG;AACH,MAAM,OAAO,gBAAgB;IACnB,EAAE,CAAoB;IACtB,SAAS,CAAgB;IAEjC,YAAY,EAAqB,EAAE,IAAkC;QACnE,IAAI,CAAC,EAAE,GAAG,EAAE,CAAC;QACb,IAAI,CAAC,SAAS,GAAG,IAAI,CAAC,SAAS,CAAC;IAClC,CAAC;IAED,kEAAkE;IAElE,uCAAuC;IACvC,SAAS,CAAC,GAAoD;QAC5D,MAAM,GAAG,GAAG,IAAI,IAAI,EAAE,CAAC,WAAW,EAAE,CAAC;QACrC,IAAI,CAAC,EAAE,CAAC,OAAO,CAAC;;;KAGf,CAAC,CAAC,GAAG,CACJ,GAAG,CAAC,EAAE,EACN,GAAG,CAAC,YAAY,EAChB,GAAG,CAAC,SAAS,EACb,GAAG,CAAC,IAAI,IAAI,IAAI,EAChB,GAAG,CAAC,WAAW,IAAI,IAAI,EACvB,GAAG,CAAC,YAAY,EAChB,GAAG,CAAC,MAAM,EACV,GAAG,CAAC,OAAO,CAAC,CAAC,CAAC,IAAI,CAAC,SAAS,CAAC,GAAG,CAAC,OAAO,CAAC,CAAC,CAAC,CAAC,IAAI,EAChD,GAAG,CAAC,OAAO,CAAC,CAAC,CAAC,IAAI,CAAC,SAAS,CAAC,GAAG,CAAC,OAAO,CAAC,CAAC,CAAC,CAAC,IAAI,EAChD,GAAG,CAAC,SAAS,EACb,GAAG,CACJ,CAAC;IACJ,CAAC;IAED;;;;;;;;OAQG;IACH,YAAY,CAAC,EAAU,EAAE,KAA8B;QACrD,MAAM,GAAG,GAAG,IAAI,IAAI,EAAE,CAAC,WAAW,EAAE,CAAC;QACrC,MAAM,GAAG,GAAG,IAAI,CAAC,EAAE;aAChB,OAAO,CAAC,gDAAgD,CAAC;aACzD,GAAG,CAAC,EAAE,CAA2C,CAAC;QACrD,IAAI,CAAC,GAAG;YAAE,OAAO;QACjB,MAAM,OAAO,GAAG,GAAG,CAAC,OAAO,CAAC,CAAC,CAAE,IAAI,CAAC,KAAK,CAAC,GAAG,CAAC,OAAO,CAA6B,CAAC,CAAC,CAAC,EAAE,CAAC;QACxF,MAAM,MAAM,GAAG,EAAE,GAAG,OAAO,EAAE,GAAG,KAAK,EAAE,CAAC;QACxC,yEAAyE;QACzE,2EAA2E;QAC3E,MAAM,UAAU,GAAG,IAAI,CAAC,SAAS,CAAC,MAAM,CAAC,CAAC;QAC1C,IAAI,CAAC,EAAE;aACJ,OAAO,CAAC,mEAAmE,CAAC;aAC5E,GAAG,CAAC,UAAU,EAAE,GAAG,EAAE,EAAE,CAAC,CAAC;IAC9B,CAAC;IAED;;;;;;OAMG;IACH,WAAW,CAAC,EAAU,EAAE,KAAa,EAAE,KAAwB;QAC7D,MAAM,GAAG,GAAG,IAAI,IAAI,EAAE,CAAC,WAAW,EAAE,CAAC;QACrC,MAAM,GAAG,GAAG,IAAI,CAAC,EAAE,CAAC,OAAO,CAAC,sDAAsD,CAAC,CAAC,GAAG,CAAC,EAAE,CAA0C,CAAC;QACrI,IAAI,CAAC,GAAG;YAAE,OAAO;QACjB,MAAM,OAAO,GAAwB,IAAI,CAAC,KAAK,CAAC,GAAG,CAAC,aAAa,CAAC,CAAC;QACnE,OAAO,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;QACpB,IAAI,CAAC,EAAE,CAAC,OAAO,CAAC;;KAEf,CAAC,CAAC,GAAG,CAAC,KAAK,EAAE,IAAI,CAAC,SAAS,CAAC,OAAO,CAAC,EAAE,GAAG,EAAE,EAAE,CAAC,CAAC;IAClD,CAAC;IAED,sCAAsC;IACtC,MAAM,CAAC,EAAU;QACf,MAAM,GAAG,GAAG,IAAI,CAAC,EAAE,CAAC,OAAO,CAAC,0CAA0C,CAAC,CAAC,GAAG,CAAC,EAAE,CAAwC,CAAC;QACvH,OAAO,GAAG,CAAC,CAAC,CAAC,IAAI,CAAC,WAAW,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC;IAC5C,CAAC;IAED,iFAAiF;IACjF,YAAY,CAAC,SAAiB;QAC5B,MAAM,GAAG,GAAG,IAAI,CAAC,EAAE,CAAC,OAAO,CAAC;;;;;KAK3B,CAAC,CAAC,GAAG,CAAC,SAAS,CAAwC,CAAC;QACzD,OAAO,GAAG,CAAC,CAAC,CAAC,IAAI,CAAC,WAAW,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC;IAC5C,CAAC;IAED,wDAAwD;IACxD,UAAU;QACR,MAAM,IAAI,GAAG,IAAI,CAAC,EAAE,CAAC,OAAO,CAAC;;KAE5B,CAAC,CAAC,GAAG,EAA+B,CAAC;QACtC,OAAO,IAAI,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,IAAI,CAAC,WAAW,CAAC,CAAC,CAAC,CAAC,CAAC;IAC9C,CAAC;IAED,kEAAkE;IAClE,UAAU,CAAC,KAAK,GAAG,EAAE;QACnB,MAAM,IAAI,GAAG,IAAI,CAAC,EAAE,CAAC,OAAO,CAAC;;KAE5B,CAAC,CAAC,GAAG,CAAC,KAAK,CAA8B,CAAC;QAC3C,OAAO,IAAI,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,IAAI,CAAC,WAAW,CAAC,CAAC,CAAC,CAAC,CAAC;IAC9C,CAAC;IAED;;;;;;;;;OASG;IACH,IAAI,CAAC,OAMD,EAAE;QACJ,MAAM,KAAK,GAAG,IAAI,CAAC,KAAK,IAAI,EAAE,CAAC;QAC/B,MAAM,MAAM,GAAG,IAAI,CAAC,MAAM,IAAI,CAAC,CAAC;QAEhC,MAAM,KAAK,GAAa,EAAE,CAAC;QAC3B,MAAM,MAAM,GAAc,EAAE,CAAC;QAC7B,IAAI,IAAI,CAAC,QAAQ,EAAE,CAAC;YAClB,KAAK,CAAC,IAAI,CAAC,iBAAiB,CAAC,CAAC;YAC9B,MAAM,CAAC,IAAI,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC;QAC7B,CAAC;QACD,IAAI,IAAI,CAAC,YAAY,EAAE,CAAC;YACtB,KAAK,CAAC,IAAI,CAAC,mBAAmB,CAAC,CAAC;YAChC,MAAM,CAAC,IAAI,CAAC,IAAI,CAAC,YAAY,CAAC,CAAC;QACjC,CAAC;QACD,IAAI,IAAI,CAAC,QAAQ,IAAI,IAAI,CAAC,QAAQ,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;YAC9C,KAAK,CAAC,IAAI,CAAC,cAAc,IAAI,CAAC,QAAQ,CAAC,GAAG,CAAC,GAAG,EAAE,CAAC,GAAG,CAAC,CAAC,IAAI,CAAC,GAAG,CAAC,GAAG,CAAC,CAAC;YACpE,MAAM,CAAC,IAAI,CAAC,GAAG,IAAI,CAAC,QAAQ,CAAC,CAAC;QAChC,CAAC;QACD,MAAM,WAAW,GAAG,KAAK,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC,CAAC,SAAS,KAAK,CAAC,IAAI,CAAC,OAAO,CAAC,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC;QAE3E,MAAM,KAAK,GACT,IAAI,CAAC,EAAE;aACJ,OAAO,CAAC,2CAA2C,WAAW,EAAE,CAAC;aACjE,GAAG,CAAC,GAAG,MAAM,CACjB,CAAC,CAAC,CAAC;QAEJ,qEAAqE;QACrE,qDAAqD;QACrD,qEAAqE;QACrE,2DAA2D;QAC3D,6DAA6D;QAC7D,wCAAwC;QACxC,MAAM,IAAI,GAAG,IAAI,CAAC,EAAE;aACjB,OAAO,CACN;;;;;WAKG,WAAW;;0BAEI,CACnB;aACA,GAAG,CAAC,GAAG,MAAM,EAAE,KAAK,EAAE,MAAM,CAA8B,CAAC;QAE9D,OAAO;YACL,IAAI,EAAE,IAAI,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,IAAI,CAAC,WAAW,CAAC,CAAC,CAAC,CAAC;YAC1C,KAAK;SACN,CAAC;IACJ,CAAC;IAED,4DAA4D;IAC5D,aAAa;QACX,MAAM,IAAI,GAAG,IAAI,CAAC,EAAE;aACjB,OAAO,CAAC,6EAA6E,CAAC;aACtF,GAAG,EAAiC,CAAC;QACxC,OAAO,IAAI,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,aAAa,CAAC,CAAC;IAC1C,CAAC;IAED;;;;;;OAMG;IACH,SAAS,CACP,EAAU,EACV,MAA4C,EAC5C,OAAyD,EAAE;QAE3D,MAAM,KAAK,GAAG,GAAG,EAAE;YACjB,IAAI,IAAI,CAAC,cAAc,EAAE,CAAC;gBACxB,IAAI,CAAC,WAAW,CAAC,EAAE,EAAE,IAAI,CAAC,cAAc,CAAC,KAAK,EAAE;oBAC9C,KAAK,EAAE,IAAI,CAAC,cAAc,CAAC,KAAK;oBAChC,SAAS,EAAE,IAAI,IAAI,EAAE,CAAC,WAAW,EAAE;oBACnC,OAAO,EAAE,IAAI;oBACb,OAAO,EAAE,IAAI,CAAC,cAAc,CAAC,OAAO;iBACrC,CAAC,CAAC;YACL,CAAC;YACD,IAAI,CAAC,YAAY,CAAC,EAAE,EAAE,MAAM,EAAE,IAAI,CAAC,KAAK,CAAC,CAAC;QAC5C,CAAC,CAAC;QACF,IAAI,IAAI,CAAC,cAAc,EAAE,CAAC;YACxB,IAAI,CAAC,EAAE,CAAC,WAAW,CAAC,KAAK,CAAC,EAAE,CAAC;QAC/B,CAAC;aAAM,CAAC;YACN,KAAK,EAAE,CAAC;QACV,CAAC;IACH,CAAC;IAEO,YAAY,CAAC,EAAU,EAAE,MAA4C,EAAE,KAAc;QAC3F,MAAM,GAAG,GAAG,IAAI,IAAI,EAAE,CAAC,WAAW,EAAE,CAAC;QACrC,IAAI,CAAC,EAAE,CAAC,OAAO,CAAC;;;;;KAKf,CAAC,CAAC,GAAG,CAAC,MAAM,EAAE,GAAG,EAAE,GAAG,EAAE,KAAK,IAAI,IAAI,EAAE,KAAK,IAAI,IAAI,EAAE,EAAE,CAAC,CAAC;IAC7D,CAAC;IAED,4BAA4B;IAC5B,SAAS,CAAC,EAAU;QAClB,MAAM,GAAG,GAAG,IAAI,IAAI,EAAE,CAAC,WAAW,EAAE,CAAC;QACrC,IAAI,CAAC,EAAE,CAAC,OAAO,CAAC;;KAEf,CAAC,CAAC,GAAG,CAAC,GAAG,EAAE,GAAG,EAAE,EAAE,CAAC,CAAC;IACvB,CAAC;IAED,kDAAkD;IAClD,SAAS,CAAC,EAAU;QAClB,MAAM,GAAG,GAAG,IAAI,IAAI,EAAE,CAAC,WAAW,EAAE,CAAC;QACrC,IAAI,CAAC,EAAE,CAAC,OAAO,CAAC;;KAEf,CAAC,CAAC,GAAG,CAAC,GAAG,EAAE,EAAE,CAAC,CAAC;IAClB,CAAC;IAED,yDAAyD;IACzD,UAAU,CAAC,EAAU;QACnB,MAAM,GAAG,GAAG,IAAI,IAAI,EAAE,CAAC,WAAW,EAAE,CAAC;QACrC,IAAI,CAAC,EAAE,CAAC,OAAO,CAAC;;KAEf,CAAC,CAAC,GAAG,CAAC,GAAG,EAAE,EAAE,CAAC,CAAC;IAClB,CAAC;IAED;;;;;OAKG;IACH,qBAAqB,CAAC,EAAU;QAC9B,MAAM,GAAG,GAAG,IAAI,IAAI,EAAE,CAAC,WAAW,EAAE,CAAC;QACrC,IAAI,CAAC,EAAE,CAAC,OAAO,CAAC;;;;KAIf,CAAC,CAAC,GAAG,CAAC,GAAG,EAAE,EAAE,CAAC,CAAC;QAChB,MAAM,GAAG,GAAG,IAAI,CAAC,EAAE,CAAC,OAAO,CAAC,sDAAsD,CAAC;aAChF,GAAG,CAAC,EAAE,CAA0C,CAAC;QACpD,OAAO,GAAG,EAAE,aAAa,IAAI,CAAC,CAAC;IACjC,CAAC;IAEO,WAAW,CAAC,GAA4B;QAC9C,OAAO;YACL,EAAE,EAAE,GAAG,CAAC,EAAY;YACpB,YAAY,EAAE,GAAG,CAAC,aAAuB;YACzC,SAAS,EAAE,GAAG,CAAC,UAAoB;YACnC,IAAI,EAAE,GAAG,CAAC,IAA0B;YACpC,WAAW,EAAE,GAAG,CAAC,YAAkC;YACnD,YAAY,EAAE,GAAG,CAAC,aAAuB;YACzC,YAAY,EAAE,IAAI,CAAC,KAAK,CAAC,GAAG,CAAC,aAAuB,CAAwB;YAC5E,MAAM,EAAE,GAAG,CAAC,MAA+B;YAC3C,OAAO,EAAE,GAAG,CAAC,OAAO,CAAC,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,GAAG,CAAC,OAAiB,CAA4B,CAAC,CAAC,CAAC,SAAS;YAC/F,OAAO,EAAE,GAAG,CAAC,OAAO,CAAC,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,GAAG,CAAC,OAAiB,CAA4B,CAAC,CAAC,CAAC,SAAS;YAC/F,YAAY,EAAE,OAAO,GAAG,CAAC,aAAa,KAAK,QAAQ,CAAC,CAAC,CAAC,GAAG,CAAC,aAAa,CAAC,CAAC,CAAC,CAAC;YAC3E,SAAS,EAAE,GAAG,CAAC,UAAoB;YACnC,SAAS,EAAE,GAAG,CAAC,UAAoB;YACnC,UAAU,EAAE,GAAG,CAAC,WAAiC;SAClD,CAAC;IACJ,CAAC;IAED,kEAAkE;IAClE,EAAE;IACF,0EAA0E;IAC1E,4EAA4E;IAC5E,uBAAuB;IAEvB;;;;;;;;;;;;;;;OAeG;IACH;;;;;;;;;;;OAWG;IACH,gBAAgB,CACd,KAAa,EACb,QAAgD,EAChD,MAAmB,EACnB,YAAsC;QAEtC,IAAI,CAAC,EAAE,CAAC,WAAW,CAAC,GAAG,EAAE;YACvB,IAAI,CAAC,WAAW,CAAC,KAAK,EAAE,MAAM,CAAC,KAAK,EAAE;gBACpC,KAAK,EAAE,MAAM,CAAC,KAAK;gBACnB,SAAS,EAAE,IAAI,IAAI,EAAE,CAAC,WAAW,EAAE;gBACnC,OAAO,EAAE,IAAI;gBACb,OAAO,EAAE,MAAM,CAAC,OAAO;aACxB,CAAC,CAAC;YACH,IAAI,YAAY;gBAAE,IAAI,CAAC,YAAY,CAAC,KAAK,EAAE,YAAY,CAAC,CAAC;YACzD,IAAI,CAAC,SAAS,CAAC,MAAM,CAAC,QAAQ,CAAC,CAAC;YAChC,IAAI,CAAC,SAAS,CAAC,KAAK,CAAC,CAAC;QACxB,CAAC,CAAC,EAAE,CAAC;IACP,CAAC;IAED;;;;;;;;;OASG;IACH,oBAAoB,CAAC,UAAkB,EAAE,SAAiB;QACxD,OAAO,IAAI,CAAC,EAAE,CAAC,WAAW,CAAC,GAAG,EAAE;YAC9B,MAAM,QAAQ,GAAG,IAAI,CAAC,SAAS,CAAC,OAAO,CAAC,UAAU,CAAC,CAAC;YACpD,IAAI,CAAC,QAAQ;gBAAE,MAAM,IAAI,KAAK,CAAC,YAAY,UAAU,YAAY,CAAC,CAAC;YACnE,MAAM,OAAO,GAAG,IAAI,CAAC,SAAS,CAAC,OAAO,CAAC,UAAU,EAAE,UAAU,EAAE,SAAS,CAAC,CAAC;YAC1E,IAAI,OAAO,KAAK,CAAC,EAAE,CAAC;gBAClB,MAAM,IAAI,KAAK,CAAC,YAAY,UAAU,qCAAqC,CAAC,CAAC;YAC/E,CAAC;YACD,IAAI,CAAC,UAAU,CAAC,QAAQ,CAAC,aAAa,CAAC,CAAC;YACxC,OAAO,IAAI,CAAC,MAAM,CAAC,QAAQ,CAAC,aAAa,CAAC,CAAC;QAC7C,CAAC,CAAC,EAAE,CAAC;IACP,CAAC;IAED;;;;OAIG;IACH,kBAAkB,CAAC,UAAkB,EAAE,SAAiB,EAAE,MAAe;QACvE,OAAO,IAAI,CAAC,EAAE,CAAC,WAAW,CAAC,GAAG,EAAE;YAC9B,MAAM,QAAQ,GAAG,IAAI,CAAC,SAAS,CAAC,OAAO,CAAC,UAAU,CAAC,CAAC;YACpD,IAAI,CAAC,QAAQ;gBAAE,MAAM,IAAI,KAAK,CAAC,YAAY,UAAU,YAAY,CAAC,CAAC;YACnE,MAAM,OAAO,GAAG,IAAI,CAAC,SAAS,CAAC,OAAO,CAAC,UAAU,EAAE,UAAU,EAAE,SAAS,EAAE,MAAM,CAAC,CAAC;YAClF,IAAI,OAAO,KAAK,CAAC,EAAE,CAAC;gBAClB,MAAM,IAAI,KAAK,CAAC,YAAY,UAAU,qCAAqC,CAAC,CAAC;YAC/E,CAAC;YACD,IAAI,CAAC,YAAY,CAAC,QAAQ,CAAC,aAAa,EAAE,QAAQ,EAAE,aAAa,MAAM,IAAI,iBAAiB,EAAE,CAAC,CAAC;YAChG,OAAO,IAAI,CAAC,MAAM,CAAC,QAAQ,CAAC,aAAa,CAAC,CAAC;QAC7C,CAAC,CAAC,EAAE,CAAC;IACP,CAAC;IAED,yBAAyB,CACvB,KAAa,EACb,UAAkB,EAClB,SAAiB,EACjB,SAAiB,EACjB,YAAqC;QAErC,OAAO,IAAI,CAAC,EAAE,CAAC,WAAW,CAAC,GAAG,EAAE;YAC9B,MAAM,OAAO,GAAG,IAAI,CAAC,SAAS,CAAC,gBAAgB,CAAC,UAAU,EAAE,SAAS,EAAE,SAAS,CAAC,CAAC;YAClF,IAAI,OAAO,KAAK,CAAC,EAAE,CAAC;gBAClB,MAAM,IAAI,KAAK,CAAC,cAAc,UAAU,qCAAqC,CAAC,CAAC;YACjF,CAAC;YACD,IAAI,CAAC,YAAY,CAAC,KAAK,EAAE,YAAY,CAAC,CAAC;YACvC,IAAI,CAAC,UAAU,CAAC,KAAK,CAAC,CAAC;YACvB,OAAO,IAAI,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC;QAC5B,CAAC,CAAC,EAAE,CAAC;IACP,CAAC;CACF"}

package/dist/state/workflow-run-store.test.d.ts

@@ -0,0 +1 @@
+export {};

package/dist/state/workflow-run-store.test.js

@@ -0,0 +1,264 @@
+import { describe, it, expect, beforeEach, afterEach } from "vitest";
+import Database from "better-sqlite3";
+import { randomUUID } from "crypto";
+import { StateDb } from "./db.js";
+import { migrate } from "./migrate.js";
+import { ApprovalStore } from "./approval-store.js";
+import { WorkflowRunStore } from "./workflow-run-store.js";
+let db;
+beforeEach(() => {
+    db = new StateDb(":memory:");
+});
+afterEach(() => {
+    db.close();
+});
+/** Create a fresh run and return its id. */
+function makeRun(overrides = {}) {
+    const id = randomUUID();
+    db.runs.createRun({
+        id,
+        workflowName: "explore",
+        triggerId: `slack:${id}`,
+        currentPhase: "socratic",
+        status: "running",
+        startedAt: new Date().toISOString(),
+        ...overrides,
+    });
+    return id;
+}
+describe("pauseForApproval", () => {
+    it("creates the approval, appends the marker, merges scratch, and pauses — in one step", () => {
+        const runId = makeRun();
+        const approvalId = randomUUID();
+        db.runs.pauseForApproval(runId, {
+            id: approvalId,
+            workflowRunId: runId,
+            gate: "post_architect",
+            summary: "Plan ready",
+            kind: "approve",
+            artifact: "architect-plan.md",
+            createdAt: new Date().toISOString(),
+        }, { phase: "waiting_approval", summary: "Waiting for approval: post_architect" }, { socratic: { iteration: 2 } });
+        const run = db.runs.getRun(runId);
+        expect(run.status).toBe("paused");
+        expect(run.currentPhase).toBe("waiting_approval");
+        expect(run.phaseHistory.at(-1).phase).toBe("waiting_approval");
+        expect(run.scratch).toEqual({ socratic: { iteration: 2 } });
+        const approval = db.approvals.getById(approvalId);
+        expect(approval.status).toBe("pending");
+        expect(approval.gate).toBe("post_architect");
+        expect(approval.artifact).toBe("architect-plan.md");
+    });
+    it("rolls back the phase-history append when the approval store throws (injected collaborator)", () => {
+        // Build a store stack on a raw shared connection so we can inject a fake
+        // ApprovalStore whose create() throws as the last txn step.
+        const raw = new Database(":memory:");
+        migrate(raw);
+        const realApprovals = new ApprovalStore(raw);
+        const seed = new WorkflowRunStore(raw, { approvals: realApprovals });
+        const runId = randomUUID();
+        seed.createRun({
+            id: runId,
+            workflowName: "build",
+            triggerId: "owner/repo#1",
+            currentPhase: "architect",
+            status: "running",
+            startedAt: new Date().toISOString(),
+        });
+        const throwingApprovals = {
+            create() {
+                throw new Error("approval insert failed");
+            },
+        };
+        const runs = new WorkflowRunStore(raw, { approvals: throwingApprovals });
+        expect(() => runs.pauseForApproval(runId, {
+            id: randomUUID(),
+            workflowRunId: runId,
+            gate: "post_architect",
+            summary: "Plan ready",
+            createdAt: new Date().toISOString(),
+        }, { phase: "waiting_approval" })).toThrow("approval insert failed");
+        // The appendPhase that ran before the throwing collaborator must be rolled
+        // back: the run is still running with empty phase history.
+        const run = seed.getRun(runId);
+        expect(run.status).toBe("running");
+        expect(run.phaseHistory).toEqual([]);
+        raw.close();
+    });
+});
+describe("finishRun with a terminal marker", () => {
+    it("appends the on_success phase marker and flips status in one step", () => {
+        const runId = makeRun();
+        db.runs.finishRun(runId, "succeeded", { terminalMarker: { phase: "done", summary: "PR #5" } });
+        const run = db.runs.getRun(runId);
+        expect(run.status).toBe("succeeded");
+        expect(run.finishedAt).toBeTruthy();
+        expect(run.currentPhase).toBe("done");
+        const last = run.phaseHistory.at(-1);
+        expect(last.phase).toBe("done");
+        expect(last.summary).toBe("PR #5");
+        expect(last.success).toBe(true);
+    });
+    it("plain finish (no marker) flips status without touching phase history", () => {
+        const runId = makeRun();
+        db.runs.finishRun(runId, "failed", { error: "boom" });
+        const run = db.runs.getRun(runId);
+        expect(run.status).toBe("failed");
+        expect(run.phaseHistory).toEqual([]);
+        expect(run.context).toEqual({ error: "boom" });
+    });
+});
+describe("resolveGateAndResume — approve path", () => {
+    it("approves the gate and sets the run running, returning the run", () => {
+        const runId = makeRun({ status: "paused" });
+        const approvalId = randomUUID();
+        db.approvals.create({
+            id: approvalId,
+            workflowRunId: runId,
+            gate: "post_architect",
+            summary: "Plan ready",
+            createdAt: new Date().toISOString(),
+        });
+        const run = db.runs.resolveGateAndResume(approvalId, "bob");
+        expect(run.id).toBe(runId);
+        expect(run.status).toBe("running");
+        const approval = db.approvals.getById(approvalId);
+        expect(approval.status).toBe("approved");
+        expect(approval.respondedBy).toBe("bob");
+    });
+    it("throws on an unknown approval id", () => {
+        expect(() => db.runs.resolveGateAndResume("no-such-approval", "bob")).toThrow();
+    });
+    it("does not resume a stale approval that was already resolved", () => {
+        const runId = makeRun({ status: "paused" });
+        const approvalId = randomUUID();
+        db.approvals.create({
+            id: approvalId,
+            workflowRunId: runId,
+            gate: "post_architect",
+            summary: "Plan ready",
+            createdAt: new Date().toISOString(),
+        });
+        db.runs.resolveGateAndFail(approvalId, "carol", "plan incomplete");
+        expect(() => db.runs.resolveGateAndResume(approvalId, "bob")).toThrow("not pending");
+        expect(db.runs.getRun(runId).status).toBe("failed");
+        expect(db.approvals.getById(approvalId).status).toBe("rejected");
+    });
+});
+describe("resolveGateAndFail — reject path", () => {
+    it("does not fail a stale approval that was already approved", () => {
+        const runId = makeRun({ status: "paused" });
+        const approvalId = randomUUID();
+        db.approvals.create({
+            id: approvalId,
+            workflowRunId: runId,
+            gate: "post_architect",
+            summary: "Plan ready",
+            createdAt: new Date().toISOString(),
+        });
+        db.runs.resolveGateAndResume(approvalId, "bob");
+        expect(() => db.runs.resolveGateAndFail(approvalId, "carol", "too late")).toThrow("not pending");
+        expect(db.runs.getRun(runId).status).toBe("running");
+        expect(db.approvals.getById(approvalId).status).toBe("approved");
+    });
+    it("rejects the gate and fails the run", () => {
+        const runId = makeRun({ status: "paused" });
+        const approvalId = randomUUID();
+        db.approvals.create({
+            id: approvalId,
+            workflowRunId: runId,
+            gate: "post_architect",
+            summary: "Plan ready",
+            createdAt: new Date().toISOString(),
+        });
+        const run = db.runs.resolveGateAndFail(approvalId, "carol", "plan incomplete");
+        expect(run.id).toBe(runId);
+        expect(run.status).toBe("failed");
+        const approval = db.approvals.getById(approvalId);
+        expect(approval.status).toBe("rejected");
+        expect(approval.respondedBy).toBe("carol");
+        expect(approval.response).toBe("plan incomplete");
+        expect(db.runs.getRun(runId).context).toEqual({ error: "Rejected: plan incomplete" });
+    });
+    it("records a fallback error annotation when rejection has no reason", () => {
+        const runId = makeRun({ status: "paused" });
+        const approvalId = randomUUID();
+        db.approvals.create({
+            id: approvalId,
+            workflowRunId: runId,
+            gate: "post_architect",
+            summary: "Plan ready",
+            createdAt: new Date().toISOString(),
+        });
+        const run = db.runs.resolveGateAndFail(approvalId, "carol");
+        expect(run.status).toBe("failed");
+        expect(run.context).toEqual({ error: "Rejected: no reason given" });
+    });
+});
+describe("resolveReplyGateAndResume — the socratic explore-reply atomic op", () => {
+    it("resolves the reply gate, merges scratch, and sets the run running in one step", () => {
+        const runId = makeRun({ status: "paused" });
+        const approvalId = randomUUID();
+        db.approvals.create({
+            id: approvalId,
+            workflowRunId: runId,
+            gate: "socratic_1",
+            summary: "What problem are we solving?",
+            kind: "reply",
+            createdAt: new Date().toISOString(),
+        });
+        const scratchPatch = { socratic: { qa: [{ question: "Q1", answer: "A1" }] } };
+        const run = db.runs.resolveReplyGateAndResume(runId, approvalId, "A1", "alice", scratchPatch);
+        // Returns the resumed run
+        expect(run).not.toBeNull();
+        expect(run.id).toBe(runId);
+        expect(run.status).toBe("running");
+        // Gate resolved with the reply text recorded
+        const approval = db.approvals.getById(approvalId);
+        expect(approval.status).toBe("approved");
+        expect(approval.response).toBe("A1");
+        expect(approval.respondedBy).toBe("alice");
+        // Scratch merged
+        const reloaded = db.runs.getRun(runId);
+        expect(reloaded.status).toBe("running");
+        expect(reloaded.scratch).toEqual(scratchPatch);
+    });
+    it("double-reply concurrency guard: a second resolve throws and leaves the run paused", () => {
+        const runId = makeRun({ status: "paused" });
+        const approvalId = randomUUID();
+        db.approvals.create({
+            id: approvalId,
+            workflowRunId: runId,
+            gate: "socratic_1",
+            summary: "Q",
+            kind: "reply",
+            createdAt: new Date().toISOString(),
+        });
+        db.runs.resolveReplyGateAndResume(runId, approvalId, "first", "alice", {});
+        db.runs.setPaused(runId); // pretend it paused again on the next iteration
+        // A racing second reply against the already-resolved gate must not resume.
+        expect(() => db.runs.resolveReplyGateAndResume(runId, approvalId, "second", "bob", {})).toThrow();
+        expect(db.runs.getRun(runId).status).toBe("paused");
+    });
+    it("rolls back the gate resolution when the scratch patch is not serializable", () => {
+        const runId = makeRun({ status: "paused" });
+        const approvalId = randomUUID();
+        db.approvals.create({
+            id: approvalId,
+            workflowRunId: runId,
+            gate: "socratic_1",
+            summary: "Q",
+            kind: "reply",
+            createdAt: new Date().toISOString(),
+        });
+        // A BigInt makes JSON.stringify throw mid-transaction (natural poison input).
+        const poison = { socratic: { n: BigInt(1) } };
+        expect(() => db.runs.resolveReplyGateAndResume(runId, approvalId, "A1", "alice", poison)).toThrow();
+        // Nothing applied: gate still pending, run still paused, scratch untouched.
+        expect(db.approvals.getById(approvalId).status).toBe("pending");
+        const reloaded = db.runs.getRun(runId);
+        expect(reloaded.status).toBe("paused");
+        expect(reloaded.scratch).toBeUndefined();
+    });
+});
+//# sourceMappingURL=workflow-run-store.test.js.map