isaacscript-common 30.11.6 → 30.11.8

package/dist/src/functions/random.lua

@@ -7,8 +7,8 @@ local ____rng = require("src.functions.rng")
 local getRandomSeed = ____rng.getRandomSeed
 local isRNG = ____rng.isRNG
 local newRNG = ____rng.newRNG
---- This returns a random float between 0 and 1. It is inclusive on the low end, but exclusive on the
--- high end. (This is because the `RNG.RandomFloat` method will never return a value of exactly 1.)
+--- Returns a random float between 0 and 1. It is inclusive on the low end, but exclusive on the high
+-- end. (This is because the `RNG.RandomFloat` method will never return a value of exactly 1.)
 -- 
 -- @param seedOrRNG Optional. The `Seed` or `RNG` object to use. If an `RNG` object is provided, the
 -- `RNG.Next` method will be called. Default is `getRandomSeed()`.
@@ -19,7 +19,7 @@ function ____exports.getRandom(self, seedOrRNG)
     local rng = isRNG(nil, seedOrRNG) and seedOrRNG or newRNG(nil, seedOrRNG)
     return rng:RandomFloat()
 end
---- This returns a random float between min and max.
+--- Returns a random float between min and max.
 -- 
 -- For example:
 -- 
@@ -43,7 +43,7 @@ function ____exports.getRandomFloat(self, min, max, seedOrRNG)
     end
     return min + ____exports.getRandom(nil, seedOrRNG) * (max - min)
 end
---- This returns a random integer between min and max. It is inclusive on both ends.
+--- Returns a random integer between min and max. It is inclusive on both ends.
 -- 
 -- Note that this function will run the `Next` method on the `RNG` object before returning the
 -- random number.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "isaacscript-common",
-  "version": "30.11.6",
+  "version": "30.11.8",
   "description": "Helper functions and features for IsaacScript mods.",
   "keywords": [
     "isaac",

package/src/classes/features/other/FlyingDetection.ts

@@ -32,10 +32,12 @@ export class FlyingDetection extends Feature {
   public hasFlyingTemporaryEffect(player: EntityPlayer): boolean {
     const effects = player.GetEffects();
 
-    // - Hanged Man card gives a Transcendence temporary effect.
+    // - We specify true to the `getFlyingCollectibles` function since conditional flying
+    //   collectibles will only grant a temporary effect if their condition is activated.
+    // - The Hanged Man card gives a Transcendence temporary effect.
     // - Pinking Shears gives a Transcendence temporary effect.
     const flyingCollectibles =
-      this.moddedElementSets.getFlyingCollectibles(false);
+      this.moddedElementSets.getFlyingCollectibles(true);
     for (const collectibleType of flyingCollectibles) {
       if (effects.HasCollectibleEffect(collectibleType)) {
         return true;

package/src/functions/random.ts

@@ -2,8 +2,8 @@ import { ReadonlySet } from "../types/ReadonlySet";
 import { getRandomSeed, isRNG, newRNG } from "./rng";
 
 /**
- * This returns a random float between 0 and 1. It is inclusive on the low end, but exclusive on the
- * high end. (This is because the `RNG.RandomFloat` method will never return a value of exactly 1.)
+ * Returns a random float between 0 and 1. It is inclusive on the low end, but exclusive on the high
+ * end. (This is because the `RNG.RandomFloat` method will never return a value of exactly 1.)
  *
  * @param seedOrRNG Optional. The `Seed` or `RNG` object to use. If an `RNG` object is provided, the
  *                  `RNG.Next` method will be called. Default is `getRandomSeed()`.
@@ -14,7 +14,7 @@ export function getRandom(seedOrRNG: Seed | RNG = getRandomSeed()): float {
 }
 
 /**
- * This returns a random float between min and max.
+ * Returns a random float between min and max.
  *
  * For example:
  *
@@ -44,7 +44,7 @@ export function getRandomFloat(
 }
 
 /**
- * This returns a random integer between min and max. It is inclusive on both ends.
+ * Returns a random integer between min and max. It is inclusive on both ends.
  *
  * Note that this function will run the `Next` method on the `RNG` object before returning the
  * random number.