iotagent-node-lib 2.17.0 → 2.20.0

package/test/unit/ngsiv2/plugins/multientity-plugin_test.js

@@ -27,6 +27,7 @@
 
 const iotAgentLib = require('../../../../lib/fiware-iotagent-lib');
 const utils = require('../../../tools/utils');
+const request = utils.request;
 const should = require('should');
 const logger = require('logops');
 const nock = require('nock');
@@ -242,6 +243,46 @@ const iotAgentConfig = {
                 }
             ]
         },
+        WeatherStation9Jexl: {
+            commands: [],
+            type: 'WeatherStation',
+            expressionLanguage: 'jexl',
+            lazy: [],
+            static: [
+                {
+                    name: 'st1',
+                    type: 'Number',
+                    value: 1
+                },
+                {
+                    name: 'st2',
+                    type: 'Number',
+                    value: 2
+                }
+            ],
+            active: [
+                {
+                    object_id: 'v1',
+                    name: 'vol',
+                    expression: 'st1 * 100',
+                    type: 'Number',
+                    entity_name: 'WeatherStation1'
+                },
+                {
+                    object_id: 'v2',
+                    name: 'vol',
+                    expression: 'st2 * 100',
+                    type: 'Number',
+                    entity_name: 'WeatherStation2'
+                },
+                {
+                    object_id: 'v',
+                    name: 'vol',
+                    expression: 'v * 100',
+                    type: 'Number'
+                }
+            ]
+        },
         Sensor001: {
             commands: [],
             type: 'Sensor',
@@ -293,6 +334,187 @@ const iotAgentConfig = {
             ],
             type: 'SensorCommand',
             lazy: []
+        },
+        WrongStation: {
+            commands: [],
+            type: 'WrongStation',
+            expressionLanguage: 'jexl',
+            lazy: [],
+            active: [
+                {
+                    object_id: 'v1',
+                    name: 'type',
+                    type: 'string',
+                    entity_name: 'WrongStation1'
+                },
+                {
+                    object_id: 'v2',
+                    name: 'id',
+                    type: 'string',
+                    entity_name: 'WrongStation1'
+                },
+                {
+                    object_id: 'v',
+                    name: 'vol',
+                    type: 'Number',
+                    entity_name: 'WrongStation1'
+                }
+            ]
+        },
+        SharedIds1: {
+            commands: [],
+            type: 'ShareStation',
+            lazy: [],
+            active: [
+                {
+                    object_id: 'v1',
+                    name: 'volt1',
+                    type: 'Number',
+                    entity_name: 'WeatherStation1',
+                    entity_type: 'Type1'
+                },
+                {
+                    object_id: 'v2',
+                    name: 'volt2',
+                    type: 'Number',
+                    entity_name: 'WeatherStation1',
+                    entity_type: 'Type2'
+                },
+                {
+                    object_id: 'v3',
+                    name: 'extravolt2',
+                    type: 'Number',
+                    entity_name: 'WeatherStation1',
+                    entity_type: 'Type2'
+                },
+                {
+                    object_id: 'v',
+                    name: 'vol',
+                    type: 'Number'
+                }
+            ]
+        },
+        SharedIds2: {
+            commands: [],
+            type: 'ShareStation',
+            lazy: [],
+            active: [
+                {
+                    object_id: 'v1',
+                    name: 'vol',
+                    type: 'Number',
+                    entity_name: 'WeatherStation1',
+                    entity_type: 'Type1'
+                },
+                {
+                    object_id: 'v2',
+                    name: 'vol',
+                    type: 'Number',
+                    entity_name: 'WeatherStation1',
+                    entity_type: 'Type2'
+                },
+                {
+                    object_id: 'v3',
+                    name: 'extravol',
+                    type: 'Number',
+                    entity_name: 'WeatherStation1',
+                    entity_type: 'Type2'
+                },
+                {
+                    object_id: 'v',
+                    name: 'vol',
+                    type: 'Number'
+                }
+            ]
+        },
+        SharedIds3: {
+            commands: [],
+            type: 'ShareStation',
+            expressionLanguage: 'jexl',
+            lazy: [],
+            active: [
+                {
+                    object_id: 'fakev1',
+                    expression: 'v',
+                    name: 'vol',
+                    type: 'Number',
+                    entity_name: 'WeatherStation1',
+                    entity_type: 'Type1'
+                },
+                {
+                    object_id: 'fakev2',
+                    expression: 'v',
+                    name: 'vol',
+                    type: 'Number',
+                    entity_name: 'WeatherStation1',
+                    entity_type: 'Type2'
+                },
+                {
+                    object_id: 'fakev3',
+                    expression: 'v',
+                    name: 'extravol',
+                    type: 'Number',
+                    entity_name: 'WeatherStation1',
+                    entity_type: 'Type2'
+                },
+                {
+                    object_id: 'v',
+                    name: 'vol',
+                    type: 'Number'
+                }
+            ]
+        },
+        GPS: {
+            commands: [],
+            type: 'GPS',
+            lazy: [],
+            active: [
+                {
+                    name: 'explicit',
+                    type: 'number',
+                    entity_name: 'SO5',
+                    object_id: 'x'
+                },
+                {
+                    name: 'explicit',
+                    type: 'number',
+                    entity_name: 'SO6',
+                    object_id: 'y'
+                }
+            ],
+            explicitAttrs: true
+        },
+        GPS2: {
+            commands: [],
+            type: 'GPS',
+            lazy: [],
+            active: [
+                {
+                    name: 'foo',
+                    type: 'text',
+                    object_id: 'f'
+                },
+                {
+                    name: 'attr1',
+                    type: 'number',
+                    entity_name: 'SO5',
+                    object_id: 'x'
+                },
+                {
+                    name: 'attr2',
+                    type: 'number',
+                    entity_name: 'SO6',
+                    object_id: 'y'
+                }
+            ],
+            static: [
+                {
+                    name: 'bar',
+                    type: 'text',
+                    value: 'b'
+                }
+            ],
+            explicitAttrs: '[ "attr1", "attr2" ]'
         }
     },
     service: 'smartgondor',
@@ -598,6 +820,135 @@ describe('NGSI-v2 - Multi-entity plugin', function () {
         });
     });
 
+    describe('When an update comes for a multientity with same entity_id and different entity_type with different attrs', function () {
+        const values = [
+            {
+                name: 'v',
+                type: 'Number',
+                value: 0
+            },
+            {
+                name: 'v1',
+                type: 'Number',
+                value: 1
+            },
+            {
+                name: 'v2',
+                type: 'Number',
+                value: 2
+            },
+            {
+                name: 'v3',
+                type: 'Number',
+                value: 3
+            }
+        ];
+
+        beforeEach(function () {
+            nock.cleanAll();
+
+            contextBrokerMock = nock('http://192.168.1.1:1026')
+                .matchHeader('fiware-service', 'smartgondor')
+                .matchHeader('fiware-servicepath', 'gardens')
+                .post(
+                    '/v2/op/update',
+                    utils.readExampleFile(
+                        './test/unit/ngsiv2/examples/contextRequests/updateContextMultientityPlugin12.json'
+                    )
+                )
+                .reply(204);
+        });
+
+        it('should send the update value to three entities with different attribute names and different object_id', function (done) {
+            iotAgentLib.update('sh1', 'SharedIds1', '', values, function (error) {
+                should.not.exist(error);
+                contextBrokerMock.done();
+                done();
+            });
+        });
+    });
+
+    describe('When an update comes for a multientity with same entity_id and different entity_type whit shared attrs', function () {
+        const values = [
+            {
+                name: 'v',
+                type: 'Number',
+                value: 0
+            },
+            {
+                name: 'v1',
+                type: 'Number',
+                value: 1
+            },
+            {
+                name: 'v2',
+                type: 'Number',
+                value: 2
+            },
+            {
+                name: 'v3',
+                type: 'Number',
+                value: 3
+            }
+        ];
+
+        beforeEach(function () {
+            nock.cleanAll();
+
+            contextBrokerMock = nock('http://192.168.1.1:1026')
+                .matchHeader('fiware-service', 'smartgondor')
+                .matchHeader('fiware-servicepath', 'gardens')
+                .post(
+                    '/v2/op/update',
+                    utils.readExampleFile(
+                        './test/unit/ngsiv2/examples/contextRequests/updateContextMultientityPlugin13.json'
+                    )
+                )
+                .reply(204);
+        });
+
+        it('should send the update value to three entities with same attribute names', function (done) {
+            iotAgentLib.update('sh2', 'SharedIds2', '', values, function (error) {
+                should.not.exist(error);
+                contextBrokerMock.done();
+                done();
+            });
+        });
+    });
+
+    describe('When an update comes for a multientity with same entity_id and different entity_type whit shared attrs and shared object_id', function () {
+        const values = [
+            {
+                name: 'v',
+                type: 'Number',
+                value: 0
+            }
+        ];
+
+        beforeEach(function () {
+            nock.cleanAll();
+
+            contextBrokerMock = nock('http://192.168.1.1:1026')
+                .matchHeader('fiware-service', 'smartgondor')
+                .matchHeader('fiware-servicepath', 'gardens')
+                .post(
+                    '/v2/op/update',
+                    utils.readExampleFile(
+                        './test/unit/ngsiv2/examples/contextRequests/updateContextMultientityPlugin14.json'
+                    )
+                )
+                .reply(204);
+        });
+
+        it('should send the update value to three entities with same attribute names', function (done) {
+            iotAgentLib.update('sh3', 'SharedIds3', '', values, function (error) {
+                should.not.exist(error);
+                contextBrokerMock.done();
+                done();
+            });
+        });
+    });
+
     describe('When an update comes for a multientity defined with an expression (multi values / multiple entities / same attribute) - JEXL', function () {
         const values = [
             {
@@ -641,6 +992,97 @@ describe('NGSI-v2 - Multi-entity plugin', function () {
         });
     });
 
+    describe('When an update comes for a multientity defined with an expression (multi values / multiple entities / same attribute) - JEXL with static', function () {
+        const values = [
+            {
+                name: 'v',
+                type: 'Number',
+                value: 0
+            }
+        ];
+
+        beforeEach(function () {
+            nock.cleanAll();
+
+            contextBrokerMock = nock('http://192.168.1.1:1026')
+                .matchHeader('fiware-service', 'smartgondor')
+                .matchHeader('fiware-servicepath', 'gardens')
+                .post(
+                    '/v2/op/update',
+                    utils.readExampleFile(
+                        './test/unit/ngsiv2/examples/contextRequests/updateContextMultientityPlugin10.json'
+                    )
+                )
+                .reply(204);
+        });
+
+        it('should send the update value to the resulting value of the expression', function (done) {
+            iotAgentLib.update('ws9', 'WeatherStation9Jexl', '', values, function (error) {
+                should.not.exist(error);
+                contextBrokerMock.done();
+                done();
+            });
+        });
+    });
+
+    beforeEach(function () {
+        nock.cleanAll();
+
+        contextBrokerMock = nock('http://192.168.1.1:1026')
+            .matchHeader('fiware-service', 'smartgondor')
+            .matchHeader('fiware-servicepath', 'gardens')
+            .post(
+                '/v2/op/update',
+                utils.readExampleFile(
+                    './test/unit/ngsiv2/examples/contextRequests/updateContextMultientityPlugin11.json'
+                )
+            )
+            .reply(204);
+    });
+
+    describe('When an update comes for a multientity whith a wrong mapping)', function () {
+        const values = [
+            {
+                name: 'v',
+                type: 'Number',
+                value: 0
+            },
+            {
+                name: 'v1',
+                type: 'Number',
+                value: 1
+            },
+            {
+                name: 'v2',
+                type: 'Number',
+                value: 2
+            }
+        ];
+
+        beforeEach(function () {
+            nock.cleanAll();
+
+            contextBrokerMock = nock('http://192.168.1.1:1026')
+                .matchHeader('fiware-service', 'smartgondor')
+                .matchHeader('fiware-servicepath', 'gardens')
+                .post(
+                    '/v2/op/update',
+                    utils.readExampleFile(
+                        './test/unit/ngsiv2/examples/contextRequests/updateContextMultientityPlugin11.json'
+                    )
+                )
+                .reply(204);
+        });
+
+        it('should send the update value to the resulting value of the expression overwriting wrong id and type mapped attributes', function (done) {
+            iotAgentLib.update('ws11', 'WrongStation', '', values, function (error) {
+                should.not.exist(error);
+                contextBrokerMock.done();
+                done();
+            });
+        });
+    });
+
     describe('When an update comes for a multientity measurement without type for one entity', function () {
         const values = [
             {
@@ -679,6 +1121,90 @@ describe('NGSI-v2 - Multi-entity plugin', function () {
         });
     });
 
+    describe('When an update comes for a multientity measurement explicitAttrs for one entity', function () {
+        const values = [
+            {
+                name: 'x',
+                type: 'Number',
+                value: 52
+            },
+            {
+                name: 'y',
+                type: 'Number',
+                value: 13
+            },
+            {
+                name: 'z',
+                type: 'Number',
+                value: 12
+            }
+        ];
+
+        beforeEach(function () {
+            nock.cleanAll();
+            contextBrokerMock = nock('http://192.168.1.1:1026')
+                .matchHeader('fiware-service', 'smartgondor')
+                .matchHeader('fiware-servicepath', 'gardens')
+                .post(
+                    '/v2/op/update',
+                    utils.readExampleFile(
+                        './test/unit/ngsiv2/examples/contextRequests/updateContextMultientityPlugin15.json'
+                    )
+                )
+                .reply(204);
+        });
+
+        it('should remove hidden attrs from the value', function (done) {
+            iotAgentLib.update('gps1', 'GPS', '', values, function (error) {
+                should.not.exist(error);
+                contextBrokerMock.done();
+                done();
+            });
+        });
+    });
+
+    describe('When an update comes for a multientity measurement explicitAttrs as jexl for one entity', function () {
+        const values = [
+            {
+                name: 'x',
+                type: 'Number',
+                value: 52
+            },
+            {
+                name: 'y',
+                type: 'Number',
+                value: 13
+            },
+            {
+                name: 'z',
+                type: 'Number',
+                value: 12
+            }
+        ];
+
+        beforeEach(function () {
+            nock.cleanAll();
+            contextBrokerMock = nock('http://192.168.1.1:1026')
+                .matchHeader('fiware-service', 'smartgondor')
+                .matchHeader('fiware-servicepath', 'gardens')
+                .post(
+                    '/v2/op/update',
+                    utils.readExampleFile(
+                        './test/unit/ngsiv2/examples/contextRequests/updateContextMultientityPlugin16.json'
+                    )
+                )
+                .reply(204);
+        });
+
+        it('should remove hidden attrs from the value', function (done) {
+            iotAgentLib.update('gps1', 'GPS2', '', values, function (error) {
+                should.not.exist(error);
+                contextBrokerMock.done();
+                done();
+            });
+        });
+    });
+
     describe(
         'When an update comes for a multientity measurement and there are attributes with' +
             ' the same name but different alias and mapped to different CB entities',

package/test/unit/{plugins → ngsiv2/plugins}/translation-inPlugins_test.js

@@ -23,8 +23,9 @@
 
 /* eslint-disable no-unused-vars */
 
-const iotAgentLib = require('../../../lib/fiware-iotagent-lib');
-const utils = require('../../tools/utils');
+const iotAgentLib = require('../../../../lib/fiware-iotagent-lib');
+const utils = require('../../../tools/utils');
+const request = utils.request;
 const should = require('should');
 const logger = require('logops');
 const nock = require('nock');
@@ -32,7 +33,8 @@ let contextBrokerMock;
 const iotAgentConfig = {
     contextBroker: {
         host: '192.168.1.1',
-        port: '1026'
+        port: '1026',
+        nsgiVersion: 'v2'
     },
     server: {
         port: 4041
@@ -117,7 +119,7 @@ const iotAgentConfig = {
     deviceRegistrationDuration: 'P1M'
 };
 
-describe('Data Mapping Plugins: translation', function () {
+describe('NGSI-v2 - Data Mapping Plugins: translation', function () {
     beforeEach(function (done) {
         logger.setLevel('FATAL');
 
@@ -139,11 +141,11 @@ describe('Data Mapping Plugins: translation', function () {
             contextBrokerMock = nock('http://192.168.1.1:1026')
                 .matchHeader('fiware-service', 'smartgondor')
                 .matchHeader('fiware-servicepath', 'gardens')
-                .post(
-                    '/v1/updateContext',
-                    utils.readExampleFile('./test/unit/examples/contextRequests/updateContextMiddleware1.json')
+                .patch(
+                    '/v2/entities/light1/attrs?type=Light',
+                    utils.readExampleFile('./test/unit/ngsiv2/examples/contextRequests/updateContextMiddleware1.json')
                 )
-                .reply(200, utils.readExampleFile('./test/unit/examples/contextResponses/updateContext1Success.json'));
+                .reply(204);
         });
 
         it('should execute the translation middlewares', function (done) {
@@ -163,7 +165,7 @@ describe('Data Mapping Plugins: translation', function () {
             let executed = false;
 
             function testMiddleware(entity, typeInformation, callback) {
-                entity.contextElements[0].attributes[1].value = entity.contextElements[0].attributes[1].value + '%';
+                entity.dimming.value = entity.dimming.value + '%';
                 executed = true;
                 callback(null, entity, typeInformation);
             }
@@ -192,7 +194,7 @@ describe('Data Mapping Plugins: translation', function () {
             ];
 
             function testMiddleware(entity, typeInformation, callback) {
-                entity.contextElements[0].attributes[1].value = entity.contextElements[0].attributes[1].value + '%';
+                entity.dimming.value = entity.dimming.value + '%';
                 callback(null, entity, typeInformation);
             }
 
@@ -215,19 +217,19 @@ describe('Data Mapping Plugins: translation', function () {
             contextBrokerMock = nock('http://192.168.1.1:1026')
                 .matchHeader('fiware-service', 'smartgondor')
                 .matchHeader('fiware-servicepath', 'gardens')
-                .post(
-                    '/v1/queryContext',
-                    utils.readExampleFile('./test/unit/examples/contextRequests/queryContext1.json')
-                )
-                .reply(200, utils.readExampleFile('./test/unit/examples/contextResponses/queryContext1Success.json'));
+                .get('/v2/entities/light1/attrs?attrs=state,dimming&type=Light')
+
+                .reply(
+                    200,
+                    utils.readExampleFile('./test/unit/ngsiv2/examples/contextRequests/updateContextMiddleware2.json')
+                );
         });
 
         it('should call the middleware', function (done) {
             let called = false;
 
             function testMiddleware(entity, typeInformation, callback) {
-                entity.contextResponses[0].contextElement.attributes[1].value =
-                    entity.contextResponses[0].contextElement.attributes[1].value + '%';
+                entity.dimming.value = entity.dimming.value + '%';
 
                 called = true;
 
@@ -244,9 +246,7 @@ describe('Data Mapping Plugins: translation', function () {
         });
         it('should call the middleware', function (done) {
             function testMiddleware(entity, typeInformation, callback) {
-                entity.contextResponses[0].contextElement.attributes[1].value =
-                    entity.contextResponses[0].contextElement.attributes[1].value + '%';
-
+                entity.dimming.value = entity.dimming.value + '%';
                 callback(null, entity, typeInformation);
             }
 
@@ -254,7 +254,7 @@ describe('Data Mapping Plugins: translation', function () {
 
             iotAgentLib.query('light1', 'Light', '', attributes, function (error, result) {
                 should.not.exist(error);
-                result.contextResponses[0].contextElement.attributes[1].value.should.equal('23%');
+                result.dimming.value.should.equal('23%');
                 done();
             });
         });