iotagent-node-lib 2.17.0 → 2.20.0

package/test/unit/ngsiv2/general/iotam-autoregistration-test.js

@@ -24,9 +24,10 @@
 /* eslint-disable no-unused-vars */
 
 const iotAgentLib = require('../../../../lib/fiware-iotagent-lib');
-const request = require('request');
+
 const nock = require('nock');
 const utils = require('../../../tools/utils');
+const request = utils.request;
 const groupRegistryMemory = require('../../../../lib/services/groups/groupRegistryMemory');
 const should = require('should');
 const iotAgentConfig = {

package/test/unit/ngsiv2/general/startup-test.js

@@ -30,6 +30,7 @@ const iotAgentLib = require('../../../../lib/fiware-iotagent-lib');
 const should = require('should');
 const nock = require('nock');
 const utils = require('../../../tools/utils');
+const request = utils.request;
 const config = require('../../../../lib/commonConfig');
 const iotAgentConfig = {
     logLevel: 'FATAL',

package/test/unit/ngsiv2/lazyAndCommands/active-devices-attribute-update-test.js

@@ -26,11 +26,13 @@
 /* eslint-disable no-unused-vars */
 
 const iotAgentLib = require('../../../../lib/fiware-iotagent-lib');
+const utils = require('../../../tools/utils');
+const request = utils.request;
 const should = require('should');
 const logger = require('logops');
 const nock = require('nock');
 const mongoUtils = require('../../mongodb/mongoDBUtils');
-const request = require('request');
+
 let contextBrokerMock;
 const iotAgentConfig = {
     logLevel: 'FATAL',

package/test/unit/ngsiv2/lazyAndCommands/command-test.js

@@ -27,11 +27,12 @@
 
 const iotAgentLib = require('../../../../lib/fiware-iotagent-lib');
 const utils = require('../../../tools/utils');
+const request = utils.request;
 const should = require('should');
 const logger = require('logops');
 const nock = require('nock');
 const mongoUtils = require('../../mongodb/mongoDBUtils');
-const request = require('request');
+
 const timekeeper = require('timekeeper');
 let contextBrokerMock;
 let statusAttributeMock;

package/test/unit/ngsiv2/lazyAndCommands/lazy-devices-test.js

@@ -27,16 +27,18 @@
 
 const iotAgentLib = require('../../../../lib/fiware-iotagent-lib');
 const utils = require('../../../tools/utils');
+const request = utils.request;
 const async = require('async');
 const apply = async.apply;
 const should = require('should');
 const logger = require('logops');
 const nock = require('nock');
 const mongoUtils = require('../../mongodb/mongoDBUtils');
-const request = require('request');
+
 const timekeeper = require('timekeeper');
 let contextBrokerMock;
 const iotAgentConfig = {
+    logLevel: 'FATAL',
     contextBroker: {
         host: '192.168.1.1',
         port: '1026',
@@ -235,12 +237,11 @@ describe('NGSI-v2 - IoT Agent Lazy Devices', function () {
         const options = {
             url: 'http://localhost:' + iotAgentConfig.server.port + '/v2/op/query',
             method: 'POST',
-            json: true,
             headers: {
                 'fiware-service': 'smartgondor',
                 'fiware-servicepath': 'gardens'
             },
-            body: {
+            json: {
                 entities: [
                     {
                         id: 'Light:light1'
@@ -307,12 +308,12 @@ describe('NGSI-v2 - IoT Agent Lazy Devices', function () {
         const options = {
             url: 'http://localhost:' + iotAgentConfig.server.port + '/v2/op/query',
             method: 'POST',
-            json: true,
+
             headers: {
                 'fiware-service': 'smartgondor',
                 'fiware-servicepath': 'gardens'
             },
-            body: {
+            json: {
                 entities: [
                     {
                         id: 'Light:light1'
@@ -370,12 +371,12 @@ describe('NGSI-v2 - IoT Agent Lazy Devices', function () {
         const options = {
             url: 'http://localhost:' + iotAgentConfig.server.port + '/v2/op/query',
             method: 'POST',
-            json: true,
+
             headers: {
                 'fiware-service': 'smartgondor',
                 'fiware-servicepath': 'gardens'
             },
-            body: {
+            json: {
                 entities: [
                     {
                         id: 'Light:light1'
@@ -441,12 +442,11 @@ describe('NGSI-v2 - IoT Agent Lazy Devices', function () {
         const options = {
             url: 'http://localhost:' + iotAgentConfig.server.port + '/v2/op/query',
             method: 'POST',
-            json: true,
             headers: {
                 'fiware-service': 'smartgondor',
                 'fiware-servicepath': 'gardens'
             },
-            body: {
+            json: {
                 entities: [
                     {
                         id: 'Motion:motion1'
@@ -580,12 +580,11 @@ describe('NGSI-v2 - IoT Agent Lazy Devices', function () {
         const options = {
             url: 'http://localhost:' + iotAgentConfig.server.port + '/v2/op/query',
             method: 'POST',
-            json: true,
             headers: {
                 'fiware-service': 'smartgondor',
                 'fiware-servicepath': 'gardens'
             },
-            body: {
+            json: {
                 entities: [
                     {
                         idPattern: '.*'
@@ -663,12 +662,11 @@ describe('NGSI-v2 - IoT Agent Lazy Devices', function () {
         const options = {
             url: 'http://localhost:' + iotAgentConfig.server.port + '/v2/op/query',
             method: 'POST',
-            json: true,
             headers: {
                 'fiware-service': 'smartgondor',
                 'fiware-servicepath': 'gardens'
             },
-            body: {
+            json: {
                 entities: [
                     {
                         idPattern: '.*',
@@ -747,12 +745,11 @@ describe('NGSI-v2 - IoT Agent Lazy Devices', function () {
         const options = {
             url: 'http://localhost:' + iotAgentConfig.server.port + '/v2/op/query',
             method: 'POST',
-            json: true,
             headers: {
                 'fiware-service': 'smartgondor',
                 'fiware-servicepath': 'gardens'
             },
-            body: {
+            json: {
                 entities: [
                     {
                         id: 'Light:light1',
@@ -815,4 +812,279 @@ describe('NGSI-v2 - IoT Agent Lazy Devices', function () {
             });
         });
     });
+
+    describe('When a context query arrives to the IoT Agent with an invalid body', function () {
+        const options = {
+            url: 'http://localhost:' + iotAgentConfig.server.port + '/v2/op/query',
+            method: 'POST',
+            json: {}
+        };
+        const sensorData = [
+            {
+                id: 'Light:light1',
+                type: 'Light',
+                attributes: [
+                    {
+                        name: 'dimming',
+                        type: 'Percentage',
+                        value: '19'
+                    }
+                ]
+            }
+        ];
+
+        beforeEach(function (done) {
+            nock.cleanAll();
+
+            contextBrokerMock = nock('http://192.168.1.1:1026')
+                .matchHeader('fiware-service', 'smartgondor')
+                .matchHeader('fiware-servicepath', 'gardens')
+                .post(
+                    '/v2/registrations',
+                    utils.readExampleFile(
+                        './test/unit/ngsiv2/examples/contextAvailabilityRequests/registerIoTAgent1.json'
+                    )
+                )
+                .reply(201, null, { Location: '/v2/registrations/6319a7f5254b05844116584d' });
+
+            contextBrokerMock
+                .matchHeader('fiware-service', 'smartgondor')
+                .matchHeader('fiware-servicepath', 'gardens')
+                .post('/v2/entities?options=upsert')
+                .reply(204);
+
+            iotAgentLib.activate(iotAgentConfig, done);
+        });
+
+        it('should fail with a 400 error', function (done) {
+            let handlerCalled = false;
+
+            iotAgentLib.setDataQueryHandler(function (id, type, service, subservice, attributes, callback) {
+                handlerCalled = true;
+                callback(null, sensorData);
+            });
+
+            request(options, function (error, response, body) {
+                should.not.exist(error);
+                response.statusCode.should.equal(400);
+                handlerCalled.should.equal(false);
+                done();
+            });
+        });
+    });
+
+    describe('When a context query arrives to the IoT Agent with a payload that is not JSON', function () {
+        const options = {
+            url: 'http://localhost:' + iotAgentConfig.server.port + '/v2/op/query',
+            method: 'POST',
+            body: 'This is a body in text format',
+            headers: {
+                'Content-Type': 'text/plain',
+                'fiware-service': 'smartgondor',
+                'fiware-servicepath': 'gardens'
+            }
+        };
+        const sensorData = [
+            {
+                id: 'Light:light1',
+                type: 'Light',
+                attributes: [
+                    {
+                        name: 'dimming',
+                        type: 'Percentage',
+                        value: '19'
+                    }
+                ]
+            }
+        ];
+
+        beforeEach(function (done) {
+            nock.cleanAll();
+
+            contextBrokerMock = nock('http://192.168.1.1:1026')
+                .matchHeader('fiware-service', 'smartgondor')
+                .matchHeader('fiware-servicepath', 'gardens')
+                .post(
+                    '/v2/registrations',
+                    utils.readExampleFile(
+                        './test/unit/ngsiv2/examples/contextAvailabilityRequests/registerIoTAgent1.json'
+                    )
+                )
+                .reply(201, null, { Location: '/v2/registrations/6319a7f5254b05844116584d' });
+
+            contextBrokerMock
+                .matchHeader('fiware-service', 'smartgondor')
+                .matchHeader('fiware-servicepath', 'gardens')
+                .post('/v2/entities?options=upsert')
+                .reply(204);
+
+            iotAgentLib.activate(iotAgentConfig, done);
+        });
+
+        it('should fail with a 400 error', function (done) {
+            let handlerCalled = false;
+
+            iotAgentLib.setDataQueryHandler(function (id, type, service, subservice, attributes, callback) {
+                handlerCalled = true;
+                callback(null, sensorData);
+            });
+
+            request(options, function (error, response, body) {
+                should.not.exist(error);
+                response.statusCode.should.equal(400);
+                handlerCalled.should.equal(false);
+                done();
+            });
+        });
+    });
+
+    describe('When a query arrives to the IoT Agent with an empty attributes array', function () {
+        const options = {
+            url: 'http://localhost:' + iotAgentConfig.server.port + '/v2/op/query',
+            method: 'POST',
+            json: {
+                entities: [
+                    {
+                        type: 'Light',
+                        isPattern: 'false',
+                        id: 'Light:light1'
+                    }
+                ],
+                attributes: []
+            },
+            headers: {
+                'fiware-service': 'smartgondor',
+                'fiware-servicepath': 'gardens'
+            }
+        };
+        const sensorData = [
+            {
+                id: 'Light:light1',
+                type: 'Light',
+                temperature: { type: 'centigrades', value: 19 }
+            }
+        ];
+
+        beforeEach(function (done) {
+            nock.cleanAll();
+
+            contextBrokerMock = nock('http://192.168.1.1:1026')
+                .matchHeader('fiware-service', 'smartgondor')
+                .matchHeader('fiware-servicepath', 'gardens')
+                .post(
+                    '/v2/registrations',
+                    utils.readExampleFile(
+                        './test/unit/ngsiv2/examples/contextAvailabilityRequests/registerIoTAgent1.json'
+                    )
+                )
+                .reply(201, null, { Location: '/v2/registrations/6319a7f5254b05844116584d' });
+
+            contextBrokerMock
+                .matchHeader('fiware-service', 'smartgondor')
+                .matchHeader('fiware-servicepath', 'gardens')
+                .post('/v2/entities?options=upsert')
+                .reply(204);
+
+            async.series([apply(iotAgentLib.activate, iotAgentConfig), apply(iotAgentLib.register, device1)], done);
+        });
+
+        it('should return the information of all the attributes', function (done) {
+            const expectedResponse = utils.readExampleFile(
+                './test/unit/ngsiv2/examples/contextProviderResponses/queryInformationResponseEmptyAttributes.json'
+            );
+
+            iotAgentLib.setDataQueryHandler(function (id, type, service, subservice, attributes, callback) {
+                should.exist(attributes);
+                attributes.length.should.equal(1);
+                attributes[0].should.equal('temperature');
+                callback(null, sensorData[0]);
+            });
+
+            request(options, function (error, response, body) {
+                should.not.exist(error);
+                body.should.eql(expectedResponse);
+                done();
+            });
+        });
+    });
+
+    describe('When a context query arrives to the IoT Agent with a payload that is not JSON', function () {
+        const options = {
+            url: 'http://localhost:' + iotAgentConfig.server.port + '/v2/op/query',
+            method: 'POST',
+            body: 'This is a body in text format',
+            headers: {
+                'Content-Type': 'text/plain',
+                'fiware-service': 'smartgondor',
+                'fiware-servicepath': 'gardens'
+            }
+        };
+        const sensorData = [
+            {
+                id: 'Light:light1',
+                type: 'Light',
+                attributes: [
+                    {
+                        name: 'dimming',
+                        type: 'Percentage',
+                        value: '19'
+                    }
+                ]
+            }
+        ];
+
+        beforeEach(function (done) {
+            nock.cleanAll();
+
+            contextBrokerMock = nock('http://192.168.1.1:1026')
+                .matchHeader('fiware-service', 'smartgondor')
+                .matchHeader('fiware-servicepath', 'gardens')
+                .post(
+                    '/v2/registrations',
+                    utils.readExampleFile(
+                        './test/unit/ngsiv2/examples/contextAvailabilityRequests/registerIoTAgent1.json'
+                    )
+                )
+                .reply(201, null, { Location: '/v2/registrations/6319a7f5254b05844116584d' });
+
+            contextBrokerMock
+                .matchHeader('fiware-service', 'smartgondor')
+                .matchHeader('fiware-servicepath', 'gardens')
+                .post('/v2/entities?options=upsert')
+                .reply(204);
+
+            iotAgentLib.activate(iotAgentConfig, done);
+        });
+
+        it('should fail with a 400 error', function (done) {
+            let handlerCalled = false;
+
+            iotAgentLib.setDataQueryHandler(function (id, type, service, subservice, attributes, callback) {
+                handlerCalled = true;
+                callback(null, sensorData);
+            });
+
+            request(options, function (error, response, body) {
+                should.not.exist(error);
+                response.statusCode.should.equal(400);
+                handlerCalled.should.equal(false);
+                done();
+            });
+        });
+
+        it('should return an NGSI compliant payload', function (done) {
+            let handlerCalled = false;
+
+            iotAgentLib.setDataQueryHandler(function (id, type, service, subservice, attributes, callback) {
+                handlerCalled = true;
+                callback(null, sensorData);
+            });
+
+            request(options, function (error, response, body) {
+                body.error.should.equal('UNSUPPORTED_CONTENT_TYPE');
+                body.description.should.equal('Unsupported content type in the context request: text/plain');
+                done();
+            });
+        });
+    });
 });

package/test/unit/ngsiv2/lazyAndCommands/polling-commands-test.js

@@ -27,14 +27,16 @@
 
 const iotAgentLib = require('../../../../lib/fiware-iotagent-lib');
 const utils = require('../../../tools/utils');
+const request = utils.request;
 const should = require('should');
 const logger = require('logops');
 const nock = require('nock');
 const mongoUtils = require('../../mongodb/mongoDBUtils');
-const request = require('request');
+
 let contextBrokerMock;
 let statusAttributeMock;
 const iotAgentConfig = {
+    logLevel: 'FATAL',
     contextBroker: {
         host: '192.168.1.1',
         port: '1026',

package/test/unit/ngsiv2/ngsiService/active-devices-test.js

@@ -27,6 +27,7 @@
 
 const iotAgentLib = require('../../../../lib/fiware-iotagent-lib');
 const utils = require('../../../tools/utils');
+const request = utils.request;
 const timekeeper = require('timekeeper');
 const should = require('should');
 const logger = require('logops');
@@ -190,6 +191,27 @@ describe('NGSI-v2 - Active attributes test', function () {
                 done();
             });
         });
+
+        it('should ignore if wrong type or id are target atributes in the context broker', function (done) {
+            const wrongvalues = [
+                {
+                    name: 'type',
+                    type: 'string',
+                    value: 'wrongtype'
+                },
+                {
+                    name: 'id',
+                    type: 'string',
+                    value: 'wrongid'
+                }
+            ];
+
+            iotAgentLib.update('light1', 'Light', '', wrongvalues.concat(values), function (error) {
+                should.not.exist(error);
+                contextBrokerMock.done();
+                done();
+            });
+        });
     });
 
     describe('When the IoT Agent receives new information and the timestamp flag is on', function () {
@@ -716,4 +738,70 @@ describe('NGSI-v2 - Active attributes test', function () {
             });
         });
     });
+
+    describe('When the IoT Agent receives new information from a device and the appendMode flag is on', function () {
+        beforeEach(function (done) {
+            nock.cleanAll();
+
+            contextBrokerMock = nock('http://192.168.1.1:1026')
+                .matchHeader('fiware-service', 'smartgondor')
+                .matchHeader('fiware-servicepath', 'gardens')
+                .post(
+                    '/v2/entities/light1/attrs',
+                    utils.readExampleFile('./test/unit/ngsiv2/examples/contextRequests/updateContext.json')
+                )
+                .query({ type: 'Light' })
+                .reply(204);
+
+            iotAgentConfig.appendMode = true;
+            iotAgentLib.activate(iotAgentConfig, done);
+        });
+
+        afterEach(function (done) {
+            iotAgentConfig.appendMode = false;
+
+            done();
+        });
+
+        it('should change the value of the corresponding attribute in the context broker', function (done) {
+            iotAgentLib.update('light1', 'Light', '', values, function (error) {
+                should.not.exist(error);
+                contextBrokerMock.done();
+                done();
+            });
+        });
+    });
+
+    describe('When the IoT Agent receives new information from a device and CBis defined using environment variables', function () {
+        beforeEach(function (done) {
+            process.env.IOTA_CB_HOST = 'cbhost';
+
+            nock.cleanAll();
+
+            contextBrokerMock = nock('http://cbhost:1026')
+                .matchHeader('fiware-service', 'smartgondor')
+                .matchHeader('fiware-servicepath', 'gardens')
+                .patch(
+                    '/v2/entities/light1/attrs',
+                    utils.readExampleFile('./test/unit/ngsiv2/examples/contextRequests/updateContext.json')
+                )
+                .query({ type: 'Light' })
+                .reply(204);
+
+            iotAgentLib.activate(iotAgentConfig, done);
+        });
+
+        it('should change the value of the corresponding attribute in the context broker', function (done) {
+            iotAgentLib.update('light1', 'Light', '', values, function (error) {
+                should.not.exist(error);
+                contextBrokerMock.done();
+                done();
+            });
+        });
+
+        afterEach(function (done) {
+            delete process.env.IOTA_CB_HOST;
+            done();
+        });
+    });
 });