incremnt 0.8.1 → 0.8.3

package/src/sync-service.js

@@ -4,6 +4,7 @@ import { formatIncrementScorePrelude } from './score-prelude.js';
 import {
   askVerificationMetadata,
   buildAskAnswerRepairContext,
+  degradeAskAnswer,
   safeAskVerificationFallback,
   shouldRepairAskAnswer,
   verifyAskAnswer
@@ -207,10 +208,28 @@ function mergeAgenticToolProvenance(routingMetadata, toolInvocations = []) {
   }
 }
 
+function sanitizeBodyWeightEvidenceFactsForStorage(value) {
+  if (!value || typeof value !== 'object' || Array.isArray(value)) return null;
+  const facts = { ...value };
+  if (Array.isArray(facts.rows)) {
+    facts.rows = facts.rows
+      .filter((row) => row?.date && Number.isFinite(Number(row.weightKg)))
+      .slice(-90)
+      .map((row) => ({
+        date: askStorageString(String(row.date).slice(0, 10), { maxLength: 10 }),
+        weightKg: Math.round(Number(row.weightKg) * 10) / 10
+      }))
+      .filter((row) => row.date);
+  }
+  const serialized = JSON.stringify(facts);
+  if (serialized.length > ASK_STRUCTURED_MAX_JSON_LENGTH) return null;
+  return JSON.parse(serialized);
+}
+
 function sanitizeAskEvidenceForStorage(item) {
   if (!item || typeof item !== 'object' || Array.isArray(item)) return null;
   const sanitized = {};
-  for (const key of ['label', 'section', 'toolName', 'sourceTimestamp']) {
+  for (const key of ['label', 'section', 'toolName', 'sourceTimestamp', 'kind', 'presentation']) {
     const value = askStorageString(item[key], { maxLength: 240 });
     if (value) sanitized[key] = value;
   }
@@ -218,6 +237,13 @@ function sanitizeAskEvidenceForStorage(item) {
     const values = askStorageStringArray(item[key], { maxItems: ASK_STRUCTURED_MAX_ITEMS, maxLength: 160 });
     if (values.length > 0) sanitized[key] = values;
   }
+  const isBodyWeightEvidence = sanitized.toolName === 'get_body_weight_snapshot'
+    || sanitized.kind === 'body_weight_trend'
+    || sanitized.presentation === 'body_weight_trend';
+  if (isBodyWeightEvidence) {
+    const facts = sanitizeBodyWeightEvidenceFactsForStorage(item.facts);
+    if (facts) sanitized.facts = facts;
+  }
   return Object.keys(sanitized).length > 0 ? sanitized : null;
 }
 
@@ -242,7 +268,7 @@ function sanitizeAskProgramDraftForStorage(value) {
   return JSON.parse(serialized);
 }
 
-function sanitizeAskStructuredResponseForStorage(structured) {
+export function sanitizeAskStructuredResponseForStorage(structured) {
   if (!structured || typeof structured !== 'object' || Array.isArray(structured)) return null;
   const confidence = askStorageString(structured.confidence, { maxLength: 40 });
   const answer = askStorageString(structured.answer);
@@ -602,6 +628,7 @@ export function buildAskInteractionLogPayload({
     fallback: askResult?.fallback === true ? true : undefined,
     route: routingMetadata?.route ?? evidencePlan?.route,
     effectiveRoute: routingMetadata?.effectiveRoute ?? evidencePlan?.effectiveRoute,
+    responseProfile: routingMetadata?.responseProfile ?? routingMetadata?.intent?.responseProfile,
     requestedAction: routingMetadata?.intent?.requestedAction,
     intentConfidence: typeof routingMetadata?.intent?.confidence === 'number' ? routingMetadata.intent.confidence : undefined,
     structuredConfidence: typeof structured?.confidence === 'string' ? structured.confidence : undefined,
@@ -620,6 +647,8 @@ export function buildAskInteractionLogPayload({
     hasProgramDraft: structured?.programDraft != null ? true : undefined,
     askVerificationStatus: answerVerification.status,
     askVerificationRetryCount: typeof answerVerification.retryCount === 'number' ? answerVerification.retryCount : undefined,
+    askVerificationDegraded: answerVerification.degraded === true ? true : undefined,
+    askVerificationRedactedCount: typeof answerVerification.redactedCount === 'number' ? answerVerification.redactedCount : undefined,
     askVerificationBlockingFailureCount: typeof answerVerification.blockingFailureCount === 'number' ? answerVerification.blockingFailureCount : undefined,
     askVerificationAdvisoryFailureCount: typeof answerVerification.advisoryFailureCount === 'number' ? answerVerification.advisoryFailureCount : undefined,
     askVerificationFailureKeys: logStringArray(answerVerification.failureKeys),
@@ -5165,6 +5194,11 @@ export function createSyncServiceRequestHandler({
         const coachObservationFollowUp = selectAskCoachObservationFollowUp(requestedCoachObservation, coachObservations);
         const missingRequestedCoachObservation = Boolean(requestedCoachObservation && !coachObservationFollowUp);
 
+        const persistedKind = persistedConversation?.kind ?? (conversationId?.startsWith('weekly-checkin:') ? 'weekly-checkin' : 'ask');
+        // The weekly check-in shares this ask path but runs under the terse
+        // WEEKLY_CHECKIN_PROMPT; force the defensive profile so the expansive
+        // evidence merge and score headline do not contradict that prompt.
+        const askResponseProfileOverride = persistedKind === 'weekly-checkin' ? 'defensive' : null;
         const routedContext = coachObservationFollowUp
           ? askObservationFollowUpContext(snapshot, question, coachObservationFollowUp, {
               exclude,
@@ -5177,9 +5211,11 @@ export function createSyncServiceRequestHandler({
                 intent: requestedCoachObservation.intent,
                 today: new Date()
               })
-            : askRoutedContext(snapshot, question, { exclude, coachFacts, coachObservations, history: canonicalHistory });
-        const persistedKind = persistedConversation?.kind ?? (conversationId?.startsWith('weekly-checkin:') ? 'weekly-checkin' : 'ask');
-        const incrementScorePrelude = formatIncrementScorePrelude(scoreSnapshots, { question });
+            : askRoutedContext(snapshot, question, { exclude, coachFacts, coachObservations, history: canonicalHistory, responseProfileOverride: askResponseProfileOverride });
+        const incrementScorePrelude = formatIncrementScorePrelude(scoreSnapshots, {
+          question,
+          responseProfile: routedContext.metadata?.responseProfile ?? routedContext.metadata?.intent?.responseProfile
+        });
 
         const preludes = [incrementScorePrelude].filter(Boolean);
         const ctx = preludes.length > 0
@@ -5296,6 +5332,8 @@ export function createSyncServiceRequestHandler({
           let verificationRetryCount = 0;
           let verificationRepaired = false;
           let verificationFallback = false;
+          let verificationDegraded = false;
+          let verificationRedactedCount = 0;
 
           if (persistedKind === 'ask' && shouldRepairAskAnswer(verification)) {
             verificationRetryCount = 1;
@@ -5322,20 +5360,42 @@ export function createSyncServiceRequestHandler({
           }
 
           if (persistedKind === 'ask' && shouldRepairAskAnswer(verification)) {
-            verificationFallback = true;
-            attempt = {
-              ...attempt,
-              assistantAnswer: safeAskVerificationFallback(),
-              programDraft: undefined,
-              planChangeset: undefined
-            };
+            // Graceful degrade before refusing: strip the specific unsupported
+            // sentences/bullets and ship the rest if it re-verifies clean. A
+            // coaching answer minus one clause beats a blanket refusal.
+            const degraded = degradeAskAnswer(attempt.assistantAnswer, verification);
+            const degradedVerification = degraded.usable
+              ? verifyAskAnswer({
+                  answer: degraded.text,
+                  snapshot,
+                  routingMetadata,
+                  today: new Date(),
+                  exclude: [...exclude]
+                })
+              : null;
+            if (degradedVerification && degradedVerification.blockingFailureCount === 0) {
+              attempt = { ...attempt, assistantAnswer: degraded.text };
+              verification = degradedVerification;
+              verificationDegraded = true;
+              verificationRedactedCount = degraded.redactedCount;
+            } else {
+              verificationFallback = true;
+              attempt = {
+                ...attempt,
+                assistantAnswer: safeAskVerificationFallback(),
+                programDraft: undefined,
+                planChangeset: undefined
+              };
+            }
           }
 
           const answerVerification = persistedKind === 'ask'
             ? askVerificationMetadata(verification, {
                 retryCount: verificationRetryCount,
                 repaired: verificationRepaired,
-                fallback: verificationFallback
+                fallback: verificationFallback,
+                degraded: verificationDegraded,
+                redactedCount: verificationRedactedCount
               })
             : undefined;
           if (answerVerification) {