incremnt 0.8.1 → 0.8.3

package/src/score-prelude.js

@@ -29,25 +29,25 @@ export function scoreComponentPhrase(name) {
   return SCORE_COMPONENT_PHRASES[String(name).toLowerCase()] ?? 'another training area';
 }
 
-// True when the user's question is actually about the Increment Score. Only then
-// should the prelude hand the model the bare numeric headline — otherwise the
-// model parrots "your score is 92/100" into answers about sessions, volume, or
-// plans where it was never asked for.
+// True when the user's question is actually about the Increment Score. Defensive
+// Ask profiles still use this to avoid score dashboarding in narrow decisions;
+// expansive Ask profiles intentionally get the headline for richer coaching.
 export function isScoreQuestion(question) {
   return /\b(?:increment\s+)?score\b/i.test(String(question ?? ''));
 }
 
-export function formatIncrementScorePrelude(snapshots, { question = '' } = {}) {
+export function formatIncrementScorePrelude(snapshots, { question = '', responseProfile = 'defensive' } = {}) {
   if (!Array.isArray(snapshots) || snapshots.length === 0) return null;
   const latest = snapshots[0];
   if (latest == null || typeof latest.score !== 'number') return null;
 
+  const allowsHeadline = responseProfile === 'expansive' || isScoreQuestion(question);
   const lines = [
-    '[Increment Score — context only. Speak in training reality (recovery, fatigue, consistency, density). Never recite component values, sub-scores, decimals, or daily score numbers. Do not volunteer the overall score number unless the user asked about the score.]'
+    allowsHeadline
+      ? '[Increment Score — context only. The rounded score headline and drivers may be used in rich Ask Coach answers. Never recite component values, sub-scores, decimals, or daily score numbers.]'
+      : '[Increment Score — context only. Speak in training reality (recovery, fatigue, consistency, density). Never recite component values, sub-scores, decimals, or daily score numbers. Do not volunteer the overall score number unless the user asked about the score.]'
   ];
-  // Hand over the numeric headline only when the question is score-related; the
-  // weakest/strongest area and direction below are always safe to provide.
-  if (isScoreQuestion(question)) {
+  if (allowsHeadline) {
     lines.push(`- Current: ${Math.round(latest.score)}/100`);
   }
 
@@ -90,18 +90,21 @@ export function formatIncrementScorePrelude(snapshots, { question = '' } = {}) {
   const negatives = driverLabels(latest.topNegativeDrivers);
   if (negatives) lines.push(`- Holding the score back: ${negatives}`);
 
-  // Direction words only — no delta number, no daily-score list.
+  // Direction words only — no delta number, no daily-score list. Scores are only
+  // comparable within one formula version; a formula change makes the direction a
+  // cross-ruler lie ("+36 / 77% up"), so suppress the steer across it.
+  const latestFormulaVersion = latest.formulaVersion ?? null;
   if (snapshots.length > 1) {
     const prior = snapshots[1];
-    if (typeof prior?.score === 'number') {
+    if (typeof prior?.score === 'number' && (prior.formulaVersion ?? null) === latestFormulaVersion) {
       const delta = latest.score - prior.score;
       const dir = delta > 0 ? 'up' : delta < 0 ? 'down' : 'flat';
       lines.push(`- Day-over-day: ${dir}`);
     }
     const recent = snapshots
       .slice(0, 7)
-      .map((s) => (typeof s?.score === 'number' ? s.score : null))
-      .filter((s) => s != null);
+      .filter((s) => typeof s?.score === 'number' && (s.formulaVersion ?? null) === latestFormulaVersion)
+      .map((s) => s.score);
     if (recent.length >= 3) {
       const span = recent[0] - recent[recent.length - 1];
       const trend = span > 2 ? 'rising' : span < -2 ? 'falling' : 'steady';