hungry-ghost-hive 0.48.0 → 0.49.0

package/src/cli/commands/manager/auto-reject-comment-only-reviews.test.ts

@@ -167,7 +167,12 @@ import { autoRejectCommentOnlyReviews } from './index.js';
 // ── Helpers ────────────────────────────────────────────────────────────────
 
 function makeMockCtx(overrides: Partial<ManagerCheckContext> = {}): ManagerCheckContext {
-  const mockDb = { db: {} as any, save: vi.fn(), close: vi.fn() };
+  const mockDb = {
+    db: {} as any,
+    provider: { withTransaction: vi.fn(async (fn: () => unknown) => fn()) },
+    save: vi.fn(),
+    close: vi.fn(),
+  };
   return {
     root: '/test/project',
     verbose: false,
@@ -228,7 +233,7 @@ describe('autoRejectCommentOnlyReviews', () => {
   });
 
   it('should return early when no PRs are in reviewing status', async () => {
-    vi.mocked(getPullRequestsByStatus).mockReturnValue([]);
+    vi.mocked(getPullRequestsByStatus).mockResolvedValue([]);
 
     const ctx = makeMockCtx();
     await autoRejectCommentOnlyReviews(ctx);
@@ -239,7 +244,7 @@ describe('autoRejectCommentOnlyReviews', () => {
   });
 
   it('should return early when reviewing PRs have no github_pr_number', async () => {
-    vi.mocked(getPullRequestsByStatus).mockReturnValue([
+    vi.mocked(getPullRequestsByStatus).mockResolvedValue([
       makeReviewingPR({ github_pr_number: null }),
     ] as any);
 
@@ -250,8 +255,8 @@ describe('autoRejectCommentOnlyReviews', () => {
   });
 
   it('should skip PRs where QA agent is not idle', async () => {
-    vi.mocked(getPullRequestsByStatus).mockReturnValue([makeReviewingPR()] as any);
-    vi.mocked(getAllTeams).mockReturnValue([
+    vi.mocked(getPullRequestsByStatus).mockResolvedValue([makeReviewingPR()] as any);
+    vi.mocked(getAllTeams).mockResolvedValue([
       { id: 'team-1', repo_path: 'repos/mini-marty' },
     ] as any);
 
@@ -275,8 +280,8 @@ describe('autoRejectCommentOnlyReviews', () => {
   });
 
   it('should skip PRs when QA has formal APPROVED review on GitHub', async () => {
-    vi.mocked(getPullRequestsByStatus).mockReturnValue([makeReviewingPR()] as any);
-    vi.mocked(getAllTeams).mockReturnValue([
+    vi.mocked(getPullRequestsByStatus).mockResolvedValue([makeReviewingPR()] as any);
+    vi.mocked(getAllTeams).mockResolvedValue([
       { id: 'team-1', repo_path: 'repos/mini-marty' },
     ] as any);
 
@@ -304,8 +309,8 @@ describe('autoRejectCommentOnlyReviews', () => {
   });
 
   it('should auto-reject when QA left CHANGES_REQUESTED review', async () => {
-    vi.mocked(getPullRequestsByStatus).mockReturnValue([makeReviewingPR()] as any);
-    vi.mocked(getAllTeams).mockReturnValue([
+    vi.mocked(getPullRequestsByStatus).mockResolvedValue([makeReviewingPR()] as any);
+    vi.mocked(getAllTeams).mockResolvedValue([
       { id: 'team-1', repo_path: 'repos/mini-marty' },
     ] as any);
 
@@ -352,8 +357,8 @@ describe('autoRejectCommentOnlyReviews', () => {
   });
 
   it('should auto-reject when QA left substantive comments (>= 20 chars)', async () => {
-    vi.mocked(getPullRequestsByStatus).mockReturnValue([makeReviewingPR()] as any);
-    vi.mocked(getAllTeams).mockReturnValue([
+    vi.mocked(getPullRequestsByStatus).mockResolvedValue([makeReviewingPR()] as any);
+    vi.mocked(getAllTeams).mockResolvedValue([
       { id: 'team-1', repo_path: 'repos/mini-marty' },
     ] as any);
 
@@ -392,8 +397,8 @@ describe('autoRejectCommentOnlyReviews', () => {
   });
 
   it('should ignore short comments (< 20 chars) and not reject', async () => {
-    vi.mocked(getPullRequestsByStatus).mockReturnValue([makeReviewingPR()] as any);
-    vi.mocked(getAllTeams).mockReturnValue([
+    vi.mocked(getPullRequestsByStatus).mockResolvedValue([makeReviewingPR()] as any);
+    vi.mocked(getAllTeams).mockResolvedValue([
       { id: 'team-1', repo_path: 'repos/mini-marty' },
     ] as any);
 
@@ -421,8 +426,8 @@ describe('autoRejectCommentOnlyReviews', () => {
   });
 
   it('should skip bot "Looks good to me" comments under 100 chars', async () => {
-    vi.mocked(getPullRequestsByStatus).mockReturnValue([makeReviewingPR()] as any);
-    vi.mocked(getAllTeams).mockReturnValue([
+    vi.mocked(getPullRequestsByStatus).mockResolvedValue([makeReviewingPR()] as any);
+    vi.mocked(getAllTeams).mockResolvedValue([
       { id: 'team-1', repo_path: 'repos/mini-marty' },
     ] as any);
 
@@ -453,8 +458,8 @@ describe('autoRejectCommentOnlyReviews', () => {
   });
 
   it('should gracefully skip PR when GitHub API call fails', async () => {
-    vi.mocked(getPullRequestsByStatus).mockReturnValue([makeReviewingPR()] as any);
-    vi.mocked(getAllTeams).mockReturnValue([
+    vi.mocked(getPullRequestsByStatus).mockResolvedValue([makeReviewingPR()] as any);
+    vi.mocked(getAllTeams).mockResolvedValue([
       { id: 'team-1', repo_path: 'repos/mini-marty' },
     ] as any);
 
@@ -481,8 +486,8 @@ describe('autoRejectCommentOnlyReviews', () => {
   });
 
   it('should notify developer agent via tmux after rejection', async () => {
-    vi.mocked(getPullRequestsByStatus).mockReturnValue([makeReviewingPR()] as any);
-    vi.mocked(getAllTeams).mockReturnValue([
+    vi.mocked(getPullRequestsByStatus).mockResolvedValue([makeReviewingPR()] as any);
+    vi.mocked(getAllTeams).mockResolvedValue([
       { id: 'team-1', repo_path: 'repos/mini-marty' },
     ] as any);
 
@@ -514,8 +519,8 @@ describe('autoRejectCommentOnlyReviews', () => {
   });
 
   it('should handle idle status from agent record even without agentStates entry', async () => {
-    vi.mocked(getPullRequestsByStatus).mockReturnValue([makeReviewingPR()] as any);
-    vi.mocked(getAllTeams).mockReturnValue([
+    vi.mocked(getPullRequestsByStatus).mockResolvedValue([makeReviewingPR()] as any);
+    vi.mocked(getAllTeams).mockResolvedValue([
       { id: 'team-1', repo_path: 'repos/mini-marty' },
     ] as any);
 
@@ -541,8 +546,8 @@ describe('autoRejectCommentOnlyReviews', () => {
   });
 
   it('should combine feedback from both reviews and comments in rejection reason', async () => {
-    vi.mocked(getPullRequestsByStatus).mockReturnValue([makeReviewingPR()] as any);
-    vi.mocked(getAllTeams).mockReturnValue([
+    vi.mocked(getPullRequestsByStatus).mockResolvedValue([makeReviewingPR()] as any);
+    vi.mocked(getAllTeams).mockResolvedValue([
       { id: 'team-1', repo_path: 'repos/mini-marty' },
     ] as any);
 

package/src/cli/commands/manager/escalation-handler.test.ts

@@ -1,7 +1,7 @@
 // Licensed under the Hungry Ghost Hive License. See LICENSE.
 
-import type { Database } from 'sql.js';
 import { beforeEach, describe, expect, it, vi } from 'vitest';
+import type { DatabaseProvider } from '../../../db/provider.js';
 import { AgentState } from '../../../state-detectors/types.js';
 import {
   buildHumanApprovalReason,
@@ -146,19 +146,19 @@ describe('handleEscalationAndNudge interruption recovery progression', () => {
     agentStates.clear();
     const { getRecentEscalationsForAgent, getActiveEscalationsForAgent } =
       await import('../../../db/queries/escalations.js');
-    vi.mocked(getRecentEscalationsForAgent).mockReturnValue([]);
-    vi.mocked(getActiveEscalationsForAgent).mockReturnValue([]);
+    vi.mocked(getRecentEscalationsForAgent).mockResolvedValue([]);
+    vi.mocked(getActiveEscalationsForAgent).mockResolvedValue([]);
   });
 
   function makeCtx() {
-    const dbInstance = {} as Database;
+    const dbInstance = {} as DatabaseProvider;
     return {
       ctx: {
         verbose: false,
         escalatedSessions: new Set<string>(),
         counters: { nudged: 0, escalationsCreated: 0, escalationsResolved: 0 },
         config: { manager: { nudge_cooldown_ms: 60000 } },
-        withDb: async (fn: (db: { db: Database; save: () => void }) => Promise<unknown>) =>
+        withDb: async (fn: (db: { db: DatabaseProvider; save: () => void }) => Promise<unknown>) =>
           fn({ db: dbInstance, save: vi.fn() }),
       },
     };
@@ -268,14 +268,14 @@ describe('handleEscalationAndNudge — fromAgentId FK fix', () => {
   });
 
   function makeCtx() {
-    const dbInstance = {} as Database;
+    const dbInstance = {} as DatabaseProvider;
     return {
       ctx: {
         verbose: false,
         escalatedSessions: new Set<string>(),
         counters: { nudged: 0, escalationsCreated: 0, escalationsResolved: 0 },
         config: { manager: { nudge_cooldown_ms: 60000 } },
-        withDb: async (fn: (db: { db: Database; save: () => void }) => Promise<unknown>) =>
+        withDb: async (fn: (db: { db: DatabaseProvider; save: () => void }) => Promise<unknown>) =>
           fn({ db: dbInstance, save: vi.fn() }),
       },
       dbInstance,
@@ -285,8 +285,8 @@ describe('handleEscalationAndNudge — fromAgentId FK fix', () => {
   it('uses agent.id (not session name) as fromAgentId when creating an escalation', async () => {
     const { createEscalation, getRecentEscalationsForAgent } =
       await import('../../../db/queries/escalations.js');
-    vi.mocked(getRecentEscalationsForAgent).mockReturnValue([]);
-    vi.mocked(createEscalation).mockReturnValue({
+    vi.mocked(getRecentEscalationsForAgent).mockResolvedValue([]);
+    vi.mocked(createEscalation).mockResolvedValue({
       id: 'ESC-TEST',
       story_id: 'STORY-001',
       from_agent_id: 'senior-AbCdEf',
@@ -299,7 +299,7 @@ describe('handleEscalationAndNudge — fromAgentId FK fix', () => {
     });
 
     const { createLog } = await import('../../../db/queries/logs.js');
-    vi.mocked(createLog).mockReturnValue(undefined as never);
+    vi.mocked(createLog).mockResolvedValue(undefined as never);
 
     const { ctx } = makeCtx();
     const sessionName = 'hive-senior-AbCdEf'; // tmux session name with hive- prefix
@@ -327,8 +327,8 @@ describe('handleEscalationAndNudge — fromAgentId FK fix', () => {
   it('uses null as fromAgentId when agent is undefined', async () => {
     const { createEscalation, getRecentEscalationsForAgent } =
       await import('../../../db/queries/escalations.js');
-    vi.mocked(getRecentEscalationsForAgent).mockReturnValue([]);
-    vi.mocked(createEscalation).mockReturnValue({
+    vi.mocked(getRecentEscalationsForAgent).mockResolvedValue([]);
+    vi.mocked(createEscalation).mockResolvedValue({
       id: 'ESC-NULL',
       story_id: null,
       from_agent_id: null,
@@ -341,7 +341,7 @@ describe('handleEscalationAndNudge — fromAgentId FK fix', () => {
     });
 
     const { createLog } = await import('../../../db/queries/logs.js');
-    vi.mocked(createLog).mockReturnValue(undefined as never);
+    vi.mocked(createLog).mockResolvedValue(undefined as never);
 
     const { ctx } = makeCtx();
 

package/src/cli/commands/manager/escalation-handler.ts

@@ -1,7 +1,7 @@
 // Licensed under the Hungry Ghost Hive License. See LICENSE.
 
 import chalk from 'chalk';
-import type { getAllAgents } from '../../../db/queries/agents.js';
+import type { AgentRow } from '../../../db/queries/agents.js';
 import {
   createEscalation,
   getActiveEscalationsForAgent,
@@ -131,7 +131,7 @@ export function buildRateLimitRecoveryPrompt(
 export async function handleEscalationAndNudge(
   ctx: ManagerCheckContext,
   sessionName: string,
-  agent: ReturnType<typeof getAllAgents>[number] | undefined,
+  agent: AgentRow | undefined,
   stateResult: {
     state: import('../../../state-detectors/types.js').AgentState;
     isWaiting: boolean;
@@ -221,7 +221,7 @@ export async function handleEscalationAndNudge(
     }
 
     await ctx.withDb(async db => {
-      createLog(db.db, {
+      await createLog(db.provider, {
         agentId: 'manager',
         storyId: agent?.current_story_id || undefined,
         eventType: 'STORY_PROGRESS_UPDATE',
@@ -265,7 +265,7 @@ export async function handleEscalationAndNudge(
       await killTmuxSession(sessionName);
       interruptionRecoveryAttempts.delete(sessionName);
       await ctx.withDb(async db => {
-        createLog(db.db, {
+        await createLog(db.provider, {
           agentId: 'manager',
           storyId: agent?.current_story_id || undefined,
           eventType: 'STORY_PROGRESS_UPDATE',
@@ -334,7 +334,7 @@ export async function handleEscalationAndNudge(
     }
 
     await ctx.withDb(async db => {
-      createLog(db.db, {
+      await createLog(db.provider, {
         agentId: 'manager',
         storyId: agent?.current_story_id || undefined,
         eventType: 'STORY_PROGRESS_UPDATE',
@@ -370,8 +370,13 @@ export async function handleEscalationAndNudge(
     (agentId !== null &&
       (await ctx.withDb(
         async db =>
-          getRecentEscalationsForAgent(db.db, agentId, RECENT_ESCALATION_LOOKBACK_MINUTES).length >
-          0
+          (
+            await getRecentEscalationsForAgent(
+              db.provider,
+              agentId,
+              RECENT_ESCALATION_LOOKBACK_MINUTES
+            )
+          ).length > 0
       )));
   verboseLog(ctx, `escalationCheck: ${sessionName} hasRecentEscalation=${hasRecentEscalation}`);
 
@@ -387,13 +392,13 @@ export async function handleEscalationAndNudge(
     );
 
     await ctx.withDb(async db => {
-      const escalation = createEscalation(db.db, {
+      const escalation = await createEscalation(db.provider, {
         storyId,
         fromAgentId: agentId,
         toAgentId: null,
         reason: escalationReason,
       });
-      createLog(db.db, {
+      await createLog(db.provider, {
         agentId: 'manager',
         storyId,
         eventType: 'ESCALATION_CREATED',
@@ -444,16 +449,18 @@ export async function handleEscalationAndNudge(
     interruptionRecoveryAttempts.delete(sessionName);
     // Agent recovered - auto-resolve active escalations
     const resolvedCount = await ctx.withDb(async db => {
-      const activeEscalations = agentId ? getActiveEscalationsForAgent(db.db, agentId) : [];
+      const activeEscalations = agentId
+        ? await getActiveEscalationsForAgent(db.provider, agentId)
+        : [];
       for (const escalation of activeEscalations) {
-        updateEscalation(db.db, escalation.id, {
+        await updateEscalation(db.provider, escalation.id, {
           status: 'resolved',
           resolution: `Agent recovered: no longer in waiting state`,
         });
         ctx.counters.escalationsResolved++;
       }
       if (activeEscalations.length > 0) {
-        createLog(db.db, {
+        await createLog(db.provider, {
           agentId: 'manager',
           eventType: 'ESCALATION_RESOLVED',
           message: `${sessionName} recovered and manager auto-resolved ${activeEscalations.length} escalation(s)`,

package/src/cli/commands/manager/feature-sign-off.test.ts

@@ -53,7 +53,14 @@ import { checkFeatureSignOff } from './feature-sign-off.js';
 import type { ManagerCheckContext } from './types.js';
 
 function makeCtx(overrides: Partial<ManagerCheckContext> = {}): ManagerCheckContext {
-  const mockDb = { db: {} as never, save: vi.fn(), close: vi.fn(), runMigrations: vi.fn() };
+  const mockProvider = {} as never;
+  const mockDb = {
+    db: {} as never,
+    provider: mockProvider,
+    save: vi.fn(),
+    close: vi.fn(),
+    runMigrations: vi.fn(),
+  };
   const mockScheduler = {
     spawnFeatureTest: vi.fn().mockResolvedValue({ id: 'team-1-feature-test-1' }),
   };
@@ -172,7 +179,7 @@ describe('checkFeatureSignOff', () => {
 
   it('should skip when no in_progress requirements with feature branches exist', async () => {
     const ctx = makeCtx();
-    mockGetRequirementsByStatus.mockReturnValue([]);
+    mockGetRequirementsByStatus.mockResolvedValue([]);
 
     await checkFeatureSignOff(ctx);
 
@@ -181,7 +188,7 @@ describe('checkFeatureSignOff', () => {
 
   it('should skip requirements without feature_branch and with default target_branch (main)', async () => {
     const ctx = makeCtx();
-    mockGetRequirementsByStatus.mockReturnValue([
+    mockGetRequirementsByStatus.mockResolvedValue([
       makeRequirement({ feature_branch: null, target_branch: 'main' }),
     ]);
 
@@ -194,9 +201,9 @@ describe('checkFeatureSignOff', () => {
   it('should process requirements with target_branch but no feature_branch', async () => {
     const ctx = makeCtx();
     const req = makeRequirement({ feature_branch: null, target_branch: 'feature/REQ-TEST1234' });
-    mockGetRequirementsByStatus.mockReturnValue([req]);
-    mockGetStoriesByRequirement.mockReturnValue([makeStory({ status: 'merged' })]);
-    mockGetAllTeams.mockReturnValue([makeTeam()]);
+    mockGetRequirementsByStatus.mockResolvedValue([req]);
+    mockGetStoriesByRequirement.mockResolvedValue([makeStory({ status: 'merged' })]);
+    mockGetAllTeams.mockResolvedValue([makeTeam()]);
 
     await checkFeatureSignOff(ctx);
 
@@ -218,12 +225,12 @@ describe('checkFeatureSignOff', () => {
 
   it('should skip when not all stories are merged', async () => {
     const ctx = makeCtx();
-    mockGetRequirementsByStatus.mockReturnValue([makeRequirement()]);
-    mockGetStoriesByRequirement.mockReturnValue([
+    mockGetRequirementsByStatus.mockResolvedValue([makeRequirement()]);
+    mockGetStoriesByRequirement.mockResolvedValue([
       makeStory({ id: 'STORY-1', status: 'merged' }),
       makeStory({ id: 'STORY-2', status: 'in_progress' }),
     ]);
-    mockGetAllTeams.mockReturnValue([makeTeam()]);
+    mockGetAllTeams.mockResolvedValue([makeTeam()]);
 
     await checkFeatureSignOff(ctx);
 
@@ -232,9 +239,9 @@ describe('checkFeatureSignOff', () => {
 
   it('should skip requirements with no stories', async () => {
     const ctx = makeCtx();
-    mockGetRequirementsByStatus.mockReturnValue([makeRequirement()]);
-    mockGetStoriesByRequirement.mockReturnValue([]);
-    mockGetAllTeams.mockReturnValue([makeTeam()]);
+    mockGetRequirementsByStatus.mockResolvedValue([makeRequirement()]);
+    mockGetStoriesByRequirement.mockResolvedValue([]);
+    mockGetAllTeams.mockResolvedValue([makeTeam()]);
 
     await checkFeatureSignOff(ctx);
 
@@ -244,12 +251,12 @@ describe('checkFeatureSignOff', () => {
   it('should spawn feature_test agent when all stories are merged', async () => {
     const ctx = makeCtx();
     const req = makeRequirement();
-    mockGetRequirementsByStatus.mockReturnValue([req]);
-    mockGetStoriesByRequirement.mockReturnValue([
+    mockGetRequirementsByStatus.mockResolvedValue([req]);
+    mockGetStoriesByRequirement.mockResolvedValue([
       makeStory({ id: 'STORY-1', status: 'merged' }),
       makeStory({ id: 'STORY-2', status: 'merged' }),
     ]);
-    mockGetAllTeams.mockReturnValue([makeTeam()]);
+    mockGetAllTeams.mockResolvedValue([makeTeam()]);
 
     await checkFeatureSignOff(ctx);
 
@@ -278,9 +285,9 @@ describe('checkFeatureSignOff', () => {
 
   it('should create log entries on successful spawn', async () => {
     const ctx = makeCtx();
-    mockGetRequirementsByStatus.mockReturnValue([makeRequirement()]);
-    mockGetStoriesByRequirement.mockReturnValue([makeStory({ status: 'merged' })]);
-    mockGetAllTeams.mockReturnValue([makeTeam()]);
+    mockGetRequirementsByStatus.mockResolvedValue([makeRequirement()]);
+    mockGetStoriesByRequirement.mockResolvedValue([makeStory({ status: 'merged' })]);
+    mockGetAllTeams.mockResolvedValue([makeTeam()]);
 
     await checkFeatureSignOff(ctx);
 
@@ -304,14 +311,16 @@ describe('checkFeatureSignOff', () => {
     const ctx = makeCtx();
     const req1 = makeRequirement({ id: 'REQ-AAA', feature_branch: 'feature/REQ-AAA' });
     const req2 = makeRequirement({ id: 'REQ-BBB', feature_branch: 'feature/REQ-BBB' });
-    mockGetRequirementsByStatus.mockReturnValue([req1, req2]);
+    mockGetRequirementsByStatus.mockResolvedValue([req1, req2]);
     mockGetStoriesByRequirement
-      .mockReturnValueOnce([makeStory({ id: 'S-1', status: 'merged', requirement_id: 'REQ-AAA' })])
-      .mockReturnValueOnce([
+      .mockResolvedValueOnce([
+        makeStory({ id: 'S-1', status: 'merged', requirement_id: 'REQ-AAA' }),
+      ])
+      .mockResolvedValueOnce([
         makeStory({ id: 'S-2', status: 'merged', requirement_id: 'REQ-BBB' }),
         makeStory({ id: 'S-3', status: 'in_progress', requirement_id: 'REQ-BBB' }),
       ]);
-    mockGetAllTeams.mockReturnValue([makeTeam()]);
+    mockGetAllTeams.mockResolvedValue([makeTeam()]);
 
     await checkFeatureSignOff(ctx);
 
@@ -325,11 +334,11 @@ describe('checkFeatureSignOff', () => {
 
   it('should skip when story has no team_id', async () => {
     const ctx = makeCtx();
-    mockGetRequirementsByStatus.mockReturnValue([makeRequirement()]);
-    mockGetStoriesByRequirement.mockReturnValue([
+    mockGetRequirementsByStatus.mockResolvedValue([makeRequirement()]);
+    mockGetStoriesByRequirement.mockResolvedValue([
       makeStory({ status: 'merged', team_id: null as unknown as string }),
     ]);
-    mockGetAllTeams.mockReturnValue([makeTeam()]);
+    mockGetAllTeams.mockResolvedValue([makeTeam()]);
 
     await checkFeatureSignOff(ctx);
 
@@ -338,11 +347,11 @@ describe('checkFeatureSignOff', () => {
 
   it('should skip when team is not found', async () => {
     const ctx = makeCtx();
-    mockGetRequirementsByStatus.mockReturnValue([makeRequirement()]);
-    mockGetStoriesByRequirement.mockReturnValue([
+    mockGetRequirementsByStatus.mockResolvedValue([makeRequirement()]);
+    mockGetStoriesByRequirement.mockResolvedValue([
       makeStory({ status: 'merged', team_id: 'team-unknown' }),
     ]);
-    mockGetAllTeams.mockReturnValue([makeTeam({ id: 'team-other' })]);
+    mockGetAllTeams.mockResolvedValue([makeTeam({ id: 'team-other' })]);
 
     await checkFeatureSignOff(ctx);
 
@@ -355,9 +364,9 @@ describe('checkFeatureSignOff', () => {
       spawnFeatureTest: ReturnType<typeof vi.fn>;
     };
     mockScheduler.spawnFeatureTest.mockRejectedValue(new Error('spawn failed'));
-    mockGetRequirementsByStatus.mockReturnValue([makeRequirement()]);
-    mockGetStoriesByRequirement.mockReturnValue([makeStory({ status: 'merged' })]);
-    mockGetAllTeams.mockReturnValue([makeTeam()]);
+    mockGetRequirementsByStatus.mockResolvedValue([makeRequirement()]);
+    mockGetStoriesByRequirement.mockResolvedValue([makeStory({ status: 'merged' })]);
+    mockGetAllTeams.mockResolvedValue([makeTeam()]);
 
     await checkFeatureSignOff(ctx);
 

package/src/cli/commands/manager/feature-sign-off.ts

@@ -19,18 +19,18 @@ export async function checkFeatureSignOff(ctx: ManagerCheckContext): Promise<voi
   }
 
   await ctx.withDb(async (db, scheduler) => {
-    const inProgressReqs = getRequirementsByStatus(db.db, 'in_progress').filter(
+    const inProgressReqs = (await getRequirementsByStatus(db.provider, 'in_progress')).filter(
       req => req.feature_branch || req.target_branch !== 'main'
     );
     verboseLogCtx(ctx, `checkFeatureSignOff: candidates=${inProgressReqs.length}`);
 
     if (inProgressReqs.length === 0) return;
 
-    const teams = getAllTeams(db.db);
+    const teams = await getAllTeams(db.provider);
     const e2eTestsPath = ctx.config.e2e_tests!.path;
 
     for (const req of inProgressReqs) {
-      const stories = getStoriesByRequirement(db.db, req.id);
+      const stories = await getStoriesByRequirement(db.provider, req.id);
       if (stories.length === 0) {
         verboseLogCtx(ctx, `checkFeatureSignOff: req=${req.id} skip=no_stories`);
         continue;
@@ -68,7 +68,7 @@ export async function checkFeatureSignOff(ctx: ManagerCheckContext): Promise<voi
 
       try {
         // Transition requirement to sign_off
-        updateRequirement(db.db, req.id, { status: 'sign_off' });
+        await updateRequirement(db.provider, req.id, { status: 'sign_off' });
 
         // Spawn feature_test agent
         const agent = await scheduler.spawnFeatureTest(teamId, team.name, team.repo_path, {
@@ -77,7 +77,7 @@ export async function checkFeatureSignOff(ctx: ManagerCheckContext): Promise<voi
           e2eTestsPath,
         });
 
-        createLog(db.db, {
+        await createLog(db.provider, {
           agentId: agent.id,
           eventType: 'FEATURE_TEST_SPAWNED',
           message: `Spawned feature_test agent for requirement ${req.id} (branch: ${effectiveBranch})`,
@@ -88,7 +88,7 @@ export async function checkFeatureSignOff(ctx: ManagerCheckContext): Promise<voi
             stories_merged: stories.length,
           },
         });
-        createLog(db.db, {
+        await createLog(db.provider, {
           agentId: 'manager',
           eventType: 'FEATURE_SIGN_OFF_TRIGGERED',
           message: `All ${stories.length} stories merged for ${req.id} — triggered feature sign-off`,
@@ -108,7 +108,7 @@ export async function checkFeatureSignOff(ctx: ManagerCheckContext): Promise<voi
         );
       } catch (err) {
         // Revert status on failure
-        updateRequirement(db.db, req.id, { status: 'in_progress' });
+        await updateRequirement(db.provider, req.id, { status: 'in_progress' });
         db.save();
         console.error(
           chalk.red(`  Feature sign-off failed for ${req.id}:`),

package/src/cli/commands/manager/feature-test-result.ts

@@ -3,7 +3,7 @@
 import chalk from 'chalk';
 import { execSync } from 'child_process';
 import { join } from 'path';
-import { queryAll, type AgentLogRow } from '../../../db/client.js';
+import type { AgentLogRow } from '../../../db/client.js';
 import { getAgentsByType } from '../../../db/queries/agents.js';
 import { createLog } from '../../../db/queries/logs.js';
 import { getRequirementById, updateRequirement } from '../../../db/queries/requirements.js';
@@ -33,7 +33,7 @@ interface FeatureTestCandidate {
 export async function checkFeatureTestResult(ctx: ManagerCheckContext): Promise<void> {
   // Phase 1: Read DB to find candidates (brief lock)
   const candidates = await ctx.withDb(async db => {
-    const featureTestAgents = getAgentsByType(db.db, 'feature_test');
+    const featureTestAgents = await getAgentsByType(db.provider, 'feature_test');
     verboseLogCtx(ctx, `checkFeatureTestResult: agents=${featureTestAgents.length}`);
 
     if (featureTestAgents.length === 0) return [];
@@ -41,8 +41,7 @@ export async function checkFeatureTestResult(ctx: ManagerCheckContext): Promise<
     const result: FeatureTestCandidate[] = [];
 
     for (const agent of featureTestAgents) {
-      const recentLogs = queryAll<AgentLogRow>(
-        db.db,
+      const recentLogs = await db.provider.queryAll<AgentLogRow>(
         `
         SELECT * FROM agent_logs
         WHERE agent_id = ?
@@ -62,8 +61,7 @@ export async function checkFeatureTestResult(ctx: ManagerCheckContext): Promise<
       const resultLog = recentLogs[0];
       const message = resultLog.message || '';
 
-      const alreadyProcessed = queryAll<AgentLogRow>(
-        db.db,
+      const alreadyProcessed = await db.provider.queryAll<AgentLogRow>(
         `
         SELECT * FROM agent_logs
         WHERE agent_id = 'manager'
@@ -79,8 +77,7 @@ export async function checkFeatureTestResult(ctx: ManagerCheckContext): Promise<
         continue;
       }
 
-      const spawnLog = queryAll<AgentLogRow>(
-        db.db,
+      const spawnLog = await db.provider.queryAll<AgentLogRow>(
         `
         SELECT * FROM agent_logs
         WHERE agent_id = ?
@@ -104,7 +101,7 @@ export async function checkFeatureTestResult(ctx: ManagerCheckContext): Promise<
         continue;
       }
 
-      const requirement = getRequirementById(db.db, requirementId);
+      const requirement = await getRequirementById(db.provider, requirementId);
       if (!requirement) {
         verboseLogCtx(
           ctx,
@@ -142,7 +139,7 @@ export async function checkFeatureTestResult(ctx: ManagerCheckContext): Promise<
       }
 
       // Find repo path
-      const teams = getAllTeams(db.db);
+      const teams = await getAllTeams(db.provider);
       const team = teams.length > 0 ? teams[0] : null;
       if (!team) {
         verboseLogCtx(ctx, `checkFeatureTestResult: agent=${agent.id} skip=no_team`);
@@ -223,8 +220,8 @@ Co-Authored-By: Feature Test Agent <noreply@hive>`;
 
     // Phase 2b: DB writes (brief lock)
     await ctx.withDb(async db => {
-      updateRequirement(db.db, requirementId, { status: 'sign_off_passed' });
-      createLog(db.db, {
+      await updateRequirement(db.provider, requirementId, { status: 'sign_off_passed' });
+      await createLog(db.provider, {
         agentId: 'manager',
         eventType: 'FEATURE_SIGN_OFF_PASSED',
         message: `Feature sign-off PASSED for ${requirementId} — feature branch ${featureBranch} merged to main`,
@@ -247,8 +244,8 @@ Co-Authored-By: Feature Test Agent <noreply@hive>`;
   } catch (err) {
     // Revert status on failure (brief lock)
     await ctx.withDb(async db => {
-      updateRequirement(db.db, requirementId, { status: 'sign_off' });
-      createLog(db.db, {
+      await updateRequirement(db.provider, requirementId, { status: 'sign_off' });
+      await createLog(db.provider, {
         agentId: 'manager',
         eventType: 'FEATURE_SIGN_OFF_FAILED',
         status: 'error',
@@ -281,8 +278,8 @@ async function handleTestFailure(
   );
 
   await ctx.withDb(async db => {
-    updateRequirement(db.db, requirementId, { status: 'sign_off_failed' });
-    createLog(db.db, {
+    await updateRequirement(db.provider, requirementId, { status: 'sign_off_failed' });
+    await createLog(db.provider, {
       agentId: 'manager',
       eventType: 'FEATURE_SIGN_OFF_FAILED',
       message: `Feature sign-off FAILED for ${requirementId} — E2E tests failed on ${featureBranch}`,