hungry-ghost-hive 0.48.0 → 0.49.0

package/dist/db/queries/pull-requests.test.js

@@ -1,5 +1,6 @@
 // Licensed under the Hungry Ghost Hive License. See LICENSE.
 import { beforeEach, describe, expect, it } from 'vitest';
+import { SqliteProvider } from '../provider.js';
 import { createPullRequest, deletePullRequest, getAllPullRequests, getApprovedPullRequests, getMergeQueue, getNextInQueue, getPullRequestByGithubNumber, getPullRequestById, getPullRequestByStory, getPullRequestsByStatus, getPullRequestsByTeam, getQueuePosition, isAgentReviewingPR, updatePullRequest, } from './pull-requests.js';
 import { createStory } from './stories.js';
 import { createTeam } from './teams.js';
@@ -9,14 +10,15 @@ describe('pull-requests queries', () => {
     let teamId;
     let storyId;
     beforeEach(async () => {
-        db = await createTestDatabase();
-        const team = createTeam(db, {
+        const rawDb = await createTestDatabase();
+        db = new SqliteProvider(rawDb);
+        const team = await createTeam(db, {
             repoUrl: 'https://github.com/test/repo.git',
             repoPath: '/path/to/repo',
             name: 'Test Team',
         });
         teamId = team.id;
-        const story = createStory(db, {
+        const story = await createStory(db, {
             title: 'Test Story',
             description: 'Test description',
             teamId,
@@ -24,8 +26,8 @@ describe('pull-requests queries', () => {
         storyId = story.id;
     });
     describe('createPullRequest', () => {
-        it('should create a pull request with all fields', () => {
-            const pr = createPullRequest(db, {
+        it('should create a pull request with all fields', async () => {
+            const pr = await createPullRequest(db, {
                 storyId,
                 teamId,
                 branchName: 'feature/test-branch',
@@ -43,8 +45,8 @@ describe('pull-requests queries', () => {
             expect(pr.status).toBe('queued');
             expect(pr.created_at).toBeDefined();
         });
-        it('should create PR with only required fields', () => {
-            const pr = createPullRequest(db, {
+        it('should create PR with only required fields', async () => {
+            const pr = await createPullRequest(db, {
                 branchName: 'feature/simple-branch',
             });
             expect(pr.branch_name).toBe('feature/simple-branch');
@@ -53,13 +55,13 @@ describe('pull-requests queries', () => {
             expect(pr.github_pr_number).toBeNull();
             expect(pr.status).toBe('queued');
         });
-        it('should generate unique IDs', () => {
-            const pr1 = createPullRequest(db, { branchName: 'branch-1' });
-            const pr2 = createPullRequest(db, { branchName: 'branch-2' });
+        it('should generate unique IDs', async () => {
+            const pr1 = await createPullRequest(db, { branchName: 'branch-1' });
+            const pr2 = await createPullRequest(db, { branchName: 'branch-2' });
             expect(pr1.id).not.toBe(pr2.id);
         });
-        it('should extract PR number from github_pr_url when creating PR', () => {
-            const pr = createPullRequest(db, {
+        it('should extract PR number from github_pr_url when creating PR', async () => {
+            const pr = await createPullRequest(db, {
                 storyId,
                 teamId,
                 branchName: 'feature/extract-test',
@@ -69,16 +71,16 @@ describe('pull-requests queries', () => {
             expect(pr.github_pr_number).toBe(456);
             expect(pr.github_pr_url).toBe('https://github.com/test/repo/pull/456');
         });
-        it('should prefer explicit githubPrNumber over extracted from URL', () => {
-            const pr = createPullRequest(db, {
+        it('should prefer explicit githubPrNumber over extracted from URL', async () => {
+            const pr = await createPullRequest(db, {
                 branchName: 'feature/prefer-explicit',
                 githubPrNumber: 789,
                 githubPrUrl: 'https://github.com/test/repo/pull/456',
             });
             expect(pr.github_pr_number).toBe(789);
         });
-        it('should handle malformed github_pr_url gracefully', () => {
-            const pr = createPullRequest(db, {
+        it('should handle malformed github_pr_url gracefully', async () => {
+            const pr = await createPullRequest(db, {
                 branchName: 'feature/malformed-url',
                 githubPrUrl: 'https://github.com/test/repo',
             });
@@ -87,149 +89,149 @@ describe('pull-requests queries', () => {
         });
     });
     describe('getPullRequestById', () => {
-        it('should retrieve a PR by ID', () => {
-            const created = createPullRequest(db, {
+        it('should retrieve a PR by ID', async () => {
+            const created = await createPullRequest(db, {
                 branchName: 'feature/test',
                 storyId,
             });
-            const retrieved = getPullRequestById(db, created.id);
+            const retrieved = await getPullRequestById(db, created.id);
             expect(retrieved).toBeDefined();
             expect(retrieved?.id).toBe(created.id);
             expect(retrieved?.branch_name).toBe('feature/test');
         });
-        it('should return undefined for non-existent PR', () => {
-            const result = getPullRequestById(db, 'non-existent-id');
+        it('should return undefined for non-existent PR', async () => {
+            const result = await getPullRequestById(db, 'non-existent-id');
             expect(result).toBeUndefined();
         });
     });
     describe('getPullRequestByStory', () => {
-        it('should retrieve a PR by story ID', () => {
-            const pr = createPullRequest(db, {
+        it('should retrieve a PR by story ID', async () => {
+            const pr = await createPullRequest(db, {
                 storyId,
                 branchName: 'feature/story-branch',
             });
-            const retrieved = getPullRequestByStory(db, storyId);
+            const retrieved = await getPullRequestByStory(db, storyId);
             expect(retrieved).toBeDefined();
             expect(retrieved?.id).toBe(pr.id);
             expect(retrieved?.story_id).toBe(storyId);
         });
-        it('should return undefined when no PR for story', () => {
-            const result = getPullRequestByStory(db, 'non-existent-story');
+        it('should return undefined when no PR for story', async () => {
+            const result = await getPullRequestByStory(db, 'non-existent-story');
             expect(result).toBeUndefined();
         });
     });
     describe('getPullRequestByGithubNumber', () => {
-        it('should retrieve a PR by GitHub PR number', () => {
-            const pr = createPullRequest(db, {
+        it('should retrieve a PR by GitHub PR number', async () => {
+            const pr = await createPullRequest(db, {
                 branchName: 'feature/test',
                 githubPrNumber: 456,
             });
-            const retrieved = getPullRequestByGithubNumber(db, 456);
+            const retrieved = await getPullRequestByGithubNumber(db, 456);
             expect(retrieved).toBeDefined();
             expect(retrieved?.id).toBe(pr.id);
             expect(retrieved?.github_pr_number).toBe(456);
         });
-        it('should return undefined for non-existent PR number', () => {
-            const result = getPullRequestByGithubNumber(db, 999);
+        it('should return undefined for non-existent PR number', async () => {
+            const result = await getPullRequestByGithubNumber(db, 999);
             expect(result).toBeUndefined();
         });
     });
     describe('getMergeQueue', () => {
-        it('should return queued and reviewing PRs', () => {
-            const pr1 = createPullRequest(db, { branchName: 'branch-1', teamId });
-            const pr2 = createPullRequest(db, { branchName: 'branch-2', teamId });
-            updatePullRequest(db, pr2.id, { status: 'reviewing' });
-            const pr3 = createPullRequest(db, { branchName: 'branch-3', teamId });
-            updatePullRequest(db, pr3.id, { status: 'merged' });
-            const queue = getMergeQueue(db);
+        it('should return queued and reviewing PRs', async () => {
+            const pr1 = await createPullRequest(db, { branchName: 'branch-1', teamId });
+            const pr2 = await createPullRequest(db, { branchName: 'branch-2', teamId });
+            await updatePullRequest(db, pr2.id, { status: 'reviewing' });
+            const pr3 = await createPullRequest(db, { branchName: 'branch-3', teamId });
+            await updatePullRequest(db, pr3.id, { status: 'merged' });
+            const queue = await getMergeQueue(db);
             expect(queue).toHaveLength(2);
             expect(queue.map(p => p.id)).toContain(pr1.id);
             expect(queue.map(p => p.id)).toContain(pr2.id);
             expect(queue.map(p => p.id)).not.toContain(pr3.id);
         });
-        it('should filter by team when teamId provided', () => {
-            const team2 = createTeam(db, {
+        it('should filter by team when teamId provided', async () => {
+            const team2 = await createTeam(db, {
                 repoUrl: 'https://github.com/test/repo2.git',
                 repoPath: '/path/to/repo2',
                 name: 'Team 2',
             });
-            const pr1 = createPullRequest(db, { branchName: 'branch-1', teamId });
-            createPullRequest(db, { branchName: 'branch-2', teamId: team2.id });
-            const queue = getMergeQueue(db, teamId);
+            const pr1 = await createPullRequest(db, { branchName: 'branch-1', teamId });
+            await createPullRequest(db, { branchName: 'branch-2', teamId: team2.id });
+            const queue = await getMergeQueue(db, teamId);
             expect(queue).toHaveLength(1);
             expect(queue[0].id).toBe(pr1.id);
         });
-        it('should order by created_at ASC', () => {
-            const pr1 = createPullRequest(db, { branchName: 'first', teamId });
-            const pr2 = createPullRequest(db, { branchName: 'second', teamId });
-            const queue = getMergeQueue(db);
+        it('should order by created_at ASC', async () => {
+            const pr1 = await createPullRequest(db, { branchName: 'first', teamId });
+            const pr2 = await createPullRequest(db, { branchName: 'second', teamId });
+            const queue = await getMergeQueue(db);
             expect(queue[0].id).toBe(pr1.id);
             expect(queue[1].id).toBe(pr2.id);
         });
     });
     describe('getNextInQueue', () => {
-        it('should return the oldest queued PR', () => {
-            createPullRequest(db, { branchName: 'branch-1', teamId });
-            const pr2 = createPullRequest(db, { branchName: 'branch-2', teamId });
-            updatePullRequest(db, pr2.id, { status: 'reviewing' });
-            createPullRequest(db, { branchName: 'branch-3', teamId });
-            const next = getNextInQueue(db);
+        it('should return the oldest queued PR', async () => {
+            await createPullRequest(db, { branchName: 'branch-1', teamId });
+            const pr2 = await createPullRequest(db, { branchName: 'branch-2', teamId });
+            await updatePullRequest(db, pr2.id, { status: 'reviewing' });
+            await createPullRequest(db, { branchName: 'branch-3', teamId });
+            const next = await getNextInQueue(db);
             expect(next).toBeDefined();
             expect(next?.id).not.toBe(pr2.id); // pr2 is reviewing, not queued
             expect(next?.status).toBe('queued');
         });
-        it('should filter by team when teamId provided', () => {
-            const team2 = createTeam(db, {
+        it('should filter by team when teamId provided', async () => {
+            const team2 = await createTeam(db, {
                 repoUrl: 'https://github.com/test/repo2.git',
                 repoPath: '/path/to/repo2',
                 name: 'Team 2',
             });
-            createPullRequest(db, { branchName: 'branch-1', teamId: team2.id });
-            const pr2 = createPullRequest(db, { branchName: 'branch-2', teamId });
-            const next = getNextInQueue(db, teamId);
+            await createPullRequest(db, { branchName: 'branch-1', teamId: team2.id });
+            const pr2 = await createPullRequest(db, { branchName: 'branch-2', teamId });
+            const next = await getNextInQueue(db, teamId);
             expect(next?.id).toBe(pr2.id);
         });
-        it('should return undefined when no queued PRs', () => {
-            const pr = createPullRequest(db, { branchName: 'branch-1', teamId });
-            updatePullRequest(db, pr.id, { status: 'merged' });
-            const next = getNextInQueue(db);
+        it('should return undefined when no queued PRs', async () => {
+            const pr = await createPullRequest(db, { branchName: 'branch-1', teamId });
+            await updatePullRequest(db, pr.id, { status: 'merged' });
+            const next = await getNextInQueue(db);
             expect(next).toBeUndefined();
         });
     });
     describe('getQueuePosition', () => {
-        it('should return correct position in queue', () => {
-            const pr1 = createPullRequest(db, { branchName: 'branch-1', teamId });
-            const pr2 = createPullRequest(db, { branchName: 'branch-2', teamId });
-            const pr3 = createPullRequest(db, { branchName: 'branch-3', teamId });
-            expect(getQueuePosition(db, pr1.id)).toBe(1);
-            expect(getQueuePosition(db, pr2.id)).toBe(2);
-            expect(getQueuePosition(db, pr3.id)).toBe(3);
-        });
-        it('should return -1 for PR not in queue', () => {
-            const pr = createPullRequest(db, { branchName: 'branch-1', teamId });
-            updatePullRequest(db, pr.id, { status: 'merged' });
-            expect(getQueuePosition(db, pr.id)).toBe(-1);
-        });
-        it('should return -1 for non-existent PR', () => {
-            expect(getQueuePosition(db, 'non-existent-id')).toBe(-1);
+        it('should return correct position in queue', async () => {
+            const pr1 = await createPullRequest(db, { branchName: 'branch-1', teamId });
+            const pr2 = await createPullRequest(db, { branchName: 'branch-2', teamId });
+            const pr3 = await createPullRequest(db, { branchName: 'branch-3', teamId });
+            expect(await getQueuePosition(db, pr1.id)).toBe(1);
+            expect(await getQueuePosition(db, pr2.id)).toBe(2);
+            expect(await getQueuePosition(db, pr3.id)).toBe(3);
+        });
+        it('should return -1 for PR not in queue', async () => {
+            const pr = await createPullRequest(db, { branchName: 'branch-1', teamId });
+            await updatePullRequest(db, pr.id, { status: 'merged' });
+            expect(await getQueuePosition(db, pr.id)).toBe(-1);
+        });
+        it('should return -1 for non-existent PR', async () => {
+            expect(await getQueuePosition(db, 'non-existent-id')).toBe(-1);
         });
     });
     describe('getPullRequestsByStatus', () => {
-        it('should filter PRs by status', () => {
-            const pr1 = createPullRequest(db, { branchName: 'branch-1' });
-            const pr2 = createPullRequest(db, { branchName: 'branch-2' });
-            updatePullRequest(db, pr2.id, { status: 'approved' });
-            const queued = getPullRequestsByStatus(db, 'queued');
-            const approved = getPullRequestsByStatus(db, 'approved');
+        it('should filter PRs by status', async () => {
+            const pr1 = await createPullRequest(db, { branchName: 'branch-1' });
+            const pr2 = await createPullRequest(db, { branchName: 'branch-2' });
+            await updatePullRequest(db, pr2.id, { status: 'approved' });
+            const queued = await getPullRequestsByStatus(db, 'queued');
+            const approved = await getPullRequestsByStatus(db, 'approved');
             expect(queued).toHaveLength(1);
             expect(queued[0].id).toBe(pr1.id);
             expect(approved).toHaveLength(1);
             expect(approved[0].id).toBe(pr2.id);
         });
-        it('should order by created_at DESC', () => {
-            const pr1 = createPullRequest(db, { branchName: 'first' });
-            const pr2 = createPullRequest(db, { branchName: 'second' });
-            const queued = getPullRequestsByStatus(db, 'queued');
+        it('should order by created_at DESC', async () => {
+            const pr1 = await createPullRequest(db, { branchName: 'first' });
+            const pr2 = await createPullRequest(db, { branchName: 'second' });
+            const queued = await getPullRequestsByStatus(db, 'queued');
             expect(queued).toHaveLength(2);
             // Verify both PRs are present
             expect(queued.map(p => p.id)).toContain(pr1.id);
@@ -237,32 +239,32 @@ describe('pull-requests queries', () => {
         });
     });
     describe('getApprovedPullRequests', () => {
-        it('should return only approved PRs', () => {
-            createPullRequest(db, { branchName: 'branch-1' });
-            const pr2 = createPullRequest(db, { branchName: 'branch-2' });
-            updatePullRequest(db, pr2.id, { status: 'approved' });
-            const pr3 = createPullRequest(db, { branchName: 'branch-3' });
-            updatePullRequest(db, pr3.id, { status: 'approved' });
-            const approved = getApprovedPullRequests(db);
+        it('should return only approved PRs', async () => {
+            await createPullRequest(db, { branchName: 'branch-1' });
+            const pr2 = await createPullRequest(db, { branchName: 'branch-2' });
+            await updatePullRequest(db, pr2.id, { status: 'approved' });
+            const pr3 = await createPullRequest(db, { branchName: 'branch-3' });
+            await updatePullRequest(db, pr3.id, { status: 'approved' });
+            const approved = await getApprovedPullRequests(db);
             expect(approved).toHaveLength(2);
             expect(approved.map(p => p.id)).toContain(pr2.id);
             expect(approved.map(p => p.id)).toContain(pr3.id);
         });
-        it('should order by created_at ASC', () => {
-            const pr1 = createPullRequest(db, { branchName: 'first' });
-            updatePullRequest(db, pr1.id, { status: 'approved' });
-            const pr2 = createPullRequest(db, { branchName: 'second' });
-            updatePullRequest(db, pr2.id, { status: 'approved' });
-            const approved = getApprovedPullRequests(db);
+        it('should order by created_at ASC', async () => {
+            const pr1 = await createPullRequest(db, { branchName: 'first' });
+            await updatePullRequest(db, pr1.id, { status: 'approved' });
+            const pr2 = await createPullRequest(db, { branchName: 'second' });
+            await updatePullRequest(db, pr2.id, { status: 'approved' });
+            const approved = await getApprovedPullRequests(db);
             expect(approved[0].id).toBe(pr1.id);
             expect(approved[1].id).toBe(pr2.id);
         });
     });
     describe('getAllPullRequests', () => {
-        it('should return all PRs ordered by created_at DESC', () => {
-            const pr1 = createPullRequest(db, { branchName: 'first' });
-            const pr2 = createPullRequest(db, { branchName: 'second' });
-            const prs = getAllPullRequests(db);
+        it('should return all PRs ordered by created_at DESC', async () => {
+            const pr1 = await createPullRequest(db, { branchName: 'first' });
+            const pr2 = await createPullRequest(db, { branchName: 'second' });
+            const prs = await getAllPullRequests(db);
             expect(prs).toHaveLength(2);
             // Verify both PRs are present
             expect(prs.map(p => p.id)).toContain(pr1.id);
@@ -270,61 +272,61 @@ describe('pull-requests queries', () => {
         });
     });
     describe('getPullRequestsByTeam', () => {
-        it('should filter PRs by team', () => {
-            const team2 = createTeam(db, {
+        it('should filter PRs by team', async () => {
+            const team2 = await createTeam(db, {
                 repoUrl: 'https://github.com/test/repo2.git',
                 repoPath: '/path/to/repo2',
                 name: 'Team 2',
             });
-            const pr1 = createPullRequest(db, { branchName: 'branch-1', teamId });
-            createPullRequest(db, { branchName: 'branch-2', teamId: team2.id });
-            const teamPrs = getPullRequestsByTeam(db, teamId);
+            const pr1 = await createPullRequest(db, { branchName: 'branch-1', teamId });
+            await createPullRequest(db, { branchName: 'branch-2', teamId: team2.id });
+            const teamPrs = await getPullRequestsByTeam(db, teamId);
             expect(teamPrs).toHaveLength(1);
             expect(teamPrs[0].id).toBe(pr1.id);
         });
     });
     describe('updatePullRequest', () => {
-        it('should update PR status', () => {
-            const pr = createPullRequest(db, { branchName: 'test' });
-            const updated = updatePullRequest(db, pr.id, { status: 'reviewing' });
+        it('should update PR status', async () => {
+            const pr = await createPullRequest(db, { branchName: 'test' });
+            const updated = await updatePullRequest(db, pr.id, { status: 'reviewing' });
             expect(updated?.status).toBe('reviewing');
         });
-        it('should set reviewed_at when status changes to reviewing', () => {
-            const pr = createPullRequest(db, { branchName: 'test' });
-            const updated = updatePullRequest(db, pr.id, { status: 'reviewing' });
+        it('should set reviewed_at when status changes to reviewing', async () => {
+            const pr = await createPullRequest(db, { branchName: 'test' });
+            const updated = await updatePullRequest(db, pr.id, { status: 'reviewing' });
             expect(updated?.reviewed_at).toBeDefined();
         });
-        it('should set reviewed_at when status changes to approved', () => {
-            const pr = createPullRequest(db, { branchName: 'test' });
-            const updated = updatePullRequest(db, pr.id, { status: 'approved' });
+        it('should set reviewed_at when status changes to approved', async () => {
+            const pr = await createPullRequest(db, { branchName: 'test' });
+            const updated = await updatePullRequest(db, pr.id, { status: 'approved' });
             expect(updated?.reviewed_at).toBeDefined();
         });
-        it('should update reviewedBy', () => {
-            const pr = createPullRequest(db, { branchName: 'test' });
-            const updated = updatePullRequest(db, pr.id, {
+        it('should update reviewedBy', async () => {
+            const pr = await createPullRequest(db, { branchName: 'test' });
+            const updated = await updatePullRequest(db, pr.id, {
                 reviewedBy: 'qa-agent-123',
             });
             expect(updated?.reviewed_by).toBe('qa-agent-123');
         });
-        it('should update reviewNotes', () => {
-            const pr = createPullRequest(db, { branchName: 'test' });
-            const updated = updatePullRequest(db, pr.id, {
+        it('should update reviewNotes', async () => {
+            const pr = await createPullRequest(db, { branchName: 'test' });
+            const updated = await updatePullRequest(db, pr.id, {
                 reviewNotes: 'LGTM! Good work.',
             });
             expect(updated?.review_notes).toBe('LGTM! Good work.');
         });
-        it('should update GitHub PR details', () => {
-            const pr = createPullRequest(db, { branchName: 'test' });
-            const updated = updatePullRequest(db, pr.id, {
+        it('should update GitHub PR details', async () => {
+            const pr = await createPullRequest(db, { branchName: 'test' });
+            const updated = await updatePullRequest(db, pr.id, {
                 githubPrNumber: 789,
                 githubPrUrl: 'https://github.com/test/repo/pull/789',
             });
             expect(updated?.github_pr_number).toBe(789);
             expect(updated?.github_pr_url).toBe('https://github.com/test/repo/pull/789');
         });
-        it('should update multiple fields at once', () => {
-            const pr = createPullRequest(db, { branchName: 'test' });
-            const updated = updatePullRequest(db, pr.id, {
+        it('should update multiple fields at once', async () => {
+            const pr = await createPullRequest(db, { branchName: 'test' });
+            const updated = await updatePullRequest(db, pr.id, {
                 status: 'approved',
                 reviewedBy: 'qa-agent',
                 reviewNotes: 'Approved',
@@ -333,114 +335,114 @@ describe('pull-requests queries', () => {
             expect(updated?.reviewed_by).toBe('qa-agent');
             expect(updated?.review_notes).toBe('Approved');
         });
-        it('should update updated_at timestamp', () => {
-            const pr = createPullRequest(db, { branchName: 'test' });
-            const updated = updatePullRequest(db, pr.id, { status: 'reviewing' });
+        it('should update updated_at timestamp', async () => {
+            const pr = await createPullRequest(db, { branchName: 'test' });
+            const updated = await updatePullRequest(db, pr.id, { status: 'reviewing' });
             // Verify updated_at exists and is a valid timestamp
             expect(updated?.updated_at).toBeDefined();
             expect(typeof updated?.updated_at).toBe('string');
         });
-        it('should return PR when no updates provided', () => {
-            const pr = createPullRequest(db, { branchName: 'test' });
-            const updated = updatePullRequest(db, pr.id, {});
+        it('should return PR when no updates provided', async () => {
+            const pr = await createPullRequest(db, { branchName: 'test' });
+            const updated = await updatePullRequest(db, pr.id, {});
             expect(updated?.id).toBe(pr.id);
         });
-        it('should return undefined for non-existent PR', () => {
-            const updated = updatePullRequest(db, 'non-existent-id', { status: 'reviewing' });
+        it('should return undefined for non-existent PR', async () => {
+            const updated = await updatePullRequest(db, 'non-existent-id', { status: 'reviewing' });
             expect(updated).toBeUndefined();
         });
     });
     describe('deletePullRequest', () => {
-        it('should delete a PR', () => {
-            const pr = createPullRequest(db, { branchName: 'to-delete' });
-            deletePullRequest(db, pr.id);
-            const retrieved = getPullRequestById(db, pr.id);
+        it('should delete a PR', async () => {
+            const pr = await createPullRequest(db, { branchName: 'to-delete' });
+            await deletePullRequest(db, pr.id);
+            const retrieved = await getPullRequestById(db, pr.id);
             expect(retrieved).toBeUndefined();
         });
-        it('should not throw when deleting non-existent PR', () => {
-            expect(() => deletePullRequest(db, 'non-existent-id')).not.toThrow();
+        it('should not throw when deleting non-existent PR', async () => {
+            await expect(deletePullRequest(db, 'non-existent-id')).resolves.not.toThrow();
         });
     });
     describe('isAgentReviewingPR', () => {
-        it('should return true if agent has a PR in reviewing status', () => {
-            const pr = createPullRequest(db, { branchName: 'test' });
-            updatePullRequest(db, pr.id, {
+        it('should return true if agent has a PR in reviewing status', async () => {
+            const pr = await createPullRequest(db, { branchName: 'test' });
+            await updatePullRequest(db, pr.id, {
                 status: 'reviewing',
                 reviewedBy: 'qa-agent-1',
             });
-            expect(isAgentReviewingPR(db, 'qa-agent-1')).toBe(true);
+            expect(await isAgentReviewingPR(db, 'qa-agent-1')).toBe(true);
         });
-        it('should return false if agent has no PRs in reviewing status', () => {
-            const pr = createPullRequest(db, { branchName: 'test' });
-            updatePullRequest(db, pr.id, {
+        it('should return false if agent has no PRs in reviewing status', async () => {
+            const pr = await createPullRequest(db, { branchName: 'test' });
+            await updatePullRequest(db, pr.id, {
                 status: 'approved',
                 reviewedBy: 'qa-agent-1',
             });
-            expect(isAgentReviewingPR(db, 'qa-agent-1')).toBe(false);
+            expect(await isAgentReviewingPR(db, 'qa-agent-1')).toBe(false);
         });
-        it('should return false if agent has never reviewed any PR', () => {
-            expect(isAgentReviewingPR(db, 'non-existent-agent')).toBe(false);
+        it('should return false if agent has never reviewed any PR', async () => {
+            expect(await isAgentReviewingPR(db, 'non-existent-agent')).toBe(false);
         });
-        it('should not count PRs reviewed by other agents', () => {
-            const pr = createPullRequest(db, { branchName: 'test' });
-            updatePullRequest(db, pr.id, {
+        it('should not count PRs reviewed by other agents', async () => {
+            const pr = await createPullRequest(db, { branchName: 'test' });
+            await updatePullRequest(db, pr.id, {
                 status: 'reviewing',
                 reviewedBy: 'qa-agent-1',
             });
-            expect(isAgentReviewingPR(db, 'qa-agent-2')).toBe(false);
+            expect(await isAgentReviewingPR(db, 'qa-agent-2')).toBe(false);
         });
-        it('should return true only if status is exactly reviewing', () => {
+        it('should return true only if status is exactly reviewing', async () => {
             const statuses = ['queued', 'approved', 'merged', 'rejected', 'closed'];
             for (const status of statuses) {
-                const pr = createPullRequest(db, { branchName: `test-${status}` });
-                updatePullRequest(db, pr.id, {
+                const pr = await createPullRequest(db, { branchName: `test-${status}` });
+                await updatePullRequest(db, pr.id, {
                     status,
                     reviewedBy: 'qa-agent-test',
                 });
             }
-            expect(isAgentReviewingPR(db, 'qa-agent-test')).toBe(false);
+            expect(await isAgentReviewingPR(db, 'qa-agent-test')).toBe(false);
         });
-        it('should handle multiple PRs and return true if any is reviewing', () => {
-            const pr1 = createPullRequest(db, { branchName: 'test-1' });
-            updatePullRequest(db, pr1.id, {
+        it('should handle multiple PRs and return true if any is reviewing', async () => {
+            const pr1 = await createPullRequest(db, { branchName: 'test-1' });
+            await updatePullRequest(db, pr1.id, {
                 status: 'approved',
                 reviewedBy: 'qa-agent-1',
             });
-            const pr2 = createPullRequest(db, { branchName: 'test-2' });
-            updatePullRequest(db, pr2.id, {
+            const pr2 = await createPullRequest(db, { branchName: 'test-2' });
+            await updatePullRequest(db, pr2.id, {
                 status: 'reviewing',
                 reviewedBy: 'qa-agent-1',
             });
-            expect(isAgentReviewingPR(db, 'qa-agent-1')).toBe(true);
+            expect(await isAgentReviewingPR(db, 'qa-agent-1')).toBe(true);
         });
     });
     describe('edge cases', () => {
-        it('should handle all PR statuses', () => {
+        it('should handle all PR statuses', async () => {
             const statuses = ['queued', 'reviewing', 'approved', 'merged', 'rejected', 'closed'];
-            const pr = createPullRequest(db, { branchName: 'test' });
-            statuses.forEach(status => {
-                const updated = updatePullRequest(db, pr.id, { status });
+            const pr = await createPullRequest(db, { branchName: 'test' });
+            for (const status of statuses) {
+                const updated = await updatePullRequest(db, pr.id, { status });
                 expect(updated?.status).toBe(status);
-            });
+            }
         });
-        it('should handle very long review notes', () => {
-            const pr = createPullRequest(db, { branchName: 'test' });
+        it('should handle very long review notes', async () => {
+            const pr = await createPullRequest(db, { branchName: 'test' });
             const longNotes = 'A'.repeat(50000);
-            const updated = updatePullRequest(db, pr.id, { reviewNotes: longNotes });
+            const updated = await updatePullRequest(db, pr.id, { reviewNotes: longNotes });
             expect(updated?.review_notes).toBe(longNotes);
         });
-        it('should handle special characters in branch names', () => {
-            const pr = createPullRequest(db, {
+        it('should handle special characters in branch names', async () => {
+            const pr = await createPullRequest(db, {
                 branchName: 'feature/STORY-123_fix-bug-with-dashes',
             });
             expect(pr.branch_name).toBe('feature/STORY-123_fix-bug-with-dashes');
         });
-        it('should handle null fields', () => {
-            const pr = createPullRequest(db, {
+        it('should handle null fields', async () => {
+            const pr = await createPullRequest(db, {
                 branchName: 'test',
                 submittedBy: 'agent-1',
             });
-            const updated = updatePullRequest(db, pr.id, {
+            const updated = await updatePullRequest(db, pr.id, {
                 reviewedBy: null,
                 reviewNotes: null,
             });
@@ -450,11 +452,11 @@ describe('pull-requests queries', () => {
     });
     describe('getPrioritizedMergeQueue', () => {
         it('should prioritize by age when no story dependencies', async () => {
-            const pr1 = createPullRequest(db, { branchName: 'branch-1', teamId });
-            const pr2 = createPullRequest(db, { branchName: 'branch-2', teamId });
-            const pr3 = createPullRequest(db, { branchName: 'branch-3', teamId });
+            const pr1 = await createPullRequest(db, { branchName: 'branch-1', teamId });
+            const pr2 = await createPullRequest(db, { branchName: 'branch-2', teamId });
+            const pr3 = await createPullRequest(db, { branchName: 'branch-3', teamId });
             const { getPrioritizedMergeQueue } = await import('./pull-requests.js');
-            const queue = getPrioritizedMergeQueue(db, teamId);
+            const queue = await getPrioritizedMergeQueue(db, teamId);
             // Should be ordered: pr1 (oldest), pr2, pr3 (newest)
             expect(queue[0].id).toBe(pr1.id);
             expect(queue[1].id).toBe(pr2.id);
@@ -462,45 +464,40 @@ describe('pull-requests queries', () => {
         });
         it('should prioritize PRs with satisfied dependencies', async () => {
             // Create two base stories: story1 and story2
-            const story1 = createStory(db, {
+            const story1 = await createStory(db, {
                 title: 'Story 1 - Base',
                 description: 'Base story',
                 teamId,
             });
-            const story2 = createStory(db, {
+            const story2 = await createStory(db, {
                 title: 'Story 2 - Dependent',
                 description: 'Dependent story',
                 teamId,
             });
-            const story3 = createStory(db, {
+            const story3 = await createStory(db, {
                 title: 'Story 3 - Independent',
                 description: 'Independent story',
                 teamId,
             });
             // Add dependency: story2 depends on story1
             const { addStoryDependency } = await import('./stories.js');
-            addStoryDependency(db, story2.id, story1.id);
+            await addStoryDependency(db, story2.id, story1.id);
             // Create PRs in order: story3 (independent, oldest), story2 (dependent, newer), story1 (base, newest)
-            const pr3 = createPullRequest(db, {
+            const pr3 = await createPullRequest(db, {
                 storyId: story3.id,
                 branchName: 'feature/story3-independent',
                 teamId,
             });
-            const pr2_unsatisfied = createPullRequest(db, {
+            const pr2_unsatisfied = await createPullRequest(db, {
                 storyId: story2.id,
                 branchName: 'feature/story2-unsatisfied',
                 teamId,
             });
             // Update story1 to merged status (satisfies story2's dependency)
             const { updateStory } = await import('./stories.js');
-            updateStory(db, story1.id, { status: 'merged' });
+            await updateStory(db, story1.id, { status: 'merged' });
             const { getPrioritizedMergeQueue } = await import('./pull-requests.js');
-            const queue = getPrioritizedMergeQueue(db, teamId);
-            // Expected order:
-            // 1. pr2_unsatisfied (has unsatisfied dependency) - should be deprioritized
-            // 2. pr3 (independent, no dependencies) - by age after unsatisfied ones
-            // Actually: dependencies satisfied > no dependencies
-            // So: pr2 should be LAST (unsatisfied), pr3 and pr2_before_merge should be by age
+            const queue = await getPrioritizedMergeQueue(db, teamId);
             const indexIndependent = queue.findIndex(p => p.id === pr3.id);
             const indexUnsatisfied = queue.findIndex(p => p.id === pr2_unsatisfied.id);
             // Independent PR should come before dependent PR with unsatisfied dependencies