hex-audit 0.7.0 → 0.8.0

package/dashboard/app/issues/page.tsx

@@ -1,283 +1,38 @@
-import { readJsonFile, readNestedJsonFile, listSubdirs } from '@/lib/data';
-import { NotYetGenerated } from '@/components/NotYetGenerated';
-import { IssuesBoardClient, type BoardIssue } from './IssuesBoardClient';
+import { buildBoard } from '@/lib/server/board';
+import { outDir, readConfig } from '@/lib/server/workspace';
+import { readRules } from '../../../src/core/rules';
+import { EmptyState } from '@/components/ui/EmptyState';
+import { Toolbar } from '@/components/ui/SplitView';
+import { BoardClient } from './BoardClient';
 
-// Read .hex/ at request time, not at build time. Without this, next build
-// prerenders this page with whatever .hex/ data was available in the build
-// environment and ships static HTML — the dashboard then renders that
-// stale (or empty) HTML for every audit project, ignoring the runtime cwd.
 export const dynamic = 'force-dynamic';
 
-interface FindingsFile {
-  findings: Array<{
-    id: string;
-    title: string;
-    severity: 'Critical' | 'High' | 'Medium' | 'Low' | 'Info';
-    description?: string;
-    recommendation?: string;
-    resolution?: string;
-    update_from_client?: string;
-    root_cause?: { locations?: Array<{ file: string; snippet?: string }> };
-    poc?: { status?: string; file?: string | null; validation_memo?: string | null };
-    github?: { issue_number?: number; issue_url?: string; state?: string; sync_status?: string };
-    category?: string;
-  }>;
-}
-
-interface ConfigFile {
-  settings?: {
-    report?: { repository_url?: string; initial_commit?: string };
-  };
-}
-
-interface TrackingFile {
-  findings: Array<{
-    id: string;
-    title: string;
-    severity: 'Critical' | 'High' | 'Medium' | 'Low' | 'Info';
-    source?: string;
-    status?: string;
-    poc_status?: string;
-    poc_file?: string | null;
-    duplicates?: string[];
-    duplicate_of?: string | null;
-    notes?: string;
-  }>;
-}
-
-interface ComparisonFile {
-  duplicates?: Array<{
-    ai_finding: string;
-    matches: string;
-    confidence?: string;
-    match_signals?: Record<string, boolean | string>;
-    reasoning?: string;
-  }>;
-}
-
-interface AiResultFile {
-  tool: string;
-  findings: Array<{
-    id: string;
-    title: string;
-    severity: 'Critical' | 'High' | 'Medium' | 'Low' | 'Info';
-    description?: string;
-    affected_code?: Array<{ file: string; snippet?: string }>;
-    category?: string;
-  }>;
-}
-
-interface SpecConformanceFile {
-  items?: Array<{
-    id: string;
-    spec_text: string;
-    spec_location?: Record<string, unknown>;
-    status: 'CONFORMS' | 'DEVIATES' | 'PARTIAL' | 'UNVERIFIABLE' | 'UNDOCUMENTED';
-    finding: string;
-    code_location?: { file: string; line_start?: number; line_end?: number };
-    severity_hint?: 'Critical' | 'High' | 'Medium' | 'Low' | 'Info';
-  }>;
-}
-
-/**
- * Derive the GitHub sync chip state. Verified findings are push candidates
- * (unsynced until pushed); synced findings always carry an issue number.
- * Everything else gets no chip.
- */
-function computeSyncState(
-  status: string | undefined,
-  github: { issue_number?: number; state?: string; sync_status?: string } | undefined,
-): BoardIssue['sync_state'] {
-  if (status !== 'verified' && status !== 'synced') return 'none';
-  if (!github?.issue_number) return 'unsynced';
-  if (
-    github.sync_status === 'conflict' ||
-    github.sync_status === 'local_ahead' ||
-    github.sync_status === 'remote_ahead'
-  ) {
-    return 'conflict';
-  }
-  return github.state === 'closed' ? 'synced_closed' : 'synced_open';
-}
-
-function statusToColumn(status: string | undefined): BoardIssue['column'] {
-  switch (status) {
-    case 'verified':
-      return 'verified';
-    case 'synced':
-      return 'synced';
-    case 'rejected':
-      return 'invalid';
-    case 'duplicate':
-      return 'duplicate';
-    case 'pending_validation':
-    case 'unverified':
-    default:
-      return 'potential';
-  }
-}
-
-function buildBoardIssues(): BoardIssue[] {
-  const findings = readJsonFile<FindingsFile>('findings.json') ?? { findings: [] };
-  const tracking = readJsonFile<TrackingFile>('tracking.json') ?? { findings: [] };
-  const comparison = readJsonFile<ComparisonFile>('comparison.json') ?? { duplicates: [] };
-  const spec = readJsonFile<SpecConformanceFile>('spec-conformance.json') ?? { items: [] };
-
-  const findingById = new Map(findings.findings.map((f) => [f.id, f]));
-  const specById = new Map((spec.items ?? []).map((s) => [s.id, s]));
-
-  // AI results: enumerate all subdirs under ai-results/ so future tools (or
-  // legacy projects) still surface. Today only auditagent is officially
-  // supported.
-  const aiTools = listSubdirs('ai-results');
-  const aiById = new Map<string, AiResultFile['findings'][number] & { tool: string }>();
-  for (const tool of aiTools) {
-    const file = readNestedJsonFile<AiResultFile>(`ai-results/${tool}/findings.json`);
-    if (!file) continue;
-    for (const f of file.findings ?? []) {
-      aiById.set(f.id, { ...f, tool: file.tool ?? tool });
-    }
-  }
-
-  // External github findings live under external/<source>/findings.json.
-  const externalSources = listSubdirs('external');
-  for (const source of externalSources) {
-    const file = readNestedJsonFile<AiResultFile>(`external/${source}/findings.json`);
-    if (!file) continue;
-    for (const f of file.findings ?? []) {
-      aiById.set(f.id, { ...f, tool: file.tool ?? source });
-    }
-  }
-
-  const matchByLocalId = new Map<string, NonNullable<ComparisonFile['duplicates']>[number]>();
-  for (const dup of comparison.duplicates ?? []) {
-    // The schema field is named `ai_finding` historically but the dedup direction
-    // depends on source — for github-canonical hits, ai_finding is actually the
-    // local id that became the duplicate.
-    matchByLocalId.set(dup.ai_finding, dup);
-  }
-
-  const issues: BoardIssue[] = [];
-
-  // Pass 1: every tracking entry (canonical source for status + source).
-  for (const t of tracking.findings) {
-    const finding = findingById.get(t.id);
-    const aiFinding = aiById.get(t.id);
-    const specItem = specById.get(t.id);
-
-    const description = finding?.description ?? aiFinding?.description ?? specItem?.finding ?? '';
-    const recommendation = finding?.recommendation ?? '';
-    const resolution = finding?.resolution;
-    const updateFromClient = finding?.update_from_client;
-
-    const locations: BoardIssue['code_locations'] = [];
-    if (finding?.root_cause?.locations) {
-      for (const loc of finding.root_cause.locations) {
-        locations.push({ file: loc.file, snippet: loc.snippet });
-      }
-    } else if (aiFinding?.affected_code) {
-      for (const loc of aiFinding.affected_code) {
-        locations.push({ file: loc.file, snippet: loc.snippet });
-      }
-    } else if (specItem?.code_location?.file) {
-      locations.push({ file: specItem.code_location.file });
-    }
-
-    const dup = matchByLocalId.get(t.id);
-    const matchSignals = dup?.match_signals
-      ? {
-          contract: Boolean(dup.match_signals.contract),
-          function: Boolean(dup.match_signals.function),
-          root_cause: String(dup.match_signals.root_cause ?? ''),
-          attack_vector: String(dup.match_signals.attack_vector ?? ''),
-        }
-      : undefined;
-
-    issues.push({
-      id: t.id,
-      title: t.title || finding?.title || aiFinding?.title || specItem?.spec_text || t.id,
-      severity: t.severity,
-      source: (t.source as BoardIssue['source']) ?? 'manual',
-      status: (t.status as BoardIssue['status']) ?? 'pending_validation',
-      column: statusToColumn(t.status),
-      description,
-      recommendation,
-      resolution,
-      update_from_client: updateFromClient,
-      code_locations: locations,
-      github_synced: Boolean(finding?.github?.issue_number),
-      github_issue_url: finding?.github?.issue_url,
-      github_issue_number: finding?.github?.issue_number,
-      github_state: finding?.github?.state,
-      sync_state: computeSyncState(t.status, finding?.github),
-      duplicate_of: t.duplicate_of ?? dup?.matches ?? null,
-      match_signals: matchSignals,
-      reasoning: dup?.reasoning,
-      has_finding_record: Boolean(finding),
-      category: finding?.category ?? aiFinding?.category,
-      poc_status: t.poc_status as BoardIssue['poc_status'],
-      poc_file: t.poc_file ?? finding?.poc?.file ?? null,
-      notes: t.notes ?? '',
-    });
-  }
-
-  // Pass 2: findings.json entries that have no tracking row (legacy data).
-  // Render them as verified so we don't drop them silently.
-  const seen = new Set(issues.map((i) => i.id));
-  for (const f of findings.findings) {
-    if (seen.has(f.id)) continue;
-    issues.push({
-      id: f.id,
-      title: f.title,
-      severity: f.severity,
-      source: 'manual',
-      status: 'verified',
-      column: 'verified',
-      description: f.description ?? '',
-      recommendation: f.recommendation ?? '',
-      resolution: f.resolution,
-      update_from_client: f.update_from_client,
-      code_locations: f.root_cause?.locations ?? [],
-      github_synced: Boolean(f.github?.issue_number),
-      github_issue_url: f.github?.issue_url,
-      github_issue_number: f.github?.issue_number,
-      github_state: f.github?.state,
-      sync_state: computeSyncState('verified', f.github),
-      duplicate_of: null,
-      match_signals: undefined,
-      reasoning: undefined,
-      has_finding_record: true,
-      category: f.category,
-      poc_status: f.poc?.status as BoardIssue['poc_status'],
-      poc_file: f.poc?.file ?? null,
-      notes: '',
-    });
-  }
-
-  return issues;
-}
-
-export default function IssuesPage() {
-  const issues = buildBoardIssues();
-  const config = readJsonFile<ConfigFile>('config.json');
-  const formatCtx = {
-    repositoryUrl: config?.settings?.report?.repository_url,
-    commit: config?.settings?.report?.initial_commit,
-  };
+/** Board answers: which cards need a decision? */
+export default function BoardPage() {
+  const issues = buildBoard();
+  const config = readConfig();
+  const rules = readRules(outDir());
 
   if (issues.length === 0) {
     return (
-      <div>
-        <header className="mb-6">
-          <h1 className="text-title font-semibold text-text-primary">Issues</h1>
-          <p className="mt-1 text-body text-text-secondary">
-            Potential, Verified, Invalid, and Duplicate issues across all sources.
-          </p>
-        </header>
-        <NotYetGenerated command="/init-audit  (then /write-finding or /ingest-aa-report)" />
+      <div className="flex h-full flex-col">
+        <Toolbar title="Board" />
+        <EmptyState
+          sentence="No cards yet. Findings from you, agents and scans land here."
+          command="/init-audit"
+        />
       </div>
     );
   }
 
-  return <IssuesBoardClient issues={issues} formatCtx={formatCtx} />;
+  return (
+    <BoardClient
+      issues={issues}
+      rules={rules.map((r) => ({ id: r.id, kind: r.kind, text: r.text, scope: r.scope ?? [] }))}
+      formatCtx={{
+        repositoryUrl: config?.settings?.report?.repository_url,
+        commit: config?.settings?.report?.initial_commit,
+      }}
+    />
+  );
 }

package/dashboard/app/layout.tsx

@@ -1,10 +1,14 @@
 import type { Metadata } from 'next';
 import { Manrope, JetBrains_Mono } from 'next/font/google';
 import { ThemeProvider } from 'next-themes';
-import { DashboardLayout } from '@/components/DashboardLayout';
+import { Sidebar } from '@/components/ui/Sidebar';
+import { LAYOUT_BOOT } from '@/lib/pane-width';
+import { ToastProvider } from '@/components/ui/Toast';
 import { CommandPalette } from '@/components/CommandPalette';
+import { AutoRefresh } from '@/components/AutoRefresh';
 import pkg from '../../package.json';
 import { readJsonFile } from '@/lib/data';
+import { latestFixReview } from '@/lib/server/workspace';
 import './globals.css';
 
 const manrope = Manrope({
@@ -21,31 +25,42 @@ const jetbrainsMono = JetBrains_Mono({
 
 export const metadata: Metadata = {
   title: 'Hex',
-  description: 'Local dashboard for Solidity smart contract audits',
+  description: 'A calm review workspace for Solidity audits',
 };
 
-// The sidebar depends on .hex/config.json (diff mode shows Changes), so every
-// route renders at request time — including /diagram and /flows, which would
-// otherwise be prerendered with whatever config existed at build time.
+// The sidebar depends on .hex/ (diff mode or a fix review shows Changes), so every
+// route renders at request time against the audited project's `.hex/`.
 export const dynamic = 'force-dynamic';
 
-function isDiffAudit(): boolean {
-  return readJsonFile<{ project?: { mode?: string } }>('config.json')?.project?.mode === 'diff';
+interface ConfigFile {
+  project?: { name?: string; mode?: string };
 }
 
-export default function RootLayout({
-  children,
-}: {
-  children: React.ReactNode;
-}) {
+export default function RootLayout({ children }: { children: React.ReactNode }) {
+  const config = readJsonFile<ConfigFile>('config.json');
+  // Changes covers both "what moved since the base audit" (diff mode) and the
+  // fix review, which follows full audits too.
+  const showChanges =
+    config?.project?.mode === 'diff' || latestFixReview<{ generated_at: string }>() !== null;
   return (
     <html lang="en" suppressHydrationWarning>
-      <body className={`${manrope.variable} ${jetbrainsMono.variable} min-h-screen bg-surface-0 text-text-primary font-sans`}>
+      <body
+        className={`${manrope.variable} ${jetbrainsMono.variable} h-full bg-surface-0 font-sans text-text-primary`}
+      >
+        <script dangerouslySetInnerHTML={{ __html: LAYOUT_BOOT() }} />
         <ThemeProvider attribute="data-theme" defaultTheme="dark" enableSystem={false}>
-          <CommandPalette />
-          <DashboardLayout version={pkg.version} diffMode={isDiffAudit()}>
-            {children}
-          </DashboardLayout>
+          <ToastProvider>
+            <AutoRefresh />
+            <CommandPalette showChanges={showChanges} />
+            <Sidebar
+              projectName={config?.project?.name ?? null}
+              version={pkg.version}
+              showChanges={showChanges}
+            />
+            <main className="h-screen overflow-hidden bg-surface-0 transition-[margin] duration-200 ease-out md:ml-[var(--sidebar-w,220px)]">
+              {children}
+            </main>
+          </ToastProvider>
         </ThemeProvider>
       </body>
     </html>