harness-everything 0.2.2 → 0.3.6

package/scripts/verify-install.js

@@ -0,0 +1,147 @@
+#!/usr/bin/env node
+/**
+ * Verify a Harness installation against this package source.
+ *
+ * The install manifest records where Harness copied each skill. This command
+ * checks its package version, every recorded skill, and the complete file
+ * tree, so an old install is reported as stale instead of looking healthy.
+ */
+
+const crypto = require('crypto');
+const fs = require('fs');
+const os = require('os');
+const path = require('path');
+const { getWorkspaceRoot } = require('./lib/workspace');
+const manifest = require('./lib/manifest');
+
+const sourceRoot = path.resolve(__dirname, '..');
+const packageVersion = require(path.join(sourceRoot, 'package.json')).version;
+const userHome = os.homedir();
+
+function fileTreeHash(root) {
+  if (!fs.existsSync(root)) return null;
+  const files = [];
+  function walk(dir) {
+    for (const entry of fs.readdirSync(dir, { withFileTypes: true })) {
+      const full = path.join(dir, entry.name);
+      if (entry.isDirectory()) walk(full);
+      else if (entry.isFile()) files.push(path.relative(root, full).replace(/\\/g, '/') + ':' + crypto.createHash('sha256').update(fs.readFileSync(full)).digest('hex'));
+    }
+  }
+  walk(root);
+  return crypto.createHash('sha256').update(files.sort().join('\n')).digest('hex');
+}
+
+function availableSkills() {
+  return new Set(fs.readdirSync(sourceRoot, { withFileTypes: true })
+    .filter(entry => entry.isDirectory() && fs.existsSync(path.join(sourceRoot, entry.name, 'SKILL.md')))
+    .map(entry => entry.name));
+}
+
+function isHarnessSkill(dir) {
+  const skillMd = path.join(dir, 'SKILL.md');
+  if (!fs.existsSync(skillMd)) return false;
+  const raw = fs.readFileSync(skillMd, 'utf8');
+  return /(?:^|\n)\s*author:\s*["']?Miya Daniel["']?/m.test(raw);
+}
+
+function verifyManifest(manifestPath, expectedSkillRoot) {
+  const failures = [];
+  if (!fs.existsSync(manifestPath)) {
+    const known = availableSkills();
+    const legacy = expectedSkillRoot && fs.existsSync(expectedSkillRoot)
+      ? fs.readdirSync(expectedSkillRoot, { withFileTypes: true })
+        .filter(entry => entry.isDirectory() && known.has(entry.name) && isHarnessSkill(path.join(expectedSkillRoot, entry.name)))
+        .map(entry => entry.name)
+      : [];
+    if (!legacy.length) return { checked: false, failures };
+    failures.push(`STALE untracked installation: ${legacy.length} Harness skill copy/copies have no manifest`);
+    for (const id of legacy) {
+      if (fileTreeHash(path.join(sourceRoot, id)) !== fileTreeHash(path.join(expectedSkillRoot, id))) {
+        failures.push(`STALE tree: ${id} differs from source`);
+      }
+    }
+    return { checked: true, failures };
+  }
+  const data = manifest.readManifest(manifestPath);
+  if (data.package !== manifest.PACKAGE_NAME) failures.push(`manifest package is ${data.package || '(missing)'}`);
+  if (data.version !== packageVersion) failures.push(`STALE version: installed ${data.version || '(missing)'}, source ${packageVersion}`);
+  const known = availableSkills();
+  const recordedPaths = new Set();
+  for (const entry of data.skills || []) {
+    const dir = entry.dirPath;
+    recordedPaths.add(path.resolve(dir || ''));
+    if (!entry.id || !known.has(entry.id)) {
+      failures.push(`unknown or removed skill in manifest: ${entry.id || '(missing id)'}`);
+      continue;
+    }
+    if (!dir || !fs.existsSync(dir)) {
+      failures.push(`missing installed skill: ${entry.id}`);
+      continue;
+    }
+    const sourceHash = fileTreeHash(path.join(sourceRoot, entry.id));
+    const installedHash = fileTreeHash(dir);
+    if (sourceHash !== installedHash) failures.push(`STALE tree: ${entry.id} differs from source`);
+  }
+  if (expectedSkillRoot && fs.existsSync(expectedSkillRoot)) {
+    for (const entry of fs.readdirSync(expectedSkillRoot, { withFileTypes: true })) {
+      const dir = path.join(expectedSkillRoot, entry.name);
+      if (entry.isDirectory() && isHarnessSkill(dir) && !recordedPaths.has(path.resolve(dir))) {
+        failures.push(`untracked Harness skill copy: ${entry.name}`);
+      }
+    }
+  }
+  return { checked: true, failures };
+}
+
+function parseArgs() {
+  const args = process.argv.slice(2);
+  const value = (name) => {
+    const i = args.indexOf(name);
+    return i === -1 ? undefined : args[i + 1];
+  };
+  return {
+    root: value('--root') ? path.resolve(value('--root')) : getWorkspaceRoot(),
+    manifestPath: value('--manifest') ? path.resolve(value('--manifest')) : undefined,
+    global: args.includes('--global'),
+  };
+}
+
+function main() {
+  const options = parseArgs();
+  const targets = options.manifestPath
+    ? [{ manifestPath: options.manifestPath, skillRoot: path.dirname(options.manifestPath).replace(/harness-everything$/, 'skills') }]
+    : options.global
+      ? [{ manifestPath: manifest.getManifestPath(path.join(userHome, '.agents')), skillRoot: path.join(userHome, '.agents', 'skills') }]
+      : [
+        ['.claude', '.claude/skills'], ['.cursor', '.cursor/skills'], ['.github', '.github/skills'],
+        ['.codex', '.codex/skills'], ['.continue', '.continue/skills'],
+      ].map(([home, skillsPath]) => ({
+        manifestPath: manifest.getManifestPath(path.join(options.root, home)),
+        skillRoot: path.join(options.root, skillsPath),
+      }));
+  let checked = 0;
+  let failures = 0;
+  for (const target of targets) {
+    const result = verifyManifest(target.manifestPath, target.skillRoot);
+    if (!result.checked) continue;
+    checked++;
+    console.log(`Checking ${path.relative(options.root, target.manifestPath) || target.manifestPath}...`);
+    if (result.failures.length) {
+      result.failures.forEach(failure => console.error(`  FAIL ${failure}`));
+      failures += result.failures.length;
+    } else console.log('  PASS version and skill tree match source.');
+  }
+  if (!checked) {
+    console.error('No Harness installation manifest found. Install Harness before verifying it.');
+    process.exit(1);
+  }
+  if (failures) {
+    console.error(`INSTALL VERIFICATION FAILED: ${failures} problem(s).`);
+    process.exit(1);
+  }
+  console.log(`INSTALL VERIFICATION PASSED: ${checked} manifest(s).`);
+}
+
+if (require.main === module) main();
+module.exports = { fileTreeHash, verifyManifest };

package/security-review/SKILL.md

@@ -1,511 +1,50 @@
 ---
 name: security-review
-description: Use this skill when adding authentication, handling user input, working with secrets, creating API endpoints, or implementing payment/sensitive features. Provides comprehensive security checklist and patterns.
-author: Miya Daniel | Harness Core Team
-version: 0.2.0
+description: Conducts STRIDE threat modeling, scans secrets via audit scripts, and hardens code against OWASP Top 10 risks with three-tier boundary controls. Use when implementing auth, handling input/uploads, managing secrets, or auditing code before deployment.
+license: Apache-2.0
 metadata:
-  origin: ECC
+  author: Miya Daniel
+  version: 0.3.4
 ---
 
-# Security Review Skill
+# Security Review & Code Hardening
 
-## 📋 Skill Contract
+Hardens code against OWASP Top 10.
 
-| Component | Specification |
-| :--- | :--- |
-| **Trigger / Input** | Task involves Auth, API Endpoints, File Uploads, User Input, or Secrets. Input: Target code file. |
-| **Expected Output** | Security scan commands executed in terminal. Code modified to fix vulnerabilities. |
-| **State Mutations** | Codebase hardened against injection/XSS/IDOR. |
-| **Enforcement Gate** | You MUST use grep or standard security linters in the terminal to scan for secrets (`sk-`, `password`) or raw SQL interpolations BEFORE marking the security check as complete. |
-
-This skill ensures all code follows security best practices and identifies potential vulnerabilities.
-
-## When to Activate
-
-- Implementing authentication or authorization
-- Handling user input or file uploads
-- Creating new API endpoints
-- Working with secrets or credentials
-- Implementing payment features
-- Storing or transmitting sensitive data
-- Integrating third-party APIs
-
-## Security Checklist
-
-### 1. Secrets Management
-
-#### FAIL: NEVER Do This
-```typescript
-const apiKey = "sk-proj-xxxxx"  // Hardcoded secret
-const dbPassword = "password123" // In source code
-```
-
-#### PASS: ALWAYS Do This
-```typescript
-const apiKey = process.env.OPENAI_API_KEY
-const dbUrl = process.env.DATABASE_URL
-
-// Verify secrets exist
-if (!apiKey) {
-  throw new Error('OPENAI_API_KEY not configured')
-}
-```
-
-#### Verification Steps
-- [ ] No hardcoded API keys, tokens, or passwords
-- [ ] All secrets in environment variables
-- [ ] `.env.local` in .gitignore
-- [ ] No secrets in git history
-- [ ] Production secrets in hosting platform (Vercel, Railway)
-
-### 2. Input Validation
-
-#### Always Validate User Input
-```typescript
-import { z } from 'zod'
-
-// Define validation schema
-const CreateUserSchema = z.object({
-  email: z.string().email(),
-  name: z.string().min(1).max(100),
-  age: z.number().int().min(0).max(150)
-})
-
-// Validate before processing
-export async function createUser(input: unknown) {
-  try {
-    const validated = CreateUserSchema.parse(input)
-    return await db.users.create(validated)
-  } catch (error) {
-    if (error instanceof z.ZodError) {
-      return { success: false, errors: error.issues }
-    }
-    throw error
-  }
-}
-```
-
-#### File Upload Validation
-```typescript
-function validateFileUpload(file: File) {
-  // Size check (5MB max)
-  const maxSize = 5 * 1024 * 1024
-  if (file.size > maxSize) {
-    throw new Error('File too large (max 5MB)')
-  }
-
-  // Type check
-  const allowedTypes = ['image/jpeg', 'image/png', 'image/gif']
-  if (!allowedTypes.includes(file.type)) {
-    throw new Error('Invalid file type')
-  }
-
-  // Extension check
-  const allowedExtensions = ['.jpg', '.jpeg', '.png', '.gif']
-  const extension = file.name.toLowerCase().match(/\.[^.]+$/)?.[0]
-  if (!extension || !allowedExtensions.includes(extension)) {
-    throw new Error('Invalid file extension')
-  }
-
-  return true
-}
-```
-
-#### Verification Steps
-- [ ] All user inputs validated with schemas
-- [ ] File uploads restricted (size, type, extension)
-- [ ] No direct use of user input in queries
-- [ ] Whitelist validation (not blacklist)
-- [ ] Error messages don't leak sensitive info
-
-### 3. SQL Injection Prevention
-
-#### FAIL: NEVER Concatenate SQL
-```typescript
-// DANGEROUS - SQL Injection vulnerability
-const query = `SELECT * FROM users WHERE email = '${userEmail}'`
-await db.query(query)
-```
-
-#### PASS: ALWAYS Use Parameterized Queries
-```typescript
-// Safe - parameterized query
-const { data } = await supabase
-  .from('users')
-  .select('*')
-  .eq('email', userEmail)
-
-// Or with raw SQL
-await db.query(
-  'SELECT * FROM users WHERE email = $1',
-  [userEmail]
-)
-```
-
-#### Verification Steps
-- [ ] All database queries use parameterized queries
-- [ ] No string concatenation in SQL
-- [ ] ORM/query builder used correctly
-- [ ] Supabase queries properly sanitized
-
-### 4. Authentication & Authorization
-
-#### JWT Token Handling
-```typescript
-// FAIL: WRONG: localStorage (vulnerable to XSS)
-localStorage.setItem('token', token)
-
-// PASS: CORRECT: httpOnly cookies
-res.setHeader('Set-Cookie',
-  `token=${token}; HttpOnly; Secure; SameSite=Strict; Max-Age=3600`)
-```
-
-#### Authorization Checks
-```typescript
-export async function deleteUser(userId: string, requesterId: string) {
-  // ALWAYS verify authorization first
-  const requester = await db.users.findUnique({
-    where: { id: requesterId }
-  })
-
-  if (requester.role !== 'admin') {
-    return NextResponse.json(
-      { error: 'Unauthorized' },
-      { status: 403 }
-    )
-  }
-
-  // Proceed with deletion
-  await db.users.delete({ where: { id: userId } })
-}
-```
-
-#### Row Level Security (Supabase)
-```sql
--- Enable RLS on all tables
-ALTER TABLE users ENABLE ROW LEVEL SECURITY;
-
--- Users can only view their own data
-CREATE POLICY "Users view own data"
-  ON users FOR SELECT
-  USING (auth.uid() = id);
-
--- Users can only update their own data
-CREATE POLICY "Users update own data"
-  ON users FOR UPDATE
-  USING (auth.uid() = id);
-```
-
-#### Verification Steps
-- [ ] Tokens stored in httpOnly cookies (not localStorage)
-- [ ] Authorization checks before sensitive operations
-- [ ] Row Level Security enabled in Supabase
-- [ ] Role-based access control implemented
-- [ ] Session management secure
-
-### 5. XSS Prevention
-
-#### Sanitize HTML
-```typescript
-import DOMPurify from 'isomorphic-dompurify'
-
-// ALWAYS sanitize user-provided HTML
-function renderUserContent(html: string) {
-  const clean = DOMPurify.sanitize(html, {
-    ALLOWED_TAGS: ['b', 'i', 'em', 'strong', 'p'],
-    ALLOWED_ATTR: []
-  })
-  return <div dangerouslySetInnerHTML={{ __html: clean }} />
-}
-```
-
-#### Content Security Policy
-
-Start strict and loosen only with a documented removal plan. Do not default to
-`'unsafe-inline'` or `'unsafe-eval'`; they neutralize much of CSP's protection
-and should be treated as temporary compatibility debt.
-
-```typescript
-// next.config.js
-const securityHeaders = [
-  {
-    key: 'Content-Security-Policy',
-    value: `
-      default-src 'self';
-      base-uri 'self';
-      object-src 'none';
-      frame-ancestors 'none';
-      script-src 'self';
-      style-src 'self';
-      img-src 'self' data: https:;
-      font-src 'self';
-      connect-src 'self' https://api.example.com;
-    `.replace(/\s{2,}/g, ' ').trim()
-  }
-]
-```
-
-#### Verification Steps
-- [ ] User-provided HTML sanitized
-- [ ] CSP headers configured
-- [ ] No unvalidated dynamic content rendering
-- [ ] React's built-in XSS protection used
+## USE FOR:
+- AuthN or authZ implementation
+- User input, uploads, new API endpoints
+- Secrets, credentials, payment features
+- Security audit before production deploy
 
-### 6. CSRF Protection
+## DO NOT USE FOR:
+- Code review without security scope — instead use a standard pass
+- Performance profiling
+- Accessibility or UI styling fixes
 
-#### CSRF Tokens
-```typescript
-import { csrf } from '@/lib/csrf'
+## Skill Contract
 
-export async function POST(request: Request) {
-  const token = request.headers.get('X-CSRF-Token')
-
-  if (!csrf.verify(token)) {
-    return NextResponse.json(
-      { error: 'Invalid CSRF token' },
-      { status: 403 }
-    )
-  }
-
-  // Process request
-}
-```
-
-#### SameSite Cookies
-```typescript
-res.setHeader('Set-Cookie',
-  `session=${sessionId}; HttpOnly; Secure; SameSite=Strict`)
-```
-
-#### Verification Steps
-- [ ] CSRF tokens on state-changing operations
-- [ ] SameSite=Strict on all cookies
-- [ ] Double-submit cookie pattern implemented
-
-### 7. Rate Limiting
-
-#### API Rate Limiting
-```typescript
-import rateLimit from 'express-rate-limit'
-
-const limiter = rateLimit({
-  windowMs: 15 * 60 * 1000, // 15 minutes
-  max: 100, // 100 requests per window
-  message: 'Too many requests'
-})
-
-// Apply to routes
-app.use('/api/', limiter)
-```
-
-#### Expensive Operations
-```typescript
-// Aggressive rate limiting for searches
-const searchLimiter = rateLimit({
-  windowMs: 60 * 1000, // 1 minute
-  max: 10, // 10 requests per minute
-  message: 'Too many search requests'
-})
-
-app.use('/api/search', searchLimiter)
-```
-
-#### Verification Steps
-- [ ] Rate limiting on all API endpoints
-- [ ] Stricter limits on expensive operations
-- [ ] IP-based rate limiting
-- [ ] User-based rate limiting (authenticated)
-
-### 8. Sensitive Data Exposure
-
-#### Logging
-```typescript
-// FAIL: WRONG: Logging sensitive data
-console.log('User login:', { email, password })
-console.log('Payment:', { cardNumber, cvv })
-
-// PASS: CORRECT: Redact sensitive data
-console.log('User login:', { email, userId })
-console.log('Payment:', { last4: card.last4, userId })
-```
-
-#### Error Messages
-```typescript
-// FAIL: WRONG: Exposing internal details
-catch (error) {
-  return NextResponse.json(
-    { error: error.message, stack: error.stack },
-    { status: 500 }
-  )
-}
-
-// PASS: CORRECT: Generic error messages
-catch (error) {
-  console.error('Internal error:', error)
-  return NextResponse.json(
-    { error: 'An error occurred. Please try again.' },
-    { status: 500 }
-  )
-}
-```
-
-#### Verification Steps
-- [ ] No passwords, tokens, or secrets in logs
-- [ ] Error messages generic for users
-- [ ] Detailed errors only in server logs
-- [ ] No stack traces exposed to users
-
-### 9. Blockchain Security (Solana)
-
-#### Wallet Verification
-```typescript
-import { verify } from '@solana/web3.js'
-
-async function verifyWalletOwnership(
-  publicKey: string,
-  signature: string,
-  message: string
-) {
-  try {
-    const isValid = verify(
-      Buffer.from(message),
-      Buffer.from(signature, 'base64'),
-      Buffer.from(publicKey, 'base64')
-    )
-    return isValid
-  } catch (error) {
-    return false
-  }
-}
-```
-
-#### Transaction Verification
-```typescript
-async function verifyTransaction(transaction: Transaction) {
-  // Verify recipient
-  if (transaction.to !== expectedRecipient) {
-    throw new Error('Invalid recipient')
-  }
-
-  // Verify amount
-  if (transaction.amount > maxAmount) {
-    throw new Error('Amount exceeds limit')
-  }
-
-  // Verify user has sufficient balance
-  const balance = await getBalance(transaction.from)
-  if (balance < transaction.amount) {
-    throw new Error('Insufficient balance')
-  }
-
-  return true
-}
-```
-
-#### Verification Steps
-- [ ] Wallet signatures verified
-- [ ] Transaction details validated
-- [ ] Balance checks before transactions
-- [ ] No blind transaction signing
-
-### 10. Dependency Security
-
-#### Regular Updates
-```bash
-# Check for vulnerabilities
-npm audit
-
-# Fix automatically fixable issues
-npm audit fix
-
-# Update dependencies
-npm update
-
-# Check for outdated packages
-npm outdated
-```
-
-#### Lock Files
-```bash
-# ALWAYS commit lock files
-git add package-lock.json
-
-# Use in CI/CD for reproducible builds
-npm ci  # Instead of npm install
-```
-
-#### Verification Steps
-- [ ] Dependencies up to date
-- [ ] No known vulnerabilities (npm audit clean)
-- [ ] Lock files committed
-- [ ] Dependabot enabled on GitHub
-- [ ] Regular security updates
-
-## Security Testing
-
-### Automated Security Tests
-```typescript
-// Test authentication
-test('requires authentication', async () => {
-  const response = await fetch('/api/protected')
-  expect(response.status).toBe(401)
-})
-
-// Test authorization
-test('requires admin role', async () => {
-  const response = await fetch('/api/admin', {
-    headers: { Authorization: `Bearer ${userToken}` }
-  })
-  expect(response.status).toBe(403)
-})
-
-// Test input validation
-test('rejects invalid input', async () => {
-  const response = await fetch('/api/users', {
-    method: 'POST',
-    body: JSON.stringify({ email: 'not-an-email' })
-  })
-  expect(response.status).toBe(400)
-})
-
-// Test rate limiting
-test('enforces rate limits', async () => {
-  const requests = Array(101).fill(null).map(() =>
-    fetch('/api/endpoint')
-  )
-
-  const responses = await Promise.all(requests)
-  const tooManyRequests = responses.filter(r => r.status === 429)
-
-  expect(tooManyRequests.length).toBeGreaterThan(0)
-})
-```
+| Component | Specification |
+| :--- | :--- |
+| **Trigger / Input** | Auth, endpoints, uploads, user input, secrets, audit requests. |
+| **Expected Output** | Threat model, scan via `audit-secrets.js`, hardened code, audit report. |
+| **State Mutations** | Codebase hardened against injection/XSS/IDOR; report to docs or platform dir. |
+| **Enforcement Gate** | Secret scan via the script or grep before concluding review. |
 
-## Pre-Deployment Security Checklist
+## Review Flow
 
-Before ANY production deployment:
+1. Threat-model (`STRIDE`) per security-review/guides/STRIDE-THREAT-MODEL.md; misuse-case every endpoint/input.
+2. Scan secrets and injection risks:
+   ```bash
+   node "<this-skill-dir>/scripts/audit-secrets.js"
+   ```
+   Fallback: grep scan.
+3. Fix findings per the boundary system; report to `docs/security-audit.md`, or `.github/harness-everything/security-audit.md` when docs/ is protected or absent.
 
-- [ ] **Secrets**: No hardcoded secrets, all in env vars
-- [ ] **Input Validation**: All user inputs validated
-- [ ] **SQL Injection**: All queries parameterized
-- [ ] **XSS**: User content sanitized
-- [ ] **CSRF**: Protection enabled
-- [ ] **Authentication**: Proper token handling
-- [ ] **Authorization**: Role checks in place
-- [ ] **Rate Limiting**: Enabled on all endpoints
-- [ ] **HTTPS**: Enforced in production
-- [ ] **Security Headers**: CSP, X-Frame-Options configured
-- [ ] **Error Handling**: No sensitive data in errors
-- [ ] **Logging**: No sensitive data logged
-- [ ] **Dependencies**: Up to date, no vulnerabilities
-- [ ] **Row Level Security**: Enabled in Supabase
-- [ ] **CORS**: Properly configured
-- [ ] **File Uploads**: Validated (size, type)
-- [ ] **Wallet Signatures**: Verified (if blockchain)
+## Three-Tier Boundary System
 
-## Resources
+- **Always Do**: parameterize SQL, Zod-validate inputs, httpOnly cookies, secrets to `process.env`.
+- **Ask First**: CORS changes, auth/login flows, file uploads, rate limits.
+- **Never Do**: commit hardcoded secrets (`sk-`), log passwords/tokens, use eval() or unescaped innerHTML.
 
-- [OWASP Top 10](https://owasp.org/www-project-top-ten/)
-- [Next.js Security](https://nextjs.org/docs/security)
-- [Supabase Security](https://supabase.com/docs/guides/auth)
-- [Web Security Academy](https://portswigger.net/web-security)
+Deep dive: references/security-checklist.md + security-review/guides/OWASP-PATTERNS.md