harness-everything 0.2.2 → 0.3.6

package/harness-everything/scripts/verify-gate.js

@@ -1,31 +1,100 @@
-#!/usr/bin/env node
-/**
- * Verification Gatekeeper
- * Forces the AI to run this script to prove quality gates before declaring a task done.
- */
-const { execSync } = require('child_process');
-
-console.log("=== 🛡️ Harness Verification Gate ===");
-
-try {
-  console.log("Running basic checks (simulated for now)...");
-  
-  // In a real project, this would run `npm run lint` and `npm test`
-  // We'll simulate a failure if `.verify-fail.tmp` exists just to prove the mechanism.
-  const fs = require('fs');
-  if (fs.existsSync('.verify-fail.tmp')) {
-    console.error("❌ Verification FAILED: Found broken tests or lint errors.");
-    console.error("Please fix the code and run this gate again.");
-    process.exit(1);
-  }
-  
-  console.log("✅ Lint passed.");
-  console.log("✅ Tests passed.");
-  console.log("✅ Verification SUCCESS. You may now complete the task.");
-  process.exit(0);
-
-} catch (err) {
-  console.error("❌ Verification FAILED.");
-  console.error(err.message);
-  process.exit(1);
-}
+#!/usr/bin/env node
+/**
+ * Verification Gatekeeper
+ * Runs the target project's own mechanical checks (lint/test scripts from the
+ * nearest package.json) and refuses completion (Exit 1) when any of them fail.
+ *
+ * Escape hatches, both deliberate:
+ * - `.verify-fail.tmp` in cwd forces a failure - the hermetic self-regression
+ *   suite uses it to prove the blocking mechanism without needing a real
+ *   broken project.
+ * - HARNESS_SKIP_PROJECT_CHECKS=1 skips the project-script phase (the tmp-file
+ *   check above still applies). The gate sets it for its own children so a
+ *   project whose test suite itself drives the Harness runtime (like this repo) cannot
+ *   recurse back into the gate.
+ */
+const { execSync } = require('child_process');
+const fs = require('fs');
+const path = require('path');
+
+console.log("=== 🛡️ Harness Verification Gate ===");
+
+// Phase 1: explicit failure injection (test/demo hook).
+if (fs.existsSync('.verify-fail.tmp')) {
+  console.error("❌ Verification FAILED: .verify-fail.tmp present (injected failure).");
+  console.error("Please fix the code and run this gate again.");
+  process.exit(1);
+}
+
+if (process.env.HARNESS_SKIP_PROJECT_CHECKS === '1') {
+  console.log("ℹ️ HARNESS_SKIP_PROJECT_CHECKS=1 - project scripts skipped (recursion guard / hermetic test mode).");
+  console.log("✅ Verification SUCCESS (injection check only).");
+  process.exit(0);
+}
+
+// Phase 2: locate the nearest package.json, walking up from cwd but never
+// above the enclosing git repository (same scoping rule as tier-router.js).
+function findPackageDir() {
+  let dir = path.resolve(process.cwd());
+  while (true) {
+    if (fs.existsSync(path.join(dir, 'package.json'))) return dir;
+    if (fs.existsSync(path.join(dir, '.git'))) return null; // repo root reached, none found
+    const parent = path.dirname(dir);
+    if (parent === dir) return null;
+    dir = parent;
+  }
+}
+
+function detectRunner(dir) {
+  if (fs.existsSync(path.join(dir, 'pnpm-lock.yaml'))) return 'pnpm';
+  if (fs.existsSync(path.join(dir, 'yarn.lock'))) return 'yarn';
+  if (fs.existsSync(path.join(dir, 'bun.lockb')) || fs.existsSync(path.join(dir, 'bun.lock'))) return 'bun';
+  return 'npm';
+}
+
+const pkgDir = findPackageDir();
+let scripts = {};
+if (pkgDir) {
+  try {
+    scripts = JSON.parse(fs.readFileSync(path.join(pkgDir, 'package.json'), 'utf8')).scripts || {};
+  } catch (err) {
+    console.error(`❌ Verification FAILED: package.json at ${pkgDir} is unreadable/invalid JSON (${err.message}).`);
+    process.exit(1);
+  }
+}
+
+// npm-init's placeholder ("no test specified" + exit 1) is absence of a test
+// suite, not a failing one - running it would block every fresh project.
+const runnable = ['lint', 'test'].filter(name =>
+  typeof scripts[name] === 'string' &&
+  scripts[name].trim() !== '' &&
+  !/no test specified/i.test(scripts[name])
+);
+
+if (!pkgDir || runnable.length === 0) {
+  console.log("⚠️ Verification UNCHECKED: No automated lint/test scripts detected in package.json.");
+  console.log("   Exit code is 0 (non-blocking), but NO AUTOMATED EVIDENCE was produced.");
+  console.log("   PROHIBITED: Do NOT cite this run as proof that tests pass. Perform manual or alternative verification first.");
+  process.exit(0);
+}
+
+const runner = detectRunner(pkgDir);
+for (const name of runnable) {
+  console.log(`\n▶ Running "${runner} run ${name}" in ${pkgDir} ...`);
+  try {
+    execSync(`${runner} run ${name}`, {
+      cwd: pkgDir,
+      stdio: 'inherit',
+      timeout: 10 * 60 * 1000,
+      env: { ...process.env, HARNESS_SKIP_PROJECT_CHECKS: '1' }
+    });
+    console.log(`✅ ${name} passed.`);
+  } catch (err) {
+    console.error(`\n❌ Verification FAILED: "${runner} run ${name}" exited non-zero${err.signal ? ` (signal ${err.signal})` : ''}.`);
+    console.error("Fix the failures above and run this gate again.");
+    process.exit(1);
+  }
+}
+
+console.log("\n✅ Verification SUCCESS. You may now complete the task.");
+process.exit(0);

package/hooks/hooks.json

@@ -1,155 +1,155 @@
-{
-  "$schema": "https://json.schemastore.org/claude-code-settings.json",
-  "hooks": {
-    "SessionStart": [
-      {
-        "hooks": [
-          {
-            "type": "command",
-            "command": "node harness-everything/scripts/bootstrap.js"
-          }
-        ],
-        "description": "Bootstrap Harness Skills OS on session start",
-        "id": "harness:pre:bootstrap"
-      }
-    ],
-    "UserPromptSubmit": [
-      {
-        "hooks": [
-          {
-            "type": "command",
-            "command": "node harness-everything/scripts/tier-router.js"
-          }
-        ],
-        "description": "Auto-route user requests using tier-router",
-        "id": "harness:pre:tier-router"
-      }
-    ],
-    "PreToolUse": [
-      {
-        "matcher": "Bash|PowerShell|Edit|Write",
-        "hooks": [
-          {
-            "type": "command",
-            "command": "node hooks/scripts/rule-of-3.js"
-          }
-        ],
-        "description": "Rule of 3 Circuit Breaker - Prevents micro-error looping",
-        "id": "harness:pre:rule-of-3"
-      },
-      {
-        "matcher": "Grep|Glob|Read",
-        "hooks": [
-          {
-            "type": "command",
-            "command": "node hooks/scripts/boundary-guard.js"
-          }
-        ],
-        "description": "Physical boundary enforcement for searches and large file reads",
-        "id": "harness:pre:boundary-guard"
-      },
-      {
-        "matcher": "Edit|Write",
-        "hooks": [
-          {
-            "type": "command",
-            "command": "node hooks/scripts/depth-guard.js"
-          }
-        ],
-        "description": "Information depth guard - Enforce impact assessment before writing code",
-        "id": "harness:pre:depth-guard"
-      },
-      {
-        "matcher": "Edit|Write|Bash|PowerShell",
-        "hooks": [
-          {
-            "type": "command",
-            "command": "node hooks/scripts/context-compact.js"
-          }
-        ],
-        "description": "Strategic context compaction enforcement",
-        "id": "harness:pre:context-compact"
-      },
-      {
-        "matcher": "Task",
-        "hooks": [
-          {
-            "type": "command",
-            "command": "node hooks/scripts/subagent-scope-guard.js"
-          }
-        ],
-        "description": "Snapshot repo state before a subagent burst starts",
-        "id": "harness:pre:subagent-scope-guard"
-      }
-    ],
-    "Stop": [
-      {
-        "hooks": [
-          {
-            "type": "command",
-            "command": "node hooks/scripts/stop-gate.js"
-          }
-        ],
-        "description": "Pre-delivery gate - bounce the end of a turn once per edit batch when edits were never verified",
-        "id": "harness:stop:stop-gate"
-      }
-    ],
-    "PostToolUse": [
-      {
-        "matcher": "Bash|PowerShell",
-        "hooks": [
-          {
-            "type": "command",
-            "command": "node hooks/scripts/rule-of-3-tracker.js"
-          }
-        ],
-        "description": "Track error signatures for Rule of 3",
-        "id": "harness:post:rule-of-3-tracker"
-      },
-      {
-        "matcher": "Edit|Write|Bash|PowerShell",
-        "hooks": [
-          {
-            "type": "command",
-            "command": "node hooks/scripts/state-persist.js"
-          }
-        ],
-        "description": "Save skill transition state",
-        "id": "harness:post:state-persist"
-      },
-      {
-        "matcher": "Edit|Write",
-        "hooks": [
-          {
-            "type": "command",
-            "command": "node hooks/scripts/atomic-commit-check.js"
-          }
-        ],
-        "description": "Atomic commit enforcement",
-        "id": "harness:post:atomic-commit-check"
-      },
-      {
-        "matcher": "Bash|PowerShell",
-        "hooks": [
-          {
-            "type": "command",
-            "command": "node hooks/scripts/contract-test.js"
-          }
-        ],
-        "description": "Contract testing between sub-agents",
-        "id": "harness:post:contract-test"
-      },
-      {
-        "matcher": "Task",
-        "hooks": [
-          {
-            "type": "command",
-            "command": "node hooks/scripts/subagent-scope-guard.js"
-          }
-        ],
-        "description": "Diff the whole repo after a subagent burst finishes - catches scope creep past what the task briefed",
-        "id": "harness:post:subagent-scope-guard"
-      }
-    ]
-  }
-}
+{
+  "$schema": "https://json.schemastore.org/claude-code-settings.json",
+  "hooks": {
+    "SessionStart": [
+      {
+        "hooks": [
+          {
+            "type": "command",
+            "command": "node harness-everything/scripts/bootstrap.js"
+          }
+        ],
+        "description": "Bootstrap Harness Skills OS on session start",
+        "id": "harness:pre:bootstrap"
+      }
+    ],
+    "UserPromptSubmit": [
+      {
+        "hooks": [
+          {
+            "type": "command",
+            "command": "node harness-everything/scripts/tier-router.js"
+          }
+        ],
+        "description": "Auto-route user requests using tier-router",
+        "id": "harness:pre:tier-router"
+      }
+    ],
+    "PreToolUse": [
+      {
+        "matcher": "Bash|PowerShell|Edit|Write",
+        "hooks": [
+          {
+            "type": "command",
+            "command": "node hooks/scripts/rule-of-3.js"
+          }
+        ],
+        "description": "Rule of 3 Circuit Breaker - Prevents micro-error looping",
+        "id": "harness:pre:rule-of-3"
+      },
+      {
+        "matcher": "Grep|Glob|Read",
+        "hooks": [
+          {
+            "type": "command",
+            "command": "node hooks/scripts/boundary-guard.js"
+          }
+        ],
+        "description": "Physical boundary enforcement for searches and large file reads",
+        "id": "harness:pre:boundary-guard"
+      },
+      {
+        "matcher": "Edit|Write",
+        "hooks": [
+          {
+            "type": "command",
+            "command": "node hooks/scripts/depth-guard.js"
+          }
+        ],
+        "description": "Information depth guard - Enforce impact assessment before writing code",
+        "id": "harness:pre:depth-guard"
+      },
+      {
+        "matcher": "Edit|Write|Bash|PowerShell",
+        "hooks": [
+          {
+            "type": "command",
+            "command": "node hooks/scripts/context-compact.js"
+          }
+        ],
+        "description": "Strategic context compaction enforcement",
+        "id": "harness:pre:context-compact"
+      },
+      {
+        "matcher": "Task",
+        "hooks": [
+          {
+            "type": "command",
+            "command": "node hooks/scripts/subagent-scope-guard.js"
+          }
+        ],
+        "description": "Snapshot repo state before a subagent burst starts",
+        "id": "harness:pre:subagent-scope-guard"
+      }
+    ],
+    "Stop": [
+      {
+        "hooks": [
+          {
+            "type": "command",
+            "command": "node hooks/scripts/stop-gate.js"
+          }
+        ],
+        "description": "Pre-delivery gate - bounce the end of a turn once per edit batch when edits were never verified",
+        "id": "harness:stop:stop-gate"
+      }
+    ],
+    "PostToolUse": [
+      {
+        "matcher": "Bash|PowerShell",
+        "hooks": [
+          {
+            "type": "command",
+            "command": "node hooks/scripts/rule-of-3-tracker.js"
+          }
+        ],
+        "description": "Track error signatures for Rule of 3",
+        "id": "harness:post:rule-of-3-tracker"
+      },
+      {
+        "matcher": "Edit|Write|Bash|PowerShell",
+        "hooks": [
+          {
+            "type": "command",
+            "command": "node hooks/scripts/state-persist.js"
+          }
+        ],
+        "description": "Save skill transition state",
+        "id": "harness:post:state-persist"
+      },
+      {
+        "matcher": "Edit|Write",
+        "hooks": [
+          {
+            "type": "command",
+            "command": "node hooks/scripts/atomic-commit-check.js"
+          }
+        ],
+        "description": "Atomic commit enforcement",
+        "id": "harness:post:atomic-commit-check"
+      },
+      {
+        "matcher": "Bash|PowerShell",
+        "hooks": [
+          {
+            "type": "command",
+            "command": "node hooks/scripts/contract-test.js"
+          }
+        ],
+        "description": "Contract testing between sub-agents",
+        "id": "harness:post:contract-test"
+      },
+      {
+        "matcher": "Task",
+        "hooks": [
+          {
+            "type": "command",
+            "command": "node hooks/scripts/subagent-scope-guard.js"
+          }
+        ],
+        "description": "Diff the whole repo after a subagent burst finishes - catches scope creep past what the task briefed",
+        "id": "harness:post:subagent-scope-guard"
+      }
+    ]
+  }
+}

package/hooks/scripts/atomic-commit-check.js

@@ -1,68 +1,68 @@
-#!/usr/bin/env node
-/**
- * Atomic Commit Check (PostToolUse: Edit|Write)
- * PostToolUse can't block - the edit/write already happened. So this counts
- * Edit/Write calls since the last commit and, once the count crosses a
- * threshold, feeds a strong reminder back to Claude (exit 2) to commit the
- * completed chunk before piling on more changes. Resets whenever HEAD moves.
- * Fails open on any error - this is a nudge, never a hard stop.
- */
-const { execSync } = require('child_process');
-const fs = require('fs');
-const path = require('path');
-const { getWorkspaceRoot, getSessionDir } = require('./lib/harness-state');
-
-const THRESHOLD = 6;
-const RENUDGE_EVERY = 3;
-
-function main(payload) {
-  try {
-    const root = getWorkspaceRoot();
-    const head = execSync('git rev-parse HEAD', { cwd: root, encoding: 'utf8', stdio: ['ignore', 'pipe', 'ignore'] }).trim();
-
-    const stateFile = path.join(getSessionDir(root, payload && payload.session_id), 'atomic-commit-state.json');
-
-    let state = { lastHead: head, editCount: 0 };
-    if (fs.existsSync(stateFile)) {
-      try { state = JSON.parse(fs.readFileSync(stateFile, 'utf8')); } catch (e) { /* use default */ }
-    }
-
-    if (state.lastHead !== head) {
-      // A commit happened since we last checked - fresh start.
-      state.lastHead = head;
-      state.editCount = 0;
-    }
-
-    state.editCount += 1;
-    fs.writeFileSync(stateFile, JSON.stringify(state, null, 2), 'utf8');
-
-    const overThreshold = state.editCount >= THRESHOLD;
-    const onNudgeBeat = overThreshold && (state.editCount - THRESHOLD) % RENUDGE_EVERY === 0;
-
-    if (onNudgeBeat) {
-      const statusRaw = execSync('git status --porcelain', { cwd: root, encoding: 'utf8', stdio: ['ignore', 'pipe', 'ignore'] }).trim();
-      const changedFiles = statusRaw ? statusRaw.split('\n').length : 0;
-      console.error(`[Atomic Commit Check] ${state.editCount} Edit/Write calls since the last commit (${changedFiles} files currently changed).`);
-      console.error(`If a logically complete chunk of work is done, commit it now before continuing - large uncommitted diffs are harder to review and harder to recover from.`);
-      process.exit(2);
-    }
-
-    process.exit(0);
-  } catch (err) {
-    process.exit(0);
-  }
-}
-
-let inputData = '';
-const timeout = setTimeout(() => { main(null); }, 200);
-process.stdin.on('data', chunk => { inputData += chunk; });
-process.stdin.on('end', () => {
-  clearTimeout(timeout);
-  let payload = null;
-  try { payload = JSON.parse(inputData.trim()); } catch (err) { /* no payload */ }
-  main(payload);
-});
-process.stdin.on('error', () => {
-  clearTimeout(timeout);
-  main(null);
-});
+#!/usr/bin/env node
+/**
+ * Atomic Commit Check (PostToolUse: Edit|Write)
+ * PostToolUse can't block - the edit/write already happened. So this counts
+ * Edit/Write calls since the last commit and, once the count crosses a
+ * threshold, feeds a strong reminder back to Claude (exit 2) to commit the
+ * completed chunk before piling on more changes. Resets whenever HEAD moves.
+ * Fails open on any error - this is a nudge, never a hard stop.
+ */
+const { execSync } = require('child_process');
+const fs = require('fs');
+const path = require('path');
+const { getWorkspaceRoot, getSessionDir } = require('./lib/harness-state');
+
+const THRESHOLD = 6;
+const RENUDGE_EVERY = 3;
+
+function main(payload) {
+  try {
+    const root = getWorkspaceRoot();
+    const head = execSync('git rev-parse HEAD', { cwd: root, encoding: 'utf8', stdio: ['ignore', 'pipe', 'ignore'] }).trim();
+
+    const stateFile = path.join(getSessionDir(root, payload && payload.session_id), 'atomic-commit-state.json');
+
+    let state = { lastHead: head, editCount: 0 };
+    if (fs.existsSync(stateFile)) {
+      try { state = JSON.parse(fs.readFileSync(stateFile, 'utf8')); } catch (e) { /* use default */ }
+    }
+
+    if (state.lastHead !== head) {
+      // A commit happened since we last checked - fresh start.
+      state.lastHead = head;
+      state.editCount = 0;
+    }
+
+    state.editCount += 1;
+    fs.writeFileSync(stateFile, JSON.stringify(state, null, 2), 'utf8');
+
+    const overThreshold = state.editCount >= THRESHOLD;
+    const onNudgeBeat = overThreshold && (state.editCount - THRESHOLD) % RENUDGE_EVERY === 0;
+
+    if (onNudgeBeat) {
+      const statusRaw = execSync('git status --porcelain', { cwd: root, encoding: 'utf8', stdio: ['ignore', 'pipe', 'ignore'] }).trim();
+      const changedFiles = statusRaw ? statusRaw.split('\n').length : 0;
+      console.error(`[Atomic Commit Check] ${state.editCount} Edit/Write calls since the last commit (${changedFiles} files currently changed).`);
+      console.error(`If a logically complete chunk of work is done, commit it now before continuing - large uncommitted diffs are harder to review and harder to recover from.`);
+      process.exit(2);
+    }
+
+    process.exit(0);
+  } catch (err) {
+    process.exit(0);
+  }
+}
+
+let inputData = '';
+const timeout = setTimeout(() => { main(null); }, 200);
+process.stdin.on('data', chunk => { inputData += chunk; });
+process.stdin.on('end', () => {
+  clearTimeout(timeout);
+  let payload = null;
+  try { payload = JSON.parse(inputData.trim()); } catch (err) { /* no payload */ }
+  main(payload);
+});
+process.stdin.on('error', () => {
+  clearTimeout(timeout);
+  main(null);
+});