handsontable 0.34.1 → 0.34.5

package/es/plugins/manualRowMove/test/manualRowMoveUI.e2e.js

@@ -54,7 +54,7 @@ describe('manualRowMove', function () {
         manualRowMove: true
       });
 
-      var $headers = [this.$container.find('tbody tr:eq(0) th:eq(0)'), this.$container.find('tbody tr:eq(1) th:eq(0)'), this.$container.find('tbody tr:eq(2) th:eq(0)')];
+      var $headers = [spec().$container.find('tbody tr:eq(0) th:eq(0)'), spec().$container.find('tbody tr:eq(1) th:eq(0)'), spec().$container.find('tbody tr:eq(2) th:eq(0)')];
 
       $headers[0].simulate('mousedown');
       $headers[0].simulate('mouseup');
@@ -66,202 +66,60 @@ describe('manualRowMove', function () {
       expect(spec().$container.find('.ht__manualRowMove--backlight:visible').length).toBe(1);
     });
 
-    it('should run `beforeRowMove` with proper `target` parameter (moving row above first header)', function () {
-      var targetParameterInsideCallback = void 0;
+    describe('backlight', function () {
+      it('should set proper left position of element when colWidths is undefined', function () {
+        handsontable({
+          data: Handsontable.helper.createSpreadsheetData(10, 10),
+          rowHeaders: true,
+          manualRowMove: true
+        });
 
-      handsontable({
-        data: Handsontable.helper.createSpreadsheetData(30, 30),
-        rowHeaders: true,
-        colHeaders: true,
-        manualRowMove: true,
-        beforeRowMove: function beforeRowMove(rows, target) {
-          targetParameterInsideCallback = target;
-        }
-      });
-      var $fistHeader = this.$container.find('tbody tr:eq(0) th:eq(0)');
+        var $headerTH = spec().$container.find('tbody tr:eq(0) th:eq(0)');
 
-      this.$container.find('tbody tr:eq(1) th:eq(0)').simulate('mousedown');
-      this.$container.find('tbody tr:eq(1) th:eq(0)').simulate('mouseup');
-      this.$container.find('tbody tr:eq(1) th:eq(0)').simulate('mousedown');
+        $headerTH.simulate('mousedown');
+        $headerTH.simulate('mouseup');
+        $headerTH.simulate('mousedown');
 
-      $fistHeader.simulate('mouseover');
-      $fistHeader.simulate('mousemove', {
-        clientY: $fistHeader.offset().bottom - $fistHeader.height() - 50
+        expect(spec().$container.find('.ht__manualRowMove--backlight')[0].offsetLeft).toBe(50);
       });
-      $fistHeader.simulate('mouseup');
 
-      expect(targetParameterInsideCallback).toEqual(0);
-    });
+      it('should set proper left position of element when colWidths is defined', function () {
+        handsontable({
+          data: Handsontable.helper.createSpreadsheetData(10, 10),
+          rowHeaders: true,
+          manualRowMove: true,
+          colWidths: 100
+        });
 
-    it('should run `beforeRowMove` with proper `target` parameter (moving row to the top of first header)', function () {
-      var targetParameterInsideCallback = void 0;
+        var $headerTH = spec().$container.find('tbody tr:eq(0) th:eq(0)');
 
-      handsontable({
-        data: Handsontable.helper.createSpreadsheetData(30, 30),
-        rowHeaders: true,
-        manualRowMove: true,
-        colHeaders: true,
-        beforeRowMove: function beforeRowMove(rows, target) {
-          targetParameterInsideCallback = target;
-        }
-      });
-      var $fistHeader = this.$container.find('tbody tr:eq(0) th:eq(0)');
+        $headerTH.simulate('mousedown');
+        $headerTH.simulate('mouseup');
+        $headerTH.simulate('mousedown');
 
-      this.$container.find('tbody tr:eq(1) th:eq(0)').simulate('mousedown');
-      this.$container.find('tbody tr:eq(1) th:eq(0)').simulate('mouseup');
-      this.$container.find('tbody tr:eq(1) th:eq(0)').simulate('mousedown');
-
-      $fistHeader.simulate('mouseover');
-      $fistHeader.simulate('mousemove', {
-        clientY: $fistHeader.offset().bottom - $fistHeader.height()
-      });
-      $fistHeader.simulate('mouseup');
-
-      expect(targetParameterInsideCallback).toEqual(0);
-    });
-
-    it('should run `beforeRowMove` with proper `target` parameter (moving row to the middle of the table)', function () {
-      var targetParameterInsideCallback = void 0;
-
-      handsontable({
-        data: Handsontable.helper.createSpreadsheetData(30, 30),
-        rowHeaders: true,
-        manualRowMove: true,
-        beforeRowMove: function beforeRowMove(rows, target) {
-          targetParameterInsideCallback = target;
-        }
+        expect(spec().$container.find('.ht__manualRowMove--backlight')[0].offsetLeft).toBe(50);
       });
-
-      this.$container.find('tbody tr:eq(0) th:eq(0)').simulate('mousedown');
-      this.$container.find('tbody tr:eq(0) th:eq(0)').simulate('mouseup');
-      this.$container.find('tbody tr:eq(0) th:eq(0)').simulate('mousedown');
-
-      this.$container.find('tbody tr:eq(2) th:eq(0)').simulate('mouseover');
-      this.$container.find('tbody tr:eq(2) th:eq(0)').simulate('mousemove');
-      this.$container.find('tbody tr:eq(2) th:eq(0)').simulate('mouseup');
-
-      expect(targetParameterInsideCallback).toEqual(2);
     });
 
-    it('should run `beforeRowMove` with proper `target` parameter (moving row to the top of last header)', function () {
-      var targetParameterInsideCallback = void 0;
-
-      handsontable({
-        data: Handsontable.helper.createSpreadsheetData(30, 30),
-        rowHeaders: true,
-        manualRowMove: true,
-        beforeRowMove: function beforeRowMove(rows, target) {
-          targetParameterInsideCallback = target;
-        }
-      });
+    describe('guideline', function () {
+      it('should set proper top position of element when target is first row and column headers are disabled', function () {
+        handsontable({
+          data: Handsontable.helper.createSpreadsheetData(10, 10),
+          rowHeaders: true,
+          colHeaders: false,
+          manualRowMove: true
+        });
 
-      this.$container.find('tbody tr:eq(0) th:eq(0)').simulate('mousedown');
-      this.$container.find('tbody tr:eq(0) th:eq(0)').simulate('mouseup');
-      this.$container.find('tbody tr:eq(0) th:eq(0)').simulate('mousedown');
+        var $headers = [spec().$container.find('tbody tr:eq(0) th:eq(0)'), spec().$container.find('tbody tr:eq(1) th:eq(0)')];
 
-      this.$container.find('tbody tr:eq(29) th:eq(0)').simulate('mouseover');
-      this.$container.find('tbody tr:eq(29) th:eq(0)').simulate('mousemove');
-      this.$container.find('tbody tr:eq(29) th:eq(0)').simulate('mouseup');
+        $headers[1].simulate('mousedown');
+        $headers[1].simulate('mouseup');
+        $headers[1].simulate('mousedown');
+        $headers[0].simulate('mouseover');
+        $headers[0].simulate('mousemove');
 
-      expect(targetParameterInsideCallback).toEqual(29);
-    });
-
-    it('should run `beforeRowMove` with proper `target` parameter (moving row to the bottom of last header)', function () {
-      var targetParameterInsideCallback = void 0;
-
-      handsontable({
-        data: Handsontable.helper.createSpreadsheetData(30, 30),
-        rowHeaders: true,
-        manualRowMove: true,
-        beforeRowMove: function beforeRowMove(rows, target) {
-          targetParameterInsideCallback = target;
-        }
+        expect(spec().$container.find('.ht__manualRowMove--guideline')[0].offsetTop).toBe(-1);
       });
-      var $lastHeader = this.$container.find('tbody tr:eq(29) th:eq(0)');
-
-      this.$container.find('tbody tr:eq(0) th:eq(0)').simulate('mousedown');
-      this.$container.find('tbody tr:eq(0) th:eq(0)').simulate('mouseup');
-      this.$container.find('tbody tr:eq(0) th:eq(0)').simulate('mousedown');
-
-      $lastHeader.simulate('mouseover');
-      $lastHeader.simulate('mousemove', {
-        clientY: $lastHeader.offset().top + $lastHeader.height()
-      });
-      $lastHeader.simulate('mouseup');
-
-      expect(targetParameterInsideCallback).toEqual(30);
-    });
-
-    it('should run `beforeRowMove` with proper `target` parameter (moving row below last header)', function () {
-      var targetParameterInsideCallback = void 0;
-
-      handsontable({
-        data: Handsontable.helper.createSpreadsheetData(30, 30),
-        rowHeaders: true,
-        manualRowMove: true,
-        beforeRowMove: function beforeRowMove(rows, target) {
-          targetParameterInsideCallback = target;
-        }
-      });
-      var $lastHeader = this.$container.find('tbody tr:eq(29) th:eq(0)');
-
-      this.$container.find('tbody tr:eq(0) th:eq(0)').simulate('mousedown');
-      this.$container.find('tbody tr:eq(0) th:eq(0)').simulate('mouseup');
-      this.$container.find('tbody tr:eq(0) th:eq(0)').simulate('mousedown');
-
-      $lastHeader.simulate('mouseover');
-      $lastHeader.simulate('mousemove', {
-        clientY: $lastHeader.offset().top + $lastHeader.height() + 200
-      });
-      $lastHeader.simulate('mouseup');
-
-      expect(targetParameterInsideCallback).toEqual(30);
-    });
-
-    it('should run `beforeRowMove` with proper visual `target` parameter', function () {
-      var targetParameterInsideCallback = void 0;
-
-      handsontable({
-        data: Handsontable.helper.createSpreadsheetData(30, 30),
-        rowHeaders: true,
-        manualRowMove: [1, 2, 0],
-        beforeRowMove: function beforeRowMove(rows, target) {
-          targetParameterInsideCallback = target;
-        }
-      });
-
-      this.$container.find('tbody tr:eq(0) th:eq(0)').simulate('mousedown');
-      this.$container.find('tbody tr:eq(0) th:eq(0)').simulate('mouseup');
-      this.$container.find('tbody tr:eq(0) th:eq(0)').simulate('mousedown');
-
-      this.$container.find('tbody tr:eq(2) th:eq(0)').simulate('mouseover');
-      this.$container.find('tbody tr:eq(2) th:eq(0)').simulate('mousemove');
-      this.$container.find('tbody tr:eq(2) th:eq(0)').simulate('mouseup');
-
-      expect(targetParameterInsideCallback).toEqual(2);
-    });
-
-    it('should run `afterRowMove` with proper visual `target` parameter', function () {
-      var targetParameterInsideCallback = void 0;
-
-      handsontable({
-        data: Handsontable.helper.createSpreadsheetData(30, 30),
-        rowHeaders: true,
-        manualRowMove: [1, 2, 0],
-        afterRowMove: function afterRowMove(rows, target) {
-          targetParameterInsideCallback = target;
-        }
-      });
-
-      this.$container.find('tbody tr:eq(0) th:eq(0)').simulate('mousedown');
-      this.$container.find('tbody tr:eq(0) th:eq(0)').simulate('mouseup');
-      this.$container.find('tbody tr:eq(0) th:eq(0)').simulate('mousedown');
-
-      this.$container.find('tbody tr:eq(2) th:eq(0)').simulate('mouseover');
-      this.$container.find('tbody tr:eq(2) th:eq(0)').simulate('mousemove');
-      this.$container.find('tbody tr:eq(2) th:eq(0)').simulate('mouseup');
-
-      expect(targetParameterInsideCallback).toEqual(2);
     });
   });
 });

package/es/plugins/manualRowMove/ui/_base.js

@@ -112,10 +112,10 @@ var BaseUI = function () {
   }, {
     key: 'setPosition',
     value: function setPosition(top, left) {
-      if (top) {
+      if (top !== void 0) {
         this._element.style.top = top + UNIT;
       }
-      if (left) {
+      if (left !== void 0) {
         this._element.style.left = left + UNIT;
       }
     }

package/es/tableView.js

@@ -192,6 +192,7 @@ function TableView(instance) {
     border: {
       width: 1,
       color: 'red'
+      // style: 'solid' // not used
     }
   })];
   selections.current = selections[0];

package/handsontable.jquery.json

@@ -1,7 +1,7 @@
 {
   "name": "handsontable",
   "title": "Handsontable",
-  "version": "0.34.1",
+  "version": "0.34.5",
   "author": {
     "name": "Handsoncode",
     "email": "hello@handsontable.com",

package/hot.config.js

@@ -8,5 +8,5 @@ module.exports = {
   HOT_PACKAGE_TYPE: 'ce',
   HOT_PACKAGE_NAME: packageBody.name,
   HOT_BUILD_DATE: moment().format('DD/MM/YYYY HH:mm:ss'),
-  HOT_RELEASE_DATE: '06/09/2017',
+  HOT_RELEASE_DATE: '12/10/2017',
 };

package/package.json

@@ -10,7 +10,7 @@
     "url": "https://github.com/handsontable/handsontable/issues"
   },
   "author": "Handsoncode <hello@handsontable.com>",
-  "version": "0.34.1",
+  "version": "0.34.5",
   "browser": "dist/handsontable.js",
   "main": "commonjs/index.js",
   "module": "es/index.js",
@@ -81,17 +81,17 @@
     "eslint": "^4.3.0",
     "eslint-config-airbnb-base": "^11.3.1",
     "eslint-plugin-import": "^2.7.0",
-    "extract-text-webpack-plugin": "^2.1.2",
+    "extract-text-webpack-plugin": "^3.0.0",
     "glob": "^7.1.2",
     "grunt": "^1.0.1",
     "grunt-lib-phantomjs": "^1.1.0",
-    "html-webpack-plugin": "^2.29.0",
+    "html-webpack-plugin": "^2.30.1",
     "jasmine-co": "^1.2.2",
     "jasmine-core": "2.5.2",
     "jasmine-terminal-reporter": "^1.0.3",
     "jest": "^19.0.0",
     "loader-utils": "^1.1.0",
-    "optimize-css-assets-webpack-plugin": "^1.3.2",
+    "optimize-css-assets-webpack-plugin": "^3.1.1",
     "progress-bar-webpack-plugin": "^1.10.0",
     "request": "^2.81.0",
     "rimraf": "^2.5.4",
@@ -100,7 +100,7 @@
     "supports-color": "^4.2.1",
     "tree-kill": "^1.1.0",
     "typescript": "^2.4.2",
-    "webpack": "^2.7.0"
+    "webpack": "^3.5.6"
   },
   "license": "MIT",
   "jest": {