handsontable 0.34.1 → 0.34.5

package/es/plugins/copyPaste/test/copyPaste.e2e.js

@@ -1,5 +1,9 @@
+var _createClass = function () { function defineProperties(target, props) { for (var i = 0; i < props.length; i++) { var descriptor = props[i]; descriptor.enumerable = descriptor.enumerable || false; descriptor.configurable = true; if ("value" in descriptor) descriptor.writable = true; Object.defineProperty(target, descriptor.key, descriptor); } } return function (Constructor, protoProps, staticProps) { if (protoProps) defineProperties(Constructor.prototype, protoProps); if (staticProps) defineProperties(Constructor, staticProps); return Constructor; }; }();
+
 function _asyncToGenerator(fn) { return function () { var gen = fn.apply(this, arguments); return new Promise(function (resolve, reject) { function step(key, arg) { try { var info = gen[key](arg); var value = info.value; } catch (error) { reject(error); return; } if (info.done) { resolve(value); } else { return Promise.resolve(value).then(function (value) { step("next", value); }, function (err) { step("throw", err); }); } } return step("next"); }); }; }
 
+function _classCallCheck(instance, Constructor) { if (!(instance instanceof Constructor)) { throw new TypeError("Cannot call a class as a function"); } }
+
 describe('CopyPaste', function () {
   var id = 'testContainer';
 
@@ -14,6 +18,37 @@ describe('CopyPaste', function () {
     }
   });
 
+  var DataTransferObject = function () {
+    function DataTransferObject() {
+      _classCallCheck(this, DataTransferObject);
+
+      this.data = '';
+    }
+
+    _createClass(DataTransferObject, [{
+      key: 'getData',
+      value: function getData() {
+        return this.data;
+      }
+    }, {
+      key: 'setData',
+      value: function setData(type, value) {
+        this.data = value;
+      }
+    }]);
+
+    return DataTransferObject;
+  }();
+
+  ;
+
+  function getClipboardEvent() {
+    var event = {};
+    event.clipboardData = new DataTransferObject();
+    event.preventDefault = function () {};
+    return event;
+  }
+
   var arrayOfArrays = function arrayOfArrays() {
     return [['', 'Kia', 'Nissan', 'Toyota', 'Honda'], ['2008', 10, 11, 12, 13], ['2009', 20, 11, 14, 13], ['2010', 30, 15, 12, 13]];
   };
@@ -78,67 +113,7 @@ describe('CopyPaste', function () {
     });
   });
 
-  describe('setting values copyable', function () {
-    it('should set copyable text when selecting a single cell and hitting ctrl', function () {
-      handsontable({
-        data: Handsontable.helper.createSpreadsheetData(2, 2)
-      });
-
-      var copyPasteTextarea = $('#HandsontableCopyPaste')[0];
-
-      expect(copyPasteTextarea.value.length).toEqual(0);
-
-      selectCell(0, 0);
-      keyDownUp(Handsontable.helper.KEY_CODES.CONTROL_LEFT);
-
-      expect(copyPasteTextarea.value).toEqual('A1');
-    });
-
-    it('should set copyable text when selecting a single cell and hitting left command', function () {
-      handsontable({
-        data: Handsontable.helper.createSpreadsheetData(2, 2)
-      });
-
-      var copyPasteTextarea = $('#HandsontableCopyPaste')[0];
-
-      expect(copyPasteTextarea.value.length).toEqual(0);
-
-      selectCell(0, 0);
-      keyDownUp(Handsontable.helper.KEY_CODES.COMMAND_LEFT);
-
-      expect(copyPasteTextarea.value).toEqual('A1');
-    });
-
-    it('should set copyable text when selecting a single cell and hitting right command', function () {
-      handsontable({
-        data: Handsontable.helper.createSpreadsheetData(2, 2)
-      });
-
-      var copyPasteTextarea = $('#HandsontableCopyPaste')[0];
-
-      expect(copyPasteTextarea.value.length).toEqual(0);
-
-      selectCell(0, 0);
-      keyDownUp(Handsontable.helper.KEY_CODES.COMMAND_RIGHT);
-
-      expect(copyPasteTextarea.value).toEqual('A1');
-    });
-
-    it('should set copyable text when selecting multiple cells and hitting ctrl', function () {
-      handsontable({
-        data: Handsontable.helper.createSpreadsheetData(2, 2)
-      });
-
-      var copyPasteTextarea = $('#HandsontableCopyPaste')[0];
-
-      expect(copyPasteTextarea.value.length).toEqual(0);
-
-      selectCell(0, 0, 1, 0);
-      keyDownUp(Handsontable.helper.KEY_CODES.CONTROL_LEFT);
-
-      expect(copyPasteTextarea.value).toEqual('A1\nA2');
-    });
-
+  xdescribe('setting values copyable', function () {
     it('should set copyable text when selecting all cells with CTRL+A', function (done) {
       handsontable({
         data: Handsontable.helper.createSpreadsheetData(2, 2)
@@ -159,24 +134,6 @@ describe('CopyPaste', function () {
       }, 10);
     });
 
-    it('should not throw error when no cell is selected (#1221)', function () {
-      handsontable({
-        data: Handsontable.helper.createSpreadsheetData(2, 2)
-      });
-
-      selectCell(0, 0);
-      deselectCell();
-
-      function keydownCtrl() {
-        $(document).simulate('keydown', {
-          keyCode: Handsontable.helper.KEY_CODES.COMMAND_LEFT
-        });
-      }
-
-      // expect no to throw any exception
-      expect(keydownCtrl).not.toThrow();
-    });
-
     it('should not throw error when no cell is selected and contextmenu options was clicked', function () {
       // This is ugly trick to check problematic thing (#4390).
       // Unfortunately we cannot open the context menu, when event.target is not an TD element.
@@ -207,22 +164,6 @@ describe('CopyPaste', function () {
       expect(copyPasteTextarea.value).toEqual('A\t1\nB\t2');
     });
 
-    it('should set copyable text when selecting a single cell with editor type as false (#2574)', function () {
-      handsontable({
-        data: [['A', 1], ['B', 2]],
-        columns: [{ type: 'text' }, { editor: false }]
-      });
-
-      var copyPasteTextarea = $('#HandsontableCopyPaste')[0];
-
-      expect(copyPasteTextarea.value.length).toEqual(0);
-
-      selectCell(1, 1, 1, 1);
-      keyDownUp(Handsontable.helper.KEY_CODES.CONTROL_LEFT);
-
-      expect(copyPasteTextarea.value).toEqual('2');
-    });
-
     it('should set copyable text until copyRowsLimit is reached', function () {
       handsontable({
         data: arrayOfArrays(),
@@ -274,67 +215,46 @@ describe('CopyPaste', function () {
   });
 
   describe('copy', function () {
-    it('should be possible to copy data by keyboard shortcut', function () {
-      handsontable({
-        data: Handsontable.helper.createSpreadsheetData(2, 2)
-      });
-
-      selectCell(1, 1);
-      keyDown('ctrl');
-      keyDown('ctrl+c');
+    xit('should be possible to copy data by keyboard shortcut', function () {
+      // simulated keyboard shortcuts doesn't run the true events
+    });
 
-      expect($('#HandsontableCopyPaste')[0]).toBe(document.activeElement);
-      // unfortunately we have not access to read data from the system clipboard
+    xit('should be possible to copy data by contextMenu option', function () {
+      // simulated mouse events doesn't run the true browser event
     });
 
     it('should be possible to copy data by API', function () {
       var hot = handsontable({
         data: Handsontable.helper.createSpreadsheetData(2, 2)
       });
+      var copyEvent = getClipboardEvent('copy');
+      var plugin = hot.getPlugin('CopyPaste');
 
       selectCell(1, 0);
 
-      hot.getPlugin('CopyPaste').setCopyableText();
-      // below line is cause of console warning in FF about execCommand
-      hot.getPlugin('CopyPaste').copy(true);
-
-      expect($('#HandsontableCopyPaste')[0]).toBe(document.activeElement);
-      // unfortunately we have not access to read data from the system clipboard
-    });
-
-    it('should be possible to copy data by contextMenu option', function () {
-      var beforeCopySpy = jasmine.createSpy('beforeCopy');
-
-      handsontable({
-        data: Handsontable.helper.createSpreadsheetData(2, 2),
-        beforeCopy: beforeCopySpy,
-        contextMenu: ['copy']
-      });
-
-      selectCell(0, 1);
-      contextMenu();
-
-      var items = $('.htContextMenu tbody td');
-      var actions = items.not('.htSeparator');
-
-      actions.simulate('mousedown');
+      plugin.setCopyableText();
+      plugin.onCopy(copyEvent);
 
-      expect(beforeCopySpy).toHaveBeenCalledTimes(1);
+      expect(copyEvent.clipboardData.getData()).toBe('A2');
     });
 
     it('should call beforeCopy and afterCopy during copying operation', function () {
       var beforeCopySpy = jasmine.createSpy('beforeCopy');
       var afterCopySpy = jasmine.createSpy('afterCopy');
 
-      handsontable({
+      var hot = handsontable({
         data: Handsontable.helper.createSpreadsheetData(2, 2),
         beforeCopy: beforeCopySpy,
         afterCopy: afterCopySpy
       });
 
+      var copyEvent = getClipboardEvent('copy');
+      var plugin = hot.getPlugin('CopyPaste');
+
       selectCell(0, 0);
-      keyDown('ctrl');
-      keyDown('ctrl+c');
+
+      plugin.setCopyableText();
+      plugin.onCopy(copyEvent);
 
       expect(beforeCopySpy.calls.count()).toEqual(1);
       expect(beforeCopySpy).toHaveBeenCalledWith([['A1']], [{ startRow: 0, startCol: 0, endRow: 0, endCol: 0 }], void 0, void 0, void 0, void 0);
@@ -343,112 +263,93 @@ describe('CopyPaste', function () {
     });
 
     it('should be possible to block copying', function () {
+      var beforeCopySpy = jasmine.createSpy('beforeCopy');
       var afterCopySpy = jasmine.createSpy('afterCopy');
 
-      handsontable({
+      var hot = handsontable({
         data: Handsontable.helper.createSpreadsheetData(2, 2),
         beforeCopy: function beforeCopy() {
+          beforeCopySpy();
           return false;
         },
 
         afterCopy: afterCopySpy
       });
 
+      var copyEvent = getClipboardEvent('copy');
+      var plugin = hot.getPlugin('CopyPaste');
+
       selectCell(0, 0);
-      keyDown('ctrl');
-      keyDown('ctrl+c');
 
+      plugin.setCopyableText();
+      plugin.onCopy(copyEvent);
+
+      expect(beforeCopySpy.calls.count()).toEqual(1);
       expect(afterCopySpy.calls.count()).toEqual(0);
     });
 
-    it('should be possible modification of changes during copying', _asyncToGenerator(function* () {
-      handsontable({
+    it('should be possible modification of changes during copying', function () {
+      var hot = handsontable({
         data: Handsontable.helper.createSpreadsheetData(2, 2),
         beforeCopy: function beforeCopy(changes) {
           changes.splice(0, 1);
         }
       });
 
+      var copyEvent = getClipboardEvent('copy');
+      var plugin = hot.getPlugin('CopyPaste');
       selectCell(0, 0, 1, 0);
-      keyDown('ctrl');
-      keyDown('ctrl+c');
 
-      yield sleep(60);
+      plugin.setCopyableText();
+      plugin.onCopy(copyEvent);
 
-      expect($('#HandsontableCopyPaste')[0].value).toEqual('A2');
-    }));
+      expect(copyEvent.clipboardData.getData()).toEqual('A2');
+    });
   });
 
   describe('cut', function () {
-    it('should be possible to cut data by keyboard shortcut', _asyncToGenerator(function* () {
-      var hot = handsontable({
-        data: Handsontable.helper.createSpreadsheetData(2, 2)
-      });
-
-      selectCell(1, 1);
-      keyDown('ctrl');
-      keyDown('ctrl+x');
-
-      expect($('#HandsontableCopyPaste')[0]).toBe(document.activeElement);
-
-      yield sleep(100);
+    xit('should be possible to cut data by keyboard shortcut', function () {
+      // simulated keyboard shortcuts doesn't run the true events
+    });
 
-      expect(hot.getDataAtCell(1, 1)).toBe('');
-      // unfortunately we have not access to read data from the system clipboard
-    }));
+    xit('should be possible to cut data by contextMenu option', function () {
+      // simulated mouse events doesn't run the true browser event
+    });
 
-    it('should be possible to cut data by API', _asyncToGenerator(function* () {
+    it('should be possible to cut data by API', function () {
       var hot = handsontable({
         data: Handsontable.helper.createSpreadsheetData(2, 2)
       });
+      var cutEvent = getClipboardEvent('cut');
+      var plugin = hot.getPlugin('CopyPaste');
 
       selectCell(1, 0);
 
-      hot.getPlugin('CopyPaste').setCopyableText();
-      // below line is cause of console warning in FF about execCommand
-      hot.getPlugin('CopyPaste').cut(true);
+      plugin.setCopyableText();
+      plugin.onCut(cutEvent);
 
-      expect($('#HandsontableCopyPaste')[0]).toBe(document.activeElement);
-
-      yield sleep(100);
+      expect(cutEvent.clipboardData.getData()).toBe('A2');
 
+      // await sleep(100);
       expect(hot.getDataAtCell(1, 0)).toBe('');
-      // unfortunately we have not access to read data from the system clipboard
-    }));
-
-    it('should be possible to cut data by contextMenu option', function () {
-      var beforeCutSpy = jasmine.createSpy('beforeCopy');
-
-      handsontable({
-        data: Handsontable.helper.createSpreadsheetData(2, 2),
-        beforeCut: beforeCutSpy,
-        contextMenu: ['cut']
-      });
-
-      selectCell(0, 1);
-      contextMenu();
-
-      var items = $('.htContextMenu tbody td');
-      var actions = items.not('.htSeparator');
-
-      actions.simulate('mousedown');
-
-      expect(beforeCutSpy).toHaveBeenCalledTimes(1);
     });
 
     it('should call beforeCut and afterCut during cutting out operation', function () {
       var beforeCutSpy = jasmine.createSpy('beforeCut');
       var afterCutSpy = jasmine.createSpy('afterCut');
 
-      handsontable({
+      var hot = handsontable({
         data: Handsontable.helper.createSpreadsheetData(2, 2),
         beforeCut: beforeCutSpy,
         afterCut: afterCutSpy
       });
+      var cutEvent = getClipboardEvent('cut');
+      var plugin = hot.getPlugin('CopyPaste');
 
       selectCell(0, 0);
-      keyDown('ctrl');
-      keyDown('ctrl+x');
+
+      plugin.setCopyableText();
+      plugin.onCut(cutEvent);
 
       expect(beforeCutSpy.calls.count()).toEqual(1);
       expect(beforeCutSpy).toHaveBeenCalledWith([['A1']], [{ startRow: 0, startCol: 0, endRow: 0, endCol: 0 }], void 0, void 0, void 0, void 0);

package/es/plugins/copyPaste/test/textarea.unit.js

@@ -56,7 +56,7 @@ describe('CopyPaste', function () {
       var textarea = Textarea.getSingleton();
       var newValue = 'zxcvb';
 
-      expect(textarea.element.value.length).toBe(0);
+      expect(textarea.element.value.length).toBe(1);
 
       textarea.setValue(newValue);
 
@@ -69,7 +69,7 @@ describe('CopyPaste', function () {
       var textarea = Textarea.getSingleton();
       var newValue = 'zxcvb';
 
-      expect(textarea.getValue().length).toBe(0);
+      expect(textarea.getValue().length).toBe(1);
 
       textarea.setValue(newValue);
 

package/es/plugins/copyPaste/textarea.js

@@ -74,7 +74,8 @@ var Textarea = function () {
       this.element.className = 'copyPaste';
       this.element.tabIndex = -1;
       this.element.autocomplete = 'off';
-      this.element.wrap = 'off';
+      this.element.wrap = 'hard';
+      this.element.value = ' ';
     }
 
     /**

package/es/plugins/manualColumnMove/manualColumnMove.js

@@ -149,14 +149,14 @@ var ManualColumnMove = function (_BasePlugin) {
       this.addHook('beforeRemoveCol', function (index, amount) {
         return _this2.onBeforeRemoveCol(index, amount);
       });
-      this.addHook('afterRemoveCol', function (index, amount) {
-        return _this2.onAfterRemoveCol(index, amount);
+      this.addHook('afterRemoveCol', function () {
+        return _this2.onAfterRemoveCol();
       });
       this.addHook('afterCreateCol', function (index, amount) {
         return _this2.onAfterCreateCol(index, amount);
       });
-      this.addHook('afterLoadData', function (firstTime) {
-        return _this2.onAfterLoadData(firstTime);
+      this.addHook('afterLoadData', function () {
+        return _this2.onAfterLoadData();
       });
       this.addHook('unmodifyCol', function (column) {
         return _this2.onUnmodifyCol(column);
@@ -296,7 +296,7 @@ var ManualColumnMove = function (_BasePlugin) {
         var columnWidth = 0;
 
         if (i < 0) {
-          columnWidth = this.hot.view.wt.wtTable.getColumnWidth(i) || 0;
+          columnWidth = this.hot.view.wt.wtViewport.getRowHeaderWidth() || 0;
         } else {
           columnWidth = this.hot.view.wt.wtTable.getStretchedColumnWidth(i) || 0;
         }
@@ -502,7 +502,7 @@ var ManualColumnMove = function (_BasePlugin) {
         var maxIndex = countCols - 1;
         var columnsToRemove = [];
 
-        arrayEach(this.columnsMapper._arrayMap, function (value, index, array) {
+        arrayEach(this.columnsMapper._arrayMap, function (value, index) {
           if (value > maxIndex) {
             columnsToRemove.push(index);
           }
@@ -777,13 +777,11 @@ var ManualColumnMove = function (_BasePlugin) {
      * `afterRemoveCol` hook callback.
      *
      * @private
-     * @param {Number} index Visual column index of the removed column.
-     * @param {Number} amount Amount of removed columns.
      */
 
   }, {
     key: 'onAfterRemoveCol',
-    value: function onAfterRemoveCol(index, amount) {
+    value: function onAfterRemoveCol() {
       this.columnsMapper.unshiftItems(this.removedColumns);
     }
 
@@ -791,12 +789,11 @@ var ManualColumnMove = function (_BasePlugin) {
      * `afterLoadData` hook callback.
      *
      * @private
-     * @param {Boolean} firstTime True if that was loading data during the initialization.
      */
 
   }, {
     key: 'onAfterLoadData',
-    value: function onAfterLoadData(firstTime) {
+    value: function onAfterLoadData() {
       this.updateColumnsMapper();
     }
 

package/es/plugins/manualColumnMove/test/manualColumnMoveUI.e2e.js

@@ -102,6 +102,41 @@ describe('manualColumnMove', function () {
       expect(this.$container.find('.ht__manualColumnMove--backlight')[0].offsetWidth).toBe($headerTH[0].offsetWidth);
     });
 
+    it('should set proper left position of the backlight element when colWidths is undefined', function () {
+      handsontable({
+        data: Handsontable.helper.createSpreadsheetData(10, 10),
+        manualColumnMove: true,
+        rowHeaders: true,
+        colHeaders: true
+      });
+
+      var header = spec().$container.find('thead tr:eq(0) th:eq(2)');
+
+      header.simulate('mousedown');
+      header.simulate('mouseup');
+      header.simulate('mousedown');
+
+      expect(spec().$container.find('.ht__manualColumnMove--backlight')[0].offsetLeft).toBe(100);
+    });
+
+    it('should set proper left position of the backlight element when colWidths is defined', function () {
+      handsontable({
+        data: Handsontable.helper.createSpreadsheetData(10, 10),
+        manualColumnMove: true,
+        rowHeaders: true,
+        colWidths: 100,
+        colHeaders: true
+      });
+
+      var header = spec().$container.find('thead tr:eq(0) th:eq(2)');
+
+      header.simulate('mousedown');
+      header.simulate('mouseup');
+      header.simulate('mousedown');
+
+      expect(spec().$container.find('.ht__manualColumnMove--backlight')[0].offsetLeft).toBe(150);
+    });
+
     it('should not run moving ui if mousedown was fired on sorting element', function () {
       var hot = handsontable({
         data: arrayOfArrays.slice(),

package/es/plugins/manualRowMove/manualRowMove.js

@@ -147,14 +147,14 @@ var ManualRowMove = function (_BasePlugin) {
       this.addHook('beforeRemoveRow', function (index, amount) {
         return _this2.onBeforeRemoveRow(index, amount);
       });
-      this.addHook('afterRemoveRow', function (index, amount) {
-        return _this2.onAfterRemoveRow(index, amount);
+      this.addHook('afterRemoveRow', function () {
+        return _this2.onAfterRemoveRow();
       });
       this.addHook('afterCreateRow', function (index, amount) {
         return _this2.onAfterCreateRow(index, amount);
       });
-      this.addHook('afterLoadData', function (firstTime) {
-        return _this2.onAfterLoadData(firstTime);
+      this.addHook('afterLoadData', function () {
+        return _this2.onAfterLoadData();
       });
       this.addHook('beforeColumnSort', function (column, order) {
         return _this2.onBeforeColumnSort(column, order);
@@ -517,7 +517,7 @@ var ManualRowMove = function (_BasePlugin) {
         var maxIndex = countRows - 1;
         var rowsToRemove = [];
 
-        arrayEach(this.rowsMapper._arrayMap, function (value, index, array) {
+        arrayEach(this.rowsMapper._arrayMap, function (value, index) {
           if (value > maxIndex) {
             rowsToRemove.push(index);
           }
@@ -621,7 +621,7 @@ var ManualRowMove = function (_BasePlugin) {
         priv.target.TD = TD;
         priv.rowsToMove = this.prepareRowsToMoving();
 
-        var leftPos = wtTable.holder.scrollLeft + wtTable.getColumnWidth(-1);
+        var leftPos = wtTable.holder.scrollLeft + this.hot.view.wt.wtViewport.getRowHeaderWidth();
 
         this.backlight.setPosition(null, leftPos);
         this.backlight.setSize(wtTable.hider.offsetWidth - leftPos, this.getRowsHeight(start, end + 1));
@@ -750,7 +750,7 @@ var ManualRowMove = function (_BasePlugin) {
     key: 'onAfterScrollHorizontally',
     value: function onAfterScrollHorizontally() {
       var wtTable = this.hot.view.wt.wtTable;
-      var headerWidth = wtTable.getColumnWidth(-1);
+      var headerWidth = this.hot.view.wt.wtViewport.getRowHeaderWidth();
       var scrollLeft = wtTable.holder.scrollLeft;
       var posLeft = headerWidth + scrollLeft;
 
@@ -799,13 +799,11 @@ var ManualRowMove = function (_BasePlugin) {
      * `afterRemoveRow` hook callback.
      *
      * @private
-     * @param {Number} index Visual index of the removed row.
-     * @param {Number} amount Amount of removed rows.
      */
 
   }, {
     key: 'onAfterRemoveRow',
-    value: function onAfterRemoveRow(index, amount) {
+    value: function onAfterRemoveRow() {
       this.rowsMapper.unshiftItems(this.removedRows);
     }
 
@@ -813,12 +811,11 @@ var ManualRowMove = function (_BasePlugin) {
      * `afterLoadData` hook callback.
      *
      * @private
-     * @param {Boolean} firstTime True if that was loading data during the initialization.
      */
 
   }, {
     key: 'onAfterLoadData',
-    value: function onAfterLoadData(firstTime) {
+    value: function onAfterLoadData() {
       this.updateRowsMapper();
     }