gsd-pi 2.79.0 → 2.80.0-dev.4ea7d80e7

package/src/resources/extensions/gsd/tests/deep-project-auto-loop.test.ts

@@ -1,6 +1,6 @@
 import test from "node:test";
 import assert from "node:assert/strict";
-import { existsSync, mkdirSync, readFileSync, rmSync, writeFileSync } from "node:fs";
+import { existsSync, mkdirSync, readFileSync, realpathSync, rmSync, writeFileSync } from "node:fs";
 import { execFileSync } from "node:child_process";
 import { tmpdir } from "node:os";
 import { join } from "node:path";
@@ -23,6 +23,11 @@ import {
   showSmartEntry,
   startDeepProjectSetupForeground,
 } from "../guided-flow.ts";
+import {
+  closeDatabase,
+  insertMilestone,
+  openDatabase,
+} from "../gsd-db.ts";
 import type { GSDPreferences } from "../preferences.ts";
 import type { GSDState } from "../types.ts";
 
@@ -342,6 +347,62 @@ test("deep project setup: pre-dispatch can run before the first milestone exists
   }
 });
 
+test("deep project setup: bootstrap continues queued M002 without milestone context", async () => {
+  const base = makeRepo();
+  try {
+    writeCapturedDeepPrefs(base);
+    writeValidProjectAndRequirements(base);
+    mkdirSync(join(base, ".gsd", "runtime"), { recursive: true });
+    writeFileSync(join(base, ".gsd", "runtime", "research-decision.json"), '{"decision":"skip"}\n');
+
+    openDatabase(join(base, ".gsd", "gsd.db"));
+    insertMilestone({ id: "M001", title: "First milestone", status: "complete" });
+    insertMilestone({ id: "M002", title: "Second milestone", status: "queued" });
+    closeDatabase();
+
+    const messages: unknown[] = [];
+    const pi = {
+      ...makePi(messages),
+      getThinkingLevel: () => "medium",
+    };
+    const s = new AutoSession();
+    const ready = await bootstrapAutoSession(
+      s,
+      makeCtx(`queued-${randomUUID()}`) as any,
+      pi as any,
+      base,
+      false,
+      false,
+      {
+        shouldUseWorktreeIsolation: () => false,
+        registerSigtermHandler: () => {},
+        lockBase: () => base,
+        buildResolver: () => ({}) as any,
+      },
+      {
+        classification: "none",
+        lock: null,
+        pausedSession: null,
+        state: null,
+        recovery: null,
+        recoveryPrompt: null,
+        recoveryToolCallCount: 0,
+        artifactSatisfied: false,
+        hasResumableDiskState: false,
+        isBootstrapCrash: false,
+      },
+    );
+
+    assert.equal(ready, true);
+    assert.equal(s.active, true);
+    assert.equal(s.currentMilestoneId, "M002");
+    assert.equal(messages.length, 0, "queued deep milestone must not re-enter smart new-milestone discussion");
+  } finally {
+    try { closeDatabase(); } catch {}
+    rmSync(base, { recursive: true, force: true });
+  }
+});
+
 test("deep project setup: pre-dispatch takes precedence over an existing draft milestone", async () => {
   const base = makeBase();
   try {
@@ -1020,7 +1081,7 @@ test("deep project setup: research-project blocker placeholder is a file, not th
   const base = makeBase();
   try {
     const expectedPath = resolveExpectedArtifactPath("research-project", "PROJECT-RESEARCH", base);
-    assert.equal(expectedPath, join(base, ".gsd", "research", "PROJECT-RESEARCH-BLOCKER.md"));
+    assert.equal(expectedPath, join(realpathSync(base), ".gsd", "research", "PROJECT-RESEARCH-BLOCKER.md"));
 
     mkdirSync(join(base, ".gsd", "research"), { recursive: true });
     const diagnosis = writeBlockerPlaceholder(

package/src/resources/extensions/gsd/tests/discuss-headless-rendering.test.ts

@@ -0,0 +1,37 @@
+// Project/App: GSD-2
+// File Purpose: Verifies the headless discussion prompt renders compact required guidance.
+
+import test from "node:test";
+import assert from "node:assert/strict";
+import { mkdtempSync, rmSync } from "node:fs";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
+
+test("discuss-headless prompt renders compact investigation and audit guidance", async (t) => {
+  const previousGsdHome = process.env.GSD_HOME;
+  const providedGsdHome = process.env.GSD_TEST_HOME;
+  const isolatedHome = providedGsdHome ?? mkdtempSync(join(tmpdir(), "gsd-discuss-headless-render-"));
+  process.env.GSD_HOME = isolatedHome;
+  t.after(() => {
+    if (previousGsdHome === undefined) delete process.env.GSD_HOME;
+    else process.env.GSD_HOME = previousGsdHome;
+    if (!providedGsdHome) rmSync(isolatedHome, { recursive: true, force: true });
+  });
+
+  const { loadPrompt } = await import(`../prompt-loader.ts?test=${Date.now()}`);
+  const prompt = loadPrompt("discuss-headless", {
+    seedContext: "# Spec\n\nBuild the thing.",
+    milestoneId: "M001",
+    contextPath: ".gsd/milestones/M001/M001-CONTEXT.md",
+    commitInstruction: "Commit the created milestone artifacts.",
+    multiMilestoneCommitInstruction: "Commit the created milestone artifacts.",
+    inlinedTemplates: "## Template\n\nUse standard GSD artifacts.",
+  });
+
+  assert.match(prompt, /Investigate before making decisions:/);
+  assert.match(prompt, /Budget searches across investigation and focused research\./);
+  assert.match(prompt, /Resolve all of these from the spec and investigation before writing artifacts:/);
+  assert.match(prompt, /Print a structured depth summary in chat/);
+  assert.match(prompt, /Document every assumption in CONTEXT\.md/);
+  assert.doesNotMatch(prompt, /\{\{[a-zA-Z][a-zA-Z0-9_]*\}\}/);
+});

package/src/resources/extensions/gsd/tests/execute-summary-save-empty-project.test.ts

@@ -0,0 +1,109 @@
+// gsd-2 / execute-summary-save PROJECT registration hard-fail tests
+import test from "node:test";
+import assert from "node:assert/strict";
+import { mkdirSync, rmSync, writeFileSync } from "node:fs";
+import { join } from "node:path";
+import { tmpdir } from "node:os";
+import { randomUUID } from "node:crypto";
+
+import { openDatabase, closeDatabase, getAllMilestones } from "../gsd-db.ts";
+import { markApprovalGateVerified, clearDiscussionFlowState } from "../bootstrap/write-gate.ts";
+import { executeSummarySave } from "../tools/workflow-tool-executors.ts";
+
+function makeTmpBase(): string {
+  const base = join(tmpdir(), `gsd-summary-save-empty-project-${randomUUID()}`);
+  mkdirSync(join(base, ".gsd"), { recursive: true });
+  return base;
+}
+
+function cleanup(base: string): void {
+  try { rmSync(base, { recursive: true, force: true }); } catch { /* swallow */ }
+}
+
+function openTestDb(base: string): void {
+  openDatabase(join(base, ".gsd", "gsd.db"));
+}
+
+async function inProjectDir<T>(dir: string, fn: () => Promise<T>): Promise<T> {
+  const originalCwd = process.cwd();
+  try {
+    process.chdir(dir);
+    return await fn();
+  } finally {
+    process.chdir(originalCwd);
+  }
+}
+
+function setupBase(t: { after: (fn: () => void) => void }): string {
+  const base = makeTmpBase();
+  // Force deep planning so the root-artifact guard requires a verified approval gate,
+  // matching the production flow that surfaces the regression.
+  writeFileSync(join(base, ".gsd", "PREFERENCES.md"), "---\nplanning_depth: deep\n---\n");
+  openTestDb(base);
+  markApprovalGateVerified("depth_verification_project_confirm", base);
+  t.after(() => {
+    clearDiscussionFlowState(base);
+    closeDatabase();
+    cleanup(base);
+  });
+  return base;
+}
+
+test("executeSummarySave returns isError when PROJECT.md content has zero parseable milestone lines", async (t) => {
+  const base = setupBase(t);
+
+  const content = [
+    "# Project",
+    "",
+    "## What This Is",
+    "",
+    "Bad-separator regression fixture.",
+    "",
+    "## Milestone Sequence",
+    "",
+    // Wrong separator: " : " instead of em-dash / -- / -  → MILESTONE_LINE_RE matches zero lines.
+    "- [ ] M001: Foundation : Establish the first runnable slice.",
+    "",
+    "## Next Section",
+    "",
+    "Trailing prose with no list bullets so MILESTONE_LINE_RE cannot bridge across lines.",
+    "",
+  ].join("\n");
+
+  const result = await inProjectDir(base, () => executeSummarySave({
+    artifact_type: "PROJECT",
+    content,
+  }, base));
+
+  assert.equal(result.isError, true);
+  assert.equal(result.details.error, "milestone_registration_empty_parse");
+  assert.match(result.content[0].text, /zero parseable milestone lines/);
+  assert.equal(getAllMilestones().length, 0);
+});
+
+test("executeSummarySave registers milestones when PROJECT.md uses canonical em-dash format", async (t) => {
+  const base = setupBase(t);
+
+  const content = [
+    "# Project",
+    "",
+    "## What This Is",
+    "",
+    "Canonical milestone-sequence fixture.",
+    "",
+    "## Milestone Sequence",
+    "",
+    "- [ ] M001: Foo — bar",
+    "- [ ] M002: Baz — qux",
+    "",
+  ].join("\n");
+
+  const result = await inProjectDir(base, () => executeSummarySave({
+    artifact_type: "PROJECT",
+    content,
+  }, base));
+
+  assert.notEqual(result.isError, true);
+  assert.deepEqual(result.details.registeredMilestones, ["M001", "M002"]);
+  assert.equal(getAllMilestones().length, 2);
+});

package/src/resources/extensions/gsd/tests/execute-task-rendering.test.ts

@@ -0,0 +1,59 @@
+// Project/App: GSD-2
+// File Purpose: Verifies the execution prompt renders compact required guidance.
+
+import test from "node:test";
+import assert from "node:assert/strict";
+import { mkdtempSync, rmSync } from "node:fs";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
+
+test("execute-task prompt renders compact execution and completion gates", async (t) => {
+  const previousGsdHome = process.env.GSD_HOME;
+  const providedGsdHome = process.env.GSD_TEST_HOME;
+  const isolatedHome = providedGsdHome ?? mkdtempSync(join(tmpdir(), "gsd-execute-task-render-"));
+  const fixtureRoot = process.env.GSD_TEST_WORKSPACE_ROOT ?? process.cwd();
+  process.env.GSD_HOME = isolatedHome;
+  t.after(() => {
+    if (previousGsdHome === undefined) delete process.env.GSD_HOME;
+    else process.env.GSD_HOME = previousGsdHome;
+    if (!providedGsdHome) rmSync(isolatedHome, { recursive: true, force: true });
+  });
+
+  const { loadPrompt } = await import(`../prompt-loader.ts?test=${Date.now()}`);
+  const prompt = loadPrompt("execute-task", {
+    taskId: "T01",
+    taskTitle: "Implement compact prompts",
+    sliceId: "S01",
+    sliceTitle: "Prompt reduction",
+    milestoneId: "M001",
+    workingDirectory: fixtureRoot,
+    overridesSection: "",
+    runtimeContext: "Runtime context.",
+    phaseAnchorSection: "",
+    resumeSection: "",
+    carryForwardSection: "",
+    taskPlanInline: "## Task Plan\n\n1. Edit prompt.",
+    slicePlanExcerpt: "## Slice Plan\n\nReduce prompt size.",
+    gatesToClose: "- Gate: prompt markers retained.",
+    planPath: ".gsd/milestones/M001/slices/S01/S01-PLAN.md",
+    taskPlanPath: ".gsd/milestones/M001/slices/S01/tasks/T01-PLAN.md",
+    priorTaskLines: "- None",
+    skillActivation: "Load relevant skills.",
+    templatesDir: join(fixtureRoot, "templates"),
+    taskSummaryTemplatePath: "C:\\Users\\Test\\.gsd\\agent\\extensions\\gsd\\templates\\task-summary.md",
+    verificationBudget: "~10K chars",
+    taskSummaryPath: ".gsd/milestones/M001/slices/S01/tasks/T01-SUMMARY.md",
+  });
+
+  assert.match(prompt, /You execute\./);
+  assert.match(prompt, /Call `memory_query`/);
+  assert.match(prompt, /Before any `Write` that creates an artifact or output file/);
+  assert.match(prompt, /Build real behavior/);
+  assert.match(prompt, /Background process rule/);
+  assert.match(prompt, /blocker_discovered: true/);
+  assert.match(prompt, /C:\\Users\\Test\\.gsd\\agent\\extensions\\gsd\\templates\\task-summary\.md/);
+  assert.doesNotMatch(prompt, /\{\{templatesDir\}\}\/task-summary\.md/);
+  assert.match(prompt, /Call `gsd_task_complete`/);
+  assert.match(prompt, /Do not run git commands/);
+  assert.doesNotMatch(prompt, /\{\{[a-zA-Z][a-zA-Z0-9_]*\}\}/);
+});

package/src/resources/extensions/gsd/tests/fixtures/pr-body/commands-ship-basic.md

@@ -0,0 +1,52 @@
+## TL;DR
+
+**What:** Ship milestone M001 - Authentication
+**Why:** Users need to authenticate before accessing protected resources.
+**How:** Added password hash check and session token issuance.
+
+## What
+
+### S01
+Implemented login flow.
+
+## Why
+
+Users need to authenticate before accessing protected resources.
+
+## How
+
+Added password hash check and session token issuance.
+
+## Linked Issue
+
+Closes #123
+
+## Roadmap
+
+- [x] **S01: Login**
+
+## Metrics
+
+- **Units executed:** 3
+
+## Tests Run
+
+- npm test
+- npm run typecheck:extensions
+
+## Change Type
+
+- [x] `feat` - New feature or capability
+- [ ] `fix` - Bug fix
+- [ ] `refactor` - Code restructuring
+- [ ] `test` - Adding or updating tests
+- [ ] `docs` - Documentation only
+- [ ] `chore` - Build, CI, or tooling changes
+
+## Rollback And Compatibility
+
+- Revert the merge commit.
+
+## AI Assistance Disclosure
+
+This PR was prepared with AI assistance.

package/src/resources/extensions/gsd/tests/fixtures/pr-body/commands-ship-empty-optionals.md

@@ -0,0 +1,42 @@
+## TL;DR
+
+**What:** Ship milestone M001 - Authentication
+**Why:** Milestone work is complete and ready for review.
+**How:** Generated from GSD evidence and local workflow artifacts.
+
+## What
+
+Milestone M001 completed.
+
+## Why
+
+Milestone work is complete and ready for review.
+
+## How
+
+Generated from GSD evidence and local workflow artifacts.
+
+## Linked Issue
+
+Not specified. Add an issue link before marking this PR ready if CONTRIBUTING.md requires one.
+
+## Tests Run
+
+- Not specified. Add exact verification commands before requesting review.
+
+## Change Type
+
+- [x] `feat` - New feature or capability
+- [ ] `fix` - Bug fix
+- [ ] `refactor` - Code restructuring
+- [ ] `test` - Adding or updating tests
+- [ ] `docs` - Documentation only
+- [ ] `chore` - Build, CI, or tooling changes
+
+## Rollback And Compatibility
+
+- No behavior-changing rollback notes recorded.
+
+## AI Assistance Disclosure
+
+This PR was prepared with AI assistance.

package/src/resources/extensions/gsd/tests/fixtures/pr-body/swarm-lane-no-blockers.md

@@ -0,0 +1,55 @@
+## TL;DR
+
+**What:** Ship workflow lane/writer - lane/writer
+**Why:** Workflow work is complete and ready for review.
+**How:** Generated by GSD GitHub Sync swarm routines from lane evidence.
+
+## What
+
+### Swarm lane
+**Lane:** `lane/writer`
+**Branch:** `lane/single-writer`
+**Owner:** @owner
+**Latest commit:** `abc1234`
+
+### Impact area
+Single-writer UOK metadata.
+
+### Changed contracts
+- [ ] WriterToken
+
+### Transition risks
+- [ ] Writer token lifecycle regression
+
+## Why
+
+Workflow work is complete and ready for review.
+
+## How
+
+Generated by GSD GitHub Sync swarm routines from lane evidence.
+
+## Linked Issue
+
+Closes #123
+
+## Tests Run
+
+- npm run typecheck:extensions
+
+## Change Type
+
+- [ ] `feat` - New feature or capability
+- [ ] `fix` - Bug fix
+- [x] `refactor` - Code restructuring
+- [ ] `test` - Adding or updating tests
+- [ ] `docs` - Documentation only
+- [ ] `chore` - Build, CI, or tooling changes
+
+## Rollback And Compatibility
+
+- Disable writer sequence enrichment
+
+## AI Assistance Disclosure
+
+This PR was prepared with AI assistance.

package/src/resources/extensions/gsd/tests/fixtures/pr-body/swarm-lane-with-blockers.md

@@ -0,0 +1,60 @@
+## TL;DR
+
+**What:** Ship workflow lane/writer - lane/writer
+**Why:** Workflow work is complete and ready for review.
+**How:** Generated by GSD GitHub Sync swarm routines from lane evidence.
+
+## What
+
+### Swarm lane
+**Lane:** `lane/writer`
+**Branch:** `lane/single-writer`
+**Owner:** @owner
+**Latest commit:** `abc1234`
+
+### Impact area
+Single-writer UOK metadata.
+
+### Changed contracts
+- [ ] WriterToken
+
+### Transition risks
+- [ ] Writer token lifecycle regression
+
+## Blockers
+
+- Awaiting state-lane writer-sequence merge
+- Parity report incomplete
+
+## Why
+
+Workflow work is complete and ready for review.
+
+## How
+
+Generated by GSD GitHub Sync swarm routines from lane evidence.
+
+## Linked Issue
+
+Closes #123
+
+## Tests Run
+
+- npm run typecheck:extensions
+
+## Change Type
+
+- [ ] `feat` - New feature or capability
+- [ ] `fix` - Bug fix
+- [x] `refactor` - Code restructuring
+- [ ] `test` - Adding or updating tests
+- [ ] `docs` - Documentation only
+- [ ] `chore` - Build, CI, or tooling changes
+
+## Rollback And Compatibility
+
+- Disable writer sequence enrichment
+
+## AI Assistance Disclosure
+
+This PR was prepared with AI assistance.

package/src/resources/extensions/gsd/tests/forensics-prompt-rendering.test.ts

@@ -0,0 +1,36 @@
+// Project/App: GSD-2
+// File Purpose: Verifies the forensics prompt renders required investigation and issue-routing guidance.
+
+import test from "node:test";
+import assert from "node:assert/strict";
+import { mkdtempSync, rmSync } from "node:fs";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
+
+test("forensics prompt renders compact investigation and issue routing guidance", async (t) => {
+  const previousGsdHome = process.env.GSD_HOME;
+  const providedGsdHome = process.env.GSD_TEST_HOME;
+  const isolatedHome = providedGsdHome ?? mkdtempSync(join(tmpdir(), "gsd-forensics-render-"));
+  process.env.GSD_HOME = isolatedHome;
+  t.after(() => {
+    if (previousGsdHome === undefined) delete process.env.GSD_HOME;
+    else process.env.GSD_HOME = previousGsdHome;
+    if (!providedGsdHome) rmSync(isolatedHome, { recursive: true, force: true });
+  });
+
+  const { loadPrompt } = await import(`../prompt-loader.ts?test=${Date.now()}`);
+  const prompt = loadPrompt("forensics", {
+    problemDescription: "Auto-mode repeats the same unit.",
+    forensicData: "stuck-detected event for execute-task/M001/S01/T01",
+    gsdSourceDir: process.env.GSD_TEST_WORKSPACE_ROOT ?? process.cwd(),
+    dedupSection: "No duplicate issue found.",
+  });
+
+  assert.match(prompt, /Investigation Protocol/);
+  assert.match(prompt, /gsd_milestone_status/);
+  assert.match(prompt, /sqlite3 .gsd\/gsd.db/);
+  assert.match(prompt, /gh issue create --repo gsd-build\/gsd-2/);
+  assert.match(prompt, /Do NOT use the `github_issues` tool/);
+  assert.match(prompt, /Redaction Rules/);
+  assert.doesNotMatch(prompt, /\{\{[a-zA-Z][a-zA-Z0-9_]*\}\}/);
+});

package/src/resources/extensions/gsd/tests/graph-operations.test.ts

@@ -233,6 +233,16 @@ describe("getNextPendingStep", () => {
     const next = getNextPendingStep(graph);
     assert.equal(next?.id, "b");
   });
+
+  it("treats expanded dependencies as satisfied", (t) => {
+    const graph = makeGraph([
+      makeStep({ id: "iter", status: "expanded" }),
+      makeStep({ id: "after", dependsOn: ["iter"] }),
+    ]);
+
+    const next = getNextPendingStep(graph);
+    assert.equal(next?.id, "after");
+  });
 });
 
 // ─── markStepComplete ────────────────────────────────────────────────────