gsd-pi 2.79.0 → 2.80.0-dev.4ea7d80e7

package/src/resources/extensions/gsd/tests/db-provider.test.ts

@@ -0,0 +1,105 @@
+// Project/App: GSD-2
+// File Purpose: Tests for SQLite provider loading and fallback behavior.
+
+import { describe, test } from "node:test";
+import assert from "node:assert/strict";
+import { createSqliteProviderLoader, type SqliteProviderDeps } from "../db-provider.ts";
+
+class FakeNodeDatabase {
+  readonly path: string;
+
+  constructor(path: string) {
+    this.path = path;
+  }
+}
+
+class FakeBetterDatabase {
+  readonly path: string;
+
+  constructor(path: string) {
+    this.path = path;
+  }
+}
+
+function createDeps(overrides: Partial<SqliteProviderDeps> = {}): SqliteProviderDeps & { stderr: string[] } {
+  const stderr: string[] = [];
+  return {
+    requireModule(id: string): unknown {
+      if (id === "node:sqlite") return { DatabaseSync: FakeNodeDatabase };
+      throw new Error(`unexpected module: ${id}`);
+    },
+    suppressSqliteWarning(): void {},
+    nodeVersion: "22.0.0",
+    writeStderr(message: string): void {
+      stderr.push(message);
+    },
+    stderr,
+    ...overrides,
+  };
+}
+
+describe("db-provider", () => {
+  test("loads node:sqlite first and opens raw databases with it", () => {
+    const loader = createSqliteProviderLoader(createDeps());
+
+    const rawDb = loader.openRaw("/tmp/gsd-node.db");
+
+    assert.equal(loader.getProviderName(), "node:sqlite");
+    assert.ok(rawDb instanceof FakeNodeDatabase);
+    assert.equal((rawDb as FakeNodeDatabase).path, "/tmp/gsd-node.db");
+  });
+
+  test("falls back to better-sqlite3 when node:sqlite is unavailable", () => {
+    const loader = createSqliteProviderLoader(createDeps({
+      requireModule(id: string): unknown {
+        if (id === "node:sqlite") throw new Error("node sqlite unavailable");
+        if (id === "better-sqlite3") return FakeBetterDatabase;
+        throw new Error(`unexpected module: ${id}`);
+      },
+    }));
+
+    const rawDb = loader.openRaw("/tmp/gsd-better.db");
+
+    assert.equal(loader.getProviderName(), "better-sqlite3");
+    assert.ok(rawDb instanceof FakeBetterDatabase);
+    assert.equal((rawDb as FakeBetterDatabase).path, "/tmp/gsd-better.db");
+  });
+
+  test("reports provider unavailability with a Node version hint below Node 22", () => {
+    const deps = createDeps({
+      requireModule(): unknown {
+        throw new Error("unavailable");
+      },
+      nodeVersion: "20.11.1",
+    });
+    const loader = createSqliteProviderLoader(deps);
+
+    assert.equal(loader.openRaw("/tmp/gsd-none.db"), null);
+
+    assert.equal(loader.getProviderName(), null);
+    assert.equal(deps.stderr.length, 1);
+    assert.match(deps.stderr[0], /No SQLite provider available/);
+    assert.match(deps.stderr[0], /Node >= 22\.0\.0/);
+  });
+
+  test("opens better-sqlite3 fallback without committing it until requested", () => {
+    const loader = createSqliteProviderLoader(createDeps({
+      requireModule(id: string): unknown {
+        if (id === "node:sqlite") return { DatabaseSync: FakeNodeDatabase };
+        if (id === "better-sqlite3") return { default: FakeBetterDatabase };
+        throw new Error(`unexpected module: ${id}`);
+      },
+    }));
+
+    loader.load();
+    const fallback = loader.tryOpenBetterSqliteFallback("/tmp/gsd-fallback.db");
+
+    assert.equal(loader.getProviderName(), "node:sqlite");
+    assert.ok(fallback);
+    assert.ok(fallback.rawDb instanceof FakeBetterDatabase);
+    assert.equal((fallback.rawDb as FakeBetterDatabase).path, "/tmp/gsd-fallback.db");
+
+    loader.commitFallback(fallback);
+    assert.equal(loader.getProviderName(), "better-sqlite3");
+  });
+});

package/src/resources/extensions/gsd/tests/db-runtime-kv-schema.test.ts

@@ -0,0 +1,37 @@
+// Project/App: GSD-2
+// File Purpose: Tests for runtime_kv schema helper.
+
+import { describe, test } from "node:test";
+import assert from "node:assert/strict";
+import { createRuntimeKvTableV25 } from "../db-runtime-kv-schema.ts";
+import type { DbAdapter, DbStatement } from "../db-adapter.ts";
+
+class FakeAdapter implements DbAdapter {
+  readonly execCalls: string[] = [];
+
+  exec(sql: string): void {
+    this.execCalls.push(sql);
+  }
+
+  prepare(): DbStatement {
+    throw new Error("prepare is not used by runtime_kv schema tests");
+  }
+
+  close(): void {}
+}
+
+describe("db-runtime-kv-schema", () => {
+  test("creates the runtime_kv table with soft-state scope key columns", () => {
+    const db = new FakeAdapter();
+
+    createRuntimeKvTableV25(db);
+
+    assert.equal(db.execCalls.length, 1);
+    assert.match(db.execCalls[0], /CREATE TABLE IF NOT EXISTS runtime_kv/);
+    assert.match(db.execCalls[0], /scope TEXT NOT NULL/);
+    assert.match(db.execCalls[0], /scope_id TEXT NOT NULL DEFAULT ''/);
+    assert.match(db.execCalls[0], /key TEXT NOT NULL/);
+    assert.match(db.execCalls[0], /value_json TEXT NOT NULL/);
+    assert.match(db.execCalls[0], /PRIMARY KEY \(scope, scope_id, key\)/);
+  });
+});

package/src/resources/extensions/gsd/tests/db-schema-metadata.test.ts

@@ -0,0 +1,115 @@
+// Project/App: GSD-2
+// File Purpose: Tests for SQLite schema metadata helpers.
+
+import { describe, test } from "node:test";
+import assert from "node:assert/strict";
+import { columnExists, ensureColumn, getCurrentSchemaVersion, indexExists, recordSchemaVersion } from "../db-schema-metadata.ts";
+import type { DbAdapter, DbStatement } from "../db-adapter.ts";
+
+class FakeStatement implements DbStatement {
+  private readonly getResult: Record<string, unknown> | undefined;
+  private readonly allResult: Record<string, unknown>[];
+  private readonly onRun: ((params: unknown[]) => void) | undefined;
+
+  constructor(
+    getResult: Record<string, unknown> | undefined,
+    allResult: Record<string, unknown>[],
+    onRun?: (params: unknown[]) => void,
+  ) {
+    this.getResult = getResult;
+    this.allResult = allResult;
+    this.onRun = onRun;
+  }
+
+  run(...params: unknown[]): unknown {
+    this.onRun?.(params);
+    return undefined;
+  }
+
+  get(): Record<string, unknown> | undefined {
+    return this.getResult;
+  }
+
+  all(): Record<string, unknown>[] {
+    return this.allResult;
+  }
+}
+
+class FakeAdapter implements DbAdapter {
+  readonly execCalls: string[] = [];
+  readonly runCalls: unknown[][] = [];
+  readonly preparedSql: string[] = [];
+  indexNames = new Set<string>();
+  tableColumns = new Map<string, string[]>();
+  currentVersion: number | undefined = undefined;
+
+  exec(sql: string): void {
+    this.execCalls.push(sql);
+  }
+
+  prepare(sql: string): DbStatement {
+    this.preparedSql.push(sql);
+    if (sql.includes("sqlite_master")) {
+      return new FakeStatement(this.indexNames.size > 0 ? { present: 1 } : undefined, []);
+    }
+    if (sql.includes("SELECT MAX(version)")) {
+      return new FakeStatement(this.currentVersion === undefined ? undefined : { v: this.currentVersion }, []);
+    }
+    if (sql.includes("INSERT INTO schema_version")) {
+      return new FakeStatement(undefined, [], (params) => {
+        this.runCalls.push(params);
+      });
+    }
+    const tableMatch = /^PRAGMA table_info\(([^)]+)\)$/.exec(sql);
+    if (tableMatch) {
+      const columns = this.tableColumns.get(tableMatch[1]) ?? [];
+      return new FakeStatement(undefined, columns.map((name) => ({ name })));
+    }
+    return new FakeStatement(undefined, []);
+  }
+
+  close(): void {}
+}
+
+describe("db-schema-metadata", () => {
+  test("indexExists returns true when sqlite_master has a row", () => {
+    const db = new FakeAdapter();
+    db.indexNames.add("idx_present");
+
+    assert.equal(indexExists(db, "idx_present"), true);
+  });
+
+  test("columnExists reads table_info rows", () => {
+    const db = new FakeAdapter();
+    db.tableColumns.set("tasks", ["id", "status"]);
+
+    assert.equal(columnExists(db, "tasks", "status"), true);
+    assert.equal(columnExists(db, "tasks", "missing"), false);
+  });
+
+  test("ensureColumn executes ddl only when the column is missing", () => {
+    const db = new FakeAdapter();
+    db.tableColumns.set("tasks", ["id"]);
+
+    ensureColumn(db, "tasks", "status", "ALTER TABLE tasks ADD COLUMN status TEXT");
+    ensureColumn(db, "tasks", "id", "ALTER TABLE tasks ADD COLUMN id TEXT");
+
+    assert.deepEqual(db.execCalls, ["ALTER TABLE tasks ADD COLUMN status TEXT"]);
+  });
+
+  test("getCurrentSchemaVersion returns zero when no version row exists", () => {
+    const db = new FakeAdapter();
+
+    assert.equal(getCurrentSchemaVersion(db), 0);
+  });
+
+  test("records schema version rows with timestamps", () => {
+    const db = new FakeAdapter();
+
+    recordSchemaVersion(db, 26);
+
+    assert.equal(db.runCalls.length, 1);
+    assert.equal((db.runCalls[0][0] as Record<string, unknown>)[":version"], 26);
+    assert.equal(typeof (db.runCalls[0][0] as Record<string, unknown>)[":applied_at"], "string");
+  });
+});

package/src/resources/extensions/gsd/tests/db-task-slice-rows.test.ts

@@ -0,0 +1,128 @@
+// Project/App: GSD-2
+// File Purpose: Tests for task and slice database row mappers.
+
+import { describe, test } from "node:test";
+import assert from "node:assert/strict";
+import { parseTaskArrayColumn, rowToSlice, rowToTask } from "../db-task-slice-rows.ts";
+
+describe("db-task-slice-rows", () => {
+  test("parseTaskArrayColumn handles JSON arrays, scalar JSON, raw arrays, and legacy CSV", () => {
+    assert.deepEqual(parseTaskArrayColumn('["a.ts","b.ts"]'), ["a.ts", "b.ts"]);
+    assert.deepEqual(parseTaskArrayColumn('"single.ts"'), ["single.ts"]);
+    assert.deepEqual(parseTaskArrayColumn(["a.ts", 42, "b.ts"]), ["a.ts", "b.ts"]);
+    assert.deepEqual(parseTaskArrayColumn(" a.ts, b.ts ,, "), ["a.ts", "b.ts"]);
+    assert.deepEqual(parseTaskArrayColumn(""), []);
+    assert.deepEqual(parseTaskArrayColumn(null), []);
+  });
+
+  test("rowToSlice maps optional DB columns to stable defaults", () => {
+    const slice = rowToSlice({
+      milestone_id: "M001",
+      id: "S01",
+      title: "Build the thing",
+      status: "active",
+      risk: "medium",
+      depends: '["S00"]',
+      created_at: "2026-05-04T00:00:00.000Z",
+    });
+
+    assert.deepEqual(slice, {
+      milestone_id: "M001",
+      id: "S01",
+      title: "Build the thing",
+      status: "active",
+      risk: "medium",
+      depends: ["S00"],
+      demo: "",
+      created_at: "2026-05-04T00:00:00.000Z",
+      completed_at: null,
+      full_summary_md: "",
+      full_uat_md: "",
+      goal: "",
+      success_criteria: "",
+      proof_level: "",
+      integration_closure: "",
+      observability_impact: "",
+      sequence: 0,
+      replan_triggered_at: null,
+      is_sketch: 0,
+      sketch_scope: "",
+    });
+  });
+
+  test("rowToTask maps planning and escalation columns", () => {
+    const task = rowToTask({
+      milestone_id: "M001",
+      slice_id: "S01",
+      id: "T01",
+      title: "Extract row mapper",
+      status: "done",
+      one_liner: "Mapper extraction",
+      narrative: "Moved row shaping",
+      verification_result: "passed",
+      duration: "5m",
+      completed_at: "2026-05-04T00:00:00.000Z",
+      blocker_discovered: 1,
+      deviations: "",
+      known_issues: "",
+      key_files: "a.ts,b.ts",
+      key_decisions: '["D001"]',
+      full_summary_md: "summary",
+      description: "description",
+      estimate: "small",
+      files: '["src/a.ts"]',
+      verify: "npm test",
+      inputs: '"input.md"',
+      expected_output: "result.md,report.md",
+      observability_impact: "none",
+      full_plan_md: "plan",
+      sequence: 3,
+      blocker_source: "test",
+      escalation_pending: 1,
+      escalation_awaiting_review: 0,
+      escalation_artifact_path: "/tmp/escalation.md",
+      escalation_override_applied_at: "2026-05-04T00:01:00.000Z",
+    });
+
+    assert.equal(task.blocker_discovered, true);
+    assert.deepEqual(task.key_files, ["a.ts", "b.ts"]);
+    assert.deepEqual(task.key_decisions, ["D001"]);
+    assert.deepEqual(task.files, ["src/a.ts"]);
+    assert.deepEqual(task.inputs, ["input.md"]);
+    assert.deepEqual(task.expected_output, ["result.md", "report.md"]);
+    assert.equal(task.sequence, 3);
+    assert.equal(task.escalation_pending, 1);
+    assert.equal(task.escalation_artifact_path, "/tmp/escalation.md");
+  });
+
+  test("rowToTask defaults optional planning and escalation fields", () => {
+    const task = rowToTask({
+      milestone_id: "M001",
+      slice_id: "S01",
+      id: "T01",
+      title: "Pending",
+      status: "pending",
+      one_liner: "",
+      narrative: "",
+      verification_result: "",
+      duration: "",
+      blocker_discovered: 0,
+      deviations: "",
+      known_issues: "",
+      key_files: "",
+      key_decisions: "",
+      full_summary_md: "",
+    });
+
+    assert.equal(task.completed_at, null);
+    assert.deepEqual(task.files, []);
+    assert.deepEqual(task.inputs, []);
+    assert.deepEqual(task.expected_output, []);
+    assert.equal(task.sequence, 0);
+    assert.equal(task.blocker_source, "");
+    assert.equal(task.escalation_pending, 0);
+    assert.equal(task.escalation_awaiting_review, 0);
+    assert.equal(task.escalation_artifact_path, null);
+    assert.equal(task.escalation_override_applied_at, null);
+  });
+});

package/src/resources/extensions/gsd/tests/db-transaction.test.ts

@@ -0,0 +1,110 @@
+// Project/App: GSD-2
+// File Purpose: Tests for DB transaction depth and rollback helpers.
+
+import { describe, test } from "node:test";
+import assert from "node:assert/strict";
+import { createDbTransactionRunner, type DbTransactionControls } from "../db-transaction.ts";
+
+class FakeTransactionControls implements DbTransactionControls {
+  readonly calls: string[] = [];
+  failCall = new Set<string>();
+
+  begin(): void {
+    this.record("BEGIN");
+  }
+
+  beginRead(): void {
+    this.record("BEGIN DEFERRED");
+  }
+
+  commit(): void {
+    this.record("COMMIT");
+  }
+
+  rollback(): void {
+    this.record("ROLLBACK");
+  }
+
+  private record(call: string): void {
+    this.calls.push(call);
+    if (this.failCall.has(call)) throw new Error(`failed ${call}`);
+  }
+}
+
+describe("db-transaction", () => {
+  test("commits successful write transactions", () => {
+    const runner = createDbTransactionRunner();
+    const controls = new FakeTransactionControls();
+
+    const result = runner.transaction(controls, () => {
+      assert.equal(runner.isInTransaction(), true);
+      return "ok";
+    });
+
+    assert.equal(result, "ok");
+    assert.equal(runner.isInTransaction(), false);
+    assert.deepEqual(controls.calls, ["BEGIN", "COMMIT"]);
+  });
+
+  test("rolls back failed write transactions and clears depth", () => {
+    const runner = createDbTransactionRunner();
+    const controls = new FakeTransactionControls();
+
+    assert.throws(
+      () => runner.transaction(controls, () => {
+        throw new Error("boom");
+      }),
+      /boom/,
+    );
+
+    assert.equal(runner.isInTransaction(), false);
+    assert.deepEqual(controls.calls, ["BEGIN", "ROLLBACK"]);
+  });
+
+  test("nested transactions do not issue nested BEGIN or COMMIT", () => {
+    const runner = createDbTransactionRunner();
+    const controls = new FakeTransactionControls();
+
+    runner.transaction(controls, () => {
+      runner.transaction(controls, () => {
+        assert.equal(runner.isInTransaction(), true);
+      });
+    });
+
+    assert.deepEqual(controls.calls, ["BEGIN", "COMMIT"]);
+  });
+
+  test("failed BEGIN does not mark transaction depth active", () => {
+    const runner = createDbTransactionRunner();
+    const controls = new FakeTransactionControls();
+    controls.failCall.add("BEGIN");
+
+    assert.throws(() => runner.transaction(controls, () => undefined), /failed BEGIN/);
+
+    assert.equal(runner.isInTransaction(), false);
+    assert.deepEqual(controls.calls, ["BEGIN"]);
+  });
+
+  test("read transactions log rollback failures and clear depth", () => {
+    const runner = createDbTransactionRunner();
+    const controls = new FakeTransactionControls();
+    const rollbackErrors: Error[] = [];
+    controls.failCall.add("ROLLBACK");
+
+    assert.throws(
+      () => runner.readTransaction(
+        controls,
+        () => {
+          throw new Error("read failed");
+        },
+        (error) => rollbackErrors.push(error),
+      ),
+      /read failed/,
+    );
+
+    assert.equal(runner.isInTransaction(), false);
+    assert.deepEqual(controls.calls, ["BEGIN DEFERRED", "ROLLBACK"]);
+    assert.equal(rollbackErrors.length, 1);
+    assert.match(rollbackErrors[0].message, /failed ROLLBACK/);
+  });
+});

package/src/resources/extensions/gsd/tests/db-verification-evidence-schema.test.ts

@@ -0,0 +1,76 @@
+// Project/App: GSD-2
+// File Purpose: Tests for verification evidence schema helpers.
+
+import { describe, test } from "node:test";
+import assert from "node:assert/strict";
+import {
+  dedupeVerificationEvidenceRows,
+  ensureVerificationEvidenceDedupIndex,
+} from "../db-verification-evidence-schema.ts";
+import type { DbAdapter, DbStatement } from "../db-adapter.ts";
+
+class FakeStatement implements DbStatement {
+  private readonly row: Record<string, unknown> | undefined;
+
+  constructor(row: Record<string, unknown> | undefined) {
+    this.row = row;
+  }
+
+  run(): unknown {
+    return undefined;
+  }
+
+  get(): Record<string, unknown> | undefined {
+    return this.row;
+  }
+
+  all(): Record<string, unknown>[] {
+    return [];
+  }
+}
+
+class FakeAdapter implements DbAdapter {
+  readonly execCalls: string[] = [];
+  hasDedupIndex = false;
+
+  exec(sql: string): void {
+    this.execCalls.push(sql);
+  }
+
+  prepare(): DbStatement {
+    return new FakeStatement(this.hasDedupIndex ? { present: 1 } : undefined);
+  }
+
+  close(): void {}
+}
+
+describe("db-verification-evidence-schema", () => {
+  test("dedupeVerificationEvidenceRows keeps the first row for each evidence identity", () => {
+    const db = new FakeAdapter();
+
+    dedupeVerificationEvidenceRows(db);
+
+    assert.equal(db.execCalls.length, 1);
+    assert.match(db.execCalls[0], /DELETE FROM verification_evidence/);
+    assert.match(db.execCalls[0], /GROUP BY task_id, slice_id, milestone_id, command, verdict/);
+  });
+
+  test("ensureVerificationEvidenceDedupIndex dedupes before creating the unique index", () => {
+    const db = new FakeAdapter();
+
+    ensureVerificationEvidenceDedupIndex(db);
+
+    assert.equal(db.execCalls.length, 2);
+    assert.match(db.execCalls[0], /DELETE FROM verification_evidence/);
+    assert.match(db.execCalls[1], /CREATE UNIQUE INDEX IF NOT EXISTS idx_verification_evidence_dedup/);
+  });
+
+  test("ensureVerificationEvidenceDedupIndex no-ops when the index already exists", () => {
+    const db = new FakeAdapter();
+    db.hasDedupIndex = true;
+
+    ensureVerificationEvidenceDedupIndex(db);
+
+    assert.deepEqual(db.execCalls, []);
+  });
+});

package/src/resources/extensions/gsd/tests/deep-planning-mode-dispatch.test.ts

@@ -14,6 +14,7 @@ import {
   DISPATCH_RULES,
   getDeepStageGate,
   hasPendingDeepStage,
+  resolveDispatch,
   setResearchProjectPromptBuilderForTest,
   type DispatchContext,
 } from "../auto-dispatch.ts";
@@ -248,6 +249,11 @@ function writeCapturedDeepPrefs(base: string): void {
   );
 }
 
+function writeSkippedProjectResearchDecision(base: string): void {
+  mkdirSync(join(base, ".gsd", "runtime"), { recursive: true });
+  writeFileSync(join(base, ".gsd", "runtime", "research-decision.json"), JSON.stringify({ decision: "skip" }));
+}
+
 function makeCtx(
   basePath: string,
   prefs: GSDPreferences | undefined,
@@ -785,6 +791,42 @@ test("Deep mode: research-project DOES dispatch when only 3 of 4 research files
   assert.ok(result && result.action === "dispatch", "any missing dimension must trigger re-run");
 });
 
+test("Deep mode: queued milestone without CONTEXT.md routes to milestone research after project setup", async (t) => {
+  const base = makeIsolatedBaseWithCleanup(t);
+
+  writeCapturedDeepPrefs(base);
+  writeValidProject(base);
+  writeValidRequirements(base);
+  writeSkippedProjectResearchDecision(base);
+
+  const prefs = { planning_depth: "deep" } as GSDPreferences;
+  const result = await resolveDispatch(makeCtx(base, prefs));
+
+  assert.equal(result.action, "dispatch");
+  if (result.action === "dispatch") {
+    assert.equal(result.unitType, "research-milestone");
+    assert.equal(result.unitId, "M001");
+  }
+});
+
+test("Deep mode: queued milestone without CONTEXT.md can route directly to milestone planning", async (t) => {
+  const base = makeIsolatedBaseWithCleanup(t);
+
+  writeCapturedDeepPrefs(base);
+  writeValidProject(base);
+  writeValidRequirements(base);
+  writeSkippedProjectResearchDecision(base);
+
+  const prefs = { planning_depth: "deep", phases: { skip_research: true } } as GSDPreferences;
+  const result = await resolveDispatch(makeCtx(base, prefs));
+
+  assert.equal(result.action, "dispatch");
+  if (result.action === "dispatch") {
+    assert.equal(result.unitType, "plan-milestone");
+    assert.equal(result.unitId, "M001");
+  }
+});
+
 // ─── centralized deep-stage gate ─────────────────────────────────────────
 
 test("Deep mode gate reports the earliest missing section", (t) => {