gsd-pi 2.78.1-dev.84a383f51 → 2.78.1

package/packages/pi-tui/dist/components/__tests__/leak-fixes-runtime.test.js.map

@@ -1 +0,0 @@
-{"version":3,"file":"leak-fixes-runtime.test.js","sourceRoot":"","sources":["../../../src/components/__tests__/leak-fixes-runtime.test.ts"],"names":[],"mappings":"AAAA,oEAAoE;AACpE,EAAE;AACF,yEAAyE;AACzE,uEAAuE;AACvE,6EAA6E;AAC7E,oFAAoF;AACpF,kEAAkE;AAClE,EAAE;AACF,8EAA8E;AAC9E,uCAAuC;AAEvC,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,IAAI,EAAE,UAAU,EAAE,SAAS,EAAE,MAAM,WAAW,CAAC;AACtE,OAAO,MAAM,MAAM,oBAAoB,CAAC;AACxC,OAAO,EAAE,SAAS,EAAE,MAAM,cAAc,CAAC;AACzC,OAAO,EAAE,MAAM,EAAE,MAAM,cAAc,CAAC;AACtC,OAAO,EAAE,IAAI,EAAE,MAAM,YAAY,CAAC;AAMlC,SAAS,WAAW;IACnB,OAAO,EAAE,aAAa,EAAE,IAAI,CAAC,EAAE,EAAE,EAAE,CAAC;AACrC,CAAC;AAED,2EAA2E;AAE3E,QAAQ,CAAC,sDAAsD,EAAE,GAAG,EAAE;IACrE,EAAE,CAAC,qEAAqE,EAAE,GAAG,EAAE;QAC9E,qEAAqE;QACrE,sEAAsE;QACtE,iEAAiE;QACjE,8DAA8D;QAC9D,MAAM,CAAC,GAAG,IAAI,SAAS,EAAE,CAAC;QAC1B,CAAC,CAAC,QAAQ,CAAC,IAAI,IAAI,CAAC,OAAO,EAAE,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC;QAEpC,MAAM,KAAK,GAAG,CAAC,CAAC,MAAM,CAAC,EAAE,CAAC,CAAC;QAC3B,MAAM,MAAM,GAAG,CAAC,CAAC,MAAM,CAAC,EAAE,CAAC,CAAC;QAC5B,MAAM,CAAC,WAAW,CACjB,MAAM,EACN,KAAK,EACL,2EAA2E;YAC1E,oEAAoE,CACrE,CAAC;IACH,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,0EAA0E,EAAE,GAAG,EAAE;QACnF,kEAAkE;QAClE,oEAAoE;QACpE,oEAAoE;QACpE,6DAA6D;QAC7D,MAAM,CAAC,GAAG,IAAI,SAAS,EAAE,CAAC;QAC1B,CAAC,CAAC,QAAQ,CAAC,IAAI,IAAI,CAAC,GAAG,EAAE,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC;QAChC,MAAM,KAAK,GAAG,CAAC,CAAC,MAAM,CAAC,EAAE,CAAC,CAAC;QAC3B,CAAC,CAAC,QAAQ,CAAC,IAAI,IAAI,CAAC,GAAG,EAAE,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC;QAChC,MAAM,MAAM,GAAG,CAAC,CAAC,MAAM,CAAC,EAAE,CAAC,CAAC;QAC5B,MAAM,CAAC,cAAc,CACpB,MAAM,EACN,KAAK,EACL,4DAA4D,CAC5D,CAAC;IACH,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,qDAAqD,EAAE,GAAG,EAAE;QAC9D,MAAM,CAAC,GAAG,IAAI,IAAI,CAAC,OAAO,EAAE,CAAC,EAAE,CAAC,CAAC,CAAC;QAClC,MAAM,CAAC,GAAG,IAAI,SAAS,EAAE,CAAC;QAC1B,CAAC,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC;QAEd,MAAM,KAAK,GAAG,CAAC,CAAC,MAAM,CAAC,EAAE,CAAC,CAAC;QAC3B,CAAC,CAAC,OAAO,CAAC,OAAO,CAAC,CAAC;QACnB,MAAM,MAAM,GAAG,CAAC,CAAC,MAAM,CAAC,EAAE,CAAC,CAAC;QAC5B,MAAM,CAAC,cAAc,CACpB,MAAM,EACN,KAAK,EACL,yEAAyE,CACzE,CAAC;IACH,CAAC,CAAC,CAAC;AACJ,CAAC,CAAC,CAAC;AAEH,2EAA2E;AAE3E,QAAQ,CAAC,yDAAyD,EAAE,GAAG,EAAE;IACxE,IAAI,GAAY,CAAC;IACjB,IAAI,MAAc,CAAC;IAEnB,UAAU,CAAC,GAAG,EAAE;QACf,GAAG,GAAG,WAAW,EAAE,CAAC;QACpB,IAAI,CAAC,MAAM,CAAC,MAAM,CAAC,EAAE,IAAI,EAAE,CAAC,aAAa,CAAC,EAAE,CAAC,CAAC;IAC/C,CAAC,CAAC,CAAC;IAEH,SAAS,CAAC,GAAG,EAAE;QACd,IAAI,CAAC;YACJ,MAAM,EAAE,IAAI,EAAE,CAAC;QAChB,CAAC;QAAC,MAAM,CAAC;YACR,iBAAiB;QAClB,CAAC;QACD,IAAI,CAAC,MAAM,CAAC,KAAK,EAAE,CAAC;IACrB,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,gEAAgE,EAAE,GAAG,EAAE;QACzE,+DAA+D;QAC/D,+DAA+D;QAC/D,gEAAgE;QAChE,+BAA+B;QAC/B,gEAAgE;QAChE,6DAA6D;QAC7D,mEAAmE;QACnE,+DAA+D;QAC/D,oEAAoE;QACpE,kDAAkD;QAClD,MAAM,GAAG,IAAI,MAAM,CAAC,GAAY,EAAE,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,EAAE,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,EAAE,aAAa,CAAC,CAAC;QAErE,MAAM,MAAM,GAAG,MAAM,CAAC,MAAM,CAAC,EAAE,CAAC,CAAC;QACjC,8DAA8D;QAC9D,oDAAoD;QACpD,IAAI,CAAC,MAAM,CAAC,IAAI,CAAC,EAAE,GAAG,EAAE,CAAC,CAAC;QAC1B,MAAM,KAAK,GAAG,MAAM,CAAC,MAAM,CAAC,EAAE,CAAC,CAAC;QAEhC,oEAAoE;QACpE,kEAAkE;QAClE,+CAA+C;QAC/C,MAAM,CAAC,KAAK,CAAC,MAAM,CAAC,MAAM,EAAE,KAAK,CAAC,MAAM,EAAE,kCAAkC,CAAC,CAAC;QAC9E,qEAAqE;QACrE,mEAAmE;QACnE,mDAAmD;QACnD,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,MAAM,CAAC,MAAM,EAAE,CAAC,EAAE,EAAE,CAAC;YACxC,MAAM,CAAC,KAAK,CACX,KAAK,CAAC,CAAC,CAAC,EACR,MAAM,CAAC,CAAC,CAAC,EACT,gBAAgB,CAAC,mDAAmD;gBACnE,mDAAmD,CACpD,CAAC;QACH,CAAC;IACF,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,kEAAkE,EAAE,GAAG,EAAE;QAC3E,gEAAgE;QAChE,+DAA+D;QAC/D,oEAAoE;QACpE,yCAAyC;QACzC,MAAM,GAAG,IAAI,MAAM,CAAC,GAAY,EAAE,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,EAAE,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,EAAE,OAAO,CAAC,CAAC;QAC/D,MAAM,iBAAiB,GAAG,MAAM,CAAC,MAAM,CAAC,EAAE,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QACvD,MAAM,CAAC,UAAU,CAAC,QAAQ,CAAC,CAAC;QAC5B,MAAM,WAAW,GAAG,MAAM,CAAC,MAAM,CAAC,EAAE,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QACjD,MAAM,CAAC,EAAE,CAAC,WAAW,CAAC,QAAQ,CAAC,QAAQ,CAAC,EAAE,yBAAyB,CAAC,CAAC;QACrE,MAAM,CAAC,EAAE,CAAC,CAAC,WAAW,CAAC,QAAQ,CAAC,OAAO,CAAC,IAAI,iBAAiB,KAAK,WAAW,EAC5E,gDAAgD,CAAC,CAAC;IACpD,CAAC,CAAC,CAAC;AACJ,CAAC,CAAC,CAAC;AAEH,2EAA2E;AAE3E,QAAQ,CAAC,oDAAoD,EAAE,GAAG,EAAE;IACnE,EAAE,CAAC,4EAA4E,EAAE,GAAG,EAAE;QACrF,+DAA+D;QAC/D,qEAAqE;QACrE,sDAAsD;QACtD,MAAM,CAAC,GAAG,IAAI,IAAI,CAAC,WAAW,EAAE,CAAC,EAAE,CAAC,CAAC,CAAC;QACtC,MAAM,KAAK,GAAG,CAAC,CAAC,MAAM,CAAC,EAAE,CAAC,CAAC;QAC3B,CAAC,CAAC,OAAO,CAAC,WAAW,CAAC,CAAC,CAAC,wCAAwC;QAChE,MAAM,MAAM,GAAG,CAAC,CAAC,MAAM,CAAC,EAAE,CAAC,CAAC;QAC5B,MAAM,CAAC,WAAW,CACjB,MAAM,EACN,KAAK,EACL,oEAAoE,CACpE,CAAC;IACH,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,mDAAmD,EAAE,GAAG,EAAE;QAC5D,MAAM,CAAC,GAAG,IAAI,IAAI,CAAC,KAAK,EAAE,CAAC,EAAE,CAAC,CAAC,CAAC;QAChC,MAAM,KAAK,GAAG,CAAC,CAAC,MAAM,CAAC,EAAE,CAAC,CAAC;QAC3B,CAAC,CAAC,OAAO,CAAC,KAAK,CAAC,CAAC;QACjB,MAAM,MAAM,GAAG,CAAC,CAAC,MAAM,CAAC,EAAE,CAAC,CAAC;QAC5B,MAAM,CAAC,cAAc,CACpB,MAAM,EACN,KAAK,EACL,6DAA6D,CAC7D,CAAC;IACH,CAAC,CAAC,CAAC;AACJ,CAAC,CAAC,CAAC;AAEH,2EAA2E;AAE3E,QAAQ,CAAC,+DAA+D,EAAE,GAAG,EAAE;IAC9E,MAAM,KAAK,GAAG,OAAQ,UAAkB,CAAC,EAAE,KAAK,UAAU,CAAC;IAE3D,EAAE,CACD,0EAA0E,EAC1E,EAAE,IAAI,EAAE,CAAC,KAAK,CAAC,CAAC,CAAC,kEAAkE,CAAC,CAAC,CAAC,KAAK,EAAE,EAC7F,GAAG,EAAE;QACJ,8DAA8D;QAC9D,8DAA8D;QAC9D,gEAAgE;QAChE,4DAA4D;QAC5D,+DAA+D;QAC/D,wBAAwB;QACxB,MAAM,EAAE,GAAI,UAAkB,CAAC,EAAgB,CAAC;QAEhD,MAAM,CAAC,GAAG,IAAI,SAAS,EAAE,CAAC;QAC1B,MAAM,CAAC,GAAG,IAAI,IAAI,CAAC,cAAc,EAAE,CAAC,EAAE,CAAC,CAAC,CAAC;QACzC,CAAC,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC;QAEd,8DAA8D;QAC9D,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,GAAG,EAAE,CAAC,EAAE;YAAE,CAAC,CAAC,MAAM,CAAC,EAAE,CAAC,CAAC;QAC3C,EAAE,EAAE,CAAC;QACL,MAAM,QAAQ,GAAG,OAAO,CAAC,WAAW,EAAE,CAAC,QAAQ,CAAC;QAEhD,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,IAAI,EAAE,CAAC,EAAE;YAAE,CAAC,CAAC,MAAM,CAAC,EAAE,CAAC,CAAC;QAC5C,EAAE,EAAE,CAAC;QACL,MAAM,KAAK,GAAG,OAAO,CAAC,WAAW,EAAE,CAAC,QAAQ,CAAC;QAE7C,MAAM,CAAC,EAAE,CACR,KAAK,GAAG,QAAQ,GAAG,CAAC,EACpB,2DAA2D;YAC1D,aAAa,QAAQ,YAAY,KAAK,YAAY,CAAC,KAAK,GAAG,QAAQ,CAAC,CAAC,OAAO,CAAC,CAAC,CAAC,GAAG,CACnF,CAAC;IACH,CAAC,CACD,CAAC;AACH,CAAC,CAAC,CAAC","sourcesContent":["// Runtime regression tests for the long-running-session leak fixes.\n//\n// Replaces the source-grep file `src/tests/session-memory-leaks.test.ts`\n// (deleted in #4875, tracked as #4873). The previous tests asserted on\n// identifier presence (`_prevRender`, `_lastMessage`, `MAX_CHAT_COMPONENTS`)\n// in source — a regression that set `MAX_CHAT_COMPONENTS = Number.MAX_SAFE_INTEGER`\n// or replaced `setText` with an inline mutation would still pass.\n//\n// Each test below drives the actual component through a long-running scenario\n// and asserts on observable behaviour.\n\nimport { describe, it, mock, beforeEach, afterEach } from \"node:test\";\nimport assert from \"node:assert/strict\";\nimport { Container } from \"../../tui.js\";\nimport { Loader } from \"../loader.js\";\nimport { Text } from \"../text.js\";\n\ninterface MockTui {\n\trequestRender: ReturnType<typeof mock.fn>;\n}\n\nfunction makeMockTUI(): MockTui {\n\treturn { requestRender: mock.fn() };\n}\n\n// ─── Container render-skip ──────────────────────────────────────────────\n\ndescribe(\"Container.render skips work when output is unchanged\", () => {\n\tit(\"returns the SAME array reference across two renders with no changes\", () => {\n\t\t// The container caches `_prevRender` so doRender() can short-circuit\n\t\t// the post-processing (image-line scan, applyLineResets, line diffs).\n\t\t// The contract for the optimization is reference equality of the\n\t\t// returned array — that's what the consumer in tui.ts checks.\n\t\tconst c = new Container();\n\t\tc.addChild(new Text(\"hello\", 0, 0));\n\n\t\tconst first = c.render(20);\n\t\tconst second = c.render(20);\n\t\tassert.strictEqual(\n\t\t\tsecond,\n\t\t\tfirst,\n\t\t\t\"Container must return the same array reference when content is unchanged \" +\n\t\t\t\t\"(reference equality is the consumer-visible contract for the skip)\",\n\t\t);\n\t});\n\n\tit(\"returns a DIFFERENT array reference after addChild invalidates the cache\", () => {\n\t\t// If a regression caused `_prevRender` to never reset, downstream\n\t\t// rendering would skip post-processing for new components — visible\n\t\t// as missing/stale UI. Behaviourally we observe that adding a child\n\t\t// breaks the reference-equality contract on the next render.\n\t\tconst c = new Container();\n\t\tc.addChild(new Text(\"a\", 0, 0));\n\t\tconst first = c.render(20);\n\t\tc.addChild(new Text(\"b\", 0, 0));\n\t\tconst second = c.render(20);\n\t\tassert.notStrictEqual(\n\t\t\tsecond,\n\t\t\tfirst,\n\t\t\t\"adding a child must invalidate the cached render reference\",\n\t\t);\n\t});\n\n\tit(\"returns a different reference after content changes\", () => {\n\t\tconst t = new Text(\"hello\", 0, 0);\n\t\tconst c = new Container();\n\t\tc.addChild(t);\n\n\t\tconst first = c.render(20);\n\t\tt.setText(\"world\");\n\t\tconst second = c.render(20);\n\t\tassert.notStrictEqual(\n\t\t\tsecond,\n\t\t\tfirst,\n\t\t\t\"changing a child's text must produce a fresh array (not the cached one)\",\n\t\t);\n\t});\n});\n\n// ─── Loader frame isolation ─────────────────────────────────────────────\n\ndescribe(\"Loader does not mutate Text cache on every spinner tick\", () => {\n\tlet tui: MockTui;\n\tlet loader: Loader;\n\n\tbeforeEach(() => {\n\t\ttui = makeMockTUI();\n\t\tmock.timers.enable({ apis: [\"setInterval\"] });\n\t});\n\n\tafterEach(() => {\n\t\ttry {\n\t\t\tloader?.stop();\n\t\t} catch {\n\t\t\t/* best-effort */\n\t\t}\n\t\tmock.timers.reset();\n\t});\n\n\tit(\"does not invalidate Text's render cache across N spinner ticks\", () => {\n\t\t// Loader extends Text. Text caches its rendered lines keyed by\n\t\t// (text, width). The leak was: the old Loader called setText()\n\t\t// on every 80ms tick, which always cleared the cache, forcing a\n\t\t// re-wrap of the message text.\n\t\t// Behavioural test: render the loader, capture the cached array\n\t\t// reference returned by Text.render, advance many ticks, and\n\t\t// assert the underlying Text cache was NOT invalidated (we observe\n\t\t// this via reference equality of the cached lines slice in the\n\t\t// returned array — the second `result[*]` segment from super.render\n\t\t// stays identity-stable when the cache survives).\n\t\tloader = new Loader(tui as never, (s) => s, (s) => s, \"the-message\");\n\n\t\tconst before = loader.render(40);\n\t\t// Run 50 frame intervals — the spinner should rotate, but the\n\t\t// underlying message text wrapping must not change.\n\t\tmock.timers.tick(80 * 50);\n\t\tconst after = loader.render(40);\n\n\t\t// The message portion (everything after the first `\"\"` padding line\n\t\t// and after the spinner glyph + space prefix on the first content\n\t\t// line) must be byte-identical across renders.\n\t\tassert.equal(before.length, after.length, \"render shape stable across ticks\");\n\t\t// Trailing message lines (index 2 onwards) come straight from Text's\n\t\t// cache without any spinner mutation. They must be reference-equal\n\t\t// substrings — same string contents byte-for-byte.\n\t\tfor (let i = 2; i < before.length; i++) {\n\t\t\tassert.equal(\n\t\t\t\tafter[i],\n\t\t\t\tbefore[i],\n\t\t\t\t`message line ${i} must remain byte-identical across spinner ticks ` +\n\t\t\t\t\t`(cache must not be invalidated by frame rotation)`,\n\t\t\t);\n\t\t}\n\t});\n\n\tit(\"setMessage invalidates Text cache and a new message is reflected\", () => {\n\t\t// Quiescence is conditional on the message being unchanged — we\n\t\t// must still see updates when it actually changes. This is the\n\t\t// counter-test that prevents a false-positive \"cache always stable\"\n\t\t// fix that would freeze the loader text.\n\t\tloader = new Loader(tui as never, (s) => s, (s) => s, \"first\");\n\t\tconst beforeFirstRender = loader.render(40).join(\"\\n\");\n\t\tloader.setMessage(\"second\");\n\t\tconst afterChange = loader.render(40).join(\"\\n\");\n\t\tassert.ok(afterChange.includes(\"second\"), \"new message must render\");\n\t\tassert.ok(!afterChange.includes(\"first\") || beforeFirstRender !== afterChange,\n\t\t\t\"render output must change when message changes\");\n\t});\n});\n\n// ─── Text.setText early-return guard ────────────────────────────────────\n\ndescribe(\"Text.setText returns early when value is unchanged\", () => {\n\tit(\"does not invalidate the cached render when setText receives the same value\", () => {\n\t\t// The setText early-return is the runtime guard that keeps the\n\t\t// Loader-and-Text cache stable. We observe it via reference equality\n\t\t// of the rendered output across a setText(SAME) call.\n\t\tconst t = new Text(\"identical\", 0, 0);\n\t\tconst first = t.render(30);\n\t\tt.setText(\"identical\"); // same value — must NOT clear the cache\n\t\tconst second = t.render(30);\n\t\tassert.strictEqual(\n\t\t\tsecond,\n\t\t\tfirst,\n\t\t\t\"setText with an unchanged value must leave the render cache intact\",\n\t\t);\n\t});\n\n\tit(\"invalidates cache when the value actually changes\", () => {\n\t\tconst t = new Text(\"one\", 0, 0);\n\t\tconst first = t.render(30);\n\t\tt.setText(\"two\");\n\t\tconst second = t.render(30);\n\t\tassert.notStrictEqual(\n\t\t\tsecond,\n\t\t\tfirst,\n\t\t\t\"setText with a new value must produce a fresh render result\",\n\t\t);\n\t});\n});\n\n// ─── Heap growth bound (gated on --expose-gc) ───────────────────────────\n\ndescribe(\"Long-running render loop does not leak heap (forced-GC bound)\", () => {\n\tconst hasGc = typeof (globalThis as any).gc === \"function\";\n\n\tit(\n\t\t\"renders a Container 5000 times with stable heapUsed (within 2x baseline)\",\n\t\t{ skip: !hasGc ? \"requires --expose-gc to drive deterministic GC between snapshots\" : false },\n\t\t() => {\n\t\t\t// This is the on-the-wire memory-soak test. The naive version\n\t\t\t// (no forced GC) is flaky because Node's GC is opportunistic;\n\t\t\t// any background allocation can shift heapUsed past an absolute\n\t\t\t// bound. We instead force GC between snapshots and assert a\n\t\t\t// RELATIVE bound: post-iteration heap must be within 2x of the\n\t\t\t// post-warmup baseline.\n\t\t\tconst gc = (globalThis as any).gc as () => void;\n\n\t\t\tconst c = new Container();\n\t\t\tconst t = new Text(\"steady-state\", 0, 0);\n\t\t\tc.addChild(t);\n\n\t\t\t// Warm up so the JIT and any lazy initial allocations settle.\n\t\t\tfor (let i = 0; i < 200; i++) c.render(40);\n\t\t\tgc();\n\t\t\tconst baseline = process.memoryUsage().heapUsed;\n\n\t\t\tfor (let i = 0; i < 5000; i++) c.render(40);\n\t\t\tgc();\n\t\t\tconst after = process.memoryUsage().heapUsed;\n\n\t\t\tassert.ok(\n\t\t\t\tafter < baseline * 2,\n\t\t\t\t`heapUsed must stay within 2x baseline after 5000 renders ` +\n\t\t\t\t\t`(baseline=${baseline}B, after=${after}B, ratio=${(after / baseline).toFixed(2)})`,\n\t\t\t);\n\t\t},\n\t);\n});\n"]}

package/packages/pi-tui/src/components/__tests__/leak-fixes-runtime.test.ts

@@ -1,219 +0,0 @@
-// Runtime regression tests for the long-running-session leak fixes.
-//
-// Replaces the source-grep file `src/tests/session-memory-leaks.test.ts`
-// (deleted in #4875, tracked as #4873). The previous tests asserted on
-// identifier presence (`_prevRender`, `_lastMessage`, `MAX_CHAT_COMPONENTS`)
-// in source — a regression that set `MAX_CHAT_COMPONENTS = Number.MAX_SAFE_INTEGER`
-// or replaced `setText` with an inline mutation would still pass.
-//
-// Each test below drives the actual component through a long-running scenario
-// and asserts on observable behaviour.
-
-import { describe, it, mock, beforeEach, afterEach } from "node:test";
-import assert from "node:assert/strict";
-import { Container } from "../../tui.js";
-import { Loader } from "../loader.js";
-import { Text } from "../text.js";
-
-interface MockTui {
-	requestRender: ReturnType<typeof mock.fn>;
-}
-
-function makeMockTUI(): MockTui {
-	return { requestRender: mock.fn() };
-}
-
-// ─── Container render-skip ──────────────────────────────────────────────
-
-describe("Container.render skips work when output is unchanged", () => {
-	it("returns the SAME array reference across two renders with no changes", () => {
-		// The container caches `_prevRender` so doRender() can short-circuit
-		// the post-processing (image-line scan, applyLineResets, line diffs).
-		// The contract for the optimization is reference equality of the
-		// returned array — that's what the consumer in tui.ts checks.
-		const c = new Container();
-		c.addChild(new Text("hello", 0, 0));
-
-		const first = c.render(20);
-		const second = c.render(20);
-		assert.strictEqual(
-			second,
-			first,
-			"Container must return the same array reference when content is unchanged " +
-				"(reference equality is the consumer-visible contract for the skip)",
-		);
-	});
-
-	it("returns a DIFFERENT array reference after addChild invalidates the cache", () => {
-		// If a regression caused `_prevRender` to never reset, downstream
-		// rendering would skip post-processing for new components — visible
-		// as missing/stale UI. Behaviourally we observe that adding a child
-		// breaks the reference-equality contract on the next render.
-		const c = new Container();
-		c.addChild(new Text("a", 0, 0));
-		const first = c.render(20);
-		c.addChild(new Text("b", 0, 0));
-		const second = c.render(20);
-		assert.notStrictEqual(
-			second,
-			first,
-			"adding a child must invalidate the cached render reference",
-		);
-	});
-
-	it("returns a different reference after content changes", () => {
-		const t = new Text("hello", 0, 0);
-		const c = new Container();
-		c.addChild(t);
-
-		const first = c.render(20);
-		t.setText("world");
-		const second = c.render(20);
-		assert.notStrictEqual(
-			second,
-			first,
-			"changing a child's text must produce a fresh array (not the cached one)",
-		);
-	});
-});
-
-// ─── Loader frame isolation ─────────────────────────────────────────────
-
-describe("Loader does not mutate Text cache on every spinner tick", () => {
-	let tui: MockTui;
-	let loader: Loader;
-
-	beforeEach(() => {
-		tui = makeMockTUI();
-		mock.timers.enable({ apis: ["setInterval"] });
-	});
-
-	afterEach(() => {
-		try {
-			loader?.stop();
-		} catch {
-			/* best-effort */
-		}
-		mock.timers.reset();
-	});
-
-	it("does not invalidate Text's render cache across N spinner ticks", () => {
-		// Loader extends Text. Text caches its rendered lines keyed by
-		// (text, width). The leak was: the old Loader called setText()
-		// on every 80ms tick, which always cleared the cache, forcing a
-		// re-wrap of the message text.
-		// Behavioural test: render the loader, capture the cached array
-		// reference returned by Text.render, advance many ticks, and
-		// assert the underlying Text cache was NOT invalidated (we observe
-		// this via reference equality of the cached lines slice in the
-		// returned array — the second `result[*]` segment from super.render
-		// stays identity-stable when the cache survives).
-		loader = new Loader(tui as never, (s) => s, (s) => s, "the-message");
-
-		const before = loader.render(40);
-		// Run 50 frame intervals — the spinner should rotate, but the
-		// underlying message text wrapping must not change.
-		mock.timers.tick(80 * 50);
-		const after = loader.render(40);
-
-		// The message portion (everything after the first `""` padding line
-		// and after the spinner glyph + space prefix on the first content
-		// line) must be byte-identical across renders.
-		assert.equal(before.length, after.length, "render shape stable across ticks");
-		// Trailing message lines (index 2 onwards) come straight from Text's
-		// cache without any spinner mutation. They must be reference-equal
-		// substrings — same string contents byte-for-byte.
-		for (let i = 2; i < before.length; i++) {
-			assert.equal(
-				after[i],
-				before[i],
-				`message line ${i} must remain byte-identical across spinner ticks ` +
-					`(cache must not be invalidated by frame rotation)`,
-			);
-		}
-	});
-
-	it("setMessage invalidates Text cache and a new message is reflected", () => {
-		// Quiescence is conditional on the message being unchanged — we
-		// must still see updates when it actually changes. This is the
-		// counter-test that prevents a false-positive "cache always stable"
-		// fix that would freeze the loader text.
-		loader = new Loader(tui as never, (s) => s, (s) => s, "first");
-		const beforeFirstRender = loader.render(40).join("\n");
-		loader.setMessage("second");
-		const afterChange = loader.render(40).join("\n");
-		assert.ok(afterChange.includes("second"), "new message must render");
-		assert.ok(!afterChange.includes("first") || beforeFirstRender !== afterChange,
-			"render output must change when message changes");
-	});
-});
-
-// ─── Text.setText early-return guard ────────────────────────────────────
-
-describe("Text.setText returns early when value is unchanged", () => {
-	it("does not invalidate the cached render when setText receives the same value", () => {
-		// The setText early-return is the runtime guard that keeps the
-		// Loader-and-Text cache stable. We observe it via reference equality
-		// of the rendered output across a setText(SAME) call.
-		const t = new Text("identical", 0, 0);
-		const first = t.render(30);
-		t.setText("identical"); // same value — must NOT clear the cache
-		const second = t.render(30);
-		assert.strictEqual(
-			second,
-			first,
-			"setText with an unchanged value must leave the render cache intact",
-		);
-	});
-
-	it("invalidates cache when the value actually changes", () => {
-		const t = new Text("one", 0, 0);
-		const first = t.render(30);
-		t.setText("two");
-		const second = t.render(30);
-		assert.notStrictEqual(
-			second,
-			first,
-			"setText with a new value must produce a fresh render result",
-		);
-	});
-});
-
-// ─── Heap growth bound (gated on --expose-gc) ───────────────────────────
-
-describe("Long-running render loop does not leak heap (forced-GC bound)", () => {
-	const hasGc = typeof (globalThis as any).gc === "function";
-
-	it(
-		"renders a Container 5000 times with stable heapUsed (within 2x baseline)",
-		{ skip: !hasGc ? "requires --expose-gc to drive deterministic GC between snapshots" : false },
-		() => {
-			// This is the on-the-wire memory-soak test. The naive version
-			// (no forced GC) is flaky because Node's GC is opportunistic;
-			// any background allocation can shift heapUsed past an absolute
-			// bound. We instead force GC between snapshots and assert a
-			// RELATIVE bound: post-iteration heap must be within 2x of the
-			// post-warmup baseline.
-			const gc = (globalThis as any).gc as () => void;
-
-			const c = new Container();
-			const t = new Text("steady-state", 0, 0);
-			c.addChild(t);
-
-			// Warm up so the JIT and any lazy initial allocations settle.
-			for (let i = 0; i < 200; i++) c.render(40);
-			gc();
-			const baseline = process.memoryUsage().heapUsed;
-
-			for (let i = 0; i < 5000; i++) c.render(40);
-			gc();
-			const after = process.memoryUsage().heapUsed;
-
-			assert.ok(
-				after < baseline * 2,
-				`heapUsed must stay within 2x baseline after 5000 renders ` +
-					`(baseline=${baseline}B, after=${after}B, ratio=${(after / baseline).toFixed(2)})`,
-			);
-		},
-	);
-});

package/src/resources/extensions/gsd/auto-runtime-state.ts

@@ -1,51 +0,0 @@
-// GSD auto-mode runtime state
-import { AutoSession } from "./auto/session.js";
-import type { CurrentUnit } from "./auto/session.js";
-import {
-  isDeterministicPolicyError,
-  isQueuedUserMessageSkip,
-  isToolInvocationError,
-  markToolEnd as markTrackedToolEnd,
-  markToolStart as markTrackedToolStart,
-} from "./auto-tool-tracking.js";
-
-export const autoSession = new AutoSession();
-
-export type AutoRuntimeSnapshot = {
-  active: boolean;
-  paused: boolean;
-  currentUnit: CurrentUnit | null;
-  basePath: string;
-};
-
-export function getAutoRuntimeSnapshot(): AutoRuntimeSnapshot {
-  return {
-    active: autoSession.active,
-    paused: autoSession.paused,
-    currentUnit: autoSession.currentUnit ? { ...autoSession.currentUnit } : null,
-    basePath: autoSession.basePath,
-  };
-}
-
-export function isAutoActive(): boolean {
-  return autoSession.active;
-}
-
-export function isAutoPaused(): boolean {
-  return autoSession.paused;
-}
-
-export function markToolStart(toolCallId: string, toolName?: string): void {
-  markTrackedToolStart(toolCallId, autoSession.active, toolName);
-}
-
-export function markToolEnd(toolCallId: string): void {
-  markTrackedToolEnd(toolCallId);
-}
-
-export function recordToolInvocationError(toolName: string, errorMsg: string): void {
-  if (!autoSession.active) return;
-  if (isToolInvocationError(errorMsg) || isQueuedUserMessageSkip(errorMsg) || isDeterministicPolicyError(errorMsg)) {
-    autoSession.lastToolInvocationError = `${toolName}: ${errorMsg}`;
-  }
-}

package/src/resources/extensions/gsd/milestone-id-reservation.ts

@@ -1,47 +0,0 @@
-import { isDbAvailable, getAllMilestones } from "./gsd-db.js";
-import {
-  getReservedMilestoneIds,
-  milestoneIdSort,
-  nextMilestoneId,
-  reserveMilestoneId,
-} from "./milestone-ids.js";
-import { isReusableGhostMilestone } from "./state.js";
-
-function getDatabaseMilestoneIds(): string[] {
-  if (!isDbAvailable()) return [];
-  return getAllMilestones().map((milestone) => milestone.id);
-}
-
-/**
- * Generate the next milestone ID, accounting for DB rows and in-process
- * reservations, and reserve it.
- */
-export function nextMilestoneIdReserved(
-  existingIds: string[],
-  uniqueEnabled: boolean,
-  basePath?: string,
-): string {
-  const reservedIds = getReservedMilestoneIds();
-  const allIds = [
-    ...new Set([
-      ...existingIds,
-      ...reservedIds,
-      ...getDatabaseMilestoneIds(),
-    ]),
-  ];
-
-  if (basePath) {
-    const sorted = [...allIds].sort(milestoneIdSort);
-    for (const candidate of sorted) {
-      if (reservedIds.has(candidate)) continue;
-      if (isReusableGhostMilestone(basePath, candidate)) {
-        reserveMilestoneId(candidate);
-        return candidate;
-      }
-    }
-  }
-
-  const id = nextMilestoneId(allIds, uniqueEnabled);
-  reserveMilestoneId(id);
-  return id;
-}

package/src/resources/extensions/gsd/tests/deferred-milestone-dir-4996.test.ts

@@ -1,116 +0,0 @@
-// GSD Extension — Regression test for #4996: deferred milestone dir creation
-// Verifies that showHeadlessMilestoneCreation does not pre-create the milestone
-// directory before the discuss flow runs. The dir should only appear after a
-// writer (saveArtifactToDb / atomicWriteAsync) emits the first artifact.
-
-import { describe, it, beforeEach, afterEach } from "node:test";
-import assert from "node:assert/strict";
-import { mkdtempSync, mkdirSync, existsSync, rmSync, readFileSync } from "node:fs";
-import { dirname, join } from "node:path";
-import { tmpdir } from "node:os";
-import { fileURLToPath } from "node:url";
-
-import { isReusableGhostMilestone } from "../state.ts";
-import { nextMilestoneIdReserved } from "../milestone-id-reservation.ts";
-import { clearReservedMilestoneIds, findMilestoneIds } from "../milestone-ids.ts";
-import { invalidateAllCaches } from "../cache.ts";
-import { closeDatabase, openDatabase } from "../gsd-db.ts";
-
-const __dirname = dirname(fileURLToPath(import.meta.url));
-const GUIDED_FLOW_PATH = join(__dirname, "..", "guided-flow.ts");
-
-function getShowHeadlessBody(): string {
-  const source = readFileSync(GUIDED_FLOW_PATH, "utf-8");
-  const fnStart = source.indexOf("export async function showHeadlessMilestoneCreation");
-  assert.ok(fnStart > -1, "showHeadlessMilestoneCreation must exist in guided-flow.ts");
-  const nextExport = source.indexOf("\nexport ", fnStart + 1);
-  return source.slice(fnStart, nextExport === -1 ? source.length : nextExport);
-}
-
-function makeBase(prefix = "gsd-deferred-dir-"): string {
-  const base = mkdtempSync(join(tmpdir(), prefix));
-  mkdirSync(join(base, ".gsd", "milestones"), { recursive: true });
-  return base;
-}
-
-describe("showHeadlessMilestoneCreation source guard (#4996)", () => {
-  it("does not call mkdirSync in the headless milestone creation path", () => {
-    const body = getShowHeadlessBody();
-    assert.doesNotMatch(
-      body,
-      /\bmkdirSync\s*\(/,
-      "showHeadlessMilestoneCreation must not pre-create milestone directories",
-    );
-  });
-
-  it("does not call mkdir or mkdirp before dispatchWorkflow", () => {
-    const body = getShowHeadlessBody();
-    const dispatchIdx = body.indexOf("dispatchWorkflow");
-    assert.ok(dispatchIdx > -1, "dispatchWorkflow must be present");
-
-    const beforeDispatch = body.slice(0, dispatchIdx);
-    assert.doesNotMatch(
-      beforeDispatch,
-      /\b(?:mkdir|mkdirp)\s*\(/,
-      "showHeadlessMilestoneCreation must defer directory creation until artifact write",
-    );
-  });
-});
-
-describe("deferred milestone dir creation (#4996)", () => {
-  let base: string;
-
-  beforeEach(() => {
-    clearReservedMilestoneIds();
-  });
-
-  afterEach(() => {
-    try { closeDatabase(); } catch { /* ignore */ }
-    try { invalidateAllCaches(); } catch { /* ignore */ }
-    try { clearReservedMilestoneIds(); } catch { /* ignore */ }
-    try { rmSync(base, { recursive: true, force: true }); } catch { /* ignore */ }
-  });
-
-  it("(a) fresh project: milestones dir has no M001 entry before any discuss flow", () => {
-    base = makeBase();
-    const nextId = nextMilestoneIdReserved(findMilestoneIds(base), false, base);
-    assert.equal(nextId, "M001", "reservation should choose M001 for a fresh project");
-
-    const ids = findMilestoneIds(base);
-    assert.equal(ids.length, 0, "no milestone dirs should exist before any discuss flow");
-
-    // And specifically M001 should not exist
-    const m001Dir = join(base, ".gsd", "milestones", "M001");
-    assert.ok(!existsSync(m001Dir), "M001 dir must not exist before the discuss flow runs");
-  });
-
-  it("(b) abandoned discuss flow leaves no orphan: isReusableGhostMilestone returns false for non-existent dir", () => {
-    base = makeBase();
-    const nextId = nextMilestoneIdReserved(findMilestoneIds(base), false, base);
-    assert.equal(nextId, "M001", "reservation should not require a pre-created directory");
-
-    const m001Dir = join(base, ".gsd", "milestones", "M001");
-    assert.ok(!existsSync(m001Dir), "no M001 dir should exist");
-    assert.equal(isReusableGhostMilestone(base, "M001"), false, "non-existent milestone should not be reusable");
-    // findMilestoneIds only returns dirs that exist
-    const ids = findMilestoneIds(base);
-    assert.ok(!ids.includes("M001"), "M001 should not appear in findMilestoneIds when no dir exists");
-  });
-
-  it("(c) a stub dir left from a previous bug IS reusable but a newly-generated ID with no dir is not in the ghost list", () => {
-    base = makeBase();
-    openDatabase(join(base, ".gsd", "gsd.db"));
-    // Create a stub to represent a pre-existing phantom
-    mkdirSync(join(base, ".gsd", "milestones", "M001", "slices"), { recursive: true });
-
-    // isReusableGhostMilestone identifies the orphaned stub
-    assert.ok(isReusableGhostMilestone(base, "M001"), "pre-existing stub should be identified as reusable ghost");
-    const nextId = nextMilestoneIdReserved(findMilestoneIds(base), false, base);
-    assert.equal(nextId, "M001", "reservation should reuse the pre-existing ghost");
-
-    // The new ID (M002, which would be max+1 in this scenario but ghost reuse returns M001)
-    // should not have a dir
-    const m002Dir = join(base, ".gsd", "milestones", "M002");
-    assert.ok(!existsSync(m002Dir), "a freshly-requested ID should have no dir until first artifact write");
-  });
-});

package/src/resources/extensions/gsd/tests/doctor-orphan-milestone-4996.test.ts

@@ -1,100 +0,0 @@
-// GSD Extension — Regression test for #4996: doctor orphan milestone dir check
-// Verifies that checkRuntimeHealth reports orphan_milestone_dir for empty stub
-// dirs with no DB row, does not report populated dirs, and does not report
-// legitimate in-flight worktree-only milestone dirs.
-
-import { describe, it, afterEach } from "node:test";
-import assert from "node:assert/strict";
-import { mkdtempSync, mkdirSync, writeFileSync, rmSync } from "node:fs";
-import { join } from "node:path";
-import { tmpdir } from "node:os";
-
-import { checkRuntimeHealth } from "../doctor-runtime-checks.ts";
-import {
-  openDatabase,
-  closeDatabase,
-  insertMilestone,
-} from "../gsd-db.ts";
-import { invalidateAllCaches } from "../cache.ts";
-import type { DoctorIssue, DoctorIssueCode } from "../doctor-types.ts";
-
-function makeBase(prefix = "gsd-doctor-orphan-"): string {
-  const base = mkdtempSync(join(tmpdir(), prefix));
-  mkdirSync(join(base, ".gsd", "milestones"), { recursive: true });
-  return base;
-}
-
-function stubDir(base: string, mid: string): void {
-  mkdirSync(join(base, ".gsd", "milestones", mid, "slices"), { recursive: true });
-}
-
-function populateDir(base: string, mid: string): void {
-  mkdirSync(join(base, ".gsd", "milestones", mid), { recursive: true });
-  writeFileSync(join(base, ".gsd", "milestones", mid, `${mid}-CONTEXT.md`), `# ${mid}\n`);
-}
-
-describe("gsd_doctor orphan milestone directory check (#4996)", () => {
-  let base: string;
-
-  afterEach(() => {
-    try { closeDatabase(); } catch { /* ignore */ }
-    try { invalidateAllCaches(); } catch { /* ignore */ }
-    try { rmSync(base, { recursive: true, force: true }); } catch { /* ignore */ }
-  });
-
-  it("(a) empty stub dir with no DB row is reported as orphan_milestone_dir", async () => {
-    base = makeBase();
-    stubDir(base, "M003");
-
-    const issues: DoctorIssue[] = [];
-    const fixes: string[] = [];
-    await checkRuntimeHealth(base, issues, fixes, () => false);
-
-    const orphan = issues.find(i => i.code === "orphan_milestone_dir" && i.unitId === "M003");
-    assert.ok(orphan, "should report orphan_milestone_dir for empty stub");
-    assert.equal(orphan?.severity, "warning");
-    assert.equal(orphan?.fixable, true);
-    assert.ok(orphan?.message.includes("M003"), "message should name the milestone");
-  });
-
-  it("(b) populated milestone dir is NOT reported", async () => {
-    base = makeBase();
-    populateDir(base, "M001");
-
-    const issues: DoctorIssue[] = [];
-    const fixes: string[] = [];
-    await checkRuntimeHealth(base, issues, fixes, () => false);
-
-    const orphan = issues.find(i => i.code === "orphan_milestone_dir" && i.unitId === "M001");
-    assert.ok(!orphan, "populated milestone dir must not be reported as orphan");
-  });
-
-  it("(c) worktree-only milestone (no content files, no DB row, but worktree exists) is NOT reported", async () => {
-    base = makeBase();
-    stubDir(base, "M003");
-    // Simulate a legitimate in-flight worktree
-    mkdirSync(join(base, ".gsd", "worktrees", "M003"), { recursive: true });
-
-    const issues: DoctorIssue[] = [];
-    const fixes: string[] = [];
-    await checkRuntimeHealth(base, issues, fixes, () => false);
-
-    const orphan = issues.find(i => i.code === "orphan_milestone_dir" && i.unitId === "M003");
-    assert.ok(!orphan, "milestone with a worktree must not be reported as orphan");
-  });
-
-  it("(d) queued DB row (in-flight ID) is NOT reported as orphan", async () => {
-    base = makeBase();
-    stubDir(base, "M003");
-    const dbPath = join(base, ".gsd", "gsd.db");
-    openDatabase(dbPath);
-    insertMilestone({ id: "M003", status: "queued" });
-
-    const issues: DoctorIssue[] = [];
-    const fixes: string[] = [];
-    await checkRuntimeHealth(base, issues, fixes, () => false);
-
-    const orphan = issues.find(i => i.code === "orphan_milestone_dir" && i.unitId === "M003");
-    assert.ok(!orphan, "queued DB row must block orphan report (in-flight race protection)");
-  });
-});

package/src/resources/extensions/gsd/tests/ensure-preconditions-guard-4996.test.ts

@@ -1,93 +0,0 @@
-// GSD Extension — Regression test for #4996: ensurePreconditions phantom dir guard
-// Verifies that ensurePreconditions does not create milestone directories for
-// forward-referenced slice unit IDs when the milestone has no DB row.
-
-import { describe, it, afterEach } from "node:test";
-import assert from "node:assert/strict";
-import { mkdtempSync, mkdirSync, writeFileSync, existsSync, rmSync } from "node:fs";
-import { join } from "node:path";
-import { tmpdir } from "node:os";
-
-import { ensurePreconditions } from "../auto.ts";
-import {
-  openDatabase,
-  closeDatabase,
-  insertMilestone,
-} from "../gsd-db.ts";
-
-import type { GSDState } from "../types.ts";
-
-function makeBase(prefix = "gsd-precond-"): string {
-  const base = mkdtempSync(join(tmpdir(), prefix));
-  mkdirSync(join(base, ".gsd", "milestones"), { recursive: true });
-  return base;
-}
-
-function makeMinimalState(): GSDState {
-  return {
-    activeMilestone: null,
-    activeSlice: null,
-    activeTask: null,
-    phase: "planning",
-    recentDecisions: [],
-    blockers: [],
-    nextAction: "",
-    registry: [],
-  };
-}
-
-describe("ensurePreconditions phantom-dir guard (#4996)", () => {
-  let base: string;
-
-  afterEach(() => {
-    try { closeDatabase(); } catch { /* ignore */ }
-    try { rmSync(base, { recursive: true, force: true }); } catch { /* ignore */ }
-  });
-
-  it("(a) slice unit ID for unknown milestone does NOT create dirs when no DB row exists", () => {
-    base = makeBase();
-    const state = makeMinimalState();
-
-    ensurePreconditions("execute-task", "M003/S01", base, state);
-
-    const milestoneDir = join(base, ".gsd", "milestones", "M003");
-    assert.ok(!existsSync(milestoneDir), "M003 dir must not be created for phantom slice dispatch");
-  });
-
-  it("(b) slice unit ID for milestone with DB row DOES create dirs", () => {
-    base = makeBase();
-    const dbPath = join(base, ".gsd", "gsd.db");
-    openDatabase(dbPath);
-    insertMilestone({ id: "M003", status: "active" });
-    const state = makeMinimalState();
-
-    ensurePreconditions("execute-task", "M003/S01", base, state);
-
-    const milestoneDir = join(base, ".gsd", "milestones", "M003");
-    assert.ok(existsSync(milestoneDir), "M003 dir must be created when DB row exists");
-  });
-
-  it("(c) slice unit ID for existing milestone dir with CONTEXT.md content file uses normal scaffolding", () => {
-    base = makeBase();
-    const mid = "M003";
-    const milestoneDir = join(base, ".gsd", "milestones", mid);
-    mkdirSync(milestoneDir, { recursive: true });
-    writeFileSync(join(milestoneDir, `${mid}-CONTEXT.md`), "# Context\n");
-    const state = makeMinimalState();
-
-    ensurePreconditions("execute-task", "M003/S01", base, state);
-
-    const slicesDir = join(milestoneDir, "slices");
-    assert.ok(existsSync(slicesDir), "existing milestone dir should allow slice scaffolding");
-  });
-
-  it("(d) milestone-only unit ID (no slice) still creates dir even with no DB row", () => {
-    base = makeBase();
-    const state = makeMinimalState();
-
-    ensurePreconditions("discuss-milestone", "M003", base, state);
-
-    const milestoneDir = join(base, ".gsd", "milestones", "M003");
-    assert.ok(existsSync(milestoneDir), "M003 dir must be created for milestone-only dispatch");
-  });
-});