gsd-pi 2.78.1-dev.84a383f51 → 2.78.1

package/src/resources/extensions/gsd/state.ts

@@ -114,48 +114,6 @@ export function isGhostMilestone(basePath: string, mid: string): boolean {
   return !context && !draft && !roadmap && !summary;
 }
 
-/**
- * A "reusable ghost" milestone is an orphaned filesystem stub that is safe
- * to reclaim as the next milestone ID.
- *
- * Stricter than `isGhostMilestone`: returns true ONLY when ALL of the
- * following hold:
- *   1. No DB row exists for `mid` (any status, including "queued") — a DB row
- *      means the milestone was intentionally registered by
- *      `gsd_milestone_generate_id` and may have an in-flight discuss flow.
- *      Reusing it would collide with that flow. (#4996 race window)
- *   2. No worktree directory exists at `gsdRoot/worktrees/{mid}` — a worktree
- *      means the milestone is legitimately in-flight.
- *   3. No content files exist (CONTEXT, CONTEXT-DRAFT, ROADMAP, SUMMARY) —
- *      any content means the discuss flow already ran.
- *
- * The looser `isGhostMilestone` also classifies queued-row-without-content as
- * a ghost to help state queries filter phantoms. `isReusableGhostMilestone`
- * intentionally does NOT reclaim those — a queued row is sufficient proof of
- * a live in-flight ID reservation.
- *
- * Used by `nextMilestoneIdReserved` and both MCP ID-generator tools to fill
- * gaps left by phantom directories before resorting to max+1.
- */
-export function isReusableGhostMilestone(basePath: string, mid: string): boolean {
-  // Condition 1: no DB row (any status).
-  if (!isDbAvailable()) return false;
-  const dbRow = getMilestone(mid);
-  if (dbRow != null) return false;
-
-  // Condition 2: no worktree.
-  const root = gsdRoot(basePath);
-  const wtPath = join(root, 'worktrees', mid);
-  if (existsSync(wtPath)) return false;
-
-  // Condition 3: no content files.
-  const context = resolveMilestoneFile(basePath, mid, "CONTEXT");
-  const draft   = resolveMilestoneFile(basePath, mid, "CONTEXT-DRAFT");
-  const roadmap = resolveMilestoneFile(basePath, mid, "ROADMAP");
-  const summary = resolveMilestoneFile(basePath, mid, "SUMMARY");
-  return !context && !draft && !roadmap && !summary;
-}
-
 // ─── Query Functions ───────────────────────────────────────────────────────
 
 /**

package/src/resources/extensions/gsd/templates/PREFERENCES.md

@@ -39,7 +39,6 @@ dynamic_routing:
   budget_pressure:
   cross_provider:
   hooks:
-disabled_model_providers: []
 uok:
   enabled: true
   legacy_fallback:

package/src/resources/extensions/gsd/tests/auto-loop.test.ts

@@ -1,8 +1,5 @@
 import test, { mock } from "node:test";
 import assert from "node:assert/strict";
-import { mkdtempSync } from "node:fs";
-import { tmpdir } from "node:os";
-import { join } from "node:path";
 
 import {
   resolveAgentEnd,
@@ -29,24 +26,6 @@ function makeEvent(
   return { messages };
 }
 
-async function drainMicrotasks(turns = 20): Promise<void> {
-  for (let i = 0; i < turns; i++) {
-    await Promise.resolve();
-  }
-}
-
-async function waitForMicrotasks(
-  condition: () => boolean,
-  label: string,
-  turns = 500,
-): Promise<void> {
-  for (let i = 0; i < turns; i++) {
-    if (condition()) return;
-    await Promise.resolve();
-  }
-  assert.fail(`Timed out waiting for ${label}`);
-}
-
 /**
  * Build a minimal mock AutoSession with controllable newSession behavior.
  */
@@ -737,7 +716,7 @@ function makeLoopSession(overrides?: Partial<Record<string, unknown>>) {
     verbose: false,
     stepMode: false,
     paused: false,
-    basePath: mkdtempSync(join(tmpdir(), "gsd-auto-loop-")),
+    basePath: "/tmp/project",
     originalBasePath: "",
     currentMilestoneId: "M001",
     currentUnit: null,
@@ -757,7 +736,6 @@ function makeLoopSession(overrides?: Partial<Record<string, unknown>>) {
     unitRecoveryCount: new Map<string, number>(),
     verificationRetryCount: new Map<string, number>(),
     gitService: null,
-    lastRequestTimestamp: 0,
     autoStartTime: Date.now(),
     cmdCtx: {
       newSession: () => Promise.resolve({ cancelled: false }),
@@ -2383,161 +2361,6 @@ test("autoLoop warns but proceeds for greenfield project (no project files) (#18
   );
 });
 
-// ── Proactive rate limiting (#2996) ──────────────────────────────────────────
-
-test("autoLoop enforces min_request_interval_ms delay between LLM dispatches (#2996)", async () => {
-  _resetPendingResolve();
-  mock.timers.enable({ apis: ["Date", "setTimeout"], now: 1_000 });
-
-  try {
-    const ctx = makeMockCtx();
-    ctx.ui.setStatus = () => {};
-    ctx.sessionManager = { getSessionFile: () => "/tmp/session.json" };
-    const pi = makeMockPi();
-    const originalSendMessage = pi.sendMessage;
-    const dispatchTimestamps: number[] = [];
-    pi.sendMessage = (...args: unknown[]) => {
-      dispatchTimestamps.push(Date.now());
-      return originalSendMessage(...args);
-    };
-
-    let iterCount = 0;
-
-    const s = makeLoopSession();
-
-    const deps = makeMockDeps({
-      loadEffectiveGSDPreferences: () => ({
-        preferences: { min_request_interval_ms: 300 },
-      }),
-      deriveState: async () => {
-        iterCount++;
-        deps.callLog.push("deriveState");
-        return {
-          phase: "executing",
-          activeMilestone: { id: "M001", title: "Test", status: "active" },
-          activeSlice: { id: "S01", title: "Slice" },
-          activeTask: { id: "T01" },
-          registry: [{ id: "M001", status: "active" }],
-          blockers: [],
-        } as any;
-      },
-      postUnitPostVerification: async () => {
-        deps.callLog.push("postUnitPostVerification");
-        if (iterCount >= 2) {
-          s.active = false;
-        }
-        return "continue" as const;
-      },
-    });
-
-    const loopPromise = autoLoop(ctx, pi, s, deps);
-
-    await waitForMicrotasks(() => dispatchTimestamps.length === 1, "first dispatch");
-    resolveAgentEnd(makeEvent());
-    await waitForMicrotasks(
-      () => deps.callLog.filter((entry) => entry === "resolveDispatch").length >= 2,
-      "second dispatch planning",
-    );
-
-    await drainMicrotasks(100);
-    mock.timers.tick(299);
-    await drainMicrotasks(100);
-    assert.equal(dispatchTimestamps.length, 1, "second dispatch should wait for the configured interval");
-
-    mock.timers.tick(1);
-    await waitForMicrotasks(() => dispatchTimestamps.length === 2, "second dispatch");
-    resolveAgentEnd(makeEvent());
-
-    await loopPromise;
-
-    assert.ok(iterCount >= 2, `expected at least 2 iterations, got ${iterCount}`);
-    assert.ok(dispatchTimestamps.length >= 2, `expected at least 2 dispatches, got ${dispatchTimestamps.length}`);
-
-    assert.equal(
-      (s as any).lastRequestTimestamp,
-      dispatchTimestamps[1],
-      "lastRequestTimestamp should record the actual dispatch time",
-    );
-
-    const gap = dispatchTimestamps[1]! - dispatchTimestamps[0]!;
-    assert.equal(
-      gap,
-      300,
-      `gap between dispatches should match min_request_interval_ms=300 (got ${gap}ms)`,
-    );
-  } finally {
-    mock.timers.reset();
-  }
-});
-
-test("autoLoop skips rate-limit delay when min_request_interval_ms is 0 (default)", async () => {
-  _resetPendingResolve();
-  mock.timers.enable({ apis: ["Date", "setTimeout"], now: 2_000 });
-
-  try {
-    const ctx = makeMockCtx();
-    ctx.ui.setStatus = () => {};
-    ctx.sessionManager = { getSessionFile: () => "/tmp/session.json" };
-    const pi = makeMockPi();
-    const originalSendMessage = pi.sendMessage;
-    const dispatchTimestamps: number[] = [];
-    pi.sendMessage = (...args: unknown[]) => {
-      dispatchTimestamps.push(Date.now());
-      return originalSendMessage(...args);
-    };
-
-    let iterCount = 0;
-
-    const s = makeLoopSession();
-
-    const deps = makeMockDeps({
-      loadEffectiveGSDPreferences: () => ({
-        preferences: {},
-      }),
-      deriveState: async () => {
-        iterCount++;
-        deps.callLog.push("deriveState");
-        return {
-          phase: "executing",
-          activeMilestone: { id: "M001", title: "Test", status: "active" },
-          activeSlice: { id: "S01", title: "Slice" },
-          activeTask: { id: "T01" },
-          registry: [{ id: "M001", status: "active" }],
-          blockers: [],
-        } as any;
-      },
-      postUnitPostVerification: async () => {
-        deps.callLog.push("postUnitPostVerification");
-        if (iterCount >= 3) {
-          s.active = false;
-        }
-        return "continue" as const;
-      },
-    });
-
-    const loopPromise = autoLoop(ctx, pi, s, deps);
-
-    for (let i = 1; i <= 3; i++) {
-      await waitForMicrotasks(() => dispatchTimestamps.length === i, `dispatch ${i}`);
-      resolveAgentEnd(makeEvent());
-    }
-
-    await loopPromise;
-
-    assert.ok(iterCount >= 3, `expected at least 3 iterations, got ${iterCount}`);
-    assert.ok(dispatchTimestamps.length >= 3, `expected at least 3 dispatches, got ${dispatchTimestamps.length}`);
-
-    const gap = dispatchTimestamps[2]! - dispatchTimestamps[1]!;
-    assert.equal(
-      gap,
-      0,
-      `gap should be 0ms under mocked time without rate limiting (got ${gap}ms)`,
-    );
-  } finally {
-    mock.timers.reset();
-  }
-});
-
 // ─── #4850: pre-send model-policy block is non-retryable ────────────────────
 test("autoLoop classifies ModelPolicyDispatchBlockedError as blocked, not a retryable error", async () => {
   _resetPendingResolve();

package/src/resources/extensions/gsd/tests/auto-recovery.test.ts

@@ -731,64 +731,6 @@ test("hasImplementationArtifacts uses milestone path history instead of rolling
   }
 });
 
-test("hasImplementationArtifacts finds implementation commits when .gsd/ is gitignored (#5033)", () => {
-  const base = makeGitBase();
-  try {
-    // Simulate external/untracked .gsd/ via .git/info/exclude — milestone
-    // planning artifacts never enter git, but real implementation files do.
-    writeFileSync(join(base, ".git", "info", "exclude"), ".gsd/\n");
-    mkdirSync(join(base, ".gsd", "milestones", "M001", "slices", "S01", "tasks"), { recursive: true });
-    writeFileSync(
-      join(base, ".gsd", "milestones", "M001", "slices", "S01", "tasks", "T01-SUMMARY.md"),
-      "# Summary",
-    );
-
-    mkdirSync(join(base, "benchmarks", "M001"), { recursive: true });
-    writeFileSync(join(base, "benchmarks", "M001", "manifest.yaml"), "cases: []\n");
-
-    execFileSync("git", ["add", "."], { cwd: base, stdio: "ignore" });
-    execFileSync(
-      "git",
-      ["commit", "-m", "feat: materialize M001 evidence\n\nGSD-Task: S01/T01"],
-      { cwd: base, stdio: "ignore" },
-    );
-
-    const result = hasImplementationArtifacts(base, "M001");
-    assert.equal(
-      result,
-      "present",
-      "milestone-tagged commit binding must work when .gsd/ is gitignored",
-    );
-  } finally {
-    cleanup(base);
-  }
-});
-
-test("hasImplementationArtifacts ignores malformed milestone IDs in commit-message fallback", () => {
-  const base = makeGitBase();
-  try {
-    writeFileSync(join(base, ".git", "info", "exclude"), ".gsd/\n");
-    mkdirSync(join(base, "src"), { recursive: true });
-    writeFileSync(join(base, "src", "feature.ts"), "export function feature() {}\n");
-
-    execFileSync("git", ["add", "."], { cwd: base, stdio: "ignore" });
-    execFileSync(
-      "git",
-      ["commit", "-m", "feat: materialize M001(foo evidence\n\nGSD-Task: S01/T01"],
-      { cwd: base, stdio: "ignore" },
-    );
-
-    const result = hasImplementationArtifacts(base, "M001(");
-    assert.equal(
-      result,
-      "absent",
-      "malformed milestone IDs must not bind implementation commits through message scanning",
-    );
-  } finally {
-    cleanup(base);
-  }
-});
-
 test("hasImplementationArtifacts returns true on non-git directory (fail-open)", () => {
   const base = join(tmpdir(), `gsd-test-nogit-${randomUUID()}`);
   mkdirSync(base, { recursive: true });

package/src/resources/extensions/gsd/tests/auto-session-encapsulation.test.ts

@@ -18,7 +18,6 @@ import { fileURLToPath } from "node:url";
 const __dirname = dirname(fileURLToPath(import.meta.url));
 const AUTO_TS_PATH = join(__dirname, "..", "auto.ts");
 const SESSION_TS_PATH = join(__dirname, "..", "auto", "session.ts");
-const RUNTIME_STATE_TS_PATH = join(__dirname, "..", "auto-runtime-state.ts");
 
 function getAutoTsSource(): string {
   return readFileSync(AUTO_TS_PATH, "utf-8");
@@ -28,10 +27,6 @@ function getSessionTsSource(): string {
   return readFileSync(SESSION_TS_PATH, "utf-8");
 }
 
-function getRuntimeStateTsSource(): string {
-  return readFileSync(RUNTIME_STATE_TS_PATH, "utf-8");
-}
-
 // ── Invariant 1: No module-level mutable variables in auto.ts ────────────────
 
 test("auto.ts has no module-level let declarations", () => {
@@ -80,18 +75,18 @@ test("auto.ts has no module-level var declarations", () => {
 
 // ── Invariant 2: AutoSession singleton is the only mutable module-level binding ──
 
-test("auto-runtime-state.ts has exactly one module-level const for AutoSession", () => {
-  const source = getRuntimeStateTsSource();
+test("auto.ts has exactly one module-level const for AutoSession", () => {
+  const source = getAutoTsSource();
   const lines = source.split("\n");
 
   const sessionConsts = lines.filter(line =>
-    /^(export\s+)?const\s+\w+\s*=\s*new\s+AutoSession/.test(line),
+    /^const\s+\w+\s*=\s*new\s+AutoSession/.test(line),
   );
 
   assert.equal(
     sessionConsts.length,
     1,
-    `auto-runtime-state.ts should have exactly one \`const autoSession = new AutoSession()\`. ` +
+    `auto.ts should have exactly one \`const s = new AutoSession()\`. ` +
     `Found ${sessionConsts.length}: ${sessionConsts.join(", ")}`,
   );
 });
@@ -206,6 +201,7 @@ test("auto.ts module-level consts are only AutoSession instance, true constants,
 
   // Patterns that are acceptable at module level
   const allowedPatterns = [
+    /^const s = new AutoSession/,                 // The session singleton
     /^const [A-Z_]+\s*=/,                          // UPPER_CASE constants
     /^const \w+StateAccessors/,                    // Static accessor objects
     /^const \w+:\s*\w+\s*=/,                       // Typed constants

package/src/resources/extensions/gsd/tests/auto-supervisor.test.mjs

@@ -7,27 +7,10 @@ import { writeUnitRuntimeRecord, readUnitRuntimeRecord } from '../unit-runtime.t
 import { resolveAutoSupervisorConfig } from '../preferences.ts';
 
 test('resolveAutoSupervisorConfig provides safe timeout defaults', () => {
-  // Isolate from any developer ~/.gsd/PREFERENCES.md that overrides these
-  // defaults — the test pins what resolveAutoSupervisorConfig() returns when
-  // no preferences file exists, so it must not pick up the runner's home dir.
-  const previousGsdHome = process.env.GSD_HOME;
-  const previousCwd = process.cwd();
-  const isolated = mkdtempSync(join(tmpdir(), 'gsd-supervisor-defaults-'));
-  process.env.GSD_HOME = isolated;
-  process.chdir(isolated);
-  try {
-    const supervisor = resolveAutoSupervisorConfig();
-    assert.equal(supervisor.soft_timeout_minutes, 20);
-    assert.equal(supervisor.idle_timeout_minutes, 10);
-    assert.equal(supervisor.hard_timeout_minutes, 30);
-  } finally {
-    if (previousGsdHome === undefined) {
-      delete process.env.GSD_HOME;
-    } else {
-      process.env.GSD_HOME = previousGsdHome;
-    }
-    process.chdir(previousCwd);
-  }
+  const supervisor = resolveAutoSupervisorConfig();
+  assert.equal(supervisor.soft_timeout_minutes, 20);
+  assert.equal(supervisor.idle_timeout_minutes, 10);
+  assert.equal(supervisor.hard_timeout_minutes, 30);
 });
 
 test('writeUnitRuntimeRecord persists progress and recovery metadata defaults', () => {

package/src/resources/extensions/gsd/tests/bootstrap-derive-state-db-open.test.ts

@@ -32,7 +32,7 @@ describe("bootstrap deriveState DB guards (#3844)", () => {
     assert.ok(compactIdx > -1, "register-hooks should define session_before_compact");
     const compactSection = extractSourceRegion(registerHooksSrc, 'pi.on("session_before_compact"');
     const ensureIdx = compactSection.indexOf("ensureDbOpen()");
-    const deriveIdx = compactSection.indexOf("deriveGsdState(basePath)");
+    const deriveIdx = compactSection.indexOf("deriveState(basePath)");
     assert.ok(ensureIdx > -1, "session_before_compact should call ensureDbOpen()");
     assert.ok(deriveIdx > -1, "session_before_compact should derive state");
     assert.ok(ensureIdx < deriveIdx, "session_before_compact should open DB before deriveState");