gsd-pi 2.77.0-dev.eaa4973bc → 2.78.0-dev.aeeb2ca00

package/src/resources/extensions/gsd/tests/worker-model-override.test.ts

@@ -1,48 +1,56 @@
 /**
  * Worker model override — tests for parallel.worker_model preference.
  *
- * Verifies validation, resolveParallelConfig pass-through, and type definitions.
+ * Verifies validation accepts/rejects values and that resolveParallelConfig
+ * passes worker_model through from the raw preferences object.
  */
 
 import test from "node:test";
 import assert from "node:assert/strict";
-import { readFileSync } from "node:fs";
-import { join, dirname } from "node:path";
-import { fileURLToPath } from "node:url";
+import { validatePreferences } from "../preferences-validation.ts";
+import { resolveParallelConfig } from "../preferences.ts";
 
-const __dirname = dirname(fileURLToPath(import.meta.url));
-
-const typesSrc = readFileSync(join(__dirname, "..", "types.ts"), "utf-8");
-const validationSrc = readFileSync(join(__dirname, "..", "preferences-validation.ts"), "utf-8");
-const preferencesSrc = readFileSync(join(__dirname, "..", "preferences.ts"), "utf-8");
-
-// ─── Type definition ──────────────────────────────────────────────────────
+test("validatePreferences accepts valid worker_model string", () => {
+  const { preferences, errors } = validatePreferences({
+    parallel: { enabled: true, worker_model: "claude-3-5-sonnet" },
+  } as any);
+  assert.equal(errors.length, 0, `no errors expected, got ${JSON.stringify(errors)}`);
+  assert.equal(preferences.parallel?.worker_model, "claude-3-5-sonnet");
+});
 
-test("ParallelConfig includes worker_model optional field", () => {
+test("validatePreferences rejects empty worker_model with explicit error", () => {
+  const { errors } = validatePreferences({
+    parallel: { enabled: true, worker_model: "" },
+  } as any);
   assert.ok(
-    typesSrc.includes("worker_model?: string"),
-    "ParallelConfig should have optional worker_model field",
+    errors.some((e) => e.includes("parallel.worker_model") && e.includes("non-empty")),
+    `expected error mentioning parallel.worker_model, got ${JSON.stringify(errors)}`,
   );
 });
 
-// ─── Validation ───────────────────────────────────────────────────────────
-
-test("validatePreferences accepts valid worker_model string", () => {
+test("validatePreferences rejects non-string worker_model", () => {
+  const { errors } = validatePreferences({
+    parallel: { enabled: true, worker_model: 42 },
+  } as any);
   assert.ok(
-    validationSrc.includes("p.worker_model"),
-    "validation should check parallel.worker_model",
-  );
-  assert.ok(
-    validationSrc.includes('parallel.worker_model must be a non-empty string'),
-    "validation should reject invalid worker_model",
+    errors.some((e) => e.includes("parallel.worker_model")),
+    `expected error mentioning parallel.worker_model, got ${JSON.stringify(errors)}`,
   );
 });
 
-// ─── resolveParallelConfig ────────────────────────────────────────────────
+test("resolveParallelConfig passes worker_model through", () => {
+  const cfg = resolveParallelConfig({
+    parallel: { enabled: true, worker_model: "opus-4.7" },
+  } as any);
+  assert.equal(cfg.worker_model, "opus-4.7");
+});
 
-test("resolveParallelConfig passes through worker_model", () => {
-  assert.ok(
-    preferencesSrc.includes("worker_model: prefs?.parallel?.worker_model"),
-    "resolveParallelConfig should pass through worker_model",
-  );
+test("resolveParallelConfig leaves worker_model undefined when absent", () => {
+  const cfg = resolveParallelConfig({ parallel: { enabled: true } } as any);
+  assert.equal(cfg.worker_model, undefined);
+});
+
+test("resolveParallelConfig handles undefined prefs (worker_model undefined)", () => {
+  const cfg = resolveParallelConfig(undefined);
+  assert.equal(cfg.worker_model, undefined);
 });